From nobody Fri Apr 3 06:02:43 2026 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21CE130BBAB for ; Wed, 18 Feb 2026 04:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389477; cv=none; b=rISs4+NtmxYXVD+Ob+CxIe/jx3soapLC20yEsyr6c2ahZ3IJHrojXFc3p9mYl6ZUSD329FBbWcGLLWWbQbHUaRNvGGZRqYGgcT7vkBJtb89yiJyIa1MwKy56+Yheq1nYaTGtvyCHP/eLrKh9lKhBr3gWRM47DhvZEJ9mtNkRmRI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389477; c=relaxed/simple; bh=tavTc3XfhtYb3eP3dhZujArpuFQBikYBD/4KjS7zNUU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NYPIFdWOtD1a9yIiSMDd5wCjIjIQTTMWlQq05r0T7O/1SEXNAppAtgOlPAL7SkSRJr5Ourt5rN3oKHPVU6GUkMPNGpLYY7qbDuuAW/TRLYdbshcKdWFtMxdCmHWCbU5Qex2/jE0rwXFmsZBuDJjRRxPJsANEqwcnIAssN7Eax0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H9mE/YFr; arc=none smtp.client-ip=209.85.128.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H9mE/YFr" Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-79639c2d2b5so51712137b3.2 for ; Tue, 17 Feb 2026 20:37:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771389475; x=1771994275; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OGAhusucpz3XIU5gfM/bxCa/fDIiPoUBjtUt95RLBgs=; b=H9mE/YFrd++f8eCwADqnh2vS92o5JQsRIILntMgV2k73+f7j8BbQ8mB4z9qf9sVt8e MJFoMj9fAHnE/zmq98jOgHBpA4ICY2tsbmC/6ab5ueHKYzoDTKVe6ukmyHaaxdrWt17/ Kskgf7o5RlJ/v/r2uO9Ok8xJokTyHb9cuCUKjRj/T2YvftlOMHQwZXklvutIKiNBaOVt XmdPjRDi+WTpkoF3bMZd0+eSHbmjEWwV5iUef/hoWac32fqSdvD1d8a988EPYhGdYDD3 Tkis8HBu19go4InhwMNJcOmqNf7FYwEtYYxvWX0xfCDrDThn+rfm+3cFF/fJRxAuL1fR RsLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771389475; x=1771994275; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OGAhusucpz3XIU5gfM/bxCa/fDIiPoUBjtUt95RLBgs=; b=BAozulfKPAL7og1s1dlZ0m1iHfND21El1AicW7/IdTfrYuTtvBCJhC957jtIcGIpbN 8tHYeNGlEsxGIunmo+mHL8mQSc7c9lvZZn+dK7Vc51TXC2DS04xQvlXrGhIWSaI+ZXMM kfw7oIszOb1EI0LcbouVWBIbgWHo4EcaRHYV7qvG8VY4nlC/dnRFRwhr0VWsd9as34RH 0joCB/RyurPmr45K4aldmQ4gMNM05Mjt6fmWqu4UeKYik97wxzHRk9sALlQZttOXh/HM RvRtV+QWQH/x7z0Y1KwvuqNfcKvXbZCyBLLQ5zX9t00sFINXX+nr4HzSp9uDtz+NveMA BHaQ== X-Forwarded-Encrypted: i=1; AJvYcCXMD7f7Wi0ESRQVc3Yoh1dtsRey+fRqPVpHhj0F3eH8slmPHV5uGUBacJaIBJk6QzjgjLjr/GveTGkpbwM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/hKKFYw3SrDH0Hl2dMFUndl6ckrLBcbrJGFR0EfrtydcjHT70 4m3LED6A5ZZts6t0I45ZHAIMretukQfWa61fmbKKButU3aY+FLSh3kQVwKO1/+cIsoo= X-Gm-Gg: AZuq6aJZ7qKVbSP4mXpd7kVXvQCUD0vdctMah/q5NRKMcpZKJOmM8Aq5zlL06+iZSG0 m/paOm0eF+4ov3CCem0XwbaOJ/8yNCeZj0cjOJ6QgFHPmgTJ+dOp52Wuy5ebWcy60QGMSk24ao5 aD163nTfRu9TJYE2GAMsuB9MqZCd2hQL5+RiJYpnNP6OFrHa1nyz6C0N/jHX5z8VyoqOwSGu6rA DqU4KswBXTcOe5kRmDcKdtuG4YkpSsNMHq0c7v/lXOkQqoYx3uX6p0NhJDwoVLMwG3mxYu/UOf+ 7uaLOmygbFNxU/nQoEDsFq0mWycraeYYa5UVGSBPOUvmWNXm9NpuM3YwK7UbcQRXTR0BEEep6cd dsWmmyFb1MJ0gLm43GEziN5Q4iIGTHdcVshNyPlUNyh06Acg8RWQPF58JIUWeB2hkv9i0Hjmutn D1VmZCw+DgfDBOt2kxatC3LNMxZv9kJpVhBOntFUW+JSSMj+B9Qsx0NnGp+yNIOMyhgQczxDTVP T/TC+6iDGgNKCdzSMWznd+KF8ZmZ6rokDKSDIB0YE0= X-Received: by 2002:a05:690c:4d84:b0:796:5a14:87c3 with SMTP id 00721157ae682-7979e89a46amr145000827b3.40.1771389475050; Tue, 17 Feb 2026 20:37:55 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c23e4bdsm119850617b3.32.2026.02.17.20.37.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 20:37:54 -0800 (PST) From: Ethan Tidmore To: jic23@kernel.org, andy@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Ethan Tidmore Subject: [PATCH v4 9/9] iio: light: gp2ap020a00f: Join some lines of code to be a single line Date: Tue, 17 Feb 2026 22:37:28 -0600 Message-ID: <20260218043728.609659-10-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260218043728.609659-1-ethantidmore06@gmail.com> References: <20260218043728.609659-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Andy Shevchenko In some cases the wrapped lines are harder to follow. Join them despite being longer than 80 characters in some cases. Signed-off-by: Andy Shevchenko Signed-off-by: Ethan Tidmore --- v4: - Integrate Andy Shevchenko's cleanups. drivers/iio/light/gp2ap020a00f.c | 39 +++++++++++--------------------- 1 file changed, 13 insertions(+), 26 deletions(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a= 00f.c index 1867dacc0af6..e901a8c33609 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -175,10 +175,8 @@ #define GP2AP020A00F_CHAN_TIMESTAMP 3 =20 #define GP2AP020A00F_DATA_READY_TIMEOUT msecs_to_jiffies(1000) -#define GP2AP020A00F_DATA_REG(chan) (GP2AP020A00F_D0_L_REG + \ - (chan) * 2) -#define GP2AP020A00F_THRESH_REG(th_val_id) (GP2AP020A00F_TL_L_REG + \ - (th_val_id) * 2) +#define GP2AP020A00F_DATA_REG(chan) (GP2AP020A00F_D0_L_REG + (chan) * 2) +#define GP2AP020A00F_THRESH_REG(th_val_id) (GP2AP020A00F_TL_L_REG + (th_va= l_id) * 2) #define GP2AP020A00F_THRESH_VAL_ID(reg_addr) ((reg_addr - 4) / 2) =20 #define GP2AP020A00F_SUBTRACT_MODE 0 @@ -390,20 +388,17 @@ static int gp2ap020a00f_set_operation_mode(struct gp2= ap020a00f_data *data, } =20 err =3D regmap_update_bits(data->regmap, GP2AP020A00F_ALS_REG, - GP2AP020A00F_PRST_MASK, opmode_regs_settings[op] - .als_reg); + GP2AP020A00F_PRST_MASK, opmode_regs_settings[op].als_reg); if (err < 0) return err; =20 err =3D regmap_update_bits(data->regmap, GP2AP020A00F_PS_REG, - GP2AP020A00F_INTTYPE_MASK, opmode_regs_settings[op] - .ps_reg); + GP2AP020A00F_INTTYPE_MASK, opmode_regs_settings[op].ps_reg); if (err < 0) return err; =20 err =3D regmap_update_bits(data->regmap, GP2AP020A00F_LED_REG, - GP2AP020A00F_PIN_MASK, opmode_regs_settings[op] - .led_reg); + GP2AP020A00F_PIN_MASK, opmode_regs_settings[op].led_reg); if (err < 0) return err; } @@ -861,8 +856,7 @@ static irqreturn_t gp2ap020a00f_thresh_event_handler(in= t irq, void *data) int thresh_val_id, ret; =20 /* Read interrupt flags */ - ret =3D regmap_read(priv->regmap, GP2AP020A00F_OP_REG, - &op_reg_val); + ret =3D regmap_read(priv->regmap, GP2AP020A00F_OP_REG, &op_reg_val); if (ret < 0) goto done; =20 @@ -874,8 +868,7 @@ static irqreturn_t gp2ap020a00f_thresh_event_handler(in= t irq, void *data) =20 /* Clear interrupt flags (if not in INTTYPE_PULSE mode) */ if (priv->cur_opmode !=3D GP2AP020A00F_OPMODE_PROX_DETECT) { - ret =3D regmap_write(priv->regmap, GP2AP020A00F_OP_REG, - op_reg_val); + ret =3D regmap_write(priv->regmap, GP2AP020A00F_OP_REG, op_reg_val); if (ret < 0) goto done; } @@ -972,8 +965,7 @@ static irqreturn_t gp2ap020a00f_trigger_handler(int irq= , void *data) } } =20 - iio_push_to_buffers_with_timestamp(indio_dev, priv->buffer, - pf->timestamp); + iio_push_to_buffers_with_timestamp(indio_dev, priv->buffer, pf->timestamp= ); done: iio_trigger_notify_done(indio_dev->trig); =20 @@ -1023,26 +1015,22 @@ static int gp2ap020a00f_write_event_val(struct iio_= dev *indio_dev, =20 switch (thresh_reg_l) { case GP2AP020A00F_TH_L_REG: - event_en =3D test_bit(GP2AP020A00F_FLAG_ALS_RISING_EV, - &data->flags); + event_en =3D test_bit(GP2AP020A00F_FLAG_ALS_RISING_EV, &data->flags); break; case GP2AP020A00F_TL_L_REG: - event_en =3D test_bit(GP2AP020A00F_FLAG_ALS_FALLING_EV, - &data->flags); + event_en =3D test_bit(GP2AP020A00F_FLAG_ALS_FALLING_EV, &data->flags); break; case GP2AP020A00F_PH_L_REG: if (val =3D=3D 0) return -EINVAL; =20 - event_en =3D test_bit(GP2AP020A00F_FLAG_PROX_RISING_EV, - &data->flags); + event_en =3D test_bit(GP2AP020A00F_FLAG_PROX_RISING_EV, &data->flags); break; case GP2AP020A00F_PL_L_REG: if (val =3D=3D 0) return -EINVAL; =20 - event_en =3D test_bit(GP2AP020A00F_FLAG_PROX_FALLING_EV, - &data->flags); + event_en =3D test_bit(GP2AP020A00F_FLAG_PROX_FALLING_EV, &data->flags); break; } =20 @@ -1526,8 +1514,7 @@ static void gp2ap020a00f_remove(struct i2c_client *cl= ient) struct device *dev =3D &client->dev; int err; =20 - err =3D gp2ap020a00f_set_operation_mode(data, - GP2AP020A00F_OPMODE_SHUTDOWN); + err =3D gp2ap020a00f_set_operation_mode(data, GP2AP020A00F_OPMODE_SHUTDOW= N); if (err < 0) dev_err(dev, "Failed to power off the device.\n"); =20 --=20 2.53.0