From nobody Fri Apr 3 04:40:02 2026 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11D7C2DEA64 for ; Wed, 18 Feb 2026 04:37:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389470; cv=none; b=BaOKjNRnHm/T29mCHF9xpFoD0yBWDv4ViImgxPTnmpmWbJ32jKuh7mlEy9DyZtwoT89DgkMCJQ0tdrBncw20ZLN1XEhp/cwb/3OU1c9y8LZ6aJq89iBXIoP09PqS/5Gld+jR7HYzab5WpM4hs5TcPWBmrI4vBC9DDcUFgbzpAHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389470; c=relaxed/simple; bh=//HHuTCerFcSwwiBqOvc0pkJJAPvk1SqJGx0RZE0gZU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kpZp8X1JXZb7NxwSd7tE5uzwJbnl2EfLXJBff7U5bENQz7sgim6eG/SkmJ6XFGCHjl4hNdDjMLjhVC0LAMLsMh2Oa4Nvkue4h97QsgbI9Q94DTRv8ghSH7pGWN0cz2K35vHe8Q7N/gewxTeqM9h/xK9OR3QIaTqMnA8/mK/Qqeo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cxz0hrhT; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cxz0hrhT" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-794fe698e36so44578527b3.2 for ; Tue, 17 Feb 2026 20:37:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771389468; x=1771994268; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CbCY9XCvRZytZp9MDEYN7XDbxm37YVD92nmqKbkfDRs=; b=Cxz0hrhT5bSD4YYpkEJnQGgg8IHpKKIA2q9vD4xzE2vadvbb42wHnK5opQlh2WzcDF sWuPe7+pyi2DWTbdOzGyBcjWYBtf6AQV7Zqz/tU3euGN/J9Ur222trEk+vR0CC3dwY8x 2B2TJjMxMS+mIVnvnPUsoQ3pQIl02to1suau8gzxi3p6lsgz3bZ7iO3urevjyZXaC80a oNxJOJEnhgb6xDT9YuaOJ5kgn2BT97fi0GIc2zD4b8VxcoaQxcUln4r1AEpgX37uk1qd yDvuR1YTU7XJZ7tp+NZ1czcHBp82u1K4kD4cCrLI/h10kJyCvNtfgGMrau/4QE1cOkKu d2Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771389468; x=1771994268; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CbCY9XCvRZytZp9MDEYN7XDbxm37YVD92nmqKbkfDRs=; b=uh0XeByukOOzE5PWardxVLymH0muTTw+nhzo3Gin6p/R6mK0bWiBj6k4/1RICexNaF 4XJeVz0VcgkItCdPyMHHINOBJRJQ7Ky/GedinJKcpqEcyIrylLPX9SKOZPwuOqCP0KpG 0krsQQLfc6k8CV+uhKMpQBkCE3Isu+Hp74oMpEHSYLPdTUCthf9Vx9+C2lt2zMz2yj0E JPQD9hVI4qI1/RPHNkthC5XPA9ROUmvuK4GLAZ2GE2KJ4hzI031n3r58n0fmo5IXcnEd 1Q6h9OLlPe4KfXJzwQICnRxPzQKhOJkfA5/BKpwwS4kN1G7tURSND0ShOGkCRIdGxjop QsSw== X-Forwarded-Encrypted: i=1; AJvYcCXwdwHGX5XV1eJRzxEil08Hu5fO5oqbkkBVLxE45L70T+bZmgimIzRKXb765TPHbo+0Po2IwlahGRPxfnw=@vger.kernel.org X-Gm-Message-State: AOJu0YxPK6Gred4JTS56NUMtwc2FyICtLCs29ipMwnVwVblz0k51ewi/ D8pNQe6cDzCOj4KCR160XatnW6cAnM4YEUBzHyGuOF+sh1dx5tYkAxrD X-Gm-Gg: AZuq6aJmoOI6wkmoc41Mv/KIz2wVeq3jHkRHqnH0sWfFV3VK/Qop8t06Z8HFkbdn9c4 0aoRlw+Dx6ah8Ih70Nd8An2AHYnQxBTVGA03IHL4fwoA9F3ajLt9xqPfCbDQGUyUIPvFrVEPyMi udcZIh3OKkyJBo1L5IPMx0acJyxbPx/hzFZD3sbydIESjG/M1hdJL1m8Qflfxor84crhl13S4pn RT9fFi6y8IqIo1yhMPReESbN6VM9AYESjLdwELD4DrKztqdsODJwFLeeDTorYuXK0a1QKu3rsxK dcHgCz6km6LLWISsUA8/GGUJSD1J2Uji3Ks8kS2gyr8xvg7ukviuSxZdgYKZfP9D27QZACDRQim RBJcxTjOFwqAWEGjO+2MUusF4y8UjmQbyUwh3aaqWlOQp1mEfCQ4YU2kcxn29zcM8k9AXzxRMSz WfAA+LNhxhXp0W2Z2quhsh0vv5LrRTcRCQuHr8Weoz3It/TthJKHpla25Co3aqM9ljuf1HaJd7k 1Zzln8NGztXQ8IRJiKQ7XU1JUK2A4FQT1jZSa0q0/8= X-Received: by 2002:a05:690c:6e11:b0:796:4bae:934b with SMTP id 00721157ae682-797f73f2bf8mr4193407b3.63.1771389468094; Tue, 17 Feb 2026 20:37:48 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c23e4bdsm119850617b3.32.2026.02.17.20.37.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 20:37:47 -0800 (PST) From: Ethan Tidmore To: jic23@kernel.org, andy@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v4 1/9] iio: light: gp2ap020a00f: simplify locking with guard() Date: Tue, 17 Feb 2026 22:37:20 -0600 Message-ID: <20260218043728.609659-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260218043728.609659-1-ethantidmore06@gmail.com> References: <20260218043728.609659-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the guard() cleanup handler to manage the device lock. This simplifies the code by removing the need for manual unlocking and goto error handling paths. Suggested-by: Jonathan Cameron Signed-off-by: Ethan Tidmore --- v4: - Remove whitespace between assignment and check. v3: - Remove Fixes: tag. - Added Smatch warning. v2: - Fixed gp2ap020a00f_get_thresh_reg() parameter alignment. - Removed unneeded whitespace between assignment and check. drivers/iio/light/gp2ap020a00f.c | 66 ++++++++++---------------------- 1 file changed, 20 insertions(+), 46 deletions(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a= 00f.c index c7df4b258e2c..91fdcb980111 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -31,6 +31,7 @@ * the other one. */ =20 +#include #include #include #include @@ -1024,17 +1025,13 @@ static int gp2ap020a00f_write_event_val(struct iio_= dev *indio_dev, bool event_en =3D false; u8 thresh_val_id; u8 thresh_reg_l; - int err =3D 0; =20 - mutex_lock(&data->lock); + guard(mutex)(&data->lock); =20 thresh_reg_l =3D gp2ap020a00f_get_thresh_reg(chan, dir); thresh_val_id =3D GP2AP020A00F_THRESH_VAL_ID(thresh_reg_l); - - if (thresh_val_id > GP2AP020A00F_THRESH_PH) { - err =3D -EINVAL; - goto error_unlock; - } + if (thresh_val_id > GP2AP020A00F_THRESH_PH) + return -EINVAL; =20 switch (thresh_reg_l) { case GP2AP020A00F_TH_L_REG: @@ -1046,30 +1043,23 @@ static int gp2ap020a00f_write_event_val(struct iio_= dev *indio_dev, &data->flags); break; case GP2AP020A00F_PH_L_REG: - if (val =3D=3D 0) { - err =3D -EINVAL; - goto error_unlock; - } + if (val =3D=3D 0) + return -EINVAL; + event_en =3D test_bit(GP2AP020A00F_FLAG_PROX_RISING_EV, &data->flags); break; case GP2AP020A00F_PL_L_REG: - if (val =3D=3D 0) { - err =3D -EINVAL; - goto error_unlock; - } + if (val =3D=3D 0) + return -EINVAL; + event_en =3D test_bit(GP2AP020A00F_FLAG_PROX_FALLING_EV, &data->flags); break; } =20 data->thresh_val[thresh_val_id] =3D val; - err =3D gp2ap020a00f_write_event_threshold(data, thresh_val_id, - event_en); -error_unlock: - mutex_unlock(&data->lock); - - return err; + return gp2ap020a00f_write_event_threshold(data, thresh_val_id, event_en); } =20 static int gp2ap020a00f_read_event_val(struct iio_dev *indio_dev, @@ -1081,23 +1071,16 @@ static int gp2ap020a00f_read_event_val(struct iio_d= ev *indio_dev, { struct gp2ap020a00f_data *data =3D iio_priv(indio_dev); u8 thresh_reg_l; - int err =3D IIO_VAL_INT; =20 - mutex_lock(&data->lock); + guard(mutex)(&data->lock); =20 thresh_reg_l =3D gp2ap020a00f_get_thresh_reg(chan, dir); - - if (thresh_reg_l > GP2AP020A00F_PH_L_REG) { - err =3D -EINVAL; - goto error_unlock; - } + if (thresh_reg_l > GP2AP020A00F_PH_L_REG) + return -EINVAL; =20 *val =3D data->thresh_val[GP2AP020A00F_THRESH_VAL_ID(thresh_reg_l)]; =20 -error_unlock: - mutex_unlock(&data->lock); - - return err; + return IIO_VAL_INT; } =20 static int gp2ap020a00f_write_prox_event_config(struct iio_dev *indio_dev, @@ -1165,7 +1148,7 @@ static int gp2ap020a00f_write_event_config(struct iio= _dev *indio_dev, enum gp2ap020a00f_cmd cmd; int err; =20 - mutex_lock(&data->lock); + guard(mutex)(&data->lock); =20 switch (chan->type) { case IIO_PROXIMITY: @@ -1186,8 +1169,6 @@ static int gp2ap020a00f_write_event_config(struct iio= _dev *indio_dev, err =3D -EINVAL; } =20 - mutex_unlock(&data->lock); - return err; } =20 @@ -1199,7 +1180,7 @@ static int gp2ap020a00f_read_event_config(struct iio_= dev *indio_dev, struct gp2ap020a00f_data *data =3D iio_priv(indio_dev); int event_en =3D 0; =20 - mutex_lock(&data->lock); + guard(mutex)(&data->lock); =20 switch (chan->type) { case IIO_PROXIMITY: @@ -1223,8 +1204,6 @@ static int gp2ap020a00f_read_event_config(struct iio_= dev *indio_dev, break; } =20 - mutex_unlock(&data->lock); - return event_en; } =20 @@ -1385,7 +1364,7 @@ static int gp2ap020a00f_buffer_postenable(struct iio_= dev *indio_dev) struct gp2ap020a00f_data *data =3D iio_priv(indio_dev); int i, err =3D 0; =20 - mutex_lock(&data->lock); + guard(mutex)(&data->lock); =20 /* * Enable triggers according to the scan_mask. Enabling either @@ -1413,15 +1392,12 @@ static int gp2ap020a00f_buffer_postenable(struct ii= o_dev *indio_dev) } =20 if (err < 0) - goto error_unlock; + return err; =20 data->buffer =3D kmalloc(indio_dev->scan_bytes, GFP_KERNEL); if (!data->buffer) err =3D -ENOMEM; =20 -error_unlock: - mutex_unlock(&data->lock); - return err; } =20 @@ -1430,7 +1406,7 @@ static int gp2ap020a00f_buffer_predisable(struct iio_= dev *indio_dev) struct gp2ap020a00f_data *data =3D iio_priv(indio_dev); int i, err =3D 0; =20 - mutex_lock(&data->lock); + guard(mutex)(&data->lock); =20 iio_for_each_active_channel(indio_dev, i) { switch (i) { @@ -1452,8 +1428,6 @@ static int gp2ap020a00f_buffer_predisable(struct iio_= dev *indio_dev) if (err =3D=3D 0) kfree(data->buffer); =20 - mutex_unlock(&data->lock); - return err; } =20 --=20 2.53.0 From nobody Fri Apr 3 04:40:02 2026 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E22C62EB5AF for ; Wed, 18 Feb 2026 04:37:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389471; cv=none; b=EPAVzjBn5tCZLT4HXhCSSbHkxGQW5kEncGt/8/XVd43V29AMoOccypLL5npdv7fiizmu54AcR8Cbrb+t8ddYci7IzOv6bYl4xgFtye+xDsDI5eV7RqlYFPiAOrewy5eN6KD6hE4fwrg6zXhptQs6LYlGdOz9ywH7H/XmYhPkwGU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389471; c=relaxed/simple; bh=pagHrvqBbwrKpiRdGecFFOqcw3gp13P/UHq0LoGCMuY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dxCVKdzcmjDo1oWcOH3+VXR1Ab1kcw8WsBzHEmEvQpPsC/pYx3pS9iZ9EfWkVfGzsibEKn04CVm7TqAram24c8/xO0VWo/oXFVYDRlsIfDwRfIY9ixbJ/z8apXY2uvhusL99ws2eDB2K+Pbwa0vDpCQZpjjbXJKW6fFw4tWpU94= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QdMZkTtl; arc=none smtp.client-ip=209.85.128.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QdMZkTtl" Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-794fe16d032so40776197b3.3 for ; Tue, 17 Feb 2026 20:37:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771389469; x=1771994269; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wbfCSCPWbYKBtZ/X2FNoHWhz4WNydDjl7xPuqNagV4U=; b=QdMZkTtlTqwOTj87ABapGsm8sl47ti8IVF1b4LHt7uLoSmuMI76nTmpvOPoiP8Pkr4 q+2wFzswPmvmQUbgV5jsX9IJWi7M/PujvhkvzN2eEWCpnSd8ss5XCBB/f/UEvd0IYsr8 LecZhBkGSGxqQFR5PIvac+c5QPgV9YvmynlQ+Wf8+tFYT4sKS6XfKCe6zht5+aGfN7cK F3IsPl3AqEX/l9S3VxB6cV+r9Dx1pzglQCOpXLaWtxpbQeECnnAxks9TGHuQn1MueomQ zeY4sd8JsaL2Ks6ebZ5apz3hBD8M9SHA0ZK5R6Sg64g9yO/T8I0Aeiosc7r//vL/IRjr St/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771389469; x=1771994269; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wbfCSCPWbYKBtZ/X2FNoHWhz4WNydDjl7xPuqNagV4U=; b=cDTKbOEl1lneSvcGUHlHUrKly1q9+z3oEfTXwzO9brVz4FOmIsrzxjb5w0ZGoRYeZa c4cJCDZhxryqInGVCnRER8n8ITsmwegIJq+RvnDc4uCxlsNBShonS5DQf0u6RbnEr3Sn q0XssovSd22Yo4PSb5+4vAOkb9VxNAmJihiPmcwpyHX5qdfJYPA8HsJn4erP9WPCSivh gOEglVX3DoC5uKzqU8XylTTOHg2VBrbfI6KexHTP1ae2fyszwKt4urREMBpRIZvp2eKg HmKkuFYSOWhcsimARBlos5rp8VdpHT6nlo2TCBybD7PAwmI1RilskaEO45DMOAfiCxvR F0TA== X-Forwarded-Encrypted: i=1; AJvYcCX7NypTKVhDhFDxLDCW/dQogbWDPI23JTo8jgV+41l3iZmvvbGX+j2dCLLreXlfT6W5sF62nXvS/3616R4=@vger.kernel.org X-Gm-Message-State: AOJu0YxiNmDRoJNvKgalZ+L8q4P+gQ9ow5D8qYX2bvWI0A+0dfi7ISof 7HmQ1mE/igfNWABiaYnr3H/i9LMtegdw6CjphhBxAbup7eQR5sLXRuf/ X-Gm-Gg: AZuq6aJaGlqS0ThIVCkygM+cpAdJLBebCSuFHTPNv2sRM/Wb0PR6GsSWHuiOaZ8UYbT 7+6BSmp4a3GgJrCv5swQv/1zYfwI/eIigEiJGD0ixcBQ9AGlD75y0Us834gOmexLceNgEBxjDCe dndHyTUj6bJljf4Yg3h7MCjOKLw0JiIqhOxm9Y39eHj1w0LBPMqnk4ewSdj6ARn+F9hSNsOjRrD VTsQVhlcm2dIYqZc73U7mxnykKRl6A98ynZ5VG+1QnpXV0gT03WpWGcFrEk4Ll7MGyYdB6D/HYD ukptwYlpr6OyuruSWkkkTabXsdZcQbGklBRJJVIjrphaquYOPrdFn5gaGdUvpyDgI4q4s20yCSU IxaLIdOpnLGRrwtcfzy9BXr8pijCOE+EDmfEHa5W026fQ9DNKJ1kTkyq9lVeQY/3cMtyiOOYPUb z5m5m3xXxCY54lESqgjkdae1/Dh/t7qitZg6g5VVOiodYwIgfnwDONQNUblf0PIOtcA2egB+Vsv 9UY3lh2rmNxu7mmTnvFiB0qv6VuhsD2YAvY3JMmadw= X-Received: by 2002:a05:690c:2607:b0:797:e0ec:b8df with SMTP id 00721157ae682-797f71c12a3mr4865877b3.18.1771389469023; Tue, 17 Feb 2026 20:37:49 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c23e4bdsm119850617b3.32.2026.02.17.20.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 20:37:48 -0800 (PST) From: Ethan Tidmore To: jic23@kernel.org, andy@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore , Andy Shevchenko Subject: [PATCH v4 2/9] iio: light: gp2ap020a00f: correct return type to int Date: Tue, 17 Feb 2026 22:37:21 -0600 Message-ID: <20260218043728.609659-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260218043728.609659-1-ethantidmore06@gmail.com> References: <20260218043728.609659-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gp2ap020a00f_get_thresh_reg() can return -EINVAL in its error path. Yet, the function has return type of u8. Added error checking for gp2ap020a00f_get_thresh_reg() return value. Detected by Smatch: drivers/iio/light/gp2ap020a00f.c:1013 gp2ap020a00f_get_thresh_reg() warn: signedness bug returning '(-22)' Reviewed-by: Andy Shevchenko Signed-off-by: Ethan Tidmore --- v4: - Added Reviewed-by: tag from Andy Shevchenko. v3: - Remove Fixes: tag. - Added Smatch warning. v2: - Fixed gp2ap020a00f_get_thresh_reg() parameter alignment. - Removed unneeded whitespace between assignment and check. drivers/iio/light/gp2ap020a00f.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a= 00f.c index 91fdcb980111..deca9fd77fdd 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -993,8 +993,8 @@ static irqreturn_t gp2ap020a00f_trigger_handler(int irq= , void *data) return IRQ_HANDLED; } =20 -static u8 gp2ap020a00f_get_thresh_reg(const struct iio_chan_spec *chan, - enum iio_event_direction event_dir) +static int gp2ap020a00f_get_thresh_reg(const struct iio_chan_spec *chan, + enum iio_event_direction event_dir) { switch (chan->type) { case IIO_PROXIMITY: @@ -1024,11 +1024,14 @@ static int gp2ap020a00f_write_event_val(struct iio_= dev *indio_dev, struct gp2ap020a00f_data *data =3D iio_priv(indio_dev); bool event_en =3D false; u8 thresh_val_id; - u8 thresh_reg_l; + int thresh_reg_l; =20 guard(mutex)(&data->lock); =20 thresh_reg_l =3D gp2ap020a00f_get_thresh_reg(chan, dir); + if (thresh_reg_l < 0) + return thresh_reg_l; + thresh_val_id =3D GP2AP020A00F_THRESH_VAL_ID(thresh_reg_l); if (thresh_val_id > GP2AP020A00F_THRESH_PH) return -EINVAL; @@ -1070,11 +1073,13 @@ static int gp2ap020a00f_read_event_val(struct iio_d= ev *indio_dev, int *val, int *val2) { struct gp2ap020a00f_data *data =3D iio_priv(indio_dev); - u8 thresh_reg_l; + int thresh_reg_l; =20 guard(mutex)(&data->lock); =20 thresh_reg_l =3D gp2ap020a00f_get_thresh_reg(chan, dir); + if (thresh_reg_l < 0) + return thresh_reg_l; if (thresh_reg_l > GP2AP020A00F_PH_L_REG) return -EINVAL; =20 --=20 2.53.0 From nobody Fri Apr 3 04:40:02 2026 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C27652FC881 for ; Wed, 18 Feb 2026 04:37:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389472; cv=none; b=uXqoQa/rJAIAvfzzM79x9Uj1UCAzcm7Iv5SSLIu1SHUK7R0xsz1dOYj2W/cWKgVu0RpRvYaCJGds8nmqBIzsvEnGwNArAR3tH7VQjz3LeahTY49evpVDJGqiKXmKfXH5ve14sTqdkOeROGTpvO9pqe0br70gfTiKC7DrvaWFkIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389472; c=relaxed/simple; bh=JoAZJDoiWPN35rMghHaD46+8b456UvXitcTsjZHErg8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YGAWIvv9DY6SqzsW0n4SOdOs8VgjKJH38C17zmdjvyyFiwGYWjk83qEjRiMGzS46k2spyOfsT55w9S9SsF4uOZ8BgPWlo0pSBy9GyTFoLPgtaTG2Au6huPdxSyxkUyP3bQnW2HStSSxC0Im7uietxqOsOndKvHdrRsy0ZRx/b/U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YipxEGCM; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YipxEGCM" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-7946a1f2430so40492457b3.1 for ; Tue, 17 Feb 2026 20:37:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771389470; x=1771994270; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kJMl8aGE3aksQFMSCHrKQEMvQMnBaLOVn3cqjYbpNCI=; b=YipxEGCMRfN7xJ5zU2tQ8QAPRJwIbewhxOZobfxH9hvKqrnSEIBcLAeiLMQf7LAsOb onJHEPkn1N8ciUi5xfmbHvv8f7jZRVBNXvdZAfgp7gavEoPWxrtnLqJDDCqhyRYM0AKj fzUm7VZzYsWqIo5UHqkaeBM4TATZ5+8S4x6KFT0Lh3hf+dyib93wgfZ/D4ghfcM7U7RK OPIK8q5/upEroc2WbvkLqoe35gnsTJawbdNWqk3fDPZOI0cFaLvldeJPDZh7O8KJgP/P LTytJ06046bfJMyyeeslERDJICZypQq9SVPbbT/Fk7NMADwAGNJOxJ7pkDKwXor7C7lm CR8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771389470; x=1771994270; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kJMl8aGE3aksQFMSCHrKQEMvQMnBaLOVn3cqjYbpNCI=; b=GCXSEwcO1QKDvCNPEDAlsz/Xl2QUmfgowsQ24WxGBatYAz2D1nEGKSLGYXFY6dYcDt SVm3lSu+qT3gET0CD8btBzPlQjaZdGl+dpOYh9Fmw3cJIBCJyWq3vN1tsH0sZ3fs34h5 D0DJxwFqCfh9vXJ382Dsx45xIANWNM4GjSgk8G8lsjbIhWlnaADvbVaGI0bjfa67BS+C vVMhrSh7DwAX1wxJY/3m8cI/BeCnJvXWmkVueMrStKlg5FtQP8QWocXEmlbn65uKEl2P 07Y7Zfo8xb9Go1g4+eVqdVkQWi+nOqmLe4aK9ni79rjUblCTdsx/XsMUqqJ7X0GWBVAM 6+vw== X-Forwarded-Encrypted: i=1; AJvYcCVvDuD8QX+qZPlZiQ9Ny/ImzI/hrksWxnyoRKJwx/TDiohrLqb5R6ux9NJ53o143UYYj11Rc1cUAYUXK2c=@vger.kernel.org X-Gm-Message-State: AOJu0YyxlTJvi6F8AE/7x7OqIPLBQQ09gWUni0UUQgch8Fqz24uo9kzD aUb+hHEcc6LBs4h5/4T2MyFtdAvNdnopJRu1LI2gNN3n8/XZoQ+J3g/B X-Gm-Gg: AZuq6aIuf5yJ65aN2P72/pEE271YYNEiDwmmqlxrDeTm2CmqGieGFOU/vkIn2v3AVNT lFST0LlFCRyV+NSyFTzqDnLlHnRtlbLLqc6oE9rEkUIh7r5xCYIE2E8YLpwLI8r1QrX5tMUke3O UFUijBPI4/WCOM78ocYjjyqAq5ojmBkI3l7vnbon6AQMWR8kRdUXH4TQGBt9DLjUmyI804Yo1xu GLgNQxWmavwuvRfVOr8OXgI/jLEaGTN8YNaQoul/fz3ZUDoCBHeMoY/Wp/JHxxh5rK0cX3+Qbx0 K1EMAgDy0T38Jl+PyOfqtWVxEqh8EpXgo2Tkv7Fdy0c/m+tk8K7bmpdOGuO+0sdxRyaJ6L7ES28 NGXbQLYuPrr+UIi2d5vDKkly2CauZsgs3slWYbyAE7n++UTljaGMEP8phAcTPuXT1yaSefCym/M wYwk/3pPstWFDh//URc2gawNFs7AR9Xo5/G/CeE1tLKInD0flHInSnEq1AxoZ9FFsSgI6ayeDCy 0SP2zWtMiDNFkWJrzdSKy0sM4qQ0a9TrMaZo742iDE= X-Received: by 2002:a05:690c:83:b0:796:2fde:5df3 with SMTP id 00721157ae682-797ac5d44f9mr92487807b3.40.1771389469689; Tue, 17 Feb 2026 20:37:49 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c23e4bdsm119850617b3.32.2026.02.17.20.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 20:37:49 -0800 (PST) From: Ethan Tidmore To: jic23@kernel.org, andy@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Ethan Tidmore Subject: [PATCH v4 3/9] iio: light: gp2ap020a00f: Use correct types for 16-bit LE data Date: Tue, 17 Feb 2026 22:37:22 -0600 Message-ID: <20260218043728.609659-4-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260218043728.609659-1-ethantidmore06@gmail.com> References: <20260218043728.609659-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Andy Shevchenko Instead of using byte arrays and then explicit castings, change the types of byte arrays to be __le16 and update the endianness conversions accordingly. Signed-off-by: Andy Shevchenko Signed-off-by: Ethan Tidmore --- v4: - Integrate Andy Shevchenko's cleanups. drivers/iio/light/gp2ap020a00f.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a= 00f.c index deca9fd77fdd..82b078f6a43d 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -462,7 +462,7 @@ static int gp2ap020a00f_write_event_threshold(struct gp= 2ap020a00f_data *data, =20 return regmap_bulk_write(data->regmap, GP2AP020A00F_THRESH_REG(th_val_id), - (u8 *)&thresh_buf, 2); + &thresh_buf, sizeof(thresh_buf)); } =20 static int gp2ap020a00f_alter_opmode(struct gp2ap020a00f_data *data, @@ -698,18 +698,18 @@ static int wait_conversion_complete_irq(struct gp2ap0= 20a00f_data *data) static int gp2ap020a00f_read_output(struct gp2ap020a00f_data *data, unsigned int output_reg, int *val) { - u8 reg_buf[2]; + __le16 reg_buf; int err; =20 err =3D wait_conversion_complete_irq(data); if (err < 0) dev_dbg(&data->client->dev, "data ready timeout\n"); =20 - err =3D regmap_bulk_read(data->regmap, output_reg, reg_buf, 2); + err =3D regmap_bulk_read(data->regmap, output_reg, ®_buf, sizeof(reg_b= uf)); if (err < 0) return err; =20 - *val =3D le16_to_cpup((__le16 *)reg_buf); + *val =3D le16_to_cpu(reg_buf); =20 return err; } @@ -867,8 +867,9 @@ static irqreturn_t gp2ap020a00f_thresh_event_handler(in= t irq, void *data) { struct iio_dev *indio_dev =3D data; struct gp2ap020a00f_data *priv =3D iio_priv(indio_dev); - u8 op_reg_flags, d0_reg_buf[2]; unsigned int output_val, op_reg_val; + __le16 d0_reg_buf; + u8 op_reg_flags; int thresh_val_id, ret; =20 /* Read interrupt flags */ @@ -896,11 +897,11 @@ static irqreturn_t gp2ap020a00f_thresh_event_handler(= int irq, void *data) * transition is required. */ ret =3D regmap_bulk_read(priv->regmap, GP2AP020A00F_D0_L_REG, - d0_reg_buf, 2); + &d0_reg_buf, sizeof(d0_reg_buf)); if (ret < 0) goto done; =20 - output_val =3D le16_to_cpup((__le16 *)d0_reg_buf); + output_val =3D le16_to_cpu(d0_reg_buf); =20 if (gp2ap020a00f_adjust_lux_mode(priv, output_val)) goto done; @@ -967,17 +968,15 @@ static irqreturn_t gp2ap020a00f_trigger_handler(int i= rq, void *data) int i, out_val, ret; =20 iio_for_each_active_channel(indio_dev, i) { - ret =3D regmap_bulk_read(priv->regmap, - GP2AP020A00F_DATA_REG(i), - &priv->buffer[d_size], 2); + ret =3D regmap_bulk_read(priv->regmap, GP2AP020A00F_DATA_REG(i), + &priv->buffer[d_size], 2); if (ret < 0) goto done; =20 if (i =3D=3D GP2AP020A00F_SCAN_MODE_LIGHT_CLEAR || i =3D=3D GP2AP020A00F_SCAN_MODE_LIGHT_IR) { - out_val =3D le16_to_cpup((__le16 *)&priv->buffer[d_size]); + out_val =3D get_unaligned_le16(&priv->buffer[d_size]); gp2ap020a00f_output_to_lux(priv, &out_val); - put_unaligned_le32(out_val, &priv->buffer[d_size]); d_size +=3D 4; } else { --=20 2.53.0 From nobody Fri Apr 3 04:40:02 2026 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FDC92FE076 for ; Wed, 18 Feb 2026 04:37:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389472; cv=none; b=dz39axFptKM570q96CiniC2Y3ZaGS1qO6+CTZcvLCOH6eyV9NmakMSGkcsS/jJsjPWhRNUxjd8ksjlP659oIt2UBpFa1kKCutShLeIN9xnhwGhSnGE3vtPwFd775RjXsTuHTpmjeOO/wx1MRnmdEZU/JraeSD4p1rw/Lrl6q4oc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389472; c=relaxed/simple; bh=XHQOu93rUWzl2Xuiv0/1QeO8Bne+xWmLq/eoABNV9Zs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LGfqINgwE66+5ZazC4wGXCW/er/5A5ZhjSCuKqQ/pNqfeAFls2sflSg+rP0ngR63zp1KgwGP1vyV5g9jeLUU5KucHWMVJBIiC2uhEi6FV+Us89W1tfAJnimLOkTos9s9h+ObgnibsnkN/oWbeZwQeqCQBliEjNs7pr1fNlX6V08= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ah5gQDW/; arc=none smtp.client-ip=209.85.128.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ah5gQDW/" Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-794719afcd4so45553617b3.1 for ; Tue, 17 Feb 2026 20:37:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771389470; x=1771994270; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=86olDjHGDGW+KJK4OjX2Af3Opw6yf5oy5qhYxKNHWxw=; b=ah5gQDW/crG9v/t0ugfgN8KpJWcG0EF5+uOCBbPTKleCwi4h70+3wqY6K+7bJY6sg8 mcyZHi+0a8RWkdTAStIhpGf3F9eELd1TkuvvrIU9cf4zZEilPWjEWAFTqlvSGOAoEzaJ UVjMlJY268v08D+0jdtImj9Jnrr+WWFqtb4k6a3VvpM9464rX3CilRxUOyOzp29mdNol 4mU7TK2QeEGPFwrI3SutrlLCeRs6NlPeItdET/EsVhzujTXQuH+xWpMzMmFyWViU+DG6 dHgKS9cB1IwxunWfAd1TsDIz8j9TuSfN9gerNzRNTDwFDSR1uCxSh8/6HsLE4qGXrvds AHNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771389470; x=1771994270; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=86olDjHGDGW+KJK4OjX2Af3Opw6yf5oy5qhYxKNHWxw=; b=PiKBo+hunBH12WQV6t97I9kk/LhJiFGMeWsFwOy7PT+m1pZiujFXGica7L30TxTjEi que/AdRYZen/YHZElKldfeIt2xop16/y5SCH58eRZxny9xKpLv1cobkdgDsc0YBSivZp THIDkoCUhPx9HA/XZxOSJ0XEtPP0zhAS2bSQk9FkcXPGb4dyVDihz9ke9hER3nzZDcsM Mr1F46ideNrkhrXoIKB2TQKLsO/NxnpaVpv0CGJQy1qLyHIr8NmVyCf9dt/eBtkLrEf+ i0uFK9zKCqgQq9QGKM5fbvmB7sf2+lkJ1tuiDe01bPb8dkf6/f9TMmQoX+1+Qj1A1SBI wV7g== X-Forwarded-Encrypted: i=1; AJvYcCXLJj2yHFr36+qzXzwMUXmhVLvianTgJnsKoJd9UzfrEWEAGudJ7LQuwLe6wzCW3cET9kvmImABNnP2DHY=@vger.kernel.org X-Gm-Message-State: AOJu0YwBLGsaOgpj1uM09L5n3wgzYj2Zt74oq41HVqxpyxlEIaqqSS52 WGR3Bn56IjNQCvTVzYJ1AVN1BS0Z7qZyGWRSv0Dh3gyuei1UmVA3ZYc/ X-Gm-Gg: AZuq6aJ00z8P7wdlN6hRA6j/nwsJlA+YdHoLv2YI9paM6HwEjkxc+T2RnD8Ct1zjkkI Py2QvlyPQm+LhAG90TDTrWl15KtXO/EckPUraBYcWN8eTO17PE8d26hRgfI6SBbHo0PaHrHyRid EPiiPSotalPEK/CMYuhnoSbP1Ysd0g43LqHfA4fflQ7tp/fIWEsEm/gY9Qw/s/CQ/KntcspyWzN 5TRb2E7TUOsRax6YlurXVPZIiVOROUjhPbjDZ3uRVL1YWhmszaeBxlcoWGuyMBa73d6tuve4SH3 HHBkZYHmcXr7dlIJunYOONByhAAALJx+DwshImNC/9FUbnSgB02TRu2jdlIgNfWfOeJh05EIKiJ +XlKln6JP/zfjDOr6RgnzOF+HDMY7fJX7oiiH9GeCrwEKq8EFPuiT8g8IvB9yerIT8xk3X2Rv9Y atYrCjclvI7nKs4sGYP4BGGHDHyC8zFemooUpBad7n3pqjKncwZA0ahG7OMZNzKNtpnqtdyT3Wx qfwtcSwPLhPkMKN9tZ2yAukyrcXKX9sk0Vc0vNnXZbJITyRRqNdOw== X-Received: by 2002:a05:690c:368e:b0:796:45d4:9e2d with SMTP id 00721157ae682-797a0cf98e5mr130383937b3.53.1771389470288; Tue, 17 Feb 2026 20:37:50 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c23e4bdsm119850617b3.32.2026.02.17.20.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 20:37:50 -0800 (PST) From: Ethan Tidmore To: jic23@kernel.org, andy@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Ethan Tidmore Subject: [PATCH v4 4/9] iio: light: gp2ap020a00f: Replace custom implementation of min() Date: Tue, 17 Feb 2026 22:37:23 -0600 Message-ID: <20260218043728.609659-5-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260218043728.609659-1-ethantidmore06@gmail.com> References: <20260218043728.609659-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Andy Shevchenko Replace custom implementation of min() to save a few lines of code. Signed-off-by: Andy Shevchenko Signed-off-by: Ethan Tidmore --- v4: - Integrate Andy Shevchenko's cleanups. drivers/iio/light/gp2ap020a00f.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a= 00f.c index 82b078f6a43d..4afdd22499f3 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -38,6 +38,7 @@ #include #include #include +#include #include #include #include @@ -45,6 +46,7 @@ #include #include #include + #include #include #include @@ -454,9 +456,7 @@ static int gp2ap020a00f_write_event_threshold(struct gp= 2ap020a00f_data *data, */ thresh_reg_val =3D data->thresh_val[th_val_id] / 16; else - thresh_reg_val =3D data->thresh_val[th_val_id] > 16000 ? - 16000 : - data->thresh_val[th_val_id]; + thresh_reg_val =3D min(data->thresh_val[th_val_id], 16000U); =20 thresh_buf =3D cpu_to_le16(thresh_reg_val); =20 --=20 2.53.0 From nobody Fri Apr 3 04:40:02 2026 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E3F73009EE for ; Wed, 18 Feb 2026 04:37:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389473; cv=none; b=D9DJX4BmZgW5Jpw1dfJVB7sxiWflZsb6q7e5YsMiPEK5Vr0idVhZTxIUo0TlEcG6eKWoavJ21Z2j9AaXoBfEJDJHnbxQa0O1UDxss2M9bbzw/0V1B2ShkWHqfv5NfktDpI7Gp2tv6SNB9L6SUu2S/r9Vc1EbVj0K7spGA8HyKVQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389473; c=relaxed/simple; bh=r1xsUjm742lN5OcNZYcSGZWAnGyO898ssLDUm4GqBiY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UctAkTyEr7cQSIbB3M54fa2l6YBWYaAPfNBoHTmhswchOv7tyB25dJhpsUVY2WagkSn0/7obrMpm3X0yLHIZzV1KQiMWpvJnbvZpwyW8VqIqRBZPfYfuf0RNVFdoKyJ9ZIpe4J/w8Ivc1wk/+dsx2jTvdi7sxn5C4oavVFlum3g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kTkTX8cF; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kTkTX8cF" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-790992528f6so42244797b3.1 for ; Tue, 17 Feb 2026 20:37:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771389471; x=1771994271; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TPEJTZQlZV/DMKRq+dAsxYEtRl3v2k/3xpS3no/6kB0=; b=kTkTX8cFWNjOQJK/wYtnCEroTXXWVuWYSKZcgHIy2WIw5cbmHYXy9CGhn7J1xF2xb7 XFXQFqUGe8ivWwJvWL6YmvsZWb7CA4gRY29/xajNhn5fF/t3FiqpUhegYjQggUnNSilo XzdzDetPWfli4jUKplQ9mh2BSRF4HPrbb4o+ChWa0MOki7rV7OXhILdNR2rrqw/DsZAd I3ujgX0A28MXD/NSz63RIoUCDnvf5ZT2bdvD3fjICdHJbPTICEy4ucjVfPLsGS3TaYBG n3fulTX6HngHRJl4Es6CqN2QbD77Ugn+co3JZMe/fskiXQFi7FlTBrW4wKZA2Bjp/6k1 IemA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771389471; x=1771994271; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TPEJTZQlZV/DMKRq+dAsxYEtRl3v2k/3xpS3no/6kB0=; b=ev1eK2zDNc8x1qLFZ13g4n5RlL9EwxaI/+qw9vMFnlQBwXgFbnvC3S/OQeXQV8wv7M 5hlKlu+44d6dOzWhqCbFAZy4bgbiX3v5tgUVKLq2LkGkDl1H1jlXpFa5KPuLlZ+rjPo+ Eg6tJFADB6bfiWgpX9he7DKWz5oVV9oGm8agBkINcL87+DBp+07Uv2xCx1gd/lxN5Wu8 /j+gNkH726bWP1bPf5LxWiT4AnNaolHQc0kgvYVnp3eTE0imEhDeoZlSnWvZWRqU5f+X Yq+7LNz5TFYSgeWuZO9oOj8ViQWCM95dIanCE/5F+Y+LWS/NbIGYKhaVo6EIVgR+/LZZ ODuA== X-Forwarded-Encrypted: i=1; AJvYcCVNEYyYPIZE0F8WnMOLXD7lVHvWyDuhVMQ14cMNnaVcJPnnzkTN4vC3JLaSbgwzktbAWuu/CNSmOYB0q1M=@vger.kernel.org X-Gm-Message-State: AOJu0YxnbYGuX6/v5Nc/xKTRV/AFhUXMYogc0TQ4XymKkBgDUs2l8JD+ Ss573b+2qI0ReLMiqd/8kAlCDi3bDGbfYjvy3iRTK5+BFmIKVL1ZnNU2 X-Gm-Gg: AZuq6aLq72cZSzb8MiKWYP1Fd7lLXPrxQxjt/icDLHRxFwjqZLgdv6AlqHuqWLfd2P2 4sZuR8gn3aun3PDnug8lXmT3ltMSYbJ7FcIfHbuQf/1lIAK/NVTxYNBfgW4vYzq/i6DSeFLeOVG HueZ7VYZNp6Q5Kxp7a7sUkQDJZZLsZnYhPJcL7+qd6X9GndN7bXu/q8UqL2ad2c/51ufcryJBXm zSwsrOrdIwKPwpWPyv5DMb7DzMG1MfYNNADw8FGiBQmjmw9D2L8WM8TLd60TyVQ9oXkdx2Zsmyh MqZ+ANFG0fz/BMkOGBFR0OzT7i67cnWsyg48Fea8balWFJIS6oA0FuOyAVtDJmdAwLmakw55CkJ QMS8x96zWZGw/aJBToMLnX2qd4Xb2Ocb0N0wkeQEF42Yz74qh38IdBc8QgmmMQ0U3TQab7Mktcv 4bfkLebOpDeYLEY4JquBA4wlBXp8MvZJHKQGyW/Jl0qnG1wyKIGltB8CnjQv0F+oTNE/f2hFE1i IAPQlQacez7d4eu9evh6Ds6JTYjelLNO0WzOjz6td4= X-Received: by 2002:a05:690c:4c01:b0:794:78d0:9b57 with SMTP id 00721157ae682-797f71ca8eamr5810567b3.16.1771389471041; Tue, 17 Feb 2026 20:37:51 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c23e4bdsm119850617b3.32.2026.02.17.20.37.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 20:37:50 -0800 (PST) From: Ethan Tidmore To: jic23@kernel.org, andy@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Ethan Tidmore Subject: [PATCH v4 5/9] iio: light: gp2ap020a00f: Return directly from the switch cases Date: Tue, 17 Feb 2026 22:37:24 -0600 Message-ID: <20260218043728.609659-6-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260218043728.609659-1-ethantidmore06@gmail.com> References: <20260218043728.609659-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Andy Shevchenko Return directly from the switch cases which makes code easier to follow. In some cases convert pieces to the standard pattern which also unifies it with the accepted kernel practices. By doing this, it appears to have fixed a preexisting bug, the variable err in gp2ap020a00f_buffer_predisable() is only checked once for errors after the for loop is finished. This could allow errors to be swallowed. Signed-off-by: Andy Shevchenko Signed-off-by: Ethan Tidmore --- v4: - Integrate Andy Shevchenko's cleanups. drivers/iio/light/gp2ap020a00f.c | 96 ++++++++++++-------------------- 1 file changed, 37 insertions(+), 59 deletions(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a= 00f.c index 4afdd22499f3..f9ff8bbbe5ec 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -494,27 +494,24 @@ static int gp2ap020a00f_alter_opmode(struct gp2ap020a= 00f_data *data, static int gp2ap020a00f_exec_cmd(struct gp2ap020a00f_data *data, enum gp2ap020a00f_cmd cmd) { - int err =3D 0; + int err; =20 switch (cmd) { case GP2AP020A00F_CMD_READ_RAW_CLEAR: if (data->cur_opmode !=3D GP2AP020A00F_OPMODE_SHUTDOWN) return -EBUSY; - err =3D gp2ap020a00f_set_operation_mode(data, + return gp2ap020a00f_set_operation_mode(data, GP2AP020A00F_OPMODE_READ_RAW_CLEAR); - break; case GP2AP020A00F_CMD_READ_RAW_IR: if (data->cur_opmode !=3D GP2AP020A00F_OPMODE_SHUTDOWN) return -EBUSY; - err =3D gp2ap020a00f_set_operation_mode(data, + return gp2ap020a00f_set_operation_mode(data, GP2AP020A00F_OPMODE_READ_RAW_IR); - break; case GP2AP020A00F_CMD_READ_RAW_PROXIMITY: if (data->cur_opmode !=3D GP2AP020A00F_OPMODE_SHUTDOWN) return -EBUSY; - err =3D gp2ap020a00f_set_operation_mode(data, + return gp2ap020a00f_set_operation_mode(data, GP2AP020A00F_OPMODE_READ_RAW_PROXIMITY); - break; case GP2AP020A00F_CMD_TRIGGER_CLEAR_EN: if (data->cur_opmode =3D=3D GP2AP020A00F_OPMODE_PROX_DETECT) return -EBUSY; @@ -522,16 +519,17 @@ static int gp2ap020a00f_exec_cmd(struct gp2ap020a00f_= data *data, err =3D gp2ap020a00f_alter_opmode(data, GP2AP020A00F_OPMODE_ALS, GP2AP020A00F_ADD_MODE); + else + err =3D 0; set_bit(GP2AP020A00F_FLAG_ALS_CLEAR_TRIGGER, &data->flags); - break; + return err; case GP2AP020A00F_CMD_TRIGGER_CLEAR_DIS: clear_bit(GP2AP020A00F_FLAG_ALS_CLEAR_TRIGGER, &data->flags); if (gp2ap020a00f_als_enabled(data)) break; - err =3D gp2ap020a00f_alter_opmode(data, + return gp2ap020a00f_alter_opmode(data, GP2AP020A00F_OPMODE_ALS, GP2AP020A00F_SUBTRACT_MODE); - break; case GP2AP020A00F_CMD_TRIGGER_IR_EN: if (data->cur_opmode =3D=3D GP2AP020A00F_OPMODE_PROX_DETECT) return -EBUSY; @@ -539,16 +537,17 @@ static int gp2ap020a00f_exec_cmd(struct gp2ap020a00f_= data *data, err =3D gp2ap020a00f_alter_opmode(data, GP2AP020A00F_OPMODE_ALS, GP2AP020A00F_ADD_MODE); + else + err =3D 0; set_bit(GP2AP020A00F_FLAG_ALS_IR_TRIGGER, &data->flags); - break; + return err; case GP2AP020A00F_CMD_TRIGGER_IR_DIS: clear_bit(GP2AP020A00F_FLAG_ALS_IR_TRIGGER, &data->flags); if (gp2ap020a00f_als_enabled(data)) break; - err =3D gp2ap020a00f_alter_opmode(data, + return gp2ap020a00f_alter_opmode(data, GP2AP020A00F_OPMODE_ALS, GP2AP020A00F_SUBTRACT_MODE); - break; case GP2AP020A00F_CMD_TRIGGER_PROX_EN: if (data->cur_opmode =3D=3D GP2AP020A00F_OPMODE_PROX_DETECT) return -EBUSY; @@ -556,13 +555,12 @@ static int gp2ap020a00f_exec_cmd(struct gp2ap020a00f_= data *data, GP2AP020A00F_OPMODE_PS, GP2AP020A00F_ADD_MODE); set_bit(GP2AP020A00F_FLAG_PROX_TRIGGER, &data->flags); - break; + return err; case GP2AP020A00F_CMD_TRIGGER_PROX_DIS: clear_bit(GP2AP020A00F_FLAG_PROX_TRIGGER, &data->flags); - err =3D gp2ap020a00f_alter_opmode(data, + return gp2ap020a00f_alter_opmode(data, GP2AP020A00F_OPMODE_PS, GP2AP020A00F_SUBTRACT_MODE); - break; case GP2AP020A00F_CMD_ALS_HIGH_EV_EN: if (test_bit(GP2AP020A00F_FLAG_ALS_RISING_EV, &data->flags)) return 0; @@ -576,9 +574,8 @@ static int gp2ap020a00f_exec_cmd(struct gp2ap020a00f_da= ta *data, return err; } set_bit(GP2AP020A00F_FLAG_ALS_RISING_EV, &data->flags); - err =3D gp2ap020a00f_write_event_threshold(data, + return gp2ap020a00f_write_event_threshold(data, GP2AP020A00F_THRESH_TH, true); - break; case GP2AP020A00F_CMD_ALS_HIGH_EV_DIS: if (!test_bit(GP2AP020A00F_FLAG_ALS_RISING_EV, &data->flags)) return 0; @@ -590,9 +587,8 @@ static int gp2ap020a00f_exec_cmd(struct gp2ap020a00f_da= ta *data, if (err < 0) return err; } - err =3D gp2ap020a00f_write_event_threshold(data, + return gp2ap020a00f_write_event_threshold(data, GP2AP020A00F_THRESH_TH, false); - break; case GP2AP020A00F_CMD_ALS_LOW_EV_EN: if (test_bit(GP2AP020A00F_FLAG_ALS_FALLING_EV, &data->flags)) return 0; @@ -606,9 +602,8 @@ static int gp2ap020a00f_exec_cmd(struct gp2ap020a00f_da= ta *data, return err; } set_bit(GP2AP020A00F_FLAG_ALS_FALLING_EV, &data->flags); - err =3D gp2ap020a00f_write_event_threshold(data, + return gp2ap020a00f_write_event_threshold(data, GP2AP020A00F_THRESH_TL, true); - break; case GP2AP020A00F_CMD_ALS_LOW_EV_DIS: if (!test_bit(GP2AP020A00F_FLAG_ALS_FALLING_EV, &data->flags)) return 0; @@ -620,9 +615,8 @@ static int gp2ap020a00f_exec_cmd(struct gp2ap020a00f_da= ta *data, if (err < 0) return err; } - err =3D gp2ap020a00f_write_event_threshold(data, + return gp2ap020a00f_write_event_threshold(data, GP2AP020A00F_THRESH_TL, false); - break; case GP2AP020A00F_CMD_PROX_HIGH_EV_EN: if (test_bit(GP2AP020A00F_FLAG_PROX_RISING_EV, &data->flags)) return 0; @@ -636,9 +630,8 @@ static int gp2ap020a00f_exec_cmd(struct gp2ap020a00f_da= ta *data, return err; } set_bit(GP2AP020A00F_FLAG_PROX_RISING_EV, &data->flags); - err =3D gp2ap020a00f_write_event_threshold(data, + return gp2ap020a00f_write_event_threshold(data, GP2AP020A00F_THRESH_PH, true); - break; case GP2AP020A00F_CMD_PROX_HIGH_EV_DIS: if (!test_bit(GP2AP020A00F_FLAG_PROX_RISING_EV, &data->flags)) return 0; @@ -647,9 +640,8 @@ static int gp2ap020a00f_exec_cmd(struct gp2ap020a00f_da= ta *data, GP2AP020A00F_OPMODE_SHUTDOWN); if (err < 0) return err; - err =3D gp2ap020a00f_write_event_threshold(data, + return gp2ap020a00f_write_event_threshold(data, GP2AP020A00F_THRESH_PH, false); - break; case GP2AP020A00F_CMD_PROX_LOW_EV_EN: if (test_bit(GP2AP020A00F_FLAG_PROX_FALLING_EV, &data->flags)) return 0; @@ -663,9 +655,8 @@ static int gp2ap020a00f_exec_cmd(struct gp2ap020a00f_da= ta *data, return err; } set_bit(GP2AP020A00F_FLAG_PROX_FALLING_EV, &data->flags); - err =3D gp2ap020a00f_write_event_threshold(data, + return gp2ap020a00f_write_event_threshold(data, GP2AP020A00F_THRESH_PL, true); - break; case GP2AP020A00F_CMD_PROX_LOW_EV_DIS: if (!test_bit(GP2AP020A00F_FLAG_PROX_FALLING_EV, &data->flags)) return 0; @@ -674,12 +665,11 @@ static int gp2ap020a00f_exec_cmd(struct gp2ap020a00f_= data *data, GP2AP020A00F_OPMODE_SHUTDOWN); if (err < 0) return err; - err =3D gp2ap020a00f_write_event_threshold(data, + return gp2ap020a00f_write_event_threshold(data, GP2AP020A00F_THRESH_PL, false); - break; } =20 - return err; + return 0; } =20 static int wait_conversion_complete_irq(struct gp2ap020a00f_data *data) @@ -1007,10 +997,8 @@ static int gp2ap020a00f_get_thresh_reg(const struct i= io_chan_spec *chan, else return GP2AP020A00F_TL_L_REG; default: - break; + return -EINVAL; } - - return -EINVAL; } =20 static int gp2ap020a00f_write_event_val(struct iio_dev *indio_dev, @@ -1182,33 +1170,23 @@ static int gp2ap020a00f_read_event_config(struct ii= o_dev *indio_dev, enum iio_event_direction dir) { struct gp2ap020a00f_data *data =3D iio_priv(indio_dev); - int event_en =3D 0; =20 guard(mutex)(&data->lock); =20 switch (chan->type) { case IIO_PROXIMITY: if (dir =3D=3D IIO_EV_DIR_RISING) - event_en =3D test_bit(GP2AP020A00F_FLAG_PROX_RISING_EV, - &data->flags); + return test_bit(GP2AP020A00F_FLAG_PROX_RISING_EV, &data->flags); else - event_en =3D test_bit(GP2AP020A00F_FLAG_PROX_FALLING_EV, - &data->flags); - break; + return test_bit(GP2AP020A00F_FLAG_PROX_FALLING_EV, &data->flags); case IIO_LIGHT: if (dir =3D=3D IIO_EV_DIR_RISING) - event_en =3D test_bit(GP2AP020A00F_FLAG_ALS_RISING_EV, - &data->flags); + return test_bit(GP2AP020A00F_FLAG_ALS_RISING_EV, &data->flags); else - event_en =3D test_bit(GP2AP020A00F_FLAG_ALS_FALLING_EV, - &data->flags); - break; + return test_bit(GP2AP020A00F_FLAG_ALS_FALLING_EV, &data->flags); default: - event_en =3D -EINVAL; - break; + return -EINVAL; } - - return event_en; } =20 static int gp2ap020a00f_read_channel(struct gp2ap020a00f_data *data, @@ -1366,7 +1344,7 @@ static const struct iio_info gp2ap020a00f_info =3D { static int gp2ap020a00f_buffer_postenable(struct iio_dev *indio_dev) { struct gp2ap020a00f_data *data =3D iio_priv(indio_dev); - int i, err =3D 0; + int i, err; =20 guard(mutex)(&data->lock); =20 @@ -1400,15 +1378,15 @@ static int gp2ap020a00f_buffer_postenable(struct ii= o_dev *indio_dev) =20 data->buffer =3D kmalloc(indio_dev->scan_bytes, GFP_KERNEL); if (!data->buffer) - err =3D -ENOMEM; + return -ENOMEM; =20 - return err; + return 0; } =20 static int gp2ap020a00f_buffer_predisable(struct iio_dev *indio_dev) { struct gp2ap020a00f_data *data =3D iio_priv(indio_dev); - int i, err =3D 0; + int i, err; =20 guard(mutex)(&data->lock); =20 @@ -1427,12 +1405,12 @@ static int gp2ap020a00f_buffer_predisable(struct ii= o_dev *indio_dev) GP2AP020A00F_CMD_TRIGGER_PROX_DIS); break; } + if (err) + return err; } =20 - if (err =3D=3D 0) - kfree(data->buffer); - - return err; + kfree(data->buffer); + return 0; } =20 static const struct iio_buffer_setup_ops gp2ap020a00f_buffer_setup_ops =3D= { --=20 2.53.0 From nobody Fri Apr 3 04:40:02 2026 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 799A22FF158 for ; Wed, 18 Feb 2026 04:37:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389474; cv=none; b=CeBTRetFdqYEj4NVljNjJepq/spC38PAumP49owRiN/rczd+ZiCTwkTdxzwjGyezUmIA8BPXSNKNFNZbdg9zVL/0e79HeGVB2rIRgPF3Rl5iFCWThQ69uuNcexMPLKpDgcI1Zk2/H1A2dX04sLI9OohufCdezUZNRaPqOX5qc9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389474; c=relaxed/simple; bh=I33BA+Xs3H2s+wN1ueVG8ItbqrqoSJ0FwZ0ktBaaB18=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RjH4Bb3E4JlLV1mel3e1NYsyKeocUYGCLiRLVEK1/IzgsWLR3GCbfomNDn5s5l+cJKR6yD5hkHCyzmOUkJqZ5hn0+hzxGsVqvNJ3cZy6yAMa3qs5zERXUDFnOqr8g7zSWw2qoQZy68LYLRjsCo4o7nrFI2PCdyoQSrWK2pg4JRY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d/hLL/Xb; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d/hLL/Xb" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-797ab169454so36543887b3.3 for ; Tue, 17 Feb 2026 20:37:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771389472; x=1771994272; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pj54F/VLsWjgNsa4Etjj+8Jo41r9O+F6M7507QFPSho=; b=d/hLL/XbveBythF4/YMkxXTX7oPkNEa8H29/dgw41c3ZXCxaVfxhdp9LxEK+5+UaT4 EwoHIy70s9Jss3NJaY4NxhQ43yFxQHiz49Pq2F4OX1ZxAswcjKwsTe5W0/nTwnFukAnV 4sy5AP9wALQtZVjbH59Cj2yDblmJkrVowYeSOC5wDokygzNrcbM1+YCjTtT/1ePoSYMl oFrih/uPmm83eXo6448/tDY13RpWn1N/9jeBcXciFfBiIynesn6M1jCt4vRiPq9UFQ5o rZZRGm24AihHHmN1b7lKSgE7huqU20ToSabya+pzb4gjkCW0+/X6ML+1Y5Y+HrStxZsQ I9Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771389472; x=1771994272; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pj54F/VLsWjgNsa4Etjj+8Jo41r9O+F6M7507QFPSho=; b=pmaq4VvAVqiJJbaIXvFdOzp73gumfBgxcGXtR6IuCaUfdwavO8AKVAzJS8+MxuQYqO cjBPFds3nAmDEhHO/CK+xKlgVr6U1JbVAPeWSlNM98CUuOyQXc5+iZxmMHD1w8KJ4Ojb t2xDHZce9l+kFLLtqnoPoElubsYPmNR8cfHdryBbhvUrCsH5xVTGsba9OCNA4Ia1y6r3 ETzIotUZpfnzoL5i3RWEwXD0pB6QU8mOS3ENnwvNWOzlzjugA/5m9Tgtt9QSapTq9s0p EmSJlgN/zmWyzWqGTPLqVDrXRBadaTMCBbrcnxC8JBVzA0pUoZKfzuptVjCYwg3zNV7q ktig== X-Forwarded-Encrypted: i=1; AJvYcCXyT1+x25SMhK2giYspx//xuEbEaiFSF6G6hZ9q/et+vVp6y0EAJnDJmsPcnhDwRafXDQxvplKD0s3FfGc=@vger.kernel.org X-Gm-Message-State: AOJu0YxpGOT3O4kfaUo8p6q24jm/ZPH5dfQ1+qOy1rpXYg6aB77al84j xMZxFGaNQRCd3XM1m/BAv0uZJr7Dy09Es6p/OhJrS6FmxQ/PxwZtjlwm X-Gm-Gg: AZuq6aL+CPSTlhtnFV7AbMP+GKvZtCT5EkO3gx4jGjrzpY31Q81/EwihS2urCQJ6PMQ Ks0oEJ76cO8jK1GrXdbgusEflvoIXDX2SXBwltGNFClAmuwkDkJo9bNgElyerKZMvOLY7qOLC71 1HI6L/anBBfrov1BO6ElO3poTS6VGyMgroFT7VqoDKtCst8gXuePs41uQVt0Fl6puCGxC851Jz8 OAf+Sr5p23uSwaHeWU1hBG5mDBw7tFjHkJmiNfNDofLWaL8/tts33c8XQ25J3T5CgnONQ6NUI2n px63goGcYNDz/zOIfqq1XqHRQxy9A2DFnAKzlczyzDAw68LDHxEtJGkQSH3LPNxmRH4n8dF4fZ/ 5rtxAKENAIsFvQ1QYKwG3t10+cBKMo3Esq/kOwkkLXW4CRwH9xvZlCiS/coASOZUe1DTLemarLe AJiKlU1Zy24ItF1T4jTaSBe+nbhLLvX/VXnrxBdkJg+a2i4Yq+KztvF8hxO//7trS+eucgfmqGR JvuOoOMIgQ7xaP5UpVUU2j3zXO4Ky5Tnb7l+C4nv1wCC09FqYDLPg== X-Received: by 2002:a05:690c:600d:b0:796:c34b:9b01 with SMTP id 00721157ae682-797ac62e274mr115747997b3.55.1771389472482; Tue, 17 Feb 2026 20:37:52 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c23e4bdsm119850617b3.32.2026.02.17.20.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 20:37:51 -0800 (PST) From: Ethan Tidmore To: jic23@kernel.org, andy@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Ethan Tidmore Subject: [PATCH v4 6/9] iio: light: gp2ap020a00f: Use temporary variable for struct device Date: Tue, 17 Feb 2026 22:37:25 -0600 Message-ID: <20260218043728.609659-7-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260218043728.609659-1-ethantidmore06@gmail.com> References: <20260218043728.609659-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Andy Shevchenko Use temporary variable for struct device to make code neater. Signed-off-by: Andy Shevchenko Signed-off-by: Ethan Tidmore --- v4: - Integrate Andy Shevchenko's cleanups. drivers/iio/light/gp2ap020a00f.c | 34 +++++++++++++++----------------- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a= 00f.c index f9ff8bbbe5ec..54b5d1993035 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -1192,6 +1192,7 @@ static int gp2ap020a00f_read_event_config(struct iio_= dev *indio_dev, static int gp2ap020a00f_read_channel(struct gp2ap020a00f_data *data, struct iio_chan_spec const *chan, int *val) { + struct device *dev =3D &data->client->dev; enum gp2ap020a00f_cmd cmd; int err; =20 @@ -1211,27 +1212,23 @@ static int gp2ap020a00f_read_channel(struct gp2ap02= 0a00f_data *data, =20 err =3D gp2ap020a00f_exec_cmd(data, cmd); if (err < 0) { - dev_err(&data->client->dev, - "gp2ap020a00f_exec_cmd failed\n"); - goto error_ret; + dev_err(dev, "gp2ap020a00f_exec_cmd failed\n"); + return err; } =20 err =3D gp2ap020a00f_read_output(data, chan->address, val); if (err < 0) - dev_err(&data->client->dev, - "gp2ap020a00f_read_output failed\n"); + dev_err(dev, "gp2ap020a00f_read_output failed\n"); =20 err =3D gp2ap020a00f_set_operation_mode(data, GP2AP020A00F_OPMODE_SHUTDOWN); if (err < 0) - dev_err(&data->client->dev, - "Failed to shut down the device.\n"); + dev_err(dev, "Failed to shut down the device.\n"); =20 if (cmd =3D=3D GP2AP020A00F_CMD_READ_RAW_CLEAR || cmd =3D=3D GP2AP020A00F_CMD_READ_RAW_IR) gp2ap020a00f_output_to_lux(data, val); =20 -error_ret: return err; } =20 @@ -1421,18 +1418,19 @@ static const struct iio_buffer_setup_ops gp2ap020a0= 0f_buffer_setup_ops =3D { static int gp2ap020a00f_probe(struct i2c_client *client) { const struct i2c_device_id *id =3D i2c_client_get_device_id(client); + struct device *dev =3D &client->dev; struct gp2ap020a00f_data *data; struct iio_dev *indio_dev; struct regmap *regmap; int err; =20 - indio_dev =3D devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; =20 data =3D iio_priv(indio_dev); =20 - data->vled_reg =3D devm_regulator_get(&client->dev, "vled"); + data->vled_reg =3D devm_regulator_get(dev, "vled"); if (IS_ERR(data->vled_reg)) return PTR_ERR(data->vled_reg); =20 @@ -1442,7 +1440,7 @@ static int gp2ap020a00f_probe(struct i2c_client *clie= nt) =20 regmap =3D devm_regmap_init_i2c(client, &gp2ap020a00f_regmap_config); if (IS_ERR(regmap)) { - dev_err(&client->dev, "Regmap initialization failed.\n"); + dev_err(dev, "Regmap initialization failed.\n"); err =3D PTR_ERR(regmap); goto error_regulator_disable; } @@ -1453,7 +1451,7 @@ static int gp2ap020a00f_probe(struct i2c_client *clie= nt) ARRAY_SIZE(gp2ap020a00f_reg_init_tab)); =20 if (err < 0) { - dev_err(&client->dev, "Device initialization failed.\n"); + dev_err(dev, "Device initialization failed.\n"); goto error_regulator_disable; } =20 @@ -1478,11 +1476,10 @@ static int gp2ap020a00f_probe(struct i2c_client *cl= ient) goto error_regulator_disable; =20 /* Allocate trigger */ - data->trig =3D devm_iio_trigger_alloc(&client->dev, "%s-trigger", - indio_dev->name); + data->trig =3D devm_iio_trigger_alloc(dev, "%s-trigger", indio_dev->name); if (data->trig =3D=3D NULL) { err =3D -ENOMEM; - dev_err(&indio_dev->dev, "Failed to allocate iio trigger.\n"); + dev_err(dev, "Failed to allocate iio trigger.\n"); goto error_uninit_buffer; } =20 @@ -1494,7 +1491,7 @@ static int gp2ap020a00f_probe(struct i2c_client *clie= nt) "gp2ap020a00f_als_event", indio_dev); if (err < 0) { - dev_err(&client->dev, "Irq request failed.\n"); + dev_err(dev, "Irq request failed.\n"); goto error_uninit_buffer; } =20 @@ -1502,7 +1499,7 @@ static int gp2ap020a00f_probe(struct i2c_client *clie= nt) =20 err =3D iio_trigger_register(data->trig); if (err < 0) { - dev_err(&client->dev, "Failed to register iio trigger.\n"); + dev_err(dev, "Failed to register iio trigger.\n"); goto error_free_irq; } =20 @@ -1528,12 +1525,13 @@ static void gp2ap020a00f_remove(struct i2c_client *= client) { struct iio_dev *indio_dev =3D i2c_get_clientdata(client); struct gp2ap020a00f_data *data =3D iio_priv(indio_dev); + struct device *dev =3D &client->dev; int err; =20 err =3D gp2ap020a00f_set_operation_mode(data, GP2AP020A00F_OPMODE_SHUTDOWN); if (err < 0) - dev_err(&indio_dev->dev, "Failed to power off the device.\n"); + dev_err(dev, "Failed to power off the device.\n"); =20 iio_device_unregister(indio_dev); iio_trigger_unregister(data->trig); --=20 2.53.0 From nobody Fri Apr 3 04:40:02 2026 Received: from mail-yx1-f44.google.com (mail-yx1-f44.google.com [74.125.224.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85766309F13 for ; Wed, 18 Feb 2026 04:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389475; cv=none; b=IlBquSivI3Nw7fIHIYkRa1vYMui6JgJ4751seSAdJ8BXJ/VhSm9Y9Xo5hotj66ognpO7v4vUR2RhpOX5ajIYTF6tbOEpopApBfCMkJ4dH3TxVK5W3RhF6jNH2JeYbInThyo8TkwCufMjDGx74sDxTYcoJRx+Crg9JeEGcFtHZ7Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389475; c=relaxed/simple; bh=HG5dUjtQLyGDOrqZYT1xGDVernYckHNW2qOjzxl3Ng0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NcfGaHArs2WihEsyYXVJ0urhL6jKYQAV9Qp+fWgzoDa3oolnASAs2IgGidoXWcADlYEfVwiLkUm7VvEe9Wu+Bg4x4Oeu8h4j33fE3Vez1H75jxmFSmDTqSXRtCECdok4wlj0572eXCXZdDe5QmPi/jzh613ZU9l94CiPmIHZWO8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UxbrEhxW; arc=none smtp.client-ip=74.125.224.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UxbrEhxW" Received: by mail-yx1-f44.google.com with SMTP id 956f58d0204a3-64acd19e1dfso4573017d50.0 for ; Tue, 17 Feb 2026 20:37:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771389473; x=1771994273; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Wl2rFlkvNIGjA5rJqtvMWZSPwA1P4J9Q1kL1RvIl0Xc=; b=UxbrEhxW9gb66OjfYzhnxP2/24CnXQxeOthJyzmLyJJSEQuT44n29Jjno1V6EvIXYi yqcDgwXBJZm6/Wi056ycdplr3meHIHBvcvaVAznH0lOH9erH9D6e0Q21ABRSn6Q3MLo7 K9z3VmRgOIeChORl5UP6JUheQCmGOZnjdgvQm+nET+6+HvIjElbfk5027zPGuHHjLP7F sxvOGBrex6CXjAIoLe98mHvFKDbEl7+LesZdprry/k5xcHEkq+uHjNkb2w5jsi4t2IWW hHmpd7xVFhzSojLJQP5cwEABKpeCJD4aLWLjopySgMKWPhQBgrRfcI8N1twVnVd6gE7x n5sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771389473; x=1771994273; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Wl2rFlkvNIGjA5rJqtvMWZSPwA1P4J9Q1kL1RvIl0Xc=; b=Ln9xSzQYlbdEaRGS1lHwXHNkuSdBIlI63IRhmaDWOnlSAdndpOgoAnOGavbyJXG4GO vUtQ//K5Hk89Gk7boh7w8kAmffQ9jxowyEBvhTsyKxvRrbsFsK/7mIMlGJuDjJo7gLFX flesmXOSlDGzQUtUC9mmailnTXc84my7g+O7DfAzuLKmXRDbfmFqJY5nvOU4Xtmk35vM NvtX3nem+GvjVJtFWvQvg95pB50CPv4utjITn8J/ryuGbtqr20IKz12Y0xgoggeKzF9D JLU/mDyG4K7M5T/wBkr4iwPTAhDVEFfcGf6CYThZgW4yPRoVvo/EdlxnyZYPTwkKOqFn 1zoQ== X-Forwarded-Encrypted: i=1; AJvYcCVTk9gqDmD8If/2VN05s/D5sVjuYpSoZGgzUTmPLT6OlC18NDpws4NQAy13YPl4ZP4AiAHU92KaxB4lM/E=@vger.kernel.org X-Gm-Message-State: AOJu0Ywq2ViCgoeeuNEXFZEcTNxJZAIjv/IVMDP58jUzKedIepX2LR3L 9Al5fnD2/jK495pA81BQU5yvSGNAFHfsxnbC7uYTM561HzD9or+r/hOAwG40/BTAv/w= X-Gm-Gg: AZuq6aKrEI1wYZxoSK/E9L8OXd9YSYpIlD82YeMb0cz9KgLtWoktI9kZ4LbeNGKNyS1 4NWxrkyWsxTcoMamitAGBszKueF5nGgYrU5iwUPIIkOrHrlan0HGr9+cIwOBgTk+y42ybJPqMOu Dm1nCzoEbABDTwBnmmmDx8QC0UobTfhOHJzL8kLTdVX1X5W/cNmN9XoREE/N8Q+3fSPjpmiOALU eu5n2ol9vTgDcgJuGUYx+DUU5vlPpJhqAcq8Tk8Zfd09ahXxIQpbyvZhuZSH02+WODMFqEJmvU/ WMwDQtIpMz9jCj36yVcitUuLBpo1cBRjbhXMMpJ26fJEkXSw3Xf9/MMySu//YGaNMyHB6larDFU 4xTs6QaTlJfS8gsANlKgRkuCzwPNoX8HNc06/c8Y8yh3FeKSJk0KtfKKOADX2Cd5XvpwZNg05Ik +AZ7APIHVBYRUY+qYxlHdpNTXjPGqK24G90/qGP3DPYQAPW5dsMLqmt16J3YdkkYRdrXmVZZAjj wV2FmEc0C5tP6ks1oZAs81nhhsZ133fyt+qfkU0LIU= X-Received: by 2002:a05:690e:1382:b0:64a:ef61:188d with SMTP id 956f58d0204a3-64c5557c9a4mr621442d50.11.1771389473414; Tue, 17 Feb 2026 20:37:53 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c23e4bdsm119850617b3.32.2026.02.17.20.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 20:37:53 -0800 (PST) From: Ethan Tidmore To: jic23@kernel.org, andy@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Ethan Tidmore Subject: [PATCH v4 7/9] iio: light: gp2ap020a00f: Explicitly use string literal for driver name Date: Tue, 17 Feb 2026 22:37:26 -0600 Message-ID: <20260218043728.609659-8-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260218043728.609659-1-ethantidmore06@gmail.com> References: <20260218043728.609659-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Andy Shevchenko The driver name should be easily greppable and clearly spelled. Replace a level of indirection and explicitly use string literal. While at it, remove useless blank lines before module_*() and MODULE_*() macros. Signed-off-by: Andy Shevchenko Signed-off-by: Ethan Tidmore --- v4: - Integrate Andy Shevchenko's cleanups. drivers/iio/light/gp2ap020a00f.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a= 00f.c index 54b5d1993035..d922cd4987ab 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -55,8 +55,6 @@ #include #include =20 -#define GP2A_I2C_NAME "gp2ap020a00f" - /* Registers */ #define GP2AP020A00F_OP_REG 0x00 /* Basic operations */ #define GP2AP020A00F_ALS_REG 0x01 /* ALS related settings */ @@ -1541,10 +1539,9 @@ static void gp2ap020a00f_remove(struct i2c_client *c= lient) } =20 static const struct i2c_device_id gp2ap020a00f_id[] =3D { - { GP2A_I2C_NAME }, + { "gp2ap020a00f" }, { } }; - MODULE_DEVICE_TABLE(i2c, gp2ap020a00f_id); =20 static const struct of_device_id gp2ap020a00f_of_match[] =3D { @@ -1555,14 +1552,13 @@ MODULE_DEVICE_TABLE(of, gp2ap020a00f_of_match); =20 static struct i2c_driver gp2ap020a00f_driver =3D { .driver =3D { - .name =3D GP2A_I2C_NAME, + .name =3D "gp2ap020a00f", .of_match_table =3D gp2ap020a00f_of_match, }, .probe =3D gp2ap020a00f_probe, .remove =3D gp2ap020a00f_remove, .id_table =3D gp2ap020a00f_id, }; - module_i2c_driver(gp2ap020a00f_driver); =20 MODULE_AUTHOR("Jacek Anaszewski "); --=20 2.53.0 From nobody Fri Apr 3 04:40:02 2026 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1405330B502 for ; Wed, 18 Feb 2026 04:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389476; cv=none; b=GVuvpzgVkiElfnufYxIVyNHwx1etS+vW2mrvAKE+6ONRUvPpkZKDgjSNJcv9S5C8Uzgh3xfmCm+f8UxtD8l9tCc6gZS9s20vxAoKyDaGRTEASAAXM9AW6Mk4+FuTIdfXVvuZ/hJ6WfAomAvQyviQZDABNYWDiPyeSt5ic3U8zPI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389476; c=relaxed/simple; bh=M6P2fOwaPfajnVICfkp43PSCExBZfZImFLdu1/EjtpE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jz14vUWPzyAoRij9hAlhTK8tPnm6hjpxp61XvbLxx/+NM54lyUwkbwEvre/oIBmfwYxI6n5YpnG4kFd2UI1HKVzRFHk43Mur6yfLscoZLWPjsmwNtzZId3oYWjq/WiTANGRNQEcHxyBv/Iy462dYJuFd3+v4ZSzoTAPZWNrZXVA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KlpVnxXB; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KlpVnxXB" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-794fe698e36so44578927b3.2 for ; Tue, 17 Feb 2026 20:37:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771389474; x=1771994274; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bzV4CSCJUqEmyPqip690W5uop12UNLhf6APilRzECSQ=; b=KlpVnxXB7NVpsnsWvuVLih5jtr4ix9tMjDzlVs+WmKyxeV7L1Yn2t0StGftD/miZZE J0wXrgrmLy7jLJHYlv/9rv1NSl/JrzWI2LLhII+KphcVhFYil3m/PkFrEwpskY4ebw03 bQnnx8kBBo460T9I6et78n/Hgn1+Uq55JdQY46rv8lHWAZLFwaVatY8dBBtZGPTPfG+q BdRmZozRcLj57e1Rru2utrNS/xPG3fUsWPtMwR3xVULSyUlHYUNwaIWjXCR8h7G0zUjQ BafDjs0Syu31IDtWk7bl05vmIYj2UTijBY9WBLhagsYiAu2DQhBPgr7mkkPRtXpjEj5v UJYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771389474; x=1771994274; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bzV4CSCJUqEmyPqip690W5uop12UNLhf6APilRzECSQ=; b=vONhn5nhr9CJAyd9DuTk96Fj59b/EHezRfWvgc2fED8/eHM4ReSDVq6SRRIhv1gCmj U+zQ4zF6/TGd0Pg6WOwKWkuL35a/w5OdPRo4oSR68cGzoJT1VTe0lm+9Q08jOyYqs2AT GJ+9NJ+jcxCiTpfBa/kQP4yAXrUD5YQTVYzpxkp7NKSWGBYZfByb7LLcTz/NW6tdaMvX 9qBuObFgFKx+roT4bGrcR1cDQ4GwozkCAvAgzSYnXalJWsTkeO19Uc2PV/cGVAbteCW5 EdcVUAMtnv8cptQLCFnFY+LXRIeZwVoYuKk68+VAUemb2gqKRI+Bqv3Nn6GQuuLuGB/S 3hhw== X-Forwarded-Encrypted: i=1; AJvYcCXipW9C0zyyWxz7tQg6bccxakLQU2loOFEFe/Lyy+hgp7f7iBHS5s+HMD7Ij871u3XHGZZPiBu6GjB0j04=@vger.kernel.org X-Gm-Message-State: AOJu0YxE26CUD8E8NHnhixr4Tu+f6WBgBCYgO5jSvklXQ3AW8FSI0FFk 2c7bheL9n8noTBXPBl7Ns+vJrHjMc56uzTwxryH8paU1rXDItGyLBgLo X-Gm-Gg: AZuq6aIyz7fcMudAdLHsoI/xKBLbolYMaETC3WjLaENkGUzwp4x28t0Zmo4pxzTSeSz 3CyjqA6gVdwbv6Mv8MV+OMzsfhMOkCY1Ie+03KK+UJ0uQS1fsT9wb/BP4VLGgQ1kp36kUzRXl9t FL3r+ps8fUJ8uCcuFgrRR9hUBsEsMassJlxzHgot0SHX+88kv29Vme5RF0sgusjZDHCT4aJutYf VhE9TeEz1K3EO7Syzl0WY6vch3CRME4kOX2bGUSGB0q640f5viHzknbGGr9EMoRrDSWBkM/EWMo /20HzOnKsdu3/0bsII7aD8Bbr/XhNQ8E9ZblsSfTKFAYX9ZxIDk+CXZ3wGbOGkaE/9tErYxXjZa WRpUEYQWG1mP6MQbdy7/6LOV3NGZsWj8fJe9Ovl27m6oEOx8yySWZOFjBan5x8OwUlEdpeSUniL bYTYglBzpBAoAajWELw5Pnui1QHN40zVtek55l56Z8JGmHW3Yo3IHmwblWshXld35q6KMkBq99e J/+WwkX5Ceu0QNnEF29iMDOu+h+xo2R69EKLNmXBzc= X-Received: by 2002:a05:690c:6e82:b0:794:ff27:df2c with SMTP id 00721157ae682-797f73b6411mr5118057b3.55.1771389474032; Tue, 17 Feb 2026 20:37:54 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c23e4bdsm119850617b3.32.2026.02.17.20.37.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 20:37:53 -0800 (PST) From: Ethan Tidmore To: jic23@kernel.org, andy@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Ethan Tidmore Subject: [PATCH v4 8/9] iio: light: gp2ap020a00f: Remove trailing comma in termination entry Date: Tue, 17 Feb 2026 22:37:27 -0600 Message-ID: <20260218043728.609659-9-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260218043728.609659-1-ethantidmore06@gmail.com> References: <20260218043728.609659-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Andy Shevchenko Termination entry by definition should be the last one, hence remove stray comma after it. Signed-off-by: Andy Shevchenko Signed-off-by: Ethan Tidmore --- v4: - Integrate Andy Shevchenko's cleanups. drivers/iio/light/gp2ap020a00f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a= 00f.c index d922cd4987ab..1867dacc0af6 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -195,7 +195,7 @@ enum gp2ap020a00f_opmode { GP2AP020A00F_OPMODE_ALS_AND_PS, GP2AP020A00F_OPMODE_PROX_DETECT, GP2AP020A00F_OPMODE_SHUTDOWN, - GP2AP020A00F_NUM_OPMODES, + GP2AP020A00F_NUM_OPMODES }; =20 enum gp2ap020a00f_cmd { --=20 2.53.0 From nobody Fri Apr 3 04:40:02 2026 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21CE130BBAB for ; Wed, 18 Feb 2026 04:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389477; cv=none; b=rISs4+NtmxYXVD+Ob+CxIe/jx3soapLC20yEsyr6c2ahZ3IJHrojXFc3p9mYl6ZUSD329FBbWcGLLWWbQbHUaRNvGGZRqYGgcT7vkBJtb89yiJyIa1MwKy56+Yheq1nYaTGtvyCHP/eLrKh9lKhBr3gWRM47DhvZEJ9mtNkRmRI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389477; c=relaxed/simple; bh=tavTc3XfhtYb3eP3dhZujArpuFQBikYBD/4KjS7zNUU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NYPIFdWOtD1a9yIiSMDd5wCjIjIQTTMWlQq05r0T7O/1SEXNAppAtgOlPAL7SkSRJr5Ourt5rN3oKHPVU6GUkMPNGpLYY7qbDuuAW/TRLYdbshcKdWFtMxdCmHWCbU5Qex2/jE0rwXFmsZBuDJjRRxPJsANEqwcnIAssN7Eax0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H9mE/YFr; arc=none smtp.client-ip=209.85.128.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H9mE/YFr" Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-79639c2d2b5so51712137b3.2 for ; Tue, 17 Feb 2026 20:37:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771389475; x=1771994275; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OGAhusucpz3XIU5gfM/bxCa/fDIiPoUBjtUt95RLBgs=; b=H9mE/YFrd++f8eCwADqnh2vS92o5JQsRIILntMgV2k73+f7j8BbQ8mB4z9qf9sVt8e MJFoMj9fAHnE/zmq98jOgHBpA4ICY2tsbmC/6ab5ueHKYzoDTKVe6ukmyHaaxdrWt17/ Kskgf7o5RlJ/v/r2uO9Ok8xJokTyHb9cuCUKjRj/T2YvftlOMHQwZXklvutIKiNBaOVt XmdPjRDi+WTpkoF3bMZd0+eSHbmjEWwV5iUef/hoWac32fqSdvD1d8a988EPYhGdYDD3 Tkis8HBu19go4InhwMNJcOmqNf7FYwEtYYxvWX0xfCDrDThn+rfm+3cFF/fJRxAuL1fR RsLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771389475; x=1771994275; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OGAhusucpz3XIU5gfM/bxCa/fDIiPoUBjtUt95RLBgs=; b=BAozulfKPAL7og1s1dlZ0m1iHfND21El1AicW7/IdTfrYuTtvBCJhC957jtIcGIpbN 8tHYeNGlEsxGIunmo+mHL8mQSc7c9lvZZn+dK7Vc51TXC2DS04xQvlXrGhIWSaI+ZXMM kfw7oIszOb1EI0LcbouVWBIbgWHo4EcaRHYV7qvG8VY4nlC/dnRFRwhr0VWsd9as34RH 0joCB/RyurPmr45K4aldmQ4gMNM05Mjt6fmWqu4UeKYik97wxzHRk9sALlQZttOXh/HM RvRtV+QWQH/x7z0Y1KwvuqNfcKvXbZCyBLLQ5zX9t00sFINXX+nr4HzSp9uDtz+NveMA BHaQ== X-Forwarded-Encrypted: i=1; AJvYcCXMD7f7Wi0ESRQVc3Yoh1dtsRey+fRqPVpHhj0F3eH8slmPHV5uGUBacJaIBJk6QzjgjLjr/GveTGkpbwM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/hKKFYw3SrDH0Hl2dMFUndl6ckrLBcbrJGFR0EfrtydcjHT70 4m3LED6A5ZZts6t0I45ZHAIMretukQfWa61fmbKKButU3aY+FLSh3kQVwKO1/+cIsoo= X-Gm-Gg: AZuq6aJZ7qKVbSP4mXpd7kVXvQCUD0vdctMah/q5NRKMcpZKJOmM8Aq5zlL06+iZSG0 m/paOm0eF+4ov3CCem0XwbaOJ/8yNCeZj0cjOJ6QgFHPmgTJ+dOp52Wuy5ebWcy60QGMSk24ao5 aD163nTfRu9TJYE2GAMsuB9MqZCd2hQL5+RiJYpnNP6OFrHa1nyz6C0N/jHX5z8VyoqOwSGu6rA DqU4KswBXTcOe5kRmDcKdtuG4YkpSsNMHq0c7v/lXOkQqoYx3uX6p0NhJDwoVLMwG3mxYu/UOf+ 7uaLOmygbFNxU/nQoEDsFq0mWycraeYYa5UVGSBPOUvmWNXm9NpuM3YwK7UbcQRXTR0BEEep6cd dsWmmyFb1MJ0gLm43GEziN5Q4iIGTHdcVshNyPlUNyh06Acg8RWQPF58JIUWeB2hkv9i0Hjmutn D1VmZCw+DgfDBOt2kxatC3LNMxZv9kJpVhBOntFUW+JSSMj+B9Qsx0NnGp+yNIOMyhgQczxDTVP T/TC+6iDGgNKCdzSMWznd+KF8ZmZ6rokDKSDIB0YE0= X-Received: by 2002:a05:690c:4d84:b0:796:5a14:87c3 with SMTP id 00721157ae682-7979e89a46amr145000827b3.40.1771389475050; Tue, 17 Feb 2026 20:37:55 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c23e4bdsm119850617b3.32.2026.02.17.20.37.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 20:37:54 -0800 (PST) From: Ethan Tidmore To: jic23@kernel.org, andy@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Ethan Tidmore Subject: [PATCH v4 9/9] iio: light: gp2ap020a00f: Join some lines of code to be a single line Date: Tue, 17 Feb 2026 22:37:28 -0600 Message-ID: <20260218043728.609659-10-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260218043728.609659-1-ethantidmore06@gmail.com> References: <20260218043728.609659-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Andy Shevchenko In some cases the wrapped lines are harder to follow. Join them despite being longer than 80 characters in some cases. Signed-off-by: Andy Shevchenko Signed-off-by: Ethan Tidmore --- v4: - Integrate Andy Shevchenko's cleanups. drivers/iio/light/gp2ap020a00f.c | 39 +++++++++++--------------------- 1 file changed, 13 insertions(+), 26 deletions(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a= 00f.c index 1867dacc0af6..e901a8c33609 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -175,10 +175,8 @@ #define GP2AP020A00F_CHAN_TIMESTAMP 3 =20 #define GP2AP020A00F_DATA_READY_TIMEOUT msecs_to_jiffies(1000) -#define GP2AP020A00F_DATA_REG(chan) (GP2AP020A00F_D0_L_REG + \ - (chan) * 2) -#define GP2AP020A00F_THRESH_REG(th_val_id) (GP2AP020A00F_TL_L_REG + \ - (th_val_id) * 2) +#define GP2AP020A00F_DATA_REG(chan) (GP2AP020A00F_D0_L_REG + (chan) * 2) +#define GP2AP020A00F_THRESH_REG(th_val_id) (GP2AP020A00F_TL_L_REG + (th_va= l_id) * 2) #define GP2AP020A00F_THRESH_VAL_ID(reg_addr) ((reg_addr - 4) / 2) =20 #define GP2AP020A00F_SUBTRACT_MODE 0 @@ -390,20 +388,17 @@ static int gp2ap020a00f_set_operation_mode(struct gp2= ap020a00f_data *data, } =20 err =3D regmap_update_bits(data->regmap, GP2AP020A00F_ALS_REG, - GP2AP020A00F_PRST_MASK, opmode_regs_settings[op] - .als_reg); + GP2AP020A00F_PRST_MASK, opmode_regs_settings[op].als_reg); if (err < 0) return err; =20 err =3D regmap_update_bits(data->regmap, GP2AP020A00F_PS_REG, - GP2AP020A00F_INTTYPE_MASK, opmode_regs_settings[op] - .ps_reg); + GP2AP020A00F_INTTYPE_MASK, opmode_regs_settings[op].ps_reg); if (err < 0) return err; =20 err =3D regmap_update_bits(data->regmap, GP2AP020A00F_LED_REG, - GP2AP020A00F_PIN_MASK, opmode_regs_settings[op] - .led_reg); + GP2AP020A00F_PIN_MASK, opmode_regs_settings[op].led_reg); if (err < 0) return err; } @@ -861,8 +856,7 @@ static irqreturn_t gp2ap020a00f_thresh_event_handler(in= t irq, void *data) int thresh_val_id, ret; =20 /* Read interrupt flags */ - ret =3D regmap_read(priv->regmap, GP2AP020A00F_OP_REG, - &op_reg_val); + ret =3D regmap_read(priv->regmap, GP2AP020A00F_OP_REG, &op_reg_val); if (ret < 0) goto done; =20 @@ -874,8 +868,7 @@ static irqreturn_t gp2ap020a00f_thresh_event_handler(in= t irq, void *data) =20 /* Clear interrupt flags (if not in INTTYPE_PULSE mode) */ if (priv->cur_opmode !=3D GP2AP020A00F_OPMODE_PROX_DETECT) { - ret =3D regmap_write(priv->regmap, GP2AP020A00F_OP_REG, - op_reg_val); + ret =3D regmap_write(priv->regmap, GP2AP020A00F_OP_REG, op_reg_val); if (ret < 0) goto done; } @@ -972,8 +965,7 @@ static irqreturn_t gp2ap020a00f_trigger_handler(int irq= , void *data) } } =20 - iio_push_to_buffers_with_timestamp(indio_dev, priv->buffer, - pf->timestamp); + iio_push_to_buffers_with_timestamp(indio_dev, priv->buffer, pf->timestamp= ); done: iio_trigger_notify_done(indio_dev->trig); =20 @@ -1023,26 +1015,22 @@ static int gp2ap020a00f_write_event_val(struct iio_= dev *indio_dev, =20 switch (thresh_reg_l) { case GP2AP020A00F_TH_L_REG: - event_en =3D test_bit(GP2AP020A00F_FLAG_ALS_RISING_EV, - &data->flags); + event_en =3D test_bit(GP2AP020A00F_FLAG_ALS_RISING_EV, &data->flags); break; case GP2AP020A00F_TL_L_REG: - event_en =3D test_bit(GP2AP020A00F_FLAG_ALS_FALLING_EV, - &data->flags); + event_en =3D test_bit(GP2AP020A00F_FLAG_ALS_FALLING_EV, &data->flags); break; case GP2AP020A00F_PH_L_REG: if (val =3D=3D 0) return -EINVAL; =20 - event_en =3D test_bit(GP2AP020A00F_FLAG_PROX_RISING_EV, - &data->flags); + event_en =3D test_bit(GP2AP020A00F_FLAG_PROX_RISING_EV, &data->flags); break; case GP2AP020A00F_PL_L_REG: if (val =3D=3D 0) return -EINVAL; =20 - event_en =3D test_bit(GP2AP020A00F_FLAG_PROX_FALLING_EV, - &data->flags); + event_en =3D test_bit(GP2AP020A00F_FLAG_PROX_FALLING_EV, &data->flags); break; } =20 @@ -1526,8 +1514,7 @@ static void gp2ap020a00f_remove(struct i2c_client *cl= ient) struct device *dev =3D &client->dev; int err; =20 - err =3D gp2ap020a00f_set_operation_mode(data, - GP2AP020A00F_OPMODE_SHUTDOWN); + err =3D gp2ap020a00f_set_operation_mode(data, GP2AP020A00F_OPMODE_SHUTDOW= N); if (err < 0) dev_err(dev, "Failed to power off the device.\n"); =20 --=20 2.53.0