From nobody Sun Apr 5 13:04:35 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F6F5261B9C for ; Wed, 18 Feb 2026 04:29:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771388979; cv=none; b=us7Yb/KNmeFU497v7KRDZUJNMPtLXoaFzwHVU4bfo6M5AW/vc3zOaWu6Z3adYSgM7E8H05dx5v0QfPzEeFx10P+opFR0npiHzkgRLB4nVD1VOpNe/uYXWngxJsJS4xM7G0tTuXNJzoFBIwVRrg+PNxqmVoxP+thZu5vln5QG4CA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771388979; c=relaxed/simple; bh=dhvoDsSh7tHUJR13TIhX9yNmWVj8+ijL2aeiCvX8TbY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Qh9TdtaR0MC60h9p+evgzxHcGelMgwcrfOY6ORBhcBj2Wlw9gPA+8l/AApbE2x4MCqdOem5i5TlQrFYB+S3+eAteiEET15LP+7ll/OX0kAlIqv5RJL6E7JnIpHcK9cFYUAl9h1ZFKgFuN2Dde5+SW9+w5RBzOk0PACldoVKlt20= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B1Dbwot5; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B1Dbwot5" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2ab46931cf1so2939705ad.0 for ; Tue, 17 Feb 2026 20:29:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771388978; x=1771993778; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VvzlN98l7/BarHSO/majX6xw5/psg69bWsbBzuUD8gg=; b=B1Dbwot5Lr0a9OnjCsmRGbs6P48d771jwb6vrPlSrBXpO8HdEpVzr5IF2FmN9uCNmL oqZoGkEEXibQPdc5EZQLxLDgDPJp4VmDHWOhVKo+bdJ30GUVqik1I6VqsiRn4dbJsH+b PPpI6Wca2fPzQ2KifDVQHCiTxn8fWvzdDLuvGBiMWCivMaKg/5tODs1vuJepZSCq+8YK OipWI5cmcslx3Qz8RyhGeev3nDxwOCBdMCs7+V3Mt+49EXYnNQFFuLjyi+Hpcgg5EVJk WtN5bjtXp1WOVclhUm51+REi0d50tY7Xm8NeUTsUoRNtyyYRJrFeqDsUfCmSljDoXtAQ Iuaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771388978; x=1771993778; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VvzlN98l7/BarHSO/majX6xw5/psg69bWsbBzuUD8gg=; b=Xw2pNPJ7D2h9TxuKEvJg5tcUDE0IxeZfV+bHfgOJ4dH6M9dp9RDtfq/3wjpmtemr1b /mqxW3pgvakMOwg4QTEhSKIEptfLbo2xB9qpWF+mANfmQJ4uacuet5cYOW7/xL/nLGW8 mEyGJK1ng56aOAzW5qN+eZY7cV2C72llbzXml2QXQtIGZpaTLnczFG/gHHkBN47vaxBa u3AmvIg4RAZsZ/8gDIFS1ETQThF+L4SHtOHCbN6dN2loVqUCCpVm60Hma7ClhqHH37HB uKz1od8BSdRvI5PnTniI6nrbJAlPP085E0cngCgM3ZjkhmT6bJ4tpTHZn/sf5bLmDOKn P2sw== X-Forwarded-Encrypted: i=1; AJvYcCWJh6LynD8OMCHMlK4kuCoz9dwm+yvweNfs3Tp9UxBvBnFcOh21DU0KNYzcHm0RqVSGlla1qcbTHWTCW+I=@vger.kernel.org X-Gm-Message-State: AOJu0YybwJKGSzXC3L23FU22WTwxVMs2qNs5/0C4SCS1s+d5KA8PLZDR 0sXGKapKAGyZXA9s7AItCtBYEWdzdICBMvpb+7v00oeqFVcjQcmFnXcU X-Gm-Gg: AZuq6aJvn+VY7GWY7aJ4KLAfVcoTPIvX0UNia2EZtOA55BhlDrYKrQPX62LVrpZe55h K6jciHH2uwaCmPX35ClXyy5lcBYtMJZzh+IU/iVJs6iiVQ6rKQ4DSHTZWMG/N/nphUBn8WnChy0 /I6SlcnIMIhVN6seeIDj9kXzogBR3n9aRmCCXXkrHThJOYViQUKxkDVKPXOqgLZtW/2Tw2MvpbI 1YsED3pncf6VhhkZU+hIdP8lw4/2nuP5R5G4HqtwXHk4r9hiwXgtWgTcguugXfL7dfYj38f9FDA ghy6NU0G84MVwnUqfn05cZ493LWedGNk1QX1v8MS52kDX3nnFoOb3yYb2fJGHS1qlUtWrOvMhMJ S2IKRDy2LNsDFqulSqKpylpxYUE2XUVBT1CO3uLqYUfy1H27/jElFwziX0Eb9hxa0kh9ys1/cS1 qzKj9teqsOIG0WggB6XXCWaHK9YfzCQCI/KTZtwN/F2PAYtDWWOv8wsLwzFradSMOWNhzb/74xJ xiuei/rSThG4EITOqKjsO3Ejrc6lw== X-Received: by 2002:a17:903:2c05:b0:2aa:e3d1:1430 with SMTP id d9443c01a7336-2ad50c3d06dmr5488015ad.23.1771388977806; Tue, 17 Feb 2026 20:29:37 -0800 (PST) Received: from localhost.localdomain ([2401:4900:c906:adbd:f506:1dbc:e3f3:e38e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1aaeb759sm105165865ad.83.2026.02.17.20.29.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 17 Feb 2026 20:29:37 -0800 (PST) From: Anand Kumar Shaw To: bpf@vger.kernel.org, netdev@vger.kernel.org Cc: kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, hawk@kernel.org, john.fastabend@gmail.com, sdf@fomichev.me, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, linux-kernel@vger.kernel.org, Anand Kumar Shaw Subject: [PATCH v3] bpf: cpumap: add missing XDP_ABORTED handling in xdp prog runner Date: Wed, 18 Feb 2026 09:59:24 +0530 Message-Id: <20260218042924.42931-1-anandkrshawheritage@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" cpu_map_bpf_prog_run_xdp() handles XDP_PASS, XDP_REDIRECT, and XDP_DROP but is missing an XDP_ABORTED case. Without it, XDP_ABORTED falls into the default case which logs a misleading "invalid XDP action" warning instead of tracing the abort via trace_xdp_exception(). Add the missing XDP_ABORTED case with trace_xdp_exception(), matching the handling already present in the skb path (cpu_map_bpf_prog_run_skb), devmap (dev_map_bpf_prog_run), and the generic XDP path (do_xdp_generic). Also pass xdpf->dev_rx instead of NULL to bpf_warn_invalid_xdp_action() in the default case, so the warning includes the actual device name. This aligns with the generic XDP path in net/core/dev.c which already passes the real device. Signed-off-by: Anand Kumar Shaw --- Changes in v3: - Dropped unrelated queue_index changes that were accidentally included in v2 Changes in v2: - Pass xdpf->dev_rx to bpf_warn_invalid_xdp_action() instead of NULL (Jakub Kicinski) --- kernel/bpf/cpumap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kernel/bpf/cpumap.c b/kernel/bpf/cpumap.c index 04171fbc39cb..39959bf542f9 100644 --- a/kernel/bpf/cpumap.c +++ b/kernel/bpf/cpumap.c @@ -221,7 +221,10 @@ static int cpu_map_bpf_prog_run_xdp(struct bpf_cpu_map= _entry *rcpu, } break; default: - bpf_warn_invalid_xdp_action(NULL, rcpu->prog, act); + bpf_warn_invalid_xdp_action(xdpf->dev_rx, rcpu->prog, act); + fallthrough; + case XDP_ABORTED: + trace_xdp_exception(xdpf->dev_rx, rcpu->prog, act); fallthrough; case XDP_DROP: xdp_return_frame(xdpf); --=20 2.39.5 (Apple Git-154)