From nobody Fri Apr 17 13:17:58 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 801F22FC881 for ; Wed, 18 Feb 2026 20:21:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771446082; cv=none; b=Miu+x4qnBgbe+o2PLRh5o8rtXTcTEueW6vhd7EO3ZUt0EN9Fqt8K6rN4SgXyecjZ23fge3wtL2Otvgl0M/3V6diopXFfkb2isWcC8evMRUFDnG3pzRE+fr1vCuBGrGvO3SsvlbqLw8/QQzMkuysmnT7HFdZDDquaEN0+Op0XbA0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771446082; c=relaxed/simple; bh=stUEdsfxtc4bnSAii8le9q2fiTOR/peX46/VHKirbPU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=FkHPO6os2DHkdRxl8vBFgM7xi1GVyi+isu3UxQOz0SNgfzt1mTo03XnYgh6/B1uy4Z0ySasKGRZliLp7qflWsfoM8lbwsdzmmtzBwA0zo9svArva5G8/pL+f2pHPjCp8iOQW2KRs9dOdaqnij3mjR0An105z0MiV2e5YR17Obkk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ATEfDOCQ; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ATEfDOCQ" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4836f363ad2so2534115e9.1 for ; Wed, 18 Feb 2026 12:21:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771446080; x=1772050880; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=WkBH3Pq8yF91vpQwDAd3nKXebRuZ5X1TEOAqkn6IWvw=; b=ATEfDOCQKyHY2Ckd+ikF6BFAXA7476mJOXiwv+Xgb4fDW0AU0eBSoJEWgxT+dci7+f oMAPj8Blosr4c06Ez9SIr7SloAVHnUe3ilxWYs5NFP9wZbnvAlrZDIlBq2jVAOci9zp5 Cvknbu5rZs7C58YAMwD+hs7dEgbU7lkQgP1QsDkrqPv7abbIChiEMvH+tD7HcOt1hh17 cXGV0Q8PmphfHoN1POLOiL/9+d8VXxDiwTcSR0kYH8S82vrq1gnJ3EcWQperbYc7KJKp g7GeKRgbFhWsSRwB6SBXB4cMQVmCZOHZsUVQHcAWRXK5YO+caSnzZN0jBi0gXMHY9Mdp ZaOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771446080; x=1772050880; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WkBH3Pq8yF91vpQwDAd3nKXebRuZ5X1TEOAqkn6IWvw=; b=XNPfibGkv4nQdTf62po5CJq3CtA1bNDbKodDXXqWxh3w/IOdJtPMA2xYx7NrJOihlU ZNXz0KuTlCJRztGqkpsz3Ck8ctUrIhNCyaa05TJshm/RO6bhfP8evz6VQVguDUKeHTnA GIRxH88PQ4XnIg73xfyHDg4QlvwZRFWzybHzsDY7ePr90oEASfzu3WWiYOJDa+fgvQLV ZOyM2E0O58hS93aLZ7o+sbryhPIpTwM3ii1sSYkf9JuP1njyLEbbjieQoqgYCpSQ7POY bRj0EisdPoK9DBCDzI+SV9lgsAsZMLVWeVT9ze8eNiJ+DXqihv1S1Ht/PNL1/0egi5tu RGpw== X-Forwarded-Encrypted: i=1; AJvYcCVUznLApok9tqWau3B75akcN5nz7njq4GUnR/y525ysG1dmHiv8nyPLQTqlLNBVJEB899o6sw3nEtMTx3g=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp43DegXhaXD4V0XQuXR8HxjIWOv82IfswmEzNjU+5dvQwEFba Vl9+57kHpAujS5lhWhhjoUfmLwHXXeDH1uDyXer+Gee//aKxGNjxIN0x X-Gm-Gg: AZuq6aKsjnM6KX7Qo+4HaQD6Yd9tALiRVj0rfjnpul6XmBnvYfTP9mO9SQhKEJSXBiB tPGYXA6wrqZIu1mKEbFSXiWw/f2y+FCtvx7kN2tBGK/3kdVhkP6re64fC/D7aFd2q1xuz30inly J/QHODpeaO7MiUxktF1Z7gvkc1cMx+D/XIRU0Z4iL9Yf+I0UIT839W+KuL7Rfu9iqJ3X6Q7zJb4 nzFI/8ZUwSjcw7Hn+fo7zvrPvICRKMJ55WQxzJIf86icHeLqUrnSoKBlnRadBlbR61jjslbNJ1m Vn79vzB/z2F7jf1O25JI0fffnJj9YPDX5/v2N27Iu77xsyNxw3gERmCx125j0J1NZZeHEY8aBHv 73ilvCWcEpoqByvVipGyqHy2/4MywbnTBu8jc3XcBFHBD3+vlQ87iSJEwnOiDDO1aSJEf46i54W 0iYuMV4ER5xQY1/I5LpF1waaipoemd1AvYv7/ZQxVksdX1xcvkUBda X-Received: by 2002:a05:600c:1986:b0:483:71f9:37ef with SMTP id 5b1f17b1804b1-483739ff8f5mr330227005e9.8.1771446079805; Wed, 18 Feb 2026 12:21:19 -0800 (PST) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-439567aad3csm9911973f8f.36.2026.02.18.12.21.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 12:21:19 -0800 (PST) From: Gabor Juhos Date: Wed, 18 Feb 2026 21:21:07 +0100 Subject: [PATCH] usb: core: don't power off roothub PHYs if phy_set_mode() fails Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260218-usb-phy-poweroff-fix-v1-1-66e6831e860e@gmail.com> X-B4-Tracking: v=1; b=H4sIADIflmkC/x2MywqAIBAAfyX23EJaSfQr0UFtzb2kKL2I/j3pO AMzD2RKTBnG6oFEB2cOWwFRV2C93lZCXgqDbKRqpBhwzwajvzGGk1JwDh1faNu+M8po0UkLJY2 Jiv630/y+H+tA0KBmAAAA X-Change-ID: 20260218-usb-phy-poweroff-fix-c354b6ba142c To: Greg Kroah-Hartman , Miquel Raynal Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 Remove the error path from the usb_phy_roothub_set_mode() function. The code is clearly wrong, because phy_set_mode() calls can't be balanced with phy_power_off() calls. Additionally, the usb_phy_roothub_set_mode() function is called only from usb_add_hcd() before it powers on the PHYs, so powering off those makes no sense anyway. Presumably, the code is copy-pasted from the phy_power_on() function without adjusting the error handling. Cc: stable@vger.kernel.org # v5.1+ Fixes: b97a31348379 ("usb: core: comply to PHY framework") Signed-off-by: Gabor Juhos Reviewed-by: Miquel Raynal --- drivers/usb/core/phy.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/usb/core/phy.c b/drivers/usb/core/phy.c index faa20054ad5a1c3f704cb9f70b5049cefdab804e..4bba1c2757406a35bf19eb7984a= 2807212374d18 100644 --- a/drivers/usb/core/phy.c +++ b/drivers/usb/core/phy.c @@ -200,16 +200,10 @@ int usb_phy_roothub_set_mode(struct usb_phy_roothub *= phy_roothub, list_for_each_entry(roothub_entry, head, list) { err =3D phy_set_mode(roothub_entry->phy, mode); if (err) - goto err_out; + return err; } =20 return 0; - -err_out: - list_for_each_entry_continue_reverse(roothub_entry, head, list) - phy_power_off(roothub_entry->phy); - - return err; } EXPORT_SYMBOL_GPL(usb_phy_roothub_set_mode); =20 --- base-commit: 05f7e89ab9731565d8a62e3b5d1ec206485eeb0b change-id: 20260218-usb-phy-poweroff-fix-c354b6ba142c Best regards, --=20 Gabor Juhos