From nobody Fri Apr 3 04:49:59 2026 Received: from mail.unwrap.rs (mail.unwrap.rs [172.232.15.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECCEF2C1598; Tue, 17 Feb 2026 23:35:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=172.232.15.166 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771371358; cv=none; b=tfGNVoYlAoTvvlfs4brhKmJHCtdwy6B+J92YfJ87Ka/a//EXSeDg7yspx3et3cZORKYNnrEPXKtB0Qc0y4V2mGHjJzbz/V2JcnMaVEbZAfWg8baPuMBn6wbvYETGs2dreGRcCJciWN3d9uGaefWJF5tWWMinajhLZpez3ri7ToU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771371358; c=relaxed/simple; bh=chF8byulc7vGETJ8uuyrLnT2EdBhd01wrsU+vUAuAKQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bcznDQ8e4ofpCSka6+99b3FaiYi5/1otis2C2I7ijIA8WMKlokm5EplF6HvQ7o6DhXHx0/IB7zAPxPgsPYSjXSptwbSTLuvo+NzLsFAy3EzCyzem37KidtLlP1QEmnE4DKBF71Rm2gbConWvdfhltksZUaKLvrvQPzTURf24uIs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=unwrap.rs; spf=pass smtp.mailfrom=unwrap.rs; arc=none smtp.client-ip=172.232.15.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=unwrap.rs Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=unwrap.rs From: Cole Leavitt To: vkoul@kernel.org, yung-chuan.liao@linux.intel.com Cc: pierre-louis.bossart@linux.dev, david.rhodes@cirrus.com, rf@opensource.cirrus.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, cole@unwrap.rs Subject: [PATCH 1/2] soundwire: bus: downgrade expected unattach warnings to dev_dbg Date: Tue, 17 Feb 2026 16:35:32 -0700 Message-ID: <20260217233533.4716-2-cole@unwrap.rs> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260217233533.4716-1-cole@unwrap.rs> References: <20260217233533.4716-1-cole@unwrap.rs> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The sdw_handle_slave_status() function emits dev_warn() whenever a peripheral transitions to UNATTACHED from a previously ATTACHED state. While useful for debugging genuinely unexpected detachments, this warning also fires during normal operation when a codec driver intentionally triggers a system reset (e.g., after firmware download), causing unnecessary noise in the kernel log on every boot. Add an 'unattach_pending' flag to struct sdw_slave that codec drivers can set before triggering an expected detach. When this flag is set, the bus layer emits a dev_dbg() instead of dev_warn() and clears the flag, preserving the warning for genuinely unexpected detachments. Signed-off-by: Cole Leavitt --- drivers/soundwire/bus.c | 9 +++++++-- include/linux/soundwire/sdw.h | 1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index fb68738dfb9b..a5a71ab1feed 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -1899,8 +1899,13 @@ int sdw_handle_slave_status(struct sdw_bus *bus, =20 if (status[i] =3D=3D SDW_SLAVE_UNATTACHED && slave->status !=3D SDW_SLAVE_UNATTACHED) { - dev_warn(&slave->dev, "Slave %d state check1: UNATTACHED, status was %d= \n", - i, slave->status); + if (slave->unattach_pending) + dev_dbg(&slave->dev, "Slave %d state check1: UNATTACHED (expected), st= atus was %d\n", + i, slave->status); + else + dev_warn(&slave->dev, "Slave %d state check1: UNATTACHED, status was %= d\n", + i, slave->status); + slave->unattach_pending =3D false; sdw_modify_slave_status(slave, SDW_SLAVE_UNATTACHED); =20 /* Ensure driver knows that peripheral unattached */ diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h index f462717acf20..4318f2b144e1 100644 --- a/include/linux/soundwire/sdw.h +++ b/include/linux/soundwire/sdw.h @@ -682,6 +682,7 @@ struct sdw_slave { struct completion enumeration_complete; struct completion initialization_complete; u32 unattach_request; + bool unattach_pending; bool first_interrupt_done; bool is_mockup_device; struct mutex sdw_dev_lock; /* protect callbacks/remove races */ --=20 2.52.0 From nobody Fri Apr 3 04:49:59 2026 Received: from mail.unwrap.rs (mail.unwrap.rs [172.232.15.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23AF42D7D47; Tue, 17 Feb 2026 23:35:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=172.232.15.166 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771371358; cv=none; b=bNDqp8omvDvNfHGj6swmtXsoattc6jMJSVBYyhkmqF8fIP09kqb/vuUX8IJKkrPL/ysnQo6rncgNqj/jaZ0I5oZs5swzvV8LkRArXxnOV+RsWLVE1fA+9aRd6OfApH3pnnr0J5sVdDDmBO5laIgazzn8LpwtG79JS6D2EnvC884= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771371358; c=relaxed/simple; bh=Z5rLsdcetRawaXfWJMg3rS9yrgIvWSBJ7nau4HA2BVk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j8ZcbUvpPdsrVajivTVYL1/IfoL0KP9UH3hFWiuJGTgVIhbgEEZ2KNimRIhz9LqcGYB/MLJQlzokOH3L7ydUQJOiJ8HBS0sTkPR9AkKohws3tqqtPME5Dd0W2aNnPEN+OiFhH7TatuVgDkNHt4h80CG+y3fQje9FC7v2fpI4kIo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=unwrap.rs; spf=pass smtp.mailfrom=unwrap.rs; arc=none smtp.client-ip=172.232.15.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=unwrap.rs Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=unwrap.rs From: Cole Leavitt To: vkoul@kernel.org, yung-chuan.liao@linux.intel.com Cc: pierre-louis.bossart@linux.dev, david.rhodes@cirrus.com, rf@opensource.cirrus.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, cole@unwrap.rs Subject: [PATCH 2/2] ASoC: cs35l56: set unattach_pending before SoundWire system reset Date: Tue, 17 Feb 2026 16:35:33 -0700 Message-ID: <20260217233533.4716-3-cole@unwrap.rs> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260217233533.4716-1-cole@unwrap.rs> References: <20260217233533.4716-1-cole@unwrap.rs> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The CS35L56 driver triggers a system reset after firmware download and during initial probe when no hardware reset GPIO is available. This reset physically detaches the codec from the SoundWire bus while the driver waits for re-enumeration, which is expected and handled gracefully. However, the bus layer emits a dev_warn() for this intentional transition to UNATTACHED because it cannot distinguish expected detachments from genuine failures. This produces misleading warnings on every boot for systems with CS35L56 codecs on SoundWire: cs35l56 sdw:0:2:01fa:3556:01:0: Slave 2 state check1: UNATTACHED, status = was 1 cs35l56 sdw:0:2:01fa:3556:01:1: Slave 1 state check1: UNATTACHED, status = was 1 Set the unattach_pending flag on the SoundWire peripheral before triggering a system reset in both the firmware patch path and the initial probe soft reset path. This allows the bus layer to downgrade the warning to dev_dbg() for these expected transitions. Signed-off-by: Cole Leavitt --- sound/soc/codecs/cs35l56.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c index 2ff8b172b76e..6566350a59c7 100644 --- a/sound/soc/codecs/cs35l56.c +++ b/sound/soc/codecs/cs35l56.c @@ -807,6 +807,8 @@ static void cs35l56_patch(struct cs35l56_private *cs35l= 56, bool firmware_missing reinit_completion(&cs35l56->init_completion); =20 cs35l56->soft_resetting =3D true; + if (cs35l56->sdw_peripheral) + cs35l56->sdw_peripheral->unattach_pending =3D true; cs35l56_system_reset(&cs35l56->base, !!cs35l56->sdw_peripheral); =20 if (cs35l56->sdw_peripheral) { @@ -1903,6 +1905,8 @@ int cs35l56_init(struct cs35l56_private *cs35l56) if (!cs35l56->base.reset_gpio) { dev_dbg(cs35l56->base.dev, "No reset gpio: using soft reset\n"); cs35l56->soft_resetting =3D true; + if (cs35l56->sdw_peripheral) + cs35l56->sdw_peripheral->unattach_pending =3D true; cs35l56_system_reset(&cs35l56->base, !!cs35l56->sdw_peripheral); if (cs35l56->sdw_peripheral) { /* Keep alive while we wait for re-enumeration */ --=20 2.52.0 From nobody Fri Apr 3 04:49:59 2026 Received: from mail.unwrap.rs (mail.unwrap.rs [172.232.15.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F12BF344DAE; Wed, 18 Feb 2026 18:02:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=172.232.15.166 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771437771; cv=none; b=jRVZu9/N9I6G1t4RdmGultBS0yoHgySxYMKk+jRFpQ26HzAsfFm1r5Sxwx9B03eZILbc5c4yDo0MKxmQaTiC2KCjhaX5fUH+qKpEuk20xmn8OfM3zJaGsX62veDHhVUsveQpHENzOcrsTw7bb6o4gAMoEXx95BQyxUeN1AsMU9Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771437771; c=relaxed/simple; bh=zPhv6AoqKfkCRofMNXJkiwCDxKrgStzIWC83eX3qVhc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aJmJUHOwfmpP1kS6ephpeVuNl/xTppVsX548U3bfKpmzSE/lwHDP8DfnlHFpvePxcxsQ7Hro5HnFI9aOqGM0wRgIpsB3CBk9/BB82fFYwlOz1w/s0/nX0DswMOML94IePLyuwCN5br/VcbZGCtztiutP5/19r77PcIMDHTFyAzU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=unwrap.rs; spf=pass smtp.mailfrom=unwrap.rs; arc=none smtp.client-ip=172.232.15.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=unwrap.rs Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=unwrap.rs From: Cole Leavitt To: vkoul@kernel.org, yung-chuan.liao@linux.intel.com Cc: pierre-louis.bossart@linux.dev, rf@opensource.cirrus.com, ckeepax@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Cole Leavitt Subject: [PATCH v4] soundwire: bus: demote UNATTACHED state warnings to dev_dbg() Date: Wed, 18 Feb 2026 11:02:10 -0700 Message-ID: <20260218180210.9263-1-cole@unwrap.rs> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260217233533.4716-1-cole@unwrap.rs> References: <20260217233533.4716-1-cole@unwrap.rs> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dev_warn() messages in sdw_handle_slave_status() for UNATTACHED transitions were added in commit d1b328557058 ("soundwire: bus: add dev_warn() messages to track UNATTACHED devices") to debug attachment failures with dynamic debug enabled. These warnings fire during normal operation -- for example when a codec driver triggers a hardware reset after firmware download, causing the device to momentarily go UNATTACHED before re-attaching -- producing misleading noise on every boot. Demote the messages to dev_dbg() so they remain available via dynamic debug for diagnosing real attachment failures without alarming users during expected initialization sequences. Fixes: d1b328557058 ("soundwire: bus: add dev_warn() messages to track UNAT= TACHED devices") Signed-off-by: Cole Leavitt Reviewed-by: Richard Fitzgerald --- Changes in v4: - Remove incorrect PING frame race reference from commit message (Pierre-Louis Bossart) - Clarify that the actual trigger is codec hardware reset after firmware download Changes in v3: - Add Fixes tag and version changelog Changes in v2: - Drop unattach_pending flag approach entirely per reviewer feedback (Pierre-Louis, Richard, Charles) - Simply demote dev_warn() to dev_dbg() unconditionally - Single patch instead of 2-patch series drivers/soundwire/bus.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index fb68738dfb9b..fe5316d93fef 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -1899,8 +1899,8 @@ int sdw_handle_slave_status(struct sdw_bus *bus, =20 if (status[i] =3D=3D SDW_SLAVE_UNATTACHED && slave->status !=3D SDW_SLAVE_UNATTACHED) { - dev_warn(&slave->dev, "Slave %d state check1: UNATTACHED, status was %d= \n", - i, slave->status); + dev_dbg(&slave->dev, "Slave %d state check1: UNATTACHED, status was %d\= n", + i, slave->status); sdw_modify_slave_status(slave, SDW_SLAVE_UNATTACHED); =20 /* Ensure driver knows that peripheral unattached */ @@ -1951,8 +1951,8 @@ int sdw_handle_slave_status(struct sdw_bus *bus, if (slave->status =3D=3D SDW_SLAVE_UNATTACHED) break; =20 - dev_warn(&slave->dev, "Slave %d state check2: UNATTACHED, status was %d= \n", - i, slave->status); + dev_dbg(&slave->dev, "Slave %d state check2: UNATTACHED, status was %d\= n", + i, slave->status); =20 sdw_modify_slave_status(slave, SDW_SLAVE_UNATTACHED); break; --=20 2.52.0 From nobody Fri Apr 3 04:49:59 2026 Received: from mail.unwrap.rs (mail.unwrap.rs [172.232.15.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCB3A32F766; Wed, 18 Feb 2026 14:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=172.232.15.166 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771423274; cv=none; b=nevrRMcwdeS5h2N0h7rBS4Yq1t0qvTzwl4+69GBkxGmnZKiBEEsGy4diZ7NMcF1OoBvFhg8t09xbQAFFaF9ORrK+3WqeqJNM8rs41Wt2MmsluXEqViiqsUHYCri63ouh0bRF59TdTAe0HnvTZmb1N3RiKs8GmyclwxZ6vub1tW0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771423274; c=relaxed/simple; bh=BtVYVKgsTmOrhBPS5WxXXBV2evBxZ38WWXFNEqhx8vc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KnCzZEvUDA6xRk0yGHZ7L61bdC16/y03M1xXe9cAt21mvgJqq1BYN9Uweh5RPCLVErRyzTy9a0LyELnYqw0Xhj4QpXMnYYin7yHVnndRSkbiIu/Red9PZO3Tv/Cp++VHkBRvfk4av8PYbjjgunFRp4b3l9J9Joen+x2u9VwRNl8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=unwrap.rs; spf=pass smtp.mailfrom=unwrap.rs; arc=none smtp.client-ip=172.232.15.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=unwrap.rs Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=unwrap.rs From: Cole Leavitt To: Vinod Koul , Bard Liao Cc: Pierre-Louis Bossart , Richard Fitzgerald , Charles Keepax , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Cole Leavitt Subject: [PATCH v3] soundwire: bus: demote UNATTACHED slave warnings to dev_dbg Date: Wed, 18 Feb 2026 07:00:42 -0700 Message-ID: <20260218140042.21536-1-cole@unwrap.rs> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260217233533.4716-1-cole@unwrap.rs> References: <20260217233533.4716-1-cole@unwrap.rs> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dev_warn() messages in sdw_handle_slave_status() for UNATTACHED transitions were added in commit d1b328557058 ("soundwire: bus: add dev_warn() messages to track UNATTACHED devices") to debug attachment failures with dynamic debug enabled. These warnings fire during normal operation -- for example when a codec driver triggers a system reset after firmware download, or during initial multi-device enumeration due to the PING frame race documented in cadence_master.c -- producing misleading noise on every boot. The original debugging use case is fully served by dev_dbg(), which remains visible when dynamic debug is enabled. Demote both state check warnings to dev_dbg(). Fixes: d1b328557058 ("soundwire: bus: add dev_warn() messages to track UNAT= TACHED devices") Signed-off-by: Cole Leavitt --- Changes in v3: - Add Fixes tag and version changelog Changes in v2: - Drop unattach_pending flag approach entirely per reviewer feedback (Pierre-Louis, Richard, Charles) - Simply demote dev_warn() to dev_dbg() unconditionally - Single patch instead of 2-patch series drivers/soundwire/bus.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index fb68738dfb9b..45234cc07f35 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -1899,8 +1899,8 @@ int sdw_handle_slave_status(struct sdw_bus *bus, =20 if (status[i] =3D=3D SDW_SLAVE_UNATTACHED && slave->status !=3D SDW_SLAVE_UNATTACHED) { - dev_warn(&slave->dev, "Slave %d state check1: UNATTACHED, status was %d= \n", - i, slave->status); + dev_dbg(&slave->dev, "Slave %d state check1: UNATTACHED, status was %d\= n", + i, slave->status); sdw_modify_slave_status(slave, SDW_SLAVE_UNATTACHED); =20 /* Ensure driver knows that peripheral unattached */ @@ -1951,8 +1951,8 @@ int sdw_handle_slave_status(struct sdw_bus *bus, if (slave->status =3D=3D SDW_SLAVE_UNATTACHED) break; =20 - dev_warn(&slave->dev, "Slave %d state check2: UNATTACHED, status was %d= \n", - i, slave->status); + dev_dbg(&slave->dev, "Slave %d state check2: UNATTACHED, status was %d\= n", + i, slave->status); =20 sdw_modify_slave_status(slave, SDW_SLAVE_UNATTACHED); break; --=20 2.52.0 From nobody Fri Apr 3 04:49:59 2026 Received: from mail.unwrap.rs (mail.unwrap.rs [172.232.15.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1828D328B40; Wed, 18 Feb 2026 13:55:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=172.232.15.166 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771422925; cv=none; b=juGkMMomrFZFaa+RQuANkwLrp1qt5rSVTKzq6udW7uwkYiZIHzEXj4XRhSpNaBhcKtIg00KEDihzYA7UQuXVoeBMN4u4Fen+qrIyOwhlqebBGV8DA/M9F2vtWtdbu1C5LnyEE5W5AYpAlWj6tmEI12EQXgFPN1TosG0AdQkS/Ek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771422925; c=relaxed/simple; bh=w3YNPP20ZeLgRL62e0LsUyiDC0Gz2gu+cEDFwnI2P+A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Op3d7eBSHzrdXGr8incFAAdungeZnOAg56O2DE+UXrAX94JvxE/XytwmK2uvEVQ3n0CWNODHSAFg0z8JoLPA8xLjrroQjTqWVrlgOjbEUkXDCzwWAqcM6v9w+wItqOGKLhRqkH/62Fgd4bm8YLMRd6Lqj6CUdJEE5CQ/dvpn8mM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=unwrap.rs; spf=pass smtp.mailfrom=unwrap.rs; arc=none smtp.client-ip=172.232.15.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=unwrap.rs Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=unwrap.rs From: Cole Leavitt To: Vinod Koul , Bard Liao Cc: Pierre-Louis Bossart , Richard Fitzgerald , Charles Keepax , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Cole Leavitt Subject: [PATCH v2] soundwire: bus: demote UNATTACHED slave warnings to dev_dbg Date: Wed, 18 Feb 2026 06:55:12 -0700 Message-ID: <20260218135512.20838-1-cole@unwrap.rs> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260217233533.4716-1-cole@unwrap.rs> References: <20260217233533.4716-1-cole@unwrap.rs> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dev_warn() messages in sdw_handle_slave_status() for UNATTACHED transitions were added in commit d1b328557058 ("soundwire: bus: add dev_warn() messages to track UNATTACHED devices") to debug attachment failures with dynamic debug enabled. These warnings fire during normal operation -- for example when a codec driver triggers a system reset after firmware download, or during initial multi-device enumeration due to the PING frame race documented in cadence_master.c -- producing misleading noise on every boot. The original debugging use case is fully served by dev_dbg(), which remains visible when dynamic debug is enabled. Demote both state check warnings to dev_dbg(). Signed-off-by: Cole Leavitt --- drivers/soundwire/bus.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index fb68738dfb9b..45234cc07f35 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -1899,8 +1899,8 @@ int sdw_handle_slave_status(struct sdw_bus *bus, =20 if (status[i] =3D=3D SDW_SLAVE_UNATTACHED && slave->status !=3D SDW_SLAVE_UNATTACHED) { - dev_warn(&slave->dev, "Slave %d state check1: UNATTACHED, status was %d= \n", - i, slave->status); + dev_dbg(&slave->dev, "Slave %d state check1: UNATTACHED, status was %d\= n", + i, slave->status); sdw_modify_slave_status(slave, SDW_SLAVE_UNATTACHED); =20 /* Ensure driver knows that peripheral unattached */ @@ -1951,8 +1951,8 @@ int sdw_handle_slave_status(struct sdw_bus *bus, if (slave->status =3D=3D SDW_SLAVE_UNATTACHED) break; =20 - dev_warn(&slave->dev, "Slave %d state check2: UNATTACHED, status was %d= \n", - i, slave->status); + dev_dbg(&slave->dev, "Slave %d state check2: UNATTACHED, status was %d\= n", + i, slave->status); =20 sdw_modify_slave_status(slave, SDW_SLAVE_UNATTACHED); break; --=20 2.52.0