From nobody Thu Apr 2 06:33:14 2026 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F4FD357A4A for ; Tue, 17 Feb 2026 17:50:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771350618; cv=none; b=Y/1TsS9reZfiSN4VMzdbUNhWW9rfRN/Dua5DqwTsYzHQ8PwLkDLWaMYTWVWpBH/dHHui1m+iR1zm6t6Q3IUddbldZmHF0UHbzkRcHbOY+l+/0TvCb7TMwRtelQKMLLHQYFJWObe2EUPH7+uuBP4xIGwAD1n431w8JHTsb16M300= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771350618; c=relaxed/simple; bh=IJAhYnN8LRPGZyhkVx59hrOzpdCmz9BMmhTWUhgh22o=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=rAN8W66jAqxpfLslgTLzwtgrJe8u60uOy6k1OQx/5j6NBU+HCoJnnGRd+QuaAl5v7bJcGP/nc7yzqdjNvKWJ/SvlOJ32ChDkzZ/y6oAqxLqIu3WYQX9b4HxkiFJsSPc1p4ZfP79RHFOss/NmoUJFqQblx8butbo0nZDXk3JFQk8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu; spf=pass smtp.mailfrom=u.northwestern.edu; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b=ooIlxA//; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b="ooIlxA//" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-5062fc5d86aso41440771cf.1 for ; Tue, 17 Feb 2026 09:50:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u-northwestern-edu.20230601.gappssmtp.com; s=20230601; t=1771350615; x=1771955415; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Tg4p4mgVuyaqYrmRkJ0CRO2fk4lsHW/JKl6dW870fR0=; b=ooIlxA//Od+3hxkecOWHnTyl4pYvWkY/cwH4IDod5CQd4/bT3hRwRgqZt4aTNvLIuQ X+3Qv7eTu6en1BYAavLRNRzP4pe3DVhVkoIO/dcUTGTaI4dF/apYDzW4eq9ilzvQqJDo nPNB9MY/8MnGQDJPRhjAb96+vGfFne99Ei0NXL1l136KdXCa3egd+qKoLICnVTOPYlsP DCAL97/FOcgslq5DZHY8+nLItFmW4VXQLXxLS9CbWPb9QmygZtnjwrCXXuwI7898rIB6 Ki/ypNU40N5Hw1OUfs+iOUNjHKDQjLq5iM28waFY1czu9mS3xxmAynTMlw0t8ZVWKO9h LM4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771350615; x=1771955415; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Tg4p4mgVuyaqYrmRkJ0CRO2fk4lsHW/JKl6dW870fR0=; b=gv5Oj4Y2zpTR5BEan5PAiUkKxxTqbf4anus/qMv7Ta24OpzkR7UDGvU4h8zv+wMUHa +2f1p0Vvl0uFUAyquJfOY5p9yB91bjGEimSGxlnSG5b2wr68yOK5+aoYdQuVAUTmP9Dn 1IK1CB3itPk5UeLQlaXESci65YTQi7qyqf1ioLhcqQU0Bk0rKklTZD/7xoC1XRAFMBmN NOdfikzdQ04xQJzk+k7GVH1Og50XVEiBLwtoj/HZlH+bxItl33nFMma4jCzYqTZ7V71q RU+n52dNcppFE6CcBn9LOqxXrF4fa5tBr1+s45Fhc+xkBRKTXR1XgJC71J4f+lDSC7Vj wO0g== X-Forwarded-Encrypted: i=1; AJvYcCV/vRbSZGzO6w80C1VzxBo1zzpMIWZMJl42OvVpvlY3llkvmXFGXwvzn45tUuv+nsWi5HYkDtqcLJa7eT4=@vger.kernel.org X-Gm-Message-State: AOJu0YwhjdGq81QGG6uru3IisT5+DbANCvGZ6GMWHWjw5JJzZw3DkCRN frxI0YdW9CUb9lz07W7vz6AOogiVOTUmGQ7IlxWcXFTrbPovTSPVlP8uHYDhsbchZWo= X-Gm-Gg: AZuq6aKhKVBRmY4WQ9bSCV2Q14Y3HLka45HCrUsPI5utqOdLYPl6dva2WbjydW6TpLf ti20ZYaHF9bm6G5j6nD8DgkIE/WPMF1EskN7oE5yuP3f/x+dZacPt+KBlJ2GdNBkqz0LSLV2ZLX t4zdclOA4TncE3pkq35rvK7DcLxJkrRpZPQHDWfcSgX38lF7+a8jRlTtsk+uSlg97mfC5S7ZcNB HJgafjlwNnT1obxxqv9hNRb3pQYyadRj+pk8VGYPZBvFIwK+2aHcpYwKgyX9Cqt+4TJ8F5Q7ZYS 6r+3BB46U3rxg8ebAbQpMSX7YsjSLzbkyTVqfpz/iORZMzK+PSScnLdLK/ogjhIi+Y1bUOQ9DB6 VoDIT1qEO6lmLNP2tbOnOybc7Jy90nmaFhk5614+WbXJH1uMgcTdbXs2JxitrvnveOJnLKMtIBq GkfdbFfWc6uvcjabfn57k91xl3P9Y3efjggNFNtG5WvWbIsEZdoXk5Iauwi83rxt1WyhNJ6NaMu jOfmqerc0GAztflMiD6u3/n2apQqsK+wamKmoSw0Ok= X-Received: by 2002:ac8:7f44:0:b0:500:d108:275b with SMTP id d75a77b69052e-506a8261401mr189490801cf.5.1771350615435; Tue, 17 Feb 2026 09:50:15 -0800 (PST) Received: from security.cs.northwestern.edu (security.cs.northwestern.edu. [165.124.184.136]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-506847d9852sm186225731cf.7.2026.02.17.09.50.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 09:50:14 -0800 (PST) From: Ziyi Guo To: Paolo Abeni , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ziyi Guo Subject: [PATCH net v2] net: usb: kaweth: remove TX queue manipulation in kaweth_set_rx_mode Date: Tue, 17 Feb 2026 17:50:12 +0000 Message-Id: <20260217175012.1234494-1-n7l8m4@u.northwestern.edu> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" kaweth_set_rx_mode(), the ndo_set_rx_mode callback, calls netif_stop_queue() and netif_wake_queue(). These are TX queue flow control functions unrelated to RX multicast configuration. The premature netif_wake_queue() can re-enable TX while tx_urb is still in-flight, leading to a double usb_submit_urb() on the same URB: kaweth_start_xmit() { netif_stop_queue(); usb_submit_urb(kaweth->tx_urb); } kaweth_set_rx_mode() { netif_stop_queue(); netif_wake_queue(); // wakes TX queue before URB is done } kaweth_start_xmit() { netif_stop_queue(); usb_submit_urb(kaweth->tx_urb); // URB submitted while active } This triggers the WARN in usb_submit_urb(): "URB submitted while active" This is a similar class of bug fixed in rtl8150 by - commit 958baf5eaee3 ("net: usb: Remove disruptive netif_wake_queue in rtl= 8150_set_multicast"). Also kaweth_set_rx_mode() is already functionally broken, the real set_rx_mode action is performed by kaweth_async_set_rx_mode(), which in turn is not a no-op only at ndo_open() time. Suggested-by: Paolo Abeni Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Ziyi Guo --- v2: - Add fixes tag, net prefix and Suggested-by tag. - Add explanation of safety of removing netif_stop_queue(). drivers/net/usb/kaweth.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c index c9efb7df892e..e01d14f6c366 100644 --- a/drivers/net/usb/kaweth.c +++ b/drivers/net/usb/kaweth.c @@ -765,7 +765,6 @@ static void kaweth_set_rx_mode(struct net_device *net) =20 netdev_dbg(net, "Setting Rx mode to %d\n", packet_filter_bitmap); =20 - netif_stop_queue(net); =20 if (net->flags & IFF_PROMISC) { packet_filter_bitmap |=3D KAWETH_PACKET_FILTER_PROMISCUOUS; @@ -775,7 +774,6 @@ static void kaweth_set_rx_mode(struct net_device *net) } =20 kaweth->packet_filter_bitmap =3D packet_filter_bitmap; - netif_wake_queue(net); } =20 /**************************************************************** --=20 2.34.1