From nobody Thu Apr 23 09:09:42 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C05D6302741 for ; Tue, 17 Feb 2026 11:31:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771327914; cv=none; b=jep7p+fVjk4dYhDj203W5un6qk5mP2KvPCfTNqM6gTiYpjPS/MnfDhCELddV2rke2/RqX2rC3Nb7e8XaSjAdeQhOxtfSNIBmTMzlnQyXvKLbMkH3hqlNPaL9r8c8pL9kVUoH4c0Ust4+QAfuSDrIOu8HdiQfHjOacHS+vGbxEhY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771327914; c=relaxed/simple; bh=A+edGfhNUSAdpz53Yj4yLYWTYRjAcMaFYefUDHnbxhY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Dl0l7lPBvcSpn9hNM0G5ZpzP0m88Q2WsvJqwpakXxwtoBqhoeW3cCIY8ClowDTTzygosVQsxdjb4I3fKsfTdFgkYcqOJBCy+Oxo0a5pDAN7HIQuvgqXS/I3tHr7RzHEFYfPF/fRq3RSLIoIkni4wvk/m1c5lq0t4zb5hdHCtgqI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kVf6Rt8O; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CUfDnMNG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kVf6Rt8O"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CUfDnMNG" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61HAkMZ3597031 for ; Tue, 17 Feb 2026 11:31:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=8RIDGS7I/Y6iuZvXDaZUiKDoW3f88m9v7mj zm7QvuFw=; b=kVf6Rt8OySfrN+EnMlXREA1ngVYUK+8pnGlmKwq2svkply+cmkg rXZvyCctBjHddzFa3di290f4KpSsAJIragWpx3vlTjpndXcUSRsNc+ZMm2KApyaY 3YFRHp/xH7/rpItDPlb42GApkHfr3Vdr+e4/s8NXT3g4ejnahzFLqabvQ8Ifu1gh PTd95eOUKYSU69en5UzZRV+BaLZfBbLDCdAqlEYcJRT5e+6zHWU607Tz1cFlEgEr H4xRuj3BXPPL4HqiFSATzZskFhVrQXDGfRQVtF96pRPeCkHOhtfhRmBMi6Cm6UWR yxeTD8jwJSlILgVy7DyGNZ71lz/dP1Zp5Tg== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cca361m59-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Feb 2026 11:31:52 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-824a2df507eso11743698b3a.2 for ; Tue, 17 Feb 2026 03:31:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771327912; x=1771932712; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8RIDGS7I/Y6iuZvXDaZUiKDoW3f88m9v7mjzm7QvuFw=; b=CUfDnMNG0/4rTCh10X1TW0FTAKx8wXckZgOVbtsU6NQhpah07nnGLi3igYwWwysxuC waRQaRoq7luT88aqu8YLerY8Py+HpmRW5QQymwx/D8IsEH07TjeiSZdNKxmSq1vIbGZC cKfHhS4odXC64vM8oWhhgJLknRyqEOiGXJDObuj9Eva+IeW6hQwrC1iG9L6NUMQDLYcw ylhO92B+uP67Ith11clojHA+oGK9nJY1nNmzeFHCVSp6sUtHsDotq0bFL5GY6ApKdyfy iUmbTnOL0J5+ENlbBuQA81PffsMk1u1UTWtrdA6VA1uboQ0IolaeNvGvaZ7fTuEvBo/W K5OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771327912; x=1771932712; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8RIDGS7I/Y6iuZvXDaZUiKDoW3f88m9v7mjzm7QvuFw=; b=TalBHut1NlBHkbQkCOaDyGnBiX9E/d6mLSUkwz8vcctz55paiwVOSl/Kzfqe7F3ubS wBpKEQgvUEGya8NyF+JnmCUFMT5iamVt3d9NqZfERSlmrWjMvKp9QJ69rsXPtfM/fzLD 0owhIT2XPSMFeCMj0RfzO24WruK9rXinhy+bYeK9HDwIX2ymHgwCxZt36UYfMTa1VWtz 6oO1o5/YNPUCv/8oXTrmhQWxgEH04bWOYeiHq7gmkIigQhCHfacQK78MHMrCnBS5DoKh 0nCUMQMINKviztHg309jwLjDL9BncfkTvp41vNbDCHWYJ+FbDoxpy1qokOh5DjRbmS8t 1Zng== X-Forwarded-Encrypted: i=1; AJvYcCXsvD4cADCrw0RSbZ6XYdQWsWjCfyE+HowjJ7QM1oVKr8QdBwWilp07DzuaJLDhpEBaPupyWsOUZvGDwL0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywmlz/j6RGdS54KN8kVBJczZ2C8eGCIlXwfwlxT39ZXef2Ca1Aa /iZDfNmolFHUhicx6NzPMgNzwCkkGbcd6iLC5U2arAavJCBwW6lQoMwnPJ89+g0fGYCIgOg0wxR Tzyk5ROYeMdZ5CEB1QJtkaRocw298oJt3tYWT4r81p7uMFYHXwe4/cqdGKW+Vc9naI9k= X-Gm-Gg: AZuq6aJ4jGuCZ0a1kIXBF87uX2O3W5scRBBmhUjL12n5ZftJ8AoPRnPIlOj7z6Z70MV uVf/HIIsLUhFi7chcwjSOcLT5je1qs6zuDfgq4SbcK0PHLQ0RbpLpoWpICvf+j6kMqPKsLcZymk 88AgoVLZTniGokPEBgEnNs8EnCIfrv0nryHqxovv14zTCUApvlVKSYtFXS4Fd/ghi1RPRqbatPk omtCstV5lMsGp1Qxl9Vdo0hmq04QDeGtc1FImJaq4Bwox6wBsx49Yis+P9oi7y5IHt1bmprMrGG BWCGAYpH4QJUMzh1EqY4+2p8zBeRosAdYdSr6EDhFBztzwwnMg7kYB1u5kvHuf5D2pHwm2eKt1E qxZbaAXj1+PeNMYmpxbdYmQnpfZIcs8v9xiw2d2I= X-Received: by 2002:a05:6a00:44c3:b0:824:9451:c20d with SMTP id d2e1a72fcca58-824d9633e83mr10435019b3a.62.1771327911975; Tue, 17 Feb 2026 03:31:51 -0800 (PST) X-Received: by 2002:a05:6a00:44c3:b0:824:9451:c20d with SMTP id d2e1a72fcca58-824d9633e83mr10434994b3a.62.1771327911426; Tue, 17 Feb 2026 03:31:51 -0800 (PST) Received: from work ([117.193.209.158]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824c6a2ac83sm12372958b3a.12.2026.02.17.03.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 03:31:51 -0800 (PST) From: Manivannan Sadhasivam To: jingoohan1@gmail.com, mani@kernel.org, lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Neil Armstrong Subject: [PATCH v2] PCI: dwc: Proceed with system suspend even if the endpoint doesn't respond with PME_TO_Ack message Date: Tue, 17 Feb 2026 17:01:42 +0530 Message-ID: <20260217113142.9140-1-manivannan.sadhasivam@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE3MDA5NiBTYWx0ZWRfXwTKDzXqfDGuZ RuUeaV7AUpWucS+bf5/iI9yLDt34NNSSm51T61KjX0d2XVNemdrmSjj43DDmJixh30OZXMh3VpA yvBDVXcslB1A2XnwZb5zYysjsufLmEr0o3YElbEJfLc2FcJYybDYpSjzi+pwOKPjfL6CR6B98Rn I2UBbGhM7OdHmMm5gRH1WtaXLJyulC4Wsi7V5wcDPLMY2i8IqR8Hkp8DOsFNCcAljPQWvyoZvPO KQ09j4dw+i5y6csAEfm0kIAS3LxFyeCI+rwC1XIGt4wbKLtIYfdWhYiUcGxII6hgv2l2ZR2WjfN F1WBwUn3vzxFlB186TGtTnKkLW8bVzOGpZleRJaId4tvvBlbYbQ+dLjVfkvDZOxNNWUZ/RCWXle WrcjyiopmAOAmWzZf2CRg62DZUgQpfiG3Uyjr58irHZ3YD9hyh+hxyCTZ4VkXhM6zq6u+O8fBxw WNuO9Yk1rqV1972PFjA== X-Authority-Analysis: v=2.4 cv=b+G/I9Gx c=1 sm=1 tr=0 ts=699451a8 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=SjHr3uEWn81Gzxy87858+A==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=8OcN5Qi1sVG3Ylv8c8YA:9 a=2VI0MkxyNR6bbpdq8BZq:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: RvVEH0bLeEY7MQNDDceOwP1pnpigkzHN X-Proofpoint-ORIG-GUID: RvVEH0bLeEY7MQNDDceOwP1pnpigkzHN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-17_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 bulkscore=0 impostorscore=0 adultscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602170096 Content-Type: text/plain; charset="utf-8" PCIe spec r7.0, sec 5.3.3.2.1, recommends proceeding with L2/L3 sequence even if one or devices do not respond with PME_TO_Ack message after 10ms timeout. So just print a warning if the timeout happens and proceed with the system suspend. Reported-by: Neil Armstrong Signed-off-by: Manivannan Sadhasivam Reviewed-by: Frank Li Tested-by: Neil Armstrong # on SM8650-HDK --- Changes in v2: * Added 'ret =3D 0' to avoid failing callers drivers/pci/controller/dwc/pcie-designware-host.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc= i/controller/dwc/pcie-designware-host.c index 6ae6189e9b8a..ba183fc3e77c 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -1256,9 +1256,13 @@ int dw_pcie_suspend_noirq(struct dw_pcie *pci) PCIE_PME_TO_L2_TIMEOUT_US/10, PCIE_PME_TO_L2_TIMEOUT_US, false, pci); if (ret) { - /* Only log message when LTSSM isn't in DETECT or POLL */ - dev_err(pci->dev, "Timeout waiting for L2 entry! LTSSM: 0x%x\n", val); - return ret; + /* + * Failure is non-fatal since spec r7.0, sec 5.3.3.2.1, + * recommends proceeding with L2/L3 sequence even if one or more + * devices do not respond with PME_TO_Ack after 10ms timeout. + */ + dev_warn(pci->dev, "Timeout waiting for L2 entry! LTSSM: 0x%x\n", val); + ret =3D 0; } =20 /* --=20 2.51.0