From nobody Sun Apr 19 09:18:50 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5805331A59 for ; Tue, 17 Feb 2026 11:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771327487; cv=none; b=SjvWcrSVbvWF/OjRCVk/7tXapR1dswBqgedTu/Ipbtyd17VUFkKM3/kz+t/ejpA64webfr+x4WFjyDihj9y8Rl9TlPcYpeAMGgmyN1IbcjD72ZRF2Pm1+6+nb57/hAC4P8KRLputQ6LUOHi2DFd83xun9RbuVIfbqVU0h1Ce2t0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771327487; c=relaxed/simple; bh=iKt69Ev2cDAHIcEtVWTDlH0t7RzwTpLdooqI1VoqhTo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cdhFCuEw3hTLVggvvOrqN/BKucJNAuf5QgEzXD91/tqtp3qAey+cU9j9fKJ/E3R5tq4pyc0jxMxrtPo2xW2gM0PJMiF1v4zZucFaR+0bXLuMhfQD2G4Wn+ZHBpHrbWFLAExjk/o3vxihIVdZ6g3+RV/9MlxlnR2vGOsJtJkWVOw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JZY8bqlU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Xbg5oL8L; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JZY8bqlU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Xbg5oL8L" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61H8IZpx297036 for ; Tue, 17 Feb 2026 11:24:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=tzdtf2gBTGfcSK53xronA+EV+UsP+WxBuPc s2eqZxOk=; b=JZY8bqlUp1p86oxP0p5UxN8ZtRQgljqibWGwcltan1zo9bgOjCB G+Am2sD5a0pdhx27NtPtRqASffRGGsaDvskmQ2YavTT/JQcatTGw0NHT23uPXr3v hwS5ZwF+5WENTzA8O7K8EyxtQ2SmUsjOpTXdrdnYaHiCqTG/mB7K05S05fEq2BHK FixEPvTsCLmkFzMUNEGh2oIj0I4uDo3HEbV0zMQnTlSxGgZYrO5Tb+aotjPHoC5f FeQgL28ldfHCn8E3ovbSIW65sG8C7OLmE5bFKl5ZwfGg0sikhD1xL9vY03cj5It3 BjhmROMmryUw5AHOKI5GsLj9l4MM0lI2tCA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cc6a9t450-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Feb 2026 11:24:44 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2aaeafeadbcso48223925ad.1 for ; Tue, 17 Feb 2026 03:24:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771327484; x=1771932284; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tzdtf2gBTGfcSK53xronA+EV+UsP+WxBuPcs2eqZxOk=; b=Xbg5oL8LtZPm3PY1VAKeZ16ThtUu1q79MGuKriyte1NLJ0uB8042XIS3YfPjfjbdo9 phb5n9FItIYp4Pu671d1BzcI/H+mat+dGf1eC2WoUpwrxfPkNRlD28KY7M54AWcBIiyS M7aHLL4lvpm9kevIl0f8SKLD2Q1kEyA0NYnNmP2vvUoG1/pWsgsJXGsopinp1I4Zlei+ 6NwbEBxSeJ66gAZPa/glqhwNMT/qX88ES2kaV5cz2AddVlY+qn+H9VPGsyPCv3gGYxXO 1aikAYOb8tYKmnFK9EuNGKLNMI8FtmEjyMjNu3aS+4WiurC4p5FrJZxTIw+cqNm3Y1n4 yCkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771327484; x=1771932284; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tzdtf2gBTGfcSK53xronA+EV+UsP+WxBuPcs2eqZxOk=; b=u6bzsGSGhxYX8aIBNMu9RB5BSKHT6uOSpPKQkzPQf+y0Qw5Ozf9QoHcNaFnpIeiI4f shJn2CdJh50eVP3pmglt522+dXgW8GdqhbWnJqrNihAxqruYDOoZmRODLsjdR1xsfH/P K0mPvKB4mwBxDQ5Iw0CGxwyjrQonJ1OuSV0Ez5f/MkqMbdK6t/E9H9PqtRNOaklE72aH 86euOc3gxMBkLp4QN+bih5fIrAYETq/YoxQDARnYvEou9VLe+yCfWOjEEMzPEx9cDOrY qCPZHysLru2mQbX4k8hhSkaKUJ7tfMN40iXM65+KO4V/k9uhpQoEfTY/uYcutiHNSX/3 KaeA== X-Forwarded-Encrypted: i=1; AJvYcCV+vBS8/vX43HrHhO5Xl9PorZKG8du5GVWH2GeINPKgZ6cnBnhPwvfn5xw1TRmeJIyUhPaBgKANjYpnZcU=@vger.kernel.org X-Gm-Message-State: AOJu0YyEe0PCPLK0tBw0FbZ48PrOVsznkdHRmIc8mneGAzmPXBTXTWoY GYM/XfiGSWa3FF4R82mQu8hP41BDqUcEVjiy59F2mR/j3AXFNBC2523HCrXEoIPEYT/GrNPJzMN Owg46Z862DpkTehXen9u3AmcCKVMYlbgX3qMAF3HDqYmT+Zw3Ip0uygt5Sua7YHkO36A= X-Gm-Gg: AZuq6aKOOwVxiYFbelJsb52UeT4x5qhuOTYPjMq0WdnPeNPUAATElCh8JOlxquXaZMG +A4dnNY8qescEGrxLjTFLTLzFLqI8v6w76CWEo0ItHLEDp8phUeqXpjDuYvDaQRoeyaSeW+urHO XAKw1VMYJovM6Pvnz6mhsTkY9MB/T/PZ+DG4W6vWZJi67gOQFpaUtih1TVOdoy7JORLrvXO0kkD /3uF0WPaSbsJ4X8sowmU+SN6A7P6IzCJHzNhpTA0CpDNCtRXQfE5OZAMOPTsj+g31d5fnIOyMGN 60PTEDw/s4Zga7Eb3a3QL28KIrXBKxoFQAE8cOBxwXoYIHekOsiLNLhTqaOv7txstOdBy1Yt2re 1EPqYPsvBPQx+cHMM1QYoZekIgdqyKqKnutlqY7Y= X-Received: by 2002:a17:902:f787:b0:2aa:d816:e1a4 with SMTP id d9443c01a7336-2ab505c045emr161246615ad.31.1771327483878; Tue, 17 Feb 2026 03:24:43 -0800 (PST) X-Received: by 2002:a17:902:f787:b0:2aa:d816:e1a4 with SMTP id d9443c01a7336-2ab505c045emr161246315ad.31.1771327483284; Tue, 17 Feb 2026 03:24:43 -0800 (PST) Received: from work ([117.193.209.158]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1a6fa33esm102091905ad.13.2026.02.17.03.24.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 03:24:42 -0800 (PST) From: Manivannan Sadhasivam To: jingoohan1@gmail.com, mani@kernel.org, lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Neil Armstrong Subject: [PATCH] PCI: dwc: Proceed with system suspend even if the endpoint doesn't respond with PME_TO_Ack message Date: Tue, 17 Feb 2026 16:54:30 +0530 Message-ID: <20260217112430.7955-1-manivannan.sadhasivam@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE3MDA5NSBTYWx0ZWRfX5+LCsyybp2/v qjQSSLPrZYSiFwGIERsD9vFVaFa4RFBJwMA1n9yCyWmBJZn5D1Ma6pA5/FVY3LJvflJoBdRgcoH JRD4NZbBg6ecHhPu/jHjAH8Pfyhb2kHZnLyNXpsn9a9sqUiwr1e6jYEy6PIs5sDOngwI2677fmo 7FqEb7PUj14zFlso42/xfhF48FpPKn9k6A29fJyykqREbfXSoeLFkzrT6Sjp9U+YBJBev73WSSv htI5vAqCwlx2s1gP+Nz4TrqKCyilKII6OHPg7sOPi7P7+vufx3ZQxF0QSYlrsi+262E0m4rBM1M IDt9Yfxkcfp28f1q7XpxVw7ynqMcMmEoc/B0uqD0xh15JUh0C8JfKRXqGtpKikSB1h8UbKmwiai d3a0ChqllrwjOW58JtslkYVMqKfV+rVMipZH3KV90MaUmFGMM+rzC8IB633lfOkprIITsKATAXN l0Th/ky2e8+A1zvXzOA== X-Proofpoint-GUID: cTYKArpdCiwVRxN5KP7QwFhAcP5BCyz_ X-Proofpoint-ORIG-GUID: cTYKArpdCiwVRxN5KP7QwFhAcP5BCyz_ X-Authority-Analysis: v=2.4 cv=TPNIilla c=1 sm=1 tr=0 ts=69944ffd cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=SjHr3uEWn81Gzxy87858+A==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=8OcN5Qi1sVG3Ylv8c8YA:9 a=uG9DUKGECoFWVXl0Dc02:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-17_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 spamscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602170095 Content-Type: text/plain; charset="utf-8" PCIe spec r7.0, sec 5.3.3.2.1, recommends proceeding with L2/L3 sequence even if one or devices do not respond with PME_TO_Ack message after 10ms timeout. So just print a warning if the timeout happens and proceed with the system suspend. Reported-by: Neil Armstrong Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-designware-host.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc= i/controller/dwc/pcie-designware-host.c index 6ae6189e9b8a..c01e6cafd255 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -1255,11 +1255,13 @@ int dw_pcie_suspend_noirq(struct dw_pcie *pci) val <=3D DW_PCIE_LTSSM_DETECT_WAIT, PCIE_PME_TO_L2_TIMEOUT_US/10, PCIE_PME_TO_L2_TIMEOUT_US, false, pci); - if (ret) { - /* Only log message when LTSSM isn't in DETECT or POLL */ - dev_err(pci->dev, "Timeout waiting for L2 entry! LTSSM: 0x%x\n", val); - return ret; - } + if (ret) + /* + * Failure is non-fatal since spec r7.0, sec 5.3.3.2.1, + * recommends proceeding with L2/L3 sequence even if one or more + * devices do not respond with PME_TO_Ack after 10ms timeout. + */ + dev_warn(pci->dev, "Timeout waiting for L2 entry! LTSSM: 0x%x\n", val); =20 /* * Per PCIe r6.0, sec 5.3.3.2.1, software should wait at least --=20 2.51.0