From nobody Fri Apr 3 03:13:50 2026 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BBC1221F39 for ; Tue, 17 Feb 2026 04:11:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771301476; cv=none; b=WY36R+w9pnfeanvIACtxumdMy5TXA0YsGEg6cEXvskCos8pRlXFolT1GVCPAT8fqdszGt4Vp922vRhMlGsfqBgm8YHGHshqmlzKovmZOGmcBad8gp0LNXLYv633WK21gVTEVTGaaAxm1Z77iwwG7LpTtXhA8mW/O29sycqp3ypo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771301476; c=relaxed/simple; bh=9NLhp/OJQuOkOsss0BkDyrqirQKgzJKeBi0XSeKsyRc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Vwe6qQlh5CS3n70OFmUg+IkGR4p7EBtLkBp2/TCUrOx6xlmQB9lupSvi9E957/EGUOJKTr4ymfodEH1+sWiN4MigCMDdNEvlt2AR6y58ax2vJjbmposN/5MHi1+RVfTAR/vGpNX4vG2xR3GAfs+fBImJm083dsCNHQ1JuAdu9ho= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QjVg7jpM; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QjVg7jpM" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-79273a294edso31585277b3.3 for ; Mon, 16 Feb 2026 20:11:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771301474; x=1771906274; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Y8c6DkdYfRGECPUo+HrtR+bQQEfpevZZZT3dyCzulfI=; b=QjVg7jpMktsCAya3Ch791m+pfhUQA2MxfdSfGEqaESxr/Hkm9ji7ya62ejsG5diKOx E6woOebS2RdhMP8d+dfxhpr1TjdnoLDfkWd9vPGxHuWhq9myFLnCj5t1v0fe0kySX67S wQd4ykzBdktawgm5vGJptBvnFPh77LF19K1bhxwRHW0OFYZrYDkiv3Pd0Qg0lHoLUnIt aP+ILbcfojV3A2mhQYbbeIcgisGD7ORjXG+cXfI+TmiZBZB4M/PMSkFocscW/TrUZ1tn j4oSqMIaj0/lyari/4P6cyB68g6Xru+5KojYD3Sb81oAaQ600EHwJYeln0t+xFRxh6HB UBew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771301474; x=1771906274; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Y8c6DkdYfRGECPUo+HrtR+bQQEfpevZZZT3dyCzulfI=; b=jB0X0MQ7F2R8JGMhtLvz4mo84GB05gfNUqTNRPvOA4t/WGk6ZlYDd0+BVo90HGwQmX 8JktbUjSOicMVa8GCm0WfeTP18KbTvrWNpiVkTpm9pJw+ySMa5944CcrRmQv5wp7LtqY EvDX88GysPJANexIBmiMGQzCjfHrLAh3inPeXiPBVErFWHiwYpiL+WKljpl+3KDFX7TV 09qSAUY0wmoqwMkFUDxRvsc4eXNtB7G7A78fYJSryWuVLwlYcGHfN+l7Mb5XI3682GU4 /2hbmOLLULGupn0xTQqD6ncSqQ603xzyDznQcpSIWFR4FpTLkjxhqKYENpyu3b2UOJ4N wUSw== X-Forwarded-Encrypted: i=1; AJvYcCVQexZEBMhNMmplHPqr4O8tvCJ1Yz95o5JFcSwkEodaD/jamok0oDSu4ky6ImFfPqcRq8F2cy7YYNYP5c0=@vger.kernel.org X-Gm-Message-State: AOJu0YyfuZu2bTmPkR3VWL3599LnvQQYOEejoxU0AGnLHDfe27joXfBD T4SVeSvRWgdxvkp5t3ZtSaExMysnwT/NhhBP8Jb+29EahNX21c6P9J7K X-Gm-Gg: AZuq6aKmCQ58/5daC1ZjQln12LWufAnC8+O5n+wJuTlr+ShZYJljUoKR32ToqBSy3ab t1f0e7vfN68FuriB8e5+gp0c9vRI9Altl1yYEcxzGYPQZ1dQGx/ax2E32YS1Hm3Yo5XwOfxYPWp Rh4AZf0REFIZu4f0eGJ8Z0a3yj4/ikncMaJUpobI66VCz8isJzUg4+KyjF8rqoGrn//Vsvqsp5s tM90X8Roy0DplFimYKYoUDRmoF0odwRee1VVN8zaFySmb09taliOMPeRwRZAQEi0AQGPH0AxTUZ XGKq0dBqqeBSKI3KSgr5WwyUPA9mVkCoAoAyyTuM9d3nrcaIPERXkp/2tRGjH+0ipAw6pF1V74C xQOMbKcabnS/LCz3SNHuz9dPx2v1rYKX1T3ghzBgLmn4DrjNUUGQybsyBwhu+/v8Bkf4ANgWaI+ S9/VmTgYtzlP/XwvcLkGwwREo4Rju//rROsNmJEYKGFI0JXJobHuDD0/TFsndQ9wQ9iJ4q/ZJqs FtnROhG1fx5290BEluHPh1I+IeVsTRHI/kxbEUiy/AGwdgrewW52w== X-Received: by 2002:a05:690c:e3cb:b0:797:db54:b893 with SMTP id 00721157ae682-797db54ea2amr26523277b3.45.1771301474256; Mon, 16 Feb 2026 20:11:14 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c23c244sm107101737b3.26.2026.02.16.20.11.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 20:11:14 -0800 (PST) From: Ethan Tidmore To: Lad Prabhakar , Mauro Carvalho Chehab Cc: Laurent Pinchart , Hans Verkuil , Tommaso Merciai , Daniel Scally , Biju Das , Jacopo Mondi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] media: rzg2l-cru: Fix error pointer dereference Date: Mon, 16 Feb 2026 22:10:55 -0600 Message-ID: <20260217041055.88912-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function media_pad_remote_pad_unique() can return an error pointer and is not checked. Add check for error pointer. Detected by Smatch: drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:414 rzg2l_cru_get_vi= rtual_channel() error: 'remote_pad' dereferencing possible ERR_PTR() Fixes: d7d72dae81d5d ("media: rzg2l-cru: Retrieve virtual channel informati= on") Signed-off-by: Ethan Tidmore --- drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drive= rs/media/platform/renesas/rzg2l-cru/rzg2l-video.c index 162e2ace6931..bf7d96841c78 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c @@ -411,6 +411,9 @@ static int rzg2l_cru_get_virtual_channel(struct rzg2l_c= ru_dev *cru) int ret; =20 remote_pad =3D media_pad_remote_pad_unique(&cru->ip.pads[RZG2L_CRU_IP_SIN= K]); + if (IS_ERR(remote_pad)) + return PTR_ERR(remote_pad); + ret =3D v4l2_subdev_call(cru->ip.remote, pad, get_frame_desc, remote_pad-= >index, &fd); if (ret < 0 && ret !=3D -ENOIOCTLCMD) { dev_err(cru->dev, "get_frame_desc failed on IP remote subdev\n"); --=20 2.53.0