From nobody Fri Apr 3 03:23:40 2026 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82CB13EBF02 for ; Tue, 17 Feb 2026 02:31:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771295465; cv=none; b=Jo1nvJOjrzr47ORTksnyfomhLsZiZspdOF75W2FXqltc/wveWBD1taL5tdap9IC8vcLx2kV0tMgrR2905i+qoecx+UuUiu837HgMJA0m8/0HNvOFCPGGPQ0KFG5IECs+s2DrmEqqTNX2TEJAwpO7GZuQh8ClEDXqytrEW+zknsM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771295465; c=relaxed/simple; bh=kObS168gQBNE3xpbI2vaprxcEmPUWL2LSLVxVbKppr8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Mfuxy+XLfelgsuiXRv3aYLM+upvmpoThfwwNgPKfU37h5udrX259FG/MkND58lS36+P+kj+ywFI/3ZQ0zxGVeG0ghSCz/qc6T7SERND45QMu3b8g2aIUJomCNh2DgMhT7nsZmFM9TllvdOuLE76n14lfZO+m+LF7yJmqIYTqkoo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eI3A592H; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eI3A592H" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-797d36fdb96so13828887b3.1 for ; Mon, 16 Feb 2026 18:31:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771295461; x=1771900261; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1fworB1P/Jzlnt8opUorAnuBCM+SRM92++aaBkD5qF0=; b=eI3A592Hj1vFCSBKcwrw0jB9xsAgW4ZDNQX34ugMeChWPUm0eZW6gZKZsc7P8CuKHT QoFK9W4j2XPEHrb7AR0IaKfx07yOWm+UBN/ysFcKz9rv33DX3+OnBkQcY0I2QXG3s5El GIpIzuR5TceiRq7T+PukVDnoWDwyLIAZKPgX3iEGYGU/aWvRaL2Sn3l0r1sVmzJcNhcI yg/c3jdQ5AugKbdklxX9ely/JaAlPQRynoHgUJy/pw4sVuUSzRjJ3JjDoRue7MVsQGC9 MBXvxBNvq3euG7wdsBfeIGU/L2f09J0fxsH8sL4po0XTuE2lr1wxbM7yuWXinh0ZsWXJ P7Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771295461; x=1771900261; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1fworB1P/Jzlnt8opUorAnuBCM+SRM92++aaBkD5qF0=; b=psOTPlN/q+70VOHTHOuU7mC8Bg06OQ+3/t8/JwELDuqOm8YEwEvx13DWXOt6r0k9g4 iJ7Mdux2My0m5y6bpmIEVnU1dw6lCW9hSGk4iz8cnflUEY9UXBRgdETDDlYCheEBBGkC FVvhd69jooT0ZL/uu3T845qJ8XHhczUtCeS5Vk5kyhufwiTMAqo9H6POKtVf1jdLbd9g IsXq78pqiajFFqr47wsybDYZVGXnPaRKDeJRZCEJFmfP/KpVhPrY25qbLai8VF//u5iU VTZ9cOhrHZavAq1P798YGPxABRnZh0zVEGMU7iP5c4ga6cRg4lx7gNOOgU39JP94Zc3l o6xg== X-Forwarded-Encrypted: i=1; AJvYcCU645g/SG2XqqY518gwrAVgLuOPJ/gwLqFmnfH29ATkQ7MR4hXU9qyMde91zwEsmu83e7qh71GH2uY+Y+U=@vger.kernel.org X-Gm-Message-State: AOJu0YwxdGlgZSMuGD39+i6xPqG1NbcMz2LiAmJlQFglOs67skmKcXnt 09JfdLIgn/WDsEcisl6G0YwFh7Z4+WjP7SxgnmnbeZ5Xa6f39xByp1MY X-Gm-Gg: AZuq6aKrEwnvNbNTpGY58L9Z3JyipsTQh4emktpDFLdnubomi4nX8sVIfb0MWx2KHfz 4o/4PK4DUeAKdYWk8cAJa+XuqfetPnIgeaG1UsGv0OJPX2TadI3jhJQEccl4X0RKzfDi4XVF4JE iz9rNDAcQSLBUo4QAksYNHX1RlGviHlvlNgTmPqX1VH3wy9Y/NH9zsvbaikhBWWDcV4gYBxz+zk rAFiuixN3HBQRC9M/sKKYcxYRzlZ9qZDXW1ZBKMkYEb77SB+shSq5RCFIZeJfgfgUjOWbJZ8K2v g77lEeNPcgsfiUDrOoOE+9kfe742UC1++/ILB4qcQriKLGWKGOa4TT6WS8GLrQvx9TUoXgWABer j4tNLjCYLoJU0FWdJweTiIkirqFDsgziHUBh5Kw1746Yb8FbGmbxQZx0MgGU0tkexnvWVoBGTzV kbzyVtq3D3yh62XtLi/NkVrFRP9h2jGkGZKJRxVg5J72FHAIuqfIFd71/LX/XPLapnNJbpiOH7p C9y7olybBb7HsneXiuaQWfyK0Ze4lnsyjvnV0PgHhw= X-Received: by 2002:a05:690c:67c8:b0:794:c04d:bcfc with SMTP id 00721157ae682-797aa851693mr89684017b3.13.1771295461531; Mon, 16 Feb 2026 18:31:01 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c254daasm106806247b3.44.2026.02.16.18.31.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 18:31:01 -0800 (PST) From: Ethan Tidmore To: arend.vanspriel@broadcom.com Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, johannes.berg@intel.com, Ethan Tidmore Subject: [PATCH] brcmfmac: Fix error pointer dereference Date: Mon, 16 Feb 2026 20:30:43 -0600 Message-ID: <20260217023043.73631-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function brcmf_chip_add_core() can return an error pointer and is not checked. Add checks for error pointer. Detected by Smatch: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:1010 brcmf_chip_rec= ognition() error: 'core' dereferencing possible ERR_PTR() drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:1013 brcmf_chip_rec= ognition() error: 'core' dereferencing possible ERR_PTR() drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:1016 brcmf_chip_rec= ognition() error: 'core' dereferencing possible ERR_PTR() drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:1019 brcmf_chip_rec= ognition() error: 'core' dereferencing possible ERR_PTR() drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:1022 brcmf_chip_rec= ognition() error: 'core' dereferencing possible ERR_PTR() Fixes: cb7cf7be9eba7 ("brcmfmac: make chip related functions host interface= independent") Signed-off-by: Ethan Tidmore Acked-by: Arend van Spriel --- .../wireless/broadcom/brcm80211/brcmfmac/chip.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c b/driv= ers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c index 4239f2b21e54..dcd8a296de10 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c @@ -1007,18 +1007,33 @@ static int brcmf_chip_recognition(struct brcmf_chip= _priv *ci) =20 core =3D brcmf_chip_add_core(ci, BCMA_CORE_CHIPCOMMON, SI_ENUM_BASE_DEFAULT, 0); + if (IS_ERR(core)) + return PTR_ERR(core); + brcmf_chip_sb_corerev(ci, core); core =3D brcmf_chip_add_core(ci, BCMA_CORE_SDIO_DEV, BCM4329_CORE_BUS_BASE, 0); + if (IS_ERR(core)) + return PTR_ERR(core); + brcmf_chip_sb_corerev(ci, core); core =3D brcmf_chip_add_core(ci, BCMA_CORE_INTERNAL_MEM, BCM4329_CORE_SOCRAM_BASE, 0); + if (IS_ERR(core)) + return PTR_ERR(core); + brcmf_chip_sb_corerev(ci, core); core =3D brcmf_chip_add_core(ci, BCMA_CORE_ARM_CM3, BCM4329_CORE_ARM_BASE, 0); + if (IS_ERR(core)) + return PTR_ERR(core); + brcmf_chip_sb_corerev(ci, core); =20 core =3D brcmf_chip_add_core(ci, BCMA_CORE_80211, 0x18001000, 0); + if (IS_ERR(core)) + return PTR_ERR(core); + brcmf_chip_sb_corerev(ci, core); } else if (socitype =3D=3D SOCI_AI) { ci->iscoreup =3D brcmf_chip_ai_iscoreup; --=20 2.53.0