From nobody Fri Apr 3 03:23:40 2026 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54C722CCB9 for ; Tue, 17 Feb 2026 01:48:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771292902; cv=none; b=FMSI305W/C6bbt+D6l2XXhtD0qwWYk/irzQ9RN4AW3rut028ikASu9rcYuKrfuTiFatbTFPMYFbggOCYb1YvfxzGZ/m9t9kWiOJypCmIGesQwPjmQLmm8T52JACp6gjUxKqEvViyM6Uq8mHxwZITtfcjhLAQy1cYjsOAsFB6Ivg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771292902; c=relaxed/simple; bh=Lwg2rvwrqIRECklSNKlUK55K0k33idFGObhMA9v5xU4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=P15c043kLiYBI8jBqcjRnzxn3axeWzHZEu31N8runq6tII+09ri4yBOXLnNUzsZYXxXDvqZ+Q/4J85A6yjbhLQ//ePQlubeEW7XIXn7qXqGB7EfSoARTdXYR2iOV9DALfCdoluQrUaZMjDIZ1nWW9iQwPonsCoGW3GbonAOdxWw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FJzu9aWd; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FJzu9aWd" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-793fdbb8d3aso33727557b3.3 for ; Mon, 16 Feb 2026 17:48:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771292900; x=1771897700; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BjA8YI4abbHFrmSC0kcj7gswukKzCoDbvbkarUE29Sw=; b=FJzu9aWdKCBUWlu5jBn3Z6BJWPJfmMdfb6SoIChl09oCNUj0zMAYGttjMzXz6t1JW+ i2178DppPIXS6hjqDOh8FPcQql1RGSgzu5ga1/0P0RLLxaLmo+lXLZ/wjJV+TkJdkSt/ jNWRGvMka3ByN8ANS7fvYIetp3sHI679XCPXtN2YuO98XN9CwdhYp64WT+gjzzvgxNcb yagUwWcpysRIT2ENlr1MtWn+ITgLkKlZ1+7JA4oTrr7s9BK4coPIS/n7MHiL98qq2grR 5TNLXiv/vNxdGVciOARfGH60WQzpWDrWnk5vc6aWTjMw7v++Y2wAY3wDAE9KUYXJy+rL AQ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771292900; x=1771897700; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BjA8YI4abbHFrmSC0kcj7gswukKzCoDbvbkarUE29Sw=; b=ngbYczM13XzQ/1OhQkNmdi9nA1iFQ+wkj7jI0lBKRT2DFDfY7vGT5QAAYBFG6gTU+T 0h39HtfoLXANdsmJqv4SLjOmyAN2zS/wvN8YaeM6piTyYLKU3bG5tfsa6gYrsyQkqY2X 2zP3gg1m2n57fZM38bUez5Cd4ZvLFdMH26rJkDu0uzkvHLhtQkFtquDd0l06+hKyTetu 3p8HAZeErOQQs5jsMC4Bj6E/+0l9vCTRL0whyjNAVWPzLvYjQ8tj3/kau2p23xJP7pd4 PGi+hUL90tV1RydF9+0WvqguXFmc6c6+MQz30zcLyWFhGtD8NgDivvpAf6udA3nyXhYK HQng== X-Forwarded-Encrypted: i=1; AJvYcCX8iSSqZJ5ak/XwAtYfexaQqiHHFVbtgtW5RgNWQgomKBUitiN8Via9z/C95/zPs/q9LZNl00xJMlMvqIg=@vger.kernel.org X-Gm-Message-State: AOJu0YzUmMrdx6RJcaLpLXsehPZxVK1hc46St2KI2/UhrnoQtdhhW18x w07/mAHizJq1ddAE096bsu3P9cd2HhTtX/VuIPXVR6Tu4CLcraib0hbo X-Gm-Gg: AZuq6aL1V8QLKIfSef/6pOb2elq6Pa9fOsunH/Idly1FASd00o0SHWgyf3m2FojnBZg 2X/PGGqotZwoQeDyjWmW49Zk3/nTMCMqfzejzrqURJFR4Y2Kf7xZBLI4/C6JQHfH1bbi5I+PnKm vc8sdrlgXTp4nKH+A89bcPs2WmxKE0wTRrIRJxDMLmH+dJtKZTqHUBqB23v+mdXOE1oNlOyV5vM f6jZ0IsOC2VTefooC4z72EBu9d7L+Q90NIts1cUgxsvd2VTImP2RXDMwf4f7cVXQRBKvQaB4hJi T+YM427wJi+42JkKzoF+4GyuQgscnZBAzx1WogqwkIOxZsbMEGGmc7X5+AJgcxmqyh/NajdtqN5 DNnOLzptMEiZNsiSkuXpbsHM7tkMTHdqnaPM+xnNx0Uz/n+J8+2K275RtwrDQ00TFUaKFeYbUag C+bUnrrLrXmFxW+PEx3NCwEzsqLG4f/agvmp5IlAbO8vuupUp1JsbWM1OFCABP+sRtch+sJ/gd2 Zy3CW8DW+wXpz5o0r4s3Qbs8srTLjj/hR4m8cVNGTY= X-Received: by 2002:a05:690c:b1d:b0:796:55b1:a16b with SMTP id 00721157ae682-7979e81638bmr110018307b3.31.1771292900128; Mon, 16 Feb 2026 17:48:20 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-797a668ad26sm43680067b3.37.2026.02.16.17.48.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 17:48:19 -0800 (PST) From: Ethan Tidmore To: wens@kernel.org, jernej.skrabec@gmail.com, samuel@sholland.org, mripard@kernel.org Cc: maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, neil.armstrong@linaro.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] drm/sun4i: backend: fix error pointer dereference Date: Mon, 16 Feb 2026 19:48:01 -0600 Message-ID: <20260217014801.60760-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function drm_atomic_get_plane_state() can return an error pointer and is not checked for it. Add error pointer check. Detected by Smatch: drivers/gpu/drm/sun4i/sun4i_backend.c:496 sun4i_backend_atomic_check() erro= r: 'plane_state' dereferencing possible ERR_PTR() Fixes: 96180dde23b79 ("drm/sun4i: backend: Add a custom atomic_check for th= e frontend") Signed-off-by: Ethan Tidmore Reviewed-by: Chen-Yu Tsai --- drivers/gpu/drm/sun4i/sun4i_backend.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/= sun4i_backend.c index 40405a52a073..6391bdc94a5c 100644 --- a/drivers/gpu/drm/sun4i/sun4i_backend.c +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c @@ -491,6 +491,9 @@ static int sun4i_backend_atomic_check(struct sunxi_engi= ne *engine, drm_for_each_plane_mask(plane, drm, crtc_state->plane_mask) { struct drm_plane_state *plane_state =3D drm_atomic_get_plane_state(state, plane); + if (IS_ERR(plane_state)) + return PTR_ERR(plane_state); + struct sun4i_layer_state *layer_state =3D state_to_sun4i_layer_state(plane_state); struct drm_framebuffer *fb =3D plane_state->fb; --=20 2.53.0