From nobody Fri Apr 3 02:56:38 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011046.outbound.protection.outlook.com [40.107.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A6BE4A32; Tue, 17 Feb 2026 02:46:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296365; cv=fail; b=ai4T/RBWzxg9msaNBxiNEINOXFPPgirfXWX2/NglOC/x+rWIoNkRo6/jY9xuqPZptNxrg8NBJF/T4cWKtHneMG2lMBiStHS8rKcCyi8zSFlA7f3yP8iLPmQqy/ZumLO0atjRfg4hTClRNDHDYjWsSTqReGbWBd3tZMURdMvWuE8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296365; c=relaxed/simple; bh=mIwjB6tGw7C4b+bnsGyT5U5Ezkmqljqgq6F0qnf+6hc=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=SKz8PHuMXja1beCUHXzhHUyDHYAqcEThG1pneMg2rPIsJwx1VvOG/mx84E8sTG/rmweEFx/G5tbsfGhmtMaqvH/SdPCK9rVcueHjIzwVxbihnPto4wLRfB/CCkc1wRK6Us4W0ECOk/cmHX+PgFVQt1gCdftP8zwF0LiMH4edNSw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=hqQ+IDAY; arc=fail smtp.client-ip=40.107.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="hqQ+IDAY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=J9pFZE5i4VtJtY7oIcxkmyBbiGJ3m18Np6CZniqn6Xw8rfpjKAZYob0O0llxAcIa82Zs3EOnAozFw+3NCgQOBKZzO98yjkcE+DIVnjKKxjZHNFRTsJcWszaHAfYNjWXAFCZlboA2JwNLrdy9gzVPSZzZVuqmYdpGL2PwlUOCP0lgGJH1IFJb5bQSAjoI/I6cibnrWCuB1Yus2TIfikJXRRW7DgPmCe/fTs/9SFnXf+2wfjrqwrgM1Rn9AkaLuWBeOr6vp32ky7MfzGubDRSbiv/hp+Y+TFlSipCoXmc41kivyVb8llCIlycGzxCAyO+ZsJwV0F5E/dT4LpwE8aqD5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s9tCrgbO58tcDEmQ0e2WvmQuBupnSxtdBk/lRC9eII4=; b=EW3je60M//uIvpghOrGac5fbcRiHfbAetldXGK7dLekNDd2EpRFvboiV062+tXhM4QLXQvz/kqt2eqIQHgi5dyRoHaz7U95u7BUZ6dh4OdaJvsale4i5s1u7Xog9S9At6VqRzqplDoVaYkVygi2tfdgQwMgPwVdWP5OyIQfSoSjvSqhvLY3AIh7sqjuJzyp8p3lKGuSGgMvJt6MMdCNkOBgtf6XHW/N2OtZjgXFb58gBUUrQH4oTRcbcv2cSt28msh2+oj4hfOluK6fg4GARffxBr7ANIx22SZEcGkv3ADtSepTmZy2wDTC8q9bUwXeoHrCa9uXi6cmKq4ycFThePw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s9tCrgbO58tcDEmQ0e2WvmQuBupnSxtdBk/lRC9eII4=; b=hqQ+IDAYJ206VEnZS7ium+8BsF+LfCO08D4FDCXAL1W59OoTw2ERg1jCRAoVVwcQuWTOa5hcUvPqwvaxDt2j+EwD4o9laWx2JPZPEZRG0TmvFWSXw0dbjhlN/nQJwaL3C58oaJ8GuKo8h3wp39jvqQHYT1tjOLtPiIh3vUuWhklxvNCOllN1XAwG3j1XLsnXCwG+UHvLjK0ZW8M+4qGdQjoNqDTaOkkXxf8/rpT5jo4zk9Xlm28QYvHaHkV3V6YxIvijvQE7M6GCEDi50soYoWGp7FJDI6Rip2nBNQnXZFhX/YVKcAdOe1vEvfogPyY1ogPNzbYA+yUPxwKyREZNIg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS7PR12MB9476.namprd12.prod.outlook.com (2603:10b6:8:250::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.16; Tue, 17 Feb 2026 02:45:59 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%3]) with mapi id 15.20.9611.013; Tue, 17 Feb 2026 02:45:59 +0000 From: Alexandre Courbot Date: Tue, 17 Feb 2026 11:45:49 +0900 Subject: [PATCH v3 1/8] gpu: nova-core: gsp: warn if data remains after processing a message Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260217-nova-misc-v3-1-b4e2d45eafbc@nvidia.com> References: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> In-Reply-To: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0146.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:31b::11) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS7PR12MB9476:EE_ X-MS-Office365-Filtering-Correlation-Id: ba9409a4-8ea6-4ee2-cae0-08de6dceae95 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Z0d4TlBmbWtJZVVtTEVzZVhldkhPeFFUdEFwS3llUk0yVXhHU3MwS290dG9q?= =?utf-8?B?ZVN4Y3NKMDhKZ2g3YmpEU0lTd21ZQjJKN2NBbEo0bXd2SDNMTTdCOFdRNStw?= =?utf-8?B?bEc2SWV0dEZHU0RXa2pRSEZRbHJ5WDRVb2pneVYwaEgxbXNQWDVWeTUrTlMx?= =?utf-8?B?NHRHVW8yNk9kaG9tYnJJZkpCRzJBbEh2QS9sQ09Sd285WU1VMVlxVHBXL0ZJ?= =?utf-8?B?UDFQTzJTNWtEMjY0bjdpQTVVRzB2RkZjNjVQSzAya1F1em5vczFOTEx1OSt4?= =?utf-8?B?aWx5NEdPK2ZhOWJrUjAzbTAySVNlbkt1QXZmdEI0ZFFuR05ERHZKeURQelRK?= =?utf-8?B?aWhMQi9PbU1NSnVOa2JJR0FIbnJLa0EvWkl0bGhvZW9tUGlIUHZ1UllNOGwr?= =?utf-8?B?WUhKTkcxY2VLVSs2WDlJQzc0dVZ6ZkxRdzFKWHd6SmcwUXFFSHV5Zk5KZG91?= =?utf-8?B?eDlGVWxBamxKKzJnRmZjMjYxaEs1UXFFTWticTdtT2pQT1l6WFFGQnlVTmlq?= =?utf-8?B?WmhuVXdiUjdKbjRJUFlDZ1JHZGVjTytLb0lMbVJUaUwxQkk4U096RVhRMWZi?= =?utf-8?B?RTJFZDlFcjN5c3pmeS9PQjRhQkhIcHVYSElzYWwyZEtFYndUUXdqVFNSY1RC?= =?utf-8?B?R0s5eXBEbmRPakU0dkdaTE9qVXN1TURiVkhack94TE55bjc3QkJhekpwM3U1?= =?utf-8?B?NlAxcUpHdFFEcDZOSkxISGpJUDdZOG9JRWcyQjZMRGZHcmFXdjYwbFowYW05?= =?utf-8?B?TFV1dWlpT1B5UWR6eGRja1JQa0dCZ2pWcTZQZGQwVytLcUJzYzdjL1M5cFVk?= =?utf-8?B?ek9kL3lvSkVWYm9IZ25neFFXMzFiOE0rYi8vRjlzcDNjdTlPeWpyY0JaQ0ow?= =?utf-8?B?QTFVZWdaNWtkamFWYVNGZzcvTC9xOVZPaWFDdHBXay9vOGtmWGd4TU5rejFt?= =?utf-8?B?MTgxNE1aVkc2cDhmUGlCeHc0TTdJNE1GQzdyQnkyeTB0blllWjl6Z3Z1TXFV?= =?utf-8?B?c25kN0xqUlV4TVM3OVZUVGVxSmQ3N1JsN0ZJa0VRdFdydmxsbXEzYmxTaVhP?= =?utf-8?B?SlBsMk1abWtsOEFMckxjQnFBcHNya1lBMzZPelpxN211Wjk4UFNqREhuWDBa?= =?utf-8?B?Rkx0WDZ4endkVnpQcXNLbXJTT2U2eDA1Y0xpbjZJYVkwYVlFekd5MEdsNDRG?= =?utf-8?B?alpaUE1iamo3eS9XSGRpQlFlOWhBWElGU1ZoKytlQmx1VGQxUkpDeFRXRVlR?= =?utf-8?B?K1NUK0lmazRteEtOMWk5eTRJV0JlVU9FWWJqd3B6a2VLRnRiNWxvbEFwWUVj?= =?utf-8?B?dGZTblVpcEdCQzlmTzRBOXMyZ1pwTmJlTGE2azVXRnAwQ3QxZFh0TlErODFn?= =?utf-8?B?aGFFblFrZWdld0NNeW03V1VlYWJISTY2YlB3MXZkeEhDNDBqbGlCVERRZFFi?= =?utf-8?B?OUhkT0wrQkl3bkZ6aUsxMlduN3dldW5mNUNZcThteG40Tm1WWVAyQWVzUW5Z?= =?utf-8?B?VC9aekJHbW56dTVsMGFaYzFhcHRxSzQ2SldYMTBPZmxrdm9mY04rb0U4YlhT?= =?utf-8?B?MWk4N0N0a1orSWJUUnlBNUQ2UHRJZkRPekxXemE0bmRTTjUvcGU1d1diNGFC?= =?utf-8?B?TjNjaXBpcXRPRE9RS1FVZG9EY3R4RW9JWnNvRDlOSUg2bjlCV0FZSVRvOStw?= =?utf-8?B?bitYTHJQTmIwd2NYM2djaWYxMVRobmJIaGU2cmR4bldxWklLQ3BNRTNJNy9m?= =?utf-8?B?VW9LN2RmOFdZKyt3VUVoMkowb3VVVFZBbnl1eENJR0NqVXZseGVUajR3NHVa?= =?utf-8?B?eWRUM2NhM3pNZ1dQUUgzRXZZQXdSSVFNOFZqTThMdEkvRGphY2RiZzhGK0M2?= =?utf-8?B?RzZ3WEtIWGMxeVlSNTRXallZakpOckNVZTAxWXlQWE9wMGZmMHUwWWJWTytB?= =?utf-8?B?aGlqTGIyVXV5c3Y5S0h4SGFaV0hjWEtqeEVYcnZSaFl1Wi9jMXJmd2QzWVFZ?= =?utf-8?B?ejNob29OS1p3Z1g3L0dlTlVYTWg4Y2xNZWdXMUpqMkdBQ1pJOUlubVowZHVC?= =?utf-8?B?QjN4bStmaHhGRkZnZDdHSmJWS205S1NuUzNaY1BjM2NEZEVZakpSUUdGRGRN?= =?utf-8?Q?g+mE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2Ezb3lWYzdxNHJaa3N2eXY2cmZ3Ykl3NVhhai9vc1MySUxucERxWVJsY3JL?= =?utf-8?B?VE5BSTlGNmlXQkcvdGdIdmI3R0JNdVpLYmJlM08zenlsZHpCYnlGWFJsY1gz?= =?utf-8?B?Wkg3MExuRG1mUTFGczdSSE81THRmMnFVbHhSVGlPaHBpemIzV0NaMFBIV3Bn?= =?utf-8?B?bHhEbFFScWtCbk1zYWp4bytwREQ2MXJscXNlU1pQNnc4aXk5OUhrMGNuTVcz?= =?utf-8?B?NXBBUWhGOS9iVnd4eVZ2eWV3Vm1KMGZHMldRS25CSVFIdkRyc1Y2WXJXZE1V?= =?utf-8?B?WG9zQVVMNDZxSTc5Z3JBZ2FYNEhYdW0wZTljazlhbUpUcXNDd1FkTW5rb3JY?= =?utf-8?B?MUVwZzRTVHgwL3FHNEJDK0lrOTVqZTdLWXREWklzR3pRSUhqVkkvcmxKTXA2?= =?utf-8?B?Z1hVOWZuN1JIalU5clhmMmxVNkJWYy9mNFZnNWN1VmFoaEt4QzBWOHFkdW5W?= =?utf-8?B?ZWlpaGRpWStsMml6Z21INmxFZG9CUzBFaTRzcElPQzcvS3RuUzdES04rSDNx?= =?utf-8?B?Wi9ueFhnVXU2TkhGVnBGRzg0SlhJN3N6a05pOC9RM1Mxai9YQ2pFRFljeC96?= =?utf-8?B?TEZuTDJySVBSb0pWSkNmWGZaczJ1YkdNNzRQMndZdjM5cUVXeExmRjAxNzlM?= =?utf-8?B?K2h3MGEvSlhTY1JzNkJrZmZXTzlIWVlNS0xaejR3eTJ1QXZKbndzMDlTb2Vj?= =?utf-8?B?TnEwbGQxZjZWV2NCeXJySE9aQmtzZzJiWDVXQnNhckxiTXRuQlhYSkdYN1l5?= =?utf-8?B?MUVDdEpKbmFWblpHcS9RcmhydDErYk15eEMzOThtVUpqTllNWEw5L1Jib1p1?= =?utf-8?B?aTVBNzA1M3haZzBkOVhUZFJQOGxPWXp6eFh4TEhyYWovYUtuUytpaTZ6V0t5?= =?utf-8?B?WlNxaUFwZWRLLzVtQ0RpQkcwSmgxWWQrdkpFd3ZBVm9FR0dTV21DaUZ2azNU?= =?utf-8?B?bDRSMk9JK0tjYVp3OXRyeFhEaFRIVkUyZWxQWFdkNVE3d29HcEhaVkUxaURt?= =?utf-8?B?aVpFMzFmVGZFR0NpdFdBbjBFb0FZejQ5ZkNXekYzRkJpU0duL1ZCdmpEZEx6?= =?utf-8?B?dVFnSEtkWXdPRFlISXZLQmVRb3dMVzZNbE00OWwvTXdWWHRSSUJZdXp0K3Y1?= =?utf-8?B?ZDJHbUtRcHZBcTk1dEdhR1kwRDU5ZkRHWElScVpOb3RTVm94T1FhNmFsemtj?= =?utf-8?B?WEJVZXNjM29PNWU5MFdva2czd05aWjN4RmlYbTVoakFabUtPSFg0MmR4aTRi?= =?utf-8?B?aVVZMy9QbFAxQ1FOczhUQWFHVnJxMFk2YkhHVCtXM2FxQWdQd3JDVlBTK3Bw?= =?utf-8?B?UVFhdGgwSkZtbU5mOTYwZWFaVnlyK1RENERla09OQk9Qci9yVnBRZERyeDZK?= =?utf-8?B?bEJPYlpNc3I5TnAwK3lVQTQ3M1VJKzNCOGZsZHZib054N20yUEtRdlZNeWtY?= =?utf-8?B?bEVSemRVR2xYOGl5KzZZTmNDeXVRaVo5TzVHVjVPN2YxYzc0aTQwT0xqd1Yy?= =?utf-8?B?M1NNMmRRWGR5TVo3NTlKa1FGbjhTSVZkRzBHSUNxVGc0RVFyaHBUUUFyRGpH?= =?utf-8?B?WWt5cDEyWGxXV1ZjTU01MkNJbzA2T1hLNXhWM3FURmN3RUdHaFFxMTV4TmpZ?= =?utf-8?B?MmtqbVNIaCtkcmtRdHIwTVRER3pWMlFZaHNRa1FUUUc4VWtLWGVUdDFrRUdX?= =?utf-8?B?WTQvMnV4V1NzN1F2RjRpNm1kaXRRWnB1U1Z3aFpCMEpZd3g5eS8wYldGbFZi?= =?utf-8?B?cy9vUzBIZkVFZDd2NWdvUkdHSC9WZVZOdlV4M0g2Y3UvT0dPckJhS3RDK3Vm?= =?utf-8?B?U1NCKzBFNXRJVzFmV2Fwa2VwUG1CSnpIdFg0ZGtNNUZWbmhROVUyaDhtOWxQ?= =?utf-8?B?QmNqdi9QRmg4cndVVERwZEZwclRKN1ErZTcxRWxhOGFFTjlieXRrRE01S2J3?= =?utf-8?B?RHZQMkFNRmdXSFBEQ1JyN1JjYVVkZ1U4SkpEOURHWVZMSENzTHlMUnRONDNF?= =?utf-8?B?NitWN09WVytZZm9kaURjb3FELzUvcUR2bTlYdUkyQ3hjZGR2cHNDVEJDMmhN?= =?utf-8?B?UnhPeURnV1pXSkxvSEk5SWszMXBkZGhRWVMvaEw5cHJZZFdYdEhLVDJWcldH?= =?utf-8?B?U0F6L0xJcytmK1FhYlc1UU4va3F2ZzR6Tkc5TG9PanJMY2ZtS0JtaDJmRmZw?= =?utf-8?B?SHJJYUpuMW9wZE56dEVyMVErYzVjQUc3OHY1Z2U4T1pzbDViQ3Q0ejByZ2dF?= =?utf-8?B?Zm5icmVSODZJSTk4N3Y0OUk3d2MvQmZoT0VJbWZZdzdUWGVIblVYRVlldVpy?= =?utf-8?B?K2EwbklsbHF0cDM0MnlOT0N5NXhLNWNuUlluQVhNbEg0Zy95UnRUakZvV09j?= =?utf-8?Q?lTsLYEhRu8P/l+KhrlVDzTg8ovCPo3iWm/gFFgKnboYCc?= X-MS-Exchange-AntiSpam-MessageData-1: kSgar5uwQJ8qYw== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba9409a4-8ea6-4ee2-cae0-08de6dceae95 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2026 02:45:59.4484 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MsQN3cdNNtT12soPbbwMXBoRHRprepKBhmB7NYJYkiOVcwJRMBo79VGCHNdKvpJ6NsE0br/9VaYthQgOSjycag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9476 Not processing the whole data from a received message is a strong indicator of a bug - emit a warning when such cases are detected. Reviewed-by: Lyude Paul Signed-off-by: Alexandre Courbot Reviewed-by: Danilo Krummrich --- drivers/gpu/nova-core/gsp/cmdq.rs | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 46819a82a51a..607fb9ad69b0 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -661,7 +661,17 @@ pub(crate) fn receive_msg(&mut self= , timeout: Delta) -> Resul let (cmd, contents_1) =3D M::Message::from_bytes_prefix(messag= e.contents.0).ok_or(EIO)?; let mut sbuffer =3D SBufferIter::new_reader([contents_1, messa= ge.contents.1]); =20 - M::read(cmd, &mut sbuffer).map_err(|e| e.into()) + M::read(cmd, &mut sbuffer) + .map_err(|e| e.into()) + .inspect(|_| { + if !sbuffer.is_empty() { + dev_warn!( + &self.dev, + "GSP message {:?} has unprocessed data\n", + function + ); + } + }) } else { Err(ERANGE) }; --=20 2.53.0 From nobody Fri Apr 3 02:56:38 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011046.outbound.protection.outlook.com [40.107.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3D4F2367D5; Tue, 17 Feb 2026 02:46:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296369; cv=fail; b=JOsD2sqyWgtaMdNPh8+NYhYLPFnJ9YDlJL244lK9Fpf5SkqPKWuYTDE8DuQGPevU4xBFb3NDIk1qRKkeiMNmCy3Hm5hGlk3Umfg6Oip7q+MhUCWpT7O69G3ObjWhxryUPhX8hFDoPZVOMhA9321Td4uYMibpdAXsvDx5j21xHi8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296369; c=relaxed/simple; bh=2brOPVpaoqymnaIzDRV1e8TpX6QZGgH6XrCMhNTaXVI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=IjgV5CpVmyismJfTlwxmSTYHJFJDNVhvAEwLh0F8fwy1juWmzEhhXSVh8Ik94C/riLdzblKD4mY+CdGSmmC/kYDgSAkDDmMiOEyHdhPHxCliOzwESv9+et27o4jVD2Z6yI1dw5vsZaSAqKq0AKPCgS0hCvVevmNuUo+01kq4+Ho= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=oz6sJEuN; arc=fail smtp.client-ip=40.107.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="oz6sJEuN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DANmo8R1ab2PiTwfd1QT7i+pFvynd9zQNgOVZKUHQUPxdT0nJNihD3q/I8Fr64rbpEYmRX64vwxUNAO2SH9YJpQe7hoDTSmD5pws1G8g8gRG69Nibx/mZpABNF1eAZZf0jRPEB7BmuAGhcaYTmURQo5ju2Uq5mFBycWQ7EGUTVGee8noMu+J01F6aDjJb5RnWEBJyOggE4GtHqwb2Ps/+odJqZUPmY+RoPGKmnrO3it90WTyDCcOp2kwyQTbPHIg0QPMITvScaf86pRwfIPa8AYiFery7umXFszL+o9le/H0rVHs6/R1MEJKZgXpCduwcnREyYmqLxaGYcdh9oXGpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+FDmSy9O3NrC6/0YRKao/8Y2rEN5k4FbXsnOceb/rss=; b=BVb2pxNZpIkGgmggo3lqkuQg6ntEZf562eCubN8AHYqaTNOawNv9+KmeLMm0TXhJ2nL4/naMFrgtfdeNz1s/877iw+DL3Cq6iz86+EdTPfc7KK3IqCz9GHYx43Nt507U0jGmZHAP3wRwELxLwkeTQpEvHDfuK0SE1StnO0z+ySv6GpXAEjx9iLZjE+hsp7iqPmMWmJXPXzNA0Vhkqg2ofOgUgunC3L0HMEm6bra1wyriZCpRai31RX1heI254DqfS6z+b0pkB9f3ADYDKp0BPrIdxOZuTlUH/GVBsGSYzd8ioz0nn/izrZrPCsfYDeysTZINkQU1S9pNfK0fplGrzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+FDmSy9O3NrC6/0YRKao/8Y2rEN5k4FbXsnOceb/rss=; b=oz6sJEuNRIp7vWi5t0gNcNG9Qceespv0h38x6R6aNR0nkBM/DocGFciwIeUeFrfsf6tbDMQ/BhNDux3LvDvYg8FTAOciqhUzxWdzb8YxwGwelqWtofnBdCx/CM84xQqutBhdvCdJWS1j2m9ZndvZqbWr/0CEBwCYV4W5WEVfEoL7SkRFqxci8N6Z1s0VBbzEx4q6UVmkdnrnLp4jk8iHe60HLx4VI0gU9eYM27j0YE/k2qw0HvLuswiTBDrJUkaeWCxNDMOonoGxPkh4/pEJDNqY8F8T/8q/pFDBwMLDPo5TxoRSKBwM2HhLnv7o8cs1bslgs9g2re1SCABE+URIKg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS7PR12MB9476.namprd12.prod.outlook.com (2603:10b6:8:250::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.16; Tue, 17 Feb 2026 02:46:03 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%3]) with mapi id 15.20.9611.013; Tue, 17 Feb 2026 02:46:03 +0000 From: Alexandre Courbot Date: Tue, 17 Feb 2026 11:45:50 +0900 Subject: [PATCH v3 2/8] gpu: nova-core: gsp: remove unnecessary Display impls Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260217-nova-misc-v3-2-b4e2d45eafbc@nvidia.com> References: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> In-Reply-To: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul , Gary Guo X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P286CA0108.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:380::14) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS7PR12MB9476:EE_ X-MS-Office365-Filtering-Correlation-Id: b312b8c2-0fd9-4790-6463-08de6dceb0e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NnpNTXpZQThlazVlRGRwVVgyMjNEdzhBTkp5NzZhWlBRVGVyU2lSTkpyUG5G?= =?utf-8?B?c1ZrcTgwK2pyc1J3NXRqVmZxajEzRmxwMlVNVWdEckVreEd5ZkF4eC9vSjVp?= =?utf-8?B?ZHFTOEZuSGFGWjU4VDBObm04RzN0My95akZtWXlVVUY4K0FzcG5DclRXU01D?= =?utf-8?B?b1BjTHg5RXZiQ2Z1ZURzMzVjRHNSOGo4YmQ1aFlMR3FmYWZtU2xoQ2xtdmE0?= =?utf-8?B?R2xWMTRJYlp1cHlUaElUdnlCV0lWUUZSYmw4OHJIaDRkVWN2M291K3ZsZWFN?= =?utf-8?B?ZmRhZHh6S0g2ejZGR0ZEMVRDM1c2TXpBQk5aVDk4THBialBkZWVuMzljWFd3?= =?utf-8?B?a1ZRK25yN0t4TmdINncrYUM4RDhoMFdKWHN0SjNRMjlxZ3NCSk16NGF2N0pN?= =?utf-8?B?cnhCK05XZ2NqL0dTYmlyRjhvK0hsSGZKZFpiSnZsMWl2ZmlrYmdqcGRiRWEy?= =?utf-8?B?YmZjUmhma0NqcUNXTElHV1dxVVp0NG1uclJPZ2JkaUlvUHNSejJCem84WGgw?= =?utf-8?B?RFlYd2FsaU9vYmFJU2ZZTitMNkdVd3hJUjg3M3NsdkJuR3dTUjJrT1ZKWmMz?= =?utf-8?B?dklnS0loT2tzdXdnRnduTkVlZUE2RTE3M0FzYU1sS0ZwbzhDTkpFTHBMcUVp?= =?utf-8?B?eTVPQ0Ixbm5XQnNTeEMrMU1xUWE0Q0VxUnhRUXU3cWQ3eE93ejBkNGlvNm1Z?= =?utf-8?B?Wnp3REE1MGE1bkJCNkxyS3RJTHMxVlJJNVVpN25qczNIN3ZZdjZiOUxHRnln?= =?utf-8?B?Q0FQdTIyTzRNTElwNHh2dGRTLzJSZmU1Y0NSOURKbnBQdTN6OWt4TkhwN1A2?= =?utf-8?B?ZTFDdmFaNnFycmpHTW1tSUFUY1hnSGVxSUpCYlZKRk9nak44bE1FdE9BM250?= =?utf-8?B?bTlxazdtREZ2Wm1oTVJjbWZpaHY4WVVPK2drNWFaM01FTEtsTUEyK21nOFlq?= =?utf-8?B?aU9ZQ3lrMzlndmNjYWtIUjd2SXJIK3RZOElCNlV2czJBTE8vZDVBVUVpOFZI?= =?utf-8?B?QlZ1b09ZVXpDaVZMVHhOa3Q4emlRa2VQSUZ3eDd2TU5tcDJBbW5VNFVxVis1?= =?utf-8?B?U0gvZkRPc0lRUE1QTWtoR2lqaEVTMGJuN3kxS3V4dHozNHJEZm9tdzlzNTNQ?= =?utf-8?B?bHB4KzJtZTRaNUx2MFM4ZmxnQUgwZlBSTjV6dWkzazc5S0tDMFVPTHRObXNE?= =?utf-8?B?U2NocmROdW1pTy9GNVIwWlJucEtZMXVUWm1BK2NCK0Q0SzhVa1IvQVE0TlZi?= =?utf-8?B?YUZVeERxYnFCRUZmOTRaNVFWdGhiVnljZHZ3ZVI0eVBOdUxPdFBDbFVFTVdz?= =?utf-8?B?MldlRDNTN0dZSE9OVTFkZ2d0Sm9adXNPZUJmaDZ3M0RxeDM4c1IyclV0ODVi?= =?utf-8?B?WEFHSlhVY1hVZENDZVZyNWZSVEU3NEd5UVZINkI4WHM5QUl6b29xcUVQWXBJ?= =?utf-8?B?YmNMUWZ0dmpkTit6ci85QTJnMlFvQVdmWDFYYjQ5RXdKbVpVWXN1TnhlWHBn?= =?utf-8?B?cHZ3U3JraE1yZGowdUpobitPMWxkTnJaQWc4OURQSENLbnhRbkM0UzNmdHJt?= =?utf-8?B?enlVclBwVVc2bmZxOTlweStQb1dRcHhKd1ZZb0lWV3JJMmVhNlVkenFHbVhS?= =?utf-8?B?Z051ejE3VG4rV083TkMrQ2Rka2JXbVRMZW1CTlFWaHk2b3lNTHhpamoxRGd1?= =?utf-8?B?OGMwU0FIT3FUMk92NjBLQ0RVb3ZST25PQldmMjBSaEtCOVlsckdCSThhWnBz?= =?utf-8?B?MTJCSzFHb1c3Y2NkbGg4SUFEdmtTSXd1S3BXRWRZcmlKN2FtektDUHJXVGdl?= =?utf-8?B?L0VndzVhZmZPZ1MycUxtNzYwL2pETEtzZUlVSlZ2UVViNVRHNDMxYSs2MjE0?= =?utf-8?B?YWZEdnFBYmpWcFl1L3FvNTdvZU9JcFU1ak1NNys3clZxRkpYS3pkMWV3bUts?= =?utf-8?B?SFE5cjZEaXNoL0pNZ2k0UXBZV0RQTUV1amVDL09sTzhhZUVyYnVIZUNqVWdE?= =?utf-8?B?a3R0UDkvS3FmdmhLSVVhMlVvSXUrajJwYVMyc1Z6TXZWSlNzNlNUVUtxaGwr?= =?utf-8?B?dVJqRUwvMWJtTXNRZFdJMDYzWGtoTGNlcHBFcjdSKzROczgvQlR6SHhWYVFM?= =?utf-8?Q?LLfc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eE5kcUhFL3VSckVPalVEeGtwdTFCcVg1NXNuelFBYXdSZzFPQUJlcCtBT095?= =?utf-8?B?Q1REdTk4d1R2Y2lWV1d2eitTTCtBSXZwTGpnL3lhbGpMSEJyQ3NiTzlseGVN?= =?utf-8?B?ZWY3ZUU4UXd4YmtKWDg3dmdRQ3VnK0VYQnVVZ1NuMnpmK0l2SlVVbTI5ZFdO?= =?utf-8?B?S054NTE0ZnRsTzhYRlJaU1EyZjJnb3dDdmdrSjFKbXNqWVMyRTRSajVOejhy?= =?utf-8?B?WWFtc1NGYzE5VFZWRGRIRnRjemdaMi9QTVdyem9wQ1djNUZJdlhDU090ZWtZ?= =?utf-8?B?V3V4T1B3WFdrb2NiMERiVytRem11VEtIVGJQVzcrNlUyamIxZFEyeWVrcmhH?= =?utf-8?B?eGJwRFZ1U3hEQ0Q1WHUzdGNmdVMwR2NSV00wUXYxM0s3U3JBcWpnR0xJOUtq?= =?utf-8?B?ZGRhME5rV2hoM1pxRmFmaFBlOTZBZHpIcWM0ZllsOVB6Tm5tYUxPYkgxZG5t?= =?utf-8?B?YXpUM3BRL1ZZWldZWTRjdkkrSE9xZlo3cGRvakRwdVYzeVhxNklmVWtDcFp0?= =?utf-8?B?dTNyU0dWZU9UUERZMi93RGRueFk2b3hPT0cvM1E1ekhSdkJQTG1HZTFLaHN3?= =?utf-8?B?MHNYZHlmWmU5VEVsQmNzRWRTdTFSRHdVQ2lZUW9kNitWS3QxMkRYS1NYYVBu?= =?utf-8?B?VzY3NmtZRHV6TU13T0c1OWhsQTh3STN4YzJoeUxmYmp0RHVuSjNJTHFKdSs5?= =?utf-8?B?ZTREMEp6L25vNUZXRHpIMERWd0dDcWdvQ3d0My91eWVTSktWTHlCYUJDSHlI?= =?utf-8?B?ZU1SaGxYbFFDOHdkdmYyRHJuaWJpRmFaRkZXTXo2dDM1YXJvT1pWSDEzZDBm?= =?utf-8?B?RUNCcFl6ZHJNaHpBSkhWT2RUVGMxMXJ6eFpSWXE3aEU1OXk0SDIxR0NaZWVm?= =?utf-8?B?cng2YnNTZkpaa1dwMy9oSWRmOTZsSzFwQXpWaE43S2pid3RBRy8vbmY1ZXI5?= =?utf-8?B?RW5KN0FhRkhmT2tCSW5Zc3kyNzlzUFNQNm1Xd1pjbGVxNmpTUHNSd1l1ZTVB?= =?utf-8?B?NXFaRnZ5Y3pFUTRqT1ZkSHoyMmVCVXl0M2ovTzk0RHVWT3NiYk9PaENlWGh3?= =?utf-8?B?SU9QbXJZWnRlMmIyOU1LdUpHdXpxWFl0VVlyVmVsSzJkRGZPOHhRKzU1ZHlz?= =?utf-8?B?SkxNUlpZczQ2UDZnV0JHME1PSzBtUXhYeUVjM1kxdmJkV2dycnY1ZXdvM2Nl?= =?utf-8?B?cGVwNjMwMGlsUFI0RzBVVEwvQUlsYVFaSnNueWJYVmxFdEpzUkxyKzh3Wkp4?= =?utf-8?B?UHVxSk8yRGErNERIdlNXN3l5NWwrQU1qNk5zcmJQNlIyTlJBRXg1Wm1QLzhQ?= =?utf-8?B?K0hDQ1ZvajVid2ZlVGpPYWZsOEpUYWNQdnJFQVVJVVZyYWJvUHVCWU8wME9W?= =?utf-8?B?SG93ejlFL1ZFZzNMaDc0UVl1Vk44UFArQ3BrS2NKSzIrRFBVRTdNUjVHMmtP?= =?utf-8?B?RTlDcmFVNjdSbyt3emdXaDNjVWdRS2VkTU5JemZiM2d4SGM3bW5DNW1ZVXpT?= =?utf-8?B?T3ptUk44a1RnVGo4RlBEZTY5U2V4c2tFUFVkOVRzVStIaVM1cXpTcm1QMkJD?= =?utf-8?B?MlprUDRIMUN1My9laFdSQlhFbi93VnF3RU1Dd1NIdis0TWZEVEFKRnJxSWtr?= =?utf-8?B?b01DREU1QitOZXZRRnFncnYrU3I1eGhNMnQwakRyMjcxS0lEQ3lNZ1J4NDFw?= =?utf-8?B?Q21PaE1vY2VQRW5zejhDc201cWJKeGczVW9qSEt0NndubTI4cElaU1Brd1dL?= =?utf-8?B?TERkdEp4ZUhySHJIeEZ5MWR3Z1BpRnlQdytCK2RxL0s1M1hLblAvM1AzL1NM?= =?utf-8?B?Z1ZIM041SFkrWitjTTN3cURoaG9JL2JzRFdQaU10MjdwSFU4eElIS1QxQ01H?= =?utf-8?B?TUMveXB3a0Z2aU1HQk56eDNpSXhNZWVOSytDb2t2cGVCdHV1VVFuSGdnejBh?= =?utf-8?B?bHVQNHFFZGVZQ1NYZVBoQndGQW1tRVcxTU9mRjhQNmNXTmxyT0NxVDVWa0x3?= =?utf-8?B?Z3JSZ2ZaOVZDb21kWjlZbEtQSFAydzdBVmQ0YXEzaWNkcmVUNlBreDFMZ0k0?= =?utf-8?B?K0hZNWVzcmJraGhYTDY5NFc5d3JSY0FpRU5GOWdJZmhyNEh5RHNWeVlzVVA4?= =?utf-8?B?ZHkwTXdQOUsrS3VtYTBsVTNqaGhWVGpsSWs4VXRnRDZIMFdoaW93YktScGRY?= =?utf-8?B?bk51ZVFmYmNDYzdsdWNKdVVzclloNHZxY01NZUVlVzJ6ZDNobk91UkVnc01w?= =?utf-8?B?ZVk3aHJaMFkvOUV6TzRqb0RMZ0YxMHcrby9CUVhVbHVsdHBFZDNsMFVlcXkv?= =?utf-8?B?MndyN1BYdkVVMVF2d25zMDlBYjdvS29XUHJnclYzNTZDcWVHaHpYODFjY0RH?= =?utf-8?Q?OhCWzhgusPeUL4TpAbfHr37hFzNN6H5asAwLau513Xbq9?= X-MS-Exchange-AntiSpam-MessageData-1: wDpsPAejMyfrnA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b312b8c2-0fd9-4790-6463-08de6dceb0e3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2026 02:46:03.2705 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C8yGkWZFdmeh3OOghdIG7u804dYdzeZOuH16si8j2wfJSwBB1DgXjnuXRCXdJkydJRGqgRa0XbweJH22aAK37g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9476 We only ever display these in debug context, for which the automatically derived `Debug` impls work just fine - so use them and remove these boilerplate-looking implementations. Reviewed-by: Lyude Paul Reviewed-by: Alistair Popple Reviewed-by: Gary Guo Signed-off-by: Alexandre Courbot Reviewed-by: Danilo Krummrich --- drivers/gpu/nova-core/gsp/cmdq.rs | 2 +- drivers/gpu/nova-core/gsp/fw.rs | 54 -----------------------------------= ---- 2 files changed, 1 insertion(+), 55 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 607fb9ad69b0..9eabec49849d 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -531,7 +531,7 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, co= mmand: M) -> Result =20 dev_dbg!( &self.dev, - "GSP RPC: send: seq# {}, function=3D{}, length=3D0x{:x}\n", + "GSP RPC: send: seq# {}, function=3D{:?}, length=3D0x{:x}\n", self.seq, M::FUNCTION, dst.header.length(), diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index 83ff91614e36..3c26b165038e 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -10,7 +10,6 @@ =20 use kernel::{ dma::CoherentAllocation, - fmt, prelude::*, ptr::{ Alignable, @@ -223,43 +222,6 @@ pub(crate) enum MsgFunction { UcodeLibOsPrint =3D bindings::NV_VGPU_MSG_EVENT_UCODE_LIBOS_PRINT, } =20 -impl fmt::Display for MsgFunction { - fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { - match self { - // Common function codes - MsgFunction::Nop =3D> write!(f, "NOP"), - MsgFunction::SetGuestSystemInfo =3D> write!(f, "SET_GUEST_SYST= EM_INFO"), - MsgFunction::AllocRoot =3D> write!(f, "ALLOC_ROOT"), - MsgFunction::AllocDevice =3D> write!(f, "ALLOC_DEVICE"), - MsgFunction::AllocMemory =3D> write!(f, "ALLOC_MEMORY"), - MsgFunction::AllocCtxDma =3D> write!(f, "ALLOC_CTX_DMA"), - MsgFunction::AllocChannelDma =3D> write!(f, "ALLOC_CHANNEL_DMA= "), - MsgFunction::MapMemory =3D> write!(f, "MAP_MEMORY"), - MsgFunction::BindCtxDma =3D> write!(f, "BIND_CTX_DMA"), - MsgFunction::AllocObject =3D> write!(f, "ALLOC_OBJECT"), - MsgFunction::Free =3D> write!(f, "FREE"), - MsgFunction::Log =3D> write!(f, "LOG"), - MsgFunction::GetGspStaticInfo =3D> write!(f, "GET_GSP_STATIC_I= NFO"), - MsgFunction::SetRegistry =3D> write!(f, "SET_REGISTRY"), - MsgFunction::GspSetSystemInfo =3D> write!(f, "GSP_SET_SYSTEM_I= NFO"), - MsgFunction::GspInitPostObjGpu =3D> write!(f, "GSP_INIT_POST_O= BJGPU"), - MsgFunction::GspRmControl =3D> write!(f, "GSP_RM_CONTROL"), - MsgFunction::GetStaticInfo =3D> write!(f, "GET_STATIC_INFO"), - - // Event codes - MsgFunction::GspInitDone =3D> write!(f, "INIT_DONE"), - MsgFunction::GspRunCpuSequencer =3D> write!(f, "RUN_CPU_SEQUEN= CER"), - MsgFunction::PostEvent =3D> write!(f, "POST_EVENT"), - MsgFunction::RcTriggered =3D> write!(f, "RC_TRIGGERED"), - MsgFunction::MmuFaultQueued =3D> write!(f, "MMU_FAULT_QUEUED"), - MsgFunction::OsErrorLog =3D> write!(f, "OS_ERROR_LOG"), - MsgFunction::GspPostNoCat =3D> write!(f, "NOCAT"), - MsgFunction::GspLockdownNotice =3D> write!(f, "LOCKDOWN_NOTICE= "), - MsgFunction::UcodeLibOsPrint =3D> write!(f, "LIBOS_PRINT"), - } - } -} - impl TryFrom for MsgFunction { type Error =3D kernel::error::Error; =20 @@ -330,22 +292,6 @@ pub(crate) enum SeqBufOpcode { RegWrite =3D bindings::GSP_SEQ_BUF_OPCODE_GSP_SEQ_BUF_OPCODE_REG_WRITE, } =20 -impl fmt::Display for SeqBufOpcode { - fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { - match self { - SeqBufOpcode::CoreReset =3D> write!(f, "CORE_RESET"), - SeqBufOpcode::CoreResume =3D> write!(f, "CORE_RESUME"), - SeqBufOpcode::CoreStart =3D> write!(f, "CORE_START"), - SeqBufOpcode::CoreWaitForHalt =3D> write!(f, "CORE_WAIT_FOR_HA= LT"), - SeqBufOpcode::DelayUs =3D> write!(f, "DELAY_US"), - SeqBufOpcode::RegModify =3D> write!(f, "REG_MODIFY"), - SeqBufOpcode::RegPoll =3D> write!(f, "REG_POLL"), - SeqBufOpcode::RegStore =3D> write!(f, "REG_STORE"), - SeqBufOpcode::RegWrite =3D> write!(f, "REG_WRITE"), - } - } -} - impl TryFrom for SeqBufOpcode { type Error =3D kernel::error::Error; =20 --=20 2.53.0 From nobody Fri Apr 3 02:56:38 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011046.outbound.protection.outlook.com [40.107.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC412242D9D; Tue, 17 Feb 2026 02:46:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296375; cv=fail; b=NvXW6fwRmH7c513NvoDOXn8z16A/ArtEnBOdNYYGdJw7QsNVs36bAPM7MXZU+rsQ2e+RH9vlinOaBhjZNX1wlud3UT3pnRSkFlX6qJdJ1ahjWQI1FEqAU7mUgWkFx6fNaglxlMIqNwFVJF1BtJu7Vch2GdIQdAE+1chbMBInta4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296375; c=relaxed/simple; bh=rwHv4I7suJ28WsZ1fDcDjZE7dHCYXx0attOCIJoqRFY=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=M9bgoL7oSlrhit8c4TM1VhYH0DvYzHULjZNZQMXmEfQN2X69elaFetJNnr068IqVbc/RIL8PDi9nYXmKUzAaMdGGWSSNF0yTofBSyW1vsUFF70mDTkIPpYcmxV60unOjzSJavFG5KftcvjJMy5/vLHnuqwyhFAVZaTJ3VtzIxDU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=sVK39vB2; arc=fail smtp.client-ip=40.107.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="sVK39vB2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ct1duEU/JvnLDVWVJtPKUxpni29+INDsvaUcVIHL8OHuklkctbMX3f2tlUlbzlyeb14DSUdG8j02w48weNtE3Hn7LYMGKdgdJbfiZHdPV+oIiRkqRDEWRuBXpT6b2FAqAFO3IiceeBxzkyo+HUb4+i8bFbgsdzJ860Bn1+3itdlW0nsZSDfzDMThrfehfhcOnLsgYxmxnFnz8M8featawHB9JZnw6Hk3tKLoUJTIikCiU1eFvfa6Mj1EDinbAg62TEcmazEkElbgjzmg0RuFaFVmEN/8cql6E9LtFdIiQuTqfIJECbWXTMN6YayDW0VGSNx/jQSPP0e2zGXWbW9Hkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BgqAz2VIZR6nSjL/nHGYokUKZjiojvqvS6BvvJ8XRxY=; b=iJJWfRJeIVEL8T6oeAp/XqjRMpmVoeGdo2b6gZ7keHOtumuyZsl+0vWMGO0CCFfYlAsu/irfPeMc30B/pdSwU6DvfZHDDrFlZUa2E5gJCHofL2aUxdHYA4q/oFzq2YnIpQxc2e3sJroNW3Hnbamqnc7HA795BdxosXLkB/ZbOzIDIkLIwi8wpRsHwmvzO3H27yc43xXPjTQ80JIxEr2InrgqPirbFcYCSSk2+EmHiY8d8x6dliJRIcO6a2N5b3v0JGOA6CAnwHPzPevFvpDbr1jEojY2eYLhRFHqkiPvbma0l7t4pyV86l+d5YLkrWY/gyDmPJeBqF7b9+ySQ3dq6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BgqAz2VIZR6nSjL/nHGYokUKZjiojvqvS6BvvJ8XRxY=; b=sVK39vB2BshyUQ6CVzbNooyZYKQE2jX71OzHlgcLnvItj4myrw6PEIM14tjPE46cg+F+gQrDYtMyIMaMevBNv3bvAqsHaUa5XLPNjy++X1x+E9ZovzGsfOzgpqh3FpeUrIujFu8moQfVntnvwAO/05dbfxKMb57gIRBB/UZdWsqBcByGddfubm1bKEjzKt/+ZBmzdpKgy+cvOzVTXbKHmBg/g25VM4y68cAqW9w6y0gdFCQGHu5y0wZVSVyucSe8oo3hhUFZW+UevH4KqM4bho/2ER5dpsoOHLzsHxDfpMmEIlhv/ALXtLgxzRcP7+rjhhaWwOYUQwl+JECwU8O1mw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS7PR12MB9476.namprd12.prod.outlook.com (2603:10b6:8:250::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.16; Tue, 17 Feb 2026 02:46:06 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%3]) with mapi id 15.20.9611.013; Tue, 17 Feb 2026 02:46:06 +0000 From: Alexandre Courbot Date: Tue, 17 Feb 2026 11:45:51 +0900 Subject: [PATCH v3 3/8] gpu: nova-core: gsp: simplify sequencer opcode parsing Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260217-nova-misc-v3-3-b4e2d45eafbc@nvidia.com> References: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> In-Reply-To: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul , Gary Guo X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P301CA0072.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:36f::19) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS7PR12MB9476:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e0fd2e3-ecfc-4aca-8149-08de6dceb2cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZW9SV21BOHNHb3RLSlY0RHozYTdZM2VOTGt2a0Ixd0xRazJTWlc1eEVrRnFF?= =?utf-8?B?S1BaWTI3SkZqcmJuNnIvY29lWndiZlhhQXdYWmtPZ3BWZTBaSGFXVEMwM1o0?= =?utf-8?B?Y3I5TkF5TnFmZDNScmhHUGhlTEhXL0pQclE0WmRDMlFqTktwbkM0Z2F4L082?= =?utf-8?B?VWVwelFVRTFENStxQ3RYL1JMU2JpVzFYRTJtSjFnMk84RDkzNXZtOTNLTDgy?= =?utf-8?B?YlNuVDZOWjRSTERZUWFJQUJaTGlwWWR5KzNmUWxZTnhERyt4ZUtlMTY5NVJT?= =?utf-8?B?elZMMVdqUHJyOU5rcm9BQXlNcUVQcmZveTFGbVJiZE9rZ2JyWWVnRW0wc3VY?= =?utf-8?B?eGszME1KaXNVVGZjOEc1aXVBZHFYdlJmQXQ4cUFyQWtHNHdQV3lTNDIyaXFp?= =?utf-8?B?ckRDekNVTERTOXdBVkZWUmpINzVYc1hGcDBZTmFPdHNSOG9XTTR5bHJqL3gw?= =?utf-8?B?amlLeUNQeEppVGVYNGhkVTVQRVRZWmpsdDczeVhmY0VXRkk3clJRT2k1U044?= =?utf-8?B?bHJGUjRjNmNoYU5UU3B6MDlXWVRuV2ZnNWVxeUJCODQ2ZWFpM1c1TVljK1l1?= =?utf-8?B?TjMzRytoRm1Na2tPRmt1SEh3NVJSNmwrdGl4MGswcmtKNFJYUUNWRFFPRHZ3?= =?utf-8?B?UEhiaE04RUVIclgwVkVPSUwvZDF5Zkp5b1kweFg1YmVaU1VhY0cyTUpOdTgw?= =?utf-8?B?Smt2dkpBRjg3V2N0SFV0U3BQaEJmUnNLbEdrSlQ0N3F1cTlDL3djOHYxanZG?= =?utf-8?B?VWlBQ3B5eFJ2dFR1eDBxVEg3US9jUmZDVGxFQThvbnk1R3JSdWRXcHllSjdw?= =?utf-8?B?dFpUTTNTcjIySDNqQitobEgvRTBRbDBSQ1Z0MUtxdDdKbWo0QWlIZlc3R0R4?= =?utf-8?B?SmlZNkhUemIzUzBlRkpjUGdLakRsV0xzM2htUkVyT3Z5VisycWVTS3lQdFNU?= =?utf-8?B?UXNGNlVvRHdVYVBnUEhIUWVQZFVHRnAydHRQZURRNVNvcUw3N3diZEFpL1R2?= =?utf-8?B?eEF3cUJpQm9hc0U2TWovN1R6YzNwTGdNMkZscVNZak1XdFdvMlhBUlBuOXF3?= =?utf-8?B?Zng5M21PbE1TMmh4U3ZxdTNFVzc0RHZadG1pYU01Z2c4TGZBcEs3ejBtWU1Q?= =?utf-8?B?KzBNM2RpQllqVkRIS2NMQ2MySzl3TmtxanZ3dk5Lc0VlRENUdmZ5QW9UUkZx?= =?utf-8?B?T3ptRi80UlpiTjNFYzdzTm1BbGNWWkIwampQb0xEczh1d2dhYm0rK3M3R2pz?= =?utf-8?B?cy9NVldCYjNqUW4xYW5zOFp3bUhvVlB6VXdHV1Z4UWdKZGdsZEQ0TUt0Z1Vy?= =?utf-8?B?bmxERlZZTXprempXbzNjK1FqaktueUdxaE1JODhDRTZsa1BYejZHNzhkaW1E?= =?utf-8?B?cldnR1VDanlDdkVwS1NCUTB6K3RXNW9yTzZkcG52aGYrdTQ3WWZGcmIrSTR5?= =?utf-8?B?RUtpSlFmcHgveE5DN0gyNzRXM1ZVWWU0ZHhDT0xzaG95cVBKUHl1TnNzVDg4?= =?utf-8?B?Yk5TMjVHdDVKakhVR2l5VVJSazZmOXZHYjY1UXVSdW1vb29NdHY4ekJDS0Jh?= =?utf-8?B?NnNUY05CcXZvMTNUQmFUVEt5elJ1eHh3cUpIR0tyaXhSZmpjdmFOSGp4c091?= =?utf-8?B?b3QzL0ZhdUZ2ZlFzOTZpbXl6d0RzNFUxVnVjc3pJTnU1TVF6a0RnLzJFemx5?= =?utf-8?B?cDhSMmlYQUV3d1lLVlpaYzdqWDZoajVUZXZIcHgzNmlkeDVDbGRnanRreDJR?= =?utf-8?B?RzhkdXFPaWdaTzBQMWIxMFpQQ2tGV2J2RHU3QjVaQkVGYkR3VkV6VjB3S1pJ?= =?utf-8?B?Y3FpL2VlVHpnZWJqaGF4RytGMlJIVXJHUFY0WmdRZHI3OEtnSkw0MXNBcG9P?= =?utf-8?B?aWVVQm1HeERKSS80NU5UUzZ4SVdPcUxWY2h0czRlWkUvc0d5YyttNVZKeTBY?= =?utf-8?B?K2lyZDJvRVphU083VFpKV2FJeW0vTVU5YUd5d3huajVya2h3aDdSbzVVYjZy?= =?utf-8?B?Z0pGN3Ewa0U3c0VoamZ2M2VRckFzVmhvT0phRXZoQmxJTEJTdFp6U2VXeVNB?= =?utf-8?B?cHZaMWtMclA4UUlSQXpBRlB0YVV1TmxJaW5tdzcvWUhMUldFQy9nMUZaS1ZN?= =?utf-8?Q?hLUU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ykpqd09TRi9EdURUZCtueDMrRkt5bk16N2NwbG5MdlFEWFJ5SkR0MDJzQTBq?= =?utf-8?B?ZnBwaU9PRTR1cjFxRkc0Zmp6OG1reURKUzEwci9YK2hKUUdhYUtiZFdYY0py?= =?utf-8?B?MkdyMy9TRDVQZVV2WWdQVnBxeFA4UmNuQkpTWlVOc3M0QVNiQUZUVmw2VFBP?= =?utf-8?B?K1VWOG5qS2VSdEtRNGV3am9tK3VRc2lMMEZQVGtqN3VPSDdzajlQOXZxcDQ3?= =?utf-8?B?QnFXaUgydjFaWHFJbWNCcHpnSHVqY0pmc2F1eUkrb3l5cTFiRmpyOFJCVHk4?= =?utf-8?B?akc1TlZNL0UwcWtESlNpWVJFLytyeGZBWno3OWFScCtQaDNZRWIvTmZxdXhn?= =?utf-8?B?N1pMQWU2Qkw3K0RiRmxCNWh1Q25OZktrOGdwTTBCOTBGNVQ5YVBPRTNPcjlU?= =?utf-8?B?UG01bG9vREEyT2diZTh0L04zSkZ0MGVtSmpGWk9qN3Z2cUdRSkZFb0l0eXlK?= =?utf-8?B?NXZ6NUdpb2pweGdPNGJFazhTTkZrVEQ2ZEJBOHlSL0RsYjdCeVpSTkRPVDJr?= =?utf-8?B?WWc2YWNvcmp2RVJyNFpxWmQ0NzJCb0xqODZqcDBvT2FXd3VRcmsyYlh3RTJS?= =?utf-8?B?cDVIVGsrUmlDUkE2YmNNMmNKaUcwc0FUdTR1QWZpR3c0U0VZb0YzNjBQTEEz?= =?utf-8?B?MDFuNzdsOGxXYlJPWFdXMjdDU3ExVUpIWHI4eVJWdVhxK0U0ZFNTZ0RnT3l6?= =?utf-8?B?YktSWktTenFnazRiL0xJbUwxcnI2d0xwNXZHaEdwMUZZc0E1WHY4eEFaelJo?= =?utf-8?B?THN2S1dRWVJwYUVSc2U5MkUxVXNwTnIrcGYvc2hNNWM5d2dqWGo4dERQVk9X?= =?utf-8?B?clhVb0xSTDgvVmttY1RUY2NkMEpQSG5KUDQwYU42MnJJNkRXcDNMR0ZaOTZq?= =?utf-8?B?YkluZGhVNE5HNTJqTmJwY0xpOHRrZGJSVlpkc0NuQVFocmpFQktwcXNmUlZw?= =?utf-8?B?UUV0MG1zMjBMaWZxaGZ3dDVscGowaXRlbVA5dWc5TllVK2c1NEZJd0NrNlM4?= =?utf-8?B?UjhwUFdEbExqSzF1cUFhSXpXaVlCcmdwN28rVE1LL29HNDlJRE5MME40aG5l?= =?utf-8?B?dzFsVHJzWWRvSDV4Z2Y2cEVvRm4wQ1ZMWERYOGkvSHhHTHRKUWZydlZyUktH?= =?utf-8?B?VE4wb1NWN2RTVitKSjlkU0F3NUxqb01pOHIrcFE1cTVuaWRVMHdvVmc3TVpG?= =?utf-8?B?VFlXenhmdjNaTk9TQTM4VGlWelFpZW5FVUtVV0drNFY4aVY4Q2E4V0JWa0hC?= =?utf-8?B?ZDFDV0Y0UFQweHNjNUZZbENHT2sreVNjVzlIOU4vUU9oY2R6eUZFcEt0UWZY?= =?utf-8?B?M0pLMmhFc0NJV2ZvUzZSemNFbW1WZ045V1c0enF4b0hJdDhhSWNDdDR0L3Z2?= =?utf-8?B?ZlhXQWo3V2piS2VPcUo1eVAxZHI2VjhOalc1NFlHVEtYQmwwWjlrNzRHZjdm?= =?utf-8?B?UVRFaHdaSGMxcFU3Y0x1ZG1mWVorYXNGbmVjYWxGMTNnN2hEeUxXWTZLTFcv?= =?utf-8?B?QXBQR0xvTWZ4SitnTW0weGtJRFVuWjlkVXNQQWt2RmN6WEtOK0tnQURtTSt6?= =?utf-8?B?bkYvbjZUcGpFazlMemVFLzlUdHVpT1FjditFdGQwSXBQazZta0VzR3hPQVVN?= =?utf-8?B?UXJsWk1TUFpCcmRHcGR6cFBNd1hGTk42MmJaakR4WUxrSHpsYVFxK1Y5a0lH?= =?utf-8?B?dGdLcjFZTHgzemdySjB0L1VsVldaRkJkc2hRa0FveW1pZHBQRFBFZGFSenhm?= =?utf-8?B?U2ROWmp0cmtBbkZoZkJQTW1leXVwVVVzZ1BjK0cxRDlTVUpHenZzb05ZWTlj?= =?utf-8?B?OHk5QzZUN0xPNk9VcmxKSE1nN2JOUUZPYTBjV1U0RmtHVUd6MkN4aUJUSjFF?= =?utf-8?B?TnVLc1lndmtHVzI5NkU1dWdEVk1Lb1JPT2g1Z0JSRkl0NjBIQlZaVkc5d0xD?= =?utf-8?B?YjdwWnRrTE05enVxWjJEZCtXYTl2bjgrTHY2Sk1XbndxSkhQZ1Y4VFFWYk9l?= =?utf-8?B?aUFJMVBvRjVXeGxnbVFOTmE4NFNjNlRDNmRNcWFoRFRTY3gyWUdIaEdTMDV5?= =?utf-8?B?cWt5VFpMNlZwbGFyQkx3eWQvMExybXUrK21BTHMybng5ZVkvWm16ckk5TEJL?= =?utf-8?B?V0R3ZUFjbVJqZWFlK1g0dkJYY3d5QVpiODFYTDhZNisydTBRU2IvdkIvVXgz?= =?utf-8?B?RUpyRXFyWjk2dHNZU1ZMOGNCOXlaUjRHTWVWWkRZRjhLS3Vsd1FYWGRFQi9m?= =?utf-8?B?WXpGSCt2am0zdGN4OEJ5V3VJM3JzeGNrYTgxOEdjSDdwN0tuRFMyblZKbURW?= =?utf-8?B?Mm9PL25JVUNEUDJXS0U4WkxmeDQyTjYzRjllMGs2NnJwb0JpY3JqK0JmZHI3?= =?utf-8?Q?fpTXpKck9OwkJKJDAfhfx/WozycsvWQtONM7VHM32yrXe?= X-MS-Exchange-AntiSpam-MessageData-1: C9xKtghSd+Jo4Q== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e0fd2e3-ecfc-4aca-8149-08de6dceb2cc X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2026 02:46:06.4930 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: El8IAiRZlAZqYkVR+VsPq+KlmPl26G5jYmjZ1wt5igRxGD10CZ6FaAlGPp4Vz3DoSTtuIlBVzpWQuNcMKebOzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9476 The opcodes are already the right type in the C union, so we can use them directly instead of converting them to a byte stream and back again using `FromBytes`. Reviewed-by: Lyude Paul Reviewed-by: Gary Guo Signed-off-by: Alexandre Courbot Reviewed-by: Danilo Krummrich --- drivers/gpu/nova-core/gsp/fw.rs | 40 +++++--------------------------------= --- 1 file changed, 5 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index 3c26b165038e..624f5670ed50 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -472,13 +472,7 @@ pub(crate) fn reg_write_payload(&self) -> Result { return Err(EINVAL); } // SAFETY: Opcode is verified to be `RegWrite`, so union contains = valid `RegWritePayload`. - let payload_bytes =3D unsafe { - core::slice::from_raw_parts( - core::ptr::addr_of!(self.0.payload.regWrite).cast::(), - core::mem::size_of::(), - ) - }; - Ok(*RegWritePayload::from_bytes(payload_bytes).ok_or(EINVAL)?) + Ok(RegWritePayload(unsafe { self.0.payload.regWrite })) } =20 /// Returns the register modify payload by value. @@ -489,13 +483,7 @@ pub(crate) fn reg_modify_payload(&self) -> Result { return Err(EINVAL); } // SAFETY: Opcode is verified to be `RegModify`, so union contains= valid `RegModifyPayload`. - let payload_bytes =3D unsafe { - core::slice::from_raw_parts( - core::ptr::addr_of!(self.0.payload.regModify).cast::(), - core::mem::size_of::(), - ) - }; - Ok(*RegModifyPayload::from_bytes(payload_bytes).ok_or(EINVAL)?) + Ok(RegModifyPayload(unsafe { self.0.payload.regModify })) } =20 /// Returns the register poll payload by value. @@ -506,13 +494,7 @@ pub(crate) fn reg_poll_payload(&self) -> Result { return Err(EINVAL); } // SAFETY: Opcode is verified to be `RegPoll`, so union contains v= alid `RegPollPayload`. - let payload_bytes =3D unsafe { - core::slice::from_raw_parts( - core::ptr::addr_of!(self.0.payload.regPoll).cast::(), - core::mem::size_of::(), - ) - }; - Ok(*RegPollPayload::from_bytes(payload_bytes).ok_or(EINVAL)?) + Ok(RegPollPayload(unsafe { self.0.payload.regPoll })) } =20 /// Returns the delay payload by value. @@ -523,13 +505,7 @@ pub(crate) fn delay_us_payload(&self) -> Result { return Err(EINVAL); } // SAFETY: Opcode is verified to be `DelayUs`, so union contains v= alid `DelayUsPayload`. - let payload_bytes =3D unsafe { - core::slice::from_raw_parts( - core::ptr::addr_of!(self.0.payload.delayUs).cast::(), - core::mem::size_of::(), - ) - }; - Ok(*DelayUsPayload::from_bytes(payload_bytes).ok_or(EINVAL)?) + Ok(DelayUsPayload(unsafe { self.0.payload.delayUs })) } =20 /// Returns the register store payload by value. @@ -540,13 +516,7 @@ pub(crate) fn reg_store_payload(&self) -> Result { return Err(EINVAL); } // SAFETY: Opcode is verified to be `RegStore`, so union contains = valid `RegStorePayload`. - let payload_bytes =3D unsafe { - core::slice::from_raw_parts( - core::ptr::addr_of!(self.0.payload.regStore).cast::(), - core::mem::size_of::(), - ) - }; - Ok(*RegStorePayload::from_bytes(payload_bytes).ok_or(EINVAL)?) + Ok(RegStorePayload(unsafe { self.0.payload.regStore })) } } =20 --=20 2.53.0 From nobody Fri Apr 3 02:56:38 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011046.outbound.protection.outlook.com [40.107.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC7B01FF1C7; Tue, 17 Feb 2026 02:46:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296377; cv=fail; b=AB6vjQdDNYOwdVHFeLdwXkCluvTzF/DA4h3V1cdBQsFzTJap2jBFNiab5zNhV6yoybKrvRcoBMxM5kaeRbcox6NI8dfHVUg/Yf/l2yViad9LLoUWrSEit56ef+wbALZsdoS2dASQVgs1uWkyW32kDa4wx8Mrz7MUPhvZCjsVkTs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296377; c=relaxed/simple; bh=NGHWy89uQ9i7NI3RgfPcMuc2pblVE26FGGBrOHiqi84=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=la3Yjkx9T2J+siuDyeX6qRbGm8Um/4PUDwWTgph2cBIi5Nvfx5LpD2TlhLEob3IhRf0Y/z7LcZ1VnkHvNjmsB6s2MMHn5l/mJXA3K1eKDznI6rgoVka+88K9O8wxeuVauzKCC3H+vxteljrcQauawUiqimVXgCr4Is6nESLVWVQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=gsL2h/GM; arc=fail smtp.client-ip=40.107.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="gsL2h/GM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ph/FMCOooASJQYHrVeKemHWxLOgHXnk5QxEm9UYbAf/ozKTGg5/3wqd72Cabx3ml8rScOMBbi5LJ7uo5pktnxQXO+aYCllANoDjqNGxmAaE+pySPWTF+82igyJA53d7bN2jnCVKcHC4NdwHMZber2yEvoZCsKATBD7gWMuynLJKcrQE4JkxWvf4N0eMvC5bvgHhKalVipuxweD59/HW4bNsSRPgS/3R/LoF7eD6LjfkcpPSCTwLruyZ+SMu0/Ia1kObO3Z2yIbIRTs2/JRRv2YBmi+fesFN9cluWCXAI1TcK8pVCjW90c1PCAPyaY+Y/VztvZnrDDW0n8IKr3PQnNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DZdiXC1X1/5kfL+/qkOl1hUH9hyyFCoiM0v27EabG+s=; b=pwbI7A8sz4ndN3tb8gEcZj0gQzfxIcMkZu3G/6z8T4f/MT2jvyPOHMu2AhOe/ZDc7Mjxw+uOhHZf29DAfdWGExFDOPp1hWWJ3Alaj+L38eHC1k7yAsRujoWl0M85MNcNvR8EyrFr8hSZdA1VvYpoIpOODCGWtE3piVagm/L/wfGVBUpzS6v3lYkVeaF0BJ6ww0crMAvQfh6chp0phDaOixBw93Oy0t2CO70ZLcdpj/7iUWRLKFweAwn7ycgndlOIjh91CBjzWEr/Clj8XA/PJo/KiiWevE7ayrXq5MAmdrlur3N+abPM0Afh21Y/6EGE0LtKwNN2dpZ0KZCK8IkQnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DZdiXC1X1/5kfL+/qkOl1hUH9hyyFCoiM0v27EabG+s=; b=gsL2h/GMfpybhWycCiA4iIPgCtUYifhLydr7PxgSdFD2ad0/86zF8EH/h6FuVpDKxwqk4zJLfq0dkaoVYEbJ4I0CrAS/plGLqWbG5YcgvlDh6sPj4q7lvhKWI5E4BsKlGU4rhrLFI2ZMM8iczUhKk9rL2sdkZe12+LF9NVCxUwEhb/EhTeRwXP7bpACPDMErhlT4tiSMUbfCBoYh3MZQczTio5OfbsFvEgZBP/g+q9zzYtvvBXOAlri+siamK5hDGzXInGUcK3LOkEQvCAp17aN8B/y68SKaj8CZu+DEwdMUJnns0HK123UAE9Q7XUCzZAibwiQ1PAbWiZN/VgN59g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS7PR12MB9476.namprd12.prod.outlook.com (2603:10b6:8:250::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.16; Tue, 17 Feb 2026 02:46:10 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%3]) with mapi id 15.20.9611.013; Tue, 17 Feb 2026 02:46:10 +0000 From: Alexandre Courbot Date: Tue, 17 Feb 2026 11:45:52 +0900 Subject: [PATCH v3 4/8] gpu: nova-core: gsp: remove unneeded sequencer trait Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260217-nova-misc-v3-4-b4e2d45eafbc@nvidia.com> References: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> In-Reply-To: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul , Gary Guo X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P286CA0106.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:380::10) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS7PR12MB9476:EE_ X-MS-Office365-Filtering-Correlation-Id: f75f180f-7e95-488f-f313-08de6dceb4f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?THZ1bWJtOFg4VmFPMzBLZnd1S0kwU3VYT3pTN0xiOEIwSCtpbDZrRXdZR1Nj?= =?utf-8?B?ZnNCYStqR3VGR0xJQnFxS0l6WFUrREREZVZUcVAyN2xRL0xwL1RrTHRtWEhY?= =?utf-8?B?amI5dkdrR3hmQitLOWpEQU5ZZHZhV0RiZzhGM3ZSMmVZdlhQWEg2U2Y4Ujla?= =?utf-8?B?ZVhxM2tNTC8vZ3JmbGlpWjFxZ3NoWXVPNkp2NnBFelgwYk5CaHV4a2dMSGpM?= =?utf-8?B?dmUzOEx6NVVEOXFGUHloTGFkaFUyTktaYWNHSGkvbFhnWEN3ZjdYbGNyZVBL?= =?utf-8?B?YzIrZysza2F1YTk5eFJDS0tJMGppSS96V2QyMFhrZnB3WVZIUFpjNWwwb0pJ?= =?utf-8?B?d3huTGpwMDVTaDMvQVhjTE1xWXNxT2QxcWl2OERISFdYTGlPcGlOQlhYRkJj?= =?utf-8?B?S0l4M25nd0UrdXFzaW5DMWVrcHRYMEkwdWY4REppSDNwUmE5VWpWRmo2cjZL?= =?utf-8?B?TkIzZGszd3BPMnFhaDlOUVhFc0NIT09hL0g0RVp3VWZWend4OUxvNjNVa3Z1?= =?utf-8?B?YVlrNG0rTnF2a1AxRzdrMjZwZkZmWi9JQ2YxWkttcHB4cWlyUHlpRno5dnNl?= =?utf-8?B?ZjVJa0ljbzFacnhCQWkwVUI2Z2Y5dStqN1cvQTZ4YStCd0l2TFplUitkcldZ?= =?utf-8?B?VGc3TEdoa213Qms2ckk2aXNZaFI5Rlp0NXpMeWk2MVhEbDdHRFZ6bERDbEZR?= =?utf-8?B?UlFCYXZUQzJta1JxSUFFWDFVVUJQb042ZlVEalROcCt2cEE1VnlOWUplL1Zm?= =?utf-8?B?T0djRCtDTjh3UjRLeHQ2OTh4c1h2bzIvZjExTzEzM1l1WnRWajJRMFFwRk9o?= =?utf-8?B?cXJha3lRWGgyNUtlMnExNjc3NHdIK3NVQldyaFk0dWwvWmdLMXpoa0tCOUhD?= =?utf-8?B?SjlqL09RVW5PdHZRUFFNOWFaaUR5bTNlMXJoN21lQ0c5TEVIdUZGekE1RVJt?= =?utf-8?B?WVpvSzhLS3dhSmZZcytoaTV6SDl4RFFSbGZZMExHTG01U1V0a1lKcDAzUXA5?= =?utf-8?B?MzNKNk1LMU1nVUtXZ25hQldadTJ2ejQvSXN4dC9PNU5qWHhuTitDVjU4a0xp?= =?utf-8?B?VmhlQkRPYmZnTHBzMjFicFk0dC81TDFHVEduQWlFRVlPQ3VDSmtISXlXRU1R?= =?utf-8?B?eWJQQzRxUnJwVlBBa0xVbHR3WGUwU2ZTbGlPbG9iVXpTaUdzbXV3aERQU3FW?= =?utf-8?B?L2N1Q1E3d3JEb29LRXZlRFlmdDN5UjBiMUp3K2U5R2RpV3I5TUhRRURGSXdU?= =?utf-8?B?T0owS3duT0ljNTlhREp0amNsU2lDbjFuUkVoQmNPd0ZBUVFwa3oyRVorRU1V?= =?utf-8?B?djZIV1lUOHZmU1F1STNOenVucnBkZWkyeitySEt3Tmp6bkhQS3RNeFBDK20y?= =?utf-8?B?WjA3ckk5N1Jwd1cyRWRFTm84OE5ZK21wKy9RNTJFTzN5OFlCbEVUM2tlZDcw?= =?utf-8?B?NS81RXFndkdKQTR1ZkZnMGdKVVRaSjRZMURsTlVVaGJ1MGN3Z3pLMjJVVno5?= =?utf-8?B?M1ZPZGdOYkJ6Qm1MOE9tUEF6VHhpR3BIeE1RWG43d2ptN1NLV29oMkRBWUFu?= =?utf-8?B?bFJqVHNyVFhPMjcvc3RCcUFuVGcyclh5Q2ZPODhiZXppcnMwOSswK2FTVTdu?= =?utf-8?B?KzQ2S2tza2o3M21hUFJibDNSajhnU0w4bVdodFFCTXpEZDVRZVVYK0VCZUJC?= =?utf-8?B?WEpERFgrTGdWVGhFNE9lTnc0aGhqK0hYWTVHd1k3S09rYzBldWJvWUZoSVFt?= =?utf-8?B?akRFdk0rZmNwQlpMWjhKQlRhWDI2VjdEOTU1TFNtenU3QS9wWXRLVVlQVjF5?= =?utf-8?B?TjJwODZEOEY5TGZpTjhwd0lET1lJVFA5REE2MVJYZm9hYno4c05CZU1OcktV?= =?utf-8?B?TkQxWFBKR2ZVQzhkMTBXYTVPWi9tUlhhSnoyemlvZVdsa2lWNXpraFJGV1Z3?= =?utf-8?B?dzRsZnl2eC9YSG9TL1lMQUJrb3JTeDdSanJ2M3ZKWW1ObW95R01aTXdNRy9O?= =?utf-8?B?WGZvTFh0Q0w4OXZIVUhpZ3hJWmpVcHVQa09uYjc5TEQwMGZIR0ZETlZPaWZz?= =?utf-8?B?d25UaWJFeEd5WlZvVzNIZ3cycHZOb1VEaVh6NGg5MFZ4TGJzVytGSWoxMGsv?= =?utf-8?Q?9ebE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2x4SXdVWUpkOTRpNWtHMFRsOWRUUk8vbXNXaTdYZUU1MmxlTU9TTkNPVjRo?= =?utf-8?B?SW5xeS9GMFovZHp3b1htTHhzWXZSNlFhSWhOWFlUVEhHWTl6MWNabWl4QlRZ?= =?utf-8?B?b0x6Mnp6UDFaQ0tlTW8ycXRQYUsyMGFWOVo0K3pnMnFPcFFIZmJkMXV3ZEk0?= =?utf-8?B?eC9XWmptNXJ2Umw0T1AwR2I0bElzWklEaE95RitaMDBma2xhY2FJeVM5ZEFE?= =?utf-8?B?d0VMaXZrSzFJWERwcmZpdVE5UXdNM2p5ODNRaDJZRGZTYlpmbVdqbFMwTytD?= =?utf-8?B?U3BnUG1WNDFjZjNrQnIxRExnRTJJSFJhUlBDSS82Z2FMWGtWVEYwNFFBK3Ju?= =?utf-8?B?T1J0NTJIMTJTOW55cnRLT1RaM1paZzhDVVdFK3gyNmxNUUZDN0RvR2I0anBZ?= =?utf-8?B?UHhaYU9KWjE4YWdZSUdhTWpPd3N1T3EyU3FyR2tVVFppY0hOTy9mcVlXdEdW?= =?utf-8?B?RTRNNVA3L2ZjYXUwV0hONFEwdmc4SE5uT00xaWZWTUFlZHpSRStBOThlekRI?= =?utf-8?B?NktEYTc1NTY1UGJaR2k1bW9ET1k2bGs3N2NnNW9jQ3QxRitmdzJqN1h0NXhu?= =?utf-8?B?UzBYQmhDeWpQcUZlbFNrQkhvaUlGTnJHL3MrcDdQSGUxenN0TGZkcEdYczdh?= =?utf-8?B?RjQ3MkJyYU9MZ0JRbzNuUDRtbGZIWGR3MkJKRGhZU3RCeFBPelVOZ2diWGky?= =?utf-8?B?UlVJR1BqN3BDTUdmOEN1S3U2eTdXeU9OU0RCVkxjNEZFUjBSSDEwYlpVWVdS?= =?utf-8?B?aDhMeUVNK0hjMnhRUTZSNFBBR3N6bmQrdmlXSS9YNU5NTTRUelgyZFF2aVBZ?= =?utf-8?B?WEk0YSs3bnJ1UktDdEIvUlVDdGxYSTZDRjduNGVlQitoMkVzTk0wQzdNTnkw?= =?utf-8?B?Q1plQ1VwODdLajd2a3YvUUlUcHRianJtUzRkcEowTkc0djVQZFFQc293Tlgy?= =?utf-8?B?SUVGbUJmSG0vTHZEMGdjR0l3TzFuZnJLTVBzYi9hcjRwejlQMlJNTm1kYUVl?= =?utf-8?B?aTdHNEVra2RvNFg3U3I1TnZzeVQrYTFZNDR3bGJKL1NndU83UWRPM0ZuNG5Q?= =?utf-8?B?bnpQc1pmaUQ2VzZhUzNCSEEyUWREOWswYVE5Y3FUeS9pMVN1dzFGaVNxdFNq?= =?utf-8?B?cjJLbHkvZDRhUEE1OHVHMWhpWDlMUE5pb2d1dldkc1lrV1NDNEg3SGZvT0V2?= =?utf-8?B?aW9PVzlnR1dieVZPS2pHQXJLSnNTN3MwN2kraWFDcGhFcVVJM1E4ZzRXVmxu?= =?utf-8?B?dlVUZWRZQytuUWFjbWFya3JUSnNUaVVtLzZFdjdKWGR1QUdITmFBY3I1dzR3?= =?utf-8?B?QzFVam5nQTNBblNseHdkSEF1Q094dkpObUxNVTVNNmNvMktNSEdhbTljSU45?= =?utf-8?B?Q1VUbXJuemQ2NUoyY08zUVlUUFZFUzZpdDVlSGhFZ2paRFpSRXZYMnMzWU5P?= =?utf-8?B?dlpQTXR0L0JYQWE2Y1o4bkgyM1EwZUtnTkI2OE5QMHkyaWZnT2JuZFhObHF2?= =?utf-8?B?NGQrd2dLN1l2bGx3MnVOdUxrSXdqT2hJbjZNSGdCNmVJYmNmQWV0U1lqZC9y?= =?utf-8?B?aXB3ZFFucTBSZHhteVdFcTE5dzBkTjc4L01pVmg5ckY1eDVod3RGZGlGaXV2?= =?utf-8?B?K0ZYNFVnc2lDNEtFcnNkblBZR290TktkYWx3bjE0eGg2djBxQ0ZaTDZOandy?= =?utf-8?B?dHFlY0FjMWpJVHgyMEt6cVBUVW9VNGVEWVJISW4zV1F3dXVTa2pyWm5XT2ln?= =?utf-8?B?S3VCNTBOcEtLY2dLbmx4R1hPVm5FZDZXa2lCQm4vUzdtZURQVkY3OFdCaEY3?= =?utf-8?B?SG1JSmwvV1NmRzdyVHBid1ZHMEpTeC8wWjZzcGJRcnNsQXpJd3FJU0h1YmJB?= =?utf-8?B?NU1tdlVjMXluZmVoSG5iR3IxME81NnRic1BBZU5VVHZDTmFwWEtwZURIbGNQ?= =?utf-8?B?VUZVUWF6a1hFZWZoVm9MVkJ0N04yc1g2RzU0UVlrV1FFbSsySG53ZFdZd09G?= =?utf-8?B?V3FSSU4xVHJOcEpjVVZ5ZUR4WDVjTjI2QXpKckhOcnB6eUFZb1lwTzBSY2Ez?= =?utf-8?B?WFFwT01FUUNMZVNKazZsckNoOEJOaEU4UDNqakZiTWg2b2F0SmpwdnZuVWJN?= =?utf-8?B?VkpsajZxYWQ1VUF0YTBZV1hidndqTmQ4aVByQjNCZ295cUg0Y283c2xKaVBp?= =?utf-8?B?a2V1YXVBVVNMWEdpcjNocGVOemh3Slh1TDJIdGxJVE5WL3ltUzRMYjRjQkhY?= =?utf-8?B?QTI0Vks4MGlDcE1vRWQxaCt1SzlMSC82NktQdFFTNlBrSmo4ZXg1Nm9hWnho?= =?utf-8?B?RW92MExLOVhKZ3dmV0RDclZNYmw5L0RJRTFrSCtSZDAzNndXenhWRW1PTDcr?= =?utf-8?Q?tY+m6jau2lAICqqaiG8oZcVZmI/RAkidcUlMfvQpZb2X6?= X-MS-Exchange-AntiSpam-MessageData-1: /s2fLMfqZJl9TQ== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f75f180f-7e95-488f-f313-08de6dceb4f7 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2026 02:46:10.1326 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x2l6NSROHs2/SPQmN4XpkzAxN10nRZ7QInss4EazLcARtU9/H3qMqmJ4ZLSDLUw5FEfo4tmzcRvuDQN0vejz7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9476 The `GspSeqCmdRunner` trait is never used as we never call the `run` methods from generic code. Remove it. Reviewed-by: Lyude Paul Reviewed-by: Gary Guo Signed-off-by: Alexandre Courbot Reviewed-by: Danilo Krummrich --- drivers/gpu/nova-core/gsp/sequencer.rs | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/sequencer.rs b/drivers/gpu/nova-core= /gsp/sequencer.rs index e415a2aa3203..9278ffd5216d 100644 --- a/drivers/gpu/nova-core/gsp/sequencer.rs +++ b/drivers/gpu/nova-core/gsp/sequencer.rs @@ -144,12 +144,7 @@ pub(crate) struct GspSequencer<'a> { dev: ARef, } =20 -/// Trait for running sequencer commands. -pub(crate) trait GspSeqCmdRunner { - fn run(&self, sequencer: &GspSequencer<'_>) -> Result; -} - -impl GspSeqCmdRunner for fw::RegWritePayload { +impl fw::RegWritePayload { fn run(&self, sequencer: &GspSequencer<'_>) -> Result { let addr =3D usize::from_safe_cast(self.addr()); =20 @@ -157,7 +152,7 @@ fn run(&self, sequencer: &GspSequencer<'_>) -> Result { } } =20 -impl GspSeqCmdRunner for fw::RegModifyPayload { +impl fw::RegModifyPayload { fn run(&self, sequencer: &GspSequencer<'_>) -> Result { let addr =3D usize::from_safe_cast(self.addr()); =20 @@ -169,7 +164,7 @@ fn run(&self, sequencer: &GspSequencer<'_>) -> Result { } } =20 -impl GspSeqCmdRunner for fw::RegPollPayload { +impl fw::RegPollPayload { fn run(&self, sequencer: &GspSequencer<'_>) -> Result { let addr =3D usize::from_safe_cast(self.addr()); =20 @@ -194,14 +189,14 @@ fn run(&self, sequencer: &GspSequencer<'_>) -> Result= { } } =20 -impl GspSeqCmdRunner for fw::DelayUsPayload { +impl fw::DelayUsPayload { fn run(&self, _sequencer: &GspSequencer<'_>) -> Result { fsleep(Delta::from_micros(i64::from(self.val()))); Ok(()) } } =20 -impl GspSeqCmdRunner for fw::RegStorePayload { +impl fw::RegStorePayload { fn run(&self, sequencer: &GspSequencer<'_>) -> Result { let addr =3D usize::from_safe_cast(self.addr()); =20 @@ -209,7 +204,7 @@ fn run(&self, sequencer: &GspSequencer<'_>) -> Result { } } =20 -impl GspSeqCmdRunner for GspSeqCmd { +impl GspSeqCmd { fn run(&self, seq: &GspSequencer<'_>) -> Result { match self { GspSeqCmd::RegWrite(cmd) =3D> cmd.run(seq), --=20 2.53.0 From nobody Fri Apr 3 02:56:38 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011046.outbound.protection.outlook.com [40.107.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 519DA231A3B; Tue, 17 Feb 2026 02:46:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296379; cv=fail; b=C8Ub2Zuv9maQQazDunW4sX9eqmjescPqRe73TGh4dW1BXBu6KVyN2unz6KMy8OpIdQLrPibXwNKK/4A07COort4kMEUog/p5O313gBRLNuEZOVlotLoo3KDztWqFQQZnsjK0Ynu29NfQwbYSiQB/ijK7ksMR5Dnqlw0hL0sK0ts= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296379; c=relaxed/simple; bh=FYHPQH4QvWZ7Ql2nR80bc6Sv398m+cF/aA0jV/k5ccM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=kr7DfoIxPvCuKmAshJuAzH7l2SZPI9bGAaXpoIDDbtWhZB80KI21DsF4M+lV9BWZ62Qk7pmMY8nLJG7+PvDd4CKwAAeWHy3R3387vWGocrPpcB2oiV5Y4smkYH9F26xyGId6VL3tLASzAMZWSE5GDhYaxfsr0+7pGKicS5MzQpk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=VW1Zbei0; arc=fail smtp.client-ip=40.107.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="VW1Zbei0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VbtVU2cgQ4wWPIZYpI5NyCHFjDuCLtAtIj308nqLat4m/TkoMdNlzJMZy08xmrXx1lx4b0Ua3i3GPusBCe6E8rwvIXu4gho6XOAyXILXXasrVn3SffcUU3p7bIsxgxzKCfbxbabROtCDqPmUFuJ+WOar6+F2Qxbd8TjB1obDC+bUr+rPQjtncb1XVyXktdAqefbf9gdRsq9A5SgSZi0fDV4J9eiTKuKjKG90pql7DZyUNSfLflalYJ4mP50debjuhHGRzBMD1rko0krZOtzrcDsRIMUe4bCsWVL4uh7nNxVg6SLG0G3frMb/Y15tfretc1iveEWzwVWw6C6cItdJJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bbkm2gETjVp4Z0MprIEPS1yRsLzdSXAHY/csiqcwZkY=; b=uTJXEsWb6+OBaJh2rWqL9bqH04vRjE8GK+GSAFRHxY7e1SCUH1RvDBKv4plGRb0MdHE9EeDMs5EI009XvlpQijBjdlIvhPXASDt5VbO9DQtrt30LltATX/Rb9JaAnr1ls4ZK2w+EjMkF+1C8pnzdCuO4risOZ6XiTdEq+kzQsCK7sGynF/CIQ8CzTl1AZz9PMu0hCV7+S2ki1LcU0RhSLJZ7q6rSZvHFZOAf87mRCtgLbpt0Chn4xNAmGqizyJclspLnA0G1hhS+mcoyb2eIpy1+ClkS/x6HIQ9FjIwabECMaTRlMg7o0PMTkEZeKQjDkF7Mpj7NVG1c9AdkNHy/Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bbkm2gETjVp4Z0MprIEPS1yRsLzdSXAHY/csiqcwZkY=; b=VW1Zbei0u+noq1C9/jGTxRYZYoio9LMx92ZUr4h9+ZrtybJ2TiFMBIIWAqWuf5ksTnO89A76GCkMK4xXhGuC2q9HSm884Mx6wy4LFgcaR1DmgWhuFwRrxy0qPV2DkyQvGt8m3jVZm3D0CxmPUqh1kwYn9Xfzh2vWNT42G2Zku87hecJ6TEPNCwI5jeLdy1jLFKVVaJlZzHaJZsWljWtQR07ZLVLj0e5P08YEsOPKjdUXDr2IDkfWqeW8MJO/Qf7UhYteBd0W+QKSsHMWslJtDyl7ngEV7Ed8FPh8RsqaA0fx1tA44HrCzv19jzrqmNgmo5J9Lx2pKCFuIvvLMBUrHw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS7PR12MB9476.namprd12.prod.outlook.com (2603:10b6:8:250::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.16; Tue, 17 Feb 2026 02:46:13 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%3]) with mapi id 15.20.9611.013; Tue, 17 Feb 2026 02:46:13 +0000 From: Alexandre Courbot Date: Tue, 17 Feb 2026 11:45:53 +0900 Subject: [PATCH v3 5/8] gpu: nova-core: gsp: derive `Debug` on more sequencer types Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260217-nova-misc-v3-5-b4e2d45eafbc@nvidia.com> References: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> In-Reply-To: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul , Gary Guo X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0285.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3c9::20) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS7PR12MB9476:EE_ X-MS-Office365-Filtering-Correlation-Id: d0517560-a8fa-4a15-9b9f-08de6dceb727 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SzJwT1FQaERuTG9mVkNhY25TblFHNUdFOVRpa1NIVHBSVWRTZVBBYlR2amxB?= =?utf-8?B?MnRmd2VUbC81R25Fa3BqTzBCL0h3TnNMWVM1cmh6a0FhSjRROWNoamM1NUZm?= =?utf-8?B?Lzg1ZzJFVlFDZ1Z2VG1JVGZOUDkrbmxEcHZxUHFIZE1kRVVqSzFOUVA2eFRh?= =?utf-8?B?ZG45Q1dLZG1saUhITWQrL3U1RnFGbU5YZEwwUU9TSVBOY3FSWDFMeG4zbVNR?= =?utf-8?B?M2xjY1ZvRXVwd1Bpb1lPSUo0R2J1MnVzczl1ajVxNXkzcHRtdFlyY0dUaGJz?= =?utf-8?B?cG9RTklsZnpCUHNQSUV1N2d5QTh1aFc5aDZwVkpsQ1dWTll6bHF4UHhEbytN?= =?utf-8?B?djdVNlJ5VjdSakxSRDlueTNFc3dTU0FkRlk4Nmp4d0FBMldicFEydnJXY3Ay?= =?utf-8?B?dEJhcDVsNjdtcHJSRS9oYlVNTWVHSVJqb2EwSnlRdXFFK0RQRkdUWWlxUjFh?= =?utf-8?B?bXVscWF5dWZ6SzRuWklFRmh2NFkzQUJPT3YzUENtNnFybmhWcVd3SjRWdlM2?= =?utf-8?B?WFNxYWlwUVhqRVh2cm5xNm96dlRFM0tHaVo2OWhCQXQ2eVJCcDV3Q3FwNFF3?= =?utf-8?B?ZlJwejBzbGIxWXh3Q0ZiSnE0T0ltZzAxbmt1YytjZDJKTGJwNWx0dFVLdCs4?= =?utf-8?B?a3JsNnNPV1Z5WUk3TXJtR0NFWU43Q2I4SXNrVHo4cVB4RG0zbFQvVDBpYmRD?= =?utf-8?B?MEdEUUNYYTd6dFhROGJIc1JOdGY4cC9LK3RmQUREbjRmT3VoVWRDWVdpL3A2?= =?utf-8?B?WlV1S0NnL2daZENiWXNHQjhJUVJPb3RLWlErdjBwWnljZnl4WEtsZHlpdVI5?= =?utf-8?B?RGptS0RSY0RjNUg1UFdQRmJIQWp0QjZTUS9NcHh3QXRZd1Fxd1FuVy9Ncjlr?= =?utf-8?B?SndqQUs5UnJ4dnd4YkFiWS9TUGtOaVVRRUhsdTB3ckpJcXJ1WXB0RlVEVXhB?= =?utf-8?B?amQ4Ry9yYXJaTHJjcGxieVVWWE9nSUV2VXNHTHFwaVFJNGZhNnQ1cW42RzBE?= =?utf-8?B?WmMxYzYrT0xhbURFcVlYN2FrVitkbTExTUVJTS9RbDRVWC9LNkRZSVRxRits?= =?utf-8?B?QVBzdkFvbmxiUTl0UnU5YTBCZlk2NlhLdFgrQWhLMkNDTnNsKzZTRzVxeVdQ?= =?utf-8?B?NS9mYUh0clZtT0RrZ2krbmUzcDVVQytKS3ByZ05rU0lvRUVKT3lKaUJEZDdM?= =?utf-8?B?eFhFdWFuaGhuQjJJeHpNSzBJd1Y2V0xaZjI4a1lTNUNabEtvcWV4RVNFdVJi?= =?utf-8?B?dzNsR3kxQ2dGZWpCa1JYd1EzMXJnWDJJRDB2NkNZSk5JOG5rSG1CUnhSNlhF?= =?utf-8?B?NTJiZzlQK2phVFFJSFZSSHdDNzc5UjN3SUM2akxvNHJ0N1ZvRkoxT0tHMHgr?= =?utf-8?B?WjZnc3kveG5hYVdiQU0xVXJ2VmRpZ20wK3JUOWNZM1FiZFpiczk0dnVMLzV5?= =?utf-8?B?c3laS3QreDRsQk8vTGZ5S1JjaGo2QjNNSUNsVzJGTW4yVklQUEZkMys1TWNL?= =?utf-8?B?dzk4dmkyK3o3MTBHM0xWcjZrbFc0NVk5VVlZYzEyQzhLblg2dlY2eVM4dW9D?= =?utf-8?B?Yms1dkhaRWp1dzdiU1JPeXMwZy9pNjc2b0w1SXJCNmtKUmk3QzJZZjlDNmxv?= =?utf-8?B?aWJLOTFoM1ZuVHF0Z2lBNVNoa3ZoTkEzVVpIUkRIU2J5RmdMUzJRU2pEaTRj?= =?utf-8?B?MGhuYmsxY3ZETEF1WWpTOUF3dGRYUXF0b2xIRlhJOVcyOGJhM2N4K1l6dVJU?= =?utf-8?B?NEhiR3B2eUZNc3NYU1Z3U0I2cFpRdHcwcld4QUErK3RnbzlXQzZSQjNBeWli?= =?utf-8?B?S3V0cmNBTGlXUVl2TGt3ckphYjFReTNuNkRyaHZwZy9LWW83bkszWHpmQk14?= =?utf-8?B?MnJHaFBYM0h6dlFzNkFMMEVGVFpLK1YxQXdvRnVkK3pRbk5FcENkMWdsUW1o?= =?utf-8?B?TWZWaXNtZThSbE9Bb0FFNVFqM0djVS9pcmpQS2FNb2Y3U0tET3A2NDhjWlJi?= =?utf-8?B?VHJZd29DN1NMQTd0WTBhcnhtaVd1NGhmZ2tGME1NSU40am5hanRhZStQcnZs?= =?utf-8?B?NVhVSlpOS3FNNlhVUTF1eUhBY1N2YzArbFd4ODh4eTZtYzBCL2dVL0dzTlRZ?= =?utf-8?Q?lBa8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bkY2V1RZc1hpTjEwVTRWakNKSFhKSHVIcmVMaC9BYk9WemxYSEZleGl6WlFJ?= =?utf-8?B?U3prR080RFVldEVTdlB4ZTM3TWE2OFExd2trZmxwRmFjZjRKbVZ1UkxrVDhE?= =?utf-8?B?bHVvTUdrRzN1d0hlYTNHcFJFaytkZ1VzNWpzWkNtem8vSzBFZzVYeHNMOFlk?= =?utf-8?B?d1M3c3BnWFJzdnhCbjV3aTJMRkRNK3pXdVVDTXB1cUdwNnZacTQrS0lqamJw?= =?utf-8?B?M2Eyblo3ek9BL2NwK0JUWVJpbGxTV1RhQ05LMmVNUU1qQ3RiN0lTTVovZ3ox?= =?utf-8?B?dHNVdjdaUE1GTHo3WXBkTnNndFQ3YlBpbC9taGRqbGtYQ0F6VnRCMCsyUllW?= =?utf-8?B?M0w5K2lUKzZ5cDVMdUppajluUDZITVdUd3RWYWF6ay9tYklyZUQrdElFNnY0?= =?utf-8?B?aHhHSHlBbzVFUDVrYkhseGx3bWNhQmRTU09ZT3hIMGJmbDl3S0tDamxJR1F6?= =?utf-8?B?cVdJS21vSW5aTU5sRVJBTXo2R2hHdllIbVBWajlMVHVnYW9TbzlNSDZQWHdr?= =?utf-8?B?Z0gwaFptQURueDFOK0s1dENGMFlWeHBUZ1hEdmpKSytpUldBTHpNTWN4SjVW?= =?utf-8?B?TWYrZW5POTk2RStDRnBJRHJxKzFkWjgwSjV5VU9sQmxGcUlkaWt1SGZ2d1Bq?= =?utf-8?B?RThuQlJiMERYTllBeWJuQUQxZ2x6bk1LM0E2dDFtbFFRVTJwNzVlTFpDWGxw?= =?utf-8?B?MEpmTEFGWFZxcFg2enlvQzBGYU1KdlpMbFVuWUZ5SEpDZUVFbDU1QWJqM0pI?= =?utf-8?B?UTRZamdOdTJwS0tablMybFd6dFA1RDF2WGVRR0gzSzF3Q0VIeWpscTBYWlZW?= =?utf-8?B?RFFtV2lXc3lQSHd1eGg5VGRWVm5BSkN2dVBMUzM0WUEwUUFKWkpGdVR4Tmtp?= =?utf-8?B?c1hya1V1UXFnWUozYWJINzMxYnBSd0I4dVUyRWtlS25oajk0akkyS3Nid3lR?= =?utf-8?B?Nks0ZE9qeDRKNEN3bnBqSjRBa3RZVVBYZUtpV0h0Q0NWRDQ0N0tkNTAwYzJM?= =?utf-8?B?T2Y0NnQ0R2hidy9IN21Gd1ovNjduN1labDNJdjJ0NElRSyt0ZFJUd2grQkVs?= =?utf-8?B?blBVOTBMajZoTDRqQkM1anU3WGd2ZUdwc1F4RC9QN0c5SVFGZ1V0WTNicTV1?= =?utf-8?B?VldjTVk2TlNUYWdndVNYUTdneXJEY2paWS9JZTZzVG1lOWJxRWRwYnREQzBu?= =?utf-8?B?WXVzcWdhczhyMWJXK2VwM3l0TitSeW53UE9YZGhrcEUxNzdjNmpVcUYrMHVH?= =?utf-8?B?WlY0VDZIVHN1UUEvd2Z3YVRWY3hPdkVwQUUzeWU1Q291WDJhdzkzb3hsMUhX?= =?utf-8?B?WXBXN21Jb3A0eEFhUzF2Zk4rZE15VkRMT0IzWHQ4QUNYRUUybkxlWjhxaU94?= =?utf-8?B?YzZzYy8zcEQvZTRvU3F1ZXRKU1E1bWNGNldTMERhMmhIOEZweVdSQ1VyQWF1?= =?utf-8?B?YzRWM2p4MUhkRWIvYldKQUZwM3l2d0lzUXVpQ3M2Mi9SdFhoT0xhUmZpUGgz?= =?utf-8?B?N1grL2tzd3VOQWxKaG1MT3RMcEw5VVpxb3k5REE3U1FzaUFqeElCaGJIa2xs?= =?utf-8?B?RktmTlh2YnZCbnVWaC8yaUFFWlhDdW5aRnVFeVF2ckhPUGFXblRMcDJ0WGlv?= =?utf-8?B?UXlVMGNZK1kraExuQ3huYjZJeW1RaWxMamMwc2xVQVJUSnpmaklOV2lQL2dM?= =?utf-8?B?dFRWKzYvNFRGdjB2MkpibG9sa0Fla25EK3BNWlBGYWZtNmE4VWsvU1FhbU9n?= =?utf-8?B?SXhENW5JczUyRzExNjdaL1BzbFdHbWs0ZDdpd1VSMXE1K1ZVWUlIdk5EUFF2?= =?utf-8?B?TEl1aXZLUXVGWnNHU094bjEzWWpvR3B2MXZCNFFhc1AxZDdtYkZqNkpieC9y?= =?utf-8?B?OXVVODVUalMvYVZxUjJDbDBsR2wzd05GNkNKN2x1T3VSaDEvWVpEamlsbE1U?= =?utf-8?B?VkRuR2tUbGdTNGV2bnRjUUswYUJEQ1Bud2hFSXhtS21pWHZxK3pxZXRoNGhz?= =?utf-8?B?alUyQURqVTJIOURTZm5ZU2J1MDQ0UVNIZVdPdlFsTmc4SFdMU2l4SDVWNWNM?= =?utf-8?B?RVpzZE5OSk9XcE04bUlGeGQ5R1VXcjB3cllENUxZQnM0OVA1SUhWaTI5cXNt?= =?utf-8?B?NVEwL210b21pWTNqaktOYXV4S20zMkNjekJUYTRIMDZvQUV6a2JGdTJ1V1RX?= =?utf-8?B?ZkZ6cGN4NEUwOGtDZE9aejh2YU81V04vRVdnUzRFeEN3Rk81aUZXeEw3OFZD?= =?utf-8?B?a3VQZTlxTVNjeDZvc053YzJiV241UDBPREhBZHEwZkxBTmdGV2Ftbm1WRjA2?= =?utf-8?B?OGlKSHR0UFdNd3czYXdEb1NNbE1NekhxQlpuaTVaejNTb3NkRTFkM2NMbXBs?= =?utf-8?Q?6+YqMTxpCG1YOq7zOgK97Hiu1GflBUr4uWc/F4Vg7TzMi?= X-MS-Exchange-AntiSpam-MessageData-1: hP3Bo6kasGHJCA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0517560-a8fa-4a15-9b9f-08de6dceb727 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2026 02:46:13.8230 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WiT9cVcqG+kp06Q7DFqfzm+6MBXWPr4qda0qJ1vEUoOLnFTwOkVwWwE0myhP0YOqIIRYWtu1psJ213Y1pOWzfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9476 Being able to print these is useful when debugging the sequencer. Reviewed-by: Lyude Paul Reviewed-by: Gary Guo Signed-off-by: Alexandre Courbot Reviewed-by: Danilo Krummrich --- drivers/gpu/nova-core/gsp/fw.rs | 10 +++++----- drivers/gpu/nova-core/gsp/sequencer.rs | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index 624f5670ed50..f1797e1f0d9d 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -330,7 +330,7 @@ fn from(value: SeqBufOpcode) -> Self { =20 /// Wrapper for GSP sequencer register write payload. #[repr(transparent)] -#[derive(Copy, Clone)] +#[derive(Copy, Clone, Debug)] pub(crate) struct RegWritePayload(bindings::GSP_SEQ_BUF_PAYLOAD_REG_WRITE); =20 impl RegWritePayload { @@ -353,7 +353,7 @@ unsafe impl AsBytes for RegWritePayload {} =20 /// Wrapper for GSP sequencer register modify payload. #[repr(transparent)] -#[derive(Copy, Clone)] +#[derive(Copy, Clone, Debug)] pub(crate) struct RegModifyPayload(bindings::GSP_SEQ_BUF_PAYLOAD_REG_MODIF= Y); =20 impl RegModifyPayload { @@ -381,7 +381,7 @@ unsafe impl AsBytes for RegModifyPayload {} =20 /// Wrapper for GSP sequencer register poll payload. #[repr(transparent)] -#[derive(Copy, Clone)] +#[derive(Copy, Clone, Debug)] pub(crate) struct RegPollPayload(bindings::GSP_SEQ_BUF_PAYLOAD_REG_POLL); =20 impl RegPollPayload { @@ -414,7 +414,7 @@ unsafe impl AsBytes for RegPollPayload {} =20 /// Wrapper for GSP sequencer delay payload. #[repr(transparent)] -#[derive(Copy, Clone)] +#[derive(Copy, Clone, Debug)] pub(crate) struct DelayUsPayload(bindings::GSP_SEQ_BUF_PAYLOAD_DELAY_US); =20 impl DelayUsPayload { @@ -432,7 +432,7 @@ unsafe impl AsBytes for DelayUsPayload {} =20 /// Wrapper for GSP sequencer register store payload. #[repr(transparent)] -#[derive(Copy, Clone)] +#[derive(Copy, Clone, Debug)] pub(crate) struct RegStorePayload(bindings::GSP_SEQ_BUF_PAYLOAD_REG_STORE); =20 impl RegStorePayload { diff --git a/drivers/gpu/nova-core/gsp/sequencer.rs b/drivers/gpu/nova-core= /gsp/sequencer.rs index 9278ffd5216d..0cfbedc47fcf 100644 --- a/drivers/gpu/nova-core/gsp/sequencer.rs +++ b/drivers/gpu/nova-core/gsp/sequencer.rs @@ -67,6 +67,7 @@ fn read( /// GSP Sequencer Command types with payload data. /// Commands have an opcode and an opcode-dependent struct. #[allow(clippy::enum_variant_names)] +#[derive(Debug)] pub(crate) enum GspSeqCmd { RegWrite(fw::RegWritePayload), RegModify(fw::RegModifyPayload), --=20 2.53.0 From nobody Fri Apr 3 02:56:38 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011001.outbound.protection.outlook.com [40.107.208.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 884192673A5; Tue, 17 Feb 2026 02:46:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296382; cv=fail; b=eVh7Boc5nb32wb5WIbjvHtIn4risCrh+yY+jY9JcvDo5t+SHtDHAzpwUwvc5H2njo5MbRH0kl182JrqJXVv54HLidw2Wr/VFbnYUE2g2/e99WVadJwC/tbEO1+fFtWtlxdcGIWWtna/jsZi102yESNFa656/QyD1k6QXCXXCU5I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296382; c=relaxed/simple; bh=F/F9jxlnVS8HyNEQ6bHwhiAj1xh+lnEu2hM6IVfbfzw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=MiN8xxj+Q3JX5p6juDSNWFcWuHCvbh39mS0qzYw3kpAuBhMT0zDdyqJ13rblD8YdrmI/q3+wT7qHMAuZuc6aQ308LS9pagaWNn6MD4FKqpBKKgkobh5cZCXPfZ26CGciFsPAV/1Nmhw8bfH188zL9lkx6VeYwMLJU34doaL21B4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=XA3KjVLm; arc=fail smtp.client-ip=40.107.208.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="XA3KjVLm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OYdEmr8yU9kQLrOJu/4Gyee4+VyHsGol4/0VYJSB/v+KNNx3v8VZj4dclxclvuMxHgb3QaYSDpeEOUB0FPywqXbueO0jMCShqbewk6Ng/vUIaey4WqWWF9FVIJ+/C20QL3T910EHiRyTgpK/XeNB0GyONfOKildNaMopc7xB5MnmRMV5M99a7m6lv+YuN4LIHo7DDjJ8wgB+9kiEuBO0Riu2nmUFeln6sA7dFwl9GaIvrxpwIHuY9qPEAI5M6El0pXF36B35FGP7nfwa6fE1t9DZ+NM1ifTDKbdajxsqwVtZy6q2n45EEAfUZ6m+a0UGuKW+K5tqvGJKkqBmJh/12Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p9Q+1yTvAo3Hkvvr8xxZUqUauSSU1hDfiYeUTNYlPFs=; b=iwBXYQDMRkFcVCb386D5RNb6b/CTNYmgN1J5a2aJeot5sKCQyVo5BcLCKInXA8ywQOc5PJAfuOjyDL24Hk1vEmfUq9W7u3M3swN0GaiZ2QwF/+2xbc6eAJGzJl+RQk6/ef6KHpsG+qWN0HwWLoLTSKCGKBxUaJR33/OvE1HFHuau/LJtsnCVGjWhHuGgNkX+1ytafUwPYNGetyWUst0tD0uslrun0pVOslBLY9aB0lx5fUcVw0Xk5WtYW0lC8oRyn11HbJFbnZa0hmGpbB1woP+mYvalQQhaSaVFUKChdKmif1JIfKpx3ZRu9AHpScmgPHnG6bRwC72GPsYbN8Sw8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p9Q+1yTvAo3Hkvvr8xxZUqUauSSU1hDfiYeUTNYlPFs=; b=XA3KjVLm6RgKHJBqrB+BMvS/o30jFk50Q2ZrwwGx8cDMFORB1qAPjcoOtfVwut0cMn3s0wbD63E3vWuie8oOU2tB1hsvdulgmCJREEQDMbgSVEvCJyops3B1Fl60Osy8q1kbmH3ZQII8hc/n0cHFLCd0GXgqBNo7aGKT+mPfZaxAXEacSn47QNVVJUkxODFtUfazm86RoTVKLQ2kMCc6ZJQsVKQq3KNB5957v28DKVg0dtXmLOK5N3l2Y2CCerHepUBm+ooX4MY/+NchfSTSdVfAKEQfFqokwckgzAHgSKsL2lfcY/i5XBDMc805s4j9e8mggyN4I+ewXx/e1grbCQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS7PR12MB9476.namprd12.prod.outlook.com (2603:10b6:8:250::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.16; Tue, 17 Feb 2026 02:46:17 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%3]) with mapi id 15.20.9611.013; Tue, 17 Feb 2026 02:46:17 +0000 From: Alexandre Courbot Date: Tue, 17 Feb 2026 11:45:54 +0900 Subject: [PATCH v3 6/8] gpu: nova-core: gsp: derive Zeroable for GspStaticConfigInfo Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260217-nova-misc-v3-6-b4e2d45eafbc@nvidia.com> References: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> In-Reply-To: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0070.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:31a::14) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS7PR12MB9476:EE_ X-MS-Office365-Filtering-Correlation-Id: 013f91ba-384c-403f-a21c-08de6dceb95d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aEtPRW81OEo4UGV2VkZnU2o3Tk5DOEliN091aE84U2YrUDNnOGZ2anVvT0xz?= =?utf-8?B?ZnpmZHVkcTMrZDRDT3p1aDNkZm9LWFVHWnJmV3EvSXVsbG9VY3NrL2k4bk5q?= =?utf-8?B?YnhJbHZ2Tm82blhDbElNb1VLL3lsb043bXlDK2srendPTkFxTGZkbW1CcVEz?= =?utf-8?B?aXQ2MlRCNDNUZ2J2dGNrTWQvWUJOVktYOTlXTitqQTNjTlJGb1kvMHVxbmI1?= =?utf-8?B?WHZkbnJaUkU3R2ljNHA5dHNibk15cXlkRXVtZ2FsTEM0NkxGdERRbWx6UU9a?= =?utf-8?B?cHN4K1hwRTFnM3gyWndQWE5ON1BvL0k3anNIR1FueHdBOFJBR3grVi9vdkVE?= =?utf-8?B?djY5OUVBcFFabTdKZjBmK1dyay93VHBVdThrMi92QXl0R1ZMQzBRcmxxcndM?= =?utf-8?B?YkQ2dVJnVllXQ3VHKyt5VFU2K1NWQXdUMTRzS29zZTZ2N2hzVTF0VHB4LzNn?= =?utf-8?B?bE5FTXkrT2M5V1Q5Q2Q0RERza3hrS2dFa21UN2lvbWJPcEJ0Vlp0cHdNTVRJ?= =?utf-8?B?VHNkREpZWG4zcEJBMnBpeHowdU9FZ0hZN3NLZjVrUGVLaWdudmlsWGFINXQw?= =?utf-8?B?YnVETDJuMXVCSndFZFZSdDM3a3FFWFNzQ1FzZ2VJbHkxdHlrbFJONWxodU9t?= =?utf-8?B?RlRkT09kS0pDQXMrTy9qTFIwcFVDOGtuSWZpR1BrSjlhdnpJbUpqam0vam1h?= =?utf-8?B?UGhWS1pGRWVGOTkxcFdtbVg3VDJzU3FEeWdqaWgwZDRsN0F5dHlmVnE2bnI3?= =?utf-8?B?aktSNHdSSk84ZXdyY2Vkd0NhNlNJVEVsdzFWS2J2c0V0Z2lwRUkzQk12M21D?= =?utf-8?B?SkNLREMwUldidWY3TmpBc1BhSEgyT1NSYU5FWU1lb29CV1Z1MGlHU0VMdXgx?= =?utf-8?B?Ylp5ZVlnL0xqMHQvQ3RlR2x5ZGNXMVU5V3NVTzlFQm8ycTM5Z3FTU2I4OTc3?= =?utf-8?B?N0RGL1QrSWUxMkYrK1dqWm1lczRLWElDVjEwYUNEZ1NhMENmSUEweWxVZ0hF?= =?utf-8?B?YmcvbDJhMkpvM3F6M2xIWHJMWlBEWHJsRmdMWGpTZmIrWC8wdk94S1VRMlNj?= =?utf-8?B?YXNsVDE4ZGxHTi9UZkt0RDhMVUR3WnZLUkhNVzJJZ2NpdmZiQmxhc2pyTVZ5?= =?utf-8?B?OG5BMHE0SU9LNDBBbkdwREJtaTg2SlA0elNjOEVua2o2cHZVMXpxL2IrU3Rx?= =?utf-8?B?cGUybk9xZE9rb09qODRmQjREOXZSdTI3ZjRVa0xvZlhZWWVnWGhQZUNpYUth?= =?utf-8?B?R1d0WGRZQ1BlL29WMlhsaHg2YlhiRGs3RElzYzJ6alhXWEc3TEFMWDRHSWtm?= =?utf-8?B?NjFqbGR2V0I4VmxCS0FDc09naTgrNUJ4V242VlhWNkUvRGNDdnFNTG1lcitN?= =?utf-8?B?cnJncUoyaVdJd1ZvWGwyZFpoZFNjQlpjY1BLSExhVnJ1VU8wNitlakMwNURt?= =?utf-8?B?WmVaeHFhWWNUWnB1NHYzMFByZ1JMS01WcWU5dnNQUU1rNXlVZEp6d05oWlY3?= =?utf-8?B?T3d2MEpUS1RCNEo1RXJLQXZFTVRiVlRtVHdQdGFzRlVrZmNza2lndjNGNkdr?= =?utf-8?B?b3ZMazN4MElmUnNFRUNtN0FPNlpnbFdjeW5kdFhlU3dEMGY4TTZtU0NXaEUy?= =?utf-8?B?N296RXZtclVZRkRuSVpkbHlGTkNMdkhsUFdWd0xLQWJtUi80QWIySmxabmph?= =?utf-8?B?cFE3bzB0SUlIWWdHUTNOVjFrUUgxenU5blJVYnUxT1g2RnZLR2VHMFNkeGVZ?= =?utf-8?B?VmxubDZhVStHN2JNVzZWdUFqZGV6dmtoOXA2VFZjYk1pamQ4eDBDZkJGMzBV?= =?utf-8?B?ZmtuaEkxMmcvZ0FnUWJSL1V1ZFUwclFxTzhaRXhacXZXUEQrVlVWR3JtMWpG?= =?utf-8?B?Y2w2ajI5T3JxKzhXZVdKaXZEdmJHOE4vbll5UkJFRk5iUk1temhIWnpld20w?= =?utf-8?B?NHBkdHFuNm1maUNrcEM1RDAralQ2czROK3ZCZWhKOEN3OTFnZitGZjlob2VI?= =?utf-8?B?RWQ2d0E4WFBJRFdtYkI4R0JHUmt6ZFUxa2ZjTU5BMHdYUlJQZHdNMnZiN1Ja?= =?utf-8?B?VXBXSENUYkNXOUFPSXRnQStGS1gxekJraEY5VHE4QkhTWllteC9CcUo4WlBz?= =?utf-8?Q?LBO4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1NPdkVBQ2tKajVWZlJ0NG9MQzcvZ3dSNnNNeVFuM2RURHRCS0VuaVdkVVFn?= =?utf-8?B?Z0tIdE9FUXpZMkhENUxPNmhnLzhWYWlNSkxWc2tkZ3N4N2txclBrTkdRVHZm?= =?utf-8?B?Q0x5NTVncUlvWDVaRS9rWDRMR1JEODA3UmoxMW51ZnppOHd4Q2huNDFPMWQw?= =?utf-8?B?MHlwMHpXbExFSm1iTFQxbjU1a2xlVVd3ak9sZ25rTUFScHZBOGxKcmJzZUdN?= =?utf-8?B?ajBaVUxaR3d3cEtRYU1jeXNTSGJTM1ZNdngwSmlQcW5aNko3QzNKNkNibEZr?= =?utf-8?B?Um5EL3l6R2dxQWRoTWxUSnVlUDU5ZU8vZWI4RW15OGlUYVp1Y3VtQUZQanBX?= =?utf-8?B?VUxQZWRUcVB0UzlNc0UrVHdiRjEvSWtxdUlkL3BOcEdkQTlYa2xNWDJhd28w?= =?utf-8?B?ZmVkOUdnTHd1OE15ZHRzZ0hJV3hrVGlpeE9vMU5UME9pczhzYnlpY1RIdk85?= =?utf-8?B?M09oL1AyaTFTa09xR0hMMnZJcFV0c3hzNENuc0dzQU1TY1RmQXNxMGhNYTI2?= =?utf-8?B?QXVrc2xuMHhLZHJ4S1g1M3FHcldmVDloNjZyL3lJVjJKR0IwZ2IxbVlkMjds?= =?utf-8?B?a09BKzFsTVU1dzJBZG5ZNG91T2NydTJHVzMyK0RsdjF2amhhSlJRVldxc215?= =?utf-8?B?MER4SXh6R2Rzb1U3TTJYRHFYaU0rYzUwRjM5NmFKQWlQdVJ1NUhEaHorMVhI?= =?utf-8?B?Sk5jemMwbS9TV0t2aGNuZEhRSW1sMDBua25Od0JGOGhXZHNPajBNek4rcFli?= =?utf-8?B?N0ltc0Z2elByWkk4ZzkxNUtYSHRGbkZZV25NMWlLczczWnhZQUN3WFhGa1JH?= =?utf-8?B?TGk4WFJLSUdiclFtM0QydWRXaW91allPb0s5TEJ0c3VHWCsrSVJjeE5VYjFm?= =?utf-8?B?NlNzSWg4QXE0akg0MVM1N0VQTU80Y1liTXBwZDA1NzYvT0hSVVVnVEU4R3FU?= =?utf-8?B?UnMrM1A1aVUvajNMTjR1MmFUbkVWazFEbWZZZlZ5U2ROeC9CdmUzc1BVZTFu?= =?utf-8?B?V3pkZmxPUGN5RWlGSjFzclk2dDlWSVBrWW95SmdEcE11bUlvK3VxbEtaMElw?= =?utf-8?B?dlNWVGFmOXUzVjNpblR2bFBOWkhTSmI0UVcyR1k3VkR6SnFKUzk0WXJ2UnZ3?= =?utf-8?B?WDFoM2doMWtlZ1UyZHpCRjA2ZURYODIxSnhjMUVJM1ptMlB6dUlFNXRqa1I2?= =?utf-8?B?Rzk0M1VsUkY5TnZ0T0JvaUZ5ZlJIZlVFcFltbTJ3TzZQNklsK0R1K1lQcHYv?= =?utf-8?B?dzlCR0F5NC9PcDZaVzkybkhoQ3Bya1ViM2ZQYTZaMElwMk1pc3dNTWpDaHVl?= =?utf-8?B?UlphajdPUjRhWmNQWTJ5K2lidFpNVzduWC91MkZodUFqRG8zZWlReTdFVnlM?= =?utf-8?B?ZkxyYkRTRXJZa2NZNE9JR1gzQ2swQURLd1J6Q1JEOThQbjBndExvREsrMHhX?= =?utf-8?B?dFByY1E0Z2dVRmJZYi9FRzFvWTRjaHZxVmFOaHdZMXhZZ29FcXZZdVpHR3hE?= =?utf-8?B?MERwajlBMlUxRzlvL3FKWWdQTmdLQ0VuanAzVDh6WXBuSWtQYTdwdDlURlE4?= =?utf-8?B?QVZIWUIzOURFaVcxemZLbWtjcjNZWURaUTRtVFB6eEJxN05Fb2RVcVpCZkVQ?= =?utf-8?B?Q09vbFFaTXg4VU51YzFUT0RZMzNkWWlUaHJFK3hWbzVmVGJaamQyQ25ORTdi?= =?utf-8?B?enlwaXpqbm5pclh5Qk9ndjZxTHlBSFhuNndCczMwUTNhVVpGcGk5aWRrcjRU?= =?utf-8?B?WHpnVTFXekRnYno5SGN6WS8rYnpXZmxYcjBxdW1QQUJDQ2lqaGY0NXFHdmtI?= =?utf-8?B?ZGRNSHRPejlCTmoyWGdodDNpWEdxc2NBOEwwUGtUekVoQVB0bDhQWHdDOGt4?= =?utf-8?B?cDdlbVZMKzRWTzQ1OTdpY1ViMUZsbXNOM1FxdllDNndUWS9ocXdCbmUyVith?= =?utf-8?B?TS9LYjFKc1JUSGJqRlVsbmUwRVhlaW4zSFZZdit0eXVsU2RleHd0dTdVUkYx?= =?utf-8?B?ZlQ4d21UUVlHamVhY3l4Yk53amFWa2l1MmY2MXpyQUJCNC92anFCY2ZMWkxU?= =?utf-8?B?b2s5cnFqaTV3TXhndGRMR1R2ODhEbkRBaklXVzVlWkJrUUg3bUFINUFveTFx?= =?utf-8?B?L2J0cjk0dTBsZDdNV3Q1Tkg1QlNjS2xkU0lzU2pBUExiWUprelFwcDd3OFVC?= =?utf-8?B?SkhCbE8rU3o1L0xJenBrbHpDUStUZS9ORHVyYVJiUnpuQXZTSUExaDFhMXk0?= =?utf-8?B?Q2pSVXd3N0hSQWJHV2t4bmQ5ZE16OUp5QnNGdk5YR2Q2WDRHeXBEYTk5WDBn?= =?utf-8?B?SVI4MzAyeExTeXE5VzhaUnkrVmNLN1UwZitMeld6cDR6RVFaQW9kL0tYRmtq?= =?utf-8?Q?alfFqlNUm19WWlAttzXs4rQBNT8qYEr345mK4m25OqoQ9?= X-MS-Exchange-AntiSpam-MessageData-1: GCkthlPoBH+Ykg== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 013f91ba-384c-403f-a21c-08de6dceb95d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2026 02:46:17.6333 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l0xoKDixntlgSHpuhpCyG8G3o/2hZCQFdHLEWTLPGdJJCEKr/M/BmD9zDedS+SXyL7+gXsbxZ80ECCH8xzkLtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9476 We can now derive `Zeroable` on tuple structs, so do this instead of providing our own implementation. Reviewed-by: Lyude Paul Signed-off-by: Alexandre Courbot Reviewed-by: Danilo Krummrich --- drivers/gpu/nova-core/gsp/fw/commands.rs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/fw/commands.rs b/drivers/gpu/nova-co= re/gsp/fw/commands.rs index 21be44199693..67f44421fcc3 100644 --- a/drivers/gpu/nova-core/gsp/fw/commands.rs +++ b/drivers/gpu/nova-core/gsp/fw/commands.rs @@ -107,6 +107,7 @@ unsafe impl FromBytes for PackedRegistryTable {} =20 /// Payload of the `GetGspStaticInfo` command and message. #[repr(transparent)] +#[derive(Zeroable)] pub(crate) struct GspStaticConfigInfo(bindings::GspStaticConfigInfo_t); =20 impl GspStaticConfigInfo { @@ -122,7 +123,3 @@ unsafe impl AsBytes for GspStaticConfigInfo {} // SAFETY: This struct only contains integer types for which all bit patte= rns // are valid. unsafe impl FromBytes for GspStaticConfigInfo {} - -// SAFETY: This struct only contains integer types and fixed-size arrays f= or which -// all bit patterns are valid. -unsafe impl Zeroable for GspStaticConfigInfo {} --=20 2.53.0 From nobody Fri Apr 3 02:56:38 2026 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011065.outbound.protection.outlook.com [52.101.52.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA7ED2010EE; Tue, 17 Feb 2026 02:46:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296389; cv=fail; b=Zg40HETZXu1q/fbxxHjCo1yqF2NvrPIT5bGmgj48NeSYr3/vMik/NlIcfDrFFhnShKZtilt8oYEf5c8xNGrcdBmOL7uF17swg4SoinRtE5vYkmnbuxott7Ag01uWF6HNrZEADhykXOYasovRNLDMN71OS4h/MAMnINDa2chjU2U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296389; c=relaxed/simple; bh=ADJUPwN6pfeB9JynJCq9KAhbA65oCfGwH3/Xoj6+orQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=svvCBwuGN/syDRk45irW5WOHpA6pJdPsaWqViP9yvIZB7NTkR14i4PnuOAPUSVxVO86AE9lgsvKsxo2pJAVfuphzwjgJDb/u2R4bASjuyRFntrkTfqYZZhvFZ80faJaWTK6slUKq1FB6fnYTX0fVAvVV2f+v+jGM+W0pYTGPbUc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=FZ3rlKrR; arc=fail smtp.client-ip=52.101.52.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="FZ3rlKrR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Iobk9paxE6OcMvLFwXfpK6U9nYfdP+QZexek1iG0Vrut3HrdFlPWKXRfkR3g+xSZw8qOlZqKMUw/hHh+JSgcFzaHTMS9W85Nw3PW6ZHJNtjZbivnJHCp84ReBDgtdi83WHDNP8+A8Vf0N9fnABJ4S5lI+hd7/XjcMaBysz2DnjcNuVFifH2ADi4pQgaO8FGFHwj90QsspyQflUV9KiMc72QmDeXo6KJO0R1aFNBd6yBkIEm3l319TQ698kH89m8e018+jwlI0OA7DVYyENVesABolkfK2xWmUWBmgdSqOfcVqipRoLcw05HaTilrQfyvYUK+/PIIgpH6o9E6/j2SSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AT4ua54c4eHlA6EnhNiXD5hqnbyPq30/M/XxAjXtnM0=; b=TjQzsDW8pMairkSdSqW2OmkV91U88+mVLAThtIxO/9qoskhIY/jSbMjZ9upa6+RbRtNkA8xY7FuO502COmiuYwZFzGAnV7PODuhpCoKvXCEp6mHEK1eFU2tZrYU5AMR7jDYwLspm0Aj65W2nOJ/BeV7c9tsCkHVJpTN3i2mQ9n45h7tjfr0gG0INi2ZSbruxrrT4ArxpIn6pnQWJ7gfl7bIPbuBdlADZaLj9lGAx6UkUoVpuYvl6u3ly9YLH5YT1MKQIXvSJ3psXindKoTOlfgw2Y9KSKIYeWoYiCRi0deFBr5Kv8MKZG13smDSuKL7MULwKWBJ/jjJB/qwgfPqytw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AT4ua54c4eHlA6EnhNiXD5hqnbyPq30/M/XxAjXtnM0=; b=FZ3rlKrR8JFqwESCEmLuRbihjOqMTqudYf5FKok4O0SK76iD2YzJXcI+ClgPBvVYovhMExfDqVZXKR1l5ouukZAfCiANlrToNyuYgT/+mkaXd34OClu51gbJdfysRhAdrS2aig2VtCvd7jpl2iAkkFa3CJ3mhSdibuXp+15FW/IMy+kgVrKwjnTemCgOreh2P7uXZ6dLX0qnPCN740omKrRZClGkOmOhhiGLF6OvIQdf9PFpbwr4qjQC5sCDwh6augQnxxm/M/VZs4hai+JcYEznhA9alKuzosQ+8V2CJcC4T0yxGeYOLqq/VNvYUjMvaQLd6PQVAnS/B6bicktVig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS7PR12MB9476.namprd12.prod.outlook.com (2603:10b6:8:250::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.16; Tue, 17 Feb 2026 02:46:21 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%3]) with mapi id 15.20.9611.013; Tue, 17 Feb 2026 02:46:21 +0000 From: Alexandre Courbot Date: Tue, 17 Feb 2026 11:45:55 +0900 Subject: [PATCH v3 7/8] gpu: nova-core: use core library's CStr instead of kernel one Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260217-nova-misc-v3-7-b4e2d45eafbc@nvidia.com> References: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> In-Reply-To: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul , Gary Guo X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4PR01CA0084.jpnprd01.prod.outlook.com (2603:1096:405:36c::11) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS7PR12MB9476:EE_ X-MS-Office365-Filtering-Correlation-Id: 55fa1a32-54c0-4cf0-fcd7-08de6dcebbb4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eGI5cDlxY3RubVhzcGVGdGFrOGlKOUVBYTIyTzhDckdCeVdXeThLbXZpM2ts?= =?utf-8?B?Y0FOaDhQTmQ2dEpqRmhWbGZialhLRTROQmlzRThtck9IL1lQK044enZjckhI?= =?utf-8?B?M1JZcG8yUWEvRkxJYWVrUzViZ1k2NVhFTURHMGp3ZytMY3VPVWZDUGlIY3dk?= =?utf-8?B?N0RQdXdvOTE4MUYzWGZpTHpnNVNja280YkxPOHVoTStLN0dBeFIvbGs2c3pO?= =?utf-8?B?SmxmaVRxQitYUFVLdjh4RmkyTExiNkR6Wkg5SkxtL1d4SlR6QVlUT2E4QXRP?= =?utf-8?B?eHQ0QisvUXMzQjlnVlVCdXRsU2NQUklsTXBiRURqMVFhODg2eS94a0RBM055?= =?utf-8?B?L3MrSU1QNnZQdjR2bjc5Q2c3ZmRyci9uTkRjZ0RrbzM5S3JIY1VEZ1MvZGM4?= =?utf-8?B?dVdyV1FqVmFMMFhrUSt1Tnhhb25MdGNsZWNyQTRibWs3a0Jtajl6eGlGazU2?= =?utf-8?B?U3hxWnZIUlU1OFRiRDJCamlkcjBPRU1ORlk4a2puVUgrUGVtaTRoMGRrOWZR?= =?utf-8?B?NnQ3eHg0QzlwQjlQek1IQXQ0Q29GdnkyUWRJcDBQOGdMR2czS3dTSC9GZUEz?= =?utf-8?B?U3VzZzVyaVhLdTF0YnEwVkcwZDFHZ3lUb25qbkFITkMvMC8wc1JMdDNtSGVW?= =?utf-8?B?Nk9ON1dKRWlyVUlhZkdHeGxhMFczR1RmSHRVTGZJU2U0WUxYbUNpMm52b3Bm?= =?utf-8?B?NTk5TE1IQnRjRzdiek5xYkJKSUN2Y2lyZ2lCWmJkMHBBUzRqRWxqcXordlZv?= =?utf-8?B?RUdqV0ZONjEyMUxmMDE3YnN3MFdMR2J4eDlYNmZBMGdjanZ1eXNnOTFRZXgx?= =?utf-8?B?OU9oRW9JTTFUVzlnTmkwNktPVG9VdUg0M1R4Skl1SjNVZkJFL25tcDJSRGwx?= =?utf-8?B?RVZ3Q05TSUtCVFIrbzd0eElLTU1BRTdMc3lYbDZWUTI2VmRlaEExYnh6bDQw?= =?utf-8?B?MEMra09ra1dvU0hzbkVSb0xxZ2NPdVhmbk9sRXIrV3l5Q1ZNb1RCaTBwaVNX?= =?utf-8?B?eGlGOGEwRmc1Tk5JTmFZdVBaN3FWOWxEZXdISFFNS1A4dnUwNXJZWjVNOWtV?= =?utf-8?B?YWMxdVBITGYxaGYyZ3hiSFpxcFZITDRJMkVqcUpFSHdxWEZRZlJ4cjNObVFB?= =?utf-8?B?bnBIOUk2aEI5T1ptU0xGVUdzQ0lsRG14eWN2RkdNdm11UEhIcDhHT1dJV3Vh?= =?utf-8?B?SHdRODl5K2dXalBSR2hrT1lHdzhac0VKVEFkZlVyQlhGdmpkTEkrOHNUQTFj?= =?utf-8?B?bnE2RGVoMG5ORWpDdkZrMFNkZkgwVXd1Nzk4WnJ4cnlVdk5ucmRVOTBVY01C?= =?utf-8?B?a3lrY0gvdnMrVGFaMmdqb0hSN0VycEpPQlRyaC9ueE9UZmU0YzdaakYwaGtG?= =?utf-8?B?VHFJTjBQRXV2WVliYWZuSDgrSHdjRlgrUkhiZ3BScFovZkg5a1pUUG1TT1RM?= =?utf-8?B?d1pCWDZXaDl5bUozSlUxYnVBdzZSU3ZIek0zOHFRWnFXMHFsVS9FN3lybEww?= =?utf-8?B?WHhyUERPbDBJdFk0UC9qMzdRNDZBY09vbUZSSmtKVXBDSjJCd2FtSDBkb1lz?= =?utf-8?B?TDJYOE8xZ0MyMlNXQXQyZCs0eE9LUytlQXpuaThjOXpibHFLbFliNUJqU1NG?= =?utf-8?B?d3l4QlE0MjNIeGlnSnhXRGdBNDVTQW9mWE02YTByZ3puSUdnZGt0SzhwcFFw?= =?utf-8?B?ejhZOXhROGFnQjloQWhNem1FcFNHL1p0bGVzcjdiUDRvY3dKamc1Y2x4RHhI?= =?utf-8?B?bDZFNjJDdFI3cjM5c0NreER6VndnMUtvU2wvS2lid0R4OUtXbndvZ1BOT2Fn?= =?utf-8?B?VUtiZldmdWl1WnFra1BqMzduVTZvTzNLd1dSSnNPVHZES2xxekZaeFFyb3Zn?= =?utf-8?B?eHlremxPOGJGZWtlL200c3pzbFVMUW1UQnB3bkEzOU92RURiVWVvUzg4S1Qx?= =?utf-8?B?S01vUGVyWFpKWjFFRFFmaURDZFc0eERuaEZkRDBiNUV3TFk2cVMvSFhKWG03?= =?utf-8?B?anBrbkp0OHNreTVNL2V6TllEMkRRYUZwYUVJRG40eFE5MGtaaXM3YUcxVDdT?= =?utf-8?B?ektIbzZpOWtVR3hnZ25GR0t0N2Jxd3IrMm5SOHU4L0tIRERzS1NDa2dZRXpq?= =?utf-8?Q?oERg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVlwTjNubmg0cnBobVBwR2EyK09aSHFVT3VyZWtTUVZWc2lxYlVmOWx5em94?= =?utf-8?B?dFJZTTN0QURqdUhucDI2MW94M0xpV3UraC9DbEpRR3JkQWZpeHFqMXN0Vmlx?= =?utf-8?B?ZFowQm4zdXJrd0RsZFRqZ200dWZ1WEYrRzhrVjYwREl3ekpVUnZIK0lkeDBV?= =?utf-8?B?RHhSNGg4bW43b2dTUnlPK0FPUTU2VGFMQ0UrUHp3Yy9icjdsTjI5RmdjY1Zk?= =?utf-8?B?MDRBRk8zaEVSRDJ1bzdjK3VxUGZ1Q1NTSFRzRmZOcURoRzgyOWF6SmZRcFlz?= =?utf-8?B?L1BMTGhmdkdpNFhKdnJ5eU1YaDZNZUFWMjVENEF4Q3FKQnZNUHJzZWROVDJL?= =?utf-8?B?TTJMOVdsTDhRSFVpSXFva0tVenFaSldVa0xmdTc4c3JtUlZpaXBBTFFnN0gx?= =?utf-8?B?WmNSRGxBTi80bWxIUVkxNGwxalNWby9seW9sZThHSFpkd0R5eWlTekdNYzl6?= =?utf-8?B?UmlHQkY2RnU3RWVJYTRSZmJmMEpFR3IzN2JVWmFNbXpTUWJwU0oyU3c0NHdR?= =?utf-8?B?aWdDcDlBVE5nL3l1MjhDb3p3RHNjSHFNM1lCeTlCN1F3L29WQ3hUWVA1Rldr?= =?utf-8?B?MWRkQW1BWGc5czU2L1ZaU3A5T2YyTnBibXNBeFJRTTA5dHA5bmtqN1c4VVF2?= =?utf-8?B?WE4zaHEwbGRObzdEbWUyVytVZCsvcVhBK2JKay9KMmRXZWVicTV3dlpvS3NO?= =?utf-8?B?QVhmdUtBdlRPWW5FUE00LzEyRGZPQytnTklMTUY4S3pVK0ZndXZDQTFBQnRE?= =?utf-8?B?MGtHZGFES01hdXl2aGxrbk43WW13cVJaUEtxOUg5c3JubVkrRFlORGF5dXhO?= =?utf-8?B?YUM5TFIvMGpUbGFRVHJKNllHUHBXODYyV1JzWjlOTFRYc2JZM2VZb2ZPNkZs?= =?utf-8?B?MzE2WnJlSU4wV25HdDJ1WG5tbjFJa01uU1RwMDVzNmh5d0NndnpJSTM5VGFw?= =?utf-8?B?MUhIQllVUmFwdEg1VlV3OU9RV2xEMHFOMGt4MXAzVERCdEpFbG9JWFM5RWZp?= =?utf-8?B?T2licW1yVXU0bEJlODkrb0xyRDMzM0RhV2s1WjZ2cDhWanlYVHBGTXRqMkFE?= =?utf-8?B?U1VJb0dTcWUxNnFoUXkrdUxPT2lhdjNzMkZTMGJMZTZGajY3NFh3RzJoVHpT?= =?utf-8?B?YlVudkVBaVNnbFE0WHRReVFOSmZnTk5nUnh5a1REQkdPZ1BjQXZLb251ZUNK?= =?utf-8?B?anZ2MEFwNDhyeFphWEUweEY3OUZSVmY1WG1CdGpuTWRHL3N5aytYTlB2UG1S?= =?utf-8?B?aCtXUEVpNVJaK3VnblBOcStDMW5qTDJEelBidkNuMEtoY0p1QVV0RWRLS3hT?= =?utf-8?B?OStzMlJ2WXJKSk9NODR2S21xNnFFeDdVcXBvejdIcUFNaGxwdW9OTzMvb0xT?= =?utf-8?B?MkRQa1FzbTEyOVFxbnN6L2FIZFZJdGdjZjJ1RWtGWnlpQ2NnQXcrelJ3dXJK?= =?utf-8?B?NHRaNVJCaWEwUGF3WXJSc05VckZVZFZLVk55TmtSWlZRUVV2OVMyVzBLenZU?= =?utf-8?B?VXZ0eEs1UGxKeWtvdy9YVFgyM21ZTUhVY0RtRUxKVVY2ZURvczJ1RFdqZXBR?= =?utf-8?B?anN4TCtyc0g2dUlGdVorOVp4cGZPVGVoTG0rTzY1VjJBbWljK3ZwUDJld0xr?= =?utf-8?B?ZkNGUDViQmRBdDYwT1lXNlU2d3JYR2lJajZNR2RNOE8rL0RPcyt4TElLU1Z4?= =?utf-8?B?QzhsVm5JVXRiK0N1SUVJd2NQYjdieCtTalRFZm50V3JIMUVrTWhyMUFmaUha?= =?utf-8?B?OFpMUTRqdUtyRS83em5ZREdaTDlWZ0FCeVJrcUU2dytIR1kvamc5bVVqS3da?= =?utf-8?B?aExYQkR5dnNzSmZVZXJNS2lkdG5OZjg2VUpBOGNlc2pQWWNFcVJYZkpvNnJE?= =?utf-8?B?dmdOd1kxbjlhbXFXZkJVQUw5QXF3eTJsK2xOSnQwTFRuWE5UWGZFa284Q0lz?= =?utf-8?B?NklwTXpEdVp0RExZdFl5QlgwcENOSXVvOTREdS9vTkVuUFVkVjl2NTJVdm9I?= =?utf-8?B?NlpyMVY1RGVBUm0yekZLNVMxbzZpVU5Ua1lNZHlBM3M0bi9qejFqZkhmOHVJ?= =?utf-8?B?QThNelJUSXFxUDNyYVNNMzhQSGh0dlVoUGRuQ1VQa05LdEFoaWg1ZG9WWVBH?= =?utf-8?B?SGVsRk10TlFGWG9ML0dZUzF1YmpNeHp0b29JT2ZhSDlsVmNvWE56ekIxMzht?= =?utf-8?B?NkhnZ2lzTWtzU0c1MnVsWkN6b0dUR2JrVHZrOW1Jd1JZRVFXSC9MZnBZWGtw?= =?utf-8?B?cnFWWFBVT2pFTE96WVJiUVlkaW9HaGtIODd5VTlLeC9NaE1pd0drZ08rTzZj?= =?utf-8?B?OStWcVlsVjlWc01Dcm51RXV0bi9ObmdoZldCNlBXbnIrc2lBL0hrYUR1TU85?= =?utf-8?Q?3L9yZzKUD9n5O3hEpcbvu4Kws4hMgCl3q+CDPRlV3lEFE?= X-MS-Exchange-AntiSpam-MessageData-1: 1G9fDSZPk/uStA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55fa1a32-54c0-4cf0-fcd7-08de6dcebbb4 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2026 02:46:21.4456 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gqYEoehZvwmC23j0hyakYohp4ntmrESwZD46NWkbuGKxYbYuqWOD3u/fwlbyccF527mqFE4EC05EYLfY79N69w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9476 The kernel's own CStr type has been replaced by the one in the core library, and is now an alias to the latter. Change our imports to directly reference the actual type. Reviewed-by: Lyude Paul Reviewed-by: Gary Guo Signed-off-by: Alexandre Courbot Reviewed-by: Danilo Krummrich --- drivers/gpu/nova-core/firmware.rs | 2 +- drivers/gpu/nova-core/firmware/gsp.rs | 6 +++++- drivers/gpu/nova-core/nova_core.rs | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nova-core/firmware.rs b/drivers/gpu/nova-core/firm= ware.rs index 68779540aa28..2f7249383e51 100644 --- a/drivers/gpu/nova-core/firmware.rs +++ b/drivers/gpu/nova-core/firmware.rs @@ -424,7 +424,7 @@ const fn make_entry_chipset(self, chipset: &str) -> Sel= f { } =20 pub(crate) const fn create( - module_name: &'static kernel::str::CStr, + module_name: &'static core::ffi::CStr, ) -> firmware::ModInfoBuilder { let mut this =3D Self(firmware::ModInfoBuilder::new(module_name)); let mut i =3D 0; diff --git a/drivers/gpu/nova-core/firmware/gsp.rs b/drivers/gpu/nova-core/= firmware/gsp.rs index 9488a626352f..ae3f6581c5b6 100644 --- a/drivers/gpu/nova-core/firmware/gsp.rs +++ b/drivers/gpu/nova-core/firmware/gsp.rs @@ -32,9 +32,13 @@ /// that scheme before nova-core becomes stable, which means this module w= ill eventually be /// removed. mod elf { + use core::{ + ffi::CStr, + mem::size_of, // + }; + use kernel::{ bindings, - prelude::*, transmute::FromBytes, // }; =20 diff --git a/drivers/gpu/nova-core/nova_core.rs b/drivers/gpu/nova-core/nov= a_core.rs index c1121e7c64c5..b5caf1044697 100644 --- a/drivers/gpu/nova-core/nova_core.rs +++ b/drivers/gpu/nova-core/nova_core.rs @@ -18,7 +18,7 @@ mod sbuffer; mod vbios; =20 -pub(crate) const MODULE_NAME: &kernel::str::CStr =3D ::NAME; +pub(crate) const MODULE_NAME: &core::ffi::CStr =3D ::NAME; =20 kernel::module_pci_driver! { type: driver::NovaCore, --=20 2.53.0 From nobody Fri Apr 3 02:56:38 2026 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011065.outbound.protection.outlook.com [52.101.52.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FF66231A3B; Tue, 17 Feb 2026 02:46:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296390; cv=fail; b=HwY4o2qnApVo0thrZJltIOZiKyklAO5IsmbDYuZWgitI5PMKGgn9GUIKb3Oyi/CEjyiFE0UqutWQB1SN6S3vE3wPVuGePfRk/SnVx4OuQFx9UThd/M+Pq5/tqRpEbcrQA7rgmSQ5E25HyYH+Qb78+c85b8xDdJtn8ItQ25SJSWM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771296390; c=relaxed/simple; bh=ytdZXcl0O3V0Vp3OysmI2FtpmcySF14Kj/cfu46wG8w=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=UGMmmKyxAjpV1CktHvCYECn8CoeLXvNBft6X3u92MG8zdGSIt3WrrSvyFp2PsnnVC6B3ByZ8UULgm5+faQC7dnSXpEgTcMikg9cyMNaqwQ/rC9FGcBInxcKHDhSse/eRECHcKE1oQPZsJaT33Icv6+Zv/0O/WEeNyi8mUVov6po= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=k7lgCSvB; arc=fail smtp.client-ip=52.101.52.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="k7lgCSvB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DSSta9WcFx7ETmWkAKPv+4uJBZPVdiSSdXd3KR3CRh1ZbEnxY1Li2EV9rf1i/h6p0ebBiSxh2B6WjDR/DDd49Yvakchv/a7fIb3oWYAt8nIJsnZZjEHSetOdqeI/4a5X0gKqfgvFtrVPKOzrTNFvPanuLl7nXQXjxTT6/bLEvwfAuBgaZni0IO4germDzmvWCJQpe15nxYKBGy6AQ7Nk+r6LoHRuc5VreBy+alOsVEdmH0oeuJQiCZ50UDA6O1GRO2Q8hXH1MLzJWNjA+ainXTt/t4UX9NlxYIHPlObUhOx4OkgWe/Zuyumose+0wDpkZPCpsOMFTfWeWdhMrQsLRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u/Y9PaoZ8Vpecjs3GN3ARpEx8h9R956WmXtaOf394/E=; b=fX0Z6R047LHB6ZMPhaCzDNYW6zVkU8X6HfIBDxXyjBlsGCfE8+Avzu/vSYEpBmCIC4+Ip3T/3b3wpKoI7IaSCSsR0TosfeVXVNBKsQvKiA5RH3wsZR2C9uxNeFF0SLevk/kxJlBES/nWh5+mJX8//6n/nDhyMqQAPfJtD9IPcsQ3WKBsr4G8uqVIKihlXQlv3zBdYeWqKiVZexYevS8oLHIxe1LATCagD3ylj8REpeVLg3SxJ5h0lNhMkzsWLcEGSIqH6j9rB4AQndWLFpUZM0MNiZcUZ7e4Y/4BHk1KKV4IoabuP5ttc8O/63HenOraiU3XqD8tkT04VSqaC2GTFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u/Y9PaoZ8Vpecjs3GN3ARpEx8h9R956WmXtaOf394/E=; b=k7lgCSvBqpP2sj5zASOogGvu0W/Qh1FgUpkBhzVaaHo/7m0/eoPUuOz+e+0Suw22si/0pR/xceMoeBdXBha5bX8rGgcyeRxQWfSG61C1aiYBrsoS7OtQ9RQJ7tSyQCfwdf5y2BeEdX0QFY70qJn9DfzXjFaDtZc0FRvAXQjcO4iCbu/Z4lEgii8G/gVzSNxBz/kqsNX1NSh6g4edTxImNndY+kxqHxRZSiuWUHgb2GDSZjmywGqsTgnnYZlTjsk+uvzHmSoemq0XmO5yFy9WwZwzTFziaGQhrlzTub8sObH31QtNPKzHYsj39wFRLgwLJYcwPwK4XeUcAvxZWXKqbA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS7PR12MB9476.namprd12.prod.outlook.com (2603:10b6:8:250::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.16; Tue, 17 Feb 2026 02:46:25 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%3]) with mapi id 15.20.9611.013; Tue, 17 Feb 2026 02:46:25 +0000 From: Alexandre Courbot Date: Tue, 17 Feb 2026 11:45:56 +0900 Subject: [PATCH v3 8/8] gpu: nova-core: gsp: use available device reference Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260217-nova-misc-v3-8-b4e2d45eafbc@nvidia.com> References: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> In-Reply-To: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Gary Guo X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0043.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29d::14) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS7PR12MB9476:EE_ X-MS-Office365-Filtering-Correlation-Id: 8778b99d-e1da-45c6-5cd2-08de6dcebe10 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Zlkzd3FuVkNpME96byszQlY4Vk9qcHlKeHBwSGVpNUxtR1p4bzZiTWFSaWNU?= =?utf-8?B?YkoxQWNlUEdLZTVxc2wrNm9SL2xHK2dVVHRZTTBUaFlubGRUNzlaV2p6bUtz?= =?utf-8?B?ckNjQnlPbVhkZCtzZ1dlbkFCUHVNZjArQ2VSbVZnMDVsa05VaWdlV1ZnbW96?= =?utf-8?B?TzZ5ZEUxdFdBRzV2UkZlR2M3bHFST3AyLzUyRTAxV0JhMldINmxJQ0toN05J?= =?utf-8?B?aXBLYS9WM3NrTmZGTHF4Y2JaM05Ndmx3bzFYYkNNUVhSTmpRQXd4aHBzbmNm?= =?utf-8?B?dGN6alppSzRzZVk0YVNRcGJFVmlWbGNzRm1wV0dsQkxIMEhIRWptaitzZTM4?= =?utf-8?B?cU5FUEJwR1JRQVdUeUpUQXNFYm9zSGhSbTZIekpjajQ4WTJwRll1RVR5Y1VL?= =?utf-8?B?dXdVTk1tSzJmRGgvd0ZoNHpUMXNESmVqWmlmUWdoalVLYVY1Y2tYa1Z4OUxO?= =?utf-8?B?dUVxOCtsOU05cTR1RVozV2Judmx1WFFNTjUybExTaDdwWXFzK1k5Z0ovVStk?= =?utf-8?B?Ymx5U0xqVGpWSjJLMWlVWkJXblZjdWNIQ2d0cnVEM3dIVU5DZ3FWdWJIOFVl?= =?utf-8?B?MUFHSTIreU5VbmY3Uktma0NpcE1BYjFvZDBiOVRmQkR1SnFaeUNBNUUrN1Fw?= =?utf-8?B?VHpZVWROdjErUmRpbk1pY09xTXhVNmZqeUpGYUw5MEpPTENlRWl6bzdyTXV0?= =?utf-8?B?WEhlN0xHQ21zWWo3UzJlU2s3M3F4NnhhR0dXZXVLQ1NvTk1SeWN1MG9lR3V5?= =?utf-8?B?eWU1WDYzbmxrS2hZYWM1aVluSjl0OHVrNngycFBNay9rdlQ0bFBQM2w3b3R3?= =?utf-8?B?WFU4N2lQcWg1UlhhVHVRRW15WFp0a3BKd2sxMU90cld0RE44NmZVMjJBckFo?= =?utf-8?B?WkNlaXQxOUtZa2pJT0FlYlJzcEpqRmkxaXlTdTRpcFdiSWYrUW9HUGNvMzJV?= =?utf-8?B?bHlVMzVjdjBDZFd2NVBDdm5kSGFjcFlIUlZmejlJTlJ6SUszRThOMytxaStD?= =?utf-8?B?SWFnVEtnd3d2RlRxckx2NFZZMnpGV0k5cHZ1QW1iVys5elpXSGY3ekh2WWNQ?= =?utf-8?B?c1hUUTdzUTRvWmQ4TzBUTXdsOEJ2MUlIMmtBaVU4YytPeWZnUEFqQnVzWjRw?= =?utf-8?B?bzBaNk1BL2wwNTJ3ZHRtbHRyRXd3RmVFeG5nc2ZYdjJzV2tTYWtpSVBEekxR?= =?utf-8?B?TnNOMmZMSlVuc3QxaDhFR2N2dWxmMDNaK2VNYWxKQ3YyU3hYdzZuaXZISG1W?= =?utf-8?B?Y0ZTVkFWWDFPRWczaUV3Q0t2TzNXdGcrV2N3L2RZME81c2d3Q3NrdW52bU5O?= =?utf-8?B?bTdEY0xuUTIyRkcwKzc2blNGK2ZUTHpuN0NnZjY2WFNhTm9yNjNXalZaK1dq?= =?utf-8?B?ei8yTklYU1VSVFFSaUFNTFoxUDV2N3lQb3NrY0krT1p4eUFzRSt4T09oVy9p?= =?utf-8?B?L3NpRTN1OFZ2OWQvUlBnZnVjbWlCT21GTk9SbGRWR0ltR0VpSlpPRWFPMTBI?= =?utf-8?B?MkNKUDNidVlzVkNybkRHNTg5NEY0MWo3SjM3OHRmN25tZklyYWJodXhvNitQ?= =?utf-8?B?ai9ZNktnQVVvcWFudVNreEM4TmJ6TGNuNUEydk9ubGFYRW11dE5NR0xXbElX?= =?utf-8?B?MUlBTFY4RUI1blpoR1dFcklLK3B6SFlkSS8vakVIbEhFOXpBc2VqNG1xeGpR?= =?utf-8?B?TkZGSUhrYUU4VkJZT1N0SUxOWDFKaXp5TWdTVzNmaDdOOUw2VHVlNXhMZ2FM?= =?utf-8?B?Y3g4ZlRRcjgzL3V2MnVKbzNaMncrK2ErWHlwcHdhSUg3eE5OZ3pJRzZYL3lL?= =?utf-8?B?a3FabDU1WjcrOWdyQnBZdktEMmxYL2p4bk52MlplOHpqUG1Fbm9WU0FDRVBZ?= =?utf-8?B?VWpPUW5nQmh2bS9wSFdManIvZWx1bFhTNFUzWVBQVkFSMDRMVmlBWWpZR24y?= =?utf-8?B?aEUzdVRnL0dla3VRbU11ZjRHa3FwZ0lybHlvM2VOSFhxSk5YSkVZUTlDNHVh?= =?utf-8?B?R3l1bm8wWnZHM3F2ZnJZS2NubDFjWmJRcXJSY3NmSlNYSGg5VlRoYitBWFlH?= =?utf-8?B?by9XVG9yMjFUSHl0SGdwbFdpZ1VKSUhsdkk5amhPRlVDOG5EODhQQzFJektT?= =?utf-8?Q?tqCI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVcwOE9hRGVqQXh4dDNEL2ZBbWdtTjQzU0J3UnBYTHRRK0Z3dzVTQWhZZ3ZV?= =?utf-8?B?M1F1NkJTNXB4Z0dmbXVaSnJGcTZEcGJ3THdiTlV4OWNSOU40RTBScUNMSGVs?= =?utf-8?B?d0s5ZkYxSGdxVWRLSG1uSFBIS0RZam1DNHZVLy9HZ3pFWVcxbE5NTGF5RHRL?= =?utf-8?B?cVN6VEliRkx3dS9IUE5TN1UyVU1mV25TeU1DUFBEN0NlV2RnTElOVlhzZmRa?= =?utf-8?B?UTRqV3J3bm9ZRGhNaUx0ZDJZcGd2ZzdQQWZ1bFZ3Si85RnFhTjN0MWpjaHd3?= =?utf-8?B?Q2FvaWxPZFUxendETks1VGhrWnoxd2xNOHF0TUQzS0NFYWMzcFBTeW0xVWR5?= =?utf-8?B?QTl5ZU9BMXZKT3JvcGxqNHBjT3R2WTY1dnFrVnNqWStZMVNOcTJxamlGTTdQ?= =?utf-8?B?cHZSWm9CY2FzZFpXNlgySXFOVHUwajZoZHNaVE5wbDdPd3hpVWtJWlpMYlNr?= =?utf-8?B?bWNycUhBdUtzM084dnVCUHVVbXNsTVJCUjdqTlkreDJZVmFNOTBJc25Wa3hn?= =?utf-8?B?Um5ydStJWndraCtvODlGYWg4OU15QlQ2Z0lhN1Q2WVhQdklXMWlCZVhnQmhH?= =?utf-8?B?eTgxUDdmKzFRbHRCOHU2SkZRcVVwQW9vT1JHTW1YRjRFNysrZkFnSTBTQzdW?= =?utf-8?B?L08yeUVQa3dOckU2Znl2Nk1WZDE2bG1kMFBXQ1VuRjlJdFlKRzdBQXpucnNX?= =?utf-8?B?K1JacXhzT3N1cEN6UG9jUXRZNVhkNjYwSWkwNS9hcHNjNlFwUEg2R04vc0JG?= =?utf-8?B?UWpla1BTTlk0enlJZVhZMEVyck8yMWYzZm03T3dIdUk3NFFaOWR6Rjl2c2lI?= =?utf-8?B?eTltbjFMMitIS2lUVWRQSW43T2p3T1RkYWY0aEg3NXZSbk1ER3Rua2phcFRl?= =?utf-8?B?SjdtTnVPRjYvRU5BTG9kc043R0MvenBwMEpEZElSWTFXOExtR2FLdmlERk9S?= =?utf-8?B?NUg4aGJuMWZOZkdKN2czOUlVSHlLSDdCWlcrN0E2ZnBqM2dkTm1hbE1JN2xa?= =?utf-8?B?Zk9naS9pZk9mMW8yYThKTCtQaVNBeXA5SGp2STF6WGgxZlhueVgvcnA0LzJz?= =?utf-8?B?MThPYzJmV2t6U1BhV0lKTEZJbzR5MUVTdzFYUmpVcm5MbzBqNG9LSnFWVERN?= =?utf-8?B?QVM5WGo1Z2JYQi95b1g0M1d6VmFwS3lKZzNOQkwwdnVyN3duNk0vZXkyczdw?= =?utf-8?B?UlljOTkwL0FrUUVkN3RHTnpnc1lwL0pjNEQrTnlqVUFwSVByWlB1dTJMOXlZ?= =?utf-8?B?T0EzWkNrd0x6VTZsZCtxSytGM1pFZ2J6anhwV3N2T3pXMWlUWk1KdTdiZVBD?= =?utf-8?B?VG1RcjF5a01RdHk2dVFWbDVxOWJCSEM3UUlYWkh0SEJCbDYwZ3EwWWFWOTAx?= =?utf-8?B?TE1HQUs1T3RLVE9QaU1IQ0FxZ2lpRTNaWkxGdE9ialRpS1VWRE1PYzV5R1g5?= =?utf-8?B?TFJsOXlzLzJFL3lVaXI3V0NFa21GUUJFTmdJcWhGUkJmajVuUjU4bmV5UVpQ?= =?utf-8?B?OWR2MkRNVlo3anFjeDNNUnVsNVhhMnc4dGtGYXg5eVlCbTFzUVNVbFYzTENC?= =?utf-8?B?dDUvQ1ZraXYxL3JvaldwelkyM2NpVjg1eTZGSlc0cTZFRVgrWDUwaVNxaS9w?= =?utf-8?B?ODNGbi9jQlJ2R3hJSHlsMk55QTgvY2tlelJKQURRcjBwWGVoNm80cTNDVWNh?= =?utf-8?B?UkFkbFZ6OENaRzMwdVFXOHVqSENKd1JrcUVYYlo3SDVkZHU0WUZLWXp5UHBz?= =?utf-8?B?dW1rNkVIa2hHeHFpK1BWUkF2ZlN5NmtQRE5rNmQ4VHB2cEV6RmlGVFhPU1p5?= =?utf-8?B?bkdjRVNpcUFXQ3o1WklFQ2k4alpRbXZiRWVDUnZucTJqMVNpU1J1eXFCRVFI?= =?utf-8?B?Y01KYklYa2hZWUtrMmxjWS9McHRUcjI3dWIzT3kvWis4MUNiUnV1dWtFZ1Nm?= =?utf-8?B?UDk0enlIaXhTUjlsR00rUE1PUHBNQWdBZCtGb2puYUJvZkxYYzVjVHZvTXEw?= =?utf-8?B?bHdpL1VKcFhlY0lJYlM4MTNqUTZZRHVJRThyY3VzSEwyUHFNQWFtcytvRE1s?= =?utf-8?B?TmhheXhyUFd0b250NnFidTNHMmNEL2d5RnZ5L3NWbzhJZ1BZSHdzQUd1ZFA3?= =?utf-8?B?cW8yZUFFYmN1alUwWlM1WVNwSW1MaXBjTzB0RzRaNEd3RGZvaFIvcm9ETG14?= =?utf-8?B?VEF4bW00aXFtcTllUjdHdHpwRVc1aVhVYUhKUGFMZFExaG5JcEwxcDVFdXpO?= =?utf-8?B?WVA4YURkTzBQaGV0dStIZ082LzNKZUNpa0g0Vm5BSmpOelRNbVhlZkJVSS84?= =?utf-8?B?eEQ4bzZoRENJN2J5Z21aV3R2Tk5tWUw3SWthUlRXNndub1IrdjhCdEVvOVd3?= =?utf-8?Q?5zhQR8dO3KEzmLYYszAzC3EM2MolEVWQXCxPRJis6wcAY?= X-MS-Exchange-AntiSpam-MessageData-1: baZG9Mj3r9fFmw== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8778b99d-e1da-45c6-5cd2-08de6dcebe10 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2026 02:46:25.3900 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2myan4Th40UqwN0ySbsoxietzX/GsCQ+03K6plQ7h6L5dOHl53wqXCJRbbupsCqKFo/y7YLcsLmyCUXqyf6byg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9476 We already have a regular reference to the `Device`, so we don't need to repeatedly acquire one in this method. Reviewed-by: Gary Guo Signed-off-by: Alexandre Courbot Reviewed-by: Danilo Krummrich --- drivers/gpu/nova-core/gsp/boot.rs | 34 ++++++++-------------------------- 1 file changed, 8 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/boot.rs b/drivers/gpu/nova-core/gsp/= boot.rs index be427fe26a58..93651243ab1b 100644 --- a/drivers/gpu/nova-core/gsp/boot.rs +++ b/drivers/gpu/nova-core/gsp/boot.rs @@ -170,15 +170,10 @@ pub(crate) fn boot( Some(libos_handle as u32), Some((libos_handle >> 32) as u32), )?; - dev_dbg!( - pdev.as_ref(), - "GSP MBOX0: {:#x}, MBOX1: {:#x}\n", - mbox0, - mbox1 - ); + dev_dbg!(dev, "GSP MBOX0: {:#x}, MBOX1: {:#x}\n", mbox0, mbox1); =20 dev_dbg!( - pdev.as_ref(), + dev, "Using SEC2 to load and run the booter_load firmware...\n" ); =20 @@ -190,19 +185,10 @@ pub(crate) fn boot( Some(wpr_handle as u32), Some((wpr_handle >> 32) as u32), )?; - dev_dbg!( - pdev.as_ref(), - "SEC2 MBOX0: {:#x}, MBOX1{:#x}\n", - mbox0, - mbox1 - ); + dev_dbg!(dev, "SEC2 MBOX0: {:#x}, MBOX1{:#x}\n", mbox0, mbox1); =20 if mbox0 !=3D 0 { - dev_err!( - pdev.as_ref(), - "Booter-load failed with error {:#x}\n", - mbox0 - ); + dev_err!(dev, "Booter-load failed with error {:#x}\n", mbox0); return Err(ENODEV); } =20 @@ -216,11 +202,7 @@ pub(crate) fn boot( Delta::from_secs(5), )?; =20 - dev_dbg!( - pdev.as_ref(), - "RISC-V active? {}\n", - gsp_falcon.is_riscv_active(bar), - ); + dev_dbg!(dev, "RISC-V active? {}\n", gsp_falcon.is_riscv_active(ba= r),); =20 // Create and run the GSP sequencer. let seq_params =3D GspSequencerParams { @@ -228,7 +210,7 @@ pub(crate) fn boot( libos_dma_handle: libos_handle, gsp_falcon, sec2_falcon, - dev: pdev.as_ref().into(), + dev: dev.into(), bar, }; GspSequencer::run(&mut self.cmdq, seq_params)?; @@ -239,8 +221,8 @@ pub(crate) fn boot( // Obtain and display basic GPU information. let info =3D commands::get_gsp_info(&mut self.cmdq, bar)?; match info.gpu_name() { - Ok(name) =3D> dev_info!(pdev.as_ref(), "GPU name: {}\n", name), - Err(e) =3D> dev_warn!(pdev.as_ref(), "GPU name unavailable: {:= ?}\n", e), + Ok(name) =3D> dev_info!(dev, "GPU name: {}\n", name), + Err(e) =3D> dev_warn!(dev, "GPU name unavailable: {:?}\n", e), } =20 Ok(()) --=20 2.53.0