From nobody Fri Apr 3 03:06:03 2026 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A78BC3F9FB for ; Mon, 16 Feb 2026 23:16:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771283791; cv=none; b=Lj3ZGMusLcHGUzHSv9sGrgOMqdRZeVyMnxMFIVr55ET5cQEVuuoqctt7HgjQ+NVP+kMhHCE3C/awGE1UCS39Yf69yn+4+JlvfE0tQsjtfXSFq3IvPSm8zHRhRojwKkLvOJUwiTi8mlP5RfIPeWcTPriVwnyCLai0YJ0cpefFqu8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771283791; c=relaxed/simple; bh=Pa2MOcKe8uKCnqHODEMByomNJHgh5aTvfH2oa/S9N1Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PtR/G5sC5jTC/PkDTN9QW7S9uTQOnfdOySrjGJqXtZEfXoa/zuM75uQkrQ4nEVg7fJsZXcPcuk+NdkG0lM+G9/3wvMaYEQB3q4BgbXjOY9wK84j1x8cNcXeX8V/4cY8/uBOMQGkbZfhcwP4IQpZQIMxt2iv0g9Heh9Fv35jBXmM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hlD/iEsD; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hlD/iEsD" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-7945838691aso70502347b3.0 for ; Mon, 16 Feb 2026 15:16:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771283789; x=1771888589; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LvdWQUNtVV5F3OwagAitOy7mrtkoaXiSfNcPJB7Gg9s=; b=hlD/iEsDguy2b5pYxqtV9clqabpCEG6eMym/H7sA7sKtRdTdFHQYg9DJuTJUq14CIU u59XWfs2zd2DvYf2YT620voEZHxbrDfuy9C5cfVOzttsGxxmVHR+oIrpQGxTDcYUxtr7 SIwO+QujccuFaepabqR0UNFijUG2Y6g7T3DreETmRUUZodzxvj+ybc1s1jxElx61eR4s hOgZG42IXGrkq8nT33gd8bRc9RmMhJkX1lb4AGU9JAgIHrRmsksE1Zxn8afZlTu9foVG 2vhgLwsq4VeYHKC3onZvNvWPf/msUSi1CV0A2RsMLuYxe7WQmtCo/K2n3hzbnggMn/4S NLew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771283789; x=1771888589; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LvdWQUNtVV5F3OwagAitOy7mrtkoaXiSfNcPJB7Gg9s=; b=DBHyulZ1VlaVVUukjYkI/QV2KiWnJ2AvgKoe0EmLz4naLVw80ZTfnEsgWhgOJqqGAH ZsoZw7J2JEzl9070TRPoLahYKeVtmQiwACvxw1gTKuHpoiw/RcccTn4sW6y/pswdufoS +Yhcr4UmiImLABDYmG6NruSly/Ckg0UKCWv3xYtF+peUd34tsXxF1WE48nUeQ/INlPon r+++d1+0CARkCj8KsfxEAJaPNcpt/ntZQ/JwMrgbGSd7NAaYH9jInfaB9HIIAqME04je 0Pgegm12xAM1DQMfXjyH+NUeKlWws1I4lyCjHh8GNpmhpdv2QsZLhU++iZWMW6NgHxrw IGGg== X-Forwarded-Encrypted: i=1; AJvYcCWNrMi8bHsPgQT7r7fwoxuXQ1hOLFlRyZCO5tQvWstXMGN+dZCAOkBCMKeDHIRlNbXNsAPAKiOe0dtm9Eg=@vger.kernel.org X-Gm-Message-State: AOJu0YxggbirR+ELXCrxbOyAJ7z5yMmBmhWA6QgLaKYIdErWtVWhOKXe BiMQxiQ+Epeeh0f4omCUs9GcIutLL66QMP33qGB5R2CgQCc4iiradR5V X-Gm-Gg: AZuq6aJZVk7zAS15DShpTe97eVkuClOqjw6pBqx7jvm5arhGCJR+N7B3tTDACqP4nB7 lor5Bg9qHrtiMUZ0RzeR/OwNUPGOfz+Iu+7uanpku8PfGViynNyKTby7AhI5e+78RvCXVs1WRk8 Zzck8UARlBmO/hCA9Fy9g07Nq2ylPoELaYZMuH3/8BFdwgOnuUtQlnNQQpvgw3wvW+S6S+0PdaX DdP1PY1mArqsUOBLqg0Ilt4Wni+IXgjtevoY5wbUrYGspFaggJb/M/vzEAsk9G1IzVYcRBJCJxD 1Vkjj1G+yWwaaHDhGIzwiEt8MXG+XBTietor4aJGuu3HmJa0jOrZiUio4ftX77UutEapPJvUXxG znTBjrdDC6LzVgheL7EmtO98r6C6xOxeZXr/AUqBv+hizQ57Ik0QWAU769jk+9wunax98njY9U6 BU9ghh4EsJDu7GvvfTbfXFtiOVY5+YS7nn0DxgH8JFubo+xNORgCOOa7hiUHvMzqOUQSWU5DZtQ 4bUt0sYZyXdQuA48iiSTgsou4H5rxEQi2yLfUbWok0= X-Received: by 2002:a05:690c:18:b0:794:ebee:7f15 with SMTP id 00721157ae682-797aa902defmr72650237b3.21.1771283788617; Mon, 16 Feb 2026 15:16:28 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c18b464sm106738567b3.13.2026.02.16.15.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 15:16:28 -0800 (PST) From: Ethan Tidmore To: Herbert Xu , "David S . Miller" Cc: Keerthy , Tero Kristo , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] crypto: sa2ul: add missing IS_ERR checks Date: Mon, 16 Feb 2026 17:16:09 -0600 Message-ID: <20260216231609.38021-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function dmaengine_desc_get_metadata_ptr() can return an error pointer and is not checked for it. Add error pointer checks. Fixes: 7694b6ca649fe ("crypto: sa2ul - Add crypto driver") Signed-off-by: Ethan Tidmore --- drivers/crypto/sa2ul.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index fdc0b2486069..58d41c269d62 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -1051,6 +1051,9 @@ static void sa_aes_dma_in_callback(void *data) if (req->iv) { mdptr =3D (__be32 *)dmaengine_desc_get_metadata_ptr(rxd->tx_in, &pl, &ml); + if (IS_ERR(mdptr)) + return; + result =3D (u32 *)req->iv; =20 for (i =3D 0; i < (rxd->enc_iv_size / 4); i++) @@ -1272,6 +1275,8 @@ static int sa_run(struct sa_req *req) * crypto algorithm to be used, data sizes, different keys etc. */ mdptr =3D (u32 *)dmaengine_desc_get_metadata_ptr(tx_out, &pl, &ml); + if (IS_ERR(mdptr)) + return PTR_ERR(mdptr); =20 sa_prepare_tx_desc(mdptr, (sa_ctx->cmdl_size + (SA_PSDATA_CTX_WORDS * sizeof(u32))), cmdl, sizeof(sa_ctx->epib), @@ -1367,6 +1372,9 @@ static void sa_sha_dma_in_callback(void *data) authsize =3D crypto_ahash_digestsize(tfm); =20 mdptr =3D (__be32 *)dmaengine_desc_get_metadata_ptr(rxd->tx_in, &pl, &ml); + if (IS_ERR(mdptr)) + return; + result =3D (u32 *)req->result; =20 for (i =3D 0; i < (authsize / 4); i++) @@ -1677,6 +1685,9 @@ static void sa_aead_dma_in_callback(void *data) authsize =3D crypto_aead_authsize(tfm); =20 mdptr =3D (u32 *)dmaengine_desc_get_metadata_ptr(rxd->tx_in, &pl, &ml); + if (IS_ERR(mdptr)) + return; + for (i =3D 0; i < (authsize / 4); i++) mdptr[i + 4] =3D swab32(mdptr[i + 4]); =20 --=20 2.53.0