From nobody Thu Mar 5 06:30:50 2026 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3B912C11FE for ; Mon, 16 Feb 2026 20:20:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771273241; cv=none; b=Uym+iFgm5+lz934caIgJoMo8mm3jk7Xai1Qs9W9r9Hoi/F4Gg0tuZU6Q86qufcKG5IYQagbhiWBHDlUQj5cXwcDj5QD3yaIQaXGSdCccOC/GOG/XAeY86/EXXN3WY8i5WFtsbTYSIBgMdbn7yNQMJP8zNFsVIH3oHOsy6WhyteY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771273241; c=relaxed/simple; bh=BRGrLzxa99hc7MTho+QIoxXhA4vsCiW32jOrt2sHIxk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KoFSfBcEncm77WUgWL2eDPo2aHHtEy0e3Dt1ehogSEJ+EAc+qQ92I172TpZ46REkS851qbs62KrZT9+jaoD9IljINEkHGMsGeybd63UKaWIWB22naox4BsVRgBe2isDrk4xpL11u7nW5nsK5IsAEW3KqsZpFqPQtXa5NuqEgPqE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P0IjUJbo; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P0IjUJbo" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b7cf4a975d2so497263066b.2 for ; Mon, 16 Feb 2026 12:20:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771273239; x=1771878039; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=unrY69CU7KeFJol5SFNINgosAWZeimEWByegibZitl8=; b=P0IjUJboX4Z8VgY8G6i6F6a35fgTN28dGvn2ncDW43ZtOrF5hWRqglZTtakltDBXrz oqoM5YjPADkUPK6rCf5x2eo6GNoyGcAw1Mhh3gcTOd3TPGNcjQ0ern7WC/81uy5zPQYd yHULMIVQEZ0JZGbqn2Mw99bbswxvJ3K5ENdBXOQIjEe8f237Hoo/9sVaJdPM0luUMVbU Bo8PLKq2C+xX2oj4dDKigfQme/GTADKCCjcpHaivE5tJkpWtioCudoQ/eoUKdoNatW8T 815ooxurJaHU5hpnFD3SdpYevDLAuhAknuhz6VxEj/bHlSqdk01OcyUzdz7qaiD2zuVh Od1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771273239; x=1771878039; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=unrY69CU7KeFJol5SFNINgosAWZeimEWByegibZitl8=; b=BVBSA3ZAFCp9m/3KNq52jEWR5TskJFgoRycPtUuatRChyjzF4ifBxWh4tce3x6bVZs EuZO0IKUS7BGLXaqQCMW7EFB94FJLFOHecMIJPx2bXHsSedR/3PmqN6i594iHlKkUTm8 8Rd00t0r8/xszTpteCHoLTQZ5cXZOS8jTc4F9J4ZCLicXePTnxqihbdZBk2e/qPTaKk2 /1nBuyyzeAljC1Mb3WlUdC4NiNXufe00gMfosXnatuKRbqeu+7FE8BY7K0DAAoOGFAsy mzcbKaM2jGyRtuhTyxVhSWo/JPZvd7EpSpOka0qVGA92H+AsO4qFT/amCZeSl1T9eD6U 0gPQ== X-Forwarded-Encrypted: i=1; AJvYcCXtaoi/kQgOxejp5LAt55ZFnWJRQGL/A/2M/E865P2aUNWcLqXdQhuXDxwb6i8ieGyRfeqvPjttz2PhlxM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1cwH4EBsTGv7w6Vr88HdM9BoSRIRroOI8Y5gkoI0KompGG+DT y0z1EhgTwK25a7QuY0VmSaLOtj/zOAY9it5k3JBzyel4VbQk6EUEkder X-Gm-Gg: AZuq6aKpCrE/ho1ANUdXO2LNvu2QPazTNBnC2oPChriKX99i1trwGp9BvygymOPpDBP dSwEFxonPwz2BrSvXKH9L9ivYbggwCP3JWtamp3sNnGHAFznr9Pjqnvsic39Z05fgyKWQ4Hk5JF eKwYg0DVwJZ6LiPQKuJCzubdCodLS3sLEJXouRv+zH/Z0xl+4vknhU+Q/peucaMuPU15FYBSrSd PvFrwDeFi9vyvPINQDxu63SCXznWOKKdFW8mBkEJX/+PMwMiQQe+OcqG9Gl3IjG8bqZKxinCCI9 rZjs7+iKwqZZXLnFWWp8PwAEJ/h/F5ytRSa8s7JbMvRAxsV6XPsicMjJd5uHgEK59iupmfOPyFQ 6570/0MOoY7DsPTtn0FoRJ+0PyT8Y9m+lUDova9nadf9e0WWzPL3h5da3oVrBwMzaRVs3DQL3Up SB2Bn8dPi8CXW5klbO7iNHHvWQT2g/EyY6PRm/VBcK6TcagBMppCCvPqnkD7b2mIbucH3pA8Ua+ eN9rmWEQPy8dfMKdAGePSsXY4nTszS7qQBS6LKi4GIv0PZijlJQ81OX8JlQnssurLpF5VjjWUbI Cg== X-Received: by 2002:a17:907:2686:b0:b8e:7dcb:7f1b with SMTP id a640c23a62f3a-b8fb42200eemr635735366b.21.1771273239032; Mon, 16 Feb 2026 12:20:39 -0800 (PST) Received: from cs-874966990260-default.europe-west4-a.c.i2f7e30109524dc12-tp.internal (170.212.12.34.bc.googleusercontent.com. [34.12.212.170]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc73a0039sm284309766b.25.2026.02.16.12.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 12:20:38 -0800 (PST) From: Artem Lytkin To: Greg Kroah-Hartman Cc: Sudip Mukherjee , Teddy Wang , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Artem Lytkin Subject: [PATCH] staging: sm750fb: add missing pci_release_region on error and removal Date: Mon, 16 Feb 2026 20:20:38 +0000 Message-ID: <20260216202038.1828-1-iprintercanon@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" hw_sm750_map() calls pci_request_region() but never releases the region on error paths or in lynxfb_pci_remove(). This causes a resource leak that prevents the PCI region from being mapped again after driver removal or a failed probe. A TODO comment in the code acknowledges this missing cleanup. Restructure the error handling in hw_sm750_map() to properly release the PCI region on ioremap failures, and add pci_release_region() to lynxfb_pci_remove(). Signed-off-by: Artem Lytkin --- drivers/staging/sm750fb/sm750.c | 1 + drivers/staging/sm750fb/sm750_hw.c | 22 +++++++++++----------- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm75= 0.c index fecd7457e..2d54d52ba 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -1123,6 +1123,7 @@ static void lynxfb_pci_remove(struct pci_dev *pdev) =20 iounmap(sm750_dev->pvReg); iounmap(sm750_dev->pvMem); + pci_release_region(pdev, 1); kfree(g_settings); } =20 diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/s= m750_hw.c index ce46f240c..b3a16b223 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -36,16 +36,11 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pc= i_dev *pdev) =20 pr_info("mmio phyAddr =3D %lx\n", sm750_dev->vidreg_start); =20 - /* - * reserve the vidreg space of smi adaptor - * if you do this, you need to add release region code - * in lynxfb_remove, or memory will not be mapped again - * successfully - */ + /* reserve the vidreg space of smi adaptor */ ret =3D pci_request_region(pdev, 1, "sm750fb"); if (ret) { pr_err("Can not request PCI regions.\n"); - goto exit; + return ret; } =20 /* now map mmio and vidmem */ @@ -54,7 +49,7 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_= dev *pdev) if (!sm750_dev->pvReg) { pr_err("mmio failed\n"); ret =3D -EFAULT; - goto exit; + goto err_release_region; } pr_info("mmio virtual addr =3D %p\n", sm750_dev->pvReg); =20 @@ -79,13 +74,18 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pc= i_dev *pdev) sm750_dev->pvMem =3D ioremap_wc(sm750_dev->vidmem_start, sm750_dev->vidmem_size); if (!sm750_dev->pvMem) { - iounmap(sm750_dev->pvReg); pr_err("Map video memory failed\n"); ret =3D -EFAULT; - goto exit; + goto err_unmap_reg; } pr_info("video memory vaddr =3D %p\n", sm750_dev->pvMem); -exit: + + return 0; + +err_unmap_reg: + iounmap(sm750_dev->pvReg); +err_release_region: + pci_release_region(pdev, 1); return ret; } =20 --=20 2.43.0