From nobody Thu Mar 5 06:30:49 2026 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F24102E22B5 for ; Mon, 16 Feb 2026 20:19:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771273165; cv=none; b=kRd98y19UBT7Z5xVEJsGUivJZk5cluKE+AcoaD84w1pblm5WOlTDHhCSDO+ovHI3b/18eaArTRzIumZ0927JRncDxK0zf1WVJjPvg5/EtMMonCm1LYUwWig1IqfDr+bL/c2peEutiZvno2HLKtTwP51ftFuPVoEVB2dnvIrFbjU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771273165; c=relaxed/simple; bh=dJfnYlid35pe2SJSokRooiDlcSYvPD84HLVz24A0UXA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Afv4WXJ+HjQcAPDkgMWfOcAgdHb78rV+F+muwFVGLMmEiTKL5kbLz6f3q8S24pWcvsoFDPMPmHlomdGS/fi0BV1Dw2r4A9FbAXz8eMbWP6UvfDx1PuWFbsMMuaDuFP6NhdO5qfdwUdTftU7yOJ4S+7qNIi+aO4U91WJfLjewx3I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ELxAEaBJ; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ELxAEaBJ" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b8869cd7bb1so557964766b.1 for ; Mon, 16 Feb 2026 12:19:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771273162; x=1771877962; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p9GwxEw6MSCg9oWHFrNUkW5VtcIdCqzBst6/spWlTtU=; b=ELxAEaBJs+vLeakUa0S5ZA6tH4xEZoYLJ/gV9BMJ5LgFobDDGdRaqF7gJ3qCsbTSDN V027evUup8PMtJDCBBpgleJYR8uhYHz0oNKM9wxQ0sMFPieiZsN9IMkegLK9Dnc9lgsu plNN4vf4GIj66s9LSjuQI6DnS9s8/wZJLgTiTJEsTyCsT2Z8WMcdZAp4hxQwjC1kjaJx 4VIJyaPjLUsLCs7a0qAUfxxWaPC/rawnY3/ibfOkL/58sot+7TcfMSUlWP1ukjp1vf0A rrlbEAxyU12G+D/ZYZ043eiaIhuy/tkXOrwwjL4ZDxN7qfu7fma3f9LZFvfsz7S5bsaa duhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771273162; x=1771877962; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=p9GwxEw6MSCg9oWHFrNUkW5VtcIdCqzBst6/spWlTtU=; b=lEyuIHG/lqSd265t/foRppXhXajWgK7cbDYDyOiS4Bp4+IkoClej7Q9cGNQSAsrPFZ 9kDCPWqTxpBXZHzuFrb9/LQELg2/Ke5rOyFYxySerJe1F1LraBGvsMvF4rnzu2aVxPT4 SlYHkSS2uGnGytE25Pq1iXsR9NI7ke8Ygy17E0nZigZaNTYctAJBqxlwtw7ciA3bl44O hZ9twwtE8MgMXpwVo7RJjjdHtyHNgoTEU4TAtzHIwVJnZwUHiya2q0oA0XrOpp8LNuHC aZxdUf954Lqcj5b8pvHUJkG3vMLRIk3OShFPh1GT0aAms1Wggw1kQMeXSwyiIId8cTYv CjaA== X-Forwarded-Encrypted: i=1; AJvYcCVlRmbjRbYx9ygEbZ3SOMi0SFY/nRBpEHptEpaBqxa5jPgTn4kCcUDar4ngcPTY0kC4ymuq333NHvjUIs0=@vger.kernel.org X-Gm-Message-State: AOJu0YzMoKooJjXUmCTmIB79xES2OvyhI1p+o06vlA9U9f52kqwa2Mw3 p/uVwtYB30IaL3REl31jn6M6L7LBEbCqQr3a5+YeLjOrRPKgpi2dewJIveuEqAgWal4Oag== X-Gm-Gg: AZuq6aJupLfuPKwndFzv/aFMRO7KENTsKa+le3yla5GY7/iPtUAi/QzHTgBNv2M6vh/ KJYoKghKzJJAYHCPW2/4SaeRz7HbGwFfELsmAVfbHaWegh/0ds67Cn17PdvAUn9G7YYaKZQ7Jw3 /kt51fHKfbKjZuNh+WqeDG2iapgoRsB1IKX3ki7oZAxhIMXhqNT3Am5uwd+J2N4tjWCUKZ9Zjd1 Uf4UR2pCQr0biukJ7LKmEOXhiYmxOaTYOVBgBDlo3ef+/YbBpDcKyqdCh4lQZvNRT+cB1zfvWZo lcW4/pPUSu0P1Epbw4p8fIPy3ko7dNnlWckT4HbWRI4IpaW+s9xWbKvxMqi7UM1FVo2THonzqw1 Ft76H8TZn6E6TDd4u6k0slm09f7hldGZ9D2mqI9L4ApNnFtzSaZEYL2No9vsdB7AENWXGJx45LQ euBvx1S5hHbXY2SKxhu7A7c2/v2JdlIrpoB86ufF5VO2uPSdp6HJ7OU5+mk+jeWHNfpSEA/H3Pb GmUIQr0AbBg0Mjcgg19se8aqcvZLtYv2cgu+EmNVlVHv2cx5dW9rOVFYOru2SlbhTgtEzf0Fhhj sKF2zjM/iQ0r X-Received: by 2002:a17:907:8688:b0:b8f:a85e:6d3c with SMTP id a640c23a62f3a-b8fc3c468dcmr538308966b.41.1771273162234; Mon, 16 Feb 2026 12:19:22 -0800 (PST) Received: from cs-874966990260-default.europe-west4-a.c.i2f7e30109524dc12-tp.internal (170.212.12.34.bc.googleusercontent.com. [34.12.212.170]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc735e4cbsm293498466b.13.2026.02.16.12.19.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 12:19:21 -0800 (PST) From: Artem Lytkin To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Artem Lytkin Subject: [PATCH 1/2] staging: most: dim2: check return value of clk_prepare_enable for PLL Date: Mon, 16 Feb 2026 20:19:20 +0000 Message-ID: <20260216201921.1788-2-iprintercanon@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260216201921.1788-1-iprintercanon@gmail.com> References: <20260216201921.1788-1-iprintercanon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The return value of clk_prepare_enable() for the PLL clock is not checked, while the same call for the MLB clock is properly checked earlier in the function. If clk_prepare_enable() fails, the driver continues without the PLL clock enabled, leading to undefined hardware behavior. Add the missing error check and disable the MLB clock on failure to keep the cleanup consistent with the rest of the function. Signed-off-by: Artem Lytkin --- drivers/staging/most/dim2/dim2.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index dad2abe6c..1f07c37df 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -944,7 +944,12 @@ static int fsl_mx6_enable(struct platform_device *pdev) } =20 writel(0x888, dev->io_base + 0x38); - clk_prepare_enable(dev->clk_pll); + ret =3D clk_prepare_enable(dev->clk_pll); + if (ret) { + dev_err(&pdev->dev, "failed to enable pll clock\n"); + clk_disable_unprepare(dev->clk); + return ret; + } } =20 return 0; --=20 2.43.0 From nobody Thu Mar 5 06:30:49 2026 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6F3A2E62B5 for ; Mon, 16 Feb 2026 20:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771273166; cv=none; b=qa2cS2+Zv97ieaJVpIyDj+YEfpUwo/xBrpeJkHOmg2EnPELjv140h3hPEKY7uSgVPhMGTToIqwK15tGBbXzRxtvGL/ifR0CbYlea1NqOADGkapnwWkfwrU8PZUEoGWuBEeA0UoMkVB+ftVwhcrSImR3uJCHji7l/r7Nk8+xXA54= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771273166; c=relaxed/simple; bh=j6WdTuMbnAS6EZ4UGShL/yYnQY30QjPumdOaH2gmcrI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WhX6o3qCCOousC62b5RzXn5fq97axaLyBFTY19+fZStYZ30snwrp0AU2XzQhvfGIxsomqtXCctfeZTRiRLkTWo37i0Kh5iztnnikjR7PQ70/nrc7Pfrywnc/MUUnfMHJopMBLipjcVGfBO/67fmK0v7XUiFFmn1g56foFiplvJ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JKEgnA6u; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JKEgnA6u" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-65b94e0a875so4961977a12.0 for ; Mon, 16 Feb 2026 12:19:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771273163; x=1771877963; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PVXohdqNVWPFTDXwbCd6oi5O4NV76l+yiiTi2RIk6l4=; b=JKEgnA6ugJO1umjX4MLug4T1J2sxgII1TEhrxfIfuZmZuhzqnuUPcWnyl4X6Mn25C0 ihUX0jFfV5+6SBJruaDFIc5yrf9W43rLaXTwoI/XjuwqnJIkIJVuxeu6cKITdcPLTUvk ajkr7/D9pCa9Q4mvBmgfUu4lsDvGhHf7TJrWzvN0Ac6KjLUcJHl3DIleDmBzC0JMNwgx Tx//cB+LiQuOwJ/BshHewpii3N0jxxr6F+YTDEw41lFYlGSj7V5mOpsFufFqj1Uf487Z w3q/TgxBISnH9kZ+qBKnDYnE2mfqw2O3Q0xUrb5JdOefFdb0ohWYBIW+SODcy44j67wR TEmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771273163; x=1771877963; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PVXohdqNVWPFTDXwbCd6oi5O4NV76l+yiiTi2RIk6l4=; b=PziUvY6CEj5c6QDS58DV6y7HVh8U+qbW5/lSpYTCDF5EPMUP1O+yZoKnl0goJzh5l1 qrAOrIjoCTkZdgLHeXWGS54JXAb3hUYHDFUm0UfXuDnpVZuklzpxHn1rBG0IdOblf9DH WxO73lfTF88hb6w04ep0YBefGJ3GM0+suSOM78rTVCjvi98URDs/1SUhRb8HsouPNKjG 0vJnbeGG8fenO7HcYjFWl9Bbz3/5MXYthCdQnyoORRYOVgvxvhBl5Ztsh/hhZFDv95Vp T3i7mrwtaM78lFUoEIOF41cTN6LPRVe1GzCwIWcQoKnIR8MDzTxlXFWpL8TrlXhnhy7i JlLw== X-Forwarded-Encrypted: i=1; AJvYcCWjtNGZM22HVBQSNWfRA/jqbTlc26LviferIyXz3yqM49du5YRU5fTUQyJsTPHBLSnmxUbhfbNymn53Jk4=@vger.kernel.org X-Gm-Message-State: AOJu0YyiMW3NgXQp//8YSzC48ntHjj7/0fcLTvVC7u8NefK5d6ZI+fou VdwHWmghj/FanD3z8ORT/Wd0rnPJOVBCAhNb8EskmcLcLAljJM37/iAy X-Gm-Gg: AZuq6aLPzkVSLMDPPd6wMFiuIoyNuWAGVzfphd1UC/czfCfiLB6MbZnQjSi6nYG+KUq hrrCsUZbr86hIBHhZXVQ0H9gMafDBQSHYly8bT1NnOalT3xH3pjIpXfnnFAjeUJLt010bZR9uOm yKrkh6vnSFQXcl5LW0KTktmyoDSxZrnB3ATb9ScDYgm1vQJgVP6m8xBtHbDkq2O7W6wDkqKzvNu Vi5TQ/AtMvmztz6BCnm9qL9KrJCCXSnQhFZj/A+HQ9+4gXw5UMhkqr/uMZuagIARGxYHSjSWheO fz92eyzp9gqKjx3sg/QafkYJiPRRt/LaV0bFfvdbzzA3Bw1xwNmVAF6DU7CrIr2jOaNezXuFLkW 4IPLKPfwQOpF+ttZKfMEGFGhK5bHYx0aDqwNmpTI6Yo4bL6bcHj741+x6z7Ij5AMipTjClawHw8 d1Hpt1hVeWcXlHx8AWIUVwa4XJb6HzVa1CI18VuZTfgBCD6XwWOYeer07dTl1p6HtrYWEWG9Cz5 xTuAEHlQ/dK6AspxzzWmtv4JaA0/3QUK3PdOPr6S6/IEKWT8JOpfKhfUAWwEA7Wnrt8/oywtfzy HQ== X-Received: by 2002:a17:907:3e04:b0:b87:daee:a6c4 with SMTP id a640c23a62f3a-b8fb44a68famr552185966b.36.1771273162828; Mon, 16 Feb 2026 12:19:22 -0800 (PST) Received: from cs-874966990260-default.europe-west4-a.c.i2f7e30109524dc12-tp.internal (170.212.12.34.bc.googleusercontent.com. [34.12.212.170]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc735e4cbsm293498466b.13.2026.02.16.12.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 12:19:22 -0800 (PST) From: Artem Lytkin To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Artem Lytkin Subject: [PATCH 2/2] staging: most: dim2: fix error handling in fsl_mx6_enable Date: Mon, 16 Feb 2026 20:19:21 +0000 Message-ID: <20260216201921.1788-3-iprintercanon@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260216201921.1788-1-iprintercanon@gmail.com> References: <20260216201921.1788-1-iprintercanon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Address several error handling issues in fsl_mx6_enable(): - Replace IS_ERR_OR_NULL() with IS_ERR() for devm_clk_get() return value checks, since devm_clk_get() never returns NULL on error. - Replace hardcoded -EFAULT returns with dev_err_probe() which both propagates the actual error code from devm_clk_get() and suppresses log messages during probe deferral. - Remove an unnecessary string indirection in the clk_prepare_enable error message. Signed-off-by: Artem Lytkin --- drivers/staging/most/dim2/dim2.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 1f07c37df..15eaf4ff8 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -923,24 +923,23 @@ static int fsl_mx6_enable(struct platform_device *pde= v) int ret; =20 dev->clk =3D devm_clk_get(&pdev->dev, "mlb"); - if (IS_ERR_OR_NULL(dev->clk)) { - dev_err(&pdev->dev, "unable to get mlb clock\n"); - return -EFAULT; - } + if (IS_ERR(dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk), + "unable to get mlb clock\n"); =20 ret =3D clk_prepare_enable(dev->clk); if (ret) { - dev_err(&pdev->dev, "%s\n", "clk_prepare_enable failed"); + dev_err(&pdev->dev, "clk_prepare_enable failed\n"); return ret; } =20 if (dev->clk_speed >=3D CLK_2048FS) { /* enable pll */ dev->clk_pll =3D devm_clk_get(&pdev->dev, "pll8_mlb"); - if (IS_ERR_OR_NULL(dev->clk_pll)) { - dev_err(&pdev->dev, "unable to get mlb pll clock\n"); + if (IS_ERR(dev->clk_pll)) { clk_disable_unprepare(dev->clk); - return -EFAULT; + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk_pll), + "unable to get mlb pll clock\n"); } =20 writel(0x888, dev->io_base + 0x38); --=20 2.43.0