From nobody Thu Mar 5 06:32:14 2026 Received: from mail-pg1-f227.google.com (mail-pg1-f227.google.com [209.85.215.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 049896A8D2 for ; Mon, 16 Feb 2026 19:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771269353; cv=none; b=AxdNC71iZWfBeOtxdgpST+JCz9d29AY1UjpfYpiP9DHB7JIXfdfUZ+OrnHH98WUC3S6OoADiBSRC9nPMmNuXMeKcor9nBEkL6W43BQTuH9rgHNIazTaS3Z/wOXxa2KG5vQM1Iu9HBW3eJoAoZXMIkRFr1YXZBYXQ61RruHcMBsY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771269353; c=relaxed/simple; bh=8x/wvBM+OG9JdM5lpNSxPpncq9AHJ/Gaw3amH4rui80=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=gicGKP5KL+ljQOMdQ3LGDZaHEcUt5AalVclBrvQOMGsjulwEdT4tkgh0c1dTo3HmTBE4w129WyY+23K2c1vHKcHxaLsWwirc1byXlb3eYoItVqmFea2pSxnjkpCk58kwON5/dJodJdxClSKZK8B32/PO2of7000aXPsc52Imha0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=UJ0Oy61D; arc=none smtp.client-ip=209.85.215.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="UJ0Oy61D" Received: by mail-pg1-f227.google.com with SMTP id 41be03b00d2f7-c6de0527ce1so2053978a12.2 for ; Mon, 16 Feb 2026 11:15:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771269351; x=1771874151; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NJl/yKqTclNT9kEkBmAeTF7lEJo3F6xT2CC7EiH5zHk=; b=ngrzo7KgAr1o3Px18oOVvYqDQcqDFXZNqoXj5xEOMtE/rddxR2XBI86cxieMC1dCqh lmsnvou3cK2rnWbhUlvr44GT4bhsxIPEJV5jpTTmEYY4YxQerLKDBecwKJ3Ka7mjnfG6 2ATGuMshaAXaAnLl/zm/kNnUIR23BtthnDTUQN4UamvIaX6GHoVw37TyiJuB/tclyEsv x+vDMkQj2akNG+lw8RHhPkY0DIaA9h8h49OkiTylXfugNxSBxqtm8lg9XeYOu+IRxOpj mXDdicbvDwjtJ+iRjh/vMcwQebX6t1CwVKO03+s+tZJL7iiI/xI9BEYUQbc8joRGjjRw QECQ== X-Forwarded-Encrypted: i=1; AJvYcCUTBV4bVcga8mk8FE0iObCanrisQGJ8NSZs+KEnLYX8KXpzpx5yESV30+URKmvSIGMXoITAyEyQjLi/A7c=@vger.kernel.org X-Gm-Message-State: AOJu0YxaIiYVokSBdEgCHay+tnJmswqYXiGyF2EFVXi1bM+QR7cgMuUw IZTCgrXWLjv9QBY3gwDrAO6y55WwmycR9WErPQxxS+T9kIbmYh46SstYHGKBOrRFv95f/v+H5Af QSVg5yZrzy+ycf7Setu8VPpFjPul55x0N8wuD8OQWKRqosTi5PEXJpzusNLuj0Y20X1o6jM6fIM o94X4q1HClkF8Xa/vuDefQbcpK/Nxh0XYMy4msXdjZHHDAR48bXQis0UFqKtkArPg2YWwpKZQs5 2rDLfafUoNEhByi X-Gm-Gg: AZuq6aKfwho5tZRDpuSXNjCX1EoWT5470or/dXp351vYnnChdy7KBJ1/vkJ60bFE+l+ 4R24wMeGPoE19Kdl7zbGpC1MDbSuyqVJK9lkff2M1wqxazCyV06EA3TqNXzGCLTGn/Acejr8OFT /POKfLAp1P3G2DoA1nrvD6zg5mYOV3BhMnZkuE620KDWJ8embCQ7+SOGmV/TBFJiJSKKcbqyg1P rJVAZiVdoGayNwKiJ0+bxYHPKzeNDbjKl35/KsB7PRAuY8UJqogzEtoA8Aaa7zchclhFJSrUf8Q Lr6des7TKgE0dqlLiLDNEc8sstAsoDENlBeU6o9e5rH+1qiWGsF1IuTZGb2w9F1+1h0sSqnjRqY eW/hSHH18LXG2yGqho6xw5u1HdbZRm0on8szsJdGxZOfjTNZdGHE9LUMts+VYgKaNh5qBe+VpsS AylGHH7sU66vBTzGuxIW3vukzmzkFG/w8dGEmX13eWqBgXBv9Qr7w5uw== X-Received: by 2002:a17:90b:5445:b0:355:35b0:8b88 with SMTP id 98e67ed59e1d1-356aad7a7d4mr9574419a91.32.1771269351270; Mon, 16 Feb 2026 11:15:51 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-25.dlp.protect.broadcom.com. [144.49.247.25]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-35662926c35sm2849211a91.0.2026.02.16.11.15.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Feb 2026 11:15:51 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dl1-f70.google.com with SMTP id a92af1059eb24-124a95b6f61so61568759c88.0 for ; Mon, 16 Feb 2026 11:15:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1771269349; x=1771874149; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NJl/yKqTclNT9kEkBmAeTF7lEJo3F6xT2CC7EiH5zHk=; b=UJ0Oy61D3UOfKoBaExzYzym7+EqIiB67Wm6FxNQA1mf9STV23cbzbgwTgVBEj0w/lw ng7Hdlrnzj0vRKWX8PfuQyJ3hBo8QjU0NrONCghoYb0dBv9CNgOs/zZVgIV6M2czTbHH D6qyInvuosJgm2+oFQkkTzrSJAQO2F1m0VZWg= X-Forwarded-Encrypted: i=1; AJvYcCWO7iRjWRtyhMLwDOdVBg1cBvdm80IIeAYNzpiNMG3QCFrf31+jAbiP/kU+FSxjHRnyxIhl8n7zyCDgMeo=@vger.kernel.org X-Received: by 2002:a05:7022:439e:b0:122:153:d161 with SMTP id a92af1059eb24-1273ae1655dmr5050536c88.17.1771269349576; Mon, 16 Feb 2026 11:15:49 -0800 (PST) X-Received: by 2002:a05:7022:439e:b0:122:153:d161 with SMTP id a92af1059eb24-1273ae1655dmr5050523c88.17.1771269348982; Mon, 16 Feb 2026 11:15:48 -0800 (PST) Received: from mail.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742cada1csm11067327c88.9.2026.02.16.11.15.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 11:15:48 -0800 (PST) From: Kamal Dasu To: adrian.hunter@intel.com, ulf.hansson@linaro.org, florian.fainelli@broadcom.com Cc: bcm-kernel-feedback-list@broadcom.com, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kamal Dasu Subject: [PATCH] mmc: sdhci-brcmstb: use correct register offset for V1 pin_sel restore Date: Mon, 16 Feb 2026 14:15:43 -0500 Message-Id: <20260216191543.2514647-1-kamal.dasu@broadcom.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" The restore path for SDIO_CFG_CORE_V1 was incorrectly using SDIO_CFG_SD_PIN_SEL (offset 0x44) instead of SDIO_CFG_V1_SD_PIN_SEL (offset 0x54), causing the wrong register to be written on resume. The save path already uses the correct V1-specific offset. This affects BCM7445 and BCM72116 platforms which use the V1 config core. Fixes: b7e614802e3f ("mmc: sdhci-brcmstb: save and restore registers during= PM") Signed-off-by: Kamal Dasu Reviewed-by: Florian Fainelli Tested-by: Florian Fainelli --- drivers/mmc/host/sdhci-brcmstb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcm= stb.c index c9442499876c..57e45951644e 100644 --- a/drivers/mmc/host/sdhci-brcmstb.c +++ b/drivers/mmc/host/sdhci-brcmstb.c @@ -116,7 +116,7 @@ static void sdhci_brcmstb_restore_regs(struct mmc_host = *mmc, enum cfg_core_ver v writel(sr->boot_main_ctl, priv->boot_regs + SDIO_BOOT_MAIN_CTL); =20 if (ver =3D=3D SDIO_CFG_CORE_V1) { - writel(sr->sd_pin_sel, cr + SDIO_CFG_SD_PIN_SEL); + writel(sr->sd_pin_sel, cr + SDIO_CFG_V1_SD_PIN_SEL); return; } =20 --=20 2.34.1