From nobody Thu Mar 5 08:15:09 2026 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B815B2E7166 for ; Mon, 16 Feb 2026 18:48:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771267697; cv=none; b=gdyF20odKryvLiGsLZMIbSNhEomQy2fCvElJmeeifBuBQke6Kx+OkJGKOODJUn6+XpAyZHwkYwkdBF4LPXbSI+YQlB+X2h5umUKRkpZy1Wotw6Cufnb9thHZeGaStJskbTX31R5XrX3xMiyXJLNGMJOOK99VmtcLU7LDucgM7/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771267697; c=relaxed/simple; bh=sG+WbVQlxuQia5HjUs8kRut/EDDZgsAt64p2h2iilk8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lmugj/AnDQzEZ6tYaxlaeYnGEZqw3QIs5W10bH1BhHTGI/xQ5ceVNw2pnMgD+WXcnS5af/vySPgTm/pqV06S7wQCn37Ql+dCG7xiCnLGIeM8ueB1zVwNFTAq5SAtwjuUUyyESjbQI+9nZ/xHqm7BGq7B9bdKdmAUfyu27STyt54= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=zetier.com; spf=pass smtp.mailfrom=zetier.com; dkim=pass (2048-bit key) header.d=zetier.com header.i=@zetier.com header.b=cD9luRQl; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=zetier.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zetier.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=zetier.com header.i=@zetier.com header.b="cD9luRQl" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-8cb5138df1aso219378785a.3 for ; Mon, 16 Feb 2026 10:48:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zetier.com; s=gm; t=1771267695; x=1771872495; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LTgueUMUNqPPeLpij1IzKLOOR2xA2a9HugYD4yHosO0=; b=cD9luRQljvKBJUlUIVd9sVrYrRdNKkfjYGyaPGPWujai2gY8dpBHrIdlhRn7pv8uxB QofI834a4iG6VbV7+Cj51IxuA4x994usZin6H1HiMBzrpCEXDe/hkdNnJ3igqQcnEFLd LqAmq3mJa0+l652qQyNxxg5k883nubE9w7OyvhuEL+bznKZTdudV6xMXhZjLw7r3ArVT mUYXjrCcX0HSPEJbrrwY9c6P5MrpzAPCos4eabdJICig5pxJxuB5c4eS6h7Mb5i+B3dQ 58WYj6wdjHEdF+6RTWXzqn7350rToeCoQlC8EmMIpHPC5cQqTEm4lFVhck8IK6/ID2nL 0FBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771267695; x=1771872495; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LTgueUMUNqPPeLpij1IzKLOOR2xA2a9HugYD4yHosO0=; b=NaYBsToNpgDt9ELGb3lh4FOEuHqP+Zzqy+kVeHj2wMtqClniLj46/C+LXifhRNu5j6 plGJyF+DGufUm0REHuI6sueqj+hrx/OXPvAyufc9VzOkUhjiqVkvBP5u2xhhktMqcVhv khdgGkiXW+2c2lHGWh9bOog15FpzHmKNOlv7Ern/a4986jXSdMco7aPl7bPOrKcxtuZB Lu2Sjcn7JZo+pD1ROpdFug5OU/bO3GEq4iLNwleVn01RKYFvrgLGKNuIIdNcsMgGNkf6 i+dBvkM2nQ/1qVn4ucoGmSUMqBLetBja/C4c0ZNe6BQeMj+2a9Tvu92EYVWmI/oQGSDR EiJQ== X-Forwarded-Encrypted: i=1; AJvYcCVaC1al6mX3YTAsUMkF72MyLBfyPOvCGslsvuEGPGCJk9HYA1fbR2v9Jla1Oe9XE/vLXcaW/MmQbFDmwb4=@vger.kernel.org X-Gm-Message-State: AOJu0YwwZAjQ6QY0EGkM/grs9yTqG3A2lIRa9SvGZdBLduird2WRlZCZ cQtwF5SH+Y1/Q1n6cYKTTvX9RpXkg3uobxa9LMd03Xs0UVkyjAXIlykYStQINQ7pvbw= X-Gm-Gg: AZuq6aKIyLBhl/h/tUNDicL8gK5jMnAWc87cr+1CNckJofcTtbcss4AC0j/9HMG2hA4 F+yxopBCxRzElSzoT6LDbh1vLoNSdZBMEjqgcmlGnaE1q4N17RdOxGS6TCoZLF1UwdanTb5xZKA QTs5Y81DWymmzjYNOgCPyme0zg7wlOMiJgCLtrb5SzkA64GnL9Rvfw8NZQ6vyj4RxLHYBbQwCud TeLjJtknMmRuRpn0SSYDQj4FV4CPFK2HFxYeX3K70SWqw6dYMCW8Oop/QhfmDlJ7GUieJipFZdE +7V/ucbqlxh6Tm3ijITaNVHVZK/nxxsAhuiae/PQT6PH0fICDFJM6Ca/yJQvvQPEisRAgLqwRAU 3lnt+DavIphTyACXvXgTn0tpAA9PzcTmJPYl5MYmefc3ZvUUkVacz8C+i9IlYjX1FRG+1soLoHI NOL5u7CvIym1W71IfYSnCw/gp4SIUtVnpUmbWGzGokLTUJxXZZXqJw5sSWtawMH8HZ/hstVjHv2 7LA X-Received: by 2002:a05:620a:40c1:b0:8cb:44d7:39ac with SMTP id af79cd13be357-8cb4c01e32bmr1070269685a.73.1771267694690; Mon, 16 Feb 2026 10:48:14 -0800 (PST) Received: from warpstation.incus (243.69.21.34.bc.googleusercontent.com. [34.21.69.243]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cb3e89dc23sm1027650185a.20.2026.02.16.10.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:48:14 -0800 (PST) From: Ethan Ferguson To: luisbg@kernel.org, salah.triki@gmail.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Ferguson Subject: [PATCH v2 2/2] befs: Add FS_IOC_SETFSLABEL ioctl Date: Mon, 16 Feb 2026 13:47:55 -0500 Message-ID: <20260216184755.48549-3-ethan.ferguson@zetier.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260216184755.48549-1-ethan.ferguson@zetier.com> References: <20260216184755.48549-1-ethan.ferguson@zetier.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add the FS_IOC_SETFSLABEL ioctl to the befs filesystem. Signed-off-by: Ethan Ferguson --- fs/befs/linuxvfs.c | 64 ++++++++++++++++++++++++++++++++++++---------- 1 file changed, 51 insertions(+), 13 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 942d247a6cae..f017ae4577cc 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs/linuxvfs.c @@ -754,6 +754,23 @@ static int befs_show_options(struct seq_file *m, struc= t dentry *root) return 0; } =20 +static befs_super_block *befs_get_disk_sb(struct super_block *sb, + struct buffer_head *bh) +{ + const off_t x86_sb_off =3D 512; + befs_super_block *ret =3D (befs_super_block *) bh->b_data; + + if ((ret->magic1 =3D=3D BEFS_SUPER_MAGIC1_LE) || + (ret->magic1 =3D=3D BEFS_SUPER_MAGIC1_BE)) { + befs_debug(sb, "Using PPC superblock location"); + } else { + befs_debug(sb, "Using x86 superblock location"); + ret =3D (befs_super_block *) ((void *) bh->b_data + x86_sb_off); + } + + return ret; +} + /* This function has the responsibiltiy of getting the * filesystem ready for unmounting. * Basically, we free everything that we allocated in @@ -762,9 +779,21 @@ static int befs_show_options(struct seq_file *m, struc= t dentry *root) static void befs_put_super(struct super_block *sb) { - kfree(BEFS_SB(sb)->mount_opts.iocharset); - BEFS_SB(sb)->mount_opts.iocharset =3D NULL; - unload_nls(BEFS_SB(sb)->nls); + struct befs_sb_info *befs_sb =3D BEFS_SB(sb); + struct buffer_head *bh =3D NULL; + befs_super_block *disk_sb; + + bh =3D sb_bread(sb, 0); + if (bh) { + disk_sb =3D befs_get_disk_sb(sb, bh); + memcpy(disk_sb->name, befs_sb->name, B_OS_NAME_LENGTH); + mark_buffer_dirty(bh); + brelse(bh); + } + + kfree(befs_sb->mount_opts.iocharset); + befs_sb->mount_opts.iocharset =3D NULL; + unload_nls(befs_sb->nls); kfree(sb->s_fs_info); sb->s_fs_info =3D NULL; } @@ -799,7 +828,6 @@ befs_fill_super(struct super_block *sb, struct fs_conte= xt *fc) struct inode *root; long ret =3D -EINVAL; const unsigned long sb_block =3D 0; - const off_t x86_sb_off =3D 512; int blocksize; struct befs_mount_options *parsed_opts =3D fc->fs_private; int silent =3D fc->sb_flags & SB_SILENT; @@ -843,15 +871,7 @@ befs_fill_super(struct super_block *sb, struct fs_cont= ext *fc) } =20 /* account for offset of super block on x86 */ - disk_sb =3D (befs_super_block *) bh->b_data; - if ((disk_sb->magic1 =3D=3D BEFS_SUPER_MAGIC1_LE) || - (disk_sb->magic1 =3D=3D BEFS_SUPER_MAGIC1_BE)) { - befs_debug(sb, "Using PPC superblock location"); - } else { - befs_debug(sb, "Using x86 superblock location"); - disk_sb =3D - (befs_super_block *) ((void *) bh->b_data + x86_sb_off); - } + disk_sb =3D befs_get_disk_sb(sb, bh); =20 if ((befs_load_sb(sb, disk_sb) !=3D BEFS_OK) || (befs_check_sb(sb) !=3D BEFS_OK)) @@ -964,6 +984,22 @@ static int befs_ioctl_get_volume_label(struct super_bl= ock *sb, char __user *arg) return 0; } =20 +static int befs_ioctl_set_volume_label(struct super_block *sb, char __user= *arg) +{ + struct befs_sb_info *sbi =3D BEFS_SB(sb); + + if (!capable(CAP_SYS_ADMIN)) + return -EPERM; + + if (sb_rdonly(sb)) + return -EROFS; + + if (copy_from_user(sbi->name, arg, B_OS_NAME_LENGTH)) + return -EFAULT; + + return 0; +} + static long befs_generic_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) { @@ -973,6 +1009,8 @@ static long befs_generic_ioctl(struct file *filp, unsi= gned int cmd, switch (cmd) { case FS_IOC_GETFSLABEL: return befs_ioctl_get_volume_label(inode->i_sb, user); + case FS_IOC_SETFSLABEL: + return befs_ioctl_set_volume_label(inode->i_sb, user); default: return -ENOTTY; } --=20 2.43.0