From nobody Thu Mar 5 06:31:07 2026 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D48A2BEC4E for ; Mon, 16 Feb 2026 18:11:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265486; cv=none; b=ejf3xAmxihISxE/cVkjIGGxf/A86IzbjAAr5SjE8Oy0S1DRcnVshfDAQrhoZgssHWNsHHt3Qjn1cxGViloK9zN9kQXmCMSBR1HdAO2GdKfVf/8bd8XcD0Hwir4CrK5yVOzYJg7y5bqwLzxpDPxaxTzpLiRkn7YGp/vSKNcSPw3k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265486; c=relaxed/simple; bh=9gHrAWMXeIwAu7HR6q7xW82kIG86uNEriVYuVqaTKOI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R3+E1uUWVj0YW83A53Oz5nsM4FGPEPLPr2r39FUHj1Tc0eDi7QdqYLiNeBOdRi2L/DNopbaC4HCNpXGQWVtV1gFoCvSuUgbDDlPLieXL/8z+yIuDa+3N4uf1ohx9VbX63VLfd05fd5XMis3pSK5JxceAEQXoo0JO3BTNW4MiBnc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=jMX4XfoI; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jMX4XfoI" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-1273349c56bso4335071c88.0 for ; Mon, 16 Feb 2026 10:11:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265484; x=1771870284; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HozxlB7OIQjXsWbfNoWQpOfXTqwiFdT3084VZX2m49U=; b=jMX4XfoIEf1JoMKJT5R+vggqGTvbG35xMtm5QdqoldfV8FIx/D1NrE4B2aSpCrTRfm lkXTb3d5sml6IRX3zVL/VyvGcJ2TyIHHMb52hO6o1JE7RyLtIEBCwNaNz5DwfS3qkPo9 jK4qdRWlstkNM8vAIpc+mVU8fDmZXJ4a0KEYs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265484; x=1771870284; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HozxlB7OIQjXsWbfNoWQpOfXTqwiFdT3084VZX2m49U=; b=kz5dVcqBoSubf4t9rSTs+HWv1X2LzPXnqh+iAM57yqDYwLfyhJ9/jkBE8B7LCbAjOj d9m1iN+wQV19EZQrLcQTd8YeTD287g1ZHpdAmbmpLZlV0t8B4aTvZiRkY9g2lZgNfwrk KP9jy9wuWPoT5TDRTTnFqGOv+r4WeqOTVL5zNHNyf0RvOOtI5F0SNi4o4DsKeJ7N4A23 puM8FcqvWTdJi3YpJS+MVL4d6tNgooJOSemVQ5bE3S4P9zrdwDS2OIfYqHE/hDFr6rr8 WggdTC2/2cQLtd0sd9sv4/0gsla/M/bupC9Yh18MC7TsSdjTWdXe95GQeu1KZnF4a5Ux fTJA== X-Forwarded-Encrypted: i=1; AJvYcCXUFy/B7M35OPfr4/nhR61IPr6IbVNzNOSkLGmf+jt0bd1wJw/dNlXr996vdgSAJwkwCSxwXAAceCThbbg=@vger.kernel.org X-Gm-Message-State: AOJu0YxdCWVvReIxYYWzeHnHOS/oJxPIkbVF/7ZxUTOpMJBAl76u2IBi 7z+g2zxHeWdDuUVuTiqp+GBz1bPbSnXBhrP0uxcUPXDjlYXLpEfn/TU3Xfeq3z7dJA== X-Gm-Gg: AZuq6aJrwKsCELo2NxGLOBibCw/0Au1tzGUnkppzlLFA2U4zEKJhxKmf2+ONVw3HzOa BtUP+omEj82DtS/iu6m9PbvFdy2255kqXGstrj41fVw8gFBjxPGjNGcoY29QJxww5D8RL4Pv7cI xdMW5kajuWmjFjVnOD8qCcJ9K/xXqUEVLOCK6CCxB3C83vmvf6hHwyulV+9u7wgFc0kXdBaTE3J wVphIKOzHAcIVADeRQM4AmvgMLtQ+FPHcC7GQYedfICgbid7W4m7+SzDKRHhnV8pkQzI+D2LH5X Qk1/MnoxePzL9PeTi/P9VbrCLmYcjW2dnwLFfqSzICF4TvwexEL/VcMuIuMqQsAWuX/1JG8MIzS KjW8ki+D/VSw0bEAosweXU9Weir9Hez/7PGVrOfmsYD6p8NGeSXAIAnkAxnxm4y/4f2NYW7ImC6 P1Kxm5AFs8XORnJJTNa2793mnViiIRpfByhh0iHl4enX+pgjauqUJbJdo60V4EU8WhbAseAnQ/7 3zfsnWvX6w= X-Received: by 2002:a05:7022:aa1:b0:119:e569:f611 with SMTP id a92af1059eb24-12741b5e377mr3311557c88.10.1771265483574; Mon, 16 Feb 2026 10:11:23 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:22 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , Bjorn Andersson , Frank.Li@nxp.com, arm-scmi@vger.kernel.org, cristian.marussi@arm.com, festevam@gmail.com, imx@lists.linux.dev, jay.buddhabhatti@amd.com, jonathanh@nvidia.com, kernel@pengutronix.de, konradybcio@kernel.org, krzk@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-tegra@vger.kernel.org, lucaswei@google.com, mathieu.poirier@linaro.org, michal.simek@amd.com, nm@ti.com, rafael@kernel.org, robh@kernel.org, s.hauer@pengutronix.de, shawn.guo@linaro.org, ssantosh@kernel.org, sudeep.holla@kernel.org, tglx@kernel.org, thierry.reding@gmail.com Subject: [PATCH v3 01/15] mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell() Date: Mon, 16 Feb 2026 10:09:38 -0800 Message-ID: <20260216100943.v3.1.I600d04c0553f5c5ba39c2f92201da313aedfe746@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The way the mailbox core behaves when you pass a NULL `mssg` parameter to mbox_send_message() is a little questionable. Specifically, the mailbox core stores the currently active message directly in its `active_req` field. In at least two places it decides that if this field is `NULL` then there is no active request. That means if `mssg` is ever NULL it will cause the mailbox core to think is no active request. The two places where it does this are: 1. When a client calls mbox_send_message(), if `active_req` is NULL then it will call the mailbox controller to send the new message even if the mailbox controller hasn't yet called mbox_chan_txdone() on the previous (NULL) message. 2. The mailbox core will never call the client's `tx_done()` callback with a NULL message because `tx_tick()` returns early whenever the message is NULL. Though the above doesn't look like it was a conscious design choice, it does have the benefit of providing a simple way to assert an edge-triggered interrupt to the remote processor on the other side of the mailbox. Specifically: 1. Like a normal edge-triggered interrupt, if multiple edges arrive before the interrupt is Acked they are coalesced. 2. Like a normal edge-triggered interrupt, as long as the receiver (the remote processor in this case) "Ack"s the interrupt _before_ checking for work and the sender (the mailbox client in this case) posts the interrupt _after_ adding new work then we can always be certain that new work will be noticed. This assumes that the mailbox client and remote processor have some out-of-band way to communicate work and the mailbox is just being used as an interrupt. Doing a `git grep -A1 mbox_send_message | grep NULL` shows 14 hits in mainline today, but it's not 100% clear if all of those users are relying on the benefits/quirks of the existing behavior. Since the current NULL `mssg` behavior is a bit questionable but has some benefits, let's: 1. Deprecate the NULL behavior and print a warning. 2. Add a new mbox_ring_doorbell() function that is very similar to the existing NULL `mssg` case but a tad bit cleaner. The design of the new mbox_ring_doorbell() will be to maximize compatibility with the old NULL `mssg` behavior. Specifically: * We'll still pass NULL to the mailbox controller to indicate a doorbell. * Doorbells will not be queued and won't have txdone. * We'll call immediately into the mailbox controller when a doorbell is posted. With the above, any mailbox clients that don't mix doorbells and normal messages are intended to see no change in behavior when switching to the new API. Using the new API, which officiall documents that mbox_client_txdone() shouldn't be called for doorbells, does allow us to remove those calls. There are two differences in behavior between the old sending a NULL message and the new mbox_ring_doorbell(): 1. If the mailbox controller returned an error when trying to send a NULL message, the old NULL message could have ended up being queued up in the core's FIFO. Now we will just return the error. 2. If a client rings a doorbell while a non-doorbell message is in progress, previously NULL messages would have been "queued" in that case and now doorbells will be immediately posted. I'm hoping that nobody was relying on either of the two differences. In general holding NULL messages in the mailbox core's queue has odd behavior and is hard to reason about. Hopefully it's reasonable to assume nobody was doing this. As mentioned above, it should be noted that it's now documented that "txdone" shouldn't be called (by both mailbox drivers and clients) for doorbells. That being said, in most cases it won't hurt since the mailbox core will ignore the bogus "txdone". The only case where it's critical for a mailbox controller not to call "txdone" for a doorbell is when a mailbox channel mixes normal messages and doorbells and cares about the txdone callback. Specifically, when you ring a doorbell and immediately send a normal message, if the controller calls "txdone" for the doorbell it could look as if the normal message finished before it should have. This issue also would have happened with the old NULL `mssg`, though. Reviewed-by: Bjorn Andersson Signed-off-by: Douglas Anderson --- Changes in v3: - Suggest mbox_ring_doorbell in the warning message Changes in v2: - Instead of just documenting NULL, introduce a new function drivers/mailbox/mailbox.c | 82 +++++++++++++++++++++++++++++- include/linux/mailbox_client.h | 1 + include/linux/mailbox_controller.h | 4 +- 3 files changed, 85 insertions(+), 2 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 617ba505691d..fe3f2f75e734 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -161,6 +161,9 @@ EXPORT_SYMBOL_GPL(mbox_chan_received_data); * The controller that has IRQ for TX ACK calls this atomic API * to tick the TX state machine. It works only if txdone_irq * is set by the controller. + * + * Should not be called for "doorbell" messages (any time the message + * sent was NULL). */ void mbox_chan_txdone(struct mbox_chan *chan, int r) { @@ -182,6 +185,9 @@ EXPORT_SYMBOL_GPL(mbox_chan_txdone); * The client/protocol had received some 'ACK' packet and it notifies * the API that the last packet was sent successfully. This only works * if the controller can't sense TX-Done. + * + * Should not be called for "doorbell" messages (any time the message + * sent was NULL). */ void mbox_client_txdone(struct mbox_chan *chan, int r) { @@ -222,7 +228,7 @@ EXPORT_SYMBOL_GPL(mbox_client_peek_data); * mbox_send_message - For client to submit a message to be * sent to the remote. * @chan: Mailbox channel assigned to this client. - * @mssg: Client specific message typecasted. + * @mssg: Client specific message typecasted. Should not be NULL. * * For client to submit data to the controller destined for a remote * processor. If the client had set 'tx_block', the call will return @@ -249,6 +255,28 @@ int mbox_send_message(struct mbox_chan *chan, void *ms= sg) if (!chan || !chan->cl) return -EINVAL; =20 + /* + * The mailbox core gets confused when mbox_send_message() is called + * with NULL messages since the code directly stores messages in + * `active_req` and assumes that a NULL `active_req` means no request + * is active. This causes the core to call the mailbox controller a + * second time even if the previous message hasn't finished and also + * means the client's tx_done() callback will never be called. However, + * clients historically passed NULL anyway. Deprecate passing NULL + * here by adding a warning. + * + * Clients who don't have a message should switch to using + * mbox_ring_doorbell(), which explicitly documents the immediate + * sending of doorbells, the lack of txdone, and what happens if you + * mix doorbells and normal messages. + * + * TODO: when it's certain that all clients have transitioned, consider + * changing this to return -EINVAL. + */ + if (!mssg) + dev_warn_once(chan->mbox->dev, + "NULL mbox messages are deprecated; use mbox_ring_doorbell\n"); + t =3D add_to_rbuf(chan, mssg); if (t < 0) { dev_err(chan->mbox->dev, "Try increasing MBOX_TX_QUEUE_LEN\n"); @@ -277,6 +305,58 @@ int mbox_send_message(struct mbox_chan *chan, void *ms= sg) } EXPORT_SYMBOL_GPL(mbox_send_message); =20 +/** + * mbox_ring_doorbell - Client function to ring the doorbell with no messa= ge. + * @chan: Mailbox channel assigned to this client. + * + * Send a notification to the remote side of the mailbox but don't actually + * send any data. This is typically used when the client and the remote si= de + * of the mailbox have some other (non-mailbox) way to communicate and the + * mailbox is simply used as an "interrupt" to notify the remote side. + * + * This function has a few important differences from mbox_send_message(): + * - There is no concept of "txdone" for mbox_ring_doorbell(), even if the + * controller itself would be able to tell when the remote CPU saw or Ac= ked + * the doorbell. + * - Because there is no concept of "txdone", there is no need to wait for + * previous doorbells to "finish" before notifying the controller of ano= ther + * doorbell. + * - Because we never wait to notify a controller of a doorbell, there is = no + * queue for doorbells. + * + * The above properties mean that calling mbox_ring_doorbell() is the equi= valent + * of re-asserting an edge triggered interrupt to the remote side. If the = remote + * side hasn't yet "cleared" the interrupt this is a no-op. If the remote = side + * has cleared the interrupt, it will be re-asserted. Expected usage: + * + * This CPU: + * - Update out-of-band (OOB) memory shared between this CPU and remote CP= U. + * - Ring doorbell. + * Remote CPU: + * - Clear doorbell. + * - Read OOB shared memory and act on it. + * + * The remote CPU will always be guaranteed to notice changes, even if thi= s CPU + * updates / rings multiple times before the remote CPU has a chance to ru= n. + * + * Mixing calls of mbox_ring_doorbell() and mbox_send_message() on the same + * mailbox channel is allowed, assuming the mailbox controller correctly a= voids + * calling mbox_chan_txdone() for doorbells. + * + * NOTE: For compatibility reasons, doorbells are sent to the mailbox + * controller driver by passing NULL to the mailbox controller's + * send_data() callback. + * + * Return: Negative error code upon failure. + */ +int mbox_ring_doorbell(struct mbox_chan *chan) +{ + guard(spinlock_irqsave)(&chan->lock); + + return chan->mbox->ops->send_data(chan, NULL); +} +EXPORT_SYMBOL_GPL(mbox_ring_doorbell); + /** * mbox_flush - flush a mailbox channel * @chan: mailbox channel to flush diff --git a/include/linux/mailbox_client.h b/include/linux/mailbox_client.h index c6eea9afb943..e3fc11e42c58 100644 --- a/include/linux/mailbox_client.h +++ b/include/linux/mailbox_client.h @@ -42,6 +42,7 @@ struct mbox_chan *mbox_request_channel_byname(struct mbox= _client *cl, const char *name); struct mbox_chan *mbox_request_channel(struct mbox_client *cl, int index); int mbox_send_message(struct mbox_chan *chan, void *mssg); +int mbox_ring_doorbell(struct mbox_chan *chan); int mbox_flush(struct mbox_chan *chan, unsigned long timeout); void mbox_client_txdone(struct mbox_chan *chan, int r); /* atomic */ bool mbox_client_peek_data(struct mbox_chan *chan); /* atomic */ diff --git a/include/linux/mailbox_controller.h b/include/linux/mailbox_con= troller.h index 80a427c7ca29..36648fa7b6f3 100644 --- a/include/linux/mailbox_controller.h +++ b/include/linux/mailbox_controller.h @@ -19,7 +19,9 @@ struct mbox_chan; * if the remote hasn't yet read the last data sent. Actual * transmission of data is reported by the controller via * mbox_chan_txdone (if it has some TX ACK irq). It must not - * sleep. + * sleep. Will be passed NULL data for doorbell-only messages. + * Note that doorbell messages are always sent immediately with + * no queuing. mbox_chan_txdone() shouldn't be called on doorbells. * @flush: Called when a client requests transmissions to be blocking but * the context doesn't allow sleeping. Typically the controller * will implement a busy loop waiting for the data to flush out. --=20 2.53.0.273.g2a3d683680-goog From nobody Thu Mar 5 06:31:07 2026 Received: from mail-dl1-f53.google.com (mail-dl1-f53.google.com [74.125.82.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A41C32DAFB5 for ; Mon, 16 Feb 2026 18:11:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265488; cv=none; b=XDCpI+WFwnhJ+4ZXbq51/ybwNnCnB5PSDFD9OoqW8QrO7KDLm4uWFlsqV7FhzED8/EovdUd2tV63L6wNf/OlehW1hbnVqH8gYptv22K1Oh5D3xgvNuqiZFMJ8pJkhGkNZm3H5CsCit/WUZwPAAVCBVkH81f5km3CmKgTv0OFhCI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265488; c=relaxed/simple; bh=T9138cDwn+QZwBFaC6QbDa1VBT/f3YEeuN2KjrVKfhQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Jnz/cNbaiVCNb+M/fGh1agWJhrdJmyV+ProLaQpVgnWIKH7YSS5z274gQBenSjoe8CjjBuieglh1Wk+MzWsH8+IE6cEU32SULd4w2G932l0wf98/nLzZfbeXDpFrZiQiKX3QgJGeCcYQ2cO1qpjg/aBJUUzdI7xTniYF6qC8utU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=jdjDdybT; arc=none smtp.client-ip=74.125.82.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jdjDdybT" Received: by mail-dl1-f53.google.com with SMTP id a92af1059eb24-12721cd256bso4209961c88.1 for ; Mon, 16 Feb 2026 10:11:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265486; x=1771870286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/jhin/02GFgkWCuBO/6cY6fZT+lc+CgTrHw88Ws4rz8=; b=jdjDdybTjFsZxPPaz7naIvRFI0gEe52F3eQgLyLPjcoJBYbA8ArgdiX15fH8yvco4c pi0D9Szb6bwFmPDEjRAZZ9O6TSaDmhQ9CP9ABFQaElb4+Sc0cL3Q9W8O7koxtOkyEqmU Ys7wrqvPL4LgsjqPUE/gux6tQOHZRpsI1e0p0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265486; x=1771870286; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/jhin/02GFgkWCuBO/6cY6fZT+lc+CgTrHw88Ws4rz8=; b=O6dTpXS3/yrtZJapdr98JEcADFaHv6cjd8eX8arvOccFNBvm+dWNG6aTf6DcVVb9hg nedL1I7mFhA59AgoNK8JbER1KWCXp58v9UFR7j9fwd8fgALrJiHxd246Uw9c3Xshx7o0 y5vTIlieM+bb/xeimDSInzBwSfPWj4IRGr1DQtx7ZtbPmYpjElVtnia20hPr4jCzsLwQ N/SPV1rKuv318SjzsvokoYx7w+/XJwkWy5+hmrbQp2haLoaojOIN+vT5tHpx3DK5Vrb/ oedfW1KVycjVu+bB/dXClpT8W29JxmbWzAk/FNv/oIzWKeT5SrcPJZsjMX6rXIaGVzkJ 9PZw== X-Forwarded-Encrypted: i=1; AJvYcCWW3pbPgkcb12Mxtv1LopNDIqQjM/s2Z2Gey1C1NyLuAfaHFhIZdm9NZ+j6aTS+pIzbUiIz7GNPQNvWIWY=@vger.kernel.org X-Gm-Message-State: AOJu0YxGkU6KdO+CgFBKyu3MCqSj12GEeF2zjUmP6W3XuGY/8C0oDPg2 SpMeaBh5gVJaJUi89SxbQ61he11zhEEp6fNzHWdhZ9mPxffHXtMMQKPcsjobGI/J9Q== X-Gm-Gg: AZuq6aKEIkdrPuAqPmHS3zIgr01FW518NloNuQUiuNFFaQHufRu0ylVWTNig8Rx1vYv wbI1JLNqAj706di4H3p8wpq+kKb8dn7lDdFFmEUNI9trOqAkbSZzoU/ZDmh9lGtRvdWqNw2rkej SGX1HJfzGKJcyY26ez58ZFP49jpaiKAJHfPNkWdudIGN5aSunu0pkQjV67rmLASx99BEmFduMAk i/UGu72EktEaWmHrA//DdPuhN44SNoTxSeK78PZ0xyWE/AR2mhzJWd2lHW/f9Le0WL8cU/uaQ56 X3KOLktf5LyPwJJ2Ba17tPKtylmCiP0PQaOqhwfIc7kHLC5pFpwTRKLHvqJV+k/3a8x+739iTPP C//ETZiVDHkApqLV1VJ6f9XKGrlgwyMy2jNoZHmkmfYqf7tZgq2F6/QTFbWACGe9ibZSPnY7Fxe ZaXyfRraYjxCZtOL+HKNmuM6FYEfwRgvKCVjVevEXKrqTI/Fqx1XYQZT3Rep4QhLNmCheDaxKng FCkyEKYCso= X-Received: by 2002:a05:7022:4389:b0:124:11af:7b42 with SMTP id a92af1059eb24-12741bd58e8mr4199049c88.33.1771265485799; Mon, 16 Feb 2026 10:11:25 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:24 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, rafael@kernel.org Subject: [PATCH v3 02/15] ACPI: PCC: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:39 -0800 Message-ID: <20260216100943.v3.2.Ibc0c2b7d0280f23aecade13c49dedc2bb7fdd7a2@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). From code inspection, it appears that this driver only ever sends NULL messages and thus the conversion is straightforward. The only change is to remove the call to mbox_chan_txdone(). The call wouldn't have done anything in the past anyway (since chan->active_req was NULL) but with doorbells it's officially documented to not be needed. Signed-off-by: Douglas Anderson --- Something seemed a little fishy in this code. The code seems to be a _client_ of a mailbox, yet it was calling mbox_chan_txdone() which is something mailbox _controllers_ are supposed to call when their "txdone" interrupt goes off. It appears that this client even reaches into the mailbox controller and confirms that `txdone_irq` is set, which should mean that the controller itself signals txdone. If the mailbox controller is actually signaling "txdone" it should ideally be improved to not do so for doorbell (NULL) messages, but it won't matter much for this client since we only ever send doorbells and don't care about the txdone callback. (no changes since v1) drivers/acpi/acpi_pcc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/acpi/acpi_pcc.c b/drivers/acpi/acpi_pcc.c index e3f302b9dee5..3d240ecd98f4 100644 --- a/drivers/acpi/acpi_pcc.c +++ b/drivers/acpi/acpi_pcc.c @@ -106,7 +106,7 @@ acpi_pcc_address_space_handler(u32 function, acpi_physi= cal_address addr, /* Write to Shared Memory */ memcpy_toio(data->pcc_chan->shmem, (void *)value, data->ctx.length); =20 - ret =3D mbox_send_message(data->pcc_chan->mchan, NULL); + ret =3D mbox_ring_doorbell(data->pcc_chan->mchan); if (ret < 0) return AE_ERROR; =20 @@ -123,8 +123,6 @@ acpi_pcc_address_space_handler(u32 function, acpi_physi= cal_address addr, return AE_TIME; } =20 - mbox_chan_txdone(data->pcc_chan->mchan, ret); - memcpy_fromio(value, data->pcc_chan->shmem, data->ctx.length); =20 return AE_OK; --=20 2.53.0.273.g2a3d683680-goog From nobody Thu Mar 5 06:31:07 2026 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B30C2E11C7 for ; Mon, 16 Feb 2026 18:11:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265491; cv=none; b=jcyLCsqvuaGqYxZq+zJpVf8lQ2wgN4jY43foe+sKXrEIpwqkCiWKQSe9uYIsm0hjVXgsKn6ZcG5mkQEk9SD/rKE7gMWXOxvXSZlXAV21wG/8DV9xO3IEEwoN+m2slwZgzahiTvNazApF2ovqsQm0Q99OEh+PE+tQE5jmQ02o1jI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265491; c=relaxed/simple; bh=+607S4Sa52IGLHPOE6uFJa9rkx8P/LizPZWNWoD5Hvs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z4/D27AuBFU6R/3PFHrsy+y+ZzFQ4eK8bYN89dea1yXDwUvadnqivb+xBZ4+jDZxNenBd3sdnrta0h1uGX1dA/BkZdgTriRh/IPaB1lIib5AUZwZEr5zqJ8izGUWMvRuWbsfuBpvX/w9CHdVLm+n/CYqPGGEJCIqxLpkkDmBLDY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=G8oAidob; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="G8oAidob" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-2b4520f6b32so3976082eec.0 for ; Mon, 16 Feb 2026 10:11:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265488; x=1771870288; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ESsYEinmAI9cWzRkrWAAeFjrdNwaMwa0qK/fG3RugZk=; b=G8oAidob5kSaCLTJ8RAav7I3SVoElcIUQ1nK4IU4uB0QNVMK7Y3v3hr9r/E4tfnYDi O+VccY9eegOzqIhP+BWrS0J6cwLMkepqQ/+N8Ku0/JFbml85RDiwL9xHO4/jmaVCyPVU //SGlE0FnyBWZberGGN8jt3etPWt1BiuWBtM8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265488; x=1771870288; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ESsYEinmAI9cWzRkrWAAeFjrdNwaMwa0qK/fG3RugZk=; b=jPLSN3pcZZbbADs+KAqHXNeL7jy6P310ag9iVPM1qhx13FnpnWdmsRxyAJFG0dEyA4 +PkdQpH3Ztd5cTQrNMV79k8HQf8yaUpxJuf74lfp6zKKmH0Qh5KgqHSpZYVOdzlQ9rqY CxA7BhtLVsBM91ULxfz3OVs/+pQYXm/xfSC/H8/aS8ayWCH4EmCkqpgEyRm4SwMFZhW1 EX7QaSKIo5ni6SZ9FsoXSkG+PyxeREU5LoLUWaUIPYpPks2C1TbX6mp02ll7IlH2G6AA mRDdNfyFIWrIs9Wp29Si3P36vuOuUd6J7sJIgiFDLCtMe7AgFXOV7rXZQ/AWsWjuR0IL 2ZgQ== X-Forwarded-Encrypted: i=1; AJvYcCVI5krBZR0nmK0EbSOwm7eT18NWQg0t8Rn/kRkZo++9urb4yF6EefGVrpT/NMnv16EPVEmtw5J2oAufOE4=@vger.kernel.org X-Gm-Message-State: AOJu0YzylazpRHMBNuZEuz8MeKxXDXdjuHhZpbeXQKvqjg1vf2vtcsPh HE3GsvMnrT/9vBostx8njlduJxaTqOjO0EllmK0sbbCbKjcucwVJbXNECnMN6MRgEw== X-Gm-Gg: AZuq6aJ+gPAFtC5g4D5XiR3tSVEHE0rtprhXhdZALvoStPM+cvHFFkGF7VBArPkJN7p PGuqBUU5BlDfMh07ta2AmoHqCKvOF6SUP/azAp4HvzpyuOKF6+ayWUc9QzkpQ8mDq0TDZNaZ7Ei 4OYY9j2bfoEE6eI22mfOZe3EJi3JVbM/gI9KJuoYdvFExXcHaXPjwVYJGltgAfizdMfqUCeqBqD GRbqY6qwIi2/0iZEjPY8fOi33dJNJfdL17iW++bZNHq6XTrVXsbL9NHzS3XEsCW4p/SZ0BGY6ek sKiHxFAXm4qzQJquY+nfTFz4znQnUV5usdfQzCArZz7vfvi8miI10dmoChkjarOCnSaBOdiYcpB 7ahwAHA4uzXCWXfMGsRIdPWFJgMvKLb4bp0PPAvt86loqGMPWP+IuwXJhBWT9yvDoMFGlajD0xe yUL/kew6CN11E+r4gMtR6mRF3TOwEfPLgSJe2R8qe1AyGrnqaE1cKgX+5K1qk5Jyr6sPdSThDND 8dnTzlurB0= X-Received: by 2002:a05:7301:1f12:b0:2ba:8d14:631d with SMTP id 5a478bee46e88-2babc3baca4mr2777562eec.11.1771265488333; Mon, 16 Feb 2026 10:11:28 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:26 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , Cristian Marussi , arm-scmi@vger.kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sudeep.holla@kernel.org Subject: [PATCH v3 03/15] firmware: arm_scmi: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:40 -0800 Message-ID: <20260216100943.v3.3.I4a01e1fa771c0b1ea7e35882784e4b7f8f33f65b@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). The mbox_ring_doorbell() explicitly documents not to call mbox_client_txdone() for doorbells, so remove the call. NOTE: upon first glance, this mailbox client appears to send doorbells and regular messages on the same mailbox channel (smbox->chan), so it needs some extra attention. Specifically, the new API behaves differently if you ring a doorbell while a non-doorbell message is in progress. I don't believe that this is something we have to worry about with this mailbox client, though, because the code was calling mbox_client_txdone() after sending the NULL message. Had a non-mailbox message been in progress, that would have marked the in-progress message as done instead of marking the NULL message as done. In discussion [1], it was further clarified that the driver shouldn't ever be sending doorbell and non-doorbell messages on the same channel. Link: http://lore.kernel.org/r/aYoPLzOjPvJbu0Kb@pluto [1] Tested-by: Cristian Marussi Signed-off-by: Douglas Anderson --- Changes in v3: - Updated patch description based on Cristian's response. drivers/firmware/arm_scmi/transports/mailbox.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/firmware/arm_scmi/transports/mailbox.c b/drivers/firmw= are/arm_scmi/transports/mailbox.c index ae0f67e6cc45..c4561441ac2e 100644 --- a/drivers/firmware/arm_scmi/transports/mailbox.c +++ b/drivers/firmware/arm_scmi/transports/mailbox.c @@ -324,7 +324,6 @@ static void mailbox_clear_channel(struct scmi_chan_info= *cinfo) { struct scmi_mailbox *smbox =3D cinfo->transport_info; struct mbox_chan *intr_chan; - int ret; =20 core->shmem->clear_channel(smbox->shmem); =20 @@ -338,12 +337,7 @@ static void mailbox_clear_channel(struct scmi_chan_inf= o *cinfo) else return; =20 - ret =3D mbox_send_message(intr_chan, NULL); - /* mbox_send_message returns non-negative value on success, so reset */ - if (ret > 0) - ret =3D 0; - - mbox_client_txdone(intr_chan, ret); + mbox_ring_doorbell(intr_chan); } =20 static bool --=20 2.53.0.273.g2a3d683680-goog From nobody Thu Mar 5 06:31:07 2026 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71ABC2BEC4E for ; Mon, 16 Feb 2026 18:11:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265493; cv=none; b=iYwrBQoaFkYMN3P4Ns+5hvt+iTQ8dUfrEx2i/wuiDhqhLKYrMCv3J5adqovx44/J1IlJ/Zyc17HqZA2va23PvkYCynaKYWkqEi5j0KhzsjLwZj1O5BE96g/6xQLOLxRAZiSqBioWzXOqgptSXHG9GIpRNYYPmFPAJ5FPUR8HiFY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265493; c=relaxed/simple; bh=67L1y/qLyWmX5l03+h616MLb+zlkbVeX47IpEN+bQ24=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a0EqMujenY5/onQ8CgBWcXsTWW9x4wzMH4Ds0q4Qno+msoDXmyL8yuN668lHTF95xspuq+K3aanHpwKsTl+HkYF9t8RiTvBxH3ArwAfkmXizctwOcd9mI4YJ2OhT1mf8hiB9gDAiJXMzEsSaqaGD2HLpZmc16jf2mJpmaBoCikI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=QverviNN; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QverviNN" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-124a635476fso3831254c88.0 for ; Mon, 16 Feb 2026 10:11:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265491; x=1771870291; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+a1WmFTmtt2HmepX4bGFNTbjSF3KiPQ0gf6TAdFhC+s=; b=QverviNNRI3NbiWMqNA/vwPnH3UQfmaL2bBMWbl9zZHsjmdW7BZ3IJSPV8jHpE48hE gbEovoyM5f6LKvV9IDsMtiMMULvWUdPZhCEmWgHnTXZlOmj3AhygLnFEKOZTTqXpcrvT yJB2v8q5niMWwaGy3zgGavdKdANRhe13FEGtk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265491; x=1771870291; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+a1WmFTmtt2HmepX4bGFNTbjSF3KiPQ0gf6TAdFhC+s=; b=QeZaCAUVMBUVstisnyUFnyRuSqL5aFoc47SIB4Xla9wJvNfQE/BdKDXR/PV8bEdcPS DXwCVuK8xqkt3S67rmimraKGg2ZrSDym/QT3+WnYjSsmGeWjcLH4tHRnARUey2Zt4ii7 yVCqx/tmM2KLoD6qlzwdT8pUHLbe1cbAuIyfShkLp+iGL3lDZJALpICzutRVwDL7y462 yA+otJszh6YIhfgD3CQFUFUVsMELQgH0WDQhxQ2MeKF7alQJ0GcJBhyBGALVUNmVKsa/ KwvdKW63A1+Exg2XvR9xCNfwBhlCjJI9QTK4QpUE9mkPs6WHIlqV8Y7lQmUPE19txCMT qyrg== X-Forwarded-Encrypted: i=1; AJvYcCXxwGtZ8/+oO6kJLPNofYgC4Ktve9FWBRmpqWFTe6NpFRfEIT411oFe962rNnUnkkggo9K0pdhOR5vebXw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8EyR2QJqwJptS+CmCgs2vIWUFYGPcwjoSKMbrgBS3+rLGa1Zy 2cqYcnwam988mHHhI2K1w5HImkeAQ9gg49VRpCoBZ6ADnXbXW4w38pbF7Kzq87aWnw== X-Gm-Gg: AZuq6aLDJ7vb4WKOwhMOz94dR+pGTlnuOCtVwlUOfqL5Funtirm/L1OFKUQbKg8a1hx n4oeUtofMObAL9t6t+iWALj8q3r3+4BETLQO/XzNNs1HlOmNZ76fdUk2TudP5/5JdBhqCzRN6sX +VCUuoB3r+nvckMjq/WNjnHEKbw+MN6P07Bw8ftWLwTlBDceooRXeZicy01yWmClKcjCX9d09qV JodsIw1VT5rsXR540cM1l1zCUY5JSOCcZ+FLbRKZsshod/Ojb6YuC2B/sjkGJJcAD5gPs/iQsQ5 GHKmfPtHaHuCU6RWafFDoNJP50OMM0dOzUtg+FEd0dyPhWvdKdQTjj1DHQUr0IY/GirPfFqF7Jy UDMOHkcTrv/VEzFSykvgtse2TdfMY9PH7Cq6UXQsDhLvpYWVbor+ay6OqsyoS+bm2dDVj/Dcd/4 nTPoLIrNyNzZHgrtBciLTCLtKDJ/ypSzrMJN9XmGH+3txvbRX6o59Ght8aCj+nT+FER9mZ+dYED 9U1L5e7f+o= X-Received: by 2002:a05:7022:f102:b0:11b:9386:a389 with SMTP id a92af1059eb24-1273ae68bcdmr2539975c88.44.1771265490556; Mon, 16 Feb 2026 10:11:30 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:29 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , Daniel Baluta , Frank.Li@nxp.com, Sascha Hauer , festevam@gmail.com, imx@lists.linux.dev, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 04/15] firmware: imx-dsp: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:41 -0800 Message-ID: <20260216100943.v3.4.I4a571bdd344dfe8e819cfcba37ccd0ec29284e49@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. Reviewed-by: Daniel Baluta Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/firmware/imx/imx-dsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/imx/imx-dsp.c b/drivers/firmware/imx/imx-dsp.c index ed79e823157a..231e9f841226 100644 --- a/drivers/firmware/imx/imx-dsp.c +++ b/drivers/firmware/imx/imx-dsp.c @@ -30,7 +30,7 @@ int imx_dsp_ring_doorbell(struct imx_dsp_ipc *ipc, unsign= ed int idx) return -EINVAL; =20 dsp_chan =3D &ipc->chans[idx]; - ret =3D mbox_send_message(dsp_chan->ch, NULL); + ret =3D mbox_ring_doorbell(dsp_chan->ch); if (ret < 0) return ret; =20 --=20 2.53.0.273.g2a3d683680-goog From nobody Thu Mar 5 06:31:07 2026 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E09582E1F0E for ; Mon, 16 Feb 2026 18:11:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265495; cv=none; b=GdafSR3n+AjU583wivKEMR2uEIBhoBT6w+bKffoImD3KMJg85Jzvn572gDTH0bdub0bbTGHvNy3FI7+43SX4AfyrDxDDhfyxxRxOamW7HiWWsdpbKJov9YD44zJW+nb7Krjen0+HABYPDHWMqakb89XcDNUd3o6SD7goxSWZr2Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265495; c=relaxed/simple; bh=pQ+drPsuGyEfd8K4gyjmdhI7nQ2Z+6Gl3lG1hRjSv2Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JeJh7hxfL4wkBOpYep8aTDS6eGMvTps5Duk/rdF9xNXrJPIWruiEI+d+LWnYTlWwGrS5ag4BEYfb8rCgqndcEcYro0lrGsxrGhdtKhLpuXebNIiidmg5QpbUTN7O16KqcW7hwS4968YmM9hPpEbZtVcHyzQoMAal1uVAmps+LjU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=g56neX0x; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="g56neX0x" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-1248d27f293so7781942c88.0 for ; Mon, 16 Feb 2026 10:11:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265493; x=1771870293; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S5xVuS52Zc4kvewurxT2EGZa1uCwREaSBUWVrZ6Swkk=; b=g56neX0xHVmwJ+0VCG+jsR3XBmSjnzK66MP4cKFFjs8sovggdE/HpX5yVXXEVqSC+q m1kwJhyiiCjGAhmGKWZ7Ie7J6aiFFAKkucDyhGCXyzIoosmGaKvUsTg33r4BJogZdaxw o+Wul7VSdOK+osCl7X7VNe+eBgncj5XeNw0Ss= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265493; x=1771870293; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=S5xVuS52Zc4kvewurxT2EGZa1uCwREaSBUWVrZ6Swkk=; b=Poq8yjJ4s4AuMEjj8lU4Lj2XnBsw95y5Bw6jYwZWAbdbmMv7fJi4YqMC+5fZVmBXLE 5LfvMvIIbpHfoIhHBL8ee/vy6wHgqTt2CujmoIi/VTJihaRq/jvKI+netkBdBmQfZcba DnvkDzBPe/pbaMLWeey9N5IfIY7tGdxyc5hCUQp35M5drXeFRDmY9CcY6JHCN1RxU2bI iZrGUIwZpZ38g6gFrU7edxF+9cH7EYtWJZm5JXAEBRKVuHCqt9NOKMEN8/jaQvdeO4AZ YJf5WFY+3sx+aFc63gPQA0jlyuxv2Mr8RXC8w8bGu9rLSNND7+TVuo2JBpH6EZz0SiJK NzyQ== X-Forwarded-Encrypted: i=1; AJvYcCWpsLVw6Uh+wn+FerRyKMHPYVJRhGVbfGQmqlMD4IqS861e343/E1x63gIRqqF0EmZeDOzHuk4rof++ge0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxrecm3YKpYuGTuHM59n0EBhlONudN6jscwHYk6iAGxweenPuyf /gtiesnrOzbQikS3S49uGtZoRHippqZVoBUh7MLKGBRQCpFFcuuikiwbACuL7U+1DQ== X-Gm-Gg: AZuq6aIiy9cEvN59+a1g87yrEEeLWg1FJ6Lg0arYWbRNYr38Svl1aPcYr64uKAU92+S +1WfXfMsvTdkHcULdGamAvKGwUYbkWI7ZQ3xtaYGl5gJiL+FPtgzW8WU6+Le7onQz1yHQjHjiW0 iR+A5dGLlhTJoAIM/Aj/9oHMcGp75elanGlz5c8+8ZGflxGe/S//HWOlA8eApLaOYZo4rEgPten tZJbEka7xbgx49d+dM+mKBzsW3triRhGvbhxJB8KlYjOK5P1PIScqDp5GpUytja3GnF9YaNpCle c9vLbrd/A19SAcm0vG0PY5l9OZSQ7B+kgEQRXNWvLRjNiTocQ4q8CfJL9KorufhMA9/dqaeasXW 9M4oBJCUQMFVLwpHdRfvqRieUxQ9At37xNJQB7mS6dUooQVEjbbnSJOnsabEsOHKksBwvKzXRcc Nnm0BGUCLw74P8UcZ3DT+fTM/MrnKN3QFJcaI2Rr0ih2RU7SACQI3ZR18LAju1W0IqPxhtctOsR txWuzT6j7s= X-Received: by 2002:a05:7022:6a4:b0:11e:353:57af with SMTP id a92af1059eb24-1273aed430fmr4704181c88.49.1771265493018; Mon, 16 Feb 2026 10:11:33 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:31 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , jonathanh@nvidia.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, robh@kernel.org, thierry.reding@gmail.com Subject: [PATCH v3 05/15] firmware: tegra: bpmp: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:42 -0800 Message-ID: <20260216100943.v3.5.If1255977439f4cdbb3193f73f90a784566254f15@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/firmware/tegra/bpmp-tegra186.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/firmware/tegra/bpmp-tegra186.c b/drivers/firmware/tegr= a/bpmp-tegra186.c index 64863db7a715..c45ea66aabfb 100644 --- a/drivers/firmware/tegra/bpmp-tegra186.c +++ b/drivers/firmware/tegra/bpmp-tegra186.c @@ -84,12 +84,10 @@ static int tegra186_bpmp_ring_doorbell(struct tegra_bpm= p *bpmp) struct tegra186_bpmp *priv =3D bpmp->priv; int err; =20 - err =3D mbox_send_message(priv->mbox.channel, NULL); + err =3D mbox_ring_doorbell(priv->mbox.channel); if (err < 0) return err; =20 - mbox_client_txdone(priv->mbox.channel, 0); - return 0; } =20 --=20 2.53.0.273.g2a3d683680-goog From nobody Thu Mar 5 06:31:07 2026 Received: from mail-dl1-f50.google.com (mail-dl1-f50.google.com [74.125.82.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D59B02E040E for ; Mon, 16 Feb 2026 18:11:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265497; cv=none; b=cMMYnEOHLEb0uXR3pV6Iuo1KW8Fkw2jJdM9ahHsk4kwU3IR9sNVepP3lQmyQgmH1xjfMKVtWeJatToo0xQdcbYlrRqVwUsh7KbQYj9m/yEFM3heTiwchCx3p5ZUhLsdT58POKALqRCtlj1VZw6ZsHw4YxfyXt/RNmCUCbqMi72g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265497; c=relaxed/simple; bh=mO/7s6lZDjywmGNUqkh9MjTn1N/85GdzvHKljDFqEr0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SyTEKhCZT8ryK4wI0AI10hlXr9eU8WJEiDgqQ0nn+hKnv6fLKzkIWNMpR8DbNHTQcxx/6LQEOrOTLzq3aJs+HQxRIGYvGpDHzIVGb6nzM/ZkrbfRTWOcha9zofiovLt92UK6dWw9ngP0189rs3M4CSjPMtt91MXtvq6Tmocl4bI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=i1nm0Klx; arc=none smtp.client-ip=74.125.82.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="i1nm0Klx" Received: by mail-dl1-f50.google.com with SMTP id a92af1059eb24-1274204434bso1398797c88.1 for ; Mon, 16 Feb 2026 10:11:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265495; x=1771870295; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5+5LUWDdIuonfgbs2LiKP31azCV/K9MJYYJdsQsL/KY=; b=i1nm0KlximF4JXAAtlTsGBSxoRSuJCLfvX+eZRV9sohbxQv7/K3iQUoaVpWzz2T5oW fKxh2QnKgXsmEHMP47fs+7ZbDe6Xj9Mk6hq4HVGqhpP6Lh/X3+eNHxwvGDukFqbDKMKW QR+15JRfLKUyHOpSFwuwKfsy4ffd30cnWYBeQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265495; x=1771870295; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5+5LUWDdIuonfgbs2LiKP31azCV/K9MJYYJdsQsL/KY=; b=ilOkxb+/jBLZa/uViTHsNKZHYknk8Iq6s24z9RkzPsBKqrOz7reCjkrCm+dy5L/M5L q/S+l7UBT7QeWWGhguoB5IXWDdk1iR6xOD19I6zTo+4BHMnaOezVHmy/FGraDahLTL3J MUe3rWKd1ZwKuYgvixqmhpRMfhyqMUu0L1/hSKhn/ZWQA7LJrd3IOr50dkzZsBgjpc2L 7Iym57/uXJOyug5tOAkvWzRPKeYJ+zaFtARh7PDcCeN13tszACo+pWV/gLD7yuClfwOH gVLmLcJjSxTJPbHk//GLl+IJlz8in7m2gQBQKNmRYP4c030jL0T+ZoQ8EtoXA6Vsyc7c q2pQ== X-Forwarded-Encrypted: i=1; AJvYcCXcVnNWdF59GnL4dOJi+wE6LDFZ0yrRBNByxvP+WEWhOrAV5wFyXL2cvV40pT+QyhKZZGxZelbMLJJ6/GY=@vger.kernel.org X-Gm-Message-State: AOJu0YxLDMyoPYQytYCXWdFXqvo9UyKlAbIlgIdBkTRUqiEt4qmF6gjK 2ht4hh6GJUpGW6VuBmfWpYvPUn1Orbau3IZoOHB1JgpBFZk7kLlalnP8fcESYSxUBA== X-Gm-Gg: AZuq6aLAP4KTf1S5er2zHPTMxnc5N9uGUB5HI/Na9E58If1OgI0ZwqLAqTCGzOQ1/ij TFIpDNbCFLb4z9wUzuHmT6DwYSedFwOmrP9lp9wcRHBvImskL5AJeG1t4qB2aOXVpTuOF2wxi5a uGiZQYQDApM4NWHA4b1xXDA1PAL0oj4Iou1nedFR6pc911eKkd1LX8Hum2ndO6Sj8cZR53RPKv0 ySVqg6PqIg7P2c1P3k4QsQlqHv7zhJI5hyGqyib8tm38N9Z7Ir/yXv8UyFzHJp9SRD1zJXDb4W+ nn+gwLfBPObgqQsskD/aIO/KV2DLeDMvv+bTpADdIDEEJmYh0puS/XU7/iB5JAf7qAK+NLobtQi oHFAFBWJf60oUZuc+ulA9eHA4PRbjyZMizTICk5Atn+Z+R1ghnsfw8jT5HZxzSIvtGMcv6eVlUa xZ55LQILKaqWKYbvVl/9lHg9mhhl7Lo1WjktKnZS8L54JX5HAxQ9ztBt4kNhkxHGUoVixp6SRXb Lpfq5E2TuYrZ25XEfALaQ== X-Received: by 2002:a05:7022:439a:b0:11f:1e5b:2dd6 with SMTP id a92af1059eb24-12741026896mr3749811c88.17.1771265494976; Mon, 16 Feb 2026 10:11:34 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:33 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , linux-kernel@vger.kernel.org, tglx@kernel.org Subject: [PATCH v3 06/15] irqchip/qcom-mpm: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:43 -0800 Message-ID: <20260216100943.v3.6.I59d887fd641f70e40950b7545ed31f193cd1c270@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. This client didn't previously call mbox_client_txdone() and it appears that the mailboxes it hooks up with (qcom-apcs-ipc-mailbox.c or qcom-ipcc.c) have both `txdone_irq` and `txdone_poll` as false. Presumably this means the client was relying the mailbox core's quirky behavior when sending NULL messages. Signed-off-by: Douglas Anderson Acked-by: Thomas Gleixner --- (no changes since v1) drivers/irqchip/irq-qcom-mpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-qcom-mpm.c b/drivers/irqchip/irq-qcom-mpm.c index 83f31ea657b7..5b79d95bf1fb 100644 --- a/drivers/irqchip/irq-qcom-mpm.c +++ b/drivers/irqchip/irq-qcom-mpm.c @@ -302,7 +302,7 @@ static int mpm_pd_power_off(struct generic_pm_domain *g= enpd) qcom_mpm_write(priv, MPM_REG_STATUS, i, 0); =20 /* Notify RPM to write vMPM into HW */ - ret =3D mbox_send_message(priv->mbox_chan, NULL); + ret =3D mbox_ring_doorbell(priv->mbox_chan); if (ret < 0) return ret; =20 --=20 2.53.0.273.g2a3d683680-goog From nobody Thu Mar 5 06:31:07 2026 Received: from mail-dl1-f53.google.com (mail-dl1-f53.google.com [74.125.82.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FC4C2405EC for ; Mon, 16 Feb 2026 18:11:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265499; cv=none; b=LC2atLIYpvC0MuK3VztibVk9PuKgpesmxXHsD+Tqur8ZMpXPBlbRC3WOhZvR5Nj7BJl7fnekLTQEYN4nIBvVBp/vJ3NT4mHbteR6pvGh+qKxhUtn6J168o/l23FX6T1In7x16lDTI3F5B3wdIDzJJclwTKe1TR4mJI6C27ShCSA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265499; c=relaxed/simple; bh=qHw6/cUBET4o0ltmrD98jP1CI2iuzHCbQEtnw3D5i+k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LQUJuzYysaeY6SbsS3Fkqq0q73xFzcpcBjpSfF7RZODLhdHlezHYLD/GcUzGLGuW29LXX6qn0xxin3rtyFHi03XckapKqHPG/ClvFR0hm3MGt64JJI4Bs1RdYiGqOH/POUwZDKSN7K7KEcIu1TWhyVvJbKzWo/HEwV0fi1n2aWs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Hu2enBbp; arc=none smtp.client-ip=74.125.82.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Hu2enBbp" Received: by mail-dl1-f53.google.com with SMTP id a92af1059eb24-1270adc5121so4506844c88.0 for ; Mon, 16 Feb 2026 10:11:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265498; x=1771870298; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Db07UTz9RXOWj1h4w1Ee5LGFVrVZHwXTeMkkamvRfPQ=; b=Hu2enBbpqvuxutTyJ7UPT6fhbONKI+O7DMUa/O35YMzGicxfZkT66b7mudtgJeb/K0 F+KGY4fzdWC31NwqMa5a9XWsMnR9l7kiVXp2XYvrN7pLKIwypixTfmMK2uRDJDL5QerU ZcIlxT1RH5Az2TQA++Hr6F5A6wT0R8dT7IMS0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265498; x=1771870298; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Db07UTz9RXOWj1h4w1Ee5LGFVrVZHwXTeMkkamvRfPQ=; b=B79y0YbcM+oFqrzdzPmV0Tbmw5cd2I0TNh6FH7LBnrQ7rCBCCPwuss9h2I73FOiXE1 /o4uth2kYywGm9/QDswHbKwh/RQNJ2zgSIUPhSxBNIFj0ulqH8UmkZjWeVq1YK10fT8a 1NQj6vj3lGwY942FVDkkLJhx6pEV6OKUdTGNCwdKz91XAhfjcjdfwO2tDoUp1Fb5XVfJ KUsvyKdGzzGPpMcNkt4mwjMkQuFJjwqR4YsOEwkpW0QeKALBjiLMYvmLhOnWeu8hrFnh rJVf0WJX/ZwLrBHyuwO2mLaMD7OW3GenkEteqv4acgQCICz1LtozFG7TmWs6LYyZMcLA EosA== X-Forwarded-Encrypted: i=1; AJvYcCXi8BN3emJmlnu73BnN1lcCoxWcjfWMHBOREkl5JQfwrgd8+9u/5hKMRwkZgxMF+XDRfJR0zr3TPdxJVX8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxz7ry24spOzlMi+9sQjIMMt0D96o/j0D/JUjK+j5aC2z/RZlZ4 rG+DOIqgxaI0fBvn2AJeFETifvITlw+hnZtKLgA0Ftdfqc28yEImEPdIznvDNbsgNA== X-Gm-Gg: AZuq6aJCjvvdpfnthwshm2EM2w+/KDL6RDFG2wrmxCKVO3fwFPoO4FKMKfKB0JS8Kfq F+w9lq3dkXu7gOmPYfymYcLmRwwGPnXJP9ZXDBgA+qSXRD1l0wmlS6DzKjWMjK91Fm1UO8ys2C5 MqloincyaDnDC+rlBHTGPu1sGE+m5iTKFGgCqNc1dKnYJMK0gAuoeuQ+uzZCi3RLMBGiS7KrVCH 28Mqz0oaUV4Pu2+mQKi6OSoP2/irzngUrLdFbPBL7dpvvrF7zPHNsquBRxAo3p+DyU5hiTsvN/m nTdu7zuM0xAVkt9txzm2rJwJgVk3GzwqoJKAJggejRXXUdCABRVK/ibHZ2G+LiyAlqky2c1Lwlr XdG5XENCXnSw++VVvfJiadGbsE+ThRL/9/yVKLvzMXowmwB0xyYbYfjL/KnH8KZJfu5US1zYFBH 2s+a84BtLjJcAEfwHerS59VjvZCk0PNoOyCYCdNFyxgRknCn6pnIVeVOpLDuKNAt860Ljqjv+LD TbSJXQh25g= X-Received: by 2002:a05:7022:2486:b0:11b:2138:4758 with SMTP id a92af1059eb24-1273ae182fdmr4743681c88.21.1771265497580; Mon, 16 Feb 2026 10:11:37 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:35 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , Bjorn Andersson , linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH v3 07/15] remoteproc: xlnx: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:44 -0800 Message-ID: <20260216100943.v3.7.I90e87b8f7d6ddccfa0372bb96d196d2d9d7685db@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL message on the rx channel, so the transition is straightforward. Acked-by: Bjorn Andersson Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/remoteproc/xlnx_r5_remoteproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.c b/drivers/remoteproc/x= lnx_r5_remoteproc.c index bd619a6c42aa..2acdc536d6b6 100644 --- a/drivers/remoteproc/xlnx_r5_remoteproc.c +++ b/drivers/remoteproc/xlnx_r5_remoteproc.c @@ -245,7 +245,7 @@ static void zynqmp_r5_mb_rx_cb(struct mbox_client *cl, = void *msg) memcpy(buf_msg->data, ipi_msg->data, len); =20 /* received and processed interrupt ack */ - if (mbox_send_message(ipi->rx_chan, NULL) < 0) + if (mbox_ring_doorbell(ipi->rx_chan) < 0) dev_err(cl->dev, "ack failed to mbox rx_chan\n"); =20 schedule_work(&ipi->mbox_work); --=20 2.53.0.273.g2a3d683680-goog From nobody Thu Mar 5 06:31:07 2026 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5133F29B204 for ; Mon, 16 Feb 2026 18:11:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265502; cv=none; b=ukYoQGMcyTkFP4DKBU0hstMBe9pCM+TMo7mVzFhxdgfMIaD3V7WjsJEL4MZBjODy1R/Lnp5avWl/bOVkuHNQNVeIFk0Lpvde0PObrU9iA3030kaMol+rj/osYoFduCRmOFMM6H6U/GVRqaP+Eo5nSZCc3fFG4TuoRvCZVmpVO5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265502; c=relaxed/simple; bh=fNEzY1/433eDdGyIXd3gTHHwaVm5VhatRxpUEgl5vp0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JVN6mJYX4/u76IHSQlCvHCDuX3SAVqtetbOigvmi1bF3N+rDKadkKWeWq6WUHGHGyN6q2ZbLFH5SmjKjBUdUjEdO5ViYdWp3uHXlkV98p/RYEatqsFtajTC/kvdo4m9MOZBgBcXZe/zn0X9KsLJaOCZqQyrVt+Hznk1Ijnb/+h8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=JgbbkxkK; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JgbbkxkK" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-1271257ae53so3481490c88.1 for ; Mon, 16 Feb 2026 10:11:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265500; x=1771870300; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yqyxcmWx7XZ4iXbnS055ZItFgkfiS2n3W/xrPfsX0Xs=; b=JgbbkxkKARzwrsc6jY+mqTuh/7eDCd32HnIi3MKzRe5RHXEgFylaYNVJM9bYi7vHyn QSz0DitwTZHtGX5/lZfV7FgXCFllvATL1RJXXtfArG56j1lEuw/F/z6qfYdHvGIjDo4g jdMJeDNNTXQdoyjmoLi8R6lZom+xEuA4B5hlY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265500; x=1771870300; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yqyxcmWx7XZ4iXbnS055ZItFgkfiS2n3W/xrPfsX0Xs=; b=vICUF5PNkF2AaCx5BBHbzNDNAhFs8f6d237QsFM/MRUEMShOAIT3+zBJ0+wLB5bFDC DAcysstxP1uB1P3N/AMI1pwDFVoO0YzdIBbUUHz74RkRRSWrMTc6Mxe1roImO+2Yg5Mj uh1MuOicECx0QplXnM7b9CqDqs7Mtf7pHrkz3DJowy64PT25vtBePLWHj+OvQLjp0e2n oLVhhfUNre4z3yk4OjPZOB0eqOZpA5opanpjMomlP9qO9WDX8C6vKh/H9/Bf6rJ0pgrh wlbyE2WVUZ3LORSjJYPZ3KhwXJ451wW1PKlTOT3Cmj6gCDf1dx3OOYQayyCGHR/mdl2L gz3A== X-Forwarded-Encrypted: i=1; AJvYcCWrxdis9dhL/vFpj6JiCPyl09QdH9i3p43CVsJwfOxl9oTzTJL19dXCBn95j+ZWmu1Y6PpTDrSWxLLa5s4=@vger.kernel.org X-Gm-Message-State: AOJu0YyWZLcc/1YPntWl5r0ZbE+B3oiBhfnSLdUElqerGQUEpLT5HSFE EjfM4BacTQVqm1RCEMWgCuy6Rz84Ct8NhZaFwglYkC2bPDKCGt3WknOZWy33kuM6xA== X-Gm-Gg: AZuq6aKE4vz01RNu0IGQO4EloWVmQc1FIxCHSrJpkus1YMq3BBXZWkeOQ5sSezP9Beo o6n6pdeuvuZvIC9DYYae6bMoMvKjJTg/w/80FEGU68z8e9JHPj6mv883NM7LbJq7bNrkcuEAfBF hVA6yodWF+dBPduZy5CJ38eqGpasrgb+orLZXWyOXv0ArXjXl5sueVwZoCK51z2LqQnKX4Hfj9Z nfAWiFs4HE5+fNDExN1S+XHLQbykkl5e6gwcD+L+elo0diVE1quoZcW9ftimvjk41qsC4AIvtFQ bF3PfzsD23iFdsswXaNpRoGpNdPFVC6Nx+1UBkCY0a6jEf/U2JXJo259+HacaXV6GCWA0+41QNH 5qLBZZ5kqukKvZnR1r6fz1m/cuRWXs2KkxAQiew/pEVmb9I3zV9AaRHg2KjkF9psC039mmCYSbn dtQ3dKf1bDf9/WGWb1tqcj0PBkSwfJ2zSGq5GhdBQ/6hKuZ4fZHQMyk5nHjO9zw7IGYFvp0HYpl K9gm7vCWtQ= X-Received: by 2002:a05:7022:a9a:b0:11b:a73b:2327 with SMTP id a92af1059eb24-1273ae2ef59mr4312457c88.30.1771265500459; Mon, 16 Feb 2026 10:11:40 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:38 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH v3 08/15] rpmsg: qcom_glink_rpm: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:45 -0800 Message-ID: <20260216100943.v3.8.I700ba93ec437db5100c0076941d8470344ea9995@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Acked-by: Bjorn Andersson Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/rpmsg/qcom_glink_rpm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_rpm.c b/drivers/rpmsg/qcom_glink_rpm.c index e3ba2c63a5fc..4cb9c36adcd4 100644 --- a/drivers/rpmsg/qcom_glink_rpm.c +++ b/drivers/rpmsg/qcom_glink_rpm.c @@ -197,8 +197,7 @@ static void glink_rpm_tx_kick(struct qcom_glink_pipe *g= link_pipe) struct glink_rpm_pipe *pipe =3D to_rpm_pipe(glink_pipe); struct glink_rpm *rpm =3D container_of(pipe, struct glink_rpm, tx_pipe); =20 - mbox_send_message(rpm->mbox_chan, NULL); - mbox_client_txdone(rpm->mbox_chan, 0); + mbox_ring_doorbell(rpm->mbox_chan); } =20 static irqreturn_t qcom_glink_rpm_intr(int irq, void *data) --=20 2.53.0.273.g2a3d683680-goog From nobody Thu Mar 5 06:31:07 2026 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7602D2E92BC for ; Mon, 16 Feb 2026 18:11:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265504; cv=none; b=mxy+fVcipMV076ilEKb6jYNCfSO4IYxBXtY7bkD8R8MJyUL6r1FiZ/ctgsxMpJCQRB0FwQNLncOLVCo7AA+gANu21w9Awhk0ZMOaJ3/6f4tWQB7YiMYeuOdLI+H7ZTifvkUMx/jmQlWCPglKRPsh7f+4UQE0jsatBTWmpt+43mQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265504; c=relaxed/simple; bh=1LwO0v04lIfnNg2Y8tO3ZD/AcNQmoxD04js80NYmaIw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r4l5MfeD/HghJo25iR6UwOzjB8PRRw5nupeq396s7ZECHpHDP6PWURniVvUtXMR9MDjO9jr2R5MLaLuse696U/7cOaH/u5meUFjRK5QQnbY9lCjnB0M37CUKjtFCYaqgZj/ASlUHIE93C2AMcBOXjRNBUz8VfSi93w1xffQmE2o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=cRYNPB1A; arc=none smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="cRYNPB1A" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-1248d27f2b9so4363579c88.0 for ; Mon, 16 Feb 2026 10:11:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265503; x=1771870303; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=McVpUeglzEgOwVzdcsjAkstJ2kz3KalaGrnYqtVtRLI=; b=cRYNPB1APEtIU0So2QDoKNkCQS7tQJDs6p2bpeoyGHMRLTksWAeITTEYb7lLWGSUFB 0Io7r2sAI7XCxnvEO4PkS6uaauR4sEEAs0DteGoylzPCkA6GDp5d4SrUK/kzM0CkaaN3 x/l8gpLZ9hstQZsE9EqlFyC64odw1/Gt2cSsU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265503; x=1771870303; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=McVpUeglzEgOwVzdcsjAkstJ2kz3KalaGrnYqtVtRLI=; b=nJuVRMYPkdyVDBvsApBBSz3H59soAIH/gv0QuiVkeYoOImo/erFzUjKITO7jXQ4yqc F5HW1KGr3/Rr8ViilNr7GAgA/byLvsOxqPOKRXcLgfsQund85uuJFIjlxztt/LpbtoZS YHoFRJOrVEgQ8rtYEPEopteVAGAIxrAWmARpouS0+eMI4etUUgEEEzdPhRzXeolFJ3/O gtojlk0RRhVhnBOfq8CrAYXbs1oa2xNyUWn/vEYBfPCcMVKt8gJkcZ1ARxVcdKlBgDin OgImfa1l/bnGmFZdvu/N5E/4kLZfY0/nFAz9GCZnElaRN/WQZ8V/+QpXJare1/ZZEWky WGhg== X-Forwarded-Encrypted: i=1; AJvYcCUkpQSw+ABMQ2OxIJMeQwahlxkU06LMKmkoxmEAGQrmlMQDFhlTIP0Zj6gPzJNwqTlCu6ZvtsIEy+vqiaM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzvb8h0Vh8B4k45Lw3kfvweh49A4lgTqsHlD4rsN+uGGBCiTziL UyYFwVegv4UZxAWEapy0V0Om7mXWbX4m8HWbVh3XWglh2w91mVNqrbV+uNV4H1WRnA== X-Gm-Gg: AZuq6aICEBO0YC0/aYM0ZwaoklrIqjDUVL5j9cGp0s72PFhYeLFUFOeVwoA8gS85dIx INXBBfMGfVsyWZeOAIxdgkjmduU3BB5AYsW+DKIr5hiL638ajYe+vgA7QloCQZlyjtXNWwYWeyx vzq97WfJgo8n8+wXgq7aIWkMHBtVHswnzIojuLIg+rPO50Xhsfq8STfLz7gcpgVpKGnJVf91Dtv hreYqeLXHPRGFjdHXCTNHly24txKb3OIYHRusoqfv/zMYKumeimuE/wReT4paKLWF1pR9DlZt7m WI7L7WhU+zdlrzaDTaC6kSFtLHnX2zhx+GvifyDxaSO1zGP+PQtoZdtAIO1danDxg1hVnY9wJ9o XOGRnlIS0ThzTi+X80va9obT8bsatVfWVdZ2r0inXRRWh34WkYC8X1MlzhjrOnMAEF01wQht4Zj 4ypJASpKtSwyzo/9y3yNe6Ym2DHAA8hG6Y6MzgRDDRPvw7Pq36qU/YimVitxbvsfmslWOd8qJ5O qhuGwzBp70= X-Received: by 2002:a05:7022:160a:b0:122:2f4:b251 with SMTP id a92af1059eb24-127397bf3femr5004979c88.21.1771265502576; Mon, 16 Feb 2026 10:11:42 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:41 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH v3 09/15] rpmsg: glink: smem: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:46 -0800 Message-ID: <20260216100943.v3.9.I6973a32c3fcd6d2edebdd6fd868fe0a046420ed5@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Acked-by: Bjorn Andersson Signed-off-by: Douglas Anderson --- This driver is used on my sc7180-trogdor Chromebook. While I haven't stress tested with it, I can confirm that the system boots normally to UI and can suspend/resume with this patch in place. (no changes since v1) drivers/rpmsg/qcom_glink_smem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_sme= m.c index 7a982c60a8dd..f2a6d94e72ea 100644 --- a/drivers/rpmsg/qcom_glink_smem.c +++ b/drivers/rpmsg/qcom_glink_smem.c @@ -197,8 +197,7 @@ static void glink_smem_tx_kick(struct qcom_glink_pipe *= glink_pipe) struct glink_smem_pipe *pipe =3D to_smem_pipe(glink_pipe); struct qcom_glink_smem *smem =3D pipe->smem; =20 - mbox_send_message(smem->mbox_chan, NULL); - mbox_client_txdone(smem->mbox_chan, 0); + mbox_ring_doorbell(smem->mbox_chan); } =20 static irqreturn_t qcom_glink_smem_intr(int irq, void *data) --=20 2.53.0.273.g2a3d683680-goog From nobody Thu Mar 5 06:31:07 2026 Received: from mail-dl1-f41.google.com (mail-dl1-f41.google.com [74.125.82.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEB072EB840 for ; Mon, 16 Feb 2026 18:11:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265507; cv=none; b=RoHBaAayrx5AGPn1SlyOz+Kjoyvm7m8iPDcAaCyVs2V3dm1YoNyFU4XoUDp8cyKgr1CeWtNVKGcvCA4ZNLj8cgUlPTVXatPmEQjseK+pKSJbrYOaJpLhLA4btaQDf1PifhB3bwrgDKNlUKOrBLayHEoTtmvR4+9CpHc5NvQFUio= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265507; c=relaxed/simple; bh=CDxrp4OucdMFl3rFBhyh/bKVYZGNXZao6NNebXzLvRo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kr/Mm2zaFalwYIft9BeZo0H5MmYSWEGhCTMNk8ltKe1u81vjS8kwuTofS064RDHeBDSXGWOVDggtCbvUQJBjOfnttz9xBhKpO6fblTJV8GKCd119Rh9+iUD4osjCuSRe6Kw3ye3X44qOfYdLvjBp/7iGvxrqY8TQayt5RFi+z80= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Dk8Cke8Z; arc=none smtp.client-ip=74.125.82.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Dk8Cke8Z" Received: by mail-dl1-f41.google.com with SMTP id a92af1059eb24-12732165d1eso3792683c88.1 for ; Mon, 16 Feb 2026 10:11:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265505; x=1771870305; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HSRSa2qBwyo4MKgv7YKXiUq526mCXszwG8DRrzAIIQ0=; b=Dk8Cke8Z/TooRCn/hfbmy2Jqps+817Qjh7KHgbwuiyfGH6jWu1hvgUZOi+lakInbfw nhAtkQdhK9OPwDa+EcbzjGiVOy88XBZ1o9oFOE6XBh8OWTySvCB5BRdy4VPJl8d/udjn FEbngNnr/i5CJmkPLqxnIJErCVQV40F5F2drQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265505; x=1771870305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HSRSa2qBwyo4MKgv7YKXiUq526mCXszwG8DRrzAIIQ0=; b=ckr2pgY0ytWO2iiQBj4w75GDV+1LVOJ+BJ8pikGjRP77FOpSL4mVkgqyCqPieirlq1 OJ0lVsBTZjv4FdLXLr9A71oFs8C08b13GCVxzQOU8239QFAiQ2IXk/xiFtlPG62BCAqb Cz7E8QfthvdYeGZNyY1EX3NvdGG/LlGf3YUlxVq4FtO9cEYOnqYZyQEhEfE7h4Htr314 LUMdsTbTbiEyL9ENwNrJB8AsYGpZY6N/UKLnECxcdpSwgndKkXSPj0/glKwQ8I8/qhke CfgWjKTaJkifmrJjlW7WbqMtiBpNX9M7d32p8sXfAeot7eYSKmyq424HDT8IXpRVqzdd zxKg== X-Forwarded-Encrypted: i=1; AJvYcCVZ01UYFbpKAQ1sKhzimQpOWORcLNM1O4U0N+dCUcCmYoc4o9H5HbajthkJDBERs29s4YSnbuW0w57kxPg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywa9MZXe43Ji179kb9fsV2vubtyt+DN6+wnQxWbPY5QjBjVwxiJ 3PxshO8A2Trhjj0qyBXKA34mrm9lYRA3VdSb2CtZgneMQ25GXEiRY1hFkmwCd6U0ng== X-Gm-Gg: AZuq6aKxElwiO1SUI+w9p9fhc+rmn9/pKY+qS/E+LXtq1G3iP+6LVYP8ywc2VCclcM2 6PNI7qbvPtqFG9EIcrRI5RUsy9XIW30uRGJ0KFRLKp/RT6MsQMH+ne/JRH/W2gdVFCjViW2/NIc XeFLEjppTX3SiD99zxKfvNbXGA/A5xcVsi+vh0cFpRd1yWm6j4hinxbyWzmRNDfatKPYq7L88Bg YmEDmOjUgmv1OEWIgCHbgYR9+eyylnS5FzJdfhE1vpbuJlfEvsiapB8r8OxkxwKL4d6gCUAlACF PWIN8o+ALr7q9B+/6DmwxaMH4vq9ufatSFJECd0p3k8AstXizH/cMdzTWL5jQ3C/AX72/AjZVzI gavKggM8xDCEf6GcE/xZjXMgXlTOPs2+GOmWeq91x4XIQm2X+gDf1383fPjBfHKjzdqxGB087Fs wWIr6DXjxLTQn9wfG1a+P0YyuBIwpTjsefC6eejukABHVP/LQVxW7JR+HAnUUv8y7Q5PXiM6eDR Ok+oFXghdA= X-Received: by 2002:a05:7022:926:b0:119:e56b:98be with SMTP id a92af1059eb24-1273ae92b3bmr5486503c88.37.1771265505096; Mon, 16 Feb 2026 10:11:45 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:43 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH v3 10/15] rpmsg: qcom_smd: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:47 -0800 Message-ID: <20260216100943.v3.10.Idbe327f5b4ce65a284b55033627d0819e2fed21b@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Also remove the comment about the only cause of errors for mbox_send_message() being if the framework's FIFO was full since we don't queue doorbells. Acked-by: Bjorn Andersson Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/rpmsg/qcom_smd.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 42594f5ee438..afe1177d092e 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -371,17 +371,10 @@ static void qcom_smd_signal_channel(struct qcom_smd_c= hannel *channel) { struct qcom_smd_edge *edge =3D channel->edge; =20 - if (edge->mbox_chan) { - /* - * We can ignore a failing mbox_send_message() as the only - * possible cause is that the FIFO in the framework is full of - * other writes to the same bit. - */ - mbox_send_message(edge->mbox_chan, NULL); - mbox_client_txdone(edge->mbox_chan, 0); - } else { + if (edge->mbox_chan) + mbox_ring_doorbell(edge->mbox_chan); + else regmap_write(edge->ipc_regmap, edge->ipc_offset, BIT(edge->ipc_bit)); - } } =20 /* --=20 2.53.0.273.g2a3d683680-goog From nobody Thu Mar 5 06:31:07 2026 Received: from mail-dl1-f54.google.com (mail-dl1-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4C2F312821 for ; Mon, 16 Feb 2026 18:11:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265509; cv=none; b=uxEG8U4i2OCFjLNDM42OK1tYmZhS3tlbIzwRQ/rQa1flLMSRaCHGy4lxpWdFBQaAM/VJZ05FDl1nyqLeBl0AQNk2/VRVN00lXjUr4vzfHMKGWjL4XkqPw6A3YGLZMF0BO3LAHVS+/FByYJ/RIjHGfc4+MmsEvBk7jxj/QuCGeS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265509; c=relaxed/simple; bh=qmyrR4eAQ2gYoRBvP6c/rsMJF8jOCsHArbZlrZc6las=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lpXRZby1nha9GS8XcsoucwK6Rnq1sT4zzFnsOOuwiWC7jqIoQw9f3wKrO5WcPnpoVapIBq5KmrlI9heUT7ShymPYDZXpZ3ubMHkRlDXV9kQaXihIDQXWDFSeByte1boOMrvAEUrsHoyuMzNtqim7mkhRGN8floyLxqpTXNkZs5w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=W0yeIQJt; arc=none smtp.client-ip=74.125.82.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="W0yeIQJt" Received: by mail-dl1-f54.google.com with SMTP id a92af1059eb24-126ea4e9694so656318c88.1 for ; Mon, 16 Feb 2026 10:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265508; x=1771870308; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ymwo2pW/jDGizs91i5oGR8wtWgbsstD/NJbYWAn5wMM=; b=W0yeIQJtjjtMuy0zvxC9P1NlJNa6l+S2ER8x1EQL6xTxtNk3FnbsoiWDgxBTSs+Lbo 4z9LLfa9Kr9nP41y9rPRMqO2qfPuDqJGGwIGcdJtPO7L3/q1Kj1DD6z32C7aeCsQJNiq ECgEK+4eqVt2FzMYB246/WGDJKuOhXy0JEjOE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265508; x=1771870308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ymwo2pW/jDGizs91i5oGR8wtWgbsstD/NJbYWAn5wMM=; b=JX9daigndReTD0BVR+WofsG7hDvgIbyBi9sLzFhJz3M/1Ldz3WhZUanEhDQoe8/xg+ 85SEyUV799dTphfwOS+SqA3nnDXNiqSl74CoIx4dBpk5pg4bovgreHuToclWh+vqeaOK iF1LbaZ8j3NZDxHq3AkKPbrY8rxCORxDK4GYkXjfb3P9egGAaYnuWXEs4NzY2CtZzyWV oQQsbeRiwTEzavT0Ui9jqyzYATZFeoJX2ssCT4a1vY2mhmL4PFZi4LFlfZZ178Af3NXP MSfkTtW5hgFCZHw5LUtKEhvnjZnARj1uiY9vsJ+zmXB8AYS625ri2u46Y/CLUO4I2eUn BCyw== X-Forwarded-Encrypted: i=1; AJvYcCVNN1LSZjZkOWf/l9Lm8lUlkquEqsfojVeiCJd1KAr10SbsCPhfLovtc5XRH2STURFo9iACrUQl/m+d4us=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+ACnxe39CsQpqVeiAEqnkGy8a7QVamHewudi29syTU7HQEtr/ fnPE74qHOCYOpH+WI7KC5RxL3V8s4kC2t1PcuKqPzb/h3omsspv+Y7XRFNVBb2bASQ== X-Gm-Gg: AZuq6aIJn56Y+it1ZDsagZ+26NI4/5m1xT4UzwOovM5xzaPkyXzERESFRDDC9wsxoIt 9dqLnL+ARw7Z5SIHwVG535oLY4OlntxY3564LsC5vEpgjRP/WkuKmFOsF8sU+KSMPnSX6uolxFa PQ90cGa6jO3PuG1LZTcX+mcbFq9HLHCTpxR4h677dPJRnecQijmK0WQm1Sb2AMIcdlrZBpOjX6e 2GWDtQKqEUKMfrmovxZol21I84VhJTOeagvgTie0bVXpnukkSzAaCnOLZUlCStvRcAr5gDn+SdG ZCgUuGlfZPBAT+0WXYERJhkK0LVAL8kpoiLzzk1TGHC8gPD0p1ILKA2gyWt7U26qzthkE+0d7pk ETY44FPPU7G2stERLtezeu/IT/M1saKAJkCx7a5oCPdSiX61/koSwbsWcNuBEAgBgBWUAnb2SBM uS5UFcQYF6rd4pJx4s4sPtPB+MWr0+zVL/5QJ5n8wNLQqlpuextFu92IrD1VgSk4HLlzNpxX3FJ ZVo3jmNLH0= X-Received: by 2002:a05:7022:6098:b0:127:34d9:9635 with SMTP id a92af1059eb24-1273ae33a4bmr4464871c88.30.1771265507844; Mon, 16 Feb 2026 10:11:47 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:46 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 11/15] soc: qcom: aoss: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:48 -0800 Message-ID: <20260216100943.v3.11.Id882cb3027e9d3a948ae95dfa6d310e3b29faa38@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson Acked-by: Bjorn Andersson --- This driver is used on my sc7180-trogdor Chromebook. While I haven't stress tested with it, I can confirm that the system boots normally to UI and can suspend/resume with this patch in place. (no changes since v1) drivers/soc/qcom/qcom_aoss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c index a543ab9bee6c..2ecab93239d2 100644 --- a/drivers/soc/qcom/qcom_aoss.c +++ b/drivers/soc/qcom/qcom_aoss.c @@ -97,8 +97,7 @@ struct qmp { =20 static void qmp_kick(struct qmp *qmp) { - mbox_send_message(qmp->mbox_chan, NULL); - mbox_client_txdone(qmp->mbox_chan, 0); + mbox_ring_doorbell(qmp->mbox_chan); } =20 static bool qmp_magic_valid(struct qmp *qmp) --=20 2.53.0.273.g2a3d683680-goog From nobody Thu Mar 5 06:31:07 2026 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C51522EB841 for ; Mon, 16 Feb 2026 18:11:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265511; cv=none; b=pg/WurqSsTfvKIOVH4BYerc06NH9fC0cmIKZ9pR4t633ZxdcWwSKaMp/bU4srWpAOzDA9/fq7rD489fcLN47sLJt490lYWdNnKlzgKXvwK7vuwwamnDP+Rm25f8Q6PgHvIk3zXnTtDMh9wPGfGx8uVacGWnkIPkWAI7YBCUEVTA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265511; c=relaxed/simple; bh=HTSdkJk9l98H+40HfSCW5IdP+PKN8qaGfdBkjMVQkVE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NN5c4FGVaEXBC9zZogwbVijD9gfVBzUn3POQFoqih4J3oVSK2jy7TbviaKT8jOy6ryu6uVQdt9Pf4ySpvo9Amfd2gXj21jT50AC/CaMhe6eCp/Rm+gSNoyGSHhteTBZc5Rt69UqJn2G/YuuQg3tR5BcCMQmV+dnoD1QpijxkJzg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=T6IucpcW; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="T6IucpcW" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-1270adc5121so4507131c88.0 for ; Mon, 16 Feb 2026 10:11:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265510; x=1771870310; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oiI5aUOPqb58UplGIDNV8w8jAQukJhPp7ypbCHDoRdI=; b=T6IucpcWOJ2bmD/vR+S07/qhgTn7sjxirbmNw326SFulKmWvfLhke3C3G7Wfk2YcOy 1lLeNfweqsijgobNwbc+wbGhz4eFyAoPCctk7ZFvrtLibfp++RS/2wXQ6VePiTvThg0Q vZp8hxsq0FIPsv4S+t6Ajvx51v0DthQVIXAgA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265510; x=1771870310; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oiI5aUOPqb58UplGIDNV8w8jAQukJhPp7ypbCHDoRdI=; b=PKhkOJFYBE7OJFcLI1QHwdNChKIyR2+s3GBBa7DsROlY8eHfb+DWhLxyRHxG0X5yM4 fZLVouVDXX6c7ZoND/HI+Np09taFuaw9LNj/B6OyNJH0fK+mty8GAUdsjECBV6xZorLP sGDpsMkw9nxzhGVqXdzc2e7ePohMvkN2W/blS19a5IqYklaQbUYo7Rh/ZacWjJUntRJf ciC7nYFDE7WYolDRvXbBUDCHqPC55xm19vukH+ufa+nQbWWiEhIA+UmVOCA+l73U6tor a7y+2srbgih22VG4nFftv79YQ0BLrCXnlPPKaSU203XxnLitkVVRgu+wAokSM36+GgwB HGuw== X-Forwarded-Encrypted: i=1; AJvYcCVvfGvV1+5sO1bDRFTrBqX6Br5X0iG8oEBIw1AdTf1petd8E8fmVAZZIjBSwcdDz4B313+REUlizEz85fE=@vger.kernel.org X-Gm-Message-State: AOJu0YxLqv1J3d60d7TNXtpB6vqodAp8nTh54z+NNeA6NsY4QcbAtn2v ubaupKkiaTuAfUjPG5HaVC/pCDSOrUgQwGVaLx97VmefXvVjObPIELEte5/DFz0WZA== X-Gm-Gg: AZuq6aLHH+IsG5Z+xs0sjrhyyqpNt1X0L1ff3NguIu0L3MWgoVSwx0DMNKDw5N1nRwl 63ogvx6LLTc3jkfMgffzPYkEVb/BEJhXdJxJ0BQsmf/shkFRVb2JhHZ61G+FsRDLmprJjlvtCno RAQ/ol1xJZ5A0rbmSwM737Ed+MfGBNlmrH1gR8Zc03moV64E9XAvFF4Zm2Zx8HjnQaZlY+D/Ypu rBe6Tt7833Wwy2O5k1NcNnjcdxK4IhMAo9uHV1lRrzBVnne59DL15AaCLLTPW59RBwjp77iqs4I 7SyWuIEyIKCiz88hBSA7A0d+pWJKivXB10lldsgAYXX62vaIbKsCq/qj2IB4rZkDHjdxvM+1sRi ChP8PSQSkEXG4z6FAlohxBDuZYylu8OwThl+ynjwRRL6bmWKOD46enmNt6nB5rX4sN3kBwOliPF G4r4X9zSMNuS95Zx1KLrQRR3EJ5+ppwi1sGq9Oj3dqYr72hCuFhfh9IsTQDY9MQaHd/brTFw0hs 7QvfYUCeMQ= X-Received: by 2002:a05:7022:6285:b0:119:fb9c:4ebb with SMTP id a92af1059eb24-1273ae6945amr4340040c88.30.1771265509962; Mon, 16 Feb 2026 10:11:49 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:48 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 12/15] soc: qcom: smp2p: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:49 -0800 Message-ID: <20260216100943.v3.12.I4e47dc2356edbaadac7298ddd65dd649d9b5ee16@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson Acked-by: Bjorn Andersson --- This driver is used on my sc7180-trogdor Chromebook. While I haven't stress tested with it, I can confirm that the system boots normally to UI and can suspend/resume with this patch in place. (no changes since v1) drivers/soc/qcom/smp2p.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c index cb515c2340c1..139307b66a47 100644 --- a/drivers/soc/qcom/smp2p.c +++ b/drivers/soc/qcom/smp2p.c @@ -169,12 +169,10 @@ static void qcom_smp2p_kick(struct qcom_smp2p *smp2p) /* Make sure any updated data is written before the kick */ wmb(); =20 - if (smp2p->mbox_chan) { - mbox_send_message(smp2p->mbox_chan, NULL); - mbox_client_txdone(smp2p->mbox_chan, 0); - } else { + if (smp2p->mbox_chan) + mbox_ring_doorbell(smp2p->mbox_chan); + else regmap_write(smp2p->ipc_regmap, smp2p->ipc_offset, BIT(smp2p->ipc_bit)); - } } =20 static bool qcom_smp2p_check_ssr(struct qcom_smp2p *smp2p) --=20 2.53.0.273.g2a3d683680-goog From nobody Thu Mar 5 06:31:07 2026 Received: from mail-dl1-f53.google.com (mail-dl1-f53.google.com [74.125.82.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2674A3314DB for ; Mon, 16 Feb 2026 18:11:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265515; cv=none; b=d7O/ElkwR78hWYId1uAfnhBQEwiwE+wDpZnlZ6HtctPCdkTG9Dp5utJZS0LKBWCux1Iitfunn4YYCA9djhAuI10lNrelr5Vb2+NQNQ0MzBjw3mnCeIuvdQ017oKmU7fL8ja7O2rwkEAB3OcabZYi8yS3WUGIdgzJ2nTRZ7QYt0U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265515; c=relaxed/simple; bh=W+176oTBG/C8AKzIcrHzVeoVwp5F8+32rXhrWXykrzI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ePTc5/++LC2h96sDRIITroo+fOsh6I1BO+jlo0askRmThnegLFqIo+jMiOrnrpEoal1E5RCyL92r9c7OJobQ0k5Oisp9L684Q720E15bOboIyVyx3tlJtWYx0DD+U/csNJtNs7QwGrA8RPfqgXP2y1Uh/6eKNWmp5c2N/IrJxAk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Q2e/89e+; arc=none smtp.client-ip=74.125.82.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Q2e/89e+" Received: by mail-dl1-f53.google.com with SMTP id a92af1059eb24-1271257ae53so3481710c88.1 for ; Mon, 16 Feb 2026 10:11:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265513; x=1771870313; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e4sITQtMA3O7CTV7vddQrukiiEajLzgMMa0j7tx2Nig=; b=Q2e/89e+vjYz9jKA5aOs2uzHdizUVZtUXFt5MEA7uNJpNdnW4CuTD9tFXtspH1FAWq oIKGLhPj4Fsj019uDTzGldX5xQ+1ucr0YxRv0+sRSwNzS5PIBO8XA1SIJ83bjH7x+Vjp MB9FIK2kfU8Kvv+GJvKXMMx9mbemZpRFpA0rM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265513; x=1771870313; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e4sITQtMA3O7CTV7vddQrukiiEajLzgMMa0j7tx2Nig=; b=ffR7C8VctG3XVk7eA5T6rtppQ33k1+n7N9f8pIRo5fkjCez8fFcdvQVTalggkch1E1 IjVlfHmBzFJnMChFX+ndI3qNgB86/tKIYTygJORm+N6fQVjcqscQ2LnK9HCe2QeyqsqX Bn7nnnTq4CEYVN9YicsUYXqfOs3UxcDUZ6I8FAeNJ1pl2KHcnFfzDhtWcrK3uw9rQM8T KUtGZz2ioJEz3M0tTkTloGy0caH5VITNzp+Kz9sp0zGBGoKFiREi0zNyNcPgKPTR2DKn qsgo2KBJUm4XLU6HSV3ijEFuwRqsTB1TyCbk+2FsYj3QYqLIdbsvwAg6hNS5F+vFm/az 5L4g== X-Forwarded-Encrypted: i=1; AJvYcCVA98wYyrpsUBButYmM4uBDHiArxiVFZj9Em+I0Dkt1fdbUzus7HyiCww8iv2Y7XAMK+iCUUbRd9F4Jrnw=@vger.kernel.org X-Gm-Message-State: AOJu0YwxJaIFSUv8lBE7+H6jcl8Bc0I3jJZaqwWF31OeVyeHlOQr+IWH dRXdhHlfgDmZc2llS3d9BsK3vYx0dN2JxD1EDzQWXkZKPRCOrK6yknFPAPnaWjImPA== X-Gm-Gg: AZuq6aJmF6uZ1J3qywsypu2v8RHl3IkpwemXgjFomd98TjSSFu1c1/BupII5ijdxJdZ 9y5Mz0yCZCmNSf8Cvmxj5Ke2jgmO0LpF/soPRMnvNCkJo5/fcyOv6v/bYgEthPBuaptWhICnCw6 IF652Vc1PoyEyifw69xCoe+PSYRwcD4DwHeNaicBZgaGSc2FIVITi0f70MV5231BHFhiz4pZhWV Dy/eZUmtEmalQpsRfX73Av5M3HdxFFG8g3nAKhtI9no7oQaEQn+32PcEkmhMKt6TV0i7G0N481H nkTVn7sfzPfCYxUkYpqZAqdYy7O6qACKoSJ/tOxxWeFbx/2bea6wgwAMLenaPOx3ISjYOwLYri2 aBi+KerRs4kzebPiGClKjMoqTrOf+IsQ6gfCE8KhmW1QhJJ7kiksPKApYpX4AAukE7fNSb0PcCf vO22hlCry9SGnDNC7VwoyPEuov1m6+PMuuInuQbpyOEpTSJVdykQpn95GZ4QjMnV+zTWuxrtVNF z4CDIi990s= X-Received: by 2002:a05:7022:69a:b0:127:380e:ff5a with SMTP id a92af1059eb24-1273add779fmr3928066c88.17.1771265513269; Mon, 16 Feb 2026 10:11:53 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:50 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 13/15] soc: qcom: smsm: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:50 -0800 Message-ID: <20260216100943.v3.13.I18ba5837ac5c89cdd3531b6b09a2ab24a95912fa@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/soc/qcom/smsm.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/soc/qcom/smsm.c b/drivers/soc/qcom/smsm.c index 021e9d1f61dc..1e127678fd9c 100644 --- a/drivers/soc/qcom/smsm.c +++ b/drivers/soc/qcom/smsm.c @@ -182,14 +182,12 @@ static int smsm_update_bits(void *data, u32 mask, u32= value) if (!(val & changes)) continue; =20 - if (hostp->mbox_chan) { - mbox_send_message(hostp->mbox_chan, NULL); - mbox_client_txdone(hostp->mbox_chan, 0); - } else if (hostp->ipc_regmap) { + if (hostp->mbox_chan) + mbox_ring_doorbell(hostp->mbox_chan); + else if (hostp->ipc_regmap) regmap_write(hostp->ipc_regmap, hostp->ipc_offset, BIT(hostp->ipc_bit)); - } } =20 done: --=20 2.53.0.273.g2a3d683680-goog From nobody Thu Mar 5 06:31:07 2026 Received: from mail-dl1-f41.google.com (mail-dl1-f41.google.com [74.125.82.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CB4C3328E0 for ; Mon, 16 Feb 2026 18:11:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265517; cv=none; b=mlHHM+1ZC6Ll3PwmSeMQHZ18vp/gmoxr0EgaopDfqeKtfDMcch8XxysevO4dlXaH6X8akTgXPXG4MHxyDKQqNgCYGoOuPZWhGVkR+t6whFOv+RiKwYTg0HKQRLVgg7DciBljqac/MxEgdfyHeQ0Rp32iUuN8rBGP1mJk0Y5qqJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265517; c=relaxed/simple; bh=KL9kSkQsGx5hFor1aXxOTXacTClqA31GRHRGi8SvfOI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Gv8Bon6YwBnqBCG7HRolCbXAA3ZhxdE3zKtLkO5g9RUjrkVtWEl1uyA7a+EeUQXWW7d1FlzpVNmfmNCnjLnUTPMTLIqe4HRNzzgedmwYJQJjxgP9w5DM0U3+Tqrf8jAYTUwyx2IaEXRBVxvIZBqn/2Co4h2zHZpdvWMhZiyXp+g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=fQyTxTtN; arc=none smtp.client-ip=74.125.82.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fQyTxTtN" Received: by mail-dl1-f41.google.com with SMTP id a92af1059eb24-1270be4d125so2419871c88.1 for ; Mon, 16 Feb 2026 10:11:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265515; x=1771870315; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GrUBV+EHratYBsRTOcBaUousa7P5GwgK6vHEbze9WVI=; b=fQyTxTtNO9sHYW3iyUMCeFntYfLTT7+VljVgynroDeozXr6jwJWoc/vVVmNaUSIydw fYddNLKpV+waG/C+mzVFHQSigpTyzjwZbMXA0KtVVopjhZo0/JVlFABX3zwKzXugi3FU 9APRrHpnj0sUGCBqlzj5/iMeL/z2qvmTGlAHs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265515; x=1771870315; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GrUBV+EHratYBsRTOcBaUousa7P5GwgK6vHEbze9WVI=; b=iA1BIrxvFAA18ttnH0K2FJ5jDXVWdrc9cm8qXYbjO21GJL17xnWy1wnEM884r6af/7 187tVuLQQlPGRA8oz7vWfKCyKF5EGiZ4AaRMgfOWnq/nkBuCAPNQQ9sKuqRzw8lpXNgv 0evuXM58pVNjh22O2k7TWZ1U7kCSqlOieT2BdOTeq+VM8kuP4hN57wtXFH0e1LQoI+W5 xH/2yy5O9oKESLiJQF1Vjd49C2sDxSq39aKGkggmGM61a+XdXL2n/CfbnW3/TXEPmrwG RSvxK944GRi+kuIbo/iOWhrw3v9v8q+/lZrTwNFw3mkF54LYvRSdc24tP8CIlAWqDF9P XQ/A== X-Forwarded-Encrypted: i=1; AJvYcCVyqwJDmTUrcx3211g0E0II8zk/efuP8RP+tNCYzW7uTGOF5Bh6gIkuiyMY8iYADNrQr3x7m+gVu8udhao=@vger.kernel.org X-Gm-Message-State: AOJu0YztRC7Z2JkhpjyLu54ris2HoUjzgyN2aLnYFmTvGUSaEILmJtKq tjqDmXbqB/e8Xz8rR2sfI0uATMIcQHVy3T3HEviCJAQ4Lye7FrZUb0m6wM4iKibTRIlS1T9239W o4LI= X-Gm-Gg: AZuq6aL9cl5d9/R+K8xRavoggOFd5zCh3O2m4iDVmFS3LRsYMTuA/t1sdb3WYxmLVbh llIfrn2F5RAzzrandZfLf9duoYfpdhTKmHUCeSFdElMpHsukNhQR6tj4C+OMMEGq2nOCPA9nsun Rr8//vV9JJphmiQ9M1rJF641C2LdsSzC1yRyn8Loj9uJhYIv1ymTz2LV20/pwEBIN05QZHFj12F 7DkiDcM9h1OJyVzeHT17ef+KzdOAWyxj/i7dJ49JnmNKAmg9c6AsE7KmERUiRSbsPbmRJELnSEf ZPm/dJ6Z62+F/QqakmAN2SI8xFp7IaSU3lvzO1ONsVFlzNeqSzgff6altRvo4gYZTRU+F0ggTp8 ikX61MJ8UIwB2o7tngRASBnFJJS/sVxOLv0oAWIDKuF5Z18tTqiVk4bggE7Dz52H4L62krr3os6 NCJL9MPUFC4EMhzpyUR/PSAPf27LYtswU/Ow2PxrUm3bmm5oFpbP9lt1F07eLRLSx0Q2izBgkQg 1hSly1s2DY= X-Received: by 2002:a05:7022:6897:b0:11a:51f9:daf with SMTP id a92af1059eb24-12741b7283fmr3078155c88.14.1771265515351; Mon, 16 Feb 2026 10:11:55 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:54 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , Santosh Shilimkar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nm@ti.com Subject: [PATCH v3 14/15] soc: ti: wkup_m3_ipc: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:51 -0800 Message-ID: <20260216100943.v3.14.I0334ef23106cca2014f28ae56930741ca9238105@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/soc/ti/wkup_m3_ipc.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c index 5845fc652adc..9f74f2dfc217 100644 --- a/drivers/soc/ti/wkup_m3_ipc.c +++ b/drivers/soc/ti/wkup_m3_ipc.c @@ -328,9 +328,9 @@ static int wkup_m3_ping(struct wkup_m3_ipc *m3_ipc) * the RX callback to avoid multiple interrupts being received * by the CM3. */ - ret =3D mbox_send_message(m3_ipc->mbox, NULL); + ret =3D mbox_ring_doorbell(m3_ipc->mbox); if (ret < 0) { - dev_err(dev, "%s: mbox_send_message() failed: %d\n", + dev_err(dev, "%s: mbox_ring_doorbell() failed: %d\n", __func__, ret); return ret; } @@ -343,7 +343,6 @@ static int wkup_m3_ping(struct wkup_m3_ipc *m3_ipc) return -EIO; } =20 - mbox_client_txdone(m3_ipc->mbox, 0); return 0; } =20 @@ -358,14 +357,13 @@ static int wkup_m3_ping_noirq(struct wkup_m3_ipc *m3_= ipc) return -EIO; } =20 - ret =3D mbox_send_message(m3_ipc->mbox, NULL); + ret =3D mbox_ring_doorbell(m3_ipc->mbox); if (ret < 0) { - dev_err(dev, "%s: mbox_send_message() failed: %d\n", + dev_err(dev, "%s: mbox_ring_doorbell() failed: %d\n", __func__, ret); return ret; } =20 - mbox_client_txdone(m3_ipc->mbox, 0); return 0; } =20 --=20 2.53.0.273.g2a3d683680-goog From nobody Thu Mar 5 06:31:07 2026 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17DC3332EBB for ; Mon, 16 Feb 2026 18:11:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265521; cv=none; b=ChCYdaDiIKjttmEg5uNqX8zEGxmbGG3CBeyaaLdD1r/pwUqVTpDf5+ftduqRD7TFv9fqWLvhLIecdVem3i5bdpCZnTJvtndLSzXGZkg9iAXSYoDOlngpgddlxkkK3zR6AhdmbYZU4Eep+FqO+3U8+cdhnwUl1eeVAc8SirRyeA0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265521; c=relaxed/simple; bh=EIkani2YIGrRFTxF2yYOYtKRRlIuseM5xCRIJNEG5cE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U7Bk789LSAkiZhJnsUiTXtL2HmuLVp3f2PFWDGrVst+qEOzTkAentKKnN75XDjKb+fC7lR2oLXVgT6TH82waiWNC6katUN3l8pGS8e3JJGuoVZrKG8KWrhNRfeyzFYwesGB138NaeyIKfIHLIMaTnYtIx0r3Gh+ziwdPJihmKo4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=VhEj/gy5; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VhEj/gy5" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-12713e56abdso2541454c88.1 for ; Mon, 16 Feb 2026 10:11:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265519; x=1771870319; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J+UlvlE070gUnZu1JB77SJZotSZsX9PJX8xc0lTNuM0=; b=VhEj/gy54PPWJCZcbWa3ZkFF2l92mWoVLPkgOA2PDKD9DfucWj5x+w83x8s/8I9Ipa HawfZLWRzXf0CGfa0LD8/ztfrU4DFHForenRIdgrAnKHdSIGjKKOoL0jP4amePzCy4vc GDErDvNpWO8N8+g0EWt2U725FLzMvbEmHn15I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265519; x=1771870319; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=J+UlvlE070gUnZu1JB77SJZotSZsX9PJX8xc0lTNuM0=; b=qAgzQCN6LqnVUm6l2eLH2ZpA/SAbrYpvW2BVHy+X4glwbBbBLP1ABqHuFjX19nrLl0 vpnRZU2mrGrS1FAACE45JrlDH4CanjmEwFPW8NisvfG4CEn6qMgTM9OJhf7958Nxh9PY roP7i0xmEYzLW31NHkujcaGiPPQ9XiAMUHVldVhPJy2U0e5j3qmGuQt3rwInz71W258u qvrOBhxOW7Jx7zaIt2vneoC/fupbpAcRC8WRSB+XX5BCESTjkQwjsmf8o0FbH13J61Rk NQCdA1ojRiuPgXEG6KtcwfE/CtngxzPIdjj+er2QzF0J71mr9LIlwf8AL+TviJuyMx1/ 8cBQ== X-Forwarded-Encrypted: i=1; AJvYcCXKO/FLWpd1PREfluyCLMqTLNsed6NXmyoZnTw6kB3cVw3NjzW8tl+B5iz5KgweipJso6Cmr+5i7KJSsyw=@vger.kernel.org X-Gm-Message-State: AOJu0YwG9ZZ0udFxEXuBKVZnHiGorJjPP7bGAmgPir1ab7/l8FuCIcfg QaKYtNekgl83kNUqlbFgxjkmepA5eRvrrC+6FZR1d3WGnZ0xfpkgoyqvfGYJpVBJ/ls3EXVFSzt bxF0= X-Gm-Gg: AZuq6aJ+z7oDIgnoAm013Ao4lYoZqxpqCSygQjrU/7DcgtlOkXqf8ojM0PgEyCNJ24/ nNQ4JgAnU58NK/4Pbflh8dJuRCo2PbsBFSk6T10L2OEl/E/NipE/dSLKs2s9ddbhneiaM/U8M0P 6gk6w5KNhIGBOS7rr6yiaT7eqSaZUbwezIyPS9gEKRAUWthxiHUFq+qCsOSeM5D9d+i8LAgrY6N PiY9pjdgHQGjYKMtytPkhjQc4qCd23rEOG08SCtBNZLN0tSG8F0K1TwPDgpdFw6kyJXnTuz03pv BhRbnV+eaYHbYVoPTMqE4wreBIUovsuCGszlQMhvLZdqjH/npbA51vqVW+QLJ38IgIG5znwFXJs NlcijtoAOGR1WY5R5iJ2hXoDhNw5fJ7sqfXKgG5MgOl4lCp+BUXN+BPuOdfUZVrmp5pcQTg26Ui Ds8Og/vPyycFSeP4SrBD5A9wP+QBKR0PTMzFCqiUI7jvGYxTbY0EJnQ6+yMxnoEdGE+ukcYFKaj i4JyjBtEC4= X-Received: by 2002:a05:7022:45aa:b0:11b:3eb7:f9d7 with SMTP id a92af1059eb24-127410150b1mr3534714c88.14.1771265519181; Mon, 16 Feb 2026 10:11:59 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:56 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , jay.buddhabhatti@amd.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, marco.crivellari@suse.com, michal.simek@amd.com Subject: [PATCH v3 15/15] drivers: firmware: xilinx: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:52 -0800 Message-ID: <20260216100943.v3.15.Ib15a93253dc4bf021c41036096b8e289702878ba@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/soc/xilinx/zynqmp_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_= power.c index 9085db1b480a..b4e751247a35 100644 --- a/drivers/soc/xilinx/zynqmp_power.c +++ b/drivers/soc/xilinx/zynqmp_power.c @@ -144,7 +144,7 @@ static void ipi_receive_callback(struct mbox_client *cl= , void *data) &zynqmp_pm_init_suspend_work->callback_work); =20 /* Send NULL message to mbox controller to ack the message */ - ret =3D mbox_send_message(rx_chan, NULL); + ret =3D mbox_ring_doorbell(rx_chan); if (ret) pr_err("IPI ack failed. Error %d\n", ret); } --=20 2.53.0.273.g2a3d683680-goog