From nobody Thu Mar 5 08:43:18 2026 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 359EE1FF61E for ; Mon, 16 Feb 2026 16:45:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771260326; cv=none; b=b8X+BoZAMvXbn7V/QZPmF1wBwK+Sf4LegIHa+qT3R/ki7Sq9aytHV3XrFjSpp9wNPTxZyfUWxm8kBt/jXz4lHpa85bAHNbeP2qnG6eQOhQosd6MxxyrWt0T7eDMACazkudGuZu5kl5UvU7PkljHP+0Vali7pK53tNCYVSzVHSvI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771260326; c=relaxed/simple; bh=RB2jit2OJuLb34gSBjCz0pp35sTxAuapkpuOBwhIXk8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uxX0Lm6q7tUAgYJpYq8zxnLGI7BwWEW3rRVh5rgQcD/UaWyA2Wf9qL7zb+MTPzeJm40eK7uIRqVvhB3E+rT2IRHj7XNEPzYLu0wAIovU4OeMfceuHhJSIyFVnZdcH1f/flRWreADRW3lJmE30c2MYOo5ZujjHeNORHEXeq4RVno= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z8OJv8dO; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z8OJv8dO" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b8f8d9b2c50so27319466b.1 for ; Mon, 16 Feb 2026 08:45:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771260323; x=1771865123; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CU4lePUCCJ3xj5OwOvFkst/VeREzzL5189XbX5ib9YU=; b=Z8OJv8dOX7+2jDtlQ0hAdhv5Aql9L6s9uGyM6KQgxK1pbhOWkjdNZP3GU6POjRi67Y W9yMnl6dVglgRKFlVuihg1xFU91/kAGv90ZNNIZlgdvB1igVRTr7ih6ZiWMnkoDYVdpA HAQeNdCO0HYrsWeDB0uDX/vvGW5D1Oa8npx+nDHDwny4NJwmTwXDcDXYyn86+vPSNtKX Arkkwvt68OyM4BsNPsCkYNPV62Ov0TNcYe0a1DnuN6I7kT5ocUEhpFEykcaRhka9JjYG APZd7w48sxNuX7T64vRKxMSr5mr63ia9cD5TPIWVm0i1DSxJUKIXPQNpvtb1fxhF9gQ6 pCeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771260323; x=1771865123; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CU4lePUCCJ3xj5OwOvFkst/VeREzzL5189XbX5ib9YU=; b=wZW4BW4QzvZe4RDL3C1MIcEClab7j1eniO3c4PgaYhbuNZV7IL+uhEzy//TaP+UmbW Yn8gdyx1cqwwsy5fV3fEDYOShVJ1U5dQh29scIlL8Vu8JBo1GXpd9vutZlm4Uh3Cwd/q iSqam2c/NgJL5uI0cglp/96NylgP+dOAW7pedldKKO8JH+RoieAMo4XuRV3A6Jbb7fn0 xDyaw1On6E3Ej82M7qwBbTMw56EHtv4552hRlS6d5RDV5siI3AEHmdWXO24K9WSI9t+2 /D4WMi4heJ9Vdft673g3DiQBYdsVRYtJimiq1csYxvdSNDQ3OB2S7CIcoTrDUTXgsIxm E4Ew== X-Forwarded-Encrypted: i=1; AJvYcCUDfxaugUMV9UzQc+M8JH7ekGvpznxXkXVNGoNRt4Wm26NiIm4LECFBe2SvWZJWEB4g4I/sVctRwtkNqL8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywy+4TLxt8Ob3Up+LBmYuKzeBEPJko6oT4hy1uLA8jyU5eXepiY Iodwq9YyPKpWBgiZ3IfXbouSDonlJRN4JDEOt0RCtGM/xePyJCsiQK4M X-Gm-Gg: AZuq6aL4omqu5t1vSEftK9l0InZh24MbrDADJIx0c9fpyWfYpadn72W62Nqq6YNHhq+ wWkd+AVa0vHl8TxcQycnpRAvyqIatQFgCuuYbhZPuQlEfpgXVD+1/EpYVcvDI+fadV5n1hfdGKw 4LrgYige/LPk8LW2WVv0a8uLR03yedeOrfpkE/yMwfR9lcA92CFtAc54Fkk8zCAhSE2VGn5gia3 MrNAzIs2U25AnAzmtF9RPvjLqhW08mwkaZCEKu6Y0beieDbBcUSoOizHWCDFSF4fKOl2XbEjW+E uncS78Z1O/dym4fRZJ9jL0hSxRqLzoq95SNg6RQq9AVZDn2Qu7x0VD9oN+7llYopQ9kGrSpVFB3 k6KLoF3Lo/Ot0IhBgg2Z15UPJfgICndEWUw8tZKBwM0h2fEjkFK34msLiKFjmaf1r3wSrxRavDo wrb2kPaxyMmA/HKY1nA3pX1RmO/HmFLCYyT7hR9qLElksvKR8ldj1HiW2oLiZmtLgfioIZujSDc BMk X-Received: by 2002:a17:906:c108:b0:b8e:9ac2:9e0d with SMTP id a640c23a62f3a-b8face3fd6fmr326171166b.8.1771260323206; Mon, 16 Feb 2026 08:45:23 -0800 (PST) Received: from laptok.lan (87-205-5-123.static.ip.netia.com.pl. [87.205.5.123]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc735d185sm264683866b.14.2026.02.16.08.45.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 08:45:22 -0800 (PST) From: =?UTF-8?q?Tomasz=20Paku=C5=82a?= To: alexander.deucher@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, siqueira@igalia.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, tomasz.pakula.oficjalny@gmail.com, bernhard.berger@gmail.com, michel.daenzer@mailbox.org, daniel@fooishbar.org Subject: [PATCH v4 03/27] drm/amd/display: Remove redundant edid checks Date: Mon, 16 Feb 2026 17:44:52 +0100 Message-ID: <20260216164516.36803-4-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260216164516.36803-1-tomasz.pakula.oficjalny@gmail.com> References: <20260216164516.36803-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable [Why] Edid parsing functions check if edid is not null themselves. In a case where edid is not present, the structs will be left initialised to 0 so anu possible assigment won't change the detected (or undetected) functionality. [How] Remove edid pointer checks Signed-off-by: Tomasz Paku=C5=82a --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 6218ad911fde..903264b26d1f 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -13330,8 +13330,8 @@ void amdgpu_dm_update_freesync_caps(struct drm_conn= ector *connector, if (is_monitor_range_invalid(connector)) parse_edid_displayid_vrr(connector, edid); =20 - if (edid && (sink->sink_signal =3D=3D SIGNAL_TYPE_DISPLAY_PORT || - sink->sink_signal =3D=3D SIGNAL_TYPE_EDP)) { + if (sink->sink_signal =3D=3D SIGNAL_TYPE_DISPLAY_PORT || + sink->sink_signal =3D=3D SIGNAL_TYPE_EDP) { =20 if (dpcd_caps.allow_invalid_MSA_timing_param) freesync_capable =3D copy_range_to_amdgpu_connector(connector); @@ -13344,8 +13344,7 @@ void amdgpu_dm_update_freesync_caps(struct drm_conn= ector *connector, amdgpu_dm_connector->as_type =3D ADAPTIVE_SYNC_TYPE_EDP; } =20 - } else if (sink->sink_signal =3D=3D SIGNAL_TYPE_HDMI_TYPE_A && - drm_edid) { + } else if (sink->sink_signal =3D=3D SIGNAL_TYPE_HDMI_TYPE_A) { parse_amd_vsdb_cea(amdgpu_dm_connector, edid, &vsdb_info); if (vsdb_info.freesync_supported) { monitor_range_from_vsdb(&connector->display_info, &vsdb_info); @@ -13356,7 +13355,7 @@ void amdgpu_dm_update_freesync_caps(struct drm_conn= ector *connector, if (amdgpu_dm_connector->dc_link) as_type =3D dm_get_adaptive_sync_support_type(amdgpu_dm_connector->dc_li= nk); =20 - if (as_type =3D=3D FREESYNC_TYPE_PCON_IN_WHITELIST && drm_edid) { + if (as_type =3D=3D FREESYNC_TYPE_PCON_IN_WHITELIST) { parse_amd_vsdb_cea(amdgpu_dm_connector, edid, &vsdb_info); if (vsdb_info.freesync_supported) { amdgpu_dm_connector->pack_sdp_v1_3 =3D true; --=20 2.53.0