From nobody Fri Apr 3 01:31:23 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CBF93112BC for ; Mon, 16 Feb 2026 14:25:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771251936; cv=none; b=KPS12giMlj5G2zgk3YU59WFe1l4ttwnG3tluLO+/2AsoVpU0xqQpET8kPhZy2fdZA1U97KOL+IISWGRxXO6myxzZQZwZFeZj4Y0gBQwqFd3PjGM8HITzzHbFNqIWOCUfH/hvl1qod5xV+qynUiywqpbHwHLO4ag7y3LTiN5WnZs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771251936; c=relaxed/simple; bh=rZ1cI02ZyGsF5YC4P0LfQX97Kl0v9+FZ0eOX8dFmAtk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bCHSjgyFR1L2Zt6sg30XVB9TVT86czkUn7agCR6foTaVLVfCuCxY1rtIK1Hq8lrCWm+KYW/zpwSb5LggOTBt3Y3e2FtBSi74zboWzz3H+TnN7NBtirNPhSvqyoNLikg7Zz317ojAnfqtOCfj2G3YKoLlh9OHxO1979bciAA/tL4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lEBiKWIe; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lEBiKWIe" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-483708b697cso3118675e9.3 for ; Mon, 16 Feb 2026 06:25:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771251934; x=1771856734; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XaRMBbsVUDPXG0cpvkwkXzPiYYVpsnTMm43yQAxsAgY=; b=lEBiKWIeuO4gYZCAYmclIi5F3ikaZylno8cIeeVEMSeIV/t++SoldQA25wZCDnopIg j9gMBbIQFJIz4ZD5QyssJHi+zD88a17rjfTXbTp3SgkfK9XAsUIJSRf4FMEVQOWgXrnp Hb8xqh3lZ7MX3O+/m0v9Q3B2T3nLdpIUIEgg8NATNMBOPcgmvHhb4Q6BF6W8OmtmGVWS 9GshuDiJbiFBvhldEaLxLjG5jMP7Z6JdTlIHQp0lK1dyHj1w8TYuDnhqAM4JSvqzJ/Wd oXMe+xWfnI3RTk6kgA3U/l2GmMohmJ9Xbf/wPm9TEKFF6/EjCnyZhAZdK5ug2uRVIWoV r49w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771251934; x=1771856734; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XaRMBbsVUDPXG0cpvkwkXzPiYYVpsnTMm43yQAxsAgY=; b=BGEu/NUEp2G+zee9rgtntcq4NGAQEl3Pn79OspHTJzBdExGFNbwzC3ZiBCxuPGl7FI hfknuIBHCTNoVQMK5fMSb291AexnwOdtp1t4wdg3UV/DHejKh7DJyLC7Qg3HpESFvjJM 4LYMbsyQf6ceYyZgAKvD2dsWzRT7SQlfpebVvtaBNJiEHw9WUGQmFxnQAbV9f6SNJs3m FVlZjUhaxO8dcf/3DSam14haH2PPx9Df39EIO0DkUqGdUplGLIWisUbZJLyY1Q9iIWsZ SOXU8aLJ1OhkZdPdAo4VE2GKoUXdTDD3zCY3zKztVr+ln3hzTTtX8NCkX98BsTfRdp4f 4Spw== X-Forwarded-Encrypted: i=1; AJvYcCVniG+lSMUwTcEAALNdvPoqOkNX8GoL5u6uG5KTTvGOnbUE4NlCMjIleiPQpOiXqjJlAspfgoaweCOEzQg=@vger.kernel.org X-Gm-Message-State: AOJu0YwSETijLbrX3zvclkBu4oWGJsgZdT5S282sgYLr7YH7AnVGUkss 3vS40K8k9Ys5Zk8MWMfYPpO7eiuklCiIq76cgX5HJ7rE03GeG9O3aJc7 X-Gm-Gg: AZuq6aK5hoG6onlj3euDmYiYb5xDLY+CY0RWFx6TOZAJaw3tASl1dO9dOAze1F11aim lTVhrFUb2m4wKCgztl27GW6mIZgfKxPWkQ49Te7tl34DwvmHYFcFsTKCLDw2kc2X2KqRb4Bt14n Pv6sTO1yp6CnGgUwmGBzMSp9yuYTMcJn7B9mv/elK9NML+JsZh9rPdtb7tZaM97vSiPwHObGKrb hJSUXhmpHx6qAgJClzmqsA6LI4jwOluDzmqR2hW0esPAIyMXPb2GZY446eKYasbDAdrhLaT3oJY V2zuEpJrr0rpMRWwemr3+pHR0aV5sFyy1dPShJT3JycVLjRbatIxYib+e+94nWiWY+CND27hsw2 +eLkIx+jYUFqqlV2OyZfhocFP0PW9ETxaFcebbqLte6KPQmShzfEj/LmS1ZIbSUxktuW1iHOIms 7BzfzsAbkjg3DHa6i06pRJsv+stf8vYHcDvFUcXDYIldYCA3NJCZQMyKU7G/4OOCm0dc4KKiYIr g8+3haAv3HKurdX/hurGa3VkDy9fTU= X-Received: by 2002:a05:600c:190c:b0:47e:e20e:bbbc with SMTP id 5b1f17b1804b1-48370e2b589mr122893065e9.1.1771251933297; Mon, 16 Feb 2026 06:25:33 -0800 (PST) Received: from thomas-precision3591.paris.inria.fr (wifi-pro-82-204.paris.inria.fr. [128.93.82.204]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4835dd0e327sm434486105e9.14.2026.02.16.06.25.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 06:25:32 -0800 (PST) From: Thomas Fourier To: Cc: Thomas Fourier , Karan Tilak Kumar , Sesidhar Baddela , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: snic: Remove unused linkstatus Date: Mon, 16 Feb 2026 15:10:55 +0100 Message-ID: <20260216141056.59429-2-fourier.thomas@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The (struct vnic_dev).linkstatus buffer is freed in svnic_dev_unregister() and referenced in svnic_dev_link_status() but never alloc'd. This means (struct vnic_dev).linkstatus is always null and the dealloc the reference in svnic_dev_link_status() is dead code. Signed-off-by: Thomas Fourier --- drivers/scsi/snic/vnic_dev.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/scsi/snic/vnic_dev.c b/drivers/scsi/snic/vnic_dev.c index 760f3f22095c..c4df0b17c86c 100644 --- a/drivers/scsi/snic/vnic_dev.c +++ b/drivers/scsi/snic/vnic_dev.c @@ -42,8 +42,6 @@ struct vnic_dev { struct vnic_devcmd_notify *notify; struct vnic_devcmd_notify notify_copy; dma_addr_t notify_pa; - u32 *linkstatus; - dma_addr_t linkstatus_pa; struct vnic_stats *stats; dma_addr_t stats_pa; struct vnic_devcmd_fw_info *fw_info; @@ -650,8 +648,6 @@ int svnic_dev_init(struct vnic_dev *vdev, int arg) =20 int svnic_dev_link_status(struct vnic_dev *vdev) { - if (vdev->linkstatus) - return *vdev->linkstatus; =20 if (!vnic_dev_notify_ready(vdev)) return 0; @@ -686,11 +682,6 @@ void svnic_dev_unregister(struct vnic_dev *vdev) sizeof(struct vnic_devcmd_notify), vdev->notify, vdev->notify_pa); - if (vdev->linkstatus) - dma_free_coherent(&vdev->pdev->dev, - sizeof(u32), - vdev->linkstatus, - vdev->linkstatus_pa); if (vdev->stats) dma_free_coherent(&vdev->pdev->dev, sizeof(struct vnic_stats), --=20 2.43.0