From nobody Thu Mar 19 02:05:46 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CC4717ADE0 for ; Mon, 16 Feb 2026 13:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771249611; cv=none; b=lliBVr+5WLqhFRONqMW9/NSAddKarkjWMIrzjlbAzbtdjN2ECkdfsIrly6LjJ/X0rPNwXJt4xB7cEJfEdSezPa89t05sdWiPxRiZrhfe2CEKuKuHyCgTYx4k0WlEvaacMMPX6iaIHRvxEdEW4BLGwS8UpKsugcKTxhk7Xn1wIt8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771249611; c=relaxed/simple; bh=vPwDF8MJNcnBiZWSZeHRapffZWJMtIipr0elh3nylZ8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=bMLIM/Jn957tuMQfyMQ9tCPnWYnzTg6daa8l7/dTfENQQHSwipYEoDCXXG5XbJT/KDHGuLxaZ20NKftq+ytNUjzpkGGSOOAEbd7GSxmWu2h9mWYxPC+5WjVSkbd87pgrBp8EgSy7M8zUFTmm9bCuIcKWIkV0Nyzo8DHrI9f5yLM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gTKHCro2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gTKHCro2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D363EC116C6; Mon, 16 Feb 2026 13:46:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771249611; bh=vPwDF8MJNcnBiZWSZeHRapffZWJMtIipr0elh3nylZ8=; h=From:To:Cc:Subject:Date:From; b=gTKHCro2ySCTBE65L2zWi/J5LKjehFb3/zYpWaoC8o1AOO4Svv9Pzf+ZfqIDjR0rh xb6ayqBaO/7KT90X51Pl64yB9B9pFF+r+uEsdBZJd22d3bgoZwbz5I4shiyumR/7VO NRWiDvX90GX2Rx1qSeNgl3OKiz2lYRA6LvG30DVVaQefGEpDIfTltO8ocVkpRBZhOn Eb1MhWtmKqTG3snvY/F4u5VPOz6jGBQ56JwgjaCIXrb782ODPFJP9bY5NrudXkC2b6 aqcynndEbp7LQtq2+LuoDPBh4bkPSWOGvNRcRRvMSLXMArXmh/SyJZzW3TBUJBKB0T Ne8xP+MQh5/Xg== From: Arnd Bergmann To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthew Brost , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Rodrigo Vivi Cc: Arnd Bergmann , Himal Prasad Ghimiray , Lucas De Marchi , Matthew Auld , Francois Dugast , Andrew Morton , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org Subject: [PATCH] [v2] drm/pagemap: pass pagemap_addr by reference Date: Mon, 16 Feb 2026 14:46:01 +0100 Message-Id: <20260216134644.1025365-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann Passing a structure by value into a function is sometimes problematic, for a number of reasons. Of of these is a warning from the 32-bit arm compiler: drivers/gpu/drm/drm_gpusvm.c: In function '__drm_gpusvm_unmap_pages': drivers/gpu/drm/drm_gpusvm.c:1152:33: note: parameter passing for argument = of type 'struct drm_pagemap_addr' changed in GCC 9.1 1152 | dpagemap->ops->device_unmap(dpagema= p, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~ 1153 | dev, *a= ddr); | ~~~~~~~= ~~~~ This particular problem is harmless since we are not mixing compiler versio= ns inside of the compiler. However, passing this by reference avoids the warni= ng along with providing slightly better calling conventions as it avoids an extra copy on the stack. Signed-off-by: Arnd Bergmann Reviewed-by: Thomas Hellstr=C3=B6m --- drivers/gpu/drm/drm_gpusvm.c | 2 +- drivers/gpu/drm/drm_pagemap.c | 2 +- drivers/gpu/drm/xe/xe_svm.c | 8 ++++---- include/drm/drm_pagemap.h | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_gpusvm.c b/drivers/gpu/drm/drm_gpusvm.c index c25f50cad6fe..81626b00b755 100644 --- a/drivers/gpu/drm/drm_gpusvm.c +++ b/drivers/gpu/drm/drm_gpusvm.c @@ -1150,7 +1150,7 @@ static void __drm_gpusvm_unmap_pages(struct drm_gpusv= m *gpusvm, addr->dir); else if (dpagemap && dpagemap->ops->device_unmap) dpagemap->ops->device_unmap(dpagemap, - dev, *addr); + dev, addr); i +=3D 1 << addr->order; } =20 diff --git a/drivers/gpu/drm/drm_pagemap.c b/drivers/gpu/drm/drm_pagemap.c index d0041c947a28..22579806c055 100644 --- a/drivers/gpu/drm/drm_pagemap.c +++ b/drivers/gpu/drm/drm_pagemap.c @@ -318,7 +318,7 @@ static void drm_pagemap_migrate_unmap_pages(struct devi= ce *dev, struct drm_pagemap_zdd *zdd =3D page->zone_device_data; struct drm_pagemap *dpagemap =3D zdd->dpagemap; =20 - dpagemap->ops->device_unmap(dpagemap, dev, pagemap_addr[i]); + dpagemap->ops->device_unmap(dpagemap, dev, &pagemap_addr[i]); } else { dma_unmap_page(dev, pagemap_addr[i].addr, PAGE_SIZE << pagemap_addr[i].order, dir); diff --git a/drivers/gpu/drm/xe/xe_svm.c b/drivers/gpu/drm/xe/xe_svm.c index 213f0334518a..78f4b2c60670 100644 --- a/drivers/gpu/drm/xe/xe_svm.c +++ b/drivers/gpu/drm/xe/xe_svm.c @@ -1676,13 +1676,13 @@ xe_drm_pagemap_device_map(struct drm_pagemap *dpage= map, =20 static void xe_drm_pagemap_device_unmap(struct drm_pagemap *dpagemap, struct device *dev, - struct drm_pagemap_addr addr) + const struct drm_pagemap_addr *addr) { - if (addr.proto !=3D XE_INTERCONNECT_P2P) + if (addr->proto !=3D XE_INTERCONNECT_P2P) return; =20 - dma_unmap_resource(dev, addr.addr, PAGE_SIZE << addr.order, - addr.dir, DMA_ATTR_SKIP_CPU_SYNC); + dma_unmap_resource(dev, addr->addr, PAGE_SIZE << addr->order, + addr->dir, DMA_ATTR_SKIP_CPU_SYNC); } =20 static void xe_pagemap_destroy_work(struct work_struct *work) diff --git a/include/drm/drm_pagemap.h b/include/drm/drm_pagemap.h index 2baf0861f78f..c848f578e3da 100644 --- a/include/drm/drm_pagemap.h +++ b/include/drm/drm_pagemap.h @@ -95,7 +95,7 @@ struct drm_pagemap_ops { */ void (*device_unmap)(struct drm_pagemap *dpagemap, struct device *dev, - struct drm_pagemap_addr addr); + const struct drm_pagemap_addr *addr); =20 /** * @populate_mm: Populate part of the mm with @dpagemap memory, --=20 2.39.5