From nobody Thu Mar 19 03:45:10 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0038430E0EF for ; Mon, 16 Feb 2026 13:43:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771249394; cv=none; b=lIEPqwgOmMRj2CbYUKrlCQogmoQeZ6btz44X2TdnbX4Lg8hmfK697Q57UOt/NxLhBFHV49vk2EWAEuqGomEBgbPMVaGikmEIceiQqoyKPhZ3PwrXWKcCvdNS3oSIu32NzPYDjZHDjQB8eexYOLyOsh/3otM3p5WFliS4rVvQaM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771249394; c=relaxed/simple; bh=KJwpMUhbsmLePIcgVFzyOrsUa+2IV8OxHWYQmxoWDOg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oZoo8fzH+yYiXZCSO64noiHHVb3fD35HbOUhfMB+I+Oq1T24hhUKNUIG1d7uSzUIE5cRL062o8IpICYtQInzN/L9blla3/LzMOaNamJ8mFPXHmCRFXjD/dUlUdrEVuRG/9dVTxGmRZudJfL5j5h2Sq4dBiKd7JWxhWcOgNSTN34= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=QOpxNdVb; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="QOpxNdVb" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-43945763558so841190f8f.3 for ; Mon, 16 Feb 2026 05:43:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1771249390; x=1771854190; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1JPwPVqvwveog74YxYE5rN1bA4FdwdVXGOb+2Uf2Xb8=; b=QOpxNdVbj8MxSnNobKMQ/91aGC1Z0kuk6juLfzjxbJQ7jq15zRmXvvsOz9t66SdBmM QfY81C4qUMiL1sI9vb6Dpr7izIrdMfWv+u7UJVqvdyyXgUxsTQICT8JsPKuXVDuekXUT xZUS/RcHm9Ok0fRpqL+XwBxe6Pme/iy6BZ3hrH6m4SwJnzmZhXFarQJ1tc7zcaV2mACV 8NXXGt5TBYlR2zaqnVG1bkTTjYXWwXa6x1aowAJc0gVgGXatKRiDir5ogQYe1hK6aY+a 5/Ry2YAk8fMR6vtS1Fm2JTgDPBR+hr8uuRjP3CLE0IHyn78LdfRw6T60QSfZgLAWMh43 NN2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771249390; x=1771854190; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1JPwPVqvwveog74YxYE5rN1bA4FdwdVXGOb+2Uf2Xb8=; b=F67dbPngozE1cfgrf83GI6BCBmvuD1xPli7KuZc4awxZRhcYaBut42YKmyGywENUgS U/FhGfbAhZRdAqWUS57GKzo6kmTxRxotGmh+qIDJqeQ+CJ/dlLfbmnujVk6tWGMCsjqa 6P+nDQsl77KAFapufjL4ZeE7rJjUtcR/PusoAPlGn1uj0v/+6S8QRZfrXMsUFIF6m7w/ npDdw15aNu6WIBtqxUp4nKsBye6NeYSCo8SeIrl6oYjIMsxCaQGWh+8K5OWw2HIdD27J xZXb+xsJzpy7ETTy/4MxkUD8u24eP8oxOeFt0BugKwHb32LewVEZAKPD1LejcYpU76Xn AYtg== X-Forwarded-Encrypted: i=1; AJvYcCWjjMzsf5wvNFy1r8tA2zszbLmMeslgTmOmp7KhL1yZaB3tiZ9NExjJP1MzMvgEh8HlML78kvmmcvILYUc=@vger.kernel.org X-Gm-Message-State: AOJu0YzroxYtEzQAShSwXNQSABgFaKU5vOLb53qij79wzXbcRYZKI7rX tZgnuPk06JQI48pYsMVBD0PaqnQQUASwvrzrNdBmaCU4qj+0GCg0mJN8SJ0SQ7tojHc= X-Gm-Gg: AZuq6aJtnaSf5kOXOw1L2nyCvKhLcSUbog0QN4V0AnIM/BzWrNpMd3DYNXh8+FGlBtc HPI1oEPtARI7s4rb0E6TyA+HuKi1GbdWQ2jasdInv6MrCLg3MMEtWnPn4DOsBYcriGXYhqoYV9Y QjiO3cTv3+IVXXBONi8KEdYED3KvclM4nrxWmjQoG08zqECOPsB65yWUjVpBNB8/m9CZuKNuQDC pGanBzShA+bgNYUgUJMvFBQZI9mf+HbNWzuh9c0Xy5BTc5vMAGiBMuMAeNGz8bmSZqEjOQBhsNB 4C629ziRT3IGymn+bUqkTECnsMkQ4VULiDsAYCg9gpV2OqslNUjej5pFXEraF6sPcEzckteRWDH Y8Zw3kCE3S1vrO/Rr9nlRX9Qo+aspOLJKmPE/oVhknkpvrfZrJze/bLctoVr1cO/aD5VNIEQk5v dKCurPOgKOY4zuusEOi5IhXF9e3r2UDLyzJPEnjGEq X-Received: by 2002:a05:6000:2382:b0:437:719d:a740 with SMTP id ffacd0b85a97d-43796af9f04mr18671659f8f.49.1771249390407; Mon, 16 Feb 2026 05:43:10 -0800 (PST) Received: from zovi.suse.cz (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796a6ba57sm22103738f8f.15.2026.02.16.05.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 05:43:10 -0800 (PST) From: Petr Pavlu To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , Tom Zanussi , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Petr Pavlu Subject: [PATCH v2 2/4] tracing: Remove unnecessary check for EVENT_FILE_FL_FREED Date: Mon, 16 Feb 2026 14:41:58 +0100 Message-ID: <20260216134247.1311631-3-petr.pavlu@suse.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260216134247.1311631-1-petr.pavlu@suse.com> References: <20260216134247.1311631-1-petr.pavlu@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The event_filter_write() function calls event_file_file() to retrieve a trace_event_file associated with a given file struct. If a non-NULL pointer is returned, the function then checks whether the trace_event_file instance has the EVENT_FILE_FL_FREED flag set. This check is redundant because event_file_file() already performs this validation and returns NULL if the flag is set. The err value is also already initialized to -ENODEV. Remove the unnecessary check for EVENT_FILE_FL_FREED in event_filter_write(). Signed-off-by: Petr Pavlu --- kernel/trace/trace_events.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index e8ed6ba155cf..2ca76b048638 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -2153,12 +2153,8 @@ event_filter_write(struct file *filp, const char __u= ser *ubuf, size_t cnt, =20 mutex_lock(&event_mutex); file =3D event_file_file(filp); - if (file) { - if (file->flags & EVENT_FILE_FL_FREED) - err =3D -ENODEV; - else - err =3D apply_event_filter(file, buf); - } + if (file) + err =3D apply_event_filter(file, buf); mutex_unlock(&event_mutex); =20 kfree(buf); --=20 2.52.0