From nobody Thu Mar 5 08:15:55 2026 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7602D2E92BC for ; Mon, 16 Feb 2026 18:11:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265504; cv=none; b=mxy+fVcipMV076ilEKb6jYNCfSO4IYxBXtY7bkD8R8MJyUL6r1FiZ/ctgsxMpJCQRB0FwQNLncOLVCo7AA+gANu21w9Awhk0ZMOaJ3/6f4tWQB7YiMYeuOdLI+H7ZTifvkUMx/jmQlWCPglKRPsh7f+4UQE0jsatBTWmpt+43mQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265504; c=relaxed/simple; bh=1LwO0v04lIfnNg2Y8tO3ZD/AcNQmoxD04js80NYmaIw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r4l5MfeD/HghJo25iR6UwOzjB8PRRw5nupeq396s7ZECHpHDP6PWURniVvUtXMR9MDjO9jr2R5MLaLuse696U/7cOaH/u5meUFjRK5QQnbY9lCjnB0M37CUKjtFCYaqgZj/ASlUHIE93C2AMcBOXjRNBUz8VfSi93w1xffQmE2o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=cRYNPB1A; arc=none smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="cRYNPB1A" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-1248d27f2b9so4363579c88.0 for ; Mon, 16 Feb 2026 10:11:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265503; x=1771870303; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=McVpUeglzEgOwVzdcsjAkstJ2kz3KalaGrnYqtVtRLI=; b=cRYNPB1APEtIU0So2QDoKNkCQS7tQJDs6p2bpeoyGHMRLTksWAeITTEYb7lLWGSUFB 0Io7r2sAI7XCxnvEO4PkS6uaauR4sEEAs0DteGoylzPCkA6GDp5d4SrUK/kzM0CkaaN3 x/l8gpLZ9hstQZsE9EqlFyC64odw1/Gt2cSsU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265503; x=1771870303; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=McVpUeglzEgOwVzdcsjAkstJ2kz3KalaGrnYqtVtRLI=; b=nJuVRMYPkdyVDBvsApBBSz3H59soAIH/gv0QuiVkeYoOImo/erFzUjKITO7jXQ4yqc F5HW1KGr3/Rr8ViilNr7GAgA/byLvsOxqPOKRXcLgfsQund85uuJFIjlxztt/LpbtoZS YHoFRJOrVEgQ8rtYEPEopteVAGAIxrAWmARpouS0+eMI4etUUgEEEzdPhRzXeolFJ3/O gtojlk0RRhVhnBOfq8CrAYXbs1oa2xNyUWn/vEYBfPCcMVKt8gJkcZ1ARxVcdKlBgDin OgImfa1l/bnGmFZdvu/N5E/4kLZfY0/nFAz9GCZnElaRN/WQZ8V/+QpXJare1/ZZEWky WGhg== X-Forwarded-Encrypted: i=1; AJvYcCUkpQSw+ABMQ2OxIJMeQwahlxkU06LMKmkoxmEAGQrmlMQDFhlTIP0Zj6gPzJNwqTlCu6ZvtsIEy+vqiaM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzvb8h0Vh8B4k45Lw3kfvweh49A4lgTqsHlD4rsN+uGGBCiTziL UyYFwVegv4UZxAWEapy0V0Om7mXWbX4m8HWbVh3XWglh2w91mVNqrbV+uNV4H1WRnA== X-Gm-Gg: AZuq6aICEBO0YC0/aYM0ZwaoklrIqjDUVL5j9cGp0s72PFhYeLFUFOeVwoA8gS85dIx INXBBfMGfVsyWZeOAIxdgkjmduU3BB5AYsW+DKIr5hiL638ajYe+vgA7QloCQZlyjtXNWwYWeyx vzq97WfJgo8n8+wXgq7aIWkMHBtVHswnzIojuLIg+rPO50Xhsfq8STfLz7gcpgVpKGnJVf91Dtv hreYqeLXHPRGFjdHXCTNHly24txKb3OIYHRusoqfv/zMYKumeimuE/wReT4paKLWF1pR9DlZt7m WI7L7WhU+zdlrzaDTaC6kSFtLHnX2zhx+GvifyDxaSO1zGP+PQtoZdtAIO1danDxg1hVnY9wJ9o XOGRnlIS0ThzTi+X80va9obT8bsatVfWVdZ2r0inXRRWh34WkYC8X1MlzhjrOnMAEF01wQht4Zj 4ypJASpKtSwyzo/9y3yNe6Ym2DHAA8hG6Y6MzgRDDRPvw7Pq36qU/YimVitxbvsfmslWOd8qJ5O qhuGwzBp70= X-Received: by 2002:a05:7022:160a:b0:122:2f4:b251 with SMTP id a92af1059eb24-127397bf3femr5004979c88.21.1771265502576; Mon, 16 Feb 2026 10:11:42 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:41 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH v3 09/15] rpmsg: glink: smem: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:46 -0800 Message-ID: <20260216100943.v3.9.I6973a32c3fcd6d2edebdd6fd868fe0a046420ed5@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Acked-by: Bjorn Andersson Signed-off-by: Douglas Anderson --- This driver is used on my sc7180-trogdor Chromebook. While I haven't stress tested with it, I can confirm that the system boots normally to UI and can suspend/resume with this patch in place. (no changes since v1) drivers/rpmsg/qcom_glink_smem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_sme= m.c index 7a982c60a8dd..f2a6d94e72ea 100644 --- a/drivers/rpmsg/qcom_glink_smem.c +++ b/drivers/rpmsg/qcom_glink_smem.c @@ -197,8 +197,7 @@ static void glink_smem_tx_kick(struct qcom_glink_pipe *= glink_pipe) struct glink_smem_pipe *pipe =3D to_smem_pipe(glink_pipe); struct qcom_glink_smem *smem =3D pipe->smem; =20 - mbox_send_message(smem->mbox_chan, NULL); - mbox_client_txdone(smem->mbox_chan, 0); + mbox_ring_doorbell(smem->mbox_chan); } =20 static irqreturn_t qcom_glink_smem_intr(int irq, void *data) --=20 2.53.0.273.g2a3d683680-goog