From nobody Thu Mar 5 08:50:24 2026 Received: from mail-dl1-f53.google.com (mail-dl1-f53.google.com [74.125.82.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A41C32DAFB5 for ; Mon, 16 Feb 2026 18:11:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265488; cv=none; b=XDCpI+WFwnhJ+4ZXbq51/ybwNnCnB5PSDFD9OoqW8QrO7KDLm4uWFlsqV7FhzED8/EovdUd2tV63L6wNf/OlehW1hbnVqH8gYptv22K1Oh5D3xgvNuqiZFMJ8pJkhGkNZm3H5CsCit/WUZwPAAVCBVkH81f5km3CmKgTv0OFhCI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265488; c=relaxed/simple; bh=T9138cDwn+QZwBFaC6QbDa1VBT/f3YEeuN2KjrVKfhQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Jnz/cNbaiVCNb+M/fGh1agWJhrdJmyV+ProLaQpVgnWIKH7YSS5z274gQBenSjoe8CjjBuieglh1Wk+MzWsH8+IE6cEU32SULd4w2G932l0wf98/nLzZfbeXDpFrZiQiKX3QgJGeCcYQ2cO1qpjg/aBJUUzdI7xTniYF6qC8utU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=jdjDdybT; arc=none smtp.client-ip=74.125.82.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jdjDdybT" Received: by mail-dl1-f53.google.com with SMTP id a92af1059eb24-12721cd256bso4209961c88.1 for ; Mon, 16 Feb 2026 10:11:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265486; x=1771870286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/jhin/02GFgkWCuBO/6cY6fZT+lc+CgTrHw88Ws4rz8=; b=jdjDdybTjFsZxPPaz7naIvRFI0gEe52F3eQgLyLPjcoJBYbA8ArgdiX15fH8yvco4c pi0D9Szb6bwFmPDEjRAZZ9O6TSaDmhQ9CP9ABFQaElb4+Sc0cL3Q9W8O7koxtOkyEqmU Ys7wrqvPL4LgsjqPUE/gux6tQOHZRpsI1e0p0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265486; x=1771870286; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/jhin/02GFgkWCuBO/6cY6fZT+lc+CgTrHw88Ws4rz8=; b=O6dTpXS3/yrtZJapdr98JEcADFaHv6cjd8eX8arvOccFNBvm+dWNG6aTf6DcVVb9hg nedL1I7mFhA59AgoNK8JbER1KWCXp58v9UFR7j9fwd8fgALrJiHxd246Uw9c3Xshx7o0 y5vTIlieM+bb/xeimDSInzBwSfPWj4IRGr1DQtx7ZtbPmYpjElVtnia20hPr4jCzsLwQ N/SPV1rKuv318SjzsvokoYx7w+/XJwkWy5+hmrbQp2haLoaojOIN+vT5tHpx3DK5Vrb/ oedfW1KVycjVu+bB/dXClpT8W29JxmbWzAk/FNv/oIzWKeT5SrcPJZsjMX6rXIaGVzkJ 9PZw== X-Forwarded-Encrypted: i=1; AJvYcCWW3pbPgkcb12Mxtv1LopNDIqQjM/s2Z2Gey1C1NyLuAfaHFhIZdm9NZ+j6aTS+pIzbUiIz7GNPQNvWIWY=@vger.kernel.org X-Gm-Message-State: AOJu0YxGkU6KdO+CgFBKyu3MCqSj12GEeF2zjUmP6W3XuGY/8C0oDPg2 SpMeaBh5gVJaJUi89SxbQ61he11zhEEp6fNzHWdhZ9mPxffHXtMMQKPcsjobGI/J9Q== X-Gm-Gg: AZuq6aKEIkdrPuAqPmHS3zIgr01FW518NloNuQUiuNFFaQHufRu0ylVWTNig8Rx1vYv wbI1JLNqAj706di4H3p8wpq+kKb8dn7lDdFFmEUNI9trOqAkbSZzoU/ZDmh9lGtRvdWqNw2rkej SGX1HJfzGKJcyY26ez58ZFP49jpaiKAJHfPNkWdudIGN5aSunu0pkQjV67rmLASx99BEmFduMAk i/UGu72EktEaWmHrA//DdPuhN44SNoTxSeK78PZ0xyWE/AR2mhzJWd2lHW/f9Le0WL8cU/uaQ56 X3KOLktf5LyPwJJ2Ba17tPKtylmCiP0PQaOqhwfIc7kHLC5pFpwTRKLHvqJV+k/3a8x+739iTPP C//ETZiVDHkApqLV1VJ6f9XKGrlgwyMy2jNoZHmkmfYqf7tZgq2F6/QTFbWACGe9ibZSPnY7Fxe ZaXyfRraYjxCZtOL+HKNmuM6FYEfwRgvKCVjVevEXKrqTI/Fqx1XYQZT3Rep4QhLNmCheDaxKng FCkyEKYCso= X-Received: by 2002:a05:7022:4389:b0:124:11af:7b42 with SMTP id a92af1059eb24-12741bd58e8mr4199049c88.33.1771265485799; Mon, 16 Feb 2026 10:11:25 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:24 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, rafael@kernel.org Subject: [PATCH v3 02/15] ACPI: PCC: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:39 -0800 Message-ID: <20260216100943.v3.2.Ibc0c2b7d0280f23aecade13c49dedc2bb7fdd7a2@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). From code inspection, it appears that this driver only ever sends NULL messages and thus the conversion is straightforward. The only change is to remove the call to mbox_chan_txdone(). The call wouldn't have done anything in the past anyway (since chan->active_req was NULL) but with doorbells it's officially documented to not be needed. Signed-off-by: Douglas Anderson --- Something seemed a little fishy in this code. The code seems to be a _client_ of a mailbox, yet it was calling mbox_chan_txdone() which is something mailbox _controllers_ are supposed to call when their "txdone" interrupt goes off. It appears that this client even reaches into the mailbox controller and confirms that `txdone_irq` is set, which should mean that the controller itself signals txdone. If the mailbox controller is actually signaling "txdone" it should ideally be improved to not do so for doorbell (NULL) messages, but it won't matter much for this client since we only ever send doorbells and don't care about the txdone callback. (no changes since v1) drivers/acpi/acpi_pcc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/acpi/acpi_pcc.c b/drivers/acpi/acpi_pcc.c index e3f302b9dee5..3d240ecd98f4 100644 --- a/drivers/acpi/acpi_pcc.c +++ b/drivers/acpi/acpi_pcc.c @@ -106,7 +106,7 @@ acpi_pcc_address_space_handler(u32 function, acpi_physi= cal_address addr, /* Write to Shared Memory */ memcpy_toio(data->pcc_chan->shmem, (void *)value, data->ctx.length); =20 - ret =3D mbox_send_message(data->pcc_chan->mchan, NULL); + ret =3D mbox_ring_doorbell(data->pcc_chan->mchan); if (ret < 0) return AE_ERROR; =20 @@ -123,8 +123,6 @@ acpi_pcc_address_space_handler(u32 function, acpi_physi= cal_address addr, return AE_TIME; } =20 - mbox_chan_txdone(data->pcc_chan->mchan, ret); - memcpy_fromio(value, data->pcc_chan->shmem, data->ctx.length); =20 return AE_OK; --=20 2.53.0.273.g2a3d683680-goog