From nobody Thu Mar 5 08:56:12 2026 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C51522EB841 for ; Mon, 16 Feb 2026 18:11:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265511; cv=none; b=pg/WurqSsTfvKIOVH4BYerc06NH9fC0cmIKZ9pR4t633ZxdcWwSKaMp/bU4srWpAOzDA9/fq7rD489fcLN47sLJt490lYWdNnKlzgKXvwK7vuwwamnDP+Rm25f8Q6PgHvIk3zXnTtDMh9wPGfGx8uVacGWnkIPkWAI7YBCUEVTA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265511; c=relaxed/simple; bh=HTSdkJk9l98H+40HfSCW5IdP+PKN8qaGfdBkjMVQkVE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NN5c4FGVaEXBC9zZogwbVijD9gfVBzUn3POQFoqih4J3oVSK2jy7TbviaKT8jOy6ryu6uVQdt9Pf4ySpvo9Amfd2gXj21jT50AC/CaMhe6eCp/Rm+gSNoyGSHhteTBZc5Rt69UqJn2G/YuuQg3tR5BcCMQmV+dnoD1QpijxkJzg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=T6IucpcW; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="T6IucpcW" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-1270adc5121so4507131c88.0 for ; Mon, 16 Feb 2026 10:11:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265510; x=1771870310; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oiI5aUOPqb58UplGIDNV8w8jAQukJhPp7ypbCHDoRdI=; b=T6IucpcWOJ2bmD/vR+S07/qhgTn7sjxirbmNw326SFulKmWvfLhke3C3G7Wfk2YcOy 1lLeNfweqsijgobNwbc+wbGhz4eFyAoPCctk7ZFvrtLibfp++RS/2wXQ6VePiTvThg0Q vZp8hxsq0FIPsv4S+t6Ajvx51v0DthQVIXAgA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265510; x=1771870310; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oiI5aUOPqb58UplGIDNV8w8jAQukJhPp7ypbCHDoRdI=; b=PKhkOJFYBE7OJFcLI1QHwdNChKIyR2+s3GBBa7DsROlY8eHfb+DWhLxyRHxG0X5yM4 fZLVouVDXX6c7ZoND/HI+Np09taFuaw9LNj/B6OyNJH0fK+mty8GAUdsjECBV6xZorLP sGDpsMkw9nxzhGVqXdzc2e7ePohMvkN2W/blS19a5IqYklaQbUYo7Rh/ZacWjJUntRJf ciC7nYFDE7WYolDRvXbBUDCHqPC55xm19vukH+ufa+nQbWWiEhIA+UmVOCA+l73U6tor a7y+2srbgih22VG4nFftv79YQ0BLrCXnlPPKaSU203XxnLitkVVRgu+wAokSM36+GgwB HGuw== X-Forwarded-Encrypted: i=1; AJvYcCVvfGvV1+5sO1bDRFTrBqX6Br5X0iG8oEBIw1AdTf1petd8E8fmVAZZIjBSwcdDz4B313+REUlizEz85fE=@vger.kernel.org X-Gm-Message-State: AOJu0YxLqv1J3d60d7TNXtpB6vqodAp8nTh54z+NNeA6NsY4QcbAtn2v ubaupKkiaTuAfUjPG5HaVC/pCDSOrUgQwGVaLx97VmefXvVjObPIELEte5/DFz0WZA== X-Gm-Gg: AZuq6aLHH+IsG5Z+xs0sjrhyyqpNt1X0L1ff3NguIu0L3MWgoVSwx0DMNKDw5N1nRwl 63ogvx6LLTc3jkfMgffzPYkEVb/BEJhXdJxJ0BQsmf/shkFRVb2JhHZ61G+FsRDLmprJjlvtCno RAQ/ol1xJZ5A0rbmSwM737Ed+MfGBNlmrH1gR8Zc03moV64E9XAvFF4Zm2Zx8HjnQaZlY+D/Ypu rBe6Tt7833Wwy2O5k1NcNnjcdxK4IhMAo9uHV1lRrzBVnne59DL15AaCLLTPW59RBwjp77iqs4I 7SyWuIEyIKCiz88hBSA7A0d+pWJKivXB10lldsgAYXX62vaIbKsCq/qj2IB4rZkDHjdxvM+1sRi ChP8PSQSkEXG4z6FAlohxBDuZYylu8OwThl+ynjwRRL6bmWKOD46enmNt6nB5rX4sN3kBwOliPF G4r4X9zSMNuS95Zx1KLrQRR3EJ5+ppwi1sGq9Oj3dqYr72hCuFhfh9IsTQDY9MQaHd/brTFw0hs 7QvfYUCeMQ= X-Received: by 2002:a05:7022:6285:b0:119:fb9c:4ebb with SMTP id a92af1059eb24-1273ae6945amr4340040c88.30.1771265509962; Mon, 16 Feb 2026 10:11:49 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:48 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 12/15] soc: qcom: smp2p: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:49 -0800 Message-ID: <20260216100943.v3.12.I4e47dc2356edbaadac7298ddd65dd649d9b5ee16@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Signed-off-by: Douglas Anderson Acked-by: Bjorn Andersson --- This driver is used on my sc7180-trogdor Chromebook. While I haven't stress tested with it, I can confirm that the system boots normally to UI and can suspend/resume with this patch in place. (no changes since v1) drivers/soc/qcom/smp2p.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c index cb515c2340c1..139307b66a47 100644 --- a/drivers/soc/qcom/smp2p.c +++ b/drivers/soc/qcom/smp2p.c @@ -169,12 +169,10 @@ static void qcom_smp2p_kick(struct qcom_smp2p *smp2p) /* Make sure any updated data is written before the kick */ wmb(); =20 - if (smp2p->mbox_chan) { - mbox_send_message(smp2p->mbox_chan, NULL); - mbox_client_txdone(smp2p->mbox_chan, 0); - } else { + if (smp2p->mbox_chan) + mbox_ring_doorbell(smp2p->mbox_chan); + else regmap_write(smp2p->ipc_regmap, smp2p->ipc_offset, BIT(smp2p->ipc_bit)); - } } =20 static bool qcom_smp2p_check_ssr(struct qcom_smp2p *smp2p) --=20 2.53.0.273.g2a3d683680-goog