From nobody Thu Mar 5 08:48:01 2026 Received: from mail-dl1-f41.google.com (mail-dl1-f41.google.com [74.125.82.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEB072EB840 for ; Mon, 16 Feb 2026 18:11:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265507; cv=none; b=RoHBaAayrx5AGPn1SlyOz+Kjoyvm7m8iPDcAaCyVs2V3dm1YoNyFU4XoUDp8cyKgr1CeWtNVKGcvCA4ZNLj8cgUlPTVXatPmEQjseK+pKSJbrYOaJpLhLA4btaQDf1PifhB3bwrgDKNlUKOrBLayHEoTtmvR4+9CpHc5NvQFUio= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771265507; c=relaxed/simple; bh=CDxrp4OucdMFl3rFBhyh/bKVYZGNXZao6NNebXzLvRo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kr/Mm2zaFalwYIft9BeZo0H5MmYSWEGhCTMNk8ltKe1u81vjS8kwuTofS064RDHeBDSXGWOVDggtCbvUQJBjOfnttz9xBhKpO6fblTJV8GKCd119Rh9+iUD4osjCuSRe6Kw3ye3X44qOfYdLvjBp/7iGvxrqY8TQayt5RFi+z80= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Dk8Cke8Z; arc=none smtp.client-ip=74.125.82.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Dk8Cke8Z" Received: by mail-dl1-f41.google.com with SMTP id a92af1059eb24-12732165d1eso3792683c88.1 for ; Mon, 16 Feb 2026 10:11:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771265505; x=1771870305; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HSRSa2qBwyo4MKgv7YKXiUq526mCXszwG8DRrzAIIQ0=; b=Dk8Cke8Z/TooRCn/hfbmy2Jqps+817Qjh7KHgbwuiyfGH6jWu1hvgUZOi+lakInbfw nhAtkQdhK9OPwDa+EcbzjGiVOy88XBZ1o9oFOE6XBh8OWTySvCB5BRdy4VPJl8d/udjn FEbngNnr/i5CJmkPLqxnIJErCVQV40F5F2drQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771265505; x=1771870305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HSRSa2qBwyo4MKgv7YKXiUq526mCXszwG8DRrzAIIQ0=; b=ckr2pgY0ytWO2iiQBj4w75GDV+1LVOJ+BJ8pikGjRP77FOpSL4mVkgqyCqPieirlq1 OJ0lVsBTZjv4FdLXLr9A71oFs8C08b13GCVxzQOU8239QFAiQ2IXk/xiFtlPG62BCAqb Cz7E8QfthvdYeGZNyY1EX3NvdGG/LlGf3YUlxVq4FtO9cEYOnqYZyQEhEfE7h4Htr314 LUMdsTbTbiEyL9ENwNrJB8AsYGpZY6N/UKLnECxcdpSwgndKkXSPj0/glKwQ8I8/qhke CfgWjKTaJkifmrJjlW7WbqMtiBpNX9M7d32p8sXfAeot7eYSKmyq424HDT8IXpRVqzdd zxKg== X-Forwarded-Encrypted: i=1; AJvYcCVZ01UYFbpKAQ1sKhzimQpOWORcLNM1O4U0N+dCUcCmYoc4o9H5HbajthkJDBERs29s4YSnbuW0w57kxPg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywa9MZXe43Ji179kb9fsV2vubtyt+DN6+wnQxWbPY5QjBjVwxiJ 3PxshO8A2Trhjj0qyBXKA34mrm9lYRA3VdSb2CtZgneMQ25GXEiRY1hFkmwCd6U0ng== X-Gm-Gg: AZuq6aKxElwiO1SUI+w9p9fhc+rmn9/pKY+qS/E+LXtq1G3iP+6LVYP8ywc2VCclcM2 6PNI7qbvPtqFG9EIcrRI5RUsy9XIW30uRGJ0KFRLKp/RT6MsQMH+ne/JRH/W2gdVFCjViW2/NIc XeFLEjppTX3SiD99zxKfvNbXGA/A5xcVsi+vh0cFpRd1yWm6j4hinxbyWzmRNDfatKPYq7L88Bg YmEDmOjUgmv1OEWIgCHbgYR9+eyylnS5FzJdfhE1vpbuJlfEvsiapB8r8OxkxwKL4d6gCUAlACF PWIN8o+ALr7q9B+/6DmwxaMH4vq9ufatSFJECd0p3k8AstXizH/cMdzTWL5jQ3C/AX72/AjZVzI gavKggM8xDCEf6GcE/xZjXMgXlTOPs2+GOmWeq91x4XIQm2X+gDf1383fPjBfHKjzdqxGB087Fs wWIr6DXjxLTQn9wfG1a+P0YyuBIwpTjsefC6eejukABHVP/LQVxW7JR+HAnUUv8y7Q5PXiM6eDR Ok+oFXghdA= X-Received: by 2002:a05:7022:926:b0:119:e56b:98be with SMTP id a92af1059eb24-1273ae92b3bmr5486503c88.37.1771265505096; Mon, 16 Feb 2026 10:11:45 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:2953:dae1:1e39:73b3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm13724326c88.5.2026.02.16.10.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 10:11:43 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH v3 10/15] rpmsg: qcom_smd: Use mbox_ring_doorbell() instead of NULL message Date: Mon, 16 Feb 2026 10:09:47 -0800 Message-ID: <20260216100943.v3.10.Idbe327f5b4ce65a284b55033627d0819e2fed21b@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog In-Reply-To: <20260216181002.3475421-1-dianders@chromium.org> References: <20260216181002.3475421-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell()"), we want to switch all users of NULL mailbox messages to use mbox_ring_doorbell(). This client only ever sent NULL messages, so the transition is straightforward. We can remove the call to mbox_client_txdone(). The call didn't do anything for NULL messages and it's now officially documented not to be called for doorbells. Also remove the comment about the only cause of errors for mbox_send_message() being if the framework's FIFO was full since we don't queue doorbells. Acked-by: Bjorn Andersson Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/rpmsg/qcom_smd.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 42594f5ee438..afe1177d092e 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -371,17 +371,10 @@ static void qcom_smd_signal_channel(struct qcom_smd_c= hannel *channel) { struct qcom_smd_edge *edge =3D channel->edge; =20 - if (edge->mbox_chan) { - /* - * We can ignore a failing mbox_send_message() as the only - * possible cause is that the FIFO in the framework is full of - * other writes to the same bit. - */ - mbox_send_message(edge->mbox_chan, NULL); - mbox_client_txdone(edge->mbox_chan, 0); - } else { + if (edge->mbox_chan) + mbox_ring_doorbell(edge->mbox_chan); + else regmap_write(edge->ipc_regmap, edge->ipc_offset, BIT(edge->ipc_bit)); - } } =20 /* --=20 2.53.0.273.g2a3d683680-goog