From nobody Fri Apr 3 01:31:23 2026 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012020.outbound.protection.outlook.com [40.93.195.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2E162C0F75; Mon, 16 Feb 2026 04:22:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.20 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771215767; cv=fail; b=m3HiEtPBIcvEC03QRK0a54K0fexvby9TwQ0ksHiqYpDWX8r+gdNGZ3NdAFrUym7nFp4o/NNbdtExxJGUWQ1NXTwprmo4eqKHf17v+LZpqJ63VzgLcOsU4QAvWhEHNGgVcq0rsfyOqpsvFKf7a18i2OZAGU323bhgeBmCQEVVydw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771215767; c=relaxed/simple; bh=6oe4sS79++F/CutrUGbfOyq9yOgvs41ZH55VsDSgq/M=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ey06DX+GMBuyTwju3noeXhWD3RCcfPgPJErl8Fm0ZRG8Oqm3IURfmyulfy0vOwVWtWy3tOs451OGmGmjk3zqkV0c6l+HdlD0MrCGGgmNyQmSkqKFpQgJnUxBZLeVL9qYSZYqLqCdTVjz74jwQfxEaUmhoW3bVY7T70VuzYSuCUQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=uWz4H6NZ; arc=fail smtp.client-ip=40.93.195.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="uWz4H6NZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=K1hVGJWUjazWB9fPX1p8ojv4NRJ7XG3f/zyb/xok49W2+UXwH4kn9v/MzrC5BGQ2kxV1KK3Q4aCk54baWKnWmvGUEBgyjm9uXwHNUCyz47mJKuQBuFp7UyW82HiJ3yPUPR9aepvrZ92ZgcEUoXIsYmgqNOGfkG+sKoZVNmZVtHlEAvRisp/h1hsGBJXEzgmWb+ehpr+w02+YnyTjtXhqiZllW49TtQvQfEgZpn72auwF+AZtcr/+cbdg6smXKVM/dJSdeEKlGdWO0Rltj7tSXxcUWiKPm3IMAl96wkqkHPi0RY82AuJnftXzmrvAfF8ot0syW15dT+fVcf7B0Vb6gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GEHbCpHuaBVOYltBF5N3fgIzPGQjSOFl3lshVUh5Aic=; b=lZa/Md+7ZHM84fDWhdVPuK02LPoi+UwZp/CZ2pMZRNjbxYjN0ivwEg6mw7CVdKI4FrMVVBxvswY4CyBje8x2bEO/1zlfc3aw342yW+JuKHWF8t3iRtkVroyrmGN/m9lCWcp1AyMvPqioYCVPWShcFLfAPn86I/p8yQjOmYokIST2caNEljzpyhBC6wG3M1JlnlJAN/cuImwnRVu4rmx95V+EpLfyFKcTvoQNLKJj7FEk7wGMmlloNId65FiyF2wLQGft9j5hgVIGXCA5k38DlNQC/1B/eUDOLvedN+7W/T1tJnNlzotWHo9x3S8yns/mXJ6FhcmyZfG9MgQBWMB6GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GEHbCpHuaBVOYltBF5N3fgIzPGQjSOFl3lshVUh5Aic=; b=uWz4H6NZj7VtdkPFL/Z8Rf/HYZWxLeyazy8l6fhzbq1Xo29/uOofCkIE7FMvAIRYWJkrESIPCzDrM8jbnpbEyTp5HTSr3bjxZCGRCx2HT+6XmsvUkEDYyzWv4+OeyDXxHr+Mlwn2AQ/uUsLoyPIenYf2u2fg/AAfQwS2Q3KpiVc= Received: from BY5PR04CA0004.namprd04.prod.outlook.com (2603:10b6:a03:1d0::14) by LV8PR12MB9081.namprd12.prod.outlook.com (2603:10b6:408:188::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.16; Mon, 16 Feb 2026 04:22:42 +0000 Received: from MWH0EPF000A6732.namprd04.prod.outlook.com (2603:10b6:a03:1d0:cafe::73) by BY5PR04CA0004.outlook.office365.com (2603:10b6:a03:1d0::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9611.16 via Frontend Transport; Mon, 16 Feb 2026 04:22:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by MWH0EPF000A6732.mail.protection.outlook.com (10.167.249.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Mon, 16 Feb 2026 04:22:41 +0000 Received: from BLR-L-RBANGORI.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 15 Feb 2026 22:22:36 -0600 From: Ravi Bangoria To: Peter Zijlstra , Ingo Molnar CC: Ravi Bangoria , Arnaldo Carvalho de Melo , Namhyung Kim , Ian Rogers , Dapeng Mi , James Clark , Sadasivan Shaiju , , , , Manali Shukla , Santosh Shukla , Ananth Narayan , Sandipan Das Subject: [PATCH v2 1/5] perf/amd/ibs: Account interrupt for discarded samples Date: Mon, 16 Feb 2026 04:22:12 +0000 Message-ID: <20260216042216.1440-2-ravi.bangoria@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260216042216.1440-1-ravi.bangoria@amd.com> References: <20260216042216.1440-1-ravi.bangoria@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A6732:EE_|LV8PR12MB9081:EE_ X-MS-Office365-Filtering-Correlation-Id: f3efb198-8c79-4eff-9679-08de6d13069e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|7416014|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?HVDnXnO0xiPYzxM2+pCNJR3KR+fQPmgHAAlJprmIELwbJNXGiL+JI7osKDM4?= =?us-ascii?Q?8AaQv22yKfujkEsZjBBVmeGExOf8iJTIe4nPiZvtIBb7tvWotyEm8QY9IoIn?= =?us-ascii?Q?qv8CQ0rKO3FBqFx4a3cLd0x7PRt56wJ1AC6oiu/z2x6jpHZKf6tQ0UTvoUlS?= =?us-ascii?Q?IQzbGBIKyg2G26DLeMiiL40OyUonUcq0+7rCQCwUTdvaWRk0KfM71NTKbojD?= =?us-ascii?Q?2lePnrg8ohCEEkxsfO6GojuKbzhVLd0Zvyct1/RFWfYACm8IB+qw5ahwwzdY?= =?us-ascii?Q?7goedf5dW4pUSFIoiKCfvFDntJ8nmhBV7jPYMmcKpgYd8GMaLfNnUOk7uVQS?= =?us-ascii?Q?cppoNv05S4JcFj8wMOH6DcL0U3wsdjsjKkvgjEgTQKbvKJ3YofV0sTBx6/r8?= =?us-ascii?Q?TEsJKB0EZhVnhLaQB/sLGlgSsldQCnQQDloGOMU0/sP3U+pel83KLKS6rCMO?= =?us-ascii?Q?HfUurHkt/HubElHhxl/6I5X9jjqEHqoJTqnrms/FJWHIOF27jZkCVNFfuQvL?= =?us-ascii?Q?ICCGDZBpggrAf2iQE+niz/ffxwvIkXKuP5bshfLn6730v/KSJMiUvAk1kQ+9?= =?us-ascii?Q?oNPUM2iFc1ujQ3B56zEI5ytjWc0WeIqfjyWqHZyGttj2Phi7H4ZsjDONQm3K?= =?us-ascii?Q?G0WeXGZGYhgmZkhJQ8HRbqbqs5HagPmO4q8rObrr5EVPiVYnyGjghiHVqPxl?= =?us-ascii?Q?JQKSFXTsxRurJkt7/EpE4FnPVFgkd0d+ZTUOnEbWj38lJDTps9e6RMt3zsHp?= =?us-ascii?Q?Cs2pMavkiGN5YeV3a8Eq1L8T3jhQWckFfp/D8h7VE5B+dvC5HFbt6I637LKL?= =?us-ascii?Q?6TcScGb7oCGKIocvb+iAdO5Oorz12GUPfe92RMkVsscdeeL78ByIHYKgdvO3?= =?us-ascii?Q?Jj8AaB99yYf/fOl5P4xI6HlPBK563s6CNSZbVYHur/15fEYllNSqFl2C9Q29?= =?us-ascii?Q?pBVpZsrWNUJuh/Yk+/YKPs0iH5vq9ljrxpKeYTj3gjM0g88QVpjn1H9H0tBp?= =?us-ascii?Q?dHcoVYVXzh8LZJW7i9Ze2eB2kaWqZBgYZVqSE6x3ILKix8LA6X7yL5oCh8sr?= =?us-ascii?Q?ktoyepT0cfQkHIqEU+X8T9DAnA4KoXwOKV+LGeWzx/tCSBNSOkNrf6WUIzXJ?= =?us-ascii?Q?0lYy+/jz1JH5kVmsqVTPYwEuWfs5yTjxpZTSzZeOOeW5MAVO1mGa/A48jA1A?= =?us-ascii?Q?WMPWx6p4Lq3GqS0mieEsfhSa0UeDYat2Tlfd8rPyS6baWV1E6GcfZY4BoLFV?= =?us-ascii?Q?AsIrdhjzAi6Qd/jNRcTSaOnaXkJDeor4dvlYGeI3F3nsMM5otFq4wXjSkrRp?= =?us-ascii?Q?uRABLxZzuQCzC1oUlUNeMM8jisDUr6MKbj2R9BdD7H+rcHwajo7foIvhqcqj?= =?us-ascii?Q?zLeDs4+wvF8WjyaJnJGYOrgKWAB4OL85wquCzQdCZ0MCXHwKAnUdxgmNQJwd?= =?us-ascii?Q?M7v6XTZzFoaXJSKXo4WPd2Bw9bmRq2QLzrwbAQoHUkvyF3qCV96yWFQans8f?= =?us-ascii?Q?EKmsvkbr3gOsiRI8RWByr9U2PofOjEyqk/Jq82CheriqD/9PkvHXIjAm10DY?= =?us-ascii?Q?KPAWBpJNWzDGCRr//L89Cwmf1PY4K7BWOezSBXa3c8CnN2W/uzG8ISp7hqjZ?= =?us-ascii?Q?+5MgvC0gtQtZeq2jJcLJVYDRw5dJhRswrg8Gtl72p7tq+cosvUAbVhW3hupH?= =?us-ascii?Q?jOoOLw=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(7416014)(376014)(36860700013);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NpnmwssiaBir+leJMlxzMRTYdT73vy4jVNNyf3RzIrT7fmqbe2/aygo9KmJkppec2XvEL21hqEaCFf12QPa/IVRe9qc8CnvpaMxyrrr2hR5d/pCjj/8v4whSkSCNLIX0KM0FGBtIc/z0ycDwYbWuk4Pu6cFXHuok0vfGdqaEqfr1INEn/8IW30O6NsXJkJ8mZ56dvAFDWt/tHOAFKYbH6SOca4eXwUL9pDyLEcMU1qa1SMTi/Q/NS2ZkTD6z9nUVVELf2iMLPx1clCxLm0cM082VtQ/14HUTcqaaCF2Y2iHmG8ry1rJ9muzfeuupdBt+oynYmmOgl6iL9Q1d8tzomnrZHiS9Xon7HXUjA/lmC1/AO6kiuqhjfK8mmLO/RpcqY2qdoMGiaDp1FhFD46Xg4KXeX4CNqO8clql2TawKMTQuAycSRWm7cHe0B16kPWq6 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2026 04:22:41.4944 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3efb198-8c79-4eff-9679-08de6d13069e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A6732.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9081 Content-Type: text/plain; charset="utf-8" Add interrupt throttling accounting for below cases: o IBS Op PMU: A software filter (in addition to the hardware filter) drops samples whose load latency is below the user-specified threshold. o IBS Fetch PMU: Samples discarded due to the zero-RIP erratum (#1197). Although these samples are discarded, the NMI cost is still incurred, so they should be counted for interrupt throttling. Signed-off-by: Ravi Bangoria Acked-by: Namhyung Kim --- arch/x86/events/amd/ibs.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c index aca89f23d2e0..705ef43325be 100644 --- a/arch/x86/events/amd/ibs.c +++ b/arch/x86/events/amd/ibs.c @@ -1293,8 +1293,10 @@ static int perf_ibs_handle_irq(struct perf_ibs *perf= _ibs, struct pt_regs *iregs) * within [128, 2048] range. */ if (!op_data3.ld_op || !op_data3.dc_miss || - op_data3.dc_miss_lat <=3D (event->attr.config1 & 0xFFF)) + op_data3.dc_miss_lat <=3D (event->attr.config1 & 0xFFF)) { + throttle =3D perf_event_account_interrupt(event); goto out; + } } =20 /* @@ -1326,8 +1328,10 @@ static int perf_ibs_handle_irq(struct perf_ibs *perf= _ibs, struct pt_regs *iregs) regs.flags &=3D ~PERF_EFLAGS_EXACT; } else { /* Workaround for erratum #1197 */ - if (perf_ibs->fetch_ignore_if_zero_rip && !(ibs_data.regs[1])) + if (perf_ibs->fetch_ignore_if_zero_rip && !(ibs_data.regs[1])) { + throttle =3D perf_event_account_interrupt(event); goto out; + } =20 set_linear_ip(®s, ibs_data.regs[1]); regs.flags |=3D PERF_EFLAGS_EXACT; --=20 2.43.0 From nobody Fri Apr 3 01:31:23 2026 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011019.outbound.protection.outlook.com [52.101.62.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79DA62BE7D1; Mon, 16 Feb 2026 04:22:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.19 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771215771; cv=fail; b=jHBog6hSRNlNFypinZVcnuWkjnFktCqqXmiBH2ZTW6MYwqJAo0o3Mb5HozEUwQ72guY2uWcHEhTy4tv6IngQtpunZa7aIub7enk7hPDuAjhQGZdOK9oqagh0Q0iX3tKYHHN5RqV/ewt4koUpnUmvsoUrt8naxIqOOh4ZE+jzGyk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771215771; c=relaxed/simple; bh=QqlBHW2blcLrPuqNILJ+qISYouUg16orV21Q5qXe+QI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZjrEhC8pIVUoDfPCr0zK0xirCpgRKU4Afu9uhV5sYZpKVkNi5f2UHPcy01ZSVExG0trhic0OKLfYURQXKraOfN/Qij7PyEmamCUa5ha5IPyDKWtFlxw+U6acOEVv5FTMWZMnzb597bwkJmJG3SYfA3nPiPrOSoSJbF2AN7gAEXI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=cmzuK58I; arc=fail smtp.client-ip=52.101.62.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="cmzuK58I" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k8QHRJkWBMfocqWh/VNHcBDYBX2nCBOMV5Wf9SlpBnHX/6Ai69z+MBK0X93Oe26MnQdiAFv137hwzIL9LzKLBGbRGWeCViZOKaGzREuejSI20Ko1uCO4Dsh3Zph/hTSDeXIkAHgRq8ql2VobXj65zUmquHIdLTckoBBhPUNx/7908vrxlPGJQ1oXuzKi6bxpe/zsI/3q96EygZsHBOCwOWHjCdfKdprlFGa2xEr1VFRCp536wu//I1VeaP84hNNuZSirKbx1UtMk92iRs4YN2wFc+5exVM3IIxMkX53niGHlxiL+rI4gFq45Dx+50pThCDObd1WAY/NCrcgkuIWV1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kF0C56kEAfAr8Zc3lQ0Gql565m3CDv3VFmgi3+lHlnw=; b=w1YhqsWm/rf9vez4TT4nE0T2lW3xDHVlmIbgVxHhnNSa7gcgLKaKnyV8tVCQcfOYtJzIcjeJLV/muzRpxZ6kPm0opGZWG0dXlcmn9orzWa00woIQY3maiwZWQ1OwMgjvF1nWZjkVgwCreIvYK3DqycykMDnhekEe6Ct8+9/SRGjXemFPogWVPWqbO+GeTmieDXnHA4Il/07fbsin0yrvRixGbAA4nesBK1gnFZdi366CA6vuG2Rlm9zX96pjDI52iNCnrX2+bb/aZCNwRb1MbzbBY4wup1ugrlvP8/C0dNSmghsQM94MGCE8gYaeU1HJSkM+4v+90GhbT5jgyaOrkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kF0C56kEAfAr8Zc3lQ0Gql565m3CDv3VFmgi3+lHlnw=; b=cmzuK58IRC/s9w3fVIaIUqXNN3O5Gr39CysrJGkBcBKlbJkXash8qnVd3eJafsJJdagszWsoyA75cDEvCvFavJDUNvHsqde+3p8sQv2wEbfNqLsAEHKZ2MV3tNmQ5lX/VZKISaSVdVlemitfAHopMvzhjxHrLdxf+GN3a0T1rOA= Received: from BY3PR05CA0040.namprd05.prod.outlook.com (2603:10b6:a03:39b::15) by MN2PR12MB4143.namprd12.prod.outlook.com (2603:10b6:208:1d0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.16; Mon, 16 Feb 2026 04:22:46 +0000 Received: from MWH0EPF000A672F.namprd04.prod.outlook.com (2603:10b6:a03:39b:cafe::a2) by BY3PR05CA0040.outlook.office365.com (2603:10b6:a03:39b::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.13 via Frontend Transport; Mon, 16 Feb 2026 04:22:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by MWH0EPF000A672F.mail.protection.outlook.com (10.167.249.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Mon, 16 Feb 2026 04:22:46 +0000 Received: from BLR-L-RBANGORI.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 15 Feb 2026 22:22:41 -0600 From: Ravi Bangoria To: Peter Zijlstra , Ingo Molnar CC: Ravi Bangoria , Arnaldo Carvalho de Melo , Namhyung Kim , Ian Rogers , Dapeng Mi , James Clark , Sadasivan Shaiju , , , , Manali Shukla , Santosh Shukla , Ananth Narayan , Sandipan Das Subject: [PATCH v2 2/5] perf/amd/ibs: Limit ldlat->l3missonly dependency to Zen5 Date: Mon, 16 Feb 2026 04:22:13 +0000 Message-ID: <20260216042216.1440-3-ravi.bangoria@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260216042216.1440-1-ravi.bangoria@amd.com> References: <20260216042216.1440-1-ravi.bangoria@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A672F:EE_|MN2PR12MB4143:EE_ X-MS-Office365-Filtering-Correlation-Id: ed6a68cf-941e-4ba5-3885-08de6d130951 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|7416014|36860700013|376014|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bNlBR44481ucrBGBMn6hbwXpoOBE+7Vdq02TAnzbNDnrwPhV47DRoCOlrlOq?= =?us-ascii?Q?1OwSXAJx23Kkf+j4NipE5AUSzsHCTMlyfoQwZXwYDCBz2EKpNxhPsd1p/O8z?= =?us-ascii?Q?I4h+9TTosEGF8Q6VTNHjPCMYhBiPs1nvoJbA9NHmE+KU8o117BNJzdVCKYL2?= =?us-ascii?Q?m7VbawRJiAcQdf4NrNrCGJcTh8xNg3zKCKdTjJqL9C56eMzgQe84CryY+3kZ?= =?us-ascii?Q?2guFIRVbyz65F5mnW5kTc20vFS1BZIFwH0ao7UgrkjnQ96TIJtDV0m4Dj0UO?= =?us-ascii?Q?td6O3QKrtto5ZfFq42dZWAyWds3Ej/4xeEkTHcEJtfTPIZDPO6JENPuUdmaV?= =?us-ascii?Q?m0Trdq+cNmvHXytLmuwg6wQVh3bCES+d6Kkka/evvOahO4nO5FujJ7uB8J18?= =?us-ascii?Q?lIL7oG6vuq8rP4H2PSu4rXhwT03bMlBvT5QqHM8BWwOQNeM4zM4qwHB3rXy9?= =?us-ascii?Q?nhK+cM/ubjnPt729frs5IZz5+DbpFkVGkj604SK8pyFUxEYbsXur6VrTBMap?= =?us-ascii?Q?6zULhyeU0ILwifIRNoyl3FFrfqNdZdAznCxM8OwYfsuPluSxfxcOotPR9mwD?= =?us-ascii?Q?5SqCXXQXDPpjYUEQ+kEfzLfcnhxErSW2xjBbj6ViPUfO6Kgp92WDfFVZ5jMj?= =?us-ascii?Q?U95af6bwivJKk40c/4oZhVUocNOovgCm51XZqPCFP5GNF6tvFgyx0OFgCE8p?= =?us-ascii?Q?g56cYHYfKZDgkMY7Oktrx0V0cLhpB2BaDELeDur8d93vE8k1p928bQn/uU6O?= =?us-ascii?Q?HBHYrlSqwqPjUy1NLH0XnRjS26JwtSPY8gPMPxc2d38nc/WfW9BvfCYxYJnF?= =?us-ascii?Q?sbRfhY0z8seTdGhfTxpZzS6RL5IF2Fk5rE+LHcK+JO95jnG/1TMnHKyhqyPT?= =?us-ascii?Q?YH6EBZo+3ZNqfTMi9s7OCromAMI/iCFfovYV+dmLWsPTsy5diuVsWVyQeJtJ?= =?us-ascii?Q?2Ip84E/hBPvSZntb5Q9UebGGk9GFDiHwxiijhSr6QsJW0jmDSuF0mFnyvfAS?= =?us-ascii?Q?78SQUrmCqvOvv6P8JmY1EtoOdgKEaSTe2ptc+6L2Z8Ie/O/dz/JQpjFUMJL+?= =?us-ascii?Q?bO7zkepdJ2ptzIZVo5OSftDqiWhE2vD3RghJT9uKnzSBN2NIKLsIRm4t3gDu?= =?us-ascii?Q?H+2SF/3NGy46EJKYHI9BCAgOU9HqTjvmW+MCf8YaSduZBrqbEizg73p14h1g?= =?us-ascii?Q?yeQeu7ud0CU4pZjfyTwN+eAdf5HcBqKSBULbMqBFio3kBE7P3Dg6TmN7poU/?= =?us-ascii?Q?15bLkUOlRXsjCFl4FIU8FjXgCEB5hl+XojoKvvWi75fM5wAvaNxjmJiriWj8?= =?us-ascii?Q?VXjuPdWK8G5ItEi7VsDl9NyPEGG5gcq1v52eJSjzkaC19F7evHTrJHjVfegQ?= =?us-ascii?Q?TFe2EBoo+PNDXwO5gzvVcJPA7J+ld3qgv9rP8+yllVWJmggQqHRNwH+BjQSD?= =?us-ascii?Q?xnCN/rWnZAQH/Evufjaw7E7ZMwYpDQR6Uk4ETjcZoc92RkZWOJ/9siL6ULYw?= =?us-ascii?Q?SpUeb7X7x8dijPYwqjQD0nOJrCMfk6u7ujzGGnAtrieAU2WfOIDNKsGKAGOY?= =?us-ascii?Q?FM5rohltlIF7knIapASuXHbL71m+N0ep8eGt6JI1uS2HM9VT06au0nBk3PlL?= =?us-ascii?Q?6L+Gw8vlTdqrj9FQ5wEobWWS1nxC8vw1E3iUA9BY31vi/MkbPCxgpW76m76V?= =?us-ascii?Q?dWh2NA=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(7416014)(36860700013)(376014)(13003099007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0aUp5kM8GPjSIN/o2x1FGfGDbzxCQ49FiICIpdrLOlUfWSvmQsPwBu9vZb9cdyjwh9MzwskMu3lXzeZxXlZ3mC9E/TpfeaCRsTxA1melrLeG8dVUltpVl8fsdr107uP5qHzfQpsKBOXIUSg8xq5LCB42K3pcFSwNSLncauCXzJLP+etUfIwgh96nggYalWkgU7QGQtSUfJYK81cImOSzT/Q7Bi17cSYp0OlcfA95Do4rLYHeBUwH1bGo5A+zaO6rPMvi3yaU89R3t+pIzsB+aytYPY33Z50uC/C+T+9WBhr73cOtqJXrlzyU8EJpw+GQb051m4vnFrgFcaje99mQ4rThmDsX+6POBNv1fZ7lQP8xQbPLxr7LSURG+Qu+e5Cha86EXX4DxRUjCuHA1JcEyygym+zFPap+pn1q17VsZC9DALN5GFdPLnwq4gdKk9qG X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2026 04:22:46.0540 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed6a68cf-941e-4ba5-3885-08de6d130951 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A672F.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4143 Content-Type: text/plain; charset="utf-8" The ldlat dependency on l3missonly is specific to Zen 5; newer generations are not affected. This quirk is documented as an erratum in the following Revision Guide. Erratum: 1606 IBS (Instruction Based Sampling) OP Load Latency Filtering May Capture Unwanted Samples When L3Miss Filtering is Disabled Revision Guide for AMD Family 1Ah Models 00h-0Fh Processors, Pub. 58251 Rev. 1.30 July 2025 https://bugzilla.kernel.org/attachment.cgi?id=3D309193 Signed-off-by: Ravi Bangoria Acked-by: Namhyung Kim --- arch/x86/events/amd/ibs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c index 705ef43325be..e0b64cb13bf9 100644 --- a/arch/x86/events/amd/ibs.c +++ b/arch/x86/events/amd/ibs.c @@ -356,7 +356,10 @@ static int perf_ibs_init(struct perf_event *event) ldlat >>=3D 7; =20 config |=3D (ldlat - 1) << 59; - config |=3D IBS_OP_L3MISSONLY | IBS_OP_LDLAT_EN; + + config |=3D IBS_OP_LDLAT_EN; + if (cpu_feature_enabled(X86_FEATURE_ZEN5)) + config |=3D IBS_OP_L3MISSONLY; } =20 /* --=20 2.43.0 From nobody Fri Apr 3 01:31:23 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010016.outbound.protection.outlook.com [52.101.56.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1309D26560B; Mon, 16 Feb 2026 04:22:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.16 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771215776; cv=fail; b=ChUUO0uzxnGt3/gik+xw74WsKB0mWEHj6K86reGGsXpnHpzvzmk050Uxj/uwDVZR6coAsNYCt3NTwFBGEuBi5VpmZtPNtjhqMKVlsQAERQuAyezlhmsyYj+DLQGiNvaKFmbiUSPPrCIrxkD8dX3F1CC9Nv0kno35RZoOmSZvBr4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771215776; c=relaxed/simple; bh=hPP46hSKrcQmjWoPi90xrzdXemWMPs8uW1YUMTg1/4M=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TM7FKjhVCGfsGxS6DH5GWE45DY2Sv5290IMkoSfQ93yBUpfUxC3RlY62IP9ZkHbU1wHmtxVC7vocnQdOW2sUCbyHZcQ3BPHTBAwjt2rcIV4aGwTb/n6ZO4VPu+sUGAIMTc8Zd9gbLOu3ulBwrEAMVfKMqd3+LYw8Dm99ibKZOHo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=WtwTANDO; arc=fail smtp.client-ip=52.101.56.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="WtwTANDO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gmzgA2EC8j0kVkryFMXnYdnxQJQebnyjcaOlNhTyJj4gLOlC3F3CeOc2fNKEX0U9zf83nKSPIQC4+rZdts4fTHw6iiio60fZ474nnPyJySwynPNPlAzxHjBy8ow2xUFhZ5tTw+9aKtfvWS2MPNuSDAi51dp8bApBfYRErEsHbyQ24gXR0GDvJKhZzey+Rg1Ou6Y1dvvMHuqp9CKjTAqvKhnv9ARfJgZJuH8xQuTWykdSTzF7Dt75XmA3CXjoZMS8D/wIeFIFTgwjIAbdYQc4K9+m3iPcE5zKR1O2cXAm/yf1FobSTEYS1LZ5DfM56NIDpA78hlzVTeR1NG6JTCCNSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3TTvnxyLBekPLG0IU1aDIMAqikNjccX1PVBqE8DlaD4=; b=eXb2umpd9gvnKGE0mkL9h8IEUXCqnhqKOqu3Sh7aVFwDsd4AUAMOVbDySQQUrMn64DDW32is/ORvCcA0rSxFGQAr83RWPHEJU3o4UUykdUdL7QdVZsTqG4+KFGhQzQCZXhSKNKHTJpC3WatrpF0/pwDu4/IU3sdo1/NNUHAUqCNnkAzDhLyuyJSFhZEDz/z4zmXvp4btU4r9p7rPtT7o3OHtm+IMGI76KRFE6FTy9DkUmfICJvLFwbISEUw1f/avuuAC/kIJw5uZjn8u0fp9SGDJ+jAQAYEI+xxPctPTuqFotrw2C6xzfPVLNLolo1Rjj7VXtgRNBQYD6NWtWF0PPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3TTvnxyLBekPLG0IU1aDIMAqikNjccX1PVBqE8DlaD4=; b=WtwTANDOHOkSwOUXVq182wGTbQgmi6Th27+I/7j0fSQSXNZFDl35KmZuY2FFheT5s0inbqMwxIggpMgAqK0NForFucuZORE1FCqpml2QD6VcoJHVx5jqJ9KXgRUuEI992NVPOE0zSMuq1GkQ8VUQXxmhRz892srsdcoiL0kBxOw= Received: from SJ0PR03CA0371.namprd03.prod.outlook.com (2603:10b6:a03:3a1::16) by MN2PR12MB4240.namprd12.prod.outlook.com (2603:10b6:208:1d3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.10; Mon, 16 Feb 2026 04:22:51 +0000 Received: from MWH0EPF000A6730.namprd04.prod.outlook.com (2603:10b6:a03:3a1:cafe::d) by SJ0PR03CA0371.outlook.office365.com (2603:10b6:a03:3a1::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9611.16 via Frontend Transport; Mon, 16 Feb 2026 04:22:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by MWH0EPF000A6730.mail.protection.outlook.com (10.167.249.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Mon, 16 Feb 2026 04:22:50 +0000 Received: from BLR-L-RBANGORI.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 15 Feb 2026 22:22:45 -0600 From: Ravi Bangoria To: Peter Zijlstra , Ingo Molnar CC: Ravi Bangoria , Arnaldo Carvalho de Melo , Namhyung Kim , Ian Rogers , Dapeng Mi , James Clark , Sadasivan Shaiju , , , , Manali Shukla , Santosh Shukla , Ananth Narayan , Sandipan Das Subject: [PATCH v2 3/5] perf/amd/ibs: Preserve PhyAddrVal bit when clearing PhyAddr MSR Date: Mon, 16 Feb 2026 04:22:14 +0000 Message-ID: <20260216042216.1440-4-ravi.bangoria@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260216042216.1440-1-ravi.bangoria@amd.com> References: <20260216042216.1440-1-ravi.bangoria@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A6730:EE_|MN2PR12MB4240:EE_ X-MS-Office365-Filtering-Correlation-Id: fef3a4a2-8a5d-4567-8688-08de6d130bc8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|7416014|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Nkn6VfVKjfOkUaBREYRRwsDDaAwpjQnf651aOn2JgoG5ocz2nskINkmxo4v2?= =?us-ascii?Q?/aA9Et9amk3tRRML9wD+mS62kkPJV2/M+4p9jvCQOYvIpOzcPTGGGkZztXzj?= =?us-ascii?Q?CW9rP5z6PlSRsbmavAE45nchApkGK0os+73G3z0bXQllfawvHnCfz5hFmj+g?= =?us-ascii?Q?mEYSldstsaep83+KHAAg1eCvwbkmpXyD0eKI8BW2qbcMPXg4EXV9czfq/C86?= =?us-ascii?Q?rEMx2cy7DkCFLWjVmD/y6WpJqOJcOaCJDjExF0BYcusxEJenwozSij4GNPl9?= =?us-ascii?Q?KUqQvZ5VuvEjzf9PviEHRf31cTPM6UmaxOfo0/Sg28UqSVT/yzCZhizXkKJb?= =?us-ascii?Q?O8p3wUPGsOe85RQdIcxVY/05P1cO4wl7OLPJcteikiaswsn1bRJYXXRh5l/h?= =?us-ascii?Q?AhQSlcMi4Lvo/K1Z2cpzBO1hj2MRO5SRcby7JQgKRvwdsUKZU1JIld2tosib?= =?us-ascii?Q?+uHfyqjQ3/tzd1SNgJuFudkPwiPn2eHGN6AoeSCMe+i7JVYcskDYHMa2Z5Qn?= =?us-ascii?Q?vETt84RW2vrW8TVaXyvlVOfww2NvifdC5oqhgFIOfIL9eWc/Eg9p0RXO2ZEk?= =?us-ascii?Q?HPfZ8tLh5rkun7A5jwDQTMUz8c9bbO+R2C0qsj0p5Sivfq5Z/txTUoATmugo?= =?us-ascii?Q?65ZwRO2GQLIkFIyqz+/gMRvFqxlYPZsZNzD69gXhgoZpwcIfxj4fAj1uzkcS?= =?us-ascii?Q?QjwzVyTWdzoMKMtubB3lBoJNwwCGOKQ7FY+x+sssq3RkVVux0G+9MhSt9eFu?= =?us-ascii?Q?WbOjZav2zfCds7pmJh69vvI6jx6B9QzGNYsylM54oySFsc+m19KY3Qwcgb0f?= =?us-ascii?Q?pwaweGSjjRmKTuTZB72nA6uxQaKP6gBJlepT+0ed+WTSvgue+B8vdxyd0UrS?= =?us-ascii?Q?eyb5m5HLmkWJzXGr9otpe+S3jKoyWfKjOq4avrp1xXxRtZSK3O9vnKMwaq3L?= =?us-ascii?Q?pv+cMr+qjUcHHKAWk8ESGIjBOuGBVMptZlUy2yfHC9IgyriGouWRwYJDCpm7?= =?us-ascii?Q?bjFOwaQpoyUFhYmXKqblcfZORl5sdNt/RzvxnWQ+qOaHnMYQYutw9Shzf5fw?= =?us-ascii?Q?VIYqhntpLJPaDnVCvDgenRn+bR4rCtw9lZQDB4R1nB4M0HMDDIKew8v0le6y?= =?us-ascii?Q?8T7ZUtHCu87Sy8Fsa4RwkyQnp46epKbE3637xWzqUIxhs4IHjBDYKgRkl2U9?= =?us-ascii?Q?9gLr9UrulGJiX1UH4uFDqKfdv4aSP+egFmEKl5xZc9I9VyKZq/rGnv4yeFTG?= =?us-ascii?Q?hYqltxRQLZXcgguDD4e2VdLN3UYfs3M5k/k2ff8aZrdZO0k8DHXLRpc5mtYE?= =?us-ascii?Q?KlkJLhw5oj8akO8yRrBDcw7Hct51bVeVqqG8yv4E6a8n72Z2mFs0kolh/tFL?= =?us-ascii?Q?RbjlC2Bu7QKVIiu2b+GyAbYtkQvkRV4wwBkqn0DMqGA8V9is7pfvp9pN8Aq4?= =?us-ascii?Q?ItAaw1kWF8sxRHeSKwP/woipFCo6IHvxadLdrlHkfgd/0jcStCH9sfVgvFuB?= =?us-ascii?Q?zWwJ404F3Mb+XEznrqS+UmJVX/wAR/MsWAowBmf7OGWvsOSzNdsz0yKEGTrj?= =?us-ascii?Q?myi4Nw/ectFkjBFG0b/OfLdTaMpviF1ABHV2EEMKNz7zkGCeXpAlg8+FUaah?= =?us-ascii?Q?q4QHIo1adb/AlyRFoq+IrDtDIZGmL7hxYsQciGR/rIYVGS8lnoFGv0jElqGp?= =?us-ascii?Q?ZidbdA=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(7416014)(376014)(82310400026);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Ql7ReMblVK6nZxenoayvtGzR2aWcMbQvYVDaHFG2aPO7jT+U8vj+t1NWsdD2CXrhzIQx/BuhnNI8kS3BwozJlM5dz4fZPkrhgd2XwMgVP0fkNSD9+DcMkDy6bargs9D4aLtAeDEVPMBLegO5pbKXSOKdZZvRXF7j0SuRSyTwLtV/kk4R1ZOpnj1WPZNU+cJJ4bxgeWIbT0Pewp8R9pP46Zgpio4M7ugat8a6inlgl58fV+PHWDa+x4T1IwyBEx3L4mH26GMYWGjdactiruRf0zhDyaf5goCcuSdXvI7cH6NzpX0gBHam8R42MugVaJaMD0iLCUS35/xR8R7iPh7GFJO4Gtru3e2E4MtTg/VRFypdSDzxi+6lCsqOj5gB8zQVyM/3yCTafWJLewgg+S82MXLippTbo7pNoDPuNUAUjojq4TCCl3Ikd8TBi26NDmRZ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2026 04:22:50.1338 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fef3a4a2-8a5d-4567-8688-08de6d130bc8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A6730.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4240 Content-Type: text/plain; charset="utf-8" Commit 50a53b60e141 ("perf/amd/ibs: Prevent leaking sensitive data to userspace") zeroed the physical address and also cleared the PhyAddrVal flag before copying the value into a perf sample to avoid exposing physical addresses to unprivileged users. Clearing PhyAddrVal, however, has an unintended side-effect: several other IBS fields are considered valid only when this bit is set. As a result, those otherwise correct fields are discarded, reducing IBS functionality. Continue to zero the physical address, but keep the PhyAddrVal bit intact so the related fields remain usable while still preventing any address leak. Fixes: 50a53b60e141 ("perf/amd/ibs: Prevent leaking sensitive data to users= pace") Signed-off-by: Ravi Bangoria Acked-by: Namhyung Kim --- arch/x86/events/amd/ibs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c index e0b64cb13bf9..05b7c9f2ec33 100644 --- a/arch/x86/events/amd/ibs.c +++ b/arch/x86/events/amd/ibs.c @@ -1217,12 +1217,10 @@ static void perf_ibs_phyaddr_clear(struct perf_ibs = *perf_ibs, struct perf_ibs_data *ibs_data) { if (perf_ibs =3D=3D &perf_ibs_op) { - ibs_data->regs[ibs_op_msr_idx(MSR_AMD64_IBSOPDATA3)] &=3D ~(1ULL << 18); ibs_data->regs[ibs_op_msr_idx(MSR_AMD64_IBSDCPHYSAD)] =3D 0; return; } =20 - ibs_data->regs[ibs_fetch_msr_idx(MSR_AMD64_IBSFETCHCTL)] &=3D ~(1ULL << 5= 2); ibs_data->regs[ibs_fetch_msr_idx(MSR_AMD64_IBSFETCHPHYSAD)] =3D 0; } =20 --=20 2.43.0 From nobody Fri Apr 3 01:31:23 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011002.outbound.protection.outlook.com [40.107.208.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFFAF22A7F1; Mon, 16 Feb 2026 04:23:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.2 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771215782; cv=fail; b=IoBNH3fw3D1zu2kWJGP4uUgjL53lMjkQLC6vhHse4XwMFLIDnYzmXXd9me+M4QTDKLERug5s6GQm5uqlL1zwwCx+imWaF40Ii/d5Z4VZCPRKY4L3t2UOlUl73Akrj2CvHcBMihDUgcWqikTCXAmGdvL0CRzOIODONS7hmqPeejo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771215782; c=relaxed/simple; bh=a9z0sDFTjY8uzLGUgu03f7kdekSjgRr9CLMiK0UwMfo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GTlARgIPZvwUoL8dYfbJ9w9lJe19N3SsIMt/QAZuVUwnerFSdF87lbj5w/6yd2gsf7JjI3YF06zCq+xauCg2NDRfEtlGxLo/inZV1EDpsNJ7e9d6EuM89lx0VYNIGG1kqlJp502MD+491P/77ENK/CCV1q2SnicRP9IT6Ikgg7o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=msBLlNvI; arc=fail smtp.client-ip=40.107.208.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="msBLlNvI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qCzjI+c/p0acnriZtighETmizl7HutYycMnGBxScQ5+ok22N6Rb2haiyu4q3PE6eiBgHoUD5J2l71llOj2npY5L67iRdsfeEChWxRd6s+LNQq2B93K0u/W98SJrUevAANYjpZze51sI6BQ/kXPyw6Dka9sb0MZeeSvQrJL+bAMrf0ML6ndFK/qI5cUfwh13XWYBkcZempHwCYtHmuEKybxp47gJj2Q0JdmlPnMYVWkktM04sxBtjsC0g+D1kWuUMTfd9PllJNUYIrIfRy+vlMVxfE55vJRNxkP+XdEG/+YblGxpWJK+t0YsY32eMil4tYNvxqgg8YAX8unng9whiCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S2ha0VfAR3FdfS4I+wfNqswGVZZ3080xR+q0hiVb5RU=; b=DVKy4d+cfwGKS5aZDBIr3/Z9hPSaH2PEJdVlvoEwtPrc/mglbRMQeJJwLC84bX29/XmnBGqsskZn10SpnYRO6X805RixY3qzZLmDxRL6AmDgkAc/jjdfU4VdgXvz5s0NsPvMM9GYqTebTeCXFl0GZJV+u00nNlMkBX9L0meDMUwHng4ldcIDCEhys4/tn20dScpaqbmKSLRCTjFbMSkLe/j3A+7IASGVXQe0XOhSXUpixPgPbqd6V1KY8bY0RXiSfL1woezH3Z4IM1HcTneBsRw66G+VDJ8SEgbZa/fZ0ozPt58i3DcVKzdr6kS2eDcOghyWcaKyO7YkxYNVglUhJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S2ha0VfAR3FdfS4I+wfNqswGVZZ3080xR+q0hiVb5RU=; b=msBLlNvItcmRyyjhJAF9L37HSiT9Go4jwStiYCIxj2+dwyY4K/QsbY4XRfBSTtt8AWgk1CrmJuH3KVCFVHNka/6mmrL9sUg5SCApt4/ffh1PAhIdg/T1ZI9pn5YnQzRRFxgaY+XyhPiPg+yNjESoHfnjYNO7YZtVptllWl4Z0ns= Received: from BY3PR04CA0021.namprd04.prod.outlook.com (2603:10b6:a03:217::26) by DS7PR12MB8083.namprd12.prod.outlook.com (2603:10b6:8:e4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.16; Mon, 16 Feb 2026 04:22:55 +0000 Received: from MWH0EPF000A6734.namprd04.prod.outlook.com (2603:10b6:a03:217:cafe::9f) by BY3PR04CA0021.outlook.office365.com (2603:10b6:a03:217::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9611.16 via Frontend Transport; Mon, 16 Feb 2026 04:22:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by MWH0EPF000A6734.mail.protection.outlook.com (10.167.249.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Mon, 16 Feb 2026 04:22:54 +0000 Received: from BLR-L-RBANGORI.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 15 Feb 2026 22:22:49 -0600 From: Ravi Bangoria To: Peter Zijlstra , Ingo Molnar CC: Ravi Bangoria , Arnaldo Carvalho de Melo , Namhyung Kim , Ian Rogers , Dapeng Mi , James Clark , Sadasivan Shaiju , , , , Manali Shukla , Santosh Shukla , Ananth Narayan , Sandipan Das Subject: [PATCH v2 4/5] perf/amd/ibs: Avoid calling perf_allow_kernel() from the IBS NMI handler Date: Mon, 16 Feb 2026 04:22:15 +0000 Message-ID: <20260216042216.1440-5-ravi.bangoria@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260216042216.1440-1-ravi.bangoria@amd.com> References: <20260216042216.1440-1-ravi.bangoria@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A6734:EE_|DS7PR12MB8083:EE_ X-MS-Office365-Filtering-Correlation-Id: dfef9b67-95eb-4ce4-c340-08de6d130e92 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|7416014|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?orUQ6EADrTWrI+6RK9CQSd6JSoSJooFNPZ2Fr1Wo4zvY2l40JM/l4poC3AZs?= =?us-ascii?Q?MBeVTHDZ3HNl1XBILIjRcka3IgCdh9zEud9j658ptkn/Ph9zcV2FPxF/8ksZ?= =?us-ascii?Q?uJFtNvvsthtVas7ZP0IOf/AUiO0A02AOuwTwqtsAh0OUNj6kMURKNcNeBiFx?= =?us-ascii?Q?5Q40xLv0TX8GATCGBvfmIg0HUxQXbzn8KQVM7sAkTj0Yc/8MF5RriHy1B+nI?= =?us-ascii?Q?2s1IG8i8WajMRaadBjrEPF6aWlSvHuaUToWxJC1STNsoEfs2LUNt2X30JjK8?= =?us-ascii?Q?Qv8cKQg4eNYNH6qe46JY5ofgpDDF/jDCT4pwzgQcpx5c7foGQJYhCu5HDTiB?= =?us-ascii?Q?UApjebe46tgfRatRK7TdumhbiBd6JVQhSXgd1UDC+uv9/cRSLMOTsCjd6Ixh?= =?us-ascii?Q?4vBq9gSkYIS7LGSzxaHgJkc6UBeeSSE+YcGR9Ucq/ubXPfGzzsq/+QlXILJa?= =?us-ascii?Q?DbzuDuvaXB4gs7Z6qAY29Xtnht+Xj+PGnZ54qn0uITPt5BrewiOfiHXLKKBZ?= =?us-ascii?Q?/Cn017RC3V+K3i+H0vyyovshbX8bQ20NINFXtfpV46Ie7YOXjmA6vI6USO1d?= =?us-ascii?Q?sH+m+1T1CLdDB2w8mE5ElALms+GlD7rsvPt7c+F1svKWCGAT+Gp2jTqxf8NT?= =?us-ascii?Q?FoDRgJiFMBNWRhH5yBL4DUjEw/YJvCn+Us8C1ZSYfCjQqfy/CpPwMMhKVdsf?= =?us-ascii?Q?2TY4eCCBj8E+n5I0rb6uNEjP67yI9qyrQOfUh2WUydvu1UJMGq8eYtJkM981?= =?us-ascii?Q?WMxRdmZo3gh5lfI4l8CuHre3qLW/3j4Cep9hpSm/M1Jf63zi9BQW+d3NF11s?= =?us-ascii?Q?orIEreOTDLuc/Ivi78oHnX0Mzzw+a1xRkJlanaWXeLT1vNP+Z/SUE4ACBfJx?= =?us-ascii?Q?alMpU9ukl0NI9lg0TURZvuATitz242rrMxR0oUUn1qSn3zMEMoui/MX/h7nT?= =?us-ascii?Q?eS5SHri5kwm1vZtm7E1P4jgTtleAV+fUASflojS+f0SLcd5Q/ia7hqapNJgf?= =?us-ascii?Q?dXB3OF4zNju4hUBsJtAIJCUIQ15HvzNUBn2Xol+OMHjs+Kll9xqBwt4/5y1n?= =?us-ascii?Q?I+wm04lblCpGd+ODyR6w6NEvg/b9GIlE5d8PSkghnLfm4Xbl8WY3xSX12OOI?= =?us-ascii?Q?Zguq3Qe5gLSBcx0yv+je8WNWxlJH5uiSKj5XSiMLE527R4y9zlweeBK/JD7a?= =?us-ascii?Q?mVvjkdftGhHe6LXTmOYQBb47PFnIEuFvFy4jmWQsK/ZdqUEgE0AivvM4e1PJ?= =?us-ascii?Q?RkRK+yVYDRhudWbVGJ41aRxeXfjWO2dCcoeed9QIGTl/Lc/4QE6PjAy8A0oc?= =?us-ascii?Q?gClBZMXyor3eTYGU99WOw3leNYIHLA8AIVGBO9pYNrWmalFHmvS/WMMDKpA6?= =?us-ascii?Q?00Odgjp4PIr5Cp14Vjg8IGTwdBsAJpUTmYM88mDs5UUfLokXcByCRr3Crkv2?= =?us-ascii?Q?fMiVBKa1NnsPcHrWpWMKvV4oRNBm8i8Bv2ELAx5HzbVDmaHE+o+A4kgwol0Q?= =?us-ascii?Q?Jhg5wKaV1xupTH5BXw9wjmxEACUPDcelcWhrYP7teg7ONwHSKQvXU29QSpQC?= =?us-ascii?Q?G3/0srrwMX/jBoO1x4yrzfpnp3vXqzrUiiXm8WvUj7D1L2QvVaXZGgE7uCpe?= =?us-ascii?Q?ueJ5PrmFQazyzNosHJ2K+Sah3XgIv1x3pKaIYWt2CuwD4UBLmXd+EdbSJHbm?= =?us-ascii?Q?QBPLzA=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(7416014)(376014)(36860700013);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LayZS8VLPyHdbJ16+ZT9+kmAEdtQQTmWQzDxBNa2/WdwCbIMOX5SoLaG29A2K6z0N2avcY1RIt8oWBIYRALmiWNs4pQGrYwe3xRDjJtjsLPNMUrc+IFpJoj5DQl1SYCtcgSWXCTay7ITWn8srXvUC3Yy3aUd7/+os4uvWblsPmj2d4XLcg42VU18AfqQaqxdUGHwH0y1/6BQ+2FFYIw/8CLKSYoWaBo9ykY0G1p+w9kU60+CepZnY9CcotAab+sRlVsLmX1+Exb6o1eOi3W4XXQElpRVrBEMoimf6QYeMY+LZdzw69QRIqJF9cyLebCY3dZj70aq0+H5UQN7z8dIf+dQu6CFCX8SygevqIv0igzupV6ou+YGn8C3B/rC4aspUySO9XUUiBJyFQR/R2CZBXS8HnSXnfN6H0KlXJ22Envq4R7sYYKccbTrY8nhSpcn X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2026 04:22:54.8167 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dfef9b67-95eb-4ce4-c340-08de6d130e92 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A6734.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8083 Content-Type: text/plain; charset="utf-8" Calling perf_allow_kernel() from the NMI context is unsafe and could be fatal. Capture the permission at event-initialization time by storing it in event->hw.flags, and have the NMI handler rely on that cached flag instead of making the call directly. Reported-by: Sadasivan Shaiju Fixes: 50a53b60e141d ("perf/amd/ibs: Prevent leaking sensitive data to user= space") Signed-off-by: Ravi Bangoria Acked-by: Namhyung Kim Tested-by: Michael Petlan --- arch/x86/events/amd/ibs.c | 5 ++++- arch/x86/events/perf_event_flags.h | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c index 05b7c9f2ec33..004226b52ac7 100644 --- a/arch/x86/events/amd/ibs.c +++ b/arch/x86/events/amd/ibs.c @@ -313,6 +313,9 @@ static int perf_ibs_init(struct perf_event *event) if (ret) return ret; =20 + if (perf_allow_kernel()) + hwc->flags |=3D PERF_X86_EVENT_UNPRIVILEGED; + if (hwc->sample_period) { if (config & perf_ibs->cnt_mask) /* raw max_cnt may not be set */ @@ -1349,7 +1352,7 @@ static int perf_ibs_handle_irq(struct perf_ibs *perf_= ibs, struct pt_regs *iregs) * unprivileged users. */ if ((event->attr.sample_type & PERF_SAMPLE_RAW) && - perf_allow_kernel()) { + (hwc->flags & PERF_X86_EVENT_UNPRIVILEGED)) { perf_ibs_phyaddr_clear(perf_ibs, &ibs_data); } =20 diff --git a/arch/x86/events/perf_event_flags.h b/arch/x86/events/perf_even= t_flags.h index 70078334e4a3..47f84ee8f540 100644 --- a/arch/x86/events/perf_event_flags.h +++ b/arch/x86/events/perf_event_flags.h @@ -23,3 +23,4 @@ PERF_ARCH(PEBS_LAT_HYBRID, 0x0020000) /* ld and st lat fo= r hybrid */ PERF_ARCH(NEEDS_BRANCH_STACK, 0x0040000) /* require branch stack setup */ PERF_ARCH(BRANCH_COUNTERS, 0x0080000) /* logs the counters in the extra sp= ace of each branch */ PERF_ARCH(ACR, 0x0100000) /* Auto counter reload */ +PERF_ARCH(UNPRIVILEGED, 0x0200000) /* Unprivileged event (wrt perf_allow_= kernel()) */ --=20 2.43.0 From nobody Fri Apr 3 01:31:23 2026 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012034.outbound.protection.outlook.com [40.93.195.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FAA82BE64F; Mon, 16 Feb 2026 04:23:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.34 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771215785; cv=fail; b=BlusZOHvmH6gf0AwAd/iE4jb9xcBizWTZEzVdQ5P/Kz2/uucKOrgnujgX6c9S7umF2qIDyK9dW8ss1MEHezMr1dq3Re/5ww78p2bmRcaeojndTvNrVD2FW3Rrrq6hsMUfBovtLvEgTPbbYBcL5LCEavsnl8JBhSNXHHg7+ErjOE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771215785; c=relaxed/simple; bh=4Fko5Qs71a35JrSDRzHvEHiCGRPAdMd10F+p97IVrFs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=D/xt2p2jsDULJmiUX/BssssflHMonsky4IrsgxU/6nq/AMOBv//w/NSJKoTFkbFQvVh02KotwmhZRQPtOsmxC3dHpLsI+VPq9AdyfDwKVTv9SNuLpMXubPWv6LV7WMz6Y6rjcSp6LHa+IhnLnLwGnq7HHmR56Y7BFAKFvKMVBNg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=3+P5mHdy; arc=fail smtp.client-ip=40.93.195.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="3+P5mHdy" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BKXwRVWEBH1HuZzmCWbUT652Z16OVVRctTu74P9kl9Xa4IUmI13NmqS8SSGWRiNiC169/IB95hfhXNdgiqznOq7xgZhM8yHt5JytXzIDlA7dnUnd0Q34rG/w86HkmJwVyfgTKEUzVCchfyycy++TiBgsyyocTxN6qBSawg6DuIfiIeARR2eaT0j7WQavNIjaxBlfYFQbyN/t2OJEh+6o0hSP7ecZlp1Im9bOYUb41ohBlXX9EBuJ18elkQhdcJTt2kKJK3oGRaNoUa4+ahde6QUCLqRlSeBO7MjYGEBpP2jK/WZzlcRJ0uMg2hBxnllqVAVz4KqK5gVb6uVuxr+gDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=deLYKkQV91S8CbzTfmPDgaZOXxcQ34oUfAenHqkEd2E=; b=yb2NkTmm5Hht0S59gu9PBTiMFlj9syXpoAiWVTO5iKrtwT5A6cj3Ds0hVfO7mcctyfGyBcr6wmNmajcS5D0KOCMBxbmTTd3xRl2X947pdC+PmSL8hCDqlTXXKTk1N4Byp+moahs2X0MYh1ygzWBGSqyDGAcJ8j4k9l/lBlLwxEz+lylr4Kvn0zD8ypNOt/+q0TJyL/xDadEEwHCZSc8qy99fmXCXlTr6ZNqz1lVjMozwqzqObP6GQtu9FkDjcrYSSUEWstdrndw9OIe+WjrozR8HkpxztSICxWVuwTiiRBG+NWJ2R3zPu1DkXrnjXrkiPM9MogeBoQx8v4zJLruygA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=deLYKkQV91S8CbzTfmPDgaZOXxcQ34oUfAenHqkEd2E=; b=3+P5mHdyJqiK2DuyS82ZJjH+/i8DlFZ2VZrlET3774FaAayAQtr5fboZexPBVKGJq0ny2LwHkTR55EFVxGOO4EvKl4Nv7C3NFwXzeU+vjju1ZNH5dRg+jVRbk0dS+Ob/hEkjpEc1n/SHFUm3Y7UwylJXbmVe4iXM/h7waV5HaaI= Received: from BY3PR05CA0032.namprd05.prod.outlook.com (2603:10b6:a03:39b::7) by DS7PR12MB5741.namprd12.prod.outlook.com (2603:10b6:8:70::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.11; Mon, 16 Feb 2026 04:23:00 +0000 Received: from MWH0EPF000A672F.namprd04.prod.outlook.com (2603:10b6:a03:39b:cafe::c3) by BY3PR05CA0032.outlook.office365.com (2603:10b6:a03:39b::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.13 via Frontend Transport; Mon, 16 Feb 2026 04:22:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by MWH0EPF000A672F.mail.protection.outlook.com (10.167.249.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Mon, 16 Feb 2026 04:22:59 +0000 Received: from BLR-L-RBANGORI.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 15 Feb 2026 22:22:54 -0600 From: Ravi Bangoria To: Peter Zijlstra , Ingo Molnar CC: Ravi Bangoria , Arnaldo Carvalho de Melo , Namhyung Kim , Ian Rogers , Dapeng Mi , James Clark , Sadasivan Shaiju , , , , Manali Shukla , Santosh Shukla , Ananth Narayan , Sandipan Das Subject: [PATCH v2 5/5] perf/amd/ibs: Avoid race between event add and NMI Date: Mon, 16 Feb 2026 04:22:16 +0000 Message-ID: <20260216042216.1440-6-ravi.bangoria@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260216042216.1440-1-ravi.bangoria@amd.com> References: <20260216042216.1440-1-ravi.bangoria@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A672F:EE_|DS7PR12MB5741:EE_ X-MS-Office365-Filtering-Correlation-Id: 837cfdf8-577b-4a7e-44ec-08de6d13115a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|7416014|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?olLYccxq0L6li0Z6P3hh5TNKmvKrixJd9RbvNEv5LwnhW2B6iXIlyE56aoz1?= =?us-ascii?Q?gq3N0SlyANYtK2FNIAt9mfDUIX6ArbVEwT92SCI3YYGw1As67/aGrmIXoxtB?= =?us-ascii?Q?2BXx/Mz79bZShE2HgaepXGVuP+GuAb3HzrZh1iJXJ8caJbCR6XwvpyfAcuWv?= =?us-ascii?Q?1Zs11u0+X10iFI73p/Kcjnq71gUCl8R0yHkPCSG2AEClK4YcsRqXgNzFes1U?= =?us-ascii?Q?dHDjGraH6G9Qny9MbhsN4HKWDZDzgG+lIHvMM/odDJ/TWJgF4y8LvaUqXmTC?= =?us-ascii?Q?j9RRZsxlUykSYGtSZD57KBz0olCLRnh9EDXTi0vtF9vCCIpRBh58wLTeB2M+?= =?us-ascii?Q?qAx/5Ebtg+G3V4UAm1tK3y2+0smRwCR/zYrQPBHiI6PBetI5P6OttV21K+Hr?= =?us-ascii?Q?+KialtSBZ0PLqRe2s4T4yYhw65SONOXS3gRTyJies9/a+doE0qCv1fNHg8/4?= =?us-ascii?Q?pphQcbUtBMzgNn7uv6GjkMoFA+WmtKmJkYBNot6ZSkFtbDZa0Sc8o7m05xQb?= =?us-ascii?Q?NWM//4HWra6h+FAti3Um4rg1j+tMDQXxgqdhGYyog0kd7+NYwJQQGXyOCZsi?= =?us-ascii?Q?K/A62KFflsRwph35GtVN9H+QUWd00eb2WKtS7RamO1SZuMAkIsyJ3fwKS9cY?= =?us-ascii?Q?iA0330jVVwgfA3JpiRrKoiysI/CVWAWfJHYhnnp3DutnvK3pn3Ampudwgu2F?= =?us-ascii?Q?ksO7k+YDSNPWNsBWWJ/EU9Iffd0zI6RGgNuUfikRi1U2xWmHGH7lpkxhlBms?= =?us-ascii?Q?im7XA+Yyerz6ReAQSpaltUZ5W28JKEFw33iZY+PZxo3IZnIwfoFerb6PoCZl?= =?us-ascii?Q?tEw9uWzvXoBp2lqpLSPSdQHZNI4eLCrKzhC9C4pMSjHy7iRRDjIweI9A9Tt2?= =?us-ascii?Q?MdNupAe4pPHEYqkyHR4XX9zoaGdOE4SLtSSYHMw6fvtrR/MFNQ8j7Olx3JUs?= =?us-ascii?Q?JWiyhuNsd4Uu4coOCA4L4nEJyT3Qv+twVXUGEmfNCgLM44muJBft5HsP7DqK?= =?us-ascii?Q?TGjF3JSkPrLbZNr0dNO3SrjrSJBOKaZDZd33SYqfItQod0VByOfcA8MyFJpt?= =?us-ascii?Q?nVfwsk9ezDmYXS9FOy+ACmqCLNKRv0cxJz/MdohTEsrCYTUz51ldYs9CoIt9?= =?us-ascii?Q?hcg/tkz4A9UMrqa0ciu2kpalYht7NPnZpYMehFYeiP6yxmJZG/0aBcIXtxfc?= =?us-ascii?Q?wlqVY+nvNp++raNTAnRHVUTBzBHmExmqZq3GQ7s7NQdN+LxCfadc/lbCjD6q?= =?us-ascii?Q?EVPYcL84pc8+8dfLaF/CWgugtM4rm+yDH/2OmUEN7Bo2fWR84g89MF4fn/D1?= =?us-ascii?Q?RotLjHlW9y3ELPWBdsKdTiQi2fh0KioYBPH1zME9m5xkB3Bedw7A5Ojy0SAv?= =?us-ascii?Q?BTMjfju1WH/m9RGr7uvjBH4d0q/UgStzbDnsTJ2S1FkmhA1w68sAlYlUO8H+?= =?us-ascii?Q?/zVNi89Rx4/C+GPG+KE/erY4xnStaSnBC3IDbMwt36mplpKp0+bOV4B+c513?= =?us-ascii?Q?IJ/xxAbea79gdIQilvICZ6Lpvf4ipudBPUS6FhoVXYRBI0ETEBvtYo18S55g?= =?us-ascii?Q?fKolMwFuEISQPeEpHPPVcGol+hvt565dhMp1zdWWFhS/DvkPcAWeXl/thXq/?= =?us-ascii?Q?2trJgBcv6tV6UTY9CZ2kKYE7rlhpEn3mld2V9vzl5f7I+ZELgbFHJ1izLC/X?= =?us-ascii?Q?fKz0lA=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(7416014)(376014)(36860700013);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: McKy/WstUlkihEH/pf4YA3bLCSSKaRCUqpSGFnxLREBE5d8ZteAAH40P6opfjERHmCbxx6ywga/Zi358wKCfYZysSs7cXmc0WnB0cf/M6fQWtvzOZBHHg5FjczAxLZy/8Mj/bBSGpwvWfc4YG6fZsuFX9jONjwEz+uFSS1eykF+ghbSQRu2CfbOswK2DHAkepf/BAiPV6KhK8UV3YkrXR22uMDobY7qrhSgxD4KrtIx7lesJ+N9QU3WD2kvCMw3ODQbmUeXdK8IwjcprI1RpR5QOzrg3n67kDAyi9U0nc3XM9k/W2CGpVjTvAjXpd5/VlAij60TE/8gFsvYZo6dtWZtLISFtXiLvD3IUKcPIgHJoPIMht2wpmDi3eIpCw3ngMvH0bNCSIBpj1KlSQW7AYympS1Va0i6TlFSGSJLK49sDlYuFZI42jUPRYJ0KWIjK X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2026 04:22:59.4785 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 837cfdf8-577b-4a7e-44ec-08de6d13115a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A672F.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5741 Content-Type: text/plain; charset="utf-8" Consider the following race: -------- o OP_CTL contains stale value: OP_CTL[Val]=3D1, OP_CTL[En]=3D0 o A new IBS OP event is being added o [P]: Process context, [N]: NMI context [P] perf_ibs_add(event) { [P] if (test_and_set_bit(IBS_ENABLED, pcpu->state)) [P] return; [P] /* pcpu->state =3D IBS_ENABLED */ [P] [P] pcpu->event =3D event; [P] [P] perf_ibs_start(event) { [P] set_bit(IBS_STARTED, pcpu->state); [P] /* pcpu->state =3D IBS_ENABLED | IBS_STARTED */ [P] clear_bit(IBS_STOPPING, pcpu->state); [P] /* pcpu->state =3D IBS_ENABLED | IBS_STARTED */ [N] --> NMI due to genuine FETCH event. perf_ibs_handle_irq() [N] called for OP PMU as well. [N] [N] perf_ibs_handle_irq(perf_ibs) { [N] event =3D pcpu->event; /* See line 6 */ [N] [N] if (!test_bit(IBS_STARTED, pcpu->state)) /* false */ [N] return 0; [N] [N] if (WARN_ON_ONCE(!event)) /* false */ [N] goto fail; [N] [N] if (!(*buf++ & perf_ibs->valid_mask)) /* false due to stale [N] * IBS_OP_CTL value */ [N] goto fail; [N] [N] ... [N] [N] perf_ibs_enable_event() // *Accidentally* enable the event. [N] } [N] [N] /* [N] * Repeated NMIs may follow due to accidentally enabled IBS OP [N] * event if the sample period is very low. It could also lead [N] * to pcpu->state corruption if the event gets throttled due [N] * to too frequent NMIs. [N] */ [P] perf_ibs_enable_event(); [P] } [P] } -------- We cannot safely clear IBS_{FETCH|OP}_CTL while disabling the event, because the register might be read again later. So, clear the register in the enable path - before we update pcpu->state and enable the event. This guarantees that any NMI that lands in the gap finds Val=3D0 and bails out cleanly. Signed-off-by: Ravi Bangoria Acked-by: Namhyung Kim --- arch/x86/events/amd/ibs.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c index 004226b52ac7..32e6456cb5e5 100644 --- a/arch/x86/events/amd/ibs.c +++ b/arch/x86/events/amd/ibs.c @@ -493,6 +493,14 @@ static void perf_ibs_start(struct perf_event *event, i= nt flags) } config |=3D period >> 4; =20 + /* + * Reset the IBS_{FETCH|OP}_CTL MSR before updating pcpu->state. + * Doing so prevents a race condition in which an NMI due to other + * source might accidentally activate the event before we enable + * it ourselves. + */ + perf_ibs_disable_event(perf_ibs, hwc, 0); + /* * Set STARTED before enabling the hardware, such that a subsequent NMI * must observe it. --=20 2.43.0