From nobody Fri Apr 3 01:40:57 2026 Received: from mail-yx1-f49.google.com (mail-yx1-f49.google.com [74.125.224.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21D5B2AE77 for ; Mon, 16 Feb 2026 03:20:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771212023; cv=none; b=pv6u6V3SK0ubXKu7jYIk8NCRq7bCR+kYpLMlylL64LbZOHg8KoW02iYYoBToeGE2uNc/oOLWjsroXZY2GAiU2eStqorq9PAIrETEAcmVNoWTW7RK7hlP77vxPgK7K4HhxaW0vt2chwrwoEqW4CpuPrzFwsNACmL6ysvh4/nG10E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771212023; c=relaxed/simple; bh=942O+hf+F5rfx/qQl9prdoFML+eV1a+38fZ2S9Dhrpg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oMF33cc1/gixyvHpuMsykjvkLbiGvf4RKiH784GFbY+7szBSiUbRhJDCyChJDNeRKxtKTlkm8nSFN8gk3ALmwJoDcu87ej+sMSwq1BQMoR9oFHb3BUvxefKhHW08RKyHAaw4iRzFQE5dnLfIKY5xxBtxc45eqcYKn5Q4M+lOGP8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A8P7G6GX; arc=none smtp.client-ip=74.125.224.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A8P7G6GX" Received: by mail-yx1-f49.google.com with SMTP id 956f58d0204a3-64ada2c30a1so2458829d50.0 for ; Sun, 15 Feb 2026 19:20:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771212021; x=1771816821; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6LGvUKq0n4wsuyCdZHTh6SpLNtepx8NmVuHEeyoSw+8=; b=A8P7G6GXrvglCoYI8FJGKQMtJdXIDwH8OmbXPUqpJupm/JzVjhV9PuaZ94by6obUT7 0z1fTtYSd7HOESygpLnUagbgO5FbdSMLuKoPgQuzDCdbWsHHxtKYu+T1YxBu/IVTL8cq hImz93cx4f/fvAqF4iKrajfkgksPa4FkQ4bjfodEhSPGetfMvQKvbIQZu8We+lqjPwGv xXW2BhhAJ5lthRemC6S253jqH5iFe/OpwonY7S8yzca/rsF3Wjl5UE3VI++00uqPcJu2 65NBET1qVBxOzBW/EQRoNvQdlGRAkGjQUZxfxlmQkMpQweXN5nYyDIAi0EgznbjvXioG O22g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771212021; x=1771816821; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6LGvUKq0n4wsuyCdZHTh6SpLNtepx8NmVuHEeyoSw+8=; b=GlH1/UlJZxoylkcl6eyd3JrBoDcCqwBWZOxQh0Ac03h0uBhNjxePdGpG6XWBQ/3GrJ a+WKPbnSRM+zBuAkmt7FgErek41uxr4IAAm+jqaA0L9KLhnNw1tkqB1YlI/13ANL1WNP PgzZBArMEEgb2YD3+dDaatd4FCy2xZEes5bQIjrtt9/emCL0nUNXDh8C/qMNfDZl7QrL zAk9KDRCpjvMgOnqHFxGkv6Wobd/kfgy1jDUeewGGSFmf+9AWx0g/1PxDUEYU9qkW5Qr 9q3xuasGojhhbOc6wAAUMIyyqNqHpltJEVpUq3096jeuBpljB4AgsFNXG+YKUelmn8s8 Te/w== X-Forwarded-Encrypted: i=1; AJvYcCXlerXYOLDrQp2CTqeLPLEnGdOzHuVuslNtc+UqCFfT0OyqFPt7HM5mmsa4mFUuKSpE0petQy06hvdY9/s=@vger.kernel.org X-Gm-Message-State: AOJu0YwiFTKCKA4tjy2o6Qpd5pPFXm6yKbqq/tKwvZ/Bhhhl81e8WoNf ngTDICDVF85uxZujj9rmef5xL00iwyeFEvZYJCyEFA8s5BMHcKrTBeYy X-Gm-Gg: AZuq6aI9r6Zv/hhaWtES/DpJ2MnJMSBccwJJ8XZjXAr2h6QigGKRrWPEA/0mwJOJ7/w SqE0w5oItuK0lVIcw3ohDocaj7pwKl+WUUvb7X6MecqOxxT3naD53fCWMfD+t5ycDxvixcQzZqW gos7cMnjYL/qNlYFmhqhx0kwMXN17kRbe9dXWU6C52zhOjF9o7NCCoOdxlzg7qvIBszjFWVCWcP rYXHg7RJW3GRLxCYxJywkYxa2qwO7dXnMpjqJQCY40LsiVs9niIUvK3BMMG44ooyIbc+vpGXN3h MrD8nHVQ3qN0auzNKVdupn5TmeTzXRA32zYZKmiCZVSvQOELuBNi4WsoFTu2lgNIRV71YJzPPhu htRpsJrDLZvcovca27Z12rXLMNTtbvEMoxlhbA8twUW47D3lN29/w8UGsjekHhR5uliWuGiu8SV 1frkIxN5SMzE00nRVabcey2Kwxn7VJMvKAmOLbgvZEHlrsT6IMaMe2jaHWwga0yp2UZQljWnWNj ol22f3jcHFvVCHrlOANc30ujOcjtC3VgU0Jm2GSKb6ncOHA97ABFA== X-Received: by 2002:a53:aa4c:0:b0:64a:db8b:e429 with SMTP id 956f58d0204a3-64c19b677fdmr4110257d50.90.1771212021022; Sun, 15 Feb 2026 19:20:21 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64c22e6f7e1sm2917849d50.2.2026.02.15.19.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Feb 2026 19:20:20 -0800 (PST) From: Ethan Tidmore To: david@readahead.eu Cc: jikos@kernel.org, bentiss@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] HID: wiimote: change wiimote_cmd_map_mp() to return void Date: Sun, 15 Feb 2026 21:20:03 -0600 Message-ID: <20260216032003.37959-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function wiimote_cmd_map_mp() returns bool but no variable is ever assigned to its return value. Also, by it returning bool it causes a signedness warning from Smatch because wiimote_cmd_write() can return -EIO. Detected by Smatch: drivers/hid/hid-wiimote-core.c:510 wiimote_cmd_map_mp() warn:=20 signedness bug returning '(-512)' Signed-off-by: Ethan Tidmore --- drivers/hid/hid-wiimote-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-wiimote-core.c b/drivers/hid/hid-wiimote-core.c index 5b5fc460a4c5..c4d11ff3c898 100644 --- a/drivers/hid/hid-wiimote-core.c +++ b/drivers/hid/hid-wiimote-core.c @@ -487,7 +487,7 @@ static int wiimote_cmd_init_mp(struct wiimote_data *wda= ta) } =20 /* requires the cmd-mutex to be held */ -static bool wiimote_cmd_map_mp(struct wiimote_data *wdata, __u8 exttype) +static void wiimote_cmd_map_mp(struct wiimote_data *wdata, __u8 exttype) { __u8 wmem; =20 @@ -507,7 +507,7 @@ static bool wiimote_cmd_map_mp(struct wiimote_data *wda= ta, __u8 exttype) break; } =20 - return wiimote_cmd_write(wdata, 0xa600fe, &wmem, sizeof(wmem)); + wiimote_cmd_write(wdata, 0xa600fe, &wmem, sizeof(wmem)); } =20 /* requires the cmd-mutex to be held */ --=20 2.53.0