From nobody Fri Apr 3 03:17:15 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4D7F311964 for ; Mon, 16 Feb 2026 14:21:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771251718; cv=none; b=Tn45GC6T480FJfOQhyiux8k8ZTjTgHHZyjGSWitJMbKPLdfZv0l03sUXzd3fubXg9VsHXaeFYDr4QBL2P1GOZJjUfnEEC29f1AwEWQhFvrJf/AlCNeSPzRLoEpXWVTkozybU44Z7hKHfRg2r4w2PcgNJz/10VhJoAnXzUUbDMCE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771251718; c=relaxed/simple; bh=rBYpoHHrmScCv7WRIQFrevKZghJeIckT6rUCti4DDbo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=j0C3jD8aas43jQCrSMjN4GlrSulJR7uP/+tzahKR2Xvfj3GczP3+93Ske7pDFZIWMK54LYxfz7btaCHpANgkQcFQQxDqdGVkJJxHJwZ2bvRiMVUF/S7AbLL5r1Ykoj5LG2kh8/8nKG2sSaSeJMzBZbuj5c1iW/YvGr9IH2LK8z4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ILLdRl7O; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ILLdRl7O" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4837f27cf2dso15308865e9.2 for ; Mon, 16 Feb 2026 06:21:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771251714; x=1771856514; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fGJ5JEVkfXkcRDLD7rcIejDONU0yTWmpuXz5qQ5PddA=; b=ILLdRl7Ox1Dxt0vH/ApYMEW9W42nGx07F71Q6QyeY7MYqgINEHkQJXDKryQyY7g1Nh JEC8p2xiEi2sIVJk3Llst3kuP5zhvw3ewtjiaLuZY6HdavDN05Z3+yefAq2WzBVq+wij 4/q/yDTLJXHQyZSed9zLotwXtSbng6FDgpgVuhGmIhEo0St++G1xtVAlE5k1FGScu3XX 1SaEwATPjRcSIDtAhm4LT25dox/FOKIAaKGcpLJACZDITTw5Ww85ySMfbnhtQMWyodw0 R99kl306N4pShSaIi5utZuXIf3H/LNdWkBSb5uQNN8c8ViQtn6HJ9W5ioeu15o2V9BBS c1NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771251714; x=1771856514; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fGJ5JEVkfXkcRDLD7rcIejDONU0yTWmpuXz5qQ5PddA=; b=vJSr0C9pH6P4Kukv1KzcHxvpO5Hy2dU30bL7xDINhj2O6lFNg1IkTsaKsLJUzrX8Wc 8AE8x53MDdaXVdelNAlp6kFhkasjy0P/dYLwJBIU+CNoO2CQpsAFDnuB0CageaUEDv5+ UcFtJui14GXu+yCWYS7JBtYbsSOgpBqn/yibi8ko0+JvLTCkfQmXMvwktvHSJOlJg3ew O27fIYuQzWHNTpSYc/iQBmHRKiMGy9UlCdHbAipf8lFfyypDTHkB59MsUiJkA3HPFys8 Cn9UNrfNUFNwd6U7t8XpZ/n7EJKGrILQwzw/XFNX2fl66xy5bvmc9T+Cw2SC3l5RC2Wp b5VQ== X-Forwarded-Encrypted: i=1; AJvYcCWOp4TZ8tMG+IPGRQCe/NAIs16zNMbCfVO23/XpnM8VrMmAATsOjvHDSB5npE4yVS+ysFXDebDYdZ+KxqI=@vger.kernel.org X-Gm-Message-State: AOJu0YyxAZNT2u89C+OTn++RyZT50orEZmULMDYtU0VF9dzmgSlRdHO3 RGj1kYwHsfRWbc1Durdv+22VlsJRwtbaMeDwkp6Ep+0k1MKQuzUmgVZD6WEQjRvKfcI= X-Gm-Gg: AZuq6aJ8amsFcqJtHtjfmtZX1FY4T3wfc4/uKwLAH1ALJy4eEkXm9qzI+JTABacJG+r tHkCKjAWJY90d2jHsF59LflaYHIjGqCKS5QrLfRoHALg2iEDW22VsGTonjetRZw94Pvj/B9Ftlt LgJ8an8Wi86gnf8RNy501h/ozWqKhMhUuppkY55YkqfuKV76aAybmFm9tpNpbx1jet9Pt+wV2Wa vRv82mjzIfTfmILG9m+XcUKQ4VCXFghMSiqEuAx/B0ComA1BbeBUlOV8sSqlstc4K8Ld46yd5nC bFtDH2EYiLpuajJZiCqaFxvvvmuMCF7vvKMYt7rmk2nxzqRUjYljfr1+K14qEW1++kl/CVfX8se B3McxoGDzkVAhOm+FhtZ03WYh5mIU5IeOhKvHBF6+C+sfVUynRr+U4siHF8xEBYxa75t35DK/9l kePf1OUatCXlMhSwKJvL+HyMd4dU/MqTx++jztnrTm4Gc8 X-Received: by 2002:a05:600c:1d28:b0:480:52fd:d2e4 with SMTP id 5b1f17b1804b1-48370def8e0mr167070165e9.0.1771251714147; Mon, 16 Feb 2026 06:21:54 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:106d:1080:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48370a63afesm86717475e9.9.2026.02.16.06.21.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 06:21:53 -0800 (PST) From: Neil Armstrong Date: Mon, 16 Feb 2026 15:21:46 +0100 Subject: [PATCH v4 2/9] pci: pwrctrl: slot: fix dev_err_probe() usage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260216-topic-sm8650-ayaneo-pocket-s2-base-v4-2-802c82795431@linaro.org> References: <20260216-topic-sm8650-ayaneo-pocket-s2-base-v4-0-802c82795431@linaro.org> In-Reply-To: <20260216-topic-sm8650-ayaneo-pocket-s2-base-v4-0-802c82795431@linaro.org> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Bartosz Golaszewski , Manivannan Sadhasivam , Bjorn Helgaas , Bjorn Andersson , Konrad Dybcio Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, Neil Armstrong , Bartosz Golaszewski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1707; i=neil.armstrong@linaro.org; h=from:subject:message-id; bh=rBYpoHHrmScCv7WRIQFrevKZghJeIckT6rUCti4DDbo=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBpkyf7ynkEsMQlMdHuQv8REcBYj2EJipmHCpZ8m3Lm VXLeo/uJAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCaZMn+wAKCRB33NvayMhJ0fXYEA CRswv2o7cbBmJ5SIXmeFwDesiANasQakpkYIH2bFrbhuHe238TAWmSfcoHVyPknU3r+uBGiEKqhDgT RLfCzomv488ZnbekfOmtd90Tj2osP2iKtUGftszTUbPuBONqIofb0oj+7Lbz9I3V9segmBWPWJ4k/W 7EZxHoIInQR30vU3lB21WYY0Oxz8Sjm1T6vyNLg0+5Ic+8aJqJU1K4qsyVRpuijd0kzV1SnGR24/7g A8JlSjVAMIBc+FdiGMSIoP3/s+2Jx7Yqd9y25RcVCZB8LMvkZ7Kg6hWVyNe+h9jEwwDUhViUzYz10B uQm+0JTXXU7iI6HYto7eg3w93WLVuthzygRARTeb7ROmMIDq+4aO9GvADqOB2D1+/qJsnYjWUHjPBI T1cUQCXUkg0fjwhqe8TQ/M6K1PMeUB/OgaX7GbetLh1Fm79cWgJYQsanzjdAEdbPn1YrkoqY2DHi0t GF/8n+Uy5Sw8PDIeankxeuu8tQUlin7fgT4ebvdK2G0eE0/ObBNLuztD6Fxg18jKpcAWijAyhN1YQj QSOslFUSHh8wF+fGiJ0J3c5DmSh6Os/kLCdz6kn/7Hs81RcOV60kai+5ltzv6AuXhptNhqqB/tD0f6 hLk41hiI6Li0G/DHZHPdUqDHmHJGZNDpmKE2PS7fTcOdAywnb8vcMhiLvEEw== X-Developer-Key: i=neil.armstrong@linaro.org; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE The code was not returning dev_err_probe() but dev_err_probe() returns the error code, so simplify the code. Suggested-by: Bartosz Golaszewski Reviewed-by: Bartosz Golaszewski Signed-off-by: Neil Armstrong Reviewed-by: Manivannan Sadhasivam --- drivers/pci/pwrctrl/slot.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/pci/pwrctrl/slot.c b/drivers/pci/pwrctrl/slot.c index 3320494b62d8..08e53243cdbd 100644 --- a/drivers/pci/pwrctrl/slot.c +++ b/drivers/pci/pwrctrl/slot.c @@ -40,17 +40,14 @@ static int pci_pwrctrl_slot_probe(struct platform_devic= e *pdev) =20 ret =3D of_regulator_bulk_get_all(dev, dev_of_node(dev), &slot->supplies); - if (ret < 0) { - dev_err_probe(dev, ret, "Failed to get slot regulators\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to get slot regulators\n"); =20 slot->num_supplies =3D ret; ret =3D regulator_bulk_enable(slot->num_supplies, slot->supplies); if (ret < 0) { - dev_err_probe(dev, ret, "Failed to enable slot regulators\n"); regulator_bulk_free(slot->num_supplies, slot->supplies); - return ret; + return dev_err_probe(dev, ret, "Failed to enable slot regulators\n"); } =20 ret =3D devm_add_action_or_reset(dev, devm_pci_pwrctrl_slot_power_off, @@ -59,10 +56,9 @@ static int pci_pwrctrl_slot_probe(struct platform_device= *pdev) return ret; =20 clk =3D devm_clk_get_optional_enabled(dev, NULL); - if (IS_ERR(clk)) { + if (IS_ERR(clk)) return dev_err_probe(dev, PTR_ERR(clk), "Failed to enable slot clock\n"); - } =20 pci_pwrctrl_init(&slot->ctx, dev); =20 --=20 2.34.1