From nobody Fri Apr 3 01:24:23 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2827F23A98D for ; Sun, 15 Feb 2026 18:21:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771179712; cv=none; b=EJFxLO2A/VJKyPUUQ6usoN6cFVTSbEWy55t+h6m69Bwt1Y+5J5DIcMqVQMCXGxkd5ooWzce9oa1tJwFo/mxcFoQ0qcadVyFX5l1o3S51qIYQmqZJR9hduI6bFgSS47SBR7g1EoFvN8fFLKklIWWgR/GkuK6Bnh2phHqzMIYIjGk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771179712; c=relaxed/simple; bh=bu77IN3dKv3unoNVwnBp5YYz8WY0MpEtgYSgfVR0D7I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PfF5qv+oYKAKRr9wGofVCS+wKcP1DEG0VLjCl9NBYEFJukSUYmc+3rdGAIaH6ya7SzpE4l38iLmD70ZE6+IcXuO6r/jehNHguiAYQrAB71HCXKXDCrbfRHwXmFECdQ3ea3ZdhClSEECvam5asvKT2mqi3lcZnbJN1K3bsG3pDvw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gQBHR3PU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WxWWwZ6e; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gQBHR3PU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WxWWwZ6e" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61FENT4X1655716 for ; Sun, 15 Feb 2026 18:21:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Q9Y1cdwy9BG TV0V5PwHxjZOzyujS+TRJsJwWN1L6Km8=; b=gQBHR3PUylcBdn5Qs0sf2f1hk3n XmNVeuHtfMQwyyvqoqsDfgFa92d9yf+TQ+Hw0rO0i9ReHIPqKG8KO2yiCbSIgPFA 6HGnKb4XPaV2MABg0B3iWc9ypHBQh7Mj0FfEHWB6WYnrlXdumXg5TYpbbh9jXG37 pNaODDZMkFPP8Z7CAMNX5dKfTFnjTdDadK4icAyRjg0hZJPuDvapJLbFYirKQ+x/ BXp+JIxu58o1MRp5vKMh+BbT33qOCf43nDx8iHyNMZAl0M6lbzZR3o13165Czs8t BlII2dYs/Ci8DgMeSg7BQMxPO0yTbU0Vucz1wWSpU7gWxet4Uzt8L1iXW+w== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cbfuw08yt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 15 Feb 2026 18:21:50 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-353c9d644b0so1703803a91.2 for ; Sun, 15 Feb 2026 10:21:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771179710; x=1771784510; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q9Y1cdwy9BGTV0V5PwHxjZOzyujS+TRJsJwWN1L6Km8=; b=WxWWwZ6eMQQqJt+fwf4TZQVJ/4wl46rBoHcg2oXfSRSLTlGs9AKDuk9mxcGcjSmBMR vHDp9bQCpOMPAUwLkigNZb7aPYNFe6RV60rUhdeCKPrM8Yswu/lp7KhMSSprphTYf705 O9SdHOoXXtYaMgzFkFZgNAfkj9+8YDRJfNRrCLNiiCVeDCg4Di/F/OW9fkuFjrijlXKE lU6ZdehSbDaR0RC49jRXkCG5L4zjI3TAgwt11spxgEqS6i3EEQ54d5IUqNpacksc3+A1 6gRfkE/Q0sHU2L3jJy/lKM4z/W3qa9DwXMwa/54Uc2aKN9E+u9CAoC0tMDDrEMXkHvyw lr9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771179710; x=1771784510; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Q9Y1cdwy9BGTV0V5PwHxjZOzyujS+TRJsJwWN1L6Km8=; b=BBIL+jvHpeCit5jkZOcBHlaZWi2LDXRQXcZANPKw9+YXKoARVRxguOAc4SAJeHQCC1 tSCfRMuX7DtnVYMDARCj812sPXr36a0i81W0PZbYQER2c1hCahCzOKDFEK2P96rYaYCf bLAE5YPAcQ1EQk/SnyqCOv3nTvdnoX23FD1FBdhyVl+z/nP2LkT7053P87PH+7HMyu+x EI5i4kxCCobWx3K2z4MFnDF2LrqpyQZ5mekYk5AXer5Apiz0lnbmRdsUrQdlLoGKWNFB DfNZaRxLXe1YlqkPgaPlGe+GMqjkGtyBqfpldNi0RsE3VtpM7yInbXSymnN9mdfD8X3k 2f2A== X-Forwarded-Encrypted: i=1; AJvYcCVsP9iFuz+GBUIr4mztRBtk0XAkAFkva+5qw9wQijaup3zMtvwCxZ/2+kueSrVOTH7rgJbDiX8YEiEJXDE=@vger.kernel.org X-Gm-Message-State: AOJu0YxBREXsjvJ2a4Fn5zvpr6A8mjSpsCZGB8mqY8OgzuBTNHzNEmH5 Q+Z259IcKyuUwKPmJ1slOq2btKtPqfM8ynswIs7OvswILh2YceyBWfiYNAjclrbo1/WsAuONwtz Aec2YlotQ9eL8gz7U3z+3puth7fblRP5gIgY5Zs+AX1/ZTQRczmcOs2BSPqqt773pFz2Rb22Kzp k= X-Gm-Gg: AZuq6aKwNmNCEcPT0fGoPYdEp2dgQGEtYcFR8oZ6t/SZoL9yeVUSZuOYA+I8Kn+iGUT cQPEPNnLiECZEb/G5oluXrMPevWeT4ynppmQBntzKOO+R3gljob8UqdQLR5K5Ta9ZKoFFJpPzuT QSijmDv38nHap+gOCODtLStnca0CPbrgvZsnCaPqx1/mCP05o47h4u8Fi5ZOBU+NipR3bVuFXsp Hs6lEaMhihdK9GXR5MTjSuCYWVECxo0bNpphenXfJ9wpPgMJXzUZiHoevsk++B++roJcoIWpMuS uS8iPezIikMq1W+kfiNZItc5f3fJlcvM5vGtY3N9xzJ6dhpBLluS/2ixdQ9nZFf4UMtpqV74kKD d5JaV81msvdLK+L+WlH+pwEQRlo8Bzmuku+NXeNxmdhiblqKatE+YZA== X-Received: by 2002:a17:90b:57ce:b0:356:22b5:704f with SMTP id 98e67ed59e1d1-35844a4f70emr6013780a91.15.1771179709679; Sun, 15 Feb 2026 10:21:49 -0800 (PST) X-Received: by 2002:a17:90b:57ce:b0:356:22b5:704f with SMTP id 98e67ed59e1d1-35844a4f70emr6013761a91.15.1771179709203; Sun, 15 Feb 2026 10:21:49 -0800 (PST) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35662e537desm17425381a91.4.2026.02.15.10.21.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Feb 2026 10:21:48 -0800 (PST) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, Konrad Dybcio Subject: [PATCH v6 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Date: Sun, 15 Feb 2026 23:51:33 +0530 Message-Id: <20260215182136.3995111-3-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260215182136.3995111-1-ekansh.gupta@oss.qualcomm.com> References: <20260215182136.3995111-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=Jb+xbEKV c=1 sm=1 tr=0 ts=69920ebe cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=9Nm459TXYEgc-GpAQpYA:9 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: zx1P2dH3Auw_bWIhqAdmY-o4bx8YQtJB X-Proofpoint-GUID: zx1P2dH3Auw_bWIhqAdmY-o4bx8YQtJB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE1MDE1NCBTYWx0ZWRfX4pkvcccVSD14 uFQYFBTIHMdgC4MW+bk1DQ74HuXaHaNhWPFfPkkAl4gB2ioK6yjFbgX9eG/HB2CrH7gWUy63OBn dzstei1Rjg3PLa0uqHRruUJNvHUpXUb6i0dkknrnB/wkHY7kpqQ5zyKU3gw64Q2tjgXhev1aYky sMy7euCT4cfteK8LVHbzeVTHX+yAwErSbzW+3iboVS1IzCJiLM2mmdbHHCdI0ZCXKexhe45ZIac xFZlgdN+Hd0OqO4s+q13EAA6HN2KSwDJex68v3zAkjYAa2gw8oHaXeVZVoZWnj9n0IqGgNvszoA YUqX5kT5q5UhKi8WrHkQwdE+oc+eBTqtNJ/SuskQ8Qyw8hj+Hp5px5JLnpePTPCp34TT0ZQCVzM akYI3FfzeTfDJwgc+zl9Cb/do9LLXjPTG3udVHV/kYCdmkosxu91y08FyDJ10dhSiroVnPrV4AG 4LxTa6KfEVmq3yvb4SA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-15_06,2026-02-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602150154 Content-Type: text/plain; charset="utf-8" Replace the hardcoded context ID mask (0xFF0) with GENMASK(11, 4) to improve readability and follow kernel bitfield conventions. Use FIELD_PREP and FIELD_GET instead of manual shifts for setting and extracting ctxid values. Reviewed-by: Konrad Dybcio Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index ce397c687161..0d8d89a2e220 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -37,7 +37,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 -#define FASTRPC_CTXID_MASK (0xFF0) +#define FASTRPC_CTXID_MASK GENMASK(11, 4) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) #define FASTRPC_DEVICE_NAME "fastrpc" @@ -515,7 +515,7 @@ static void fastrpc_context_free(struct kref *ref) fastrpc_buf_free(ctx->buf); =20 spin_lock_irqsave(&cctx->lock, flags); - idr_remove(&cctx->ctx_idr, ctx->ctxid >> 4); + idr_remove(&cctx->ctx_idr, FIELD_GET(FASTRPC_CTXID_MASK, ctx->ctxid)); spin_unlock_irqrestore(&cctx->lock, flags); =20 kfree(ctx->maps); @@ -651,7 +651,7 @@ static struct fastrpc_invoke_ctx *fastrpc_context_alloc( spin_unlock_irqrestore(&cctx->lock, flags); goto err_idr; } - ctx->ctxid =3D ret << 4; + ctx->ctxid =3D FIELD_PREP(FASTRPC_CTXID_MASK, ret); spin_unlock_irqrestore(&cctx->lock, flags); =20 kref_init(&ctx->refcount); @@ -2506,7 +2506,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device= *rpdev, void *data, if (len < sizeof(*rsp)) return -EINVAL; =20 - ctxid =3D ((rsp->ctx & FASTRPC_CTXID_MASK) >> 4); + ctxid =3D FIELD_GET(FASTRPC_CTXID_MASK, rsp->ctx); =20 spin_lock_irqsave(&cctx->lock, flags); ctx =3D idr_find(&cctx->ctx_idr, ctxid); --=20 2.34.1