From nobody Thu Apr 2 23:55:28 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4038B2D7DE7 for ; Sun, 15 Feb 2026 18:21:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771179708; cv=none; b=TW/UjF6W9BZA1RMJ0kn8PCmsKCADeZINREu4UWnCHr3cdmiSaSM2EQK1bzTktbDQkIsl8VVGS/qPymChI6zg9tgyRALDEcV4EWkePCmon4TB0Ywuba0DOEiainTIbKbPY4EU6aX+GZfWvKIql9nWhad3/xvF7rJMK21HdRwr8RM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771179708; c=relaxed/simple; bh=aYT9V4yjMFimp7i5AH4FrQXb7/rLIpKhB4tul51jh5g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YfWaLGjjRwbb7TfC1nkAs9njROGbx+XroCi4jXj0irolROF/t7r8mZSmiYt55MFqLcMxhk/tWIUONGxnY1wxbp5Op4w9jwL9wO/+blVdTroQ44F/KN9vbzWV0YhP6mkm8Se7H/bN+8QzPk/ukqKQmRgDVILM0GnxVWMOO5WGIo8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=E+RgyxQW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P9PdyRnC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="E+RgyxQW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P9PdyRnC" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61FB0cdp1525347 for ; Sun, 15 Feb 2026 18:21:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=wwOwIZrghwl 5hfUtSY4NZTKubqv0dn/EyjKwV7U9g9A=; b=E+RgyxQWdFXLZYrSJYq5GRl3oig HV9uQBOR3sDUmD8PIfsybURlJxigPozzSSHtQXEdYHefD8jtBrK/DH0jGSMYNAfe eQ/vXvY6j4aEKajjwKXB+0Xi2dY4TnmxotEAETbDVt4F5lANd8YjBGasdTTrzUqF qatfTrsSvRq+Wlp90+ADZQmfpUQwK0fpfVF4fw5G6iQCFZKUUOBwQhrj84HuaxpB KVKYal5eutZm8NVkKEtG4ajciuxqN52MWW86dc1CTXgltqOEIW8qleCWuW5jODJ0 r3BQKoKZLWedg4EMOG320WMXHlFtV444FxWQfv9KcvPvgusj4I7aC1Y9PCw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cahtcjkhg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 15 Feb 2026 18:21:46 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35845fcf0f5so1313573a91.0 for ; Sun, 15 Feb 2026 10:21:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771179706; x=1771784506; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wwOwIZrghwl5hfUtSY4NZTKubqv0dn/EyjKwV7U9g9A=; b=P9PdyRnCmqpIs4J0FyzPvNUIK2AHOom/yZQHe6MQFIM0+4gFQRxdM/XZYdhE/CDxDa dtv4GDK9JcqO4F5BYiW/1XUeBWDc7mMx4J9/wqOAsnx4moalSdNagyAgejR3Vy5oM4I9 t50IBwGhBCbxODNwYDSHpiTpiTa2Qw+YyuR3VQIZDPEAfRm3ASh8K/Lc69Hj5WSCUHYY yE66I2DIRAPOzHIW3mnKbsGXQDfRpEl1gQd8pnBZ7gCoiyCD4ojuyMAXV5ZhftukGZt2 awRsv6ApF3NvMFAMrD2xVtOCsGl9/Z0G5RmICCJGaQQfCImGDLl7gUYv4zjBJWz+V5MI oyAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771179706; x=1771784506; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wwOwIZrghwl5hfUtSY4NZTKubqv0dn/EyjKwV7U9g9A=; b=WYxQZ04EnRfmzqc2HZA7cz2KeEqFT7pYnQCs4ZcuyhPaqOyUq3BYj7wuDzY4aK6Tld qtcodEGaDmyrVbrW5KRnugTyHPX+wEi62QQJzGr0dcmf8IvNLlc4uKhxxT7Iqb3Turgk LAhQzP5qrTAjFt9SgNyXSy6ZuS/GjOstd7N61KhbnkxtqzN4p4LHuPpoleOku4h+OrLx BCCPdQXpwTr22c076rH76emsKKYabMDZSQf75Iucjb0aSKWibqqbyPTiFkAfkIVK/OMB WB/WXPOFRe8xNYef2/pQQxMUI4r8XMVD5HDrNfJlQ5szDpxGK6B9Z2DJqrc6HS9GF787 koRw== X-Forwarded-Encrypted: i=1; AJvYcCWS1slLBZ6epuIb6SgZn+KmSmKZccra/jBPQqjRn6UjMHeWEjPx+gCMD+L4ECiONE+RPYgksWG855x2Ogk=@vger.kernel.org X-Gm-Message-State: AOJu0YzqkjXEwdgxQ7hiauAIbr2dX69SR4F4hBScVjVdMhAVWMLx5ezQ Q3ryeg5pA3jJkm+lXFlhJao2gHjpb+UXQLm4d/tJbq/HcwpEt7MEY7D3RykZcxepGw/6PAhiJZI wT4WDdksMt+USEOqSZM+x3WwEYi4y9EjGCBtYQCEwWvYsLCMaG5T93YCHWtXtUoaYuz8= X-Gm-Gg: AZuq6aJk+W9G1GAtWbPtpmZG39IRpFIisJ1e3zFZKsuC+QL5crz6u8LjR3EX84UO+hQ Ppx5rqe03dtMvOFlBNnC8br/nBDdalyvrVw0Ggn5+blaaoQsIBtuJeaVUusxZ1PCTxilJY859SJ F6BANQs047c7CR4ChHPSoaoqtNNH2RKwAlUEJAtSWKVub1KjzHIUeOHIEzUltxNBfoFP5a1CWTc 3Aj5VoMwuYyryJN/ak0IWyKZKoAJ5RBPbgGAByzVXcTnHePjUCdZaOPvR5TQXODiCiGfRWzrgeS 7lbM1Gct+y0EMuGkirpEQRIQ8Ygf4zS8QIeF62GQzzlf8+kVNEmzIoSGlqI2tKO8DgC89w1Zkxm QbzLdJaA5XQIlgvfjiWtbflkq48Xv7XtplqfwPRtbmjQAY0JqfyaboQ== X-Received: by 2002:a17:90b:3e48:b0:353:2972:74a4 with SMTP id 98e67ed59e1d1-357b51ad1c2mr5356577a91.13.1771179705627; Sun, 15 Feb 2026 10:21:45 -0800 (PST) X-Received: by 2002:a17:90b:3e48:b0:353:2972:74a4 with SMTP id 98e67ed59e1d1-357b51ad1c2mr5356567a91.13.1771179705097; Sun, 15 Feb 2026 10:21:45 -0800 (PST) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35662e537desm17425381a91.4.2026.02.15.10.21.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Feb 2026 10:21:44 -0800 (PST) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com Subject: [PATCH v6 1/4] misc: fastrpc: Move fdlist to invoke context structure Date: Sun, 15 Feb 2026 23:51:32 +0530 Message-Id: <20260215182136.3995111-2-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260215182136.3995111-1-ekansh.gupta@oss.qualcomm.com> References: <20260215182136.3995111-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE1MDE1NCBTYWx0ZWRfX9x8YnLhMaNtF HHK1FH28B1I40YKW/CIMnwFt/t9EIzLxrDc1dgmwnQwokAfhvPEFlPka9mwd6lyb3qwRVMA/Ago lWj4ZgNsisFl1RW5wl7WSy/q/ZqCNIvbgc51rgp7TR77zbGSPC5eM013nnGu7c/LmxIWaO3NBNx qo3f7tjSoBwnAVUQ6JZ7YDH5S33ZSBGOLFZRT+sBwVO9xeDEbnALeekHhR8ImersrmaT1+l32RL fKNdcWOlPsmrELLPnZB9NNXYlgonlwjramnoSWtcWKiNabe9sQ4Nf0xj8KJHzRZmXo6GiTT6KPx I+1qmHIhGPOFp6/m+c0S+fPJdPg7AjhgjmYqxQ40WSphAdMa0gts89FoJ8Byld5PfvlmE4bO71N iEedpkO1LDOfZddA95QohbThZDNbXbMLWFcK35GqTaRgLnAZTaTLe2jxnnpCs2ikujy/R+kgvV0 IgzIDkwt+Atz73TtulA== X-Proofpoint-ORIG-GUID: 3Vz5LAXc6MFVmVd5G6oMGX5rJvJ8mown X-Authority-Analysis: v=2.4 cv=DJOCIiNb c=1 sm=1 tr=0 ts=69920eba cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=hRzSbfjIAxXVlyYcgJ4A:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: 3Vz5LAXc6MFVmVd5G6oMGX5rJvJ8mown X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-15_06,2026-02-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 adultscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602150154 Content-Type: text/plain; charset="utf-8" The fdlist is currently part of the meta buffer, computed during put_args. This leads to code duplication when preparing and reading critical meta buffer contents used by the FastRPC driver. Move fdlist to the invoke context structure to improve maintainability and reduce redundancy. This centralizes its handling and simplifies meta buffer preparation and reading logic. Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 4f5a79c50f58..ce397c687161 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -233,6 +233,7 @@ struct fastrpc_invoke_ctx { int pid; int client_id; u32 sc; + u64 *fdlist; u32 *crc; u64 ctxid; u64 msg_sz; @@ -1018,6 +1019,7 @@ static int fastrpc_get_args(u32 kernel, struct fastrp= c_invoke_ctx *ctx) rpra =3D ctx->buf->virt; list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); pages =3D fastrpc_phy_page_start(list, ctx->nscalars); + ctx->fdlist =3D (u64 *)(pages + ctx->nscalars); args =3D (uintptr_t)ctx->buf->virt + metalen; rlen =3D pkt_size - metalen; ctx->rpra =3D rpra; @@ -1120,18 +1122,10 @@ static int fastrpc_put_args(struct fastrpc_invoke_c= tx *ctx, union fastrpc_remote_arg *rpra =3D ctx->rpra; struct fastrpc_user *fl =3D ctx->fl; struct fastrpc_map *mmap =3D NULL; - struct fastrpc_invoke_buf *list; - struct fastrpc_phy_page *pages; - u64 *fdlist; - int i, inbufs, outbufs, handles; + int i, inbufs; int ret =3D 0; =20 inbufs =3D REMOTE_SCALARS_INBUFS(ctx->sc); - outbufs =3D REMOTE_SCALARS_OUTBUFS(ctx->sc); - handles =3D REMOTE_SCALARS_INHANDLES(ctx->sc) + REMOTE_SCALARS_OUTHANDLES= (ctx->sc); - list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); - pages =3D fastrpc_phy_page_start(list, ctx->nscalars); - fdlist =3D (uint64_t *)(pages + inbufs + outbufs + handles); =20 for (i =3D inbufs; i < ctx->nbufs; ++i) { if (!ctx->maps[i]) { @@ -1153,9 +1147,9 @@ static int fastrpc_put_args(struct fastrpc_invoke_ctx= *ctx, cleanup_fdlist: /* Clean up fdlist which is updated by DSP */ for (i =3D 0; i < FASTRPC_MAX_FDLIST; i++) { - if (!fdlist[i]) + if (!ctx->fdlist[i]) break; - if (!fastrpc_map_lookup(fl, (int)fdlist[i], &mmap)) + if (!fastrpc_map_lookup(fl, (int)ctx->fdlist[i], &mmap)) fastrpc_map_put(mmap); } =20 --=20 2.34.1 From nobody Thu Apr 2 23:55:28 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2827F23A98D for ; Sun, 15 Feb 2026 18:21:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771179712; cv=none; b=EJFxLO2A/VJKyPUUQ6usoN6cFVTSbEWy55t+h6m69Bwt1Y+5J5DIcMqVQMCXGxkd5ooWzce9oa1tJwFo/mxcFoQ0qcadVyFX5l1o3S51qIYQmqZJR9hduI6bFgSS47SBR7g1EoFvN8fFLKklIWWgR/GkuK6Bnh2phHqzMIYIjGk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771179712; c=relaxed/simple; bh=bu77IN3dKv3unoNVwnBp5YYz8WY0MpEtgYSgfVR0D7I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PfF5qv+oYKAKRr9wGofVCS+wKcP1DEG0VLjCl9NBYEFJukSUYmc+3rdGAIaH6ya7SzpE4l38iLmD70ZE6+IcXuO6r/jehNHguiAYQrAB71HCXKXDCrbfRHwXmFECdQ3ea3ZdhClSEECvam5asvKT2mqi3lcZnbJN1K3bsG3pDvw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gQBHR3PU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WxWWwZ6e; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gQBHR3PU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WxWWwZ6e" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61FENT4X1655716 for ; Sun, 15 Feb 2026 18:21:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Q9Y1cdwy9BG TV0V5PwHxjZOzyujS+TRJsJwWN1L6Km8=; b=gQBHR3PUylcBdn5Qs0sf2f1hk3n XmNVeuHtfMQwyyvqoqsDfgFa92d9yf+TQ+Hw0rO0i9ReHIPqKG8KO2yiCbSIgPFA 6HGnKb4XPaV2MABg0B3iWc9ypHBQh7Mj0FfEHWB6WYnrlXdumXg5TYpbbh9jXG37 pNaODDZMkFPP8Z7CAMNX5dKfTFnjTdDadK4icAyRjg0hZJPuDvapJLbFYirKQ+x/ BXp+JIxu58o1MRp5vKMh+BbT33qOCf43nDx8iHyNMZAl0M6lbzZR3o13165Czs8t BlII2dYs/Ci8DgMeSg7BQMxPO0yTbU0Vucz1wWSpU7gWxet4Uzt8L1iXW+w== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cbfuw08yt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 15 Feb 2026 18:21:50 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-353c9d644b0so1703803a91.2 for ; Sun, 15 Feb 2026 10:21:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771179710; x=1771784510; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q9Y1cdwy9BGTV0V5PwHxjZOzyujS+TRJsJwWN1L6Km8=; b=WxWWwZ6eMQQqJt+fwf4TZQVJ/4wl46rBoHcg2oXfSRSLTlGs9AKDuk9mxcGcjSmBMR vHDp9bQCpOMPAUwLkigNZb7aPYNFe6RV60rUhdeCKPrM8Yswu/lp7KhMSSprphTYf705 O9SdHOoXXtYaMgzFkFZgNAfkj9+8YDRJfNRrCLNiiCVeDCg4Di/F/OW9fkuFjrijlXKE lU6ZdehSbDaR0RC49jRXkCG5L4zjI3TAgwt11spxgEqS6i3EEQ54d5IUqNpacksc3+A1 6gRfkE/Q0sHU2L3jJy/lKM4z/W3qa9DwXMwa/54Uc2aKN9E+u9CAoC0tMDDrEMXkHvyw lr9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771179710; x=1771784510; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Q9Y1cdwy9BGTV0V5PwHxjZOzyujS+TRJsJwWN1L6Km8=; b=BBIL+jvHpeCit5jkZOcBHlaZWi2LDXRQXcZANPKw9+YXKoARVRxguOAc4SAJeHQCC1 tSCfRMuX7DtnVYMDARCj812sPXr36a0i81W0PZbYQER2c1hCahCzOKDFEK2P96rYaYCf bLAE5YPAcQ1EQk/SnyqCOv3nTvdnoX23FD1FBdhyVl+z/nP2LkT7053P87PH+7HMyu+x EI5i4kxCCobWx3K2z4MFnDF2LrqpyQZ5mekYk5AXer5Apiz0lnbmRdsUrQdlLoGKWNFB DfNZaRxLXe1YlqkPgaPlGe+GMqjkGtyBqfpldNi0RsE3VtpM7yInbXSymnN9mdfD8X3k 2f2A== X-Forwarded-Encrypted: i=1; AJvYcCVsP9iFuz+GBUIr4mztRBtk0XAkAFkva+5qw9wQijaup3zMtvwCxZ/2+kueSrVOTH7rgJbDiX8YEiEJXDE=@vger.kernel.org X-Gm-Message-State: AOJu0YxBREXsjvJ2a4Fn5zvpr6A8mjSpsCZGB8mqY8OgzuBTNHzNEmH5 Q+Z259IcKyuUwKPmJ1slOq2btKtPqfM8ynswIs7OvswILh2YceyBWfiYNAjclrbo1/WsAuONwtz Aec2YlotQ9eL8gz7U3z+3puth7fblRP5gIgY5Zs+AX1/ZTQRczmcOs2BSPqqt773pFz2Rb22Kzp k= X-Gm-Gg: AZuq6aKwNmNCEcPT0fGoPYdEp2dgQGEtYcFR8oZ6t/SZoL9yeVUSZuOYA+I8Kn+iGUT cQPEPNnLiECZEb/G5oluXrMPevWeT4ynppmQBntzKOO+R3gljob8UqdQLR5K5Ta9ZKoFFJpPzuT QSijmDv38nHap+gOCODtLStnca0CPbrgvZsnCaPqx1/mCP05o47h4u8Fi5ZOBU+NipR3bVuFXsp Hs6lEaMhihdK9GXR5MTjSuCYWVECxo0bNpphenXfJ9wpPgMJXzUZiHoevsk++B++roJcoIWpMuS uS8iPezIikMq1W+kfiNZItc5f3fJlcvM5vGtY3N9xzJ6dhpBLluS/2ixdQ9nZFf4UMtpqV74kKD d5JaV81msvdLK+L+WlH+pwEQRlo8Bzmuku+NXeNxmdhiblqKatE+YZA== X-Received: by 2002:a17:90b:57ce:b0:356:22b5:704f with SMTP id 98e67ed59e1d1-35844a4f70emr6013780a91.15.1771179709679; Sun, 15 Feb 2026 10:21:49 -0800 (PST) X-Received: by 2002:a17:90b:57ce:b0:356:22b5:704f with SMTP id 98e67ed59e1d1-35844a4f70emr6013761a91.15.1771179709203; Sun, 15 Feb 2026 10:21:49 -0800 (PST) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35662e537desm17425381a91.4.2026.02.15.10.21.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Feb 2026 10:21:48 -0800 (PST) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, Konrad Dybcio Subject: [PATCH v6 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Date: Sun, 15 Feb 2026 23:51:33 +0530 Message-Id: <20260215182136.3995111-3-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260215182136.3995111-1-ekansh.gupta@oss.qualcomm.com> References: <20260215182136.3995111-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=Jb+xbEKV c=1 sm=1 tr=0 ts=69920ebe cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=9Nm459TXYEgc-GpAQpYA:9 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: zx1P2dH3Auw_bWIhqAdmY-o4bx8YQtJB X-Proofpoint-GUID: zx1P2dH3Auw_bWIhqAdmY-o4bx8YQtJB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE1MDE1NCBTYWx0ZWRfX4pkvcccVSD14 uFQYFBTIHMdgC4MW+bk1DQ74HuXaHaNhWPFfPkkAl4gB2ioK6yjFbgX9eG/HB2CrH7gWUy63OBn dzstei1Rjg3PLa0uqHRruUJNvHUpXUb6i0dkknrnB/wkHY7kpqQ5zyKU3gw64Q2tjgXhev1aYky sMy7euCT4cfteK8LVHbzeVTHX+yAwErSbzW+3iboVS1IzCJiLM2mmdbHHCdI0ZCXKexhe45ZIac xFZlgdN+Hd0OqO4s+q13EAA6HN2KSwDJex68v3zAkjYAa2gw8oHaXeVZVoZWnj9n0IqGgNvszoA YUqX5kT5q5UhKi8WrHkQwdE+oc+eBTqtNJ/SuskQ8Qyw8hj+Hp5px5JLnpePTPCp34TT0ZQCVzM akYI3FfzeTfDJwgc+zl9Cb/do9LLXjPTG3udVHV/kYCdmkosxu91y08FyDJ10dhSiroVnPrV4AG 4LxTa6KfEVmq3yvb4SA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-15_06,2026-02-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602150154 Content-Type: text/plain; charset="utf-8" Replace the hardcoded context ID mask (0xFF0) with GENMASK(11, 4) to improve readability and follow kernel bitfield conventions. Use FIELD_PREP and FIELD_GET instead of manual shifts for setting and extracting ctxid values. Reviewed-by: Konrad Dybcio Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index ce397c687161..0d8d89a2e220 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -37,7 +37,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 -#define FASTRPC_CTXID_MASK (0xFF0) +#define FASTRPC_CTXID_MASK GENMASK(11, 4) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) #define FASTRPC_DEVICE_NAME "fastrpc" @@ -515,7 +515,7 @@ static void fastrpc_context_free(struct kref *ref) fastrpc_buf_free(ctx->buf); =20 spin_lock_irqsave(&cctx->lock, flags); - idr_remove(&cctx->ctx_idr, ctx->ctxid >> 4); + idr_remove(&cctx->ctx_idr, FIELD_GET(FASTRPC_CTXID_MASK, ctx->ctxid)); spin_unlock_irqrestore(&cctx->lock, flags); =20 kfree(ctx->maps); @@ -651,7 +651,7 @@ static struct fastrpc_invoke_ctx *fastrpc_context_alloc( spin_unlock_irqrestore(&cctx->lock, flags); goto err_idr; } - ctx->ctxid =3D ret << 4; + ctx->ctxid =3D FIELD_PREP(FASTRPC_CTXID_MASK, ret); spin_unlock_irqrestore(&cctx->lock, flags); =20 kref_init(&ctx->refcount); @@ -2506,7 +2506,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device= *rpdev, void *data, if (len < sizeof(*rsp)) return -EINVAL; =20 - ctxid =3D ((rsp->ctx & FASTRPC_CTXID_MASK) >> 4); + ctxid =3D FIELD_GET(FASTRPC_CTXID_MASK, rsp->ctx); =20 spin_lock_irqsave(&cctx->lock, flags); ctx =3D idr_find(&cctx->ctx_idr, ctxid); --=20 2.34.1 From nobody Thu Apr 2 23:55:28 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90DFF260566 for ; Sun, 15 Feb 2026 18:21:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771179715; cv=none; b=fyayO8x+HVZiZsU3mPHoG0An63s7N5NtBjS+SsHXJWoQ6MJs318ts6G0ymL2pYwyMg8flaMgsUYAFKYQCO4F5vpteDKHeJY7hV2BJFlakrSgx2KsLiU0tMUYwYD8QA46dVwTJe8Y2/q2qE1x/zD5+4bS+UAH0H9VbXYCozHLjvU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771179715; c=relaxed/simple; bh=xKLYuFz+4tSIoIWOitziYVUW3AUr5T96HlM73lCZEcU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oYO88QoIZZKleSQR6SEQP/1WZfaOhprnRf3dqCGc3RxpODeC4mvhbNzRe6YzRUbotSFHlXtJ1CK84jjfCERRpo+mjszmqj9LIjH1KhGSMJM1X9IjO6bav/BV14bjUELIyH0wbLgi/OqWAlPpDB80GPoHTnqPXFDV2lVFSG5zMrs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GyNm6z+3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=auFbO++c; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GyNm6z+3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="auFbO++c" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61FGrbKo2805041 for ; Sun, 15 Feb 2026 18:21:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=dgIREKXxj6b F+RK+0EKrSCsOy0Evz93lE4MQnPBprCM=; b=GyNm6z+3I0pB2OU0aKhe0aSTdQT HTxBeG08B5yKu37p+ohkm8k7DwfncUn30Xhiv5u82zMbEi9MGbV/QkwghlCkFBBW SRy7kUfI1TXKM+Dp3aEOlp6Q60EoMNvnvJPjLkUWutnuS0WSLRQ0CaIqjMnj0ZMu raTpAhosaFg5btRJQDhkcpcQSY3762iPdAM2Dt0whLRNY7N0bNrDzFO1pDCDLulF V9vib4AjbW7/Vxf2jz3DmHpaZvJL7M3KOuMufPj/q8QWz8Ta1zNa8VOD8wUN6pjF l7mOPC3Xh7QmZmuC6PY3pDcOstRucw8nTc1sQHT4vcxbOwBF3ptn9cgg0XA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4caj7jajj8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 15 Feb 2026 18:21:53 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-352e6fcd72dso7765748a91.3 for ; Sun, 15 Feb 2026 10:21:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771179713; x=1771784513; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dgIREKXxj6bF+RK+0EKrSCsOy0Evz93lE4MQnPBprCM=; b=auFbO++cpyF1OTHazPHCmiLoQDnnwYqdK+725DNvYnTh1vJ93/zd26npJh+SrZ9pfs GpRWVaFQACC4IwPIZNoW+QR3yiBLbjGUfTwmK2ZPfkKcewOJAgySe94uILBfNdOOhsuo h/05BlJfZOVzJdIkArLS3xIsuz5XPkTGQQIoNIWH77yRo2+/UxEoXw4okeaPK/yoW6YX duU7qW71+kWywXbSTTcsnAVPEdtD7fBfjO9joKziADZ3I9HGNbMQd+K/NZG0ms3i3h2I eNynC+0VlIYr76P7uhBC1IS3Q13psZPpg5WMLzFCVPkcNfSPWWImV+VFnRHxs7cF/YJN D6vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771179713; x=1771784513; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dgIREKXxj6bF+RK+0EKrSCsOy0Evz93lE4MQnPBprCM=; b=Jmnj7u9oib8bZ6pTh4/Q+PWPqzqMkIAnlaMoeSglnNSclDI9RfXC3JecfBebTxjF26 AaeKsT5eD6OPMg2xxpGfqtLBhHXM6wQ0DAc4aJLCAHNb+mW1P2ZGW0XOk1wgaCjlBnxC /YmklxZb4HppdAQpvNu2bbFx6CN2YrL1f5mwR/2qsRSlEcQYf5jKwtcxt2p0CU/e9CBu 9IHlfHIt06MVSOBiMEuVg85m8KZSqOBFX8iYVOfRNuE79fvhtC22JZTHM2TBOwDyr0Dj 4KEvLOnkDjRpLZtwx3KGzEhuRe/P5DdKJvIZ6H3nQb9uShBOpWT9TCt2Efb3qpLHvLwv xZKA== X-Forwarded-Encrypted: i=1; AJvYcCVPElYGdTSg5+deaRHbkfC5W+9OSCG+ms3D2YK0xu3y85+0X3wXB0VOI4JfamYSwaPMsJUHlKwzPTeFX9g=@vger.kernel.org X-Gm-Message-State: AOJu0YypVbIu4qlgBGM/+xr+A3/1D/S/OoIX6iHJMttI/DFmOv+buXf2 OqfKxNxR4RraMbumAKq+iTxmRjVdZenJYlMv0qWNNECFVjmdANEeh3u6t/sHfc1VlHDl+cth8h+ AnVzBX7cwTdqe3dStqkSAgNvEB/r/PORaCFf7a/C+HOVaBC+OUvX+Ku6nGQsmzrepkQI= X-Gm-Gg: AZuq6aK1pLPNxHi9FEefn9kYJ7iGe8Ug0MvhzUe8ptIxTZfXidEVvKOfm7k6kNnv5k7 dsKEQsDYIM/bbiNypn3redIuNBnyKDgr2mRkCL63R/rs0e3n2Ko7t8N7LgUJmsh//WhGvWOpK6j yQrdthb2k3UFcywMf8ZaqDC+TqSqiZcodOX4iBSHTSXeZkUd8u0WTLN3oPLwZOL/KDYKfZzfrKk ohcTLzSzUFN7iuLVB2YoxBUjziYx5PSLS/cvQRjTpdDX3vBlmKjMa77J9sDC+I3uBUhTsUHrC+e f2Q72+WAFSXmpYVP0G+IUyBnrpiG4HSdffDGPpKNF9jWKRfJrTwZ1S/TtPTuCnKyeeCSh3R4xcy QhIeRbBW6jHATkDg/ox7ELoN5KHm0CCJtZj7TjU6IFm2yD1lYUwh15w== X-Received: by 2002:a17:90b:554d:b0:34a:b1ea:6648 with SMTP id 98e67ed59e1d1-35844819f9amr4757693a91.2.1771179713117; Sun, 15 Feb 2026 10:21:53 -0800 (PST) X-Received: by 2002:a17:90b:554d:b0:34a:b1ea:6648 with SMTP id 98e67ed59e1d1-35844819f9amr4757678a91.2.1771179712598; Sun, 15 Feb 2026 10:21:52 -0800 (PST) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35662e537desm17425381a91.4.2026.02.15.10.21.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Feb 2026 10:21:52 -0800 (PST) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com Subject: [PATCH v6 3/4] misc: fastrpc: Expand context ID mask for DSP polling mode support Date: Sun, 15 Feb 2026 23:51:34 +0530 Message-Id: <20260215182136.3995111-4-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260215182136.3995111-1-ekansh.gupta@oss.qualcomm.com> References: <20260215182136.3995111-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=dIurWeZb c=1 sm=1 tr=0 ts=69920ec1 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=JTa3dIKMUYn8LlmgGFYA:9 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE1MDE1NCBTYWx0ZWRfX/LeOykM46n6v WwSAfNsi6rtXxj1vCNBIw6JeegIr2HTawMl0V3vqrmA0j/mPIx51tAZQEogUI5YM7etEd5tgDW3 6UJ9J0SVvXTz0pZFylqbfSHptWq5re2x3M4JfaUOCfz/rkx7bdEuBuEZU/5L+JswagB7yV5N3k7 OEudVWOpy5yGlpCj3H91l5ENYwaki4/eoEkrfMCiWZOsPtReNLG7y6Gg7XnyFJa0WA6iTHEbcWL O+5lrQXXxkazwIxPS5g7cYTGobQ9tFa+xxCsTOD8c3W99LSBPVqfmHNML7K5maTFfz8CESDnMTI HRsPVn6lDG3ELLgvv3Q3T3PsM6XdCaghFYMJ8XNB+MOG4JlSiNhXUJBSmRXezcA6PR9P5r5KriP /C3uDBN0uuR/GQbuzj3trIV+k0cxwUvDMNksCfo2OKo7z/OfhVwPa+Sd/dsCzFDi8OVoNFvWcJG Neu/XpWGPn/tQB6/d9g== X-Proofpoint-GUID: Uicf0nTkM4SukN7eaunYgXc8Ju7dax1j X-Proofpoint-ORIG-GUID: Uicf0nTkM4SukN7eaunYgXc8Ju7dax1j X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-15_06,2026-02-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 malwarescore=0 phishscore=0 suspectscore=0 impostorscore=0 spamscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602150154 Content-Type: text/plain; charset="utf-8" Current FastRPC context uses a 12-bit mask: [ID(8 bits)][PD type(4 bits)] =3D GENMASK(11, 4) This works for normal calls but fails for DSP polling mode. Polling mode expects a 16-bit layout: [15:8] =3D context ID (8 bits) [7:5] =3D reserved [4] =3D async mode bit [3:0] =3D PD type (4 bits) If async bit (bit 4) is set, DSP disables polling. With current mask, odd IDs can set this bit, causing DSP to skip poll updates. Update FASTRPC_CTXID_MASK to GENMASK(15, 8) so IDs occupy upper byte and lower byte is left for DSP flags and PD type. Reserved bits remain unused. This change is compatible with polling mode and does not break non-polling behavior. Bit layout: [15:8] =3D CCCCCCCC (context ID) [7:5] =3D xxx (reserved) [4] =3D A (async mode) [3:0] =3D PPPP (PD type) Reviewed-by: Dmitry Baryshkov Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 0d8d89a2e220..e935ae3776b4 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -37,7 +37,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 -#define FASTRPC_CTXID_MASK GENMASK(11, 4) +#define FASTRPC_CTXID_MASK GENMASK(15, 8) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) #define FASTRPC_DEVICE_NAME "fastrpc" --=20 2.34.1 From nobody Thu Apr 2 23:55:28 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE25024A07C for ; Sun, 15 Feb 2026 18:21:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771179721; cv=none; b=Hkk8rsWrHrP78Y3ilsv79VznbEfMpw3K3nlIXpbDAae+1Ab/BSmQxcvjfUF0S6khKx+0Pu09W8eFy95k8WqpE3Qe9AsdLnLM35ftIXMZKlkkVLZn8qZcYsttQ9iNDo2lyjZF6Rv3W5OBawOqi+0MHPIH+1heyXmCzOKE9ox2HFg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771179721; c=relaxed/simple; bh=STY/1vpCxJE+Z5mXhfQq3qbVCUwkW8XKChaHH3/w+TQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eJuZffyXQeKueN/v19Pg4UrbuK0+SSH8psEift7ipl42q/ePqPxUuXGp2FZbKIANsv3Koqou6fqhkR1nd5C2rGRMr9r811JsLXQvWv9ZLw3Z9wcA5son3iPBGnG67hqX88xXTbAVR8rNzST6Oam1V682cKxjYAjiPr2bN8bOXVs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JuWDinaw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gy8WGiEO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JuWDinaw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gy8WGiEO" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61FGNlOc1628544 for ; Sun, 15 Feb 2026 18:21:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=gGsuTZLqUpw Y7hBhRIBjA23F5oruK4sDevnmC00HExE=; b=JuWDinawK4rIemrbhe67N3ndm5I CCQm+M1r9uRXN3kY1ano5HhqIdcq3YXaVw+/4lmwFXR6gd/KuEj+9Yxn4fdGCwEw h3pBY8bthhkvwnfl7GmESir16JE7KzhmhVF5eI2XtJtadS4bt4zJXU7iUVNTq/0o TLREoi1inxSImpYi7zKN7ymmm47004gp16CzvkHOJOHIqSTBUanxRdOo30tS0bvm WsvFERx7E11HFNaqqSAJgbpZdQnNZPRRQoduo+WvJvbqSqNDPPnG7XLE/BO7f/l7 PwIaS2IAUBe5W8o+yqXWMz+1ASeYY2gRodU0/Bey3LeLIHisJB8j2GcmEgw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cahe62n5v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 15 Feb 2026 18:21:57 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2a7701b6353so32119915ad.3 for ; Sun, 15 Feb 2026 10:21:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771179717; x=1771784517; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gGsuTZLqUpwY7hBhRIBjA23F5oruK4sDevnmC00HExE=; b=Gy8WGiEO34Boj3G7sT1xnf3FY0VxRnx4Cn8ovZ4n9NfUdDof7UFYzxCrSlce+Eqlti 2C9wJy1DOcaSBiVTRV1Bkx7wnlqFqSIKl/vy7+zwxSVc72XafOq6fW/XmcbTFMTxZzV8 pihs8Mg6A14K2/0flz1IrdtlxbHHPPa1vzavL8z1w6eTXf1uj6Fy0+KHrF6v+/tH01SI 6ywWCtic2O5ddTXQecWAD9jZV3uZF76XHlpubC9xHak3SCWT0rMYIDxMDwjr5zWgN4lw 6DZqDJO6njFwOTWWPb3ka8YOIlGgRf3U7FHzStQwCyymBNTwSbIbg2qW/4hr3ZlCuIXO JKhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771179717; x=1771784517; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gGsuTZLqUpwY7hBhRIBjA23F5oruK4sDevnmC00HExE=; b=uREHO63RJftI6EPIP6CFp4rRSEE81tb8W4mZw1Xu7MP8Mf+519qbxAmsw/sK9NRbIk zvIFghWsrhz3UHmVFgT+TmYOvzgjAQyHsUORIdU2sNW6+BsJpAX93pjF3l20lA/XuNrW 29fdac1kGjiXTokddcK8UEFXZT/W5/HydujcbyuD9KDOwk+jfgVxlF8NA87ZnjTfFCRF +374yuYF4m459Sa/USPA11QTPaC6uZF57AuuMUUBNiRzyTm8CwVXPowcBqLV4aL45LQh f+UHh4YZvZtjyJziHg9x/iAr8gJx9N2zV2A6xGz3zeQ82F7ypUDn3dH4S8rlqNeG6mNk pX3g== X-Forwarded-Encrypted: i=1; AJvYcCUDxxNxQLPL7tWNpa/q49M7ucKaG99GJEkMSjfA32CvQHsuOEEFODLI+pGubMpLCLdOFi7C5XiH4kFOCMw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2S6qppVWIRly7ZdlyWLh56iz4jkkY7oXYUIlDGutCYabhtqly +HHn/kdoJH9UtZhrQmLPIGOPOIWY5w4J1GvltpiwcC2TCqPZuWTyDZDnQOcPCSbR+uBq54XJ3LI iyZxDTil5hM3pzYng/10hzLoyNIhuhc8yD17lca9B4XhH4MVqPb07h0JFhEmaiEa/W7I= X-Gm-Gg: AZuq6aJ8ckhpiAbUbQcVC5moeuv59nZ33O9odYwP415mlx6RtWuxtel/thZZH+9S9s+ aV4KueLc/0aeo94wj+CTsBJWZUKCg92UkyVBreSAvdNLvi+HJwjBomoC99OrYDc1JAr1D4BaLmA GQpsrLmf6Jc2eHHrznSD9qcUQ0rh38RxL0jhVN/LemqHvTTNlfhDP0H9cjskeK4u7tQ9yRcDXy/ QIcc+rx+7mo4COYTXT0N0S0NHJF74K6mMe9ipTLLbEz0pJUltBglwhNfFaFo1mb7WpAgxyaSQ/I NOwjShb5diNlFNy2TxGXdI4fJCfrBq+qDc+74rOJykmpGYhingc4tQqGywQZGbePgwkvGftbEXZ 8hImowdq2pU16Iwnj+viN+6sqPNV7OgaFEGv/gMO7MiUz8fqMozF+0Q== X-Received: by 2002:a05:6a21:7a97:b0:392:e5eb:f0a with SMTP id adf61e73a8af0-39483a3c323mr5039728637.75.1771179716720; Sun, 15 Feb 2026 10:21:56 -0800 (PST) X-Received: by 2002:a05:6a21:7a97:b0:392:e5eb:f0a with SMTP id adf61e73a8af0-39483a3c323mr5039711637.75.1771179716098; Sun, 15 Feb 2026 10:21:56 -0800 (PST) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35662e537desm17425381a91.4.2026.02.15.10.21.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Feb 2026 10:21:55 -0800 (PST) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com Subject: [PATCH v6 4/4] misc: fastrpc: Add polling mode support for fastRPC driver Date: Sun, 15 Feb 2026 23:51:35 +0530 Message-Id: <20260215182136.3995111-5-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260215182136.3995111-1-ekansh.gupta@oss.qualcomm.com> References: <20260215182136.3995111-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=c5WmgB9l c=1 sm=1 tr=0 ts=69920ec5 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=TEHdEMHTk_fMHrPBF0kA:9 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: deAS_iovSkiraU49ttU0N1I8zmezU2Ze X-Proofpoint-ORIG-GUID: deAS_iovSkiraU49ttU0N1I8zmezU2Ze X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE1MDE1NCBTYWx0ZWRfX/wnMrDUK05MZ PL2OZL1fErWzUN6KM7b2l0lFlDlFV7Lzd6m1vXmPK0QT0lZvQfRrt9biKV4axLHnIgHU+xRHNFA 63JXmczyTaimsU9ZwgkwanwQ8JHXPFuKPazy7IyUKapesCFfFuaLc6R36XAjjPiu1Ds3Od2Be5/ OzpvtmwM8PN5Kt/DbrLpj+VrOi8OBdMIHKy6/ThTzQ5FmjxfRH97Pkq8I+gjacf9TmIrtFzXv8N SCrOA3wsGf+htx8S6zd40D7gkcqRBsZCLReqPfEyyWBaJFPOt2U3k0JdlD30NSyE78+PiNaL9rX Z86QTHrjAzXYkFcnvbYFrkWPExK0BLjZJOrFKckQOMiAjqBgq985fhB8IzDvVPMY+jIOTE0mSDN BK3UuuINYAMxQV4mGHwolDXw3zS7P7KTura2wV4IWspCaSoNgGngZAbsXfpg01+eigRp58QMCAP p+H54/InSBk4BMiUTVg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-15_06,2026-02-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 malwarescore=0 bulkscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602150154 Content-Type: text/plain; charset="utf-8" For any remote call to DSP, after sending an invocation message, fastRPC driver waits for glink response and during this time the CPU can go into low power modes. This adds latency to overall fastrpc call as CPU wakeup and scheduling latencies are included. Add polling mode support with which fastRPC driver will poll continuously on a memory after sending a message to remote subsystem which will eliminate CPU wakeup and scheduling latencies and reduce fastRPC overhead. Poll mode can be enabled by user by using FASTRPC_IOCTL_SET_OPTION ioctl request with FASTRPC_POLL_MODE request id. Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 142 ++++++++++++++++++++++++++++++++++-- include/uapi/misc/fastrpc.h | 10 +++ 2 files changed, 145 insertions(+), 7 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index e935ae3776b4..c1e67dbacf2c 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -23,6 +23,8 @@ #include #include #include +#include +#include =20 #define ADSP_DOMAIN_ID (0) #define MDSP_DOMAIN_ID (1) @@ -37,6 +39,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 +#define FASTRPC_MAX_STATIC_HANDLE (20) #define FASTRPC_CTXID_MASK GENMASK(15, 8) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) @@ -105,6 +108,12 @@ =20 #define miscdev_to_fdevice(d) container_of(d, struct fastrpc_device, miscd= ev) =20 +/* Poll response number from remote processor for call completion */ +#define FASTRPC_POLL_RESPONSE (0xdecaf) + +/* Polling mode timeout limit */ +#define FASTRPC_POLL_MAX_TIMEOUT_US (10000) + struct fastrpc_phy_page { dma_addr_t addr; /* dma address */ u64 size; /* size of contiguous region */ @@ -235,8 +244,14 @@ struct fastrpc_invoke_ctx { u32 sc; u64 *fdlist; u32 *crc; + /* Poll memory that DSP updates */ + u32 *poll; u64 ctxid; u64 msg_sz; + /* work done status flag */ + bool is_work_done; + /* process updates poll memory instead of glink response */ + bool is_polled; struct kref refcount; struct list_head node; /* list of ctxs */ struct completion work; @@ -307,6 +322,8 @@ struct fastrpc_user { int client_id; int pd; bool is_secure_dev; + /* Flags poll mode state */ + bool poll_mode; /* Lock for lists */ spinlock_t lock; /* lock for allocations */ @@ -924,7 +941,8 @@ static int fastrpc_get_meta_size(struct fastrpc_invoke_= ctx *ctx) sizeof(struct fastrpc_invoke_buf) + sizeof(struct fastrpc_phy_page)) * ctx->nscalars + sizeof(u64) * FASTRPC_MAX_FDLIST + - sizeof(u32) * FASTRPC_MAX_CRCLIST; + sizeof(u32) * FASTRPC_MAX_CRCLIST + + sizeof(u32); =20 return size; } @@ -1020,6 +1038,9 @@ static int fastrpc_get_args(u32 kernel, struct fastrp= c_invoke_ctx *ctx) list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); pages =3D fastrpc_phy_page_start(list, ctx->nscalars); ctx->fdlist =3D (u64 *)(pages + ctx->nscalars); + ctx->poll =3D (u32 *)((uintptr_t)ctx->fdlist + sizeof(u64) * FASTRPC_MAX_= FDLIST + + sizeof(u32) * FASTRPC_MAX_CRCLIST); + args =3D (uintptr_t)ctx->buf->virt + metalen; rlen =3D pkt_size - metalen; ctx->rpra =3D rpra; @@ -1188,6 +1209,75 @@ static int fastrpc_invoke_send(struct fastrpc_sessio= n_ctx *sctx, =20 } =20 +static inline u32 fastrpc_poll_op(void *p) +{ + struct fastrpc_invoke_ctx *ctx =3D p; + + dma_rmb(); + return READ_ONCE(*ctx->poll); +} + +static int poll_for_remote_response(struct fastrpc_invoke_ctx *ctx) +{ + u32 val; + int ret; + + /* + * Poll until DSP writes FASTRPC_POLL_RESPONSE into *ctx->poll + * or until another path marks the work done. + */ + ret =3D read_poll_timeout_atomic(fastrpc_poll_op, val, + (val =3D=3D FASTRPC_POLL_RESPONSE) || + ctx->is_work_done, 1, + FASTRPC_POLL_MAX_TIMEOUT_US, false, ctx); + + if (!ret && val =3D=3D FASTRPC_POLL_RESPONSE) { + ctx->is_work_done =3D true; + ctx->retval =3D 0; + } + + if (ret =3D=3D -ETIMEDOUT) + ret =3D -EIO; + + return ret; +} + +static inline int fastrpc_wait_for_response(struct fastrpc_invoke_ctx *ctx, + u32 kernel) +{ + int err =3D 0; + + if (kernel) { + if (!wait_for_completion_timeout(&ctx->work, 10 * HZ)) + err =3D -ETIMEDOUT; + } else { + err =3D wait_for_completion_interruptible(&ctx->work); + } + + return err; +} + +static int fastrpc_wait_for_completion(struct fastrpc_invoke_ctx *ctx, + u32 kernel) +{ + int err; + + do { + if (ctx->is_polled) { + err =3D poll_for_remote_response(ctx); + /* If polling timed out, move to normal response mode */ + if (err) + ctx->is_polled =3D false; + } else { + err =3D fastrpc_wait_for_response(ctx, kernel); + if (err) + return err; + } + } while (!ctx->is_work_done); + + return err; +} + static int fastrpc_internal_invoke(struct fastrpc_user *fl, u32 kernel, u32 handle, u32 sc, struct fastrpc_invoke_args *args) @@ -1223,16 +1313,26 @@ static int fastrpc_internal_invoke(struct fastrpc_u= ser *fl, u32 kernel, if (err) goto bail; =20 - if (kernel) { - if (!wait_for_completion_timeout(&ctx->work, 10 * HZ)) - err =3D -ETIMEDOUT; - } else { - err =3D wait_for_completion_interruptible(&ctx->work); - } + /* + * Set message context as polled if the call is for a user PD + * dynamic module and user has enabled poll mode. + */ + if (handle > FASTRPC_MAX_STATIC_HANDLE && fl->pd =3D=3D USER_PD && + fl->poll_mode) + ctx->is_polled =3D true; + + err =3D fastrpc_wait_for_completion(ctx, kernel); =20 if (err) goto bail; =20 + if (!ctx->is_work_done) { + err =3D -ETIMEDOUT; + dev_dbg(fl->sctx->dev, "Invalid workdone state for handle 0x%x, sc 0x%x\= n", + handle, sc); + goto bail; + } + /* make sure that all memory writes by DSP are seen by CPU */ dma_rmb(); /* populate all the output buffers with results */ @@ -1812,6 +1912,30 @@ static int fastrpc_get_info_from_kernel(struct fastr= pc_ioctl_capability *cap, return 0; } =20 +static int fastrpc_set_option(struct fastrpc_user *fl, char __user *argp) +{ + struct fastrpc_ioctl_set_option opt =3D {0}; + int i; + + if (copy_from_user(&opt, argp, sizeof(opt))) + return -EFAULT; + + for (i =3D 0; i < ARRAY_SIZE(opt.reserved); i++) { + if (opt.reserved[i] !=3D 0) + return -EINVAL; + } + + if (opt.req !=3D FASTRPC_POLL_MODE) + return -EINVAL; + + if (opt.value) + fl->poll_mode =3D true; + else + fl->poll_mode =3D false; + + return 0; +} + static int fastrpc_get_dsp_info(struct fastrpc_user *fl, char __user *argp) { struct fastrpc_ioctl_capability cap =3D {0}; @@ -2167,6 +2291,9 @@ static long fastrpc_device_ioctl(struct file *file, u= nsigned int cmd, case FASTRPC_IOCTL_MEM_UNMAP: err =3D fastrpc_req_mem_unmap(fl, argp); break; + case FASTRPC_IOCTL_SET_OPTION: + err =3D fastrpc_set_option(fl, argp); + break; case FASTRPC_IOCTL_GET_DSP_INFO: err =3D fastrpc_get_dsp_info(fl, argp); break; @@ -2518,6 +2645,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device= *rpdev, void *data, } =20 ctx->retval =3D rsp->retval; + ctx->is_work_done =3D true; complete(&ctx->work); =20 /* diff --git a/include/uapi/misc/fastrpc.h b/include/uapi/misc/fastrpc.h index c6e2925f47e6..c37e24a764ae 100644 --- a/include/uapi/misc/fastrpc.h +++ b/include/uapi/misc/fastrpc.h @@ -16,6 +16,7 @@ #define FASTRPC_IOCTL_INIT_CREATE_STATIC _IOWR('R', 9, struct fastrpc_init= _create_static) #define FASTRPC_IOCTL_MEM_MAP _IOWR('R', 10, struct fastrpc_mem_map) #define FASTRPC_IOCTL_MEM_UNMAP _IOWR('R', 11, struct fastrpc_mem_unmap) +#define FASTRPC_IOCTL_SET_OPTION _IOWR('R', 12, struct fastrpc_ioctl_set_o= ption) #define FASTRPC_IOCTL_GET_DSP_INFO _IOWR('R', 13, struct fastrpc_ioctl_cap= ability) =20 /** @@ -67,6 +68,9 @@ enum fastrpc_proc_attr { /* Fastrpc attribute for memory protection of buffers */ #define FASTRPC_ATTR_SECUREMAP (1) =20 +/* Set option request ID to enable poll mode */ +#define FASTRPC_POLL_MODE (1) + struct fastrpc_invoke_args { __u64 ptr; __u64 length; @@ -133,6 +137,12 @@ struct fastrpc_mem_unmap { __s32 reserved[5]; }; =20 +struct fastrpc_ioctl_set_option { + __u32 req; /* request id */ + __u32 value; /* value */ + __s32 reserved[6]; +}; + struct fastrpc_ioctl_capability { __u32 unused; /* deprecated, ignored by the kernel */ __u32 attribute_id; --=20 2.34.1