From nobody Thu Apr 2 23:54:50 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B33E61465B4 for ; Sun, 15 Feb 2026 12:45:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771159559; cv=none; b=OvpFryso5JjcaJ5VsrJHEBtaeRDk69S7hxh02kFLkBYXjdy3m6gy3nPwdN8e32hW3c+wSMv3S3gE+iSnYwe04omg/ukeQno/q0JACTTAOK5b12l7tuFkrbgXrTIbl6XF4kw1cDlkU5C9g/+G/e7nRibfn+Twn6bAIMKgiCPwHtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771159559; c=relaxed/simple; bh=kj25TsuIf28GO+0UAaQNtP4hQ7nw5VBdZAExx6bXo+U=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=hn+5BxqB7nFKHPnXz0y1Y69UfxngQOU/MLS8ypLu5YRvi9fGR6rg7skaUmPi7p07iWsGPzVL8I0rmK0H3K5bojGjLYk5sjUIhmpO5I5yw99eUZ9SUCpZSxEAgZRcliduIZv21xJ62ktuK5YIq+xiigG8l/EWI32919pONbWfh1Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YHiN5ZE1; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YHiN5ZE1" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-436e8758b91so1863011f8f.0 for ; Sun, 15 Feb 2026 04:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771159556; x=1771764356; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Qiu8f1lgiP7GYNLsQsmv6jJbUZDMtlGtb1+PjIhSSzA=; b=YHiN5ZE1uUj1DehTePnbtPxEYyOfBm4LBMfESi5ePQDfzvmEqiuaY5p0kmij7YVU4z u2ezvEOIrW74W5YpBhGFrRiGaFnBX7GHImKn+DsjR9dWcCwNIyvXnsZpobHhRiY8ogn8 LvwTq71Osb93TT4K07QzGIzSPx5GzEPDvWyHZBrE8Q86nGT6EH3C5ACyvSle9ouB2gGg bruXyYP8fm3uMAcoxdXjOqlcSHRouV6YEyllmPK/sm3FuGddMHCrObtA7SLz08eI3T/k ME1K3e5YBiOY7JiPTwQ1GjqaLxer5Cd+bnTzyTo+VxTzWkmRDGfbXNWNzjyRj/Obd8JF GmPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771159556; x=1771764356; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Qiu8f1lgiP7GYNLsQsmv6jJbUZDMtlGtb1+PjIhSSzA=; b=es9hnzNetNg1pdI4sGfObH1DZ4skzVjosidvFp7ZyY9XVb0hHzGvBxsbHl7zge18Ff 8IR2mWBAy9eqbYCoVNFCPDIdWVuSqgEntZ5jeqLdwS7I2KNzUdkKA+2KaT4/aAoImwPS HfYOexgC0jndU0gRX6WdDEYNQptUu0HWV6LOKhdSWJvRLmW+OyDufx4eFSfRoAnZ1Erg n2msG1eRZ3YD4NkW9ZewySh37xhwX7jUynQ2vDHgF5kdnJuORC7NXhcaJzEc/wjZBQfd X1bxQpOnA60mTM2rdBcD92yRsU2468RElt5e7vlZ2FgLjghVq0EnaoEeZOl9PdEVLF/V pkUw== X-Forwarded-Encrypted: i=1; AJvYcCVKfmvkJdZQ/OQELMF8vifGddtnlu29Hxo4albG3hcX92wMTMkJKMz8jZ5LvFxjw+bEUNVivA1YyML8ocI=@vger.kernel.org X-Gm-Message-State: AOJu0YzaWit7NxCcs7nBt2OhWykRDft9NEhwL3lPMm8lwUfbPeuVVW/H fXnHpVyAyabC8NK0c80yVnRh9DHQNGFoATSbqhMYImjKHsT25LR2/V0y X-Gm-Gg: AZuq6aJMwlvD7XrpGzesy4KWzv4oHaCYu7JXihewGaAXISGmJNjyEGgyXNPG/yw+tSY xmx6g4unwmai2IYITO9XK/yqRHQKAtHUVktux5vL8rzZ4BJvWEL90MDpF9ixAmXo2DmeSmI0/sW RZmphF6mUnG9+wvkFANhZ+b3MiTbFt23LiIms5xljMRbaF3jtcwuOGWXbfHUfrogvBx1c/L+QGg n2Z8wbyI1mTUX7N1OltlpTeFmdmlszD8wR25v8Frhg1VEoRj2Rv7Oa3w7ASEenl/D/W/F+Fsl4C 4v4yGPUrU0B/FqWnCgvtg3+XcxVRlZ1WzK1gRKSLrBxWkzZh3M/q+++UYuxtO7hLc6nIZX6wXq0 9QbtPzmik4gYMvIRTvYGp2SljWM0vfhGZeIPCDDztH/BlDFrFxswaF8Az2OyhZq+sAPCKSDAoR4 66dxi1DMVuAHMeqgaPuMhspc9EBA== X-Received: by 2002:a5d:5f94:0:b0:432:5bf9:cf15 with SMTP id ffacd0b85a97d-4379db263a3mr10253083f8f.5.1771159555837; Sun, 15 Feb 2026 04:45:55 -0800 (PST) Received: from localhost ([37.228.227.141]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ac8209sm20827144f8f.30.2026.02.15.04.45.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Feb 2026 04:45:55 -0800 (PST) From: Jaime Saguillo Revilla To: oleg@redhat.com, akpm@linux-foundation.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jaime Saguillo Revilla Subject: [PATCH] proc: array: drop stale FIXME about RCU in task_sig() Date: Sun, 15 Feb 2026 12:45:11 +0000 Message-Id: <20260215124511.14227-1-jaime.saguillo@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" task_sig() already wraps the SigQ rlimit read in an explicit RCU read-side critical section. Drop the stale FIXME comment and keep using task_ucounts() for the ucounts access. No functional change. Signed-off-by: Jaime Saguillo Revilla Acked-by: Oleg Nesterov --- fs/proc/array.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/array.c b/fs/proc/array.c index f447e734612a..90fb0c6b5f99 100644 --- a/fs/proc/array.c +++ b/fs/proc/array.c @@ -280,7 +280,7 @@ static inline void task_sig(struct seq_file *m, struct = task_struct *p) blocked =3D p->blocked; collect_sigign_sigcatch(p, &ignored, &caught); num_threads =3D get_nr_threads(p); - rcu_read_lock(); /* FIXME: is this correct? */ + rcu_read_lock(); qsize =3D get_rlimit_value(task_ucounts(p), UCOUNT_RLIMIT_SIGPENDING); rcu_read_unlock(); qlim =3D task_rlimit(p, RLIMIT_SIGPENDING); --=20 2.34.1