From nobody Thu Apr 2 22:25:05 2026 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAB971548C for ; Sun, 15 Feb 2026 20:06:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771185999; cv=none; b=Rg3Vd66JzLH67cwJPqnHTQGqucNFOczdqEhfcvNhcExlvnYS3FXZ5t1OuhUqrIaV+qKKLkB9Wr2hb2gt5N5uEqlw/tl4wORKih6Kn9IiUn5xvrZbIg53bsfEkhMOlaf6pe1f8bRDLw5RBqZdskYizSURp9Z6dJToBCiZHy6i9WE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771185999; c=relaxed/simple; bh=DZxBctGHQ8YK2uZhVlc5yIy9LV6Le4CnXmSL/0tvMfg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OBJDvi/MILXKmLuex4x9wYLPGMkJA0rTGYX45D9TsEeq3/BaBu88jktPYpdVjFXe4AyPmX70xuwv0sq79mpHTpS2HM21+MMnxXgmtowvUfloDlFfmQcePuQO45C8b1etb64AZdE/DehnHnzl+sM0cKjn+jMBDuVvdptMvmKJK34= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=XJ4Mrc3T; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="XJ4Mrc3T" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-1271257ae53so2540961c88.1 for ; Sun, 15 Feb 2026 12:06:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1771185997; x=1771790797; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=16om0dKffWd/jiAsOCQqAqNAh+Z+U1swvD/OzEUaow4=; b=XJ4Mrc3TT2gRLKkB8y9LicHhoTVGqCYVhFusBjKcikmnCuV+52KIB25jph+tKQw29V i5qN/fGoH1geIEtKPmnPvqNBx4vt6d87OBuuq0LvVn9arbZnh27YI15wgfbM0UmX/Y4U bG5mLeaFu4kj8LrVcBpHUEe9u0Zlp/CT5QotM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771185997; x=1771790797; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=16om0dKffWd/jiAsOCQqAqNAh+Z+U1swvD/OzEUaow4=; b=I6hfyWQVuKq93gqRmsrXTLJxYRjObX8suDQGaOiKDuJKqt5b4gFvLfPjJJ9KLziqX3 z167z6CEVwcJKhzEehRgfmHq3UtD616y2r/fxjZGZAQS0bmYA0pX658vbQckvlFh4TSZ 3ojRRUljfxIWWCxjK634Zu7jHCNl5PjgEuDuhtX1tIXGuKFtFN17wt+OYWA6jO8hJcHi ey0JMbitMG2AY0eocRd80wmVrFR2EUJ9F6jCmzs8LbrkwCcFZOZt6usjDsmuZiDabQFp 7n48i07LwkcxvG0ZGDz5lZfAJAywWf1QGF8S7o6lPUSrGFcB+9lZys8WeL8n4UmjWkYN gjiQ== X-Forwarded-Encrypted: i=1; AJvYcCVnwTuYQTMYxV8CVYhfnPbyXPiGvIRPDC5L26w6gWC/H0dy/uLIhSgz/r6AfZh8/W9CVkQFSnyrJvK6zjY=@vger.kernel.org X-Gm-Message-State: AOJu0YwDRpeGsm2WUPxpz2bBCx//xPmeBCQM9j0aGpk5mEjWXon7m0LA P/P3YqUozbbDdtLRTN0xWQnNKn7rwwTOfwOiuA3Zf+Z7E80cbSDDN/RXWe34pvjvSw== X-Gm-Gg: AZuq6aJOvZ9vejL5u849RGViDpxBDZkor25nN1N2tB27j2WVbPbnfoVKlL3QulupHZ5 UjYr8vBnvFqVJGqDJKiepRRp4MYXguF068SLgnoDxTE2Bavu81MsDYGW7jL5x6iFIyuMn3cRgx2 RTl5FahUCuk0z+U4RviP7tQQAMICIUra4lShMtYklLUx7OqOP7PsgUv9BHM+5PsGLa5E3fcU8dO CIfW/ovbgytgvWx7NF4yk1NgzcQxhRW2pNwbN/zQ97VxdT/nEUR65b/c5edoXeHRHaVK4wak37/ YnVZa7JyoqcbkBnOzJY5ic5XZ8ibsjceIMOcdxeSoqQ+vwtfubuECvNSpD+zzmAp5PsWzdMkaJQ enxWtwsjgSpIkVBD084phFUSa0XFUA/dkAvcr7qG2DC19bEdxhuqdMF8hmULYXjUjv8Gma/U4kQ b7ttD4Omld3uaflTG6LmO2ORTFDZwpBndV+hX1CeNuvoBNcvtLuj09hNiM/g8oljF2McgTgahKG ptCm6rMNQ== X-Received: by 2002:a05:7022:f102:b0:11b:9386:a38d with SMTP id a92af1059eb24-1273ae81364mr3683409c88.48.1771185997008; Sun, 15 Feb 2026 12:06:37 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d1b:eb8c:16f:1964]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742cad9desm6896092c88.11.2026.02.15.12.06.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Feb 2026 12:06:35 -0800 (PST) From: Douglas Anderson To: Linus Walleij , Christian Brauner , Bartosz Golaszewski , Kent Gibson Cc: Douglas Anderson , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] gpio: Avoid NULL dereference in linehandle_create() Date: Sun, 15 Feb 2026 12:05:55 -0800 Message-ID: <20260215120555.v2.1.I77c3eb563271c21870379eefd16ebbc4e09635bb@changeid> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In linehandle_create(), there is a statement like this: retain_and_null_ptr(lh); Soon after, there is a debug printout that dereferences "lh", which will crash things. Avoid the crash by using handlereq.lines, which is the same value. Fixes: da7e394bf58f ("gpio: convert linehandle_create() to FD_PREPARE()") Signed-off-by: Douglas Anderson --- Changes in v2: - Use handlereq.lines rather than creating another local shadow. drivers/gpio/gpiolib-cdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c index 2adc3c070908..189127721e38 100644 --- a/drivers/gpio/gpiolib-cdev.c +++ b/drivers/gpio/gpiolib-cdev.c @@ -388,7 +388,7 @@ static int linehandle_create(struct gpio_device *gdev, = void __user *ip) fd_publish(fdf); =20 dev_dbg(&gdev->dev, "registered chardev handle for %d lines\n", - lh->num_descs); + handlereq.lines); =20 return 0; } --=20 2.53.0.273.g2a3d683680-goog