From nobody Fri Apr 3 01:29:46 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32791288535 for ; Sun, 15 Feb 2026 11:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771153595; cv=none; b=YcmfNLcdU8j4YwuHsfD6GfFuAACZtuQlaxUOIrgQzI0pRK7Xe5y2bgLpQhv7e1XFU9PHe/dYQI0X9D9THRIN5bk7d+ErmtYaT/Kqlhf2taTwRTnX9EsZoh5KtoGGY40Z+b8+O1Dgs+7+Lvb85WebZSsk2YnhFjx4mjxgoRF9Uyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771153595; c=relaxed/simple; bh=NP94FmMc49hVak9d84xroc99UMOfASUZ7FO4Vb9UwNE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=g/ecFpGVgePkB6CvhgXmX3xexw67yQ/pBdMyUQPrY6ueQIr9cU9LhLw/i923bPUuRyUjk88+CRmRxeRSf2awrHyKcdr6YEpCiNZeaQfdXQApeY7ERNkmAw0+8yZXPUE1zGgQxFDFnEC8omD9nDRBelabWwNQC1fJVo5Vlfro//M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S+XsWXtN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N73rRdBj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S+XsWXtN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N73rRdBj" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61ENhqh32869311 for ; Sun, 15 Feb 2026 11:06:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=ld1npyEylhh9T/ZrLUK2KA2uppN+ES3kJsT 5nxT2auI=; b=S+XsWXtNwq8KK4YXODBXvTA5hKPUNWG6nwUU3T0pjsMNAQTH6dY ZdE1pl9ceKZYKmugtQawlKT4wI47oTgXiCmEIVReXm25gGSkeSWJwQI6BDd4u/MR xRnjxlpzRs84j+TDjfamMoT+Sas4lQQc+wRqSe6WQShjzQkNZ8mEg+6EFgq8rt+c 22JmorGW4Q4cKLYb7KJiYQCXkel9P5Sa1Iav3dcQBvFT2Ln7nXoDNZXRG8H1MZ/B Jv2vyaAJP3zbk2gUfurCOaYoZGMxqmwOCuBgZpy9qkhMHG31CZf8MwUg4hs8/18Z 5kAd2RJk0MEn8qQvB+bTkguUmgYWNIAwkWg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cajb8t25p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 15 Feb 2026 11:06:33 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-506a1999e44so130233331cf.1 for ; Sun, 15 Feb 2026 03:06:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771153592; x=1771758392; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ld1npyEylhh9T/ZrLUK2KA2uppN+ES3kJsT5nxT2auI=; b=N73rRdBjkfALEPAWcIl+KoJI5x22TUU/fL+xIPtn/jNTBMY+MJdZEAxvaedfSyw3R1 NkvM4cDaI45LPop1q0oqh2eY6d1zZrszcIAYxBthQAONHp2bpm90tsmmfevp2cWk2TIl oHsKazk67uP573KXNWS8yDW9x2N2bL+FPd34UbfHsb1HJdZrjIqQqFJwH8iPq//9KypX lGFd1lUpn5LaztBNlRv6JMugEUJ07kSX3Gqg8MvZ7XNt9ZzBUxHH0fjDdaDGOhobo44x gt0sp3+pWBfqDOip9PETjaew9JIEjW8X/ZJzzb6FMU9y2hsI8cLD3n1BYM6YGvXD/R+w WTmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771153592; x=1771758392; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ld1npyEylhh9T/ZrLUK2KA2uppN+ES3kJsT5nxT2auI=; b=iwAK2XqR5Sd5pfrexScCx2vK0bQ4bZJdQtgV9MyoU8FG693qKdi+I4uQRQ93nYELXu g0fvd5+q5Y65Pk2I0VFCmLB48TJkXUZiLoG2olxi4kZmJiL0P1u3363ZP6pwO4PX4ryH cfIOVKZyZ6ZDOg/HatPmUlXx3KuO6HQhTZi3vijRIrv1kdsoY32ry/GrvJViJoCAX8GW nRzoXf4IxxH7rN52CHaGJLhqbcfZKAhsI+DPCIdRwndTh0b+FsmwVnX9PG0TMzvfe55G Kn4PoyQuENNG0ed9TK3i9zrAYAKnM2vCj2yuDvziRBYynii3Jrp1r5+Pbmz83wYU0R9e pLYQ== X-Forwarded-Encrypted: i=1; AJvYcCXN/1cFIzxsdlOaiRKRXJkqW1HW7Lnu9MaZ6FFqR8p1fX2DjE5r2qoepXEeelkmDpr1lTpytFqbPu4Gi4I=@vger.kernel.org X-Gm-Message-State: AOJu0YzaN7BLW9S+CH5/9QpF7WZchDEG0hWv7OA+YlWAeAS/GKt6gDQb zhzaGai/6pFfz26JUJGlni2dq9S9WsYfICDw0gVyVP0DLzjL/AeoAxiKVq8tLxZuno83DbsTE2q TU/WxckEvpfh47HlK4NjlfhDQf0imlarqGtvFPnpdS2Kly2NCQwr9648ik5+NxKCdvSU= X-Gm-Gg: AZuq6aIuF5rP3D/I3mjvVR8VLaA2HEirM7NeycoPDdCBdZ0ApfOLbTqJXlBImIsEiKD 6906VYXjUOgUIPeTVztoyhYUOGv50E5sPK52uFHk1qd3DuDoefW6nblv4UBib7OfpaGFct1pdVd SsGwGI8OuhxFjgAfLsIZnJSGD/TYbGZcsJnri5j1eiCHYi4Gw4u4QiCffZzeo+//zLW+5FO+mOv vsmcbAxk+CtAgqj1zAdsfB4g2PQ1M+RBLmZfc9T5wUTLjb9MZoSqlwqvweqZEZfNeSvDZ/rROJU KxBk3aUBMEFl/J+r+/erqBvdXl+ggoH5CqmOxywZLa9GTwii+9XE3gvuKiFtTJWsQgllDfeyZV5 +uciD8xBRNd0nArBOLimwDhbhJ+WnxHEgOvZK+w== X-Received: by 2002:a05:620a:7081:b0:8b2:ec00:7840 with SMTP id af79cd13be357-8cb42268fb7mr859965385a.27.1771153592485; Sun, 15 Feb 2026 03:06:32 -0800 (PST) X-Received: by 2002:a05:620a:7081:b0:8b2:ec00:7840 with SMTP id af79cd13be357-8cb42268fb7mr859962585a.27.1771153592073; Sun, 15 Feb 2026 03:06:32 -0800 (PST) Received: from quoll ([178.197.223.140]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4835dcfafcdsm546360325e9.9.2026.02.15.03.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Feb 2026 03:06:31 -0800 (PST) From: Krzysztof Kozlowski To: Ard Biesheuvel , Maxime Coquelin , Alexandre Torgue , linux-efi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] efi: stmm: Constify struct efivar_operations Date: Sun, 15 Feb 2026 12:06:28 +0100 Message-ID: <20260215110628.34293-2-krzysztof.kozlowski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2165; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject; bh=NP94FmMc49hVak9d84xroc99UMOfASUZ7FO4Vb9UwNE=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpkai0cmoweuXzmNdkt3cUKsm8kSCLQVJPu23p+ dCZSm7zbAmJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaZGotAAKCRDBN2bmhouD 11qAD/wN+jA1lzX6+fvH+7NvijyyXmKjI69j+7amUOgM5sbk570RGatIFifeiMMYCzNsjRtka1N SK1h155UeEuyH4Bh28xMW0yl3B4RbpKRBgecF8bJOoauDz6gj89z70NAhEoCXnlMQzyliGE3BKi Ahxw8Ny/zGlGitabsYrEgLDKuVSld04+JP8Sog5HdJ35M1hsyWuZXSNr+jqW6HxZMPq5fhBdzXr 5u07sXCHRdxtXIs+A6LZdb0qYJ3D3oSR874npKfRbML/aPlxh7DQXJPoWBoDL65GifRkJaHhZl2 MjJDpmk/7UdZIzOdP56MOfqQlImW+obhbofUzlCs1cKDpZd8hVCB7LOBYj+bJw2dfZR5nGwgGuZ MKmrUgz9ADLHW7MgUaHtCdjIKKMF+PoQjoN1Zzo30F3SVWfda9kAEQK8GxotrYMrO4n6LI9kcAL Fwl8MNE2IFEYm5DVap6C+VDkyMhbmTb84uEMDJYMHqastkqmUxy05JsGSD217Kev8/4HnhENdLN HINqvMPYNNQTDLiPSGaaDq8A2zGrjc9XKAUK9kOHbF2DT8UZsu+SuYHn0DHl5L7anJl4Itr+pii caB1cZK16piHfC546QaES/WzkbiqD9u/sxAYzvAYEfsLIlrT6dpd6lKsaXed1zbkbjcXudDC5+I fgr4KP1y45xlKHg== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE1MDA4OSBTYWx0ZWRfX7m2OgJy+bARl 6dB/Gv5lS5E8hIY2+9de/kUj2Z/th1rYVjC1dBEWb9ZOWBTCDWNC/HKa2TOrFcWATJBj+TduLIk pcpeUmCjZUSg6b3lPrV9DqS9x8PNWeU3mEEO5jlYTV12cQdhBaF2CVK8ekIdGrUAzR7f3v47blw LRwbcVNR8dDGcskblR8LOJ2kek3xD7yu+jb5K71iq1Sw/QfG56pow+DnZXmbb9O0OFNvSGeZ/Wa lvjW6sQlyUHtATczX9b78UWqP8I0IDQnBiOGEXPMLqa7n2/5lKZJR3OJdrQYWRNKmm5Rv9lwLfp SImLaUlgSJMdmzBIlFvyuq09Z8JhYlE4z1pddwLMgecw+cICIU0lNTxe+aGBG/3wdknWdA7mqQt 6p/1QoZtd0CzEi1P82yPtLggT2MMAbcPcwjscjejREcpcQ5Tc4dKWyLqPlK2FBKTeLP06vteOw+ CYkiOorXUX6lmhC4n8Q== X-Proofpoint-ORIG-GUID: 5sCUe5ijCp2b3EWLqUd5nHRzYrO7MvT6 X-Authority-Analysis: v=2.4 cv=Pe/yRyhd c=1 sm=1 tr=0 ts=6991a8b9 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=6nO30s3o7FuWeffXwhKHTA==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=NNID--eWxax2qouwXSIA:9 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: 5sCUe5ijCp2b3EWLqUd5nHRzYrO7MvT6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-15_04,2026-02-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602150089 Content-Type: text/plain; charset="utf-8" The 'struct efivar_operations' is not modified by the driver after initialization, so it should follow typical practice of being static const for increased code safety and readability. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Ilias Apalodimas --- drivers/firmware/efi/stmm/tee_stmm_efi.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/firmware/efi/stmm/tee_stmm_efi.c b/drivers/firmware/ef= i/stmm/tee_stmm_efi.c index 7b04dd649629..3bea2ef50ef3 100644 --- a/drivers/firmware/efi/stmm/tee_stmm_efi.c +++ b/drivers/firmware/efi/stmm/tee_stmm_efi.c @@ -14,7 +14,6 @@ #include "mm_communication.h" =20 static struct efivars tee_efivars; -static struct efivar_operations tee_efivar_ops; =20 static size_t max_buffer_size; /* comm + var + func + data */ static size_t max_payload_size; /* func + data */ @@ -520,6 +519,15 @@ static void tee_stmm_restore_efivars_generic_ops(void) efivars_generic_ops_register(); } =20 +static const struct efivar_operations tee_efivar_ops =3D { + .get_variable =3D tee_get_variable, + .get_next_variable =3D tee_get_next_variable, + .set_variable =3D tee_set_variable, + .set_variable_nonblocking =3D tee_set_variable_nonblocking, + .query_variable_store =3D efi_query_variable_store, + .query_variable_info =3D tee_query_variable_info, +}; + static int tee_stmm_efi_probe(struct tee_client_device *tee_dev) { struct device *dev =3D &tee_dev->dev; @@ -558,13 +566,6 @@ static int tee_stmm_efi_probe(struct tee_client_device= *tee_dev) MM_VARIABLE_COMMUNICATE_SIZE + max_payload_size; =20 - tee_efivar_ops.get_variable =3D tee_get_variable; - tee_efivar_ops.get_next_variable =3D tee_get_next_variable; - tee_efivar_ops.set_variable =3D tee_set_variable; - tee_efivar_ops.set_variable_nonblocking =3D tee_set_variable_nonblocking; - tee_efivar_ops.query_variable_store =3D efi_query_variable_store; - tee_efivar_ops.query_variable_info =3D tee_query_variable_info; - efivars_generic_ops_unregister(); pr_info("Using TEE-based EFI runtime variable services\n"); efivars_register(&tee_efivars, &tee_efivar_ops); --=20 2.51.0