From nobody Thu Apr 2 00:15:31 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83FE43B28D for ; Sat, 14 Feb 2026 20:38:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771101507; cv=none; b=RFNgLL5Z31rwEcihL53cHrmspt7678byGdmBXLjqsDTgyD1F2tILtIiJVB+pmqMM9anRpUDKkk3VDAjPKYT3RhF55qH1RwyrQlXAvXIzRDY/0tkQkURugX9crkuTdDjKji/N9mvhr/qpZAutOPfC13kwGoQG1zlf2hSF/U3/7ZY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771101507; c=relaxed/simple; bh=ISPg1m/xtoHmadv+9qD4PF4qeTVVdwlXnG/d134LzZg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DPy7auFNEpr5tQv1VJ8Yhf5DpVlx2g5jFYJK6re5ckArawZtvdw9fqQoi0A0YD8vmzV2vWJCKzZMXppSpdoAevAevWDmK0HYjl6sYHINECQnR8WQFARSAZ6eC3TrhtOBeyaw9EEgb/bFTwB2QxCIlc6mdmXXpd4MhxO9kJrkfOY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ACLn45RS; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ACLn45RS" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-4362c635319so1971021f8f.2 for ; Sat, 14 Feb 2026 12:38:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771101505; x=1771706305; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Tyvs4xFeOgUlL1nJWOsM4wXcI5MSjDts4OzcTAQg/Sk=; b=ACLn45RStFfq0f8xCGaIAblhJAIF6KAdrIhPrOE5h1D+Il2j3ZOve3icxYUEb9qw37 6WqzJkkL4JxOyu1numuLK5UEC69q8ZHaVXuGTg7YZ7Tsv0Y+sD0a/kvpiy6V+W/lHEsT 580VSixZjnb45PvaPLJepV7DWDyQeDGH7q3Geqdj3V8XqZqtbQ4gbb38FfeX/fi3LO62 4glTYGoOCODF/l5DWvTiocBeYQcBCyOEzW9fp98nSyrflBUoxPL70SbmrBpnydx1c2tw aaCZ6mjlvXDzWYh4cJk3YdRTtChzuJTmOQ926zihD+g7CqzmoO8kWxe4oX3HnyURIvPh 4l1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771101505; x=1771706305; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Tyvs4xFeOgUlL1nJWOsM4wXcI5MSjDts4OzcTAQg/Sk=; b=jMQrucDE36tvHEr94NwRc3v9P0aLJY3LxSVANYhjgb3KoMd6GMwhmK+cMWrAX0M8BU 5nvPbPohFQJL0ruI4j80CQtHf+Up65fd1xYH2TiZpL8kLbYLKBjspZm5wezP3b7HBXUi Em0KCBFYN7SjQBnekcOfpOTDKORAhmx6bMiPJtVTVvRPScdd79ILCqrncGDgzmP8Jhm2 sH7QJu9Ef76NsKElVoTvgzcitm6qODAczMII0nL9OEfd0jmuGYj9dwYO2AV74J7hswKx L0nQLfflkx/woKE9o7+DQ5/xCt0430/5HgMWNWFS8J85sIKFg3V9nMRxxAw6CWuQjCSK MhBw== X-Forwarded-Encrypted: i=1; AJvYcCX0FKlFerj65KSO15IVwcxgvsgIkemgb56Bd7zMkFQkWiQ/SAD/f+z+Ahc1/0DXZWSHRX5CzaLOkNs/3jg=@vger.kernel.org X-Gm-Message-State: AOJu0YwISfvJOG0ztGZWwwOx00FvTs9XeCXxvOAxdw1vcEa0ldvoBwUm AWoNHjhQVpOCTNgTjuycBSNpGk2s1w4x3WYmBQ6Ww4w/WlY2ysZk+P90 X-Gm-Gg: AZuq6aL3DpeClAK6QZebrjvsUIx+wMvkvm+bYv1WH4P0J+wRguP/qgrmzpApAKJe2t+ 4u9OlK+GReYm8jmtnR4hWn/8acf8W9IvnjFdL1R4NCei4Hhn+mw6GEwIbe2fsj+swWEiL//Otrb 81hmKF7xbarNCqfelT+rDp7kY7YdPWYqX+pYCmCrNqUdp1uGS36kwYEkmdcdlm/i7QLza2RuYCB QQEXaRHjcfdTS1/dNUvgbtIXO92Rl61XQWrpVh/Vj1rdoU6FyRS9HHQsB7pAvbhTbCS6ZA/CXVw n0SZoSrr2G4ap5PkWJed4TB3rc+NwKESWo4iKYQxwAtk3AVJpDCURoHEzrl6om+ndQNVVP2IN0I dzOPOfYQbAg8LnlE03cNRBo9NrJXgzGO/q9BbDrqUP9PYGiTpG+zYHXesDLmdiprVAvH9PjxGzp l5CkrMRRmcUaQlT6Y4EF4F1yGCAA== X-Received: by 2002:a05:6000:2c0c:b0:437:6b73:ffa9 with SMTP id ffacd0b85a97d-437978c7625mr11670815f8f.5.1771101504666; Sat, 14 Feb 2026 12:38:24 -0800 (PST) Received: from Max.. ([46.210.227.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-437969fd36dsm15771151f8f.0.2026.02.14.12.38.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Feb 2026 12:38:23 -0800 (PST) From: Max Brener To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Max Brener Subject: [PATCH] Input: libps2 - embed WARN_ON(1) macros into their enclosing if statements Date: Sat, 14 Feb 2026 22:37:24 +0200 Message-ID: <20260214203725.6463-1-linmaxi@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make WARN_ON(1) statements embedded inside their respective 'if' expression= s, to improve code clarity. Signed-off-by: Max Brener --- drivers/input/serio/libps2.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/input/serio/libps2.c b/drivers/input/serio/libps2.c index 269df83a167d..05b64277aecd 100644 --- a/drivers/input/serio/libps2.c +++ b/drivers/input/serio/libps2.c @@ -154,10 +154,8 @@ EXPORT_SYMBOL(ps2_end_command); */ void ps2_drain(struct ps2dev *ps2dev, size_t maxbytes, unsigned int timeou= t) { - if (maxbytes > sizeof(ps2dev->cmdbuf)) { - WARN_ON(1); + if (WARN_ON(maxbytes > sizeof(ps2dev->cmdbuf))) maxbytes =3D sizeof(ps2dev->cmdbuf); - } =20 ps2_begin_command(ps2dev); =20 @@ -270,15 +268,11 @@ int __ps2_command(struct ps2dev *ps2dev, u8 *param, u= nsigned int command) int i; u8 send_param[16]; =20 - if (receive > sizeof(ps2dev->cmdbuf)) { - WARN_ON(1); + if (WARN_ON(receive > sizeof(ps2dev->cmdbuf))) return -EINVAL; - } =20 - if (send && !param) { - WARN_ON(1); + if (WARN_ON(send && !param)) return -EINVAL; - } =20 memcpy(send_param, param, send); =20 --=20 2.43.0