From nobody Thu Apr 2 20:28:00 2026 Received: from mail-yx1-f52.google.com (mail-yx1-f52.google.com [74.125.224.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 885BD24E4B4 for ; Sat, 14 Feb 2026 18:46:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771094817; cv=none; b=ASgNdbRj8ECCjVisjVl0oehDwsxMfgXI9LaleSLgnBjs6l6Sgv9E2HuNh89vXIK9tqLV8cwYtn0OSsLTbR2569S/eWKYwhiBo79umTmMggeKpEIrlXizUjcYl8JFSFqYobraGLBWArKvLlO1y/Cq4ruThJWh2E9qhe7BTl66q5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771094817; c=relaxed/simple; bh=PWt5A979gquISWmjM7f7KHwIRvk4VF7v3XQUNs8S3zc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=naowCF8u5g+ty+Azp9cyKxnBHHNx+eNS1Xm7qn9BA1c+3e372qPOwE6KO7673C3eK+PVI7QjzA58JBxd6gEs09a0OnkWF6VBaGWt9fBQZS0gJ+Ih4ApcS6vQoXzDcnn8qVvhDsxUd/fz0BFh5xHfBmV+bCeIsxMiIohgPECrU+c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TU/V9pVU; arc=none smtp.client-ip=74.125.224.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TU/V9pVU" Received: by mail-yx1-f52.google.com with SMTP id 956f58d0204a3-64ad8435f46so1776208d50.1 for ; Sat, 14 Feb 2026 10:46:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771094814; x=1771699614; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kIuq6pEzWYh2fE6reqj+zT5+zDErtmRcMuJdTOpJN4U=; b=TU/V9pVU9gxIDh93IB0xktIpjG05J3Qd5C0AqBrfLcRl8xjAJtLclHfLXO9T3paeh+ 5BdL3u+MDiSNzW3ROvK3HBsn2IPrEN/jgT1bWwIY2Iss867DsXiGMSb60UXQwSCHTsbf YRK55bfHuf3oA2WUMxerBsENWfsRCvrWITGVH6uI9iY1yE4YPhTb3Wpb9VQVY/yxWd+V dReLWHM6IEFUOd1lkfQ5DqJWM4K42cPvx9IpWCFBKqjoOdUEwiAQNJSf1iZZuXOwu7kZ w3ozJymK6+fInlzaupk0QzlHGXwysX5Lr5DHJSMJQ9WFYoo1cq5PBKDkbNyerGLW2m/b FgRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771094814; x=1771699614; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kIuq6pEzWYh2fE6reqj+zT5+zDErtmRcMuJdTOpJN4U=; b=Y7vgPqgNEvJEu7tSWXO0MLm8zXW/aJKHgQ4XIs/fsbbnZkR9e7SxtQzujrP8zvD1XD dK+KLr75USyeBI8AK6I+r0zmnzJsFehfJzc9NM2LhmTmOphxCZLtZIITkAs3hSniNTyj zdCW5Pq+6y/8ILFBduZ06d6cS6xoonITgIUm+YBvn0Fi/lazu9VUuJ81HAqaabBKOEGp hFpslL4tA3APlwe3/meTfxa6fDoWeI7oqAyhBhdFwy7HyjIOORNBEmh0XdBAO17hdKwp pR6ofxQcSyxZuFThEQ8THh7WSP9OdRhfedws3rAKJ197TXTFjTuKLIoEG7BgBzmOkNMu cDBA== X-Forwarded-Encrypted: i=1; AJvYcCW0aKjQO6SAtAKEpVom3YCSfoCbcevn/aMlq5R6eDT+8/atCE5KFe8/FfZUoY2s4tImBuwyNqkcRLav9CQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwZYxQG8ycK30lKaioiK9wsLNGlPtwubI6eGuPEbkJb2OT9RqLT AMPKZSh4GzwWcen4iNMK3k98XBmuPoZ0sik3m9xzMZ3fOM1+t3XVwN4U X-Gm-Gg: AZuq6aKXE/8zcSNZgdeQe8/RFXswSoxLblQuDHAWt+KpjaIL844ulKEUE09KMBl6o9Q vFh1Y7Hxo8L0oVohzYl8GKlv99vg4WclcSQNn5OFywecVGtM3oUnJMLqw7+XBhpaXk0lnJ19l2V QoYEtBkq8ODAygYyHRdm735o8MSY6Up0QsBOwmdz8f5E09hojavCSTY1N73D5BbAHVTwt2kw5D2 4PXC5FZWbGei5o82hgNgPYjwNhLZBirYlxIOKv6s3nrXmklV69/Qb+08GhkXpAIBlQ+UbOuEBl8 KYDwxPY4dRq35RcAvAGw0JtoxznEq1jTMacxM9Hua76Mz2Fn9BPCib6BzBrVHcoxzpdrjY0EDwe UWXqAFhHGWlgQpaeuEgF0/5uWj9ADDZDyXHGVT+BTXlmg1Ic6gKlcOs/SZ+sbcl6vojguIlnmCw aoIgwKCgUM5GHe5t/ivvQ6pDhDrBl4oLP02OS5t2BQ8GuOwexDEaan3eVWiCZjpodmMZPYfmZ33 szxvt2vj9jc76NVTaJYyMktP3KGsW58+hmWjy/JIzw= X-Received: by 2002:a05:690e:400a:b0:64a:fd80:85d with SMTP id 956f58d0204a3-64c21b58c19mr2401923d50.65.1771094814508; Sat, 14 Feb 2026 10:46:54 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64c22fd6ca2sm1539684d50.23.2026.02.14.10.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Feb 2026 10:46:54 -0800 (PST) From: Ethan Tidmore To: Jonathan Santos , Jonathan Cameron Cc: Michael Hennerich , Lars-Peter Clausen , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore , kernel test robot , Dan Carpenter Subject: [PATCH v3] iio: adc: ad7768-1: Fix ERR_PTR dereference in ad7768_fill_scale_tbl Date: Sat, 14 Feb 2026 12:46:37 -0600 Message-ID: <20260214184637.16985-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function iio_get_current_scan_type() can return an error pointer, the return value scan_type is not checked for this and immediately dereferenced which can cause a kernel panic. Add check for IS_ERR() and propagate the error back. Fixes: ff085189cb17 ("iio: adc: ad7768-1: add support for ADAQ776x-1 ADC Fa= mily") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202602051234.5gArzLyZ-lkp@intel.com/ Signed-off-by: Ethan Tidmore Reviewed-by: Andy Shevchenko --- v3: - Fix typo and added changelog. v2: - Add credit to bots and Dan Carpenter. - Propgate the error back instead of just returning. drivers/iio/adc/ad7768-1.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c index fcd8aea7152e..e16dede687d3 100644 --- a/drivers/iio/adc/ad7768-1.c +++ b/drivers/iio/adc/ad7768-1.c @@ -531,7 +531,7 @@ static int ad7768_reg_access(struct iio_dev *indio_dev, return ret; } =20 -static void ad7768_fill_scale_tbl(struct iio_dev *dev) +static int ad7768_fill_scale_tbl(struct iio_dev *dev) { struct ad7768_state *st =3D iio_priv(dev); const struct iio_scan_type *scan_type; @@ -541,6 +541,11 @@ static void ad7768_fill_scale_tbl(struct iio_dev *dev) u64 tmp2; =20 scan_type =3D iio_get_current_scan_type(dev, &dev->channels[0]); + if (IS_ERR(scan_type)) { + dev_err(&st->spi->dev, "Failed to get scan type.\n"); + return PTR_ERR(scan_type); + } + if (scan_type->sign =3D=3D 's') val2 =3D scan_type->realbits - 1; else @@ -565,6 +570,8 @@ static void ad7768_fill_scale_tbl(struct iio_dev *dev) st->scale_tbl[i][0] =3D tmp0; /* Integer part */ st->scale_tbl[i][1] =3D abs(tmp1); /* Fractional part */ } + + return 0; } =20 static int ad7768_set_sinc3_dec_rate(struct ad7768_state *st, @@ -669,7 +676,9 @@ static int ad7768_configure_dig_fil(struct iio_dev *dev, } =20 /* Update scale table: scale values vary according to the precision */ - ad7768_fill_scale_tbl(dev); + ret =3D ad7768_fill_scale_tbl(dev); + if (ret) + return ret; =20 ad7768_fill_samp_freq_tbl(st); =20 --=20 2.53.0