From nobody Thu Apr 2 23:54:49 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 661DA2288D5 for ; Sat, 14 Feb 2026 13:51:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771077086; cv=none; b=ZWjIVzIFaMI128ZpasGKdx6+Fsr4bWgtzX9e71m5GAZ4fTtE/AL9HpAJGfNZOqU/eLo68TAbDmuSw3Isw4RqdLRxX0spY6YU5CsLWqw980e91Fm9+SuDxAs+ziAXZnpbOveGKfSanFQCpZXlS3TTAJRCvjLDBb+1GK91s6WaLR8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771077086; c=relaxed/simple; bh=VhhMkue9iw773rpzEZnIsBzM13biep36V6wC4o1vBRE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IP6uPjb/+FBVSn5b57doQKeNgftW+8bNkn33kmbWISMbX+SMgncfHWOj+x9psTHTWmeVA4PQzPhQVr5D1g/RwEhgT4VPND4KA3c3WepammGUOrAc+leQZJLKBMet1JssU1/0UYIjww5ILKodK+hYs/2KmxAViLCqxTwx8CgNAM8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hcB936YF; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hcB936YF" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-8249cb73792so2030066b3a.3 for ; Sat, 14 Feb 2026 05:51:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771077084; x=1771681884; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cQIh2dXleF0tXd7fC57g6s194jlP8VKSVaVieQRVdm8=; b=hcB936YFgcu6XaKuhRbKHcVddyNCgfHO+DGlLWt4Xq3En0NhV1cv7eD+awGlPbNzlL 0402+O4B6GkTvdyyKWmoRQT8dzSF9udLPorj8oMDUM9eY1CMXutRF8VszBnu0Yr4+ihR X9X3wQZw11PfyYBMtDLFVTxR3XSz3/vxsvG41fzeIG+ErTQnSCWtLLftMB3NKNDODGgY 1lO7uyOmXPs1PGPj9XBifz7z4dfIOZ1RrpymPqBJBCCPuEJBoYxYP5fghgIu4pCNwX2x ADZTlnlaQ5iPai4Y0yZwxzA8LVG3/eJdZdD0qdwATwvmy4Sz1m11kQbTadiDfNVkPYih cdeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771077084; x=1771681884; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cQIh2dXleF0tXd7fC57g6s194jlP8VKSVaVieQRVdm8=; b=Fe+6xzvv15iTw3n7ZqT9fPEedseWxPjlU8jllFbk1H4iz/fVj/vbQ/gd/0QTfscrCk k6Py9lkdUzrE0hUrDLyU4sEHZxAXvosozDdu92E5gkKYwBi4w9SLdJZyjgEShkwRBwkH fLKYrIqInn2z2ByBiQURPRNzsMaXdRmOQCvdOIUe323Dw1EwKcs7ckxvcn+mOkXMxOaw z/fGg025uRkakIVfD/9K1h1hjEPWZYtdsJFO2kROhgPx8Q521G4lFPYZ+t+/PZs9Hq8a xmJ+CIEKGDexjFfjOOK06xm58kwHHKWMyUXnJpxfIDw4y1InYi60Ra4RmzMMpNEzAilJ jq3w== X-Forwarded-Encrypted: i=1; AJvYcCXWOYHwaufQHcyk24k0vEnLWN8dzFALv/mCqHo5Judj8s7a6jWUvzRsCnqoYFvxisLDhNfHexTu0Z8Cs7s=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0OgW1TldY0OT3qNy6Aq+2iwAu2PqwPR5YRwpfhSwxvIpMiPBB epODEblM8pqih9PHkmkUl5E/7b/tYTnJ9hc8HDbuKt1HeyDOTAuwf10L X-Gm-Gg: AZuq6aIT65O1UkUUS3ag54SfFxw20hDST4fBVyXS9QfWql4H/h9ugjZwMkQOhXVeJb2 CxS5sApS3STEsqCVIw7R5ypW3SEgIqDt0M9IGUOFO4B6JoTs8vCeE9lUOxYkHcxVSgh7AAT3A1v COpBwxnwYTUV9oihszyIOe5ZTmbLxXw9FjE3fBfKFRKcN5yvRba/yN+UP9lAHIHyIMTOLyj1eIq Y09ATz31kiqR8Sqp93mxKlGTxfcs9hfVaVcwtl+Fk/mvGwQeM9L0g4hJj6Od9OQkJ1pBXh9gyIN oB+gmurJ5JtE3Wx8WekQHUmTW25ygvxwI0YEbqzwcyGwgf9lw5TDAlTz7bQK66IBQ+s4kczx8t4 ErJGsGSzlJ40+mKwCwFIWrEpUV9c0FIENFyw/N0suleA2ty9mYGS9MPLhZjnHRrQT+n2oqEU48r 8SsJ9xYB90jrI7uSpnFcjBpOz8SKUAEgEvVw/UPjOWZeG1hN1SnA== X-Received: by 2002:a05:6a00:2282:b0:81f:3fa0:8c38 with SMTP id d2e1a72fcca58-824d950050fmr2803920b3a.20.1771077083584; Sat, 14 Feb 2026 05:51:23 -0800 (PST) Received: from localhost.localdomain ([2401:4900:8817:dac0:96bb:43ff:fec0:e782]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824c6a2e936sm5433761b3a.6.2026.02.14.05.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Feb 2026 05:51:22 -0800 (PST) From: Samyak To: akpm@linux-foundation.org, kees@kernel.org Cc: andy@kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Samyak Subject: [PATCH] [RFC PATCH] lib/string: fix coding style issues Date: Sat, 14 Feb 2026 19:21:07 +0530 Message-ID: <20260214135107.595089-1-samyak.bambole07@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" - Add spaces around binary operators - remove spaces after casts - Add blank line after variable declarations - Fix constant on left side of a conditional expression (0 < count -> count > 0) - Remove un-needed braces around single statements Signed-off-by: Samyak Bambole --- This is my first linux kernel patch. I have compiled and tested the changes on QEMU. I would appreciate any feedback. Thanks. lib/string.c | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/lib/string.c b/lib/string.c index b632c71df..8f5582d9a 100644 --- a/lib/string.c +++ b/lib/string.c @@ -127,12 +127,13 @@ ssize_t sized_strscpy(char *dest, const char *src, si= ze_t count) */ if ((long)src & (sizeof(long) - 1)) { size_t limit =3D PAGE_SIZE - ((long)src & (PAGE_SIZE - 1)); + if (limit < max) max =3D limit; } #else /* If src or dest is unaligned, don't do word-at-a-time. */ - if (((long) dest | (long) src) & (sizeof(long) - 1)) + if (((long)dest | (long)src) & (sizeof(long) - 1)) max =3D 0; #endif #endif @@ -150,23 +151,24 @@ ssize_t sized_strscpy(char *dest, const char *src, si= ze_t count) unsigned long c, data; =20 #ifdef CONFIG_DCACHE_WORD_ACCESS - c =3D load_unaligned_zeropad(src+res); + c =3D load_unaligned_zeropad(src + res); #else - c =3D read_word_at_a_time(src+res); + c =3D read_word_at_a_time(src + res); #endif if (has_zero(c, &data, &constants)) { data =3D prep_zero_mask(c, data, &constants); data =3D create_zero_mask(data); - *(unsigned long *)(dest+res) =3D c & zero_bytemask(data); + *(unsigned long *)(dest + res) =3D c & + zero_bytemask(data); return res + find_zero(data); } count -=3D sizeof(unsigned long); if (unlikely(!count)) { c &=3D ALLBUTLAST_BYTE_MASK; - *(unsigned long *)(dest+res) =3D c; + *(unsigned long *)(dest + res) =3D c; return -E2BIG; } - *(unsigned long *)(dest+res) =3D c; + *(unsigned long *)(dest + res) =3D c; res +=3D sizeof(unsigned long); max -=3D sizeof(unsigned long); } @@ -261,7 +263,7 @@ size_t strlcat(char *dest, const char *src, size_t coun= t) dest +=3D dsize; count -=3D dsize; if (len >=3D count) - len =3D count-1; + len =3D count - 1; __builtin_memcpy(dest, src, len); dest[len] =3D 0; return res; @@ -380,6 +382,7 @@ char *strnchrnul(const char *s, size_t count, int c) char *strrchr(const char *s, int c) { const char *last =3D NULL; + do { if (*s =3D=3D (char)c) last =3D s; @@ -679,6 +682,7 @@ __visible int memcmp(const void *cs, const void *ct, si= ze_t count) if (count >=3D sizeof(unsigned long)) { const unsigned long *u1 =3D cs; const unsigned long *u2 =3D ct; + do { if (get_unaligned(u1) !=3D get_unaligned(u2)) break; @@ -690,9 +694,10 @@ __visible int memcmp(const void *cs, const void *ct, s= ize_t count) ct =3D u2; } #endif - for (su1 =3D cs, su2 =3D ct; 0 < count; ++su1, ++su2, count--) + for (su1 =3D cs, su2 =3D ct; count > 0; ++su1, ++su2, count--) { if ((res =3D *su1 - *su2) !=3D 0) break; + } return res; } EXPORT_SYMBOL(memcmp); @@ -737,7 +742,7 @@ void *memscan(void *addr, int c, size_t size) p++; size--; } - return (void *)p; + return (void *)p; } EXPORT_SYMBOL(memscan); #endif @@ -805,10 +810,10 @@ EXPORT_SYMBOL(strnstr); void *memchr(const void *s, int c, size_t n) { const unsigned char *p =3D s; + while (n-- !=3D 0) { - if ((unsigned char)c =3D=3D *p++) { + if ((unsigned char)c =3D=3D *p++) return (void *)(p - 1); - } } return NULL; } --=20 2.53.0