From nobody Thu Apr 2 22:23:34 2026 Received: from mail-yx1-f49.google.com (mail-yx1-f49.google.com [74.125.224.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB0991E47C5 for ; Sat, 14 Feb 2026 04:45:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771044350; cv=none; b=FCv3r26nYv0PMvsDjzQ9SMpZudvxU7M4CPvQ23thJ5HA7CHyxqLjshfHeW1eEaz4boJghs0whqX4ef97nRdDJ363BlKGpz1SGaFmjNI6wFbyJtKCYmRiJpaAz+7OBKe9SFRP8i635VIYoBXYV1ZB0GM3AZjw3DBrQ4CEiT+J17Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771044350; c=relaxed/simple; bh=o/GV5jieQ1nfLMF3Kw74P6li2KB/ycvzwnF/hdIeyP0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qe09YTG6YJFaahP+iCT+S06IxTQrgqUWDQUbjJd+5ta/+/DVNWMvrN8gMP0CHINSwdESbwqSiC7bVU0nNY9UM8Ocm/vlvZlTLgwzlLOqcNjdQZJuqDjEYSe7wEJ59vLLykbZGnJPH55Amfe60raubxLw+hAV61txWYb3+X335lw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vkjg9ed8; arc=none smtp.client-ip=74.125.224.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vkjg9ed8" Received: by mail-yx1-f49.google.com with SMTP id 956f58d0204a3-64acd19e1dfso1543975d50.0 for ; Fri, 13 Feb 2026 20:45:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771044349; x=1771649149; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R43m5m1ez1GonWOxLG/dVD5h7A9CUwXvLk5pXGze70s=; b=Vkjg9ed8CNNTXxgQ+ueU8tL2WddHUZ3dIR86GTMuuYRXSNMrQoENP1TomfwD+AKqmR eAmdyf5ZqtCmfWHWKTtUmztOKeL4lX4qAFNcEhBP5Pnpg5j9hHRBnuvQcgweG7I8z3a4 TKDSUbI0gzvBTsczVQdrMIxfxVAUBDtoY08qTGGEPruNU2rnIgJnOTfRdP7ICdc5JtLY JSI76AX3sm6W280/tDnaTLecOLhKBebfG6be3UwanAYyDE+TWXH0BHF8tCidEt0SYsC8 eFcqJSAcbRqJo3m/bH0m1jJmICGA/jP1+n2eRIZChigu9USecD0lPXjDnAKnuXpF5eq7 i+dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771044349; x=1771649149; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R43m5m1ez1GonWOxLG/dVD5h7A9CUwXvLk5pXGze70s=; b=FeWmzK2viT/9vuBLYNZKQAFaIsPtwg4JGAfewn3G73IWwocq4aWI67G12KXjpxc4P7 yccHPazxJ6wDhm20WLkB44nfFM9tsKoUKQdU2a4yhmB3pyjo/bWhjCqpq8nCULaS5aaM DqpqfDgogaAIIcHnveLlLxTjGz3Gca7ITU2xiH6LEfJazISq8oe2lDscgDPfxwgIbo5h /VIhanzzu/nUhUF78jnYetSDe5MTtcoDLBJIV7gZl9lj/p3xYv2+eCtP3Ju3ru4J5hew UvaCEYvj9kaBd2JiJqbL1gMLn69InsOw1TjGZf62GVyp+QEmdD4q0oOn73xMYfsSKQb+ ZaXg== X-Forwarded-Encrypted: i=1; AJvYcCVxL7hd+9mJS7PuQk+qda2vNf0lSBLQkWoBXfyjWrNOINjXb91FFfFRadG4Oc60zjA/RQYpRo7634+ouK0=@vger.kernel.org X-Gm-Message-State: AOJu0YzOLKsj1bEG1/TB1tthLjvP4NgdvLYXTAGSqHZ5TBRs1/sHs5hp LZcj4tA/eg/Zib6Z2aWwsmGtwYvc0zcLo7lnq9aGMYCGU79FKllBhY1f X-Gm-Gg: AZuq6aIUK2Cfadq/UeR0v9C4qf5l5DDowADguJeuFxFlWDMRCSlLrfwmuvMRT9vZUAS /AP1xkX0muiPlczvQgL+5QhAzkL35C4oVuVyQ0fOIQMVCNWakYFZCywMz7ChyNht2e7aKXlsdMk rrksth2fHRRl9sJt1fkyUI5y+RbBkuFKN1t8nEUQBkPe4fQ/7Igi9GX0Jn/7LBIUFyN0RgmgO+Z HYG6VM2bjvwhTurK4IMc+UUZis9dzqQf4z6dNTn+BJHeKUVkiVaHlM8cbm4WIaEnYzUE4wNQ1Oy RfzSgsi34a9Tw5SzqdjxRPrjNEj2cFGoKgqqvFmA8GLNGgGWX/KSc6pVOAsRvBCKJ7SJlf6e3QS pCznWXJrPiU03fZn67NIZGVUoIw3XuZ/S2Uy2wtcz3CGDb99lxIzjlLvqLJc/CI5OfeIHq8nH8c JEJumB9vWnOdmVz5cBdQtoTgwlu88R145MGlFydMfhotPr5vgs6ci06hX8qOxN5DJIqkKrcqQpd miJrAIWe/bO6JYtjibkvYjvYg5qxeaVjRpb0GtxTa8XewbDWkPhVA== X-Received: by 2002:a05:690e:14c9:b0:64c:2114:17a2 with SMTP id 956f58d0204a3-64c211418c1mr1742970d50.62.1771044348735; Fri, 13 Feb 2026 20:45:48 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64c22eb2059sm570067d50.10.2026.02.13.20.45.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 20:45:48 -0800 (PST) From: Ethan Tidmore To: Linus Walleij , Bartosz Golaszewski Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore , stable@vger.kernel.org Subject: [PATCH] gpio: nomadik: Add missing IS_ERR() check Date: Fri, 13 Feb 2026 22:45:31 -0600 Message-ID: <20260214044531.43539-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpio_device_get_desc() can return an error pointer and is not checked for one. Add check for error pointer. Fixes: ddeb66d2cb10f ("gpio: nomadik: don't print out global GPIO numbers i= n debugfs callbacks") Cc: stable@vger.kernel.org Signed-off-by: Ethan Tidmore Reviewed-by: Linus Walleij --- drivers/gpio/gpio-nomadik.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c index 97c5cd33279d..e22b713166d7 100644 --- a/drivers/gpio/gpio-nomadik.c +++ b/drivers/gpio/gpio-nomadik.c @@ -430,6 +430,9 @@ void nmk_gpio_dbg_show_one(struct seq_file *s, struct p= inctrl_dev *pctldev, #ifdef CONFIG_PINCTRL_NOMADIK if (mode =3D=3D NMK_GPIO_ALT_C && pctldev) { desc =3D gpio_device_get_desc(chip->gpiodev, offset); + if (IS_ERR(desc)) + return; + mode =3D nmk_prcm_gpiocr_get_mode(pctldev, desc_to_gpio(desc)); } #endif --=20 2.53.0