From nobody Fri Apr 3 00:00:13 2026 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F56E2BE03B for ; Sat, 14 Feb 2026 04:28:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771043306; cv=none; b=Oe6K3aKH1ZlMdznBuovHrNnVhjoebu2CqE8HD28FopiVoqR+gswPzVrYi6LMjIz+COvUQZrpwzu6/3ZbpP4nX8zcf3Sf5MCWFGemaDErjwbT8zSDb8b4sbyVN8OaLk2yo4v1uJU9ERcnyg7zGsSw3jL6MSD895sfvhTONI8yD9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771043306; c=relaxed/simple; bh=Qj+5yNQaODMwMypBYxmbGsn05bpI9Wn8ngebcpEKNmg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pwxOlQdJLgdHpnv2aVpsuXQCF/L3JTA/x9K+3hi90ODXFoypFHrYWRY5H+GA1ALkQg3/7Kxh/Q8PVW4chBPUHSYyr9Pq/D9iR+bN/LzOFpZHjWrVfJL16HCdbiYpSVwQHrPiLS99cwB20/Hkjn73uL9PVkowNJtOcq55bqR3qPw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=P38rMBNg; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="P38rMBNg" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-126ea4b77adso2033435c88.1 for ; Fri, 13 Feb 2026 20:28:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1771043305; x=1771648105; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CZrFuOxPh30GDseArs+7imxFHdxAweEbIg0R0txG24E=; b=P38rMBNg2rZhXcogQGJ9+R8tF4LHzRfUBLIcyRngzoipm01vDmqxDNgvwtYrtkImr3 dnP2/wCgSmPb0T1vly7kTz9vhOx+w0oNpTKYlnNYTm/TYbjnDRBYMs5IeqbfBR+i6mc4 lCJgws9zxEctDE74pMbEQNwT53SN0DD025tZ/KOiLidjMSvofR8VQjHg/HW6Hs6IZENm GbusmRAmf4tVJIU8KH/P552HHdKA1rs7kOv/lk6cFpni15F4xg6HU9bglemd41SKx/Ws oBFxDkB4dhzeW8lAOYH4/+3xW/pAZu9IS69Dj+SMbVf828qsvPxsT7Qxz8EQqya8vdj/ bbOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771043305; x=1771648105; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CZrFuOxPh30GDseArs+7imxFHdxAweEbIg0R0txG24E=; b=Fqo2cR5C5AMAxAblfVjDpgQ/jJtgn18w32ac7ymkdVPumzkmb0PRp0WxE2clUeJRna 1fT9bGPJaTFe8RwGjYG3rLwXs1FsfJFwpBRFlKcqhfcQR25d4jjpqAdRh9NTrcaPPrwG 1sXqRqzzw9s8+t2O2Woh8KN0fty4PGze0pHyId+jHzoDpHahIu/ce6LCNnNS210hgSGp S0LreADwWAP5tSlebw7LtkQr+Zzxv7Qn7WrzzbGTFc+N37bLo+8jp9IUlYVi6th9vHmA 4sGZQM3mbmQPFE4rvOmiclFJ3rMrh7AfksFriP8SXIEuWKJnVhpkBNtyLEX9zFznrn6G WaPQ== X-Forwarded-Encrypted: i=1; AJvYcCWEuqtQP1PYva1pyzMCCYArdx2j75s1HTldMV8vjPmul4GaEzIUflpTtBk5qkfSncOFL2qGikX2Dsl5jtI=@vger.kernel.org X-Gm-Message-State: AOJu0YwSg7S0/FCYccGyrtIjcKT+IsbCM099PynjwRbBarQbFWrKPk/K O4uoZCDFTVNtmMszqD6akHRZv88GmvZqf58eMCBRzweZFMgtZZCQC3tRCHwTkGfu77c= X-Gm-Gg: AZuq6aLtua65ss/OliNCakcMXNKv1LZNw7LbHHa2ZUlvQtOIsf3d7oU6Yw0gbQ32F9T h/hU3LECPIrsuF/zblLNiouM4mxy/cK4AvvOJ++EvQ0oIO06A27hjS79ZR4/wDt6UmD5RaKA0D7 WPg78BhQ5jysgiIiBcESG/DdelAVzWvpNiH8+gDhejIFDo/9hAjC+duPPKHlzqyQqmiFNcc0VEb A6+QXNGEOWOEKWjEL8uJgdbPqocXLm8kU3onxy7eoXC89XNwVmEnnH28vDk9UyFvWc+RUlLSQQ+ ori+7UOuxMzD6earDMZ0XOtn036inXsFVevLYkdbFggQnbL59N3oA4QWvsKKdHhUuZahIGM5Vcj 6xMC8AFI9rPIbeV0x8wEKvdrOpbhEXjJzzSO3v2ULyY/XiVaSjOCTILRftGdOcXFe/U+4c0kDAW UhRFn/HoLxnkJqoBSzsbeL+IGsZcn+Cxfw5FAfxWfEdAW+gg== X-Received: by 2002:a05:7022:929:b0:11d:f44d:1863 with SMTP id a92af1059eb24-127397a2455mr2164149c88.11.1771043304472; Fri, 13 Feb 2026 20:28:24 -0800 (PST) Received: from apollo.purestorage.com ([208.88.152.253]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-12742cbc900sm1021042c88.14.2026.02.13.20.28.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 20:28:24 -0800 (PST) From: Mohamed Khalfella To: Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , James Smart , Hannes Reinecke Cc: Aaron Dailey , Randy Jennings , Dhaval Giani , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Mohamed Khalfella Subject: [PATCH v3 04/21] nvmet: Implement CCR logpage Date: Fri, 13 Feb 2026 20:25:05 -0800 Message-ID: <20260214042753.4073668-5-mkhalfella@purestorage.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260214042753.4073668-1-mkhalfella@purestorage.com> References: <20260214042753.4073668-1-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Defined by TP8028 Rapid Path Failure Recovery, CCR (Cross-Controller Reset) log page contains an entry for each CCR request submitted to source controller. Implement CCR logpage for nvme linux target. Signed-off-by: Mohamed Khalfella Reviewed-by: Hannes Reinecke Reviewed-by: Sagi Grimberg --- drivers/nvme/target/admin-cmd.c | 44 +++++++++++++++++++++++++++++++++ include/linux/nvme.h | 29 ++++++++++++++++++++++ 2 files changed, 73 insertions(+) diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cm= d.c index 65ed772babb8..925a81979278 100644 --- a/drivers/nvme/target/admin-cmd.c +++ b/drivers/nvme/target/admin-cmd.c @@ -220,6 +220,7 @@ static void nvmet_execute_get_supported_log_pages(struc= t nvmet_req *req) logs->lids[NVME_LOG_FEATURES] =3D cpu_to_le32(NVME_LIDS_LSUPP); logs->lids[NVME_LOG_RMI] =3D cpu_to_le32(NVME_LIDS_LSUPP); logs->lids[NVME_LOG_RESERVATION] =3D cpu_to_le32(NVME_LIDS_LSUPP); + logs->lids[NVME_LOG_CCR] =3D cpu_to_le32(NVME_LIDS_LSUPP); =20 status =3D nvmet_copy_to_sgl(req, 0, logs, sizeof(*logs)); kfree(logs); @@ -608,6 +609,47 @@ static void nvmet_execute_get_log_page_features(struct= nvmet_req *req) nvmet_req_complete(req, status); } =20 +static void nvmet_execute_get_log_page_ccr(struct nvmet_req *req) +{ + struct nvmet_ctrl *ctrl =3D req->sq->ctrl; + struct nvmet_ccr *ccr; + struct nvme_ccr_log *log; + int index =3D 0; + u16 status; + + log =3D kzalloc(sizeof(*log), GFP_KERNEL); + if (!log) { + status =3D NVME_SC_INTERNAL; + goto out; + } + + mutex_lock(&ctrl->lock); + list_for_each_entry(ccr, &ctrl->ccr_list, entry) { + u8 flags =3D NVME_CCR_FLAGS_VALIDATED | NVME_CCR_FLAGS_INITIATED; + u8 status =3D ccr->ctrl ? NVME_CCR_STATUS_IN_PROGRESS : + NVME_CCR_STATUS_SUCCESS; + + log->entries[index].icid =3D cpu_to_le16(ccr->icid); + log->entries[index].ciu =3D ccr->ciu; + log->entries[index].acid =3D cpu_to_le16(0xffff); + log->entries[index].ccrs =3D status; + log->entries[index].ccrf =3D flags; + index++; + } + + /* Cleanup completed CCRs if requested */ + if (req->cmd->get_log_page.lsp & 0x1) + nvmet_ctrl_cleanup_ccrs(ctrl, false); + mutex_unlock(&ctrl->lock); + + log->ne =3D cpu_to_le16(index); + nvmet_clear_aen_bit(req, NVME_AEN_BIT_CCR_COMPLETE); + status =3D nvmet_copy_to_sgl(req, 0, log, sizeof(*log)); + kfree(log); +out: + nvmet_req_complete(req, status); +} + static void nvmet_execute_get_log_page(struct nvmet_req *req) { if (!nvmet_check_transfer_len(req, nvmet_get_log_page_len(req->cmd))) @@ -641,6 +683,8 @@ static void nvmet_execute_get_log_page(struct nvmet_req= *req) return nvmet_execute_get_log_page_rmi(req); case NVME_LOG_RESERVATION: return nvmet_execute_get_log_page_resv(req); + case NVME_LOG_CCR: + return nvmet_execute_get_log_page_ccr(req); } pr_debug("unhandled lid %d on qid %d\n", req->cmd->get_log_page.lid, req->sq->qid); diff --git a/include/linux/nvme.h b/include/linux/nvme.h index d9b421dc1ef3..9b6d93270c59 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -1432,6 +1432,7 @@ enum { NVME_LOG_FDP_CONFIGS =3D 0x20, NVME_LOG_DISC =3D 0x70, NVME_LOG_RESERVATION =3D 0x80, + NVME_LOG_CCR =3D 0x1E, NVME_FWACT_REPL =3D (0 << 3), NVME_FWACT_REPL_ACTV =3D (1 << 3), NVME_FWACT_ACTV =3D (2 << 3), @@ -1455,6 +1456,34 @@ enum { NVME_FIS_CSCPE =3D 1 << 21, }; =20 +/* NVMe Cross-Controller Reset Status */ +enum { + NVME_CCR_STATUS_IN_PROGRESS, + NVME_CCR_STATUS_SUCCESS, + NVME_CCR_STATUS_FAILED, +}; + +/* NVMe Cross-Controller Reset Flags */ +enum { + NVME_CCR_FLAGS_VALIDATED =3D 0x01, + NVME_CCR_FLAGS_INITIATED =3D 0x02, +}; + +struct nvme_ccr_log_entry { + __le16 icid; + __u8 ciu; + __u8 rsvd3; + __le16 acid; + __u8 ccrs; + __u8 ccrf; +}; + +struct nvme_ccr_log { + __le16 ne; + __u8 rsvd2[6]; + struct nvme_ccr_log_entry entries[NVMF_CCR_PER_PAGE]; +}; + /* NVMe Namespace Write Protect State */ enum { NVME_NS_NO_WRITE_PROTECT =3D 0, --=20 2.52.0