From nobody Fri Apr 3 00:00:16 2026 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEBEE17A31C for ; Sat, 14 Feb 2026 04:28:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771043304; cv=none; b=qKEjGNLZFFZyDAs/MBGZVOQHcn77MivdDFqPQScUeDJX2Jlv5SH07QWkx2hcW2eVO2rWC5DmIOTQFSL7Zyr79ebh24PE22cEUrpUn/AaG/sAUKTWY+vyRUc0ZuS+mJKb0gWka78tTSZOZp1NZ64YEDgQUcWujZu6ums0crYoaQY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771043304; c=relaxed/simple; bh=y7L9tNtdwqa4S4X4xFl4mjh0detKB1D0E0gERIKPd18=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BxUHtcNHP476xScoS30QoQARpmmziS03sl2qtylGsW//STiMsIzxyR1PkdUlZl4Q0Atgf4rFibyMpmmhzyoHbmvPjYBTygWeyDA6OrUbBK6aPh5xEqYfeFinDEBL6BTO0r4WXrQYlbQyJHVP1clQtq1IXLeHWht8OYRa1DZqQ7E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=NVbX9qb7; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="NVbX9qb7" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-1270adc5121so2321964c88.0 for ; Fri, 13 Feb 2026 20:28:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1771043302; x=1771648102; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DWiAfLikzaFr4GnyqsyXng2vgSJVn4kiF95ZAV+60zk=; b=NVbX9qb7Ql7oZAAYGLSXNzz0YhVODu0BYy8Pe1WjxKEuATbGxvGF4mi8WjPNH7Fqmd a1ZgAoAeLdWbbIQAEo5HNOoaDxNBojEZJLHSZHUg8EjCsI7rlvBV4sQdaCeCSvMQzQGG QYIp4hlb8/SAm6FEYsz0WGhOZ+2Up3OSNJlfU7GIb6IDUjVpm9b0tblhdGqQoQLMrxnf FQvxu1v7R3GwFXmxGiRque+YMWr4MX+ImiUyPUNZO9UTdN/7Xn75dpEEOncOToWtQIkU MP64jRWJ5OXUOpwrjy/XIhCj4JXxxNy05YNdX+qpJo2TlTb48+s07B2yNM2ANG7wRq78 1k0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771043302; x=1771648102; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DWiAfLikzaFr4GnyqsyXng2vgSJVn4kiF95ZAV+60zk=; b=q7oFAN9zgTK85RPjeG0gIfssPtqXpyRbPXvRDjNYqd1mv9fBt06gm/ZQ3Qyq+4v/Rb 2H+8h02ZUQMU/sz3/WLSfHMr1indaMFGUHy7aEMlu9Rgh0hyy+1glyywWPMMDB/904EA NduJZ3k7XQdidCqJUkx0lA3BA+xpwlYYGPSxgzlFGPMRzgX05GqETnyXOqBpfqJ22kUw Wvvfn6wmnXJGP4g7StS4iMEQ/Q6ofRFFtfwX1EdD7pfV6BDw+0ZZCQgSuVBYZIdVjJoD bJt0GSarUGtCGXeSRUqcMJ1t6RopxxGsA1NieMzvJqbDN8hnxPwRcKXiOyzbnP/8LNhR N4Ig== X-Forwarded-Encrypted: i=1; AJvYcCXZ8+tIv0aWE6cuBMKVO9+ySUM0zjByKN/vuaKGN+pJTSgkomRH4k3hfjWNNsYgeYCl9CGqUdGgZqkkOV4=@vger.kernel.org X-Gm-Message-State: AOJu0YwJ6fYJWfQqBPatX8akZs3/EGJV9SvLfKwwOTgr05URMS60TUme CjH0JQreKVPSW7N7OsgFGVVzWRcaWgWWKEPYZgIsEUh53jN3Mi0UmwloiM/+wEqXsyI= X-Gm-Gg: AZuq6aLGJw36ktMXHIygVGMqbY0Kqy/XBcxkM5poweK+u7jUdkDiBJKY/krj05Q7h/M Eox5vy9pPH/5NnTJ7cW6Hs7AKwUn3Z5CW8QFX0R6J1vl9sv+KP/CtPtGJhWOsQRB3CukNVN3lqY zoOnT6l01rWSn1u/2aGYR2QClx8YsmfoLWrbZe5nmEgcR4Ur4ROqlLIzWj75kXW1D3/cNGp/93V 7KeGFMK8Dz9AABSZHkPq9tOyGIoW3YNjfWWM19R/VfH/oP76SkektKp0LrjtYPzWr7r059OYmmi nzQtJI1I9Z8Ojf0x/fs1jJtk6UF2aHsZAqhAIJDaTt1IZ3ANoNSB2zT4Ar680hL4xjMg0AfaAF0 UzYu1YjlceNXg/+4P/3qaBuWgVy6lPWSQ/+e2OMXPo+tLiL2mOz93U/ppHTQcXs7+9fWvsrgeNB A0GbWdJnqDa3oYGcpfxf5B8gQwXQPJBGr3QE+hBPVl2k32Wg== X-Received: by 2002:a05:7022:2394:b0:127:33c5:536b with SMTP id a92af1059eb24-1273adf06e3mr1330405c88.1.1771043301717; Fri, 13 Feb 2026 20:28:21 -0800 (PST) Received: from apollo.purestorage.com ([208.88.152.253]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-12742cbc900sm1021042c88.14.2026.02.13.20.28.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 20:28:21 -0800 (PST) From: Mohamed Khalfella To: Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , James Smart , Hannes Reinecke Cc: Aaron Dailey , Randy Jennings , Dhaval Giani , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Mohamed Khalfella Subject: [PATCH v3 01/21] nvmet: Rapid Path Failure Recovery set controller identify fields Date: Fri, 13 Feb 2026 20:25:02 -0800 Message-ID: <20260214042753.4073668-2-mkhalfella@purestorage.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260214042753.4073668-1-mkhalfella@purestorage.com> References: <20260214042753.4073668-1-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" TP8028 Rapid Path Failure Recovery defined new fields in controller identify response. The newly defined fields are: - CIU (Controller Instance UNIQUIFIER): is an 8bit non-zero value that is assigned a random value when controller first created. The value is expected to be incremented when RDY bit in CSTS register is asserted - CIRN (Controller Instance Random Number): is 64bit random value that gets generated when controller is crated. CIRN is regenerated everytime RDY bit is CSTS register is asserted. - CCRL (Cross-Controller Reset Limit) is an 8bit value that defines the maximum number of in-progress controller reset operations. CCRL is hardcoded to 4 as recommended by TP8028. Signed-off-by: Mohamed Khalfella --- drivers/nvme/target/admin-cmd.c | 5 +++++ drivers/nvme/target/core.c | 9 +++++++++ drivers/nvme/target/nvmet.h | 2 ++ include/linux/nvme.h | 10 ++++++++-- 4 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cm= d.c index 5e366502fb75..368e36362ac5 100644 --- a/drivers/nvme/target/admin-cmd.c +++ b/drivers/nvme/target/admin-cmd.c @@ -696,6 +696,11 @@ static void nvmet_execute_identify_ctrl(struct nvmet_r= eq *req) =20 id->cntlid =3D cpu_to_le16(ctrl->cntlid); id->ver =3D cpu_to_le32(ctrl->subsys->ver); + if (!nvmet_is_disc_subsys(ctrl->subsys)) { + id->ciu =3D ctrl->ciu; + id->cirn =3D cpu_to_le64(ctrl->cirn); + id->ccrl =3D NVMF_CCR_LIMIT; + } =20 /* XXX: figure out what to do about RTD3R/RTD3 */ id->oaes =3D cpu_to_le32(NVMET_AEN_CFG_OPTIONAL); diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index eab3e4fc0f74..e5f413405604 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -1394,6 +1394,10 @@ static void nvmet_start_ctrl(struct nvmet_ctrl *ctrl) return; } =20 + if (!nvmet_is_disc_subsys(ctrl->subsys)) { + ctrl->ciu =3D ((u8)(ctrl->ciu + 1)) ? : 1; + ctrl->cirn =3D get_random_u64(); + } ctrl->csts =3D NVME_CSTS_RDY; =20 /* @@ -1662,6 +1666,11 @@ struct nvmet_ctrl *nvmet_alloc_ctrl(struct nvmet_all= oc_ctrl_args *args) } ctrl->cntlid =3D ret; =20 + if (!nvmet_is_disc_subsys(ctrl->subsys)) { + ctrl->ciu =3D get_random_u8() ? : 1; + ctrl->cirn =3D get_random_u64(); + } + /* * Discovery controllers may use some arbitrary high value * in order to cleanup stale discovery sessions diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h index b664b584fdc8..a36daa5d3a57 100644 --- a/drivers/nvme/target/nvmet.h +++ b/drivers/nvme/target/nvmet.h @@ -264,7 +264,9 @@ struct nvmet_ctrl { =20 uuid_t hostid; u16 cntlid; + u8 ciu; u32 kato; + u64 cirn; =20 struct nvmet_port *port; =20 diff --git a/include/linux/nvme.h b/include/linux/nvme.h index 655d194f8e72..7746b6d30349 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -21,6 +21,8 @@ #define NVMF_TRADDR_SIZE 256 #define NVMF_TSAS_SIZE 256 =20 +#define NVMF_CCR_LIMIT 4 + #define NVME_DISC_SUBSYS_NAME "nqn.2014-08.org.nvmexpress.discovery" =20 #define NVME_NSID_ALL 0xffffffff @@ -328,7 +330,10 @@ struct nvme_id_ctrl { __le16 crdt1; __le16 crdt2; __le16 crdt3; - __u8 rsvd134[122]; + __u8 rsvd134[1]; + __u8 ciu; + __le64 cirn; + __u8 rsvd144[112]; __le16 oacs; __u8 acl; __u8 aerl; @@ -389,7 +394,8 @@ struct nvme_id_ctrl { __u8 msdbd; __u8 rsvd1804[2]; __u8 dctype; - __u8 rsvd1807[241]; + __u8 ccrl; + __u8 rsvd1808[240]; struct nvme_id_power_state psd[32]; __u8 vs[1024]; }; --=20 2.52.0