From nobody Thu Apr 2 22:22:21 2026 Received: from mail-yx1-f41.google.com (mail-yx1-f41.google.com [74.125.224.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6235D42AA6 for ; Sat, 14 Feb 2026 00:53:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771030431; cv=none; b=XaFqO/g7tUTkx42O1MAAmfacx8pGmiPWoUOaU6mO5hY8/cwEgfXP9fhG25Yylly9cbh+MkCz61fJJU/u/MM4j0I43+OoRUrcUP7Grm60gQ67iXtIOEYWXlvz3xLaBgl3gaEmBGb7u+Bum2bIMxtNSbHFPjxPVbZy1MwfPpWRA7g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771030431; c=relaxed/simple; bh=QYYZINt1LWkcTytk2g0wrYoIvMCsV7Crk2E7/cdK7o4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AffU+pt0zDQPl3EAk79K0I0JkkQaMHCK3fIR/1lCjIPisomfzxj6vr/gpyVHNNAEaQ/1CPlzdJAM2Ujk7wsN3ORn2am/ZmpUrmsdS5abndV8wxu7k92GPV+XpsjOPAeiviZLbX4DQwqZN7uGtqSnu0jJQAH0LSmbHDBQdqogCQQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Spe5DRd/; arc=none smtp.client-ip=74.125.224.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Spe5DRd/" Received: by mail-yx1-f41.google.com with SMTP id 956f58d0204a3-64ad46a44easo1475251d50.0 for ; Fri, 13 Feb 2026 16:53:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771030429; x=1771635229; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kT4ZLcabTstJMeBMLau6g+RNhZ1l0Yxf3jcGbnfdBIk=; b=Spe5DRd/Vl2OErWoxkihomW07NOsNCJ9xVIvBko40LDmLWTcwupbQ8TocTVkeJ1dvR z8hkBSGurEz/ySSOXAaGvu88avbsgw6lqoTTKmK26gcc02GPzU+6zU9o/HLJXfdFTIjc 0KEUlUGTbYaOq5UeNrAo/RuxR7M2bleUktp7hi/SoFQy7qy8+57KrKVGqMXGGfCSD4Lz 8YXKIXPViafSzxgQffo5y5l0rF5zpQd00qVRDDK0yq5fHiCeEVwdJlfgjVC/4iWaUr5e QGEqBHsDx8URhpMuADoc+xw6/z6SrA06cQt1W4EZVTFxZ6DshjhiTg0mUIifY6sjE3Yy QH4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771030429; x=1771635229; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kT4ZLcabTstJMeBMLau6g+RNhZ1l0Yxf3jcGbnfdBIk=; b=HkGbjetZKiK8lMVU2l/pdBpUs/BqpJ/Wd/3BHSQge0OxdjMpw41rszZGf4OAT7yvD0 ByR2uZGtYZno0p+yURaHBryOWMd6MrSzdWxRBfR2RIC0gEn3JTThcAvCdRxiondPSooi MFf+IIHSM/ZJiVTsBAVVsaTgXmFZhDDZyQgCb4FNLqhAt60adngtmk4Q2bka5w8ogqgl J6U5TV+azShFn2cdPpcf5akZi0EkWOn3nV1c9dQHsrVE577ttVpfWQD1faGlu4w+w+j0 LOLbtJsX2hIMM2eGtG//JKx64BXuzT5bEaMqfvvHhAXEPQZU4NijYpAyUlpCdxboNKM+ vUiQ== X-Forwarded-Encrypted: i=1; AJvYcCWgDCP02VxGvFgCpIEFaFCaeem5FgRVdh1Srag1l44HG3851qAtOhdEPCbup+0hAt88UFgjmx1Crucv8iM=@vger.kernel.org X-Gm-Message-State: AOJu0YzJFzAwZ3ZBveyOXjZHn9847L2mZEeOMq3YO/iILIfg6Xwbpok6 FTEXmIfIhj6ATJhob5eh9gu7O3QzaznaM03MH4xH04AGx8vm226HhQSO X-Gm-Gg: AZuq6aJsd/Qvh60aj7hc33U83yscYxLf5swJF0uaYWslcQquGWuIIsfTEMDkGnSA93E QfjMW5xROFRDeR90magAPw1qZLL+KLC2jlbxknPF1aCDrX7qz37r6YLPe4ic5qTZLTG6NfoMifR i8UYgdKhnk9GtrxmcsbUxfJ8w91/nYsGw+Z52/0ef9sdllydtfepx7BMGT66sSc0CvBBt3kxJiK GJ8JNEOksSZqm4bbQqRBnp6xLMmrH5YgWsCxfC79GxGHdLBIS2VYtbi1EcQK/NKMbHO+g43NIBN nh2Gi8am4UwDGy7bbI6ecQ9vPuRNyiUbAsAHDVtrXAU9DWBZHJ7Gb2Gl3/67VGLolaAdpKiuZ0N 9Y/FOKaSxLVYwjvglw7UfLwmWHfagg6X0VihzEAghII5GZ+3CNQqYVI6rDXmWiBXj2buk/h4XIk vKl4iLo1ZerDHFTvp9rBYhtGjkIr00OugrYErP2ea2KQvFP+keE7glqqcn2xlWq1xaqMjmnDgwm Rq6HTVuOhp3lplfq6efp4hpvB0/0N8WuSI8HT8yl6Q= X-Received: by 2002:a53:de11:0:b0:649:3897:ba21 with SMTP id 956f58d0204a3-64c14d381f8mr3455938d50.52.1771030429324; Fri, 13 Feb 2026 16:53:49 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64c22fb1d2fsm352432d50.18.2026.02.13.16.53.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 16:53:49 -0800 (PST) From: Ethan Tidmore To: jorge.marques@analog.com, jic23@kernel.org Cc: lars@metafoo.de, Michael.Hennerich@analog.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore , kernel test robot , Dan Carpenter Subject: [PATCH] iio: adc: ad4062: Add missing IS_ERR() check Date: Fri, 13 Feb 2026 18:53:32 -0600 Message-ID: <20260214005332.29608-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the function ad4062_sizeof_storagebits() iio_get_current_scan_type() is called which can return an error pointer and is not checked for it. Also the function ad4062_sizeof_storagebits() returns type size_t but, is only used once and the variable assigned from it is type u8. Add check for error pointer in ad4062_sizeof_storagebits() and change return type to int so the error code can be properly propagated and then checked. Fixes: 23cc92280302d ("iio: adc: ad4062: Add IIO Trigger support") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202512280539.AholFF7m-lkp@intel.com/ Signed-off-by: Ethan Tidmore Reviewed-by: Jorge Marques --- drivers/iio/adc/ad4062.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad4062.c b/drivers/iio/adc/ad4062.c index dd4ad32aa6f5..c864de3b46ba 100644 --- a/drivers/iio/adc/ad4062.c +++ b/drivers/iio/adc/ad4062.c @@ -1199,11 +1199,14 @@ static int ad4062_write_event_value(struct iio_dev = *indio_dev, * The AD4062 in burst averaging mode increases realbits from 16-bits to * 20-bits, increasing the storagebits from 16-bits to 32-bits. */ -static inline size_t ad4062_sizeof_storagebits(struct ad4062_state *st) +static inline int ad4062_sizeof_storagebits(struct ad4062_state *st) { const struct iio_scan_type *scan_type =3D iio_get_current_scan_type(st->indio_dev, st->chip->channels); =20 + if (IS_ERR(scan_type)) + return PTR_ERR(scan_type); + return BITS_TO_BYTES(scan_type->storagebits); } =20 @@ -1233,7 +1236,12 @@ static int pm_ad4062_triggered_buffer_postenable(str= uct ad4062_state *st) if (ret) return ret; =20 - st->conv_sizeof =3D ad4062_sizeof_storagebits(st); + ret =3D ad4062_sizeof_storagebits(st); + if (ret < 0) + return ret; + + st->conv_sizeof =3D ret; + st->conv_addr =3D ad4062_get_conv_addr(st, st->conv_sizeof); /* CONV_READ requires read to trigger first sample. */ struct i3c_xfer xfer_sample[2] =3D { --=20 2.53.0