From nobody Fri Apr 3 00:00:20 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A35C1B4257 for ; Sat, 14 Feb 2026 21:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771103831; cv=none; b=A8kKUajpnzqzBCMdMf7eLR97y+lgzdmZVwC4VSqh1y9xM5S+FrNLyKRhnRQYihOKzR3nVHEJhSiRe+FXYRj2z4iZI3MQZE1f+lyohtuEep56+so+zWuvmhjavV+0/8Xp+EkKE+cETVJBKM0IlwmG5drznjlRO5NHPNSo2INDmBY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771103831; c=relaxed/simple; bh=rR7UOXuskvM2eh7DaNLWZK2oGGwiqf0qUS4zowk/jVM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bhwfJuby0HN2QNuNQvoS9iuR41/rqR7Cyf7SpBuswZ/G6SAQGOfHYWs464/Z2YrrSxhS15jQAgfG4XkeQ1f4d9D2oER6ULO0V+INDvqw2CD0+KWdM3Y1vA6nvE//Nh5srb/b0oftVAtAPTlnB52vtfR8Yn/02iNCEkFMGS6ARas= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=POuESY1V; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Qu8T6w5t; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="POuESY1V"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Qu8T6w5t" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61EFAO9N2595536 for ; Sat, 14 Feb 2026 21:17:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= a6sEwMUAcPV8okvfCQy4lq+fUCd6uTma93Xlp51+1dI=; b=POuESY1VkCgC29rm sfywsl7kZMjF8E64xkr7LuM0hPsdUhN3fsjpKfhbEk6D4BZP3kemAMBkUsU8w/lg LzyrvWLlLLH84Hiu/drJ1FojQbDCSQoUzRZ9hif8pVl8gkB4pFBsHY0ycJdL0MFY f/PfikQooGRuMydbfUZydyDHS9MM1SG9YAmt2dm4KNAJXkCAEgnimAifk+QKwSH/ uelPCWH1JNQQNiA3V6SoIpFuGpFW8MU2gF3QAFiZdjLF0mltVPPEhSXwV1rd01P5 qqv6/Ntx/PDS7Y/21e8AJtkFnNejA0YcDWy80e+I15TdmT2VAyMWod9bdmFPgbUB AX5n1g== Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4caerc1mrm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 14 Feb 2026 21:17:09 +0000 (GMT) Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-7d4c1b2651fso7498634a34.3 for ; Sat, 14 Feb 2026 13:17:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771103828; x=1771708628; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=a6sEwMUAcPV8okvfCQy4lq+fUCd6uTma93Xlp51+1dI=; b=Qu8T6w5tB6nLt27h4bPK5hWu4xYfpda0efeQNy+Koump/WL1RNASK0qakdT8wxtMRw eBGyHMST/nRq5tGyCxkJTER9eRPxcoK0ACo22knexhPbDNxQe3ghcMTyg8+KKmlzj5gt Uwi6vaJcLl0jJxlpykxsKz9nDWmTpBqG91Mk/dO8LyvhdG0Tlt8Ry9aq7nOy/z/Zn7aG rc81BA7W4S+xZMaA5EJVsxBtvu/AnqD71o3Pu5rWb8CrEGomZaQD2S4Qtub4aKaWyifs 4dOYsIWu+fv+wdFU3UWcxxUSf+4hntkqBGA/S/xJ1ZSedkszBfHyq55oCG+ZcigfH2A1 Mdhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771103828; x=1771708628; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=a6sEwMUAcPV8okvfCQy4lq+fUCd6uTma93Xlp51+1dI=; b=AWY1BtkI4/kUgECWtrWHT63As6FnJxYN9MGRfPQC0gqijcD0yRCTopSt7ncHGhEpw+ T9CyQBSaTUX8JpVUIGIfavOto2Nc9FWW9jz55wZVls6CdXrJz/gA1a/iSmOw/HhtGXQC NjMxpKnJiUDiSIn0etvbCF2oQYEjslWj+uqXv/g4ocxsvBIv1VrW363oKC597jIuLtRn 24KIYSbnGITLUA2446qUJU5be3Q5fuo6gZ3ej5hLz7y5kv05t4J2Ev6+qicDK144paE6 F5trUPim9Tdh2rQC6AOfVQ0FX5AZ0Bx7N9GuskajPuTk9kBSpZrZMeZU2fCR8Ew1FUwE i+Cw== X-Forwarded-Encrypted: i=1; AJvYcCUEjEaAdmT/P/UFY6NH0zEwNF5Pkl1n7RlzHYiN6a24lCf9SZB24JTKlYB95XZnDGFStToZ4FJnf8XejjQ=@vger.kernel.org X-Gm-Message-State: AOJu0YygKk9U/sJ/EIQ4E5CNxwgIQGfukTLG4lR91vqnK/GM6lWDqO+W NnSpFcVgN5E30rpwVYlERLNcPkK8tQ+xpGjfE3/bQIal7WMA58DprXUB/k3rdSVyL5ePGf8YkH2 9fucuX2rrqeNPhE5syvLhZ/R18P7AKkdCwATqMxsuQvF8KFxxuc69Lm830tQRLSEkpFE= X-Gm-Gg: AZuq6aIuzzje8RcoLwwnUXWolkRWi4rFtgtgLQvtRRlKZmtZnn1f1q5KaEG3x9hwbfi aIl+6Z0bJGoibhACv/stwU/7OBMmBbVQQcYV48RQ4bX8F+nzbZHJ6svPO7/5Zl3gHuQI2xpmGzA T5kRHhj42p/vJ1+t2IOFcxuOU0ddRFHI43lsJjhXes4PFN/aqv/X51FFW7n7BqzA3BtMlU2iMwQ VBOx3YDtp9AXMd46xCcydeaUicQy2Hc3xYqh56g27S0SWgkyzzhlsMHb+7QULO4v4ySl47hdaRP 7L5XFNtZnLUfftWLkmxQKdc/SDycmsxqNgq8Nmwml+0FJVSMgX3SpFEqfe1LU10mDeCsYflk+gl mlXKQ9vPsjiYspdbVYf1NlsisPwISrXO3peNaqspX8lP6LquA9LNnqykLHiucAYP/UwKum8SmnR loYOIzlTbaibhJTqYJozer X-Received: by 2002:a05:6830:7316:b0:7cf:cb09:b7e8 with SMTP id 46e09a7af769-7d4d0c799b7mr1865472a34.36.1771103828520; Sat, 14 Feb 2026 13:17:08 -0800 (PST) X-Received: by 2002:a05:6830:7316:b0:7cf:cb09:b7e8 with SMTP id 46e09a7af769-7d4d0c799b7mr1865463a34.36.1771103828043; Sat, 14 Feb 2026 13:17:08 -0800 (PST) Received: from [192.168.86.59] (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d4b9f04181sm5913130a34.5.2026.02.14.13.17.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Feb 2026 13:17:07 -0800 (PST) From: Bjorn Andersson Date: Sat, 14 Feb 2026 15:16:55 -0600 Subject: [PATCH 1/2] soc: qcom: qmi: Fix "invalid data length" in encoder Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260214-qmi-encode-invalid-length-v1-1-780cb4e98b0f@oss.qualcomm.com> References: <20260214-qmi-encode-invalid-length-v1-0-780cb4e98b0f@oss.qualcomm.com> In-Reply-To: <20260214-qmi-encode-invalid-length-v1-0-780cb4e98b0f@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Alexander Wilhelm , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3316; i=bjorn.andersson@oss.qualcomm.com; h=from:subject:message-id; bh=rR7UOXuskvM2eh7DaNLWZK2oGGwiqf0qUS4zowk/jVM=; b=owEBgwJ8/ZANAwAKAQsfOT8Nma3FAcsmYgBpkOZSg3Nja1vsNjNboG/+VRKxXqvv3IolYcAcS vi7E6E+k32JAkkEAAEKADMWIQQF3gPMXzXqTwlm1SULHzk/DZmtxQUCaZDmUhUcYW5kZXJzc29u QGtlcm5lbC5vcmcACgkQCx85Pw2ZrcWSXxAAyKaM/47AhyTIFa2HYrJ2DNmlZ55B1hsB3qwic7f rdNPE8ViXJPgluoL1JzVY6ncaTGgCnLx9CrGgUBZPmLSLrY/5DrJyIjuZe1nXpvh/5xVun5CxXs DDivQNPpQiqbIQsX9x5nv/vB4nh+fV+ZC9pvkDGUxJoLVtcdFxdKfleGPux+31sSYonUUUAzWqs qM5yHKid1eNMj9pzQsNe0OvQ56hYeWMJXrGfOyxuTtJabCiQHqbyNwmTkxhrSbJOTFUewirxJRq qd2kwXpZYEOF1YxhOQfPvCoDVBAtLwMtnME867KS+aFfWcmjt1shFgerTrH00uMGtJfn9hoBPkZ Lehy92iPJV8DdXcQMhKiTwAlDWy3uK1cRJNe6RvRcA1oDaVFD9ByR6p0NsM3JgtHLsgK7w2KBlW oYbWq3LwNNEauEmDXyf0NuZi4kpiIRz+oJmJgPLXaH+7FO78GJyfmiWb9nBhAljQfl6VGZxr9KG hqF1UoX+bDJEzCCndIZ0CIrTd1ih1LnuDf1FD89y1VzZTl5dJJDXaRfSusTKfJZhasmgvRhKBtM MxwWM1lWv4gou3U93AUZ7OobFjf6+7cR07ooPwHleS3VU+psA6ieK4F/CF4hQvUMD+VhHVjXf4L jPZS//cUm8CbrW7xJFmugbgOpQW/Wvrsx6Vq6OB6S1uI= X-Developer-Key: i=bjorn.andersson@oss.qualcomm.com; a=openpgp; fpr=05DE03CC5F35EA4F0966D5250B1F393F0D99ADC5 X-Authority-Analysis: v=2.4 cv=ZJraWH7b c=1 sm=1 tr=0 ts=6990e655 cx=c_pps a=+3WqYijBVYhDct2f5Fivkw==:117 a=DaeiM5VmU20ml6RIjrOvYw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=OgaCUeAxioZO__sieaIA:9 a=QEXdDO2ut3YA:10 a=eYe2g0i6gJ5uXG_o6N4q:22 X-Proofpoint-ORIG-GUID: tEa-jtp_KSlMF4-QsT4rC9jMkduw8Yb0 X-Proofpoint-GUID: tEa-jtp_KSlMF4-QsT4rC9jMkduw8Yb0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE0MDE3OCBTYWx0ZWRfX5M/3XBbGLv7F Fn3fKJXmAY59rpD61i9JVWnbYL+e3q1Ic4yvjW9/1Sa7OLgph/pnj9NFtH9KlZEdxjWNNbqq+0x 3Rz3cef76WGZ7a1HfPvEEsBFjG3TAXe4+QHJtQ9tjZl4yBTJbeEMwC5G43jZZvCbleikvej9+/U ax3KKiWdCJPJxz7QyQ3Sj5REIf93Oa5bjoSuK721t/yLlBO9itZs2wxbT7t7ytYkPXPlCt6egs8 9yYWcCdnJed3wEPG+PbeSFC4KCbx02iFTvj2NpW3c/hS3+aS8vsGnpyxvzZKCm4flkybSCnT0F4 oK8NSADW9hPeDUPld5fnpaxsdWfDbsBS80pLNHX4mufqnpAnEi568On2F7tkW3+Hct3p7eo/rkp ZKPLMA8wHRbM+ftnQx2LWoOa0fOF6lkfNJ37p+TrNvBYtWkaAR670BbVkcpdLN44pby+MdvvueA yZqYg3LfpcS7iUkqLBg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-14_03,2026-02-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 bulkscore=0 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602140178 When encoding QMI messages, the "source buffer" is a C-struct in the host memory, so while the data that goes into the outgoing buffer should be converted to little endian, the length should not be. Commit 'fe099c387e06 ("soc: qcom: preserve CPU endianness for QMI_DATA_LEN")' fixed this, but did it by copying a whole word from the source into a local u32 and then operated on that. If the length in the DATA_LEN refers to either a char or short array, it's reasonable to expect that the struct is packed such that this word will contain not only the length-byte (or length-short), but also the beginning of the payload. As the encoder loops around to encode the payload it runs into an unreasonable value of "data_len_value" and bails, with the error message "qmi_encode: Invalid data length". Rather then complicating the logic with local variables of different types we can instead pick the u8 or u16 "data_len_value" directly from "buf_src". As "buf_src" refers to a typical C-structure in the client drivers, we expect this field to be naturally aligned. We can then return to the original expression of qmi_encode_basic_elem() encoding directly from "src_buf" to "dst_buf", with the endianness conversion, based on the size of the type. Reported-by: David Heidelberg Closes: https://lore.kernel.org/all/dfb72933-938f-43f2-87f3-2e3ab9697125@ix= it.cz/ Fixes: fe099c387e06 ("soc: qcom: preserve CPU endianness for QMI_DATA_LEN") Signed-off-by: Bjorn Andersson --- drivers/soc/qcom/qmi_encdec.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/soc/qcom/qmi_encdec.c b/drivers/soc/qcom/qmi_encdec.c index 28ce6f130b6ac355820bb295c8c96f9c6a6e385f..45bb26d010da77ab8d481897026= b718c2290bad7 100644 --- a/drivers/soc/qcom/qmi_encdec.c +++ b/drivers/soc/qcom/qmi_encdec.c @@ -368,8 +368,6 @@ static int qmi_encode(const struct qmi_elem_info *ei_ar= ray, void *out_buf, const void *buf_src; int encode_tlv =3D 0; int rc; - u8 val8; - u16 val16; =20 if (!ei_array) return 0; @@ -406,7 +404,6 @@ static int qmi_encode(const struct qmi_elem_info *ei_ar= ray, void *out_buf, break; =20 case QMI_DATA_LEN: - memcpy(&data_len_value, buf_src, sizeof(u32)); data_len_sz =3D temp_ei->elem_size =3D=3D sizeof(u8) ? sizeof(u8) : sizeof(u16); /* Check to avoid out of range buffer access */ @@ -416,19 +413,16 @@ static int qmi_encode(const struct qmi_elem_info *ei_= array, void *out_buf, __func__); return -ETOOSMALL; } - if (data_len_sz =3D=3D sizeof(u8)) { - val8 =3D data_len_value; - rc =3D qmi_encode_basic_elem(buf_dst, &val8, - 1, data_len_sz); - if (rc < 0) - return rc; - } else { - val16 =3D data_len_value; - rc =3D qmi_encode_basic_elem(buf_dst, &val16, - 1, data_len_sz); - if (rc < 0) - return rc; - } + + if (data_len_sz =3D=3D sizeof(u8)) + data_len_value =3D *(u8 *)buf_src; + else + data_len_value =3D *(u16 *)buf_src; + + rc =3D qmi_encode_basic_elem(buf_dst, buf_src, 1, data_len_sz); + if (rc < 0) + return rc; + UPDATE_ENCODE_VARIABLES(temp_ei, buf_dst, encoded_bytes, tlv_len, encode_tlv, rc); --=20 2.51.0 From nobody Fri Apr 3 00:00:20 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E73F1FE45A for ; Sat, 14 Feb 2026 21:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771103831; cv=none; b=YqPlQRiUMmk+fbSMiouvcz1LeVNOBUFy222KYxFv8MVNpTxOr/q0WZuUoMTbrRHyEGhh+3bpylhHcShYeLdBbq0XlyElwEgAnuRDnPVhB7qCJ9aeJHWDzsFFMt8aIKm5jVz0JJqqNFEOVJYTCxnGW9ZKuyBtN04YGi6oBMlr13U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771103831; c=relaxed/simple; bh=RN+aHlYWeP7SS3/oVVlw9OOZL5W4/w1S8wzjWy8RLxE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=m+CnBprfFHzynWwwL8q6cfkzmehyE9zYqJy0BjWK32B3ZUqO4xfX9zYuiaCvUdIx3H0C8T+5vOAWxkjk4h0YE5rzgl4NBh5MJq6JOIMCvMOHyOImvpJXcu0t4qRfK0hv0sl+wZF0042btm9BLGPQ2OH/UIc+aZ0uxz0gFHyVlxA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dzlUOKC0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SEv3iWNj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dzlUOKC0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SEv3iWNj" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61EFAZ583385430 for ; Sat, 14 Feb 2026 21:17:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XQdos+TAnRmSkCdr5GnlxvkkXRXMSBu+4jEUKE35sLU=; b=dzlUOKC0IkOaH+mY S+Y3ay6kn5pvtvy72inwC7T2zQcVWuKVp1DBOdigXtxVq1Y3xEOW8IL4cqiMXzNX 62ugzhHbODCulpAFtYabbTNiAta+P5rIZ0F8glZD6CpgwD/LmbuMvdks5SOMZiSv CT5NHYg3fBgKh6PP9aGB1QupSXWUKMJ+NqmYFIirYqDPf0PK8fjh3VZEFas5fn1E VWe/DQm/FAHLdkGUlWRC5FDNOqeUoKzZliAlk9fdpz8wNvD5p1dKIjiFSSHorjX7 oGpvwnaslBrirO3KU6sTtWcprSadoBa+bdMQCBe7WnhK2U+wXIAJon7LF2hrS/gc Q47g/Q== Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cahtch9r4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 14 Feb 2026 21:17:09 +0000 (GMT) Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-7d1902109a9so13452775a34.2 for ; Sat, 14 Feb 2026 13:17:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771103829; x=1771708629; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XQdos+TAnRmSkCdr5GnlxvkkXRXMSBu+4jEUKE35sLU=; b=SEv3iWNjeyU6cLf1r7niXCZdFIHUfFPkz2RS8zSJBc7lzJPXvfMaZLwq1vbh86uKyc ipcEOPDKAD5ChYIP891gQi8LF1MU7OX7MPi135obBEdMmDcrVxMjrIFdVmI+3wuLCw5w nkmwNFkUSoZApu+x2jYF7BQW80C2bpifQrc7PgxYngeDjlAitv+YDGtTJZPFUNMBmegg KYIMtxGlaiz/NzAbSdEMPMmQ5rRtbxBotEKbPVBp5K0gXOn7MLadNURt2EcFdFYkzqrO 585NOJOU8NH55Q36iAzj/hKcpPXyr6ABmrGrH2nr+tUnueWLyq1ACUhfk2tnUReqEEbH ZTYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771103829; x=1771708629; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=XQdos+TAnRmSkCdr5GnlxvkkXRXMSBu+4jEUKE35sLU=; b=aGLgu5VOLpz3+XOrrKPa3rFlRQI+RtLQb71OsfxfKaPzaKF1DLhKJjsCstIUFy9GYF khPxp+vwvg+eCBpnA4EdJ7rh1VClx9Tm+v8GZYU5vIUO/2BLbpaK8kNyUmLpbn4EniHf /2NSwu+pPiG1HQFPU9TPW896rvpelyZ00rSHhJXwLWRmyQlSMk6sJY4NnLmEK1k5LFJi +lDhNaV/eKmobfBFpJFGe7nO6zRE+GwPFLLO7MyD09HCKbFxylJ+SOmWjnY/Sj4lKH9x NSqhha4WhywaB1i0QIxkyekjrE/PMWkXl5cIAND8gYfXvRTywDORyV2eLxEBHFf90HZa IrNQ== X-Forwarded-Encrypted: i=1; AJvYcCWXcxl9wcyc7d5RClcOPNfeGQAy8T04ES2N39RTc49j8rgFg0LAqKCZLt5SDNAaofDKOZsJEsq/n/HOVcE=@vger.kernel.org X-Gm-Message-State: AOJu0YxSlo9o3gVBxoycKmo+WZXL81gRH/Ga8tjQWvqJadNoCKLmnRM4 ZI6e77Y8g9ZfGhIqSnJPJnhbqAFIl34zycpUwQ0tmvejdd3sLs2alRnZ0bafaT3QPEh9dNUF/ZY RFkhAmaooV9hwn3zA5nI2Yt5Xdu4LP/4FBxOgQ7/PZb9W4bUle1WPuPlEOYFp/RSQN/clBmYecS Y= X-Gm-Gg: AZuq6aJSmrhRVESZoHlpE5NNta32bMzVuXf2bosbRawzTia/zMkDuvc0V6i7NZBgwq/ TMPSRx8geXvZ75cEU3mubeI+95VVTFEB6iN3hHaxYXHIrSGhecAklMpFJ8pcM4Np1dcACkKHdPq RFF3p88QkK/Lz/7tEaQ+c9TRiVMNuNbb/eZZXNbGJ2aDH7Y+GD7tSjuaDBghB0BpmC8xAl/Mz2h cg7e0sU3127XgAXv2TCYN78vnn0ccEo8nkO2JjXvjHC41r09TaK2/3qvm4w0+ootLuHryTHQkp8 fDHyDMBSxfPB70OKroSC/zHKb1cu14kIJWTJsFgvpG9x+/g6gcemJ6Bv/diYJ47dhRvgyiKpCTJ qV2EsqpTKdLPA5gLvVN/Zqf1NwPqLJBnKxXymwSUAVx0FpGlzZH45W2VCBBxAP/LZC7iice302r qMsx1er+P7RWFXhUJhWvHy X-Received: by 2002:a05:6830:2708:b0:7af:1d61:1055 with SMTP id 46e09a7af769-7d4c4ade32emr3270981a34.21.1771103829020; Sat, 14 Feb 2026 13:17:09 -0800 (PST) X-Received: by 2002:a05:6830:2708:b0:7af:1d61:1055 with SMTP id 46e09a7af769-7d4c4ade32emr3270969a34.21.1771103828650; Sat, 14 Feb 2026 13:17:08 -0800 (PST) Received: from [192.168.86.59] (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d4b9f04181sm5913130a34.5.2026.02.14.13.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Feb 2026 13:17:08 -0800 (PST) From: Bjorn Andersson Date: Sat, 14 Feb 2026 15:16:56 -0600 Subject: [PATCH 2/2] soc: qcom: qmi: Avoid splatting the "length" destination field Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260214-qmi-encode-invalid-length-v1-2-780cb4e98b0f@oss.qualcomm.com> References: <20260214-qmi-encode-invalid-length-v1-0-780cb4e98b0f@oss.qualcomm.com> In-Reply-To: <20260214-qmi-encode-invalid-length-v1-0-780cb4e98b0f@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Alexander Wilhelm , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2693; i=bjorn.andersson@oss.qualcomm.com; h=from:subject:message-id; bh=RN+aHlYWeP7SS3/oVVlw9OOZL5W4/w1S8wzjWy8RLxE=; b=owEBgwJ8/ZANAwAKAQsfOT8Nma3FAcsmYgBpkOZSJVQoFbe6FI9cqT5sDIILdWioSppBAd2Q7 c0jvv6jyT6JAkkEAAEKADMWIQQF3gPMXzXqTwlm1SULHzk/DZmtxQUCaZDmUhUcYW5kZXJzc29u QGtlcm5lbC5vcmcACgkQCx85Pw2ZrcUOcBAAkDJUc2Y5MHrRXH8LtjoC6ojSUpIgfXUGvEbEmkP DcGwxOY0lhVj93PrKr6DX4FL6Wmb10iwBmbaL4HbPCLfBxysfkx9MqJvIydrERXuexoL19GxydZ fDXihWK5Ypauqh4nKhWRTVxKoU+Qji/88jPMw+suuYbsaYasDcnkQwHvuMfnlscOANx99PNuyF1 AW8Jc4aKa/KAgDseZWHryLGHH1Xpqj0SR1cjQEznKiIERK/6cFAtwibyDRv/daXxlP+Gz5I873a tLroGBF5A44JWSRKnyvkjMcczqWzabZ8/PHKnDQU/g61xFZHUufC1Ato4Vmq05RKbDRGWOoYQu7 whVEguqd/TL7jIZetJp645CynCG06suINWfV48u5xsag3HvMFOThvJBx278QzA8sKR58jwiwJEO laQSXJbtNz2YxolKf92EC8ZVO5heAhU+HQBbHEFjcSvNhrN2PzAmFTlV6yg2/CM4eCH412L9vyB QH5j75kGMIpNgJfjOyKL4pqJbtF6iUeXpD/l5294E5j6C3O30EB3ar+x0xepXKAnL1WlYjAkN5I 8N6AADcO2T0OLQI8D2Xk9QFJE7/tiBByv5Rm8AfSi65IlRJPO25c/GMJNsTNLTjtgSxve/OkjC6 1AyQtN5UxyXoPOUNJxGnEevN8kVXxHRQ7UA/E9WXl7/k= X-Developer-Key: i=bjorn.andersson@oss.qualcomm.com; a=openpgp; fpr=05DE03CC5F35EA4F0966D5250B1F393F0D99ADC5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE0MDE3OCBTYWx0ZWRfX9uu+dEUnyKPb 4KWp1ahwVlYnh5t1+Fxhn7AvuIsAnNFVEAHqlgW5NtYPfgUGPhd+KuoOirsCzV/OFRgf1nTxXYy JybXEDVwF1lpCIkjefDRvUyQ4LrZMu6PL3/idiFcsh0wAODx13y/OrbeLISWEAFTiQVQC34y3Sx zKzS1ubSOfzhimSNILZXqaSTLwRT6q2URaOQfSzGMRsAnaieYkK5jb7q5t/eSpHKtDnO17fJxIS fTqF2a1Nd6M26F6wWuIAtmu8bKOsxMI/jkZ4WfxZcerodURsLQQrBPNF+QBm45zL6MTxSW6DIkr 2mDsxSj4xYj2NJd9MasdcJr1ucGtmb4ar89RYmboIEvU1RY0VhyITAeJ4B490ysXKH1/C++GtBJ hDFBNaOrVlH9oDU5BFfx3bE8y0BUI+pbM7DirgdnDoGvcP2ZbM/SDXYF+KMRJ5nDGIiky2VcLGj d/mYHiJ1ProYRlqRjVg== X-Proofpoint-ORIG-GUID: ZjDqd9hlSBbX8AseA1HUdVXjPbxxERbx X-Authority-Analysis: v=2.4 cv=DJOCIiNb c=1 sm=1 tr=0 ts=6990e655 cx=c_pps a=+3WqYijBVYhDct2f5Fivkw==:117 a=DaeiM5VmU20ml6RIjrOvYw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=PR-xUDRRZIJ0Fs8gPngA:9 a=QEXdDO2ut3YA:10 a=eYe2g0i6gJ5uXG_o6N4q:22 X-Proofpoint-GUID: ZjDqd9hlSBbX8AseA1HUdVXjPbxxERbx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-14_03,2026-02-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 adultscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602140178 When decoding a variable-length element from a QMI message the length is either a u8 or u16 field in the destination C-struct, but the current implementation prepares the value on the stack and then writes out a whole word. In a little endian system, this results in the following 2 or 3 bytes being zeroed out, and then presumably overwritten by the actual payload. So unless the length field is followed by an unreasonably short array, the splat is contained - but unnecessary. While not verified, in a big endian system, the length should end up beyond the length field, resulting in a 0-length value with "garbage" in the payload. Given the expectation that the QMI message is decoded into the naturally aligned byte or short-sized length, we can simply read the endian-correct length back from the destination buffer and use this for further processing. Fixes: fe099c387e06 ("soc: qcom: preserve CPU endianness for QMI_DATA_LEN") Signed-off-by: Bjorn Andersson --- drivers/soc/qcom/qmi_encdec.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/soc/qcom/qmi_encdec.c b/drivers/soc/qcom/qmi_encdec.c index 45bb26d010da77ab8d481897026b718c2290bad7..149af7f7c9833e1f3501f96c989= ce9bd58ccb8a0 100644 --- a/drivers/soc/qcom/qmi_encdec.c +++ b/drivers/soc/qcom/qmi_encdec.c @@ -712,8 +712,6 @@ static int qmi_decode(const struct qmi_elem_info *ei_ar= ray, void *out_c_struct, u32 decoded_bytes =3D 0; const void *buf_src =3D in_buf; int rc; - u8 val8; - u16 val16; =20 while (decoded_bytes < in_buf_len) { if (dec_level >=3D 2 && temp_ei->data_type =3D=3D QMI_EOTI) @@ -752,20 +750,16 @@ static int qmi_decode(const struct qmi_elem_info *ei_= array, void *out_c_struct, if (temp_ei->data_type =3D=3D QMI_DATA_LEN) { data_len_sz =3D temp_ei->elem_size =3D=3D sizeof(u8) ? sizeof(u8) : sizeof(u16); - if (data_len_sz =3D=3D sizeof(u8)) { - rc =3D qmi_decode_basic_elem(&val8, buf_src, - 1, data_len_sz); - if (rc < 0) - return rc; - data_len_value =3D (u32)val8; - } else { - rc =3D qmi_decode_basic_elem(&val16, buf_src, - 1, data_len_sz); - if (rc < 0) - return rc; - data_len_value =3D (u32)val16; - } - memcpy(buf_dst, &data_len_value, sizeof(u32)); + + rc =3D qmi_decode_basic_elem(buf_dst, buf_src, 1, data_len_sz); + if (rc < 0) + return rc; + + if (data_len_sz =3D=3D sizeof(u8)) + data_len_value =3D *(u8 *)buf_dst; + else + data_len_value =3D *(u16 *)buf_dst; + temp_ei =3D temp_ei + 1; buf_dst =3D out_c_struct + temp_ei->offset; tlv_len -=3D data_len_sz; --=20 2.51.0