From nobody Thu Apr 2 22:23:34 2026 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 312962701CF for ; Fri, 13 Feb 2026 19:51:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771012320; cv=none; b=WlbTng9aLJKWHxYIZq2DA2ZE5+g7ohiQ3ipbOZ7hpxajH79r+kqYuSyOzlvbiaYypxUKOTaZTRynKk+e/t0z/Nc0OoTP4G4cYJ+yuepo6dq1Ud2cj59StwlGNBMZ4tVnVlKt/UQ1+6752J5qiwDpbK6uvH61S9Mr7z51t9sOHdg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771012320; c=relaxed/simple; bh=hfSQQopjpYV5I3Yfr/pwBz4wcdwAxFlhpS2vh0kNcsE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CuH6ICkaveQa9/uKFDGqqmKOmbhFFxe/uKsNjIb3r4a09w1LY01VaYtR78hFVKyqgVaj7GJLJixqSBrrE0BwnYexsw6Qwayp7BVcPbb5MYip5xahPF4kADrxe243ks/5T4+2M9Ss08NR0uauZlQaicotjc5ihem2Cdhx87HtEEI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JDM7mAj2; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JDM7mAj2" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-79495b1aaa7so13925597b3.1 for ; Fri, 13 Feb 2026 11:51:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771012318; x=1771617118; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=U+3NM1chn06K9YCbGEYfn+AGcC25PLiw3IfcYFLF7ns=; b=JDM7mAj2Gr/NaJbAhOxJUm1OBWYdLIfP16NT/my3O/qAN3Fr7WYD9K6qX+TtUOte6Z YlS3dhi2MCKIknyHwbWP+IVKthjTVjAdCLCOeA9em29uEBcVEELCp1IqD4rMHiAZf1u4 iI3dFguAKBMN0DaanV3DuHqeZkkjvVE/ghoq0EPSMsVPTuLkByXCf6P7Z5KMa+NfhpTF /R1FaJv9MY64b69oDoGa7ikKT4Wx8MVmvMFt1GmAevy4i3M+NRZGh6bkmLiiY9Uw8Sp7 kQ0XvfNlRbU8rnlvk1b/vnm4IKPvBx8bXp2C9El244QH1rlZk+7wO9Rkf+o8sCdXL9Fo 1L2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771012318; x=1771617118; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U+3NM1chn06K9YCbGEYfn+AGcC25PLiw3IfcYFLF7ns=; b=pCX2uIyFtWojmGiu4hv0XZlGhgxW0dDcZ4WXF7IToEXm363nKvFk/CmI7kyE8GYJQ3 ehU7++stQyOYwBoe/hBttOW4/YhaC7fewskxCsdKxxrVXYXxkrKmK0Z+DLHXlILhpF1x 7AiIiNaGxwBY2vATlkDQ9i4eaa7KajjaJ+wmrEXmFBWxfMpFwgAuOzZ5OBD4iYrHq/iM MGx4g/S2RVXle/is38DWVVbTFG+eWB+cMjejJ3WSK5iunX3Ql4yvOtdj5xoDTBqzqhpy 2su/ZHGjyoBMEncttvynUV/GUkKcTKNJKGOzyI6nDFBnlwtLsgLIyZEdtW+3bDUxqHAt ZjpQ== X-Forwarded-Encrypted: i=1; AJvYcCX+2lfDVm0TAKvB1Nw//9Fbfsyzt9rdZ68YMTgdFQjHCdz9a1BO9gUp++A1P17ZZKKiyUKF0MIr9nsfBPQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwCS4hoDR6S7lNXnLfcl+iYJQ11N4y4BcjRNUoHSavsAv88dcKG PnBwAcC4D2RQRPGqv7CZ8KIeOtdtgMlb53d3a/DJ44spPSusYosk2bSw X-Gm-Gg: AZuq6aJ4gPVomRmIB6C7WndNlRxW7ZActN5rhqmQfVJKGfp0oQS0pZiJm/MDtwpHFmu Ganh+Tj337ocegUZZOkISb0iShlDmYxlmr+DjI83mAgP6rR9rN6A26SngD8mblfh9s0rLVpP19n Xfxr+F6eypXh5IptI8jW0U0zvQ9pEEVFtMYj9VoRFVf5r0y29cEC0gjBfDamzLNjlZ7emqK8fTT jXxKLuXen1Vs2Ph1AtbcKNB/qU7PcB7EgJkGdDx0bKPv/qBRxMTnmsrdWEX6YshgRNb6buVuaP+ OVAjdmtURbUrokbu6FDDYDYrlbwCSn9oHSrjNR7DLlZSPBmC3yje3RqKgEatPaKqpdIk7ykV78D TDt6vZNRaQ01oiObq6csxqAcKaGjiitVFGGlgf9XxXgL1D09ISgNfFWMUpia41tL6ceSPU4DBx1 0Z6JiuW1t296/45bMaJi+5lJyDsmiEVYaRXkFpo5uSrIdnY+OaVYvF4pm+V3zGGSxUUDaYlumx2 sj0DE878KMxA6e+I4GLoa+pC8vKCaCifWhYIabhXds= X-Received: by 2002:a05:690c:6c8e:b0:796:4f04:bbe5 with SMTP id 00721157ae682-7979e8cd65amr27744657b3.47.1771012318168; Fri, 13 Feb 2026 11:51:58 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c195dccsm74210287b3.21.2026.02.13.11.51.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 11:51:57 -0800 (PST) From: Ethan Tidmore To: Jonathan Cameron , Jonathan Santos Cc: Michael Hennerich , Lars-Peter Clausen , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore , kernel test robot , Dan Carpenter Subject: [PATCH v2] iio: adc: ad7768-1: Fix ERR_PTR dereference in ad7768_fill_scale_tbl Date: Fri, 13 Feb 2026 13:51:41 -0600 Message-ID: <20260213195141.22256-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function iio_get_current_scan_type() can return aan error pointer, the return value scan_type is not checked for this and immediately dereferenced which can cause a kernel panic. Add check for IS_ERR() and propagate the error back. Fixes: ff085189cb17 ("iio: adc: ad7768-1: add support for ADAQ776x-1 ADC Fa= mily") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202602051234.5gArzLyZ-lkp@intel.com/ Signed-off-by: Ethan Tidmore --- drivers/iio/adc/ad7768-1.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c index fcd8aea7152e..e16dede687d3 100644 --- a/drivers/iio/adc/ad7768-1.c +++ b/drivers/iio/adc/ad7768-1.c @@ -531,7 +531,7 @@ static int ad7768_reg_access(struct iio_dev *indio_dev, return ret; } =20 -static void ad7768_fill_scale_tbl(struct iio_dev *dev) +static int ad7768_fill_scale_tbl(struct iio_dev *dev) { struct ad7768_state *st =3D iio_priv(dev); const struct iio_scan_type *scan_type; @@ -541,6 +541,11 @@ static void ad7768_fill_scale_tbl(struct iio_dev *dev) u64 tmp2; =20 scan_type =3D iio_get_current_scan_type(dev, &dev->channels[0]); + if (IS_ERR(scan_type)) { + dev_err(&st->spi->dev, "Failed to get scan type.\n"); + return PTR_ERR(scan_type); + } + if (scan_type->sign =3D=3D 's') val2 =3D scan_type->realbits - 1; else @@ -565,6 +570,8 @@ static void ad7768_fill_scale_tbl(struct iio_dev *dev) st->scale_tbl[i][0] =3D tmp0; /* Integer part */ st->scale_tbl[i][1] =3D abs(tmp1); /* Fractional part */ } + + return 0; } =20 static int ad7768_set_sinc3_dec_rate(struct ad7768_state *st, @@ -669,7 +676,9 @@ static int ad7768_configure_dig_fil(struct iio_dev *dev, } =20 /* Update scale table: scale values vary according to the precision */ - ad7768_fill_scale_tbl(dev); + ret =3D ad7768_fill_scale_tbl(dev); + if (ret) + return ret; =20 ad7768_fill_samp_freq_tbl(st); =20 --=20 2.53.0