From nobody Thu Apr 2 22:29:01 2026 Received: from mail-dy1-f201.google.com (mail-dy1-f201.google.com [74.125.82.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22CB6279334 for ; Fri, 13 Feb 2026 19:22:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771010549; cv=none; b=m48HIECNn77eYb9dyekhoni1HI6MWzu/EX8Z8KzanXbYCK0NlD937+A2mGFaKmkKOjYLD5wyCMQoly2Zt2Bg2a39gbHiqXu+t6gLy9b+7AJGsbi5uSFLBtlQE0In00u3R8s7N57bN1daEP9YvFEvuwdrw/V8U7mVC/GxEvbfEDw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771010549; c=relaxed/simple; bh=lRAN5b2s8qIPY0Klj1P6SKq3/Ipitbr21jiXQae+3nw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=W9etD5214VUktGaBEEhwQd8wrxzAiM0FC5lyyKccxff6bJzXt/OW8+MEcirEa5He5RYqwMW6FxB281cOUyrv5hdq26Kw77rDNMp0Wyjxtld0FR5AWgL+IMtNsN6PI18aKhzgGQSoKmWZrln4YhHqeg4TeD2dkO+a78lBYTcrTzk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--salomondush.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=2uK2D5U0; arc=none smtp.client-ip=74.125.82.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--salomondush.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="2uK2D5U0" Received: by mail-dy1-f201.google.com with SMTP id 5a478bee46e88-2ba68ed568bso815138eec.1 for ; Fri, 13 Feb 2026 11:22:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771010546; x=1771615346; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=E+HQuoE8UnGrCMiVyAiZ9ndoG4yhkaEaK1xHNudOJZk=; b=2uK2D5U0gL/2yFHTyu4fYu41/rduFxzcvOeeDFhfXhJZnc+4EUTrdOXwWa3M1J9B3f PhRmtF1gUQbPYxLFGiTozhNy+2QYWueBhWLpcylq2v2wjbr5Ni2bshyhoVyRCM751b3U UMHOiNkgINivBc/ukq8LOf+88rv8lyEibDWBCij3eAIFuiffqZXx20y29UU8LbW5NY0I 7qatuBYtn9twIDqcgbrwNvy4cYx86flBcEcz5bsuCNDVEVjm2UgTVBUUDAWJhAfWCple 7E9qNWBB2gVZ+d/j6uC6TCDQnHDSXAqTslMfl4mLkrUFztm1EpYf9KrGnKXUnUy2ruAB Dyhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771010546; x=1771615346; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E+HQuoE8UnGrCMiVyAiZ9ndoG4yhkaEaK1xHNudOJZk=; b=n43kX/fKatvhd7l2ANaDALXz5NZ1ehgRwhFZ4FMSzuZ59uP5witAFSkyPLyxA8bDA9 O6x/qrxQj0fPW7QK9MOtdqQiH8a2KUmae8YlNTw3CcOSTZh8cCqxGnRelugQxD3FO6EN Sw1O8S0t1BcmLfeac3ZfkLpXBFbNDp0U+P7uKhesd/M74wrkrqxC0VEK02o89ttINSEn L4ZvkHK0FDO2+g+5+Y9cc3YpZyvzvI5Pfd2F/lER/JoByImdzKFuGWpcqVv0rrJ6Hy+O WE6bPUJuQ5fe9EMRAtk2/kEmjaWQGTRO3vjfvGCyaXmTQQd1ajhdkL2ibzoHjAfFzPsf ol9Q== X-Forwarded-Encrypted: i=1; AJvYcCVqrLP0qLJkVZk3P6dkx9xwlsNMM9yqPUX+mu2zwhgL6iNBsdoR9tC2bXMqeKIah5L1APupjjaWL7RzSfg=@vger.kernel.org X-Gm-Message-State: AOJu0YwYtLpMuvw/fxKiYNU2PdliPQl2lVixB4oVHBUOXibJTzqWPtn/ 1t7Qs+iFyehzXTU97xao5tZsagvORyD4K8YN2Z+1YLn2e+HgX1Am4tjbBNJF9PJB1ZdrAMbQNLI IqVKh+dQpS7hNBYue/czBxT6l6Q== X-Received: from dybfe28.prod.google.com ([2002:a05:7300:bf9c:b0:2ba:88ba:e0f5]) (user=salomondush job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:ca1:b0:2b8:3b47:8951 with SMTP id 5a478bee46e88-2bac71d4b02mr507084eec.1.1771010545892; Fri, 13 Feb 2026 11:22:25 -0800 (PST) Date: Fri, 13 Feb 2026 19:22:14 +0000 In-Reply-To: <05c3fac5-b604-496b-b0eb-5b2dbd68e66c@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <05c3fac5-b604-496b-b0eb-5b2dbd68e66c@kernel.org> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog Message-ID: <20260213192214.437871-1-salomondush@google.com> Subject: [PATCH v2] scsi: pm8001: Fix use-after-free in pm8001_queue_command() From: Salomon Dushimirimana To: dlemoal@kernel.org Cc: James.Bottomley@HansenPartnership.com, damien.lemoal@opensource.wdc.com, jinpu.wang@cloud.ionos.com, john.g.garry@oracle.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, salomondush@google.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit e29c47fe8946 ("scsi: pm8001: Simplify pm8001_task_exec()") refactors pm8001_queue_command(), however it introduces a potential cause of a double free scenario when it changes the function to return -ENODEV in case of phy down/device gone state. In this path, pm8001_queue_command updates task status and calls task_done to indicate to upper layer that the task has been handled. However, this also frees the underlying sas task. A -ENODEV is then returned to the caller. When libsas sas_ata_qc_issue receives this error value, it assumes the task wasn't handled/queued by LLDD and proceeds to clean up and free the task again, resulting in a double free. Since pm8001_queue_command handles the sas task in this case, it should return 0 to the caller indicating that the task has been handled. Fixes: e29c47fe8946 ("scsi: pm8001: Simplify pm8001_task_exec()") Signed-off-by: Salomon Dushimirimana --- drivers/scsi/pm8001/pm8001_sas.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_= sas.c index 6a8d35aea93a..645524f3fe2d 100644 --- a/drivers/scsi/pm8001/pm8001_sas.c +++ b/drivers/scsi/pm8001/pm8001_sas.c @@ -525,8 +525,9 @@ int pm8001_queue_command(struct sas_task *task, gfp_t g= fp_flags) } else { task->task_done(task); } - rc =3D -ENODEV; - goto err_out; + spin_unlock_irqrestore(&pm8001_ha->lock, flags); + pm8001_dbg(pm8001_ha, IO, "pm8001_task_exec device gone\n"); + return 0; } =20 ccb =3D pm8001_ccb_alloc(pm8001_ha, pm8001_dev, task); --=20 2.53.0.273.g2a3d683680-goog