From nobody Thu Apr 2 22:07:13 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCBDD31986F for ; Fri, 13 Feb 2026 11:53:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770983597; cv=none; b=qy04FAUOJ4Qqc7idfSOvJJ4YVpFgGfcJ4CYKXdK/UViVg7Sf/8vpBvvrT2qYT4PxLNLSknwU28C2nYDyOQEu8uf+xQ243fAPyKOwsOLT9dLXX1r9sJBpVuRcssRyRUCtaTIaaHOsuBsdAJ2M7u51FtRrfhqbVJHX9n1vNtvw/7w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770983597; c=relaxed/simple; bh=2ZVTZcJEQvp9j4d2P5a9LlD36iiY34YfpFu/m0+lLq4=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ScI71bY/tZ5DLZxXf/uaTPozie3mtRVUs5a3yc6T1d3gb2+nKcD9I1vKTes68vorVq5XAvU0Gc1Fr/AbFXSBwVv1JIDtcY+bcxKNflgqkdVE1ME/J8M5QN8MIsIRiwk9AmFUneNsrEObEnShxKTeNG+2WkNF0KR+deSR4ykmdJA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CcWWn4/A; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=oxCjBsb+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CcWWn4/A"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="oxCjBsb+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770983595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WBIaDmc/b8KhOmbhsBz+ARqnHRu5Sb2xsdw5j1dfy9I=; b=CcWWn4/AKEy+rkBre1DCGdu8aDg0lYKWi6N775ArGMMrauvYHnJEpwe9+Z3G+/+dhgpoUp i3Y/knv1QvagOwATivBNC/idzF9Iysk++WGC10w7zRg1VUz6TlXX49a5ikPKL752Dd+vKy bBWHqMoGSnIG9DkZKpRFR/YUFb7xoh4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-201-xP94rPyAOdaACrcB7hR25Q-1; Fri, 13 Feb 2026 06:53:14 -0500 X-MC-Unique: xP94rPyAOdaACrcB7hR25Q-1 X-Mimecast-MFC-AGG-ID: xP94rPyAOdaACrcB7hR25Q_1770983593 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-47edf8ba319so10956195e9.2 for ; Fri, 13 Feb 2026 03:53:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770983592; x=1771588392; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=WBIaDmc/b8KhOmbhsBz+ARqnHRu5Sb2xsdw5j1dfy9I=; b=oxCjBsb+OtyvINW/HQaSx7kxMNeCW6P7OF20/KoSpRiqIrXBQaOl/vBSmSDpv7/321 UJSlgrrpUymLiqTEGIxBYYnAGuzYulM3ogkeB26Vpz8pS5NuETeXxA56Wo6JLH/OlQ7f 1PP24yMU9hoEI5QPQ+aWxw1aZeFzLbG+CH0hHjdZxIY2hggXeFl4ZY6pkPiTY/fgmVqM HTXYi804hdbktzwQE0RdqgfStV7EolMJRNrZ9E7An+M1y6d8WA/97/MyEvSkPgRnoLgF YCK8HHTDC5cKdyuVxCBvMUqKZKi3Q6XBdWf0th3Ojgihr7RKzotFouo+xpRdGpGgdUoY TVeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770983592; x=1771588392; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WBIaDmc/b8KhOmbhsBz+ARqnHRu5Sb2xsdw5j1dfy9I=; b=hYkPhpVb6iIbIHyDaygYcJHphVmECeMJEUMR0R1DZBP/wX2qkJBJz/bWMih4YmXSYy Ok3YRA3/zoxDeEsFRc+TWPl2ZfSVrIprR3x+rcS0rLYhUk8edOsXSkwGi1kgzd0t5fgs xOKncZ/SwNN9e+ToTQVpRsxEzKuQphuVFOoze3FUD1C3QwnMifYuEcAHBCVf9DGnB2xC LBzR0Z6oncgzc2azTJ40IlW2OXpn/9iQBie/DjoLiT7PGnkUXN7nkmDlTy9xSgrI/AhL gLmJ9xs1E+mcqyxVNfYNsufKp7hWwfEIHJL/DHpkMzEUlR80WydY+dFbH6Q3+1cZkflk QR3A== X-Forwarded-Encrypted: i=1; AJvYcCXcxgvFAeX0eFLX2s+6tnR12MusKstJpMnpB74RlO34SOWu71JnVnfhXuARfEg0BP76S8pw86AFRvOx+lI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9+OVq22bPoA5T4FBI4OqtLQtsWyMceflOLm4oX/MbLuA7g/eM P/BilJTo4B9nmCt/DZIoc3MJ2se0z/E+t+eygqunelnqMfaz8e62FcBrDaaxcmoObJQU3ELa64i bEjPbEdNbcv9Y/rSBcvctM5SXvxhJaSIlcd7a5cw9RFZmMYRtL83JjQnm+CrQbZoCyg== X-Gm-Gg: AZuq6aJ2A1UM5HvTaUXhxwtsRslCsVDNXeN274Y9PFmx7n91dXQOrnmF1Xy3U9Irbmk /JqsFcLRrE9nLVSTfpcV71C1tfdMqJiCzqYPwwXwPVhxNnj52nBajPSWhp552xrN3XyOez9ao3m L2GU55P3IVAI6cylcbIMf/c2rO7atRBm1D7nKWvy7Ab11XE3uXl/ZvY8pleqK/8QA5aSnkhqPEy 2+g1azAOQ75owQi+hj9c3jMR9ieOR0MDY1/GBiiKE+eR5EEq+oI8gIrbVPTozIsW8pDhndyrI4H 4WoG4q5PA3oYv2g9+L2kTKNFI8sY4jN3HNAtJbz9rwFh5MSgcVEOtPavgJRQEWXKgPqwD39NRZp UmKEPtwMQfgsc6xZj6n7B28NHHaHF4fROLNQ= X-Received: by 2002:a05:600c:1d89:b0:480:3bba:1ca9 with SMTP id 5b1f17b1804b1-48373a083c8mr27813015e9.4.1770983591686; Fri, 13 Feb 2026 03:53:11 -0800 (PST) X-Received: by 2002:a05:600c:1d89:b0:480:3bba:1ca9 with SMTP id 5b1f17b1804b1-48373a083c8mr27812615e9.4.1770983591263; Fri, 13 Feb 2026 03:53:11 -0800 (PST) Received: from costa-tp.bos2.lab ([2a00:a041:e223:1b00:fe51:8bb:7986:c897]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4834d835f6bsm234671275e9.14.2026.02.13.03.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 03:53:10 -0800 (PST) From: Costa Shulyupin To: Steven Rostedt , Tomas Glozar , Costa Shulyupin , Crystal Wood , Wander Lairson Costa , Ivan Pravdin , John Kacur , Tiezhu Yang , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH v3 5/5] tools/rtla: Remove unneeded cpus parameter from timerlat BPF functions Date: Fri, 13 Feb 2026 13:52:34 +0200 Message-ID: <20260213115234.430232-6-costa.shul@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260213115234.430232-1-costa.shul@redhat.com> References: <20260213115234.430232-1-costa.shul@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" nr_cpus is a global variable available throughout the codebase, so passing it as a function parameter is unnecessary. Remove the cpus parameter from timerlat_bpf_get_hist_value() and get_value(), using the global nr_cpus directly. Signed-off-by: Costa Shulyupin --- tools/tracing/rtla/src/timerlat_bpf.c | 16 +++++++--------- tools/tracing/rtla/src/timerlat_bpf.h | 6 ++---- tools/tracing/rtla/src/timerlat_hist.c | 2 +- 3 files changed, 10 insertions(+), 14 deletions(-) diff --git a/tools/tracing/rtla/src/timerlat_bpf.c b/tools/tracing/rtla/src= /timerlat_bpf.c index 8d5c3a095e41..dd3cf71d74e5 100644 --- a/tools/tracing/rtla/src/timerlat_bpf.c +++ b/tools/tracing/rtla/src/timerlat_bpf.c @@ -147,24 +147,23 @@ static int get_value(struct bpf_map *map_irq, int key, long long *value_irq, long long *value_thread, - long long *value_user, - int cpus) + long long *value_user) { int err; =20 err =3D bpf_map__lookup_elem(map_irq, &key, sizeof(unsigned int), value_irq, - sizeof(long long) * cpus, 0); + sizeof(long long) * nr_cpus, 0); if (err) return err; err =3D bpf_map__lookup_elem(map_thread, &key, sizeof(unsigned int), value_thread, - sizeof(long long) * cpus, 0); + sizeof(long long) * nr_cpus, 0); if (err) return err; err =3D bpf_map__lookup_elem(map_user, &key, sizeof(unsigned int), value_user, - sizeof(long long) * cpus, 0); + sizeof(long long) * nr_cpus, 0); if (err) return err; return 0; @@ -176,13 +175,12 @@ static int get_value(struct bpf_map *map_irq, int timerlat_bpf_get_hist_value(int key, long long *value_irq, long long *value_thread, - long long *value_user, - int cpus) + long long *value_user) { return get_value(bpf->maps.hist_irq, bpf->maps.hist_thread, bpf->maps.hist_user, - key, value_irq, value_thread, value_user, cpus); + key, value_irq, value_thread, value_user); } =20 /* @@ -196,7 +194,7 @@ int timerlat_bpf_get_summary_value(enum summary_field k= ey, return get_value(bpf->maps.summary_irq, bpf->maps.summary_thread, bpf->maps.summary_user, - key, value_irq, value_thread, value_user, nr_cpus); + key, value_irq, value_thread, value_user); } =20 /* diff --git a/tools/tracing/rtla/src/timerlat_bpf.h b/tools/tracing/rtla/src= /timerlat_bpf.h index f4a5476f2abb..531c9ef16f51 100644 --- a/tools/tracing/rtla/src/timerlat_bpf.h +++ b/tools/tracing/rtla/src/timerlat_bpf.h @@ -23,8 +23,7 @@ int timerlat_bpf_restart_tracing(void); int timerlat_bpf_get_hist_value(int key, long long *value_irq, long long *value_thread, - long long *value_user, - int cpus); + long long *value_user); int timerlat_bpf_get_summary_value(enum summary_field key, long long *value_irq, long long *value_thread, @@ -44,8 +43,7 @@ static inline int timerlat_bpf_restart_tracing(void) { re= turn -1; }; static inline int timerlat_bpf_get_hist_value(int key, long long *value_irq, long long *value_thread, - long long *value_user, - int cpus) + long long *value_user) { return -1; } diff --git a/tools/tracing/rtla/src/timerlat_hist.c b/tools/tracing/rtla/sr= c/timerlat_hist.c index db66312ec966..1c4702948532 100644 --- a/tools/tracing/rtla/src/timerlat_hist.c +++ b/tools/tracing/rtla/src/timerlat_hist.c @@ -209,7 +209,7 @@ static int timerlat_hist_bpf_pull_data(struct osnoise_t= ool *tool) /* Pull histogram */ for (i =3D 0; i < data->entries; i++) { err =3D timerlat_bpf_get_hist_value(i, value_irq, value_thread, - value_user, nr_cpus); + value_user); if (err) return err; for (j =3D 0; j < nr_cpus; j++) { --=20 2.52.0