From nobody Thu Apr 2 22:07:13 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E027835CB87 for ; Fri, 13 Feb 2026 11:53:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770983593; cv=none; b=O3FB4Nk9YhyP7/fHq48rU0YhdQk6oMJwgmjF2QqlEti8jGQU7kwtl3/CX8ZHPuGG8yfcF6+nak+Dnob4IR7QVvEFhHvYTwk05PiAQy8Qk6GQdDUTPaEDXEFQoZgKeY2gviNWj+6BUbO31CDi5kycUDZhJVN7M01u1LQ04MpFikk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770983593; c=relaxed/simple; bh=jXM6h73fi/T1NI6sc5NlsOcr2JeACiIlmwKPddXhEyc=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NRGU9IPnhHuYIS2eqBvFKTxKDJr1Mkl/zkwky6foAaFBUrbTgG+bUXS4vHsZ05vWiAQGsxJ4+U2s+VVvCCMImAsvtZKks3qvdwKcse5ily6Kt8i4aPN2kdj8qxEZTcD7c7lIEXdugN/VfKeo9x9E2VMnBwP/TsGdOG4bcZPSULw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fHQ4yFmf; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=tGvSbYfA; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fHQ4yFmf"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="tGvSbYfA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770983591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vrzntSVggQfVgXA1EfIrnMrsyGocXfN5hLyeRmwcLd0=; b=fHQ4yFmfP9+oeRicat5VTr7LiQOH8g3shd6jSAz14YcMolzfJ80aZ93PFpMR/Dj4tiM5lO cMrzDMFdHsc0jfy/jGPktNEMBfJo/5lo2jevAVCNCZ+gEbQZWtL9ZtGku5vVWcE+ePYUJ1 6cECKNf6BayJBJPP4CyKe9ak7b5X7UY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-149-y_WwLVc3O9Klr2MNB66C2g-1; Fri, 13 Feb 2026 06:53:10 -0500 X-MC-Unique: y_WwLVc3O9Klr2MNB66C2g-1 X-Mimecast-MFC-AGG-ID: y_WwLVc3O9Klr2MNB66C2g_1770983589 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48069a43217so7784665e9.1 for ; Fri, 13 Feb 2026 03:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770983589; x=1771588389; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=vrzntSVggQfVgXA1EfIrnMrsyGocXfN5hLyeRmwcLd0=; b=tGvSbYfAi9k7YsSjsCciLtYL4ES8bVDTe4FzaTC+K64cTN3UutclUKkxVol0AT1ih+ 3iWFKiU1ThXiAvVu5dZ2Qt4nr/sADVvKzVeX5NxbrANQLeZKVmNnHw0tUCRlgQQXrUTT PYM2CfieZ1dBMmeiZTaTpAV3xw/1Yx7C5mRKZe0b+Y5UZ5eO8jFKNDwb9WBPzGIs7ajC KQE+eoEEnsyCBke6iWbCFVD7msA/PagMXTV+DDfuNJGrF3UksSCckzVGV/y7YaLTOwkd 3aD/RvVBZwvvj2jt3JsQHcLW1Fbdf9QZlJsXnhF0QmVxNR60j80DFN07DFEt1m+TaEy8 phCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770983589; x=1771588389; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vrzntSVggQfVgXA1EfIrnMrsyGocXfN5hLyeRmwcLd0=; b=EUqQsu/X8TJWRLlBlEgp1H1+UQtjocJZ8cQnd+DZ8LBBLSRid8q7EBEfhdL7n1BcQ8 Ckmgenes4FAAdSaFnHRJVrLqEzRzXPs5TR5weNGHpeExqslkns/TniTFFeDvEQ4KvN9D 8FNRMTQOY+HmXLgY2pIUTTK2QO1GzdTsbMKICZcb1K07K/PZgDCZBzAt4T/CdHkocVHg uzW9jlPOp8cTQHPx9IX56ufB2WD1m3rtHfEtUkFPYs6WP6+DddeQ9R2STa2XMjQ1BH/g hIJz7E4TopGbt5+2RiEn7rio5jW5eQCZdchD/xBh+w7BIrsOG4zwxZdV4V3WEH8naw9o AGnw== X-Forwarded-Encrypted: i=1; AJvYcCVh3fdBp8MlNX2kptUwqF9TdaYZ53UekSfRZfNrIbOsnb+25wAMgHid2obkw7BLJ8amcPhxnO4AnyyDWQc=@vger.kernel.org X-Gm-Message-State: AOJu0YxYUh9lfGRRmFk0aK6P79c7y9Wm7aIhgFySK6lTClLUlNeuQM6h PC+y6zOujgDpK+PnD7ATrbVDI6Q2kOU2dbVa5h4ofZ23XziktKBvXwMABXAcPWAWdrltpUZDasO s1MYvsmTAgAyb9xYPtru6ASXOQQW9hxQq3CQwPT1IvAlG+rkkNKJAon6akeoK94lhKQ== X-Gm-Gg: AZuq6aJDKMC8gyIuNQCFTp/QsnWiwEVpIZr1SDNGHOqo8cJ1Pui+ykLUJIQRh4fAM2n pzGY37y623sIGFeszMcSiYScRqf9lY+JVGLISJvj7gXhvqrMHn3BQoBq49TmXz2IOIrV1Iv2XsN fBXpxP5J2kubYzLFs1RMu0tAoyYwEhXN82M9Ytks9z+A2ITn64gAhnLxxNyfHPJHEgO9d/kwy6f 4V8lo67XEZX5CNoC9rgmHZzvOs6s3QnJ7MP1wy90CKEoTYFdtGdJmhCmsSvGrSRManEtRglTwVq eR0+2j+pyEgyP5wn+LFI8jURbFKnvImO3x6KjLAv+cUDhEt5X81AyFhaALd/5f87FOPtr4jacW6 1nUBkS2CyEkd1WpbSFeiohH5rHCULG8EiqOE= X-Received: by 2002:a05:600c:45cc:b0:47a:814c:eea1 with SMTP id 5b1f17b1804b1-48373a6c1f8mr21763945e9.35.1770983588509; Fri, 13 Feb 2026 03:53:08 -0800 (PST) X-Received: by 2002:a05:600c:45cc:b0:47a:814c:eea1 with SMTP id 5b1f17b1804b1-48373a6c1f8mr21763435e9.35.1770983588037; Fri, 13 Feb 2026 03:53:08 -0800 (PST) Received: from costa-tp.bos2.lab ([2a00:a041:e223:1b00:fe51:8bb:7986:c897]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4834d835f6bsm234671275e9.14.2026.02.13.03.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 03:53:07 -0800 (PST) From: Costa Shulyupin To: Steven Rostedt , Tomas Glozar , Costa Shulyupin , Crystal Wood , Wander Lairson Costa , Ivan Pravdin , John Kacur , Tiezhu Yang , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH v3 4/5] tools/rtla: Remove unneeded nr_cpus from for_each_monitored_cpu Date: Fri, 13 Feb 2026 13:52:33 +0200 Message-ID: <20260213115234.430232-5-costa.shul@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260213115234.430232-1-costa.shul@redhat.com> References: <20260213115234.430232-1-costa.shul@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" nr_cpus does not change at runtime, so passing it through the macro argument is unnecessary. Remove the argument and use the global nr_cpus instead. Signed-off-by: Costa Shulyupin --- tools/tracing/rtla/src/common.h | 2 +- tools/tracing/rtla/src/osnoise_hist.c | 15 +++++++-------- tools/tracing/rtla/src/osnoise_top.c | 2 +- tools/tracing/rtla/src/timerlat.c | 4 ++-- tools/tracing/rtla/src/timerlat_hist.c | 16 ++++++++-------- tools/tracing/rtla/src/timerlat_top.c | 2 +- 6 files changed, 20 insertions(+), 21 deletions(-) diff --git a/tools/tracing/rtla/src/common.h b/tools/tracing/rtla/src/commo= n.h index 32f9c1351209..28d258d6d178 100644 --- a/tools/tracing/rtla/src/common.h +++ b/tools/tracing/rtla/src/common.h @@ -109,7 +109,7 @@ struct common_params { =20 extern int nr_cpus; =20 -#define for_each_monitored_cpu(cpu, nr_cpus, common) \ +#define for_each_monitored_cpu(cpu, common) \ for (cpu =3D 0; cpu < nr_cpus; cpu++) \ if (!(common)->cpus || CPU_ISSET(cpu, &(common)->monitored_cpus)) =20 diff --git a/tools/tracing/rtla/src/osnoise_hist.c b/tools/tracing/rtla/src= /osnoise_hist.c index 90291504a1aa..e8f07108d39a 100644 --- a/tools/tracing/rtla/src/osnoise_hist.c +++ b/tools/tracing/rtla/src/osnoise_hist.c @@ -244,7 +244,7 @@ static void osnoise_hist_header(struct osnoise_tool *to= ol) if (!params->common.hist.no_index) trace_seq_printf(s, "Index"); =20 - for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, ¶ms->common) { =20 if (!data->hist[cpu].count) continue; @@ -273,8 +273,7 @@ osnoise_print_summary(struct osnoise_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "count:"); =20 - for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { - + for_each_monitored_cpu(cpu, ¶ms->common) { if (!data->hist[cpu].count) continue; =20 @@ -285,7 +284,7 @@ osnoise_print_summary(struct osnoise_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "min: "); =20 - for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, ¶ms->common) { =20 if (!data->hist[cpu].count) continue; @@ -298,7 +297,7 @@ osnoise_print_summary(struct osnoise_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "avg: "); =20 - for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, ¶ms->common) { =20 if (!data->hist[cpu].count) continue; @@ -314,7 +313,7 @@ osnoise_print_summary(struct osnoise_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "max: "); =20 - for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, ¶ms->common) { =20 if (!data->hist[cpu].count) continue; @@ -349,7 +348,7 @@ osnoise_print_stats(struct osnoise_tool *tool) trace_seq_printf(trace->seq, "%-6d", bucket * data->bucket_size); =20 - for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, ¶ms->common) { =20 if (!data->hist[cpu].count) continue; @@ -385,7 +384,7 @@ osnoise_print_stats(struct osnoise_tool *tool) if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "over: "); =20 - for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, ¶ms->common) { =20 if (!data->hist[cpu].count) continue; diff --git a/tools/tracing/rtla/src/osnoise_top.c b/tools/tracing/rtla/src/= osnoise_top.c index 6fb3e72d74f2..ab5db35f21ae 100644 --- a/tools/tracing/rtla/src/osnoise_top.c +++ b/tools/tracing/rtla/src/osnoise_top.c @@ -236,7 +236,7 @@ osnoise_print_stats(struct osnoise_tool *top) =20 osnoise_top_header(top); =20 - for_each_monitored_cpu(i, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(i, ¶ms->common) { osnoise_top_print(top, i); } =20 diff --git a/tools/tracing/rtla/src/timerlat.c b/tools/tracing/rtla/src/tim= erlat.c index 69856f677fce..ec14abd45fff 100644 --- a/tools/tracing/rtla/src/timerlat.c +++ b/tools/tracing/rtla/src/timerlat.c @@ -115,7 +115,7 @@ int timerlat_enable(struct osnoise_tool *tool) return -1; } =20 - for_each_monitored_cpu(i, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(i, ¶ms->common) { if (save_cpu_idle_disable_state(i) < 0) { err_msg("Could not save cpu idle state.\n"); return -1; @@ -218,7 +218,7 @@ void timerlat_free(struct osnoise_tool *tool) if (dma_latency_fd >=3D 0) close(dma_latency_fd); if (params->deepest_idle_state >=3D -1) { - for_each_monitored_cpu(i, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(i, ¶ms->common) { restore_cpu_idle_disable_state(i); } } diff --git a/tools/tracing/rtla/src/timerlat_hist.c b/tools/tracing/rtla/sr= c/timerlat_hist.c index 4bf1489cad23..db66312ec966 100644 --- a/tools/tracing/rtla/src/timerlat_hist.c +++ b/tools/tracing/rtla/src/timerlat_hist.c @@ -298,7 +298,7 @@ static void timerlat_hist_header(struct osnoise_tool *t= ool) if (!params->common.hist.no_index) trace_seq_printf(s, "Index"); =20 - for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; @@ -350,7 +350,7 @@ timerlat_print_summary(struct timerlat_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "count:"); =20 - for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; @@ -372,7 +372,7 @@ timerlat_print_summary(struct timerlat_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "min: "); =20 - for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; @@ -400,7 +400,7 @@ timerlat_print_summary(struct timerlat_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "avg: "); =20 - for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; @@ -428,7 +428,7 @@ timerlat_print_summary(struct timerlat_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "max: "); =20 - for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; @@ -473,7 +473,7 @@ timerlat_print_stats_all(struct timerlat_params *params, sum.min_thread =3D ~0; sum.min_user =3D ~0; =20 - for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; @@ -620,7 +620,7 @@ timerlat_print_stats(struct osnoise_tool *tool) trace_seq_printf(trace->seq, "%-6d", bucket * data->bucket_size); =20 - for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; @@ -658,7 +658,7 @@ timerlat_print_stats(struct osnoise_tool *tool) if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "over: "); =20 - for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; diff --git a/tools/tracing/rtla/src/timerlat_top.c b/tools/tracing/rtla/src= /timerlat_top.c index 4eb820fe1f21..ed3d3d1c8956 100644 --- a/tools/tracing/rtla/src/timerlat_top.c +++ b/tools/tracing/rtla/src/timerlat_top.c @@ -446,7 +446,7 @@ timerlat_print_stats(struct osnoise_tool *top) =20 timerlat_top_header(params, top); =20 - for_each_monitored_cpu(i, nr_cpus, ¶ms->common) { + for_each_monitored_cpu(i, ¶ms->common) { timerlat_top_print(top, i); timerlat_top_update_sum(top, i, &summary); } --=20 2.52.0