From nobody Thu Apr 2 22:05:40 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8B0535C18A for ; Fri, 13 Feb 2026 11:53:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770983593; cv=none; b=Hm6aGSYcxsPEncXHu9qE+2jj6HpuRvttQ8TKatiMSPtmIznKDXM03buI8bQe/75XDdpbQ37FROnrHJe8p3WgAoHn+P/Ydgfd5eZHoEWRBPSZR9a9OFNyWM9fEuTlF1WLW63HgFJpIGn0Zgb2wtzfln+r+rxphjFNt/a3Fek60Ns= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770983593; c=relaxed/simple; bh=w5dKFS5R1t7rYrQ20YIX0+7bdom2BHUqpe/9dlSUrLY=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uN+aRvtHI9A9tMnb0hYk9zjap9dwTBYjHFpknPOCkBrrdmNWhNyfxHBZ4zQBGliv8p68KwVlRz2I4/53+j1v5AQ7ChLwMnJYEwnP+Ayn4XiR7H/ikbWaOOne4ZRxnaK7LK3tet9T5kde6l42MRY3ZnqdzVzzWQ4D+d8TGaZXafA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ipw15F7U; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=rx0vyNPK; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ipw15F7U"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="rx0vyNPK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770983590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kx32wyrFkPDhCGYWgA3ZxyjG0SxAKZ8Fjt/kqUocyos=; b=Ipw15F7UW81mQZyrxruiMsICv3ncEwmDiqv6g/IHSgqoBdMgfn8BpO8wNBwHtL2J7ThrFl x9jHe3MqbNwTBrWNiXlD/oeB60J9eIp7/SwwtUJM6TBCnjH/xbH2qDkgxxEBMPZTx2IiFG W3OBBZ+e5LC1ti57P8cE593Knsp1PoY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-Wiw61cC2MNeVyub6yeBghA-1; Fri, 13 Feb 2026 06:53:07 -0500 X-MC-Unique: Wiw61cC2MNeVyub6yeBghA-1 X-Mimecast-MFC-AGG-ID: Wiw61cC2MNeVyub6yeBghA_1770983586 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4806865a01bso6036065e9.0 for ; Fri, 13 Feb 2026 03:53:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770983586; x=1771588386; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Kx32wyrFkPDhCGYWgA3ZxyjG0SxAKZ8Fjt/kqUocyos=; b=rx0vyNPKiTJZSgvwL8LNCF4TNzLgereHFpho/tKLu8DD44JHIvdMCuYFRHF6jr+xHh wJT/UUbgcMWhSR+9nIQL9v7GOC2dzn2nmO0VlYrjhNSynoIqviJyPgv86q/iJvmTIQPO 9TEm1NbXXLNUFltdnnr42Ym9Vja4bXkb8bSKbojHAHR+pEHU9oo/jx72LOdRL6mikkJg ngC5jBv+skb8XJnPpsf+xR8UJQ9m58ia3nD1oOtp53ehWlPcyYwTht0I+HqA3Zyc8nrF YLCZMWNTyT5xE3WWOs5d9t4CGlWFdd68tyj9bj+S5DqO5nZ0vlPvmKVyn5PbCU7r0qF9 yM6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770983586; x=1771588386; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Kx32wyrFkPDhCGYWgA3ZxyjG0SxAKZ8Fjt/kqUocyos=; b=cpW3N6X/Y9KnNR44fuxJ/B/6+BUR5kutIHq0To82Fcy2D0Ff7fxW0iEdQ84qhyrvhm PPHRW85i/XW9SobXlbJWHtZrMVX6SQQQyhlTGxiK4N1j6wlX3KGFpbboUHJ7Kc+Cduvq QewzMm4ehvQ28nI/rGCuQDaVIcy0OM7BRnWGB064sKZAwqSezbb0OyBrw5LxBY44uvo4 Ed9o3LLj2hThryFWTPbVy7G6wjQhtlmDBDZ1PDanV0d4BQ8ok0w8o+82lG92Ohubybo4 vUICj61D1hA0o106oOF/qHm/nWJLimm2wSrHarjGuWn3L7ZeumGV+8dCNXR3ZMtdcvo0 CUFA== X-Forwarded-Encrypted: i=1; AJvYcCWYjS6Ci99uHmSS8yNhiotRi8704/Di03LwnF9IzYW22TiJIKOaEJEoDrXN7JaEqBtqSlmuxx0V7rErngg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+98SK4UF/aLKZbcUCo1qpz9/Dja2u6iZzwcRZziRTSBRuC9No Uv1WtF0qsNrTDMjV7WNIWlKObkGcVuR9fsYHU9MEb3gC85Jgxlvnies85uff/D3YClpCwFD070F ZFMiiYQ/Da2mN+oZKCussfUrOzK9borXPOnbEhHwh7/S691d95mybEkf1VynRX9yVtQ== X-Gm-Gg: AZuq6aI9B7Ytze/xtcB+Ov1O2hXOEiB64RJVr3r9fYwd6LvUUY+zlHewKQpwLaolwV8 qSJkZSMjKzvTZxpFqVhBffb9qtE+iZuv9Bzs/LmQti6vlJEWCGJT7SWzYNyr4llL55mXk1KYUGN lnT3OJ84G4jdss4Mvrxjyv8HX3bt5N8Aats8UaIPyunBaGQ27o9KEJhLQFuzypZ1zEQHhdoAg9t 2eWtHyq9bULB7BtPZtLgILUBlGmEXfWj11TMFyewRyXLjZqU5IMqaFMmkHSoBIhQknP8sUuiK7n g/cdANJS8HyL5z9GrsDwf4mZw9K7d0BwlPEZkf4lliPFCcN6poVRkNVRctbLxb6Ut8SnFIzhv3Q Ib0NbSMjt1SgK0zc1rT35rpeYqwYtGtbOMHI= X-Received: by 2002:a05:600c:8706:b0:477:73e9:dbe7 with SMTP id 5b1f17b1804b1-48373a58a97mr22578695e9.35.1770983585910; Fri, 13 Feb 2026 03:53:05 -0800 (PST) X-Received: by 2002:a05:600c:8706:b0:477:73e9:dbe7 with SMTP id 5b1f17b1804b1-48373a58a97mr22578295e9.35.1770983585422; Fri, 13 Feb 2026 03:53:05 -0800 (PST) Received: from costa-tp.bos2.lab ([2a00:a041:e223:1b00:fe51:8bb:7986:c897]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4834d835f6bsm234671275e9.14.2026.02.13.03.53.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 03:53:05 -0800 (PST) From: Costa Shulyupin To: Steven Rostedt , Tomas Glozar , Costa Shulyupin , Crystal Wood , Wander Lairson Costa , Ivan Pravdin , John Kacur , Tiezhu Yang , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH v3 3/5] tools/rtla: Remove unneeded nr_cpus members Date: Fri, 13 Feb 2026 13:52:32 +0200 Message-ID: <20260213115234.430232-4-costa.shul@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260213115234.430232-1-costa.shul@redhat.com> References: <20260213115234.430232-1-costa.shul@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" nr_cpus does not change at runtime, so keeping it in struct members is unnecessary. Use the global nr_cpus instead of struct members. Signed-off-by: Costa Shulyupin --- tools/tracing/rtla/src/osnoise_hist.c | 18 ++++++------ tools/tracing/rtla/src/osnoise_top.c | 3 -- tools/tracing/rtla/src/timerlat_aa.c | 10 +++---- tools/tracing/rtla/src/timerlat_hist.c | 40 ++++++++++++-------------- tools/tracing/rtla/src/timerlat_top.c | 19 ++++++------ 5 files changed, 39 insertions(+), 51 deletions(-) diff --git a/tools/tracing/rtla/src/osnoise_hist.c b/tools/tracing/rtla/src= /osnoise_hist.c index d83ee047a5f5..90291504a1aa 100644 --- a/tools/tracing/rtla/src/osnoise_hist.c +++ b/tools/tracing/rtla/src/osnoise_hist.c @@ -29,7 +29,6 @@ struct osnoise_hist_data { struct osnoise_hist_cpu *hist; int entries; int bucket_size; - int nr_cpus; }; =20 /* @@ -41,7 +40,7 @@ osnoise_free_histogram(struct osnoise_hist_data *data) int cpu; =20 /* one histogram for IRQ and one for thread, per CPU */ - for (cpu =3D 0; cpu < data->nr_cpus; cpu++) { + for (cpu =3D 0; cpu < nr_cpus; cpu++) { if (data->hist[cpu].samples) free(data->hist[cpu].samples); } @@ -73,7 +72,6 @@ static struct osnoise_hist_data =20 data->entries =3D entries; data->bucket_size =3D bucket_size; - data->nr_cpus =3D nr_cpus; =20 data->hist =3D calloc(1, sizeof(*data->hist) * nr_cpus); if (!data->hist) @@ -246,7 +244,7 @@ static void osnoise_hist_header(struct osnoise_tool *to= ol) if (!params->common.hist.no_index) trace_seq_printf(s, "Index"); =20 - for_each_monitored_cpu(cpu, data->nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { =20 if (!data->hist[cpu].count) continue; @@ -275,7 +273,7 @@ osnoise_print_summary(struct osnoise_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "count:"); =20 - for_each_monitored_cpu(cpu, data->nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { =20 if (!data->hist[cpu].count) continue; @@ -287,7 +285,7 @@ osnoise_print_summary(struct osnoise_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "min: "); =20 - for_each_monitored_cpu(cpu, data->nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { =20 if (!data->hist[cpu].count) continue; @@ -300,7 +298,7 @@ osnoise_print_summary(struct osnoise_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "avg: "); =20 - for_each_monitored_cpu(cpu, data->nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { =20 if (!data->hist[cpu].count) continue; @@ -316,7 +314,7 @@ osnoise_print_summary(struct osnoise_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "max: "); =20 - for_each_monitored_cpu(cpu, data->nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { =20 if (!data->hist[cpu].count) continue; @@ -351,7 +349,7 @@ osnoise_print_stats(struct osnoise_tool *tool) trace_seq_printf(trace->seq, "%-6d", bucket * data->bucket_size); =20 - for_each_monitored_cpu(cpu, data->nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { =20 if (!data->hist[cpu].count) continue; @@ -387,7 +385,7 @@ osnoise_print_stats(struct osnoise_tool *tool) if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "over: "); =20 - for_each_monitored_cpu(cpu, data->nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { =20 if (!data->hist[cpu].count) continue; diff --git a/tools/tracing/rtla/src/osnoise_top.c b/tools/tracing/rtla/src/= osnoise_top.c index 73b3ac0dd43b..6fb3e72d74f2 100644 --- a/tools/tracing/rtla/src/osnoise_top.c +++ b/tools/tracing/rtla/src/osnoise_top.c @@ -31,7 +31,6 @@ struct osnoise_top_cpu { =20 struct osnoise_top_data { struct osnoise_top_cpu *cpu_data; - int nr_cpus; }; =20 /* @@ -59,8 +58,6 @@ static struct osnoise_top_data *osnoise_alloc_top(void) if (!data) return NULL; =20 - data->nr_cpus =3D nr_cpus; - /* one set of histograms per CPU */ data->cpu_data =3D calloc(1, sizeof(*data->cpu_data) * nr_cpus); if (!data->cpu_data) diff --git a/tools/tracing/rtla/src/timerlat_aa.c b/tools/tracing/rtla/src/= timerlat_aa.c index 5766d58709eb..59b219a1503e 100644 --- a/tools/tracing/rtla/src/timerlat_aa.c +++ b/tools/tracing/rtla/src/timerlat_aa.c @@ -102,7 +102,6 @@ struct timerlat_aa_data { * The analysis context and system wide view */ struct timerlat_aa_context { - int nr_cpus; int dump_tasks; =20 /* per CPU data */ @@ -738,7 +737,7 @@ void timerlat_auto_analysis(int irq_thresh, int thread_= thresh) irq_thresh =3D irq_thresh * 1000; thread_thresh =3D thread_thresh * 1000; =20 - for (cpu =3D 0; cpu < taa_ctx->nr_cpus; cpu++) { + for (cpu =3D 0; cpu < nr_cpus; cpu++) { taa_data =3D timerlat_aa_get_data(taa_ctx, cpu); =20 if (irq_thresh && taa_data->tlat_irq_latency >=3D irq_thresh) { @@ -766,7 +765,7 @@ void timerlat_auto_analysis(int irq_thresh, int thread_= thresh) =20 printf("\n"); printf("Printing CPU tasks:\n"); - for (cpu =3D 0; cpu < taa_ctx->nr_cpus; cpu++) { + for (cpu =3D 0; cpu < nr_cpus; cpu++) { taa_data =3D timerlat_aa_get_data(taa_ctx, cpu); tep =3D taa_ctx->tool->trace.tep; =20 @@ -792,7 +791,7 @@ static void timerlat_aa_destroy_seqs(struct timerlat_aa= _context *taa_ctx) if (!taa_ctx->taa_data) return; =20 - for (i =3D 0; i < taa_ctx->nr_cpus; i++) { + for (i =3D 0; i < nr_cpus; i++) { taa_data =3D timerlat_aa_get_data(taa_ctx, i); =20 if (taa_data->prev_irqs_seq) { @@ -842,7 +841,7 @@ static int timerlat_aa_init_seqs(struct timerlat_aa_con= text *taa_ctx) struct timerlat_aa_data *taa_data; int i; =20 - for (i =3D 0; i < taa_ctx->nr_cpus; i++) { + for (i =3D 0; i < nr_cpus; i++) { =20 taa_data =3D timerlat_aa_get_data(taa_ctx, i); =20 @@ -1031,7 +1030,6 @@ int timerlat_aa_init(struct osnoise_tool *tool, int d= ump_tasks) =20 __timerlat_aa_ctx =3D taa_ctx; =20 - taa_ctx->nr_cpus =3D nr_cpus; taa_ctx->tool =3D tool; taa_ctx->dump_tasks =3D dump_tasks; =20 diff --git a/tools/tracing/rtla/src/timerlat_hist.c b/tools/tracing/rtla/sr= c/timerlat_hist.c index dee5fbf622c3..4bf1489cad23 100644 --- a/tools/tracing/rtla/src/timerlat_hist.c +++ b/tools/tracing/rtla/src/timerlat_hist.c @@ -44,7 +44,6 @@ struct timerlat_hist_data { struct timerlat_hist_cpu *hist; int entries; int bucket_size; - int nr_cpus; }; =20 /* @@ -56,7 +55,7 @@ timerlat_free_histogram(struct timerlat_hist_data *data) int cpu; =20 /* one histogram for IRQ and one for thread, per CPU */ - for (cpu =3D 0; cpu < data->nr_cpus; cpu++) { + for (cpu =3D 0; cpu < nr_cpus; cpu++) { if (data->hist[cpu].irq) free(data->hist[cpu].irq); =20 @@ -94,7 +93,6 @@ static struct timerlat_hist_data =20 data->entries =3D entries; data->bucket_size =3D bucket_size; - data->nr_cpus =3D nr_cpus; =20 /* one set of histograms per CPU */ data->hist =3D calloc(1, sizeof(*data->hist) * nr_cpus); @@ -204,17 +202,17 @@ static int timerlat_hist_bpf_pull_data(struct osnoise= _tool *tool) { struct timerlat_hist_data *data =3D tool->data; int i, j, err; - long long value_irq[data->nr_cpus], - value_thread[data->nr_cpus], - value_user[data->nr_cpus]; + long long value_irq[nr_cpus], + value_thread[nr_cpus], + value_user[nr_cpus]; =20 /* Pull histogram */ for (i =3D 0; i < data->entries; i++) { err =3D timerlat_bpf_get_hist_value(i, value_irq, value_thread, - value_user, data->nr_cpus); + value_user, nr_cpus); if (err) return err; - for (j =3D 0; j < data->nr_cpus; j++) { + for (j =3D 0; j < nr_cpus; j++) { data->hist[j].irq[i] =3D value_irq[j]; data->hist[j].thread[i] =3D value_thread[j]; data->hist[j].user[i] =3D value_user[j]; @@ -226,7 +224,7 @@ static int timerlat_hist_bpf_pull_data(struct osnoise_t= ool *tool) value_irq, value_thread, value_user); if (err) return err; - for (i =3D 0; i < data->nr_cpus; i++) { + for (i =3D 0; i < nr_cpus; i++) { data->hist[i].irq_count =3D value_irq[i]; data->hist[i].thread_count =3D value_thread[i]; data->hist[i].user_count =3D value_user[i]; @@ -236,7 +234,7 @@ static int timerlat_hist_bpf_pull_data(struct osnoise_t= ool *tool) value_irq, value_thread, value_user); if (err) return err; - for (i =3D 0; i < data->nr_cpus; i++) { + for (i =3D 0; i < nr_cpus; i++) { data->hist[i].min_irq =3D value_irq[i]; data->hist[i].min_thread =3D value_thread[i]; data->hist[i].min_user =3D value_user[i]; @@ -246,7 +244,7 @@ static int timerlat_hist_bpf_pull_data(struct osnoise_t= ool *tool) value_irq, value_thread, value_user); if (err) return err; - for (i =3D 0; i < data->nr_cpus; i++) { + for (i =3D 0; i < nr_cpus; i++) { data->hist[i].max_irq =3D value_irq[i]; data->hist[i].max_thread =3D value_thread[i]; data->hist[i].max_user =3D value_user[i]; @@ -256,7 +254,7 @@ static int timerlat_hist_bpf_pull_data(struct osnoise_t= ool *tool) value_irq, value_thread, value_user); if (err) return err; - for (i =3D 0; i < data->nr_cpus; i++) { + for (i =3D 0; i < nr_cpus; i++) { data->hist[i].sum_irq =3D value_irq[i]; data->hist[i].sum_thread =3D value_thread[i]; data->hist[i].sum_user =3D value_user[i]; @@ -266,7 +264,7 @@ static int timerlat_hist_bpf_pull_data(struct osnoise_t= ool *tool) value_irq, value_thread, value_user); if (err) return err; - for (i =3D 0; i < data->nr_cpus; i++) { + for (i =3D 0; i < nr_cpus; i++) { data->hist[i].irq[data->entries] =3D value_irq[i]; data->hist[i].thread[data->entries] =3D value_thread[i]; data->hist[i].user[data->entries] =3D value_user[i]; @@ -300,7 +298,7 @@ static void timerlat_hist_header(struct osnoise_tool *t= ool) if (!params->common.hist.no_index) trace_seq_printf(s, "Index"); =20 - for_each_monitored_cpu(cpu, data->nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; @@ -352,7 +350,7 @@ timerlat_print_summary(struct timerlat_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "count:"); =20 - for_each_monitored_cpu(cpu, data->nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; @@ -374,7 +372,7 @@ timerlat_print_summary(struct timerlat_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "min: "); =20 - for_each_monitored_cpu(cpu, data->nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; @@ -402,7 +400,7 @@ timerlat_print_summary(struct timerlat_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "avg: "); =20 - for_each_monitored_cpu(cpu, data->nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; @@ -430,7 +428,7 @@ timerlat_print_summary(struct timerlat_params *params, if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "max: "); =20 - for_each_monitored_cpu(cpu, data->nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; @@ -475,7 +473,7 @@ timerlat_print_stats_all(struct timerlat_params *params, sum.min_thread =3D ~0; sum.min_user =3D ~0; =20 - for_each_monitored_cpu(cpu, data->nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; @@ -622,7 +620,7 @@ timerlat_print_stats(struct osnoise_tool *tool) trace_seq_printf(trace->seq, "%-6d", bucket * data->bucket_size); =20 - for_each_monitored_cpu(cpu, data->nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; @@ -660,7 +658,7 @@ timerlat_print_stats(struct osnoise_tool *tool) if (!params->common.hist.no_index) trace_seq_printf(trace->seq, "over: "); =20 - for_each_monitored_cpu(cpu, data->nr_cpus, ¶ms->common) { + for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) { =20 if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count) continue; diff --git a/tools/tracing/rtla/src/timerlat_top.c b/tools/tracing/rtla/src= /timerlat_top.c index 25b4d81b4fe0..4eb820fe1f21 100644 --- a/tools/tracing/rtla/src/timerlat_top.c +++ b/tools/tracing/rtla/src/timerlat_top.c @@ -41,7 +41,6 @@ struct timerlat_top_cpu { =20 struct timerlat_top_data { struct timerlat_top_cpu *cpu_data; - int nr_cpus; }; =20 /* @@ -71,8 +70,6 @@ static struct timerlat_top_data *timerlat_alloc_top(void) if (!data) return NULL; =20 - data->nr_cpus =3D nr_cpus; - /* one set of histograms per CPU */ data->cpu_data =3D calloc(1, sizeof(*data->cpu_data) * nr_cpus); if (!data->cpu_data) @@ -190,16 +187,16 @@ static int timerlat_top_bpf_pull_data(struct osnoise_= tool *tool) { struct timerlat_top_data *data =3D tool->data; int i, err; - long long value_irq[data->nr_cpus], - value_thread[data->nr_cpus], - value_user[data->nr_cpus]; + long long value_irq[nr_cpus], + value_thread[nr_cpus], + value_user[nr_cpus]; =20 /* Pull summary */ err =3D timerlat_bpf_get_summary_value(SUMMARY_CURRENT, value_irq, value_thread, value_user); if (err) return err; - for (i =3D 0; i < data->nr_cpus; i++) { + for (i =3D 0; i < nr_cpus; i++) { data->cpu_data[i].cur_irq =3D value_irq[i]; data->cpu_data[i].cur_thread =3D value_thread[i]; data->cpu_data[i].cur_user =3D value_user[i]; @@ -209,7 +206,7 @@ static int timerlat_top_bpf_pull_data(struct osnoise_to= ol *tool) value_irq, value_thread, value_user); if (err) return err; - for (i =3D 0; i < data->nr_cpus; i++) { + for (i =3D 0; i < nr_cpus; i++) { data->cpu_data[i].irq_count =3D value_irq[i]; data->cpu_data[i].thread_count =3D value_thread[i]; data->cpu_data[i].user_count =3D value_user[i]; @@ -219,7 +216,7 @@ static int timerlat_top_bpf_pull_data(struct osnoise_to= ol *tool) value_irq, value_thread, value_user); if (err) return err; - for (i =3D 0; i < data->nr_cpus; i++) { + for (i =3D 0; i < nr_cpus; i++) { data->cpu_data[i].min_irq =3D value_irq[i]; data->cpu_data[i].min_thread =3D value_thread[i]; data->cpu_data[i].min_user =3D value_user[i]; @@ -229,7 +226,7 @@ static int timerlat_top_bpf_pull_data(struct osnoise_to= ol *tool) value_irq, value_thread, value_user); if (err) return err; - for (i =3D 0; i < data->nr_cpus; i++) { + for (i =3D 0; i < nr_cpus; i++) { data->cpu_data[i].max_irq =3D value_irq[i]; data->cpu_data[i].max_thread =3D value_thread[i]; data->cpu_data[i].max_user =3D value_user[i]; @@ -239,7 +236,7 @@ static int timerlat_top_bpf_pull_data(struct osnoise_to= ol *tool) value_irq, value_thread, value_user); if (err) return err; - for (i =3D 0; i < data->nr_cpus; i++) { + for (i =3D 0; i < nr_cpus; i++) { data->cpu_data[i].sum_irq =3D value_irq[i]; data->cpu_data[i].sum_thread =3D value_thread[i]; data->cpu_data[i].sum_user =3D value_user[i]; --=20 2.52.0