From nobody Thu Apr 2 20:21:22 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC98A3054EE for ; Fri, 13 Feb 2026 10:18:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770977884; cv=none; b=P44Ff94x3f4YFG9L0928RGMwYxo17l5tSe2t1KmELTcFjdsWhbe4Hn37rxNGEJWt/pqj6dxR1UOHSO+lLF2vIfzkjw1I0k9bujZxwK+kc++qyZFudHG++DAJPHHdrjeIIeA9zjSzC2Cwi+EqY0g0/AWMauejWGjY2KDrkrtIdzU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770977884; c=relaxed/simple; bh=owxg3ffjo0yzq9+iIgDOxshAdGuKYEwI3iNz+F3BG+E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=J2OK+I/TsEa+H0yPoUUdcmNaIiEjDd5ibZn+6SfEFjIGI+fBMMLkJzd8TYArQNZgfUkJvMHZNlkK4GVWQ5hHPOz17hw056oIrOjKGCPkTgOWXhm2zqpCz9aNIWciydPdJQvZwZOGoB84ec6J592+9sumVGPQ3Wo6SFpob5BGdVI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SB+F1aD7; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SB+F1aD7" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-4377174e1ebso525067f8f.3 for ; Fri, 13 Feb 2026 02:18:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770977881; x=1771582681; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iEZJcxza1AZCaJNMWFyDz8fkw03R/0u6/e6oHZ46H+c=; b=SB+F1aD7nfGVe7nprSGSwAZoxm4mGuzI9pMORA2axyOg6wwLfPq7ehoG0LFWgXKFmP NqrevyQXg3kFcKII5DV89AlTkyGoFGLoCKN/M9NCTp61nb/vWEhnhGIZuAbrOSjZr0xz ZOeoo1Jxa8gioiEs6LZN588LgNsPuprRvrv+iW8LPiIw+h4y+VE7KO27p7Oh4hRC+x/C SoEvToqmACcTpt1Pw0gsNjTE+4fILjGb4uWfDvGx8CQrphwsEKbay3OYeWemVEinN0NK fzNC92ikibtILE/FPabEjQsZPnDpeC8RNHI0Gh3+ndWz2xeEyv9Jvh32AjMWoaXTV5dL rN6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770977881; x=1771582681; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iEZJcxza1AZCaJNMWFyDz8fkw03R/0u6/e6oHZ46H+c=; b=a1Eo/TzrE01Mx7JdJSuqM6FoBcQDWfx8MjE3Def3bCEGhObemnzETb0XP9r0X19ALV m7H8+VR0kYNYqASy5dMe3bxllxIUiWxKFcSqTOCdDxzVvXhrhpkDW3k2HKnnrtq/RLUo IyHqF4Wax7VMH0o2VnkjSGV5SonpiXFjXOOKIK6LX8L6EPQ2bC9d1vzWyBNHItxXYuvP C7Q67fBCFjTHu03xTzk4rYigy8OyVpnh93qLjrpktTYTfFRkCDLtjVgCistAL/ffQyNK LA3pEXIikfhsUUf+xhmkD6kAUXRk5WV18bST9Xl78yVr7KWusAFQYiHCb0wy1UopEnyu yS3Q== X-Forwarded-Encrypted: i=1; AJvYcCUnT4vdbS1fQFUhrSd86JlY/8p8WDhChnAbtm7LRwW3m+IwUKomAKbMSvzuaxgSSV13oaR6BiFCZKeAgZA=@vger.kernel.org X-Gm-Message-State: AOJu0YzMMLC4vZCHRBG95IKxYhlIDcx/vCAwRfn3QHedsextQEQKLOfb 1QZQLxpwsXZvvHmJkcJ2e/AOXtAUFj8oZM14d5nyYSy1wDOz4cm01mfuhjmXrY61rsk= X-Gm-Gg: AZuq6aKDVNV0ObRX+lnYNhrbzaRQ+3YWIil2aU5suXoiTPWxl8I/ZbfvhTAQCKKnNa9 wjGVgX4ThcEoo0lK3S4iljYWCZtvhY6cmdCJszSyWzVF0KyghKOdtmSrRt4u2j2tAl4v+sXwHb3 LkRGByMK3xBwO+ehrV/f7T52yx3GaWokutmlT2tzGIOdHRyktjf1kKwGxIDHf33oPBc9K26Xd7i CRfnI2pBmu4+zjOBG/+Qo00iwEoP1i1vivW39w6egecCKH3P6FUenSbb69biX5xUq61YP17sRfx 6gXCKiTTnCc1coMToJdzQKFsOOtfWxUvRB8Zz7wdFjsNj2APpvfR/K8EWq1xvCZ35hBXZ76SprS NzfcxNjMRfTrNGPUGYXDhcnNBkLVPRvPeSi0L9vDPXSuq6FClXbquZMTsmlMlHWmJ5tUiy8Z2rI QmTaaQ1yWz7jWbt03GRwdsCU5x2D+aInN1d82fDliQvA== X-Received: by 2002:a05:6000:186b:b0:437:895d:2026 with SMTP id ffacd0b85a97d-4379790e995mr3037276f8f.38.1770977880885; Fri, 13 Feb 2026 02:18:00 -0800 (PST) Received: from vingu-cube.. ([2a01:e0a:f:6020:b3fd:ad34:eb9e:df1f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796abc85csm4360091f8f.22.2026.02.13.02.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 02:18:00 -0800 (PST) From: Vincent Guittot To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, pierre.gondois@arm.com, kprateek.nayak@amd.com Cc: qyousef@layalina.io, christian.loehle@arm.com, Vincent Guittot Subject: [PATCH] sched/fair: Update overutilized detection Date: Fri, 13 Feb 2026 11:17:51 +0100 Message-ID: <20260213101751.3121899-1-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Checking uclamp_min is useless and counterproductive for overutilized state as misfit can now happen without being in overutilized state. Since commit e5ed0550c04c ("sched/fair: unlink misfit task from cpu overuti= lized") util_fits_cpu returns -1 when uclamp_min is above capacity which is not considered as cpu overutilized. Remove the useless rq_util_min parameter. Signed-off-by: Vincent Guittot Reviewed-by: Qais Yousef Reviewed-by: Christian Loehle --- kernel/sched/fair.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index c16b5fd71b2d..fdc4303ca83a 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6776,16 +6776,15 @@ static inline void hrtick_update(struct rq *rq) =20 static inline bool cpu_overutilized(int cpu) { - unsigned long rq_util_min, rq_util_max; + unsigned long rq_util_max; =20 if (!sched_energy_enabled()) return false; =20 - rq_util_min =3D uclamp_rq_get(cpu_rq(cpu), UCLAMP_MIN); rq_util_max =3D uclamp_rq_get(cpu_rq(cpu), UCLAMP_MAX); =20 /* Return true only if the utilization doesn't fit CPU's capacity */ - return !util_fits_cpu(cpu_util_cfs(cpu), rq_util_min, rq_util_max, cpu); + return !util_fits_cpu(cpu_util_cfs(cpu), 0, rq_util_max, cpu); } =20 /* --=20 2.43.0