From nobody Thu Apr 2 20:26:42 2026 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 945CD350290 for ; Fri, 13 Feb 2026 10:09:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770977363; cv=none; b=gaJiZT7GUJw02KEKZKE2V6RqC5WiWEv8XQMDKudHOuDCltodgWT9I8BpSc/uk4JJhn7swm8ZEbA+dzGDfzVXOCAcMS8jcd/upFxOg8kBs6NfXxYCCem7AJPlUXPOv90Y1VvQHnmKdoxpSGhHAFvcawwQVGA+twy5Kxow8l9Va0M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770977363; c=relaxed/simple; bh=Gmr69WGMLjBvur+7uCQXLHA9odNRHmal7j3YUPNU3ZE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ZGfjNzKJwbNkFuwyc4j/6Q1uM9+Dvjm6Nd+eMmWjDsfzgWgYCKH0MlSNbWiCan/14Y9QaFp+6XGO0KbZOUrLpSyPH2rYU3wG+0qx7pg/jIGgATkTIPawVQAD48zqbaMEVnbqK4OoBWQ3jU35zeg8rTsmvSX263B7nqbycBFFQUs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--guanyulin.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OXmez4S6; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--guanyulin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OXmez4S6" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-29f2381ea85so31802275ad.0 for ; Fri, 13 Feb 2026 02:09:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770977362; x=1771582162; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=iwUi3JIHoNvBN2bDQam1XZ1HxEGtt5ZvqQPmazzonYA=; b=OXmez4S6eASUJ5aMR3jT0QhjgMMB/j1r17AtoH7b7/k9LXKhtRkJps9DU/94QVMyKG Yn/tpCvtYMK9mWddJ5XI82c5c8xX2u1X+akH0OG12Px0ZR2+2KKFzDytj5/lTI4OytEB 2mKy3VF7Djr51lxhjOQ2uQUMRMfLq3hsOU4iq9vCGg7giAIA7Ohi9FvJWOHulylz2cUX +rcnBMVrKBABSBrn61szfXxDSvWm7ipYbA+Q238IPuCYt4xfd2datY+1idCyt9Mo02nW uy0yhKWUQmWDe80aW7byXas9zHgbW1b9pBLHGwAjHz3adgu3ccpCqzv7XT0w7MKim9/k nEPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770977362; x=1771582162; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iwUi3JIHoNvBN2bDQam1XZ1HxEGtt5ZvqQPmazzonYA=; b=T55D5QNEyb+RtR8uT8Ol/AFZQSAGoRs2mWE2qnfUs50tzsWFrUvdiK1bjkxjYgQObl MVytpTzXNBKQeoyXJH90pKnRbX1CA3q+cdk+iizNkfM4GhJpJJGhqfc6CC8ZNHXhWmhw IOnHP5qkaCWHZUzExNy5p218NzUdyF3XvGlVKTOXc6MEDYMeCCvON9A3BJ6Y4W71hpyZ JkkCpmwJLC/lUb8sHAVS6+XNXL0jRFYN3ebwVOy1RDKxmG24YsPeFOgYR0CNYwgwjLUX A8e86r6i9k1q9rNcIEB8owk9E/giQW5dwxuEg4U0F3VOwA/jL7AjiwK+4SjhmZIDeqm5 A8aw== X-Forwarded-Encrypted: i=1; AJvYcCXGARhz0erZESwyhIrWWMfRUm4AM3/QczRhEaxqjwiBzn0ZiHEuahCN2Z93SKHZtGLL8rQiZ0O0TnZXqU0=@vger.kernel.org X-Gm-Message-State: AOJu0YyPgXYnEttlUswlCzxlFvVJaSk0XCTiMMx4YHnj+8kOOtJiLQEb TP8vS5ciO+To9Px0SIcbH6fJynUPaLwcj5+MNLd43Bj3xu14WDKxhVdzBX+K+Q9BpgwRfvmSi9o eafDI5gF4GJ3E1wXnhA== X-Received: from plbje12.prod.google.com ([2002:a17:903:264c:b0:2a7:5a4a:5bc0]) (user=guanyulin job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:b4b:b0:298:5abe:4b1 with SMTP id d9443c01a7336-2ab5062cd61mr14490185ad.52.1770977361891; Fri, 13 Feb 2026 02:09:21 -0800 (PST) Date: Fri, 13 Feb 2026 10:07:35 +0000 In-Reply-To: <20260213100736.2914690-1-guanyulin@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260213100736.2914690-1-guanyulin@google.com> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog Message-ID: <20260213100736.2914690-2-guanyulin@google.com> Subject: [RFC PATCH v2 1/2] usb: offload: move device locking to callers in offload.c From: Guan-Yu Lin To: gregkh@linuxfoundation.org, mathias.nyman@intel.com, perex@perex.cz, tiwai@suse.com, quic_wcheng@quicinc.com, broonie@kernel.org, arnd@arndb.de, harshit.m.mogalapalli@oracle.com, wesley.cheng@oss.qualcomm.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, Guan-Yu Lin , stable@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Update usb_offload_get() and usb_offload_put() to require that the caller holds the USB device lock. Remove the internal call to usb_lock_device() and add device_lock_assert() to ensure synchronization is handled by the caller. These functions continue to manage the device's power state via autoresume/autosuspend and update the offload_usage counter. Additionally, decouple the xHCI sideband interrupter lifecycle from the offload usage counter by removing the calls to usb_offload_get() and usb_offload_put() from the interrupter creation and removal paths. This allows interrupters to be managed independently of the device's offload activity status. Cc: stable@vger.kernel.org Fixes: ef82a4803aab ("xhci: sideband: add api to trace sideband usage") Signed-off-by: Guan-Yu Lin --- drivers/usb/core/offload.c | 34 +++++++++++--------------------- drivers/usb/host/xhci-sideband.c | 14 +------------ 2 files changed, 13 insertions(+), 35 deletions(-) diff --git a/drivers/usb/core/offload.c b/drivers/usb/core/offload.c index 7c699f1b8d2b..e13a4c21d61b 100644 --- a/drivers/usb/core/offload.c +++ b/drivers/usb/core/offload.c @@ -20,6 +20,7 @@ * enabled on this usb_device; that is, another entity is actively handlin= g USB * transfers. This information allows the USB driver to adjust its power * management policy based on offload activity. + * The caller must hold @udev's device lock. * * Return: 0 on success. A negative error code otherwise. */ @@ -27,31 +28,25 @@ int usb_offload_get(struct usb_device *udev) { int ret; =20 - usb_lock_device(udev); - if (udev->state =3D=3D USB_STATE_NOTATTACHED) { - usb_unlock_device(udev); + device_lock_assert(&udev->dev); + + if (udev->state =3D=3D USB_STATE_NOTATTACHED) return -ENODEV; - } =20 if (udev->state =3D=3D USB_STATE_SUSPENDED || - udev->offload_at_suspend) { - usb_unlock_device(udev); + udev->offload_at_suspend) return -EBUSY; - } =20 /* * offload_usage could only be modified when the device is active, since * it will alter the suspend flow of the device. */ ret =3D usb_autoresume_device(udev); - if (ret < 0) { - usb_unlock_device(udev); + if (ret < 0) return ret; - } =20 udev->offload_usage++; usb_autosuspend_device(udev); - usb_unlock_device(udev); =20 return ret; } @@ -64,6 +59,7 @@ EXPORT_SYMBOL_GPL(usb_offload_get); * The inverse operation of usb_offload_get, which drops the offload_usage= of * a USB device. This information allows the USB driver to adjust its power * management policy based on offload activity. + * The caller must hold @udev's device lock. * * Return: 0 on success. A negative error code otherwise. */ @@ -71,33 +67,27 @@ int usb_offload_put(struct usb_device *udev) { int ret; =20 - usb_lock_device(udev); - if (udev->state =3D=3D USB_STATE_NOTATTACHED) { - usb_unlock_device(udev); + device_lock_assert(&udev->dev); + + if (udev->state =3D=3D USB_STATE_NOTATTACHED) return -ENODEV; - } =20 if (udev->state =3D=3D USB_STATE_SUSPENDED || - udev->offload_at_suspend) { - usb_unlock_device(udev); + udev->offload_at_suspend) return -EBUSY; - } =20 /* * offload_usage could only be modified when the device is active, since * it will alter the suspend flow of the device. */ ret =3D usb_autoresume_device(udev); - if (ret < 0) { - usb_unlock_device(udev); + if (ret < 0) return ret; - } =20 /* Drop the count when it wasn't 0, ignore the operation otherwise. */ if (udev->offload_usage) udev->offload_usage--; usb_autosuspend_device(udev); - usb_unlock_device(udev); =20 return ret; } diff --git a/drivers/usb/host/xhci-sideband.c b/drivers/usb/host/xhci-sideb= and.c index 2bd77255032b..6fc0ad658d66 100644 --- a/drivers/usb/host/xhci-sideband.c +++ b/drivers/usb/host/xhci-sideband.c @@ -93,8 +93,6 @@ __xhci_sideband_remove_endpoint(struct xhci_sideband *sb,= struct xhci_virt_ep *e static void __xhci_sideband_remove_interrupter(struct xhci_sideband *sb) { - struct usb_device *udev; - lockdep_assert_held(&sb->mutex); =20 if (!sb->ir) @@ -102,10 +100,6 @@ __xhci_sideband_remove_interrupter(struct xhci_sideban= d *sb) =20 xhci_remove_secondary_interrupter(xhci_to_hcd(sb->xhci), sb->ir); sb->ir =3D NULL; - udev =3D sb->vdev->udev; - - if (udev->state !=3D USB_STATE_NOTATTACHED) - usb_offload_put(udev); } =20 /* sideband api functions */ @@ -328,9 +322,6 @@ int xhci_sideband_create_interrupter(struct xhci_sideband *sb, int num_seg, bool ip_autoclear, u32 imod_interval, int intr_num) { - int ret =3D 0; - struct usb_device *udev; - if (!sb || !sb->xhci) return -ENODEV; =20 @@ -348,12 +339,9 @@ xhci_sideband_create_interrupter(struct xhci_sideband = *sb, int num_seg, if (!sb->ir) return -ENOMEM; =20 - udev =3D sb->vdev->udev; - ret =3D usb_offload_get(udev); - sb->ir->ip_autoclear =3D ip_autoclear; =20 - return ret; + return 0; } EXPORT_SYMBOL_GPL(xhci_sideband_create_interrupter); =20 --=20 2.53.0.273.g2a3d683680-goog From nobody Thu Apr 2 20:26:42 2026 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA05134F46A for ; Fri, 13 Feb 2026 10:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770977368; cv=none; b=fUkmdrfzzh6wqWdfJO7+6b16B/+NqCzr2T7MiA9/SBTeH+VShRIUsdR9EzrqjyANSQ405AG12siHUb1GdpX+rfu+dRN1Alszu7qhR5M9gKtm1+NV6detTF7QZv5eIIv+cc+uvKyn2MYWyZj4QugTQTdLqp9U2Kwqo52GCUjUHms= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770977368; c=relaxed/simple; bh=nEMCIOnsanEJMnLYmB5e41nP6UMT7vo619hj5X6ToIQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Lm+JU7D1E21wxhX2eYxIN0ecAmOknksDlURURK4BGymPRyqK0gDRuB+tH9Fse5kCwWYd+qvyRYZYCylX5nrylWUN3zgYpj6UF4bZ1U8j+GuLMUEv3zLBERMyVbAr1tI+jCKLj9l87ZgaIL0U4F7XHkQhXin6/cqKqMfQIPHjn0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--guanyulin.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qrRATXF/; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--guanyulin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qrRATXF/" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-354c44bf176so872112a91.0 for ; Fri, 13 Feb 2026 02:09:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770977365; x=1771582165; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=6H578zF40bIvw0kW2/BZM5eR8EPStj53jblRqAXiqY4=; b=qrRATXF/DSXdU5UJqW3LPIGgJIjEkRjTN89lmtG8kzDeaVlcTM9S9JQfUKnaSqYbJ/ wBDPU7ZBCc365c0JAoPccaWcOJgCXDHTSnZebvwPuChdTSAAWxILFscDniFsqXPawIpn ed46QkXBKjKjt/W51iU52UB1FevqK+yT5JflHmH3s+DfsXSHxy5+WKfaQ8aXA9K249pq jw+Z5BFrU3IcHwG5EZMVPIexP4NS3xc3Y/l+qCt6KzPMTmi6RXQzqhWjPyIwPZCDB0UT 9LOSE5PKkOiw28RdCcMLYlRVIB8xZRdxODfseQnfGyzNnX3eNatbCkKgX8Dr7s5Mk3jB l9sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770977365; x=1771582165; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6H578zF40bIvw0kW2/BZM5eR8EPStj53jblRqAXiqY4=; b=daepmR9m8s6mw+16PN4Jzv6zdfjpE4xQjCeNmZ9Zcy731a0k0KeD2/JWPSiWEGvng2 KOQq53qwT4QVTuh+rwTCAAQMX4bzBQ4bmIlneHdGwcWtTOFTBryzbZveUDVinzku84uU aX3lYxS2z6a2sVBtzif38ptC9RsSy0AfggjqeUnFFpHTXePuMq1BW++vrb4JZB+q3kpJ IPndC7G9L8mNv77S0AXBMBSl1fyP+o1QoYh5zJWa4Eh8iWSBfanEBdFmh3RQpXO7UWMx 8Di/vdVY/uwzmjOL/Po4vK5RTx6OmTqze15fwNOvf6a0AESiVqg2KVQAD4F/cQx/r8Y4 CFzQ== X-Forwarded-Encrypted: i=1; AJvYcCXInAkLZzvgbpVR2BsKEnOdGJn9uKXXuhW1WqswF+zu1iO9ignms8KU6yGlD7yQ0umznJV8EA+9C0o6TII=@vger.kernel.org X-Gm-Message-State: AOJu0YwHkwYHlh77XPC1eYe0R2dcieLPYydpS+GXL3LpiAjs92X+ziYV E0XhzjvN5T4IbfP7ZOmLr3L6ytnm+i1vR0DdFUNn5SaA11u+uepjMCHBO1nBk8dIT8C9ZVJvx3t nJdATISH2gM+7DY+dxg== X-Received: from pjbbx10.prod.google.com ([2002:a17:90a:f48a:b0:356:28cb:9650]) (user=guanyulin job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5550:b0:354:a065:ec3e with SMTP id 98e67ed59e1d1-356aad900fbmr1526714a91.26.1770977364914; Fri, 13 Feb 2026 02:09:24 -0800 (PST) Date: Fri, 13 Feb 2026 10:07:36 +0000 In-Reply-To: <20260213100736.2914690-1-guanyulin@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260213100736.2914690-1-guanyulin@google.com> X-Mailer: git-send-email 2.53.0.273.g2a3d683680-goog Message-ID: <20260213100736.2914690-3-guanyulin@google.com> Subject: [RFC PATCH v2 2/2] ALSA: usb: qcom: manage offload device usage From: Guan-Yu Lin To: gregkh@linuxfoundation.org, mathias.nyman@intel.com, perex@perex.cz, tiwai@suse.com, quic_wcheng@quicinc.com, broonie@kernel.org, arnd@arndb.de, harshit.m.mogalapalli@oracle.com, wesley.cheng@oss.qualcomm.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, Guan-Yu Lin , stable@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Qualcomm USB audio offload driver currently does not report its offload activity to the USB core. This prevents the USB core from properly tracking active offload sessions, which could allow the device to auto-suspend while audio offloading is in progress. Integrate usb_offload_get() and usb_offload_put() calls into the offload stream setup and teardown paths. Specifically, call usb_offload_get() when initializing the event ring and usb_offload_put() when freeing it. Since the updated usb_offload_get() and usb_offload_put() APIs require the caller to hold the USB device lock, add the necessary device locking in handle_uaudio_stream_req() and qmi_stop_session() to satisfy this requirement. Cc: stable@vger.kernel.org Fixes: ef82a4803aab ("xhci: sideband: add api to trace sideband usage") Signed-off-by: Guan-Yu Lin --- sound/usb/qcom/qc_audio_offload.c | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/sound/usb/qcom/qc_audio_offload.c b/sound/usb/qcom/qc_audio_of= fload.c index cfb30a195364..6bcb6033e688 100644 --- a/sound/usb/qcom/qc_audio_offload.c +++ b/sound/usb/qcom/qc_audio_offload.c @@ -699,6 +699,7 @@ static void uaudio_event_ring_cleanup_free(struct uaudi= o_dev *dev) uaudio_iommu_unmap(MEM_EVENT_RING, IOVA_BASE, PAGE_SIZE, PAGE_SIZE); xhci_sideband_remove_interrupter(uadev[dev->chip->card->number].sb); + usb_offload_put(dev->udev); } } =20 @@ -750,6 +751,7 @@ static void qmi_stop_session(void) struct snd_usb_substream *subs; struct usb_host_endpoint *ep; struct snd_usb_audio *chip; + struct usb_device *udev; struct intf_info *info; int pcm_card_num; int if_idx; @@ -791,8 +793,13 @@ static void qmi_stop_session(void) disable_audio_stream(subs); } atomic_set(&uadev[idx].in_use, 0); - guard(mutex)(&chip->mutex); - uaudio_dev_cleanup(&uadev[idx]); + + udev =3D uadev[idx].udev; + if (udev) { + guard(device)(&udev->dev); + guard(mutex)(&chip->mutex); + uaudio_dev_cleanup(&uadev[idx]); + } } } =20 @@ -1183,11 +1190,15 @@ static int uaudio_event_ring_setup(struct snd_usb_s= ubstream *subs, er_pa =3D 0; =20 /* event ring */ + ret =3D usb_offload_get(subs->dev); + if (ret < 0) + goto exit; + ret =3D xhci_sideband_create_interrupter(uadev[card_num].sb, 1, false, 0, uaudio_qdev->data->intr_num); if (ret < 0) { dev_err(&subs->dev->dev, "failed to fetch interrupter\n"); - goto exit; + goto put_offload; } =20 sgt =3D xhci_sideband_get_event_buffer(uadev[card_num].sb); @@ -1219,6 +1230,8 @@ static int uaudio_event_ring_setup(struct snd_usb_sub= stream *subs, mem_info->dma =3D 0; remove_interrupter: xhci_sideband_remove_interrupter(uadev[card_num].sb); +put_offload: + usb_offload_put(subs->dev); exit: return ret; } @@ -1483,6 +1496,7 @@ static int prepare_qmi_response(struct snd_usb_substr= eam *subs, uaudio_iommu_unmap(MEM_EVENT_RING, IOVA_BASE, PAGE_SIZE, PAGE_SIZE); free_sec_ring: xhci_sideband_remove_interrupter(uadev[card_num].sb); + usb_offload_put(subs->dev); drop_sync_ep: if (subs->sync_endpoint) { uaudio_iommu_unmap(MEM_XFER_RING, @@ -1528,6 +1542,7 @@ static void handle_uaudio_stream_req(struct qmi_handl= e *handle, u8 pcm_card_num; u8 pcm_dev_num; u8 direction; + struct usb_device *udev =3D NULL; int ret =3D 0; =20 if (!svc->client_connected) { @@ -1597,6 +1612,8 @@ static void handle_uaudio_stream_req(struct qmi_handl= e *handle, =20 uadev[pcm_card_num].ctrl_intf =3D chip->ctrl_intf; =20 + udev =3D subs->dev; + guard(device)(&udev->dev); if (req_msg->enable) { ret =3D enable_audio_stream(subs, map_pcm_format(req_msg->audio_format), --=20 2.53.0.273.g2a3d683680-goog