From nobody Thu Apr 2 21:51:46 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27FAD52F88 for ; Fri, 13 Feb 2026 00:15:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770941720; cv=none; b=VcOte1E3cxObcSCZ7/Pm8TnGfEHU/S7FEoDR1aWMnEl0ZLgFL46l0Ar3I3dk3QCh4HfcnV+6jxM9LKHeD3mWA3Rf+4ZRSWmmGycvJt47BwVmXIKnRy52YaquTkWRwBE8GzCdlJhejOSojfRoGABgNMcKc9+SqTOU5UYym3IZOCg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770941720; c=relaxed/simple; bh=MBxXvm9SN85wIbPQozevHNwhIzjPtliVSJlxB+6iP8A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jV9yp9O4xIVDHxQWgxWKpoX0TJMY4yaiIPYEYZNVXf4U3iRcyyl1TeeIY8HsbCp25FT1wWiEWhWJ6qyP2sRfnSicjHeMtp+M2uBNAmhyK83EAIQ2xV7dykULrCIIvxnDoIstinh+cEQIFQZ+Diw9mtsolw1IMpTHQZqgMNqd0mI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=DZ67Pj5r; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="DZ67Pj5r" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-480142406b3so3048085e9.1 for ; Thu, 12 Feb 2026 16:15:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1770941718; x=1771546518; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nkpDAlBYfnDGxcVrWynzmo5K/OoXZi98TxFwnjNQDvI=; b=DZ67Pj5r2NRtJDLbAF9tPO3yboADCvKntmnCV3l2o5HoXxZ75Uj4Fd7+7+V/muCkwJ +v+6ssbzcnMjx3XharQrFOl6hhsYACYZCgUk0LY2QodGaIJe+clwHGOMnzo54k0zXHYQ pDYbOo9g+X+n3ArPujQ95PcaVVrAp23FnUMEBmXc5LoIEV01uapMz/hc1eWZl9S9DWzO ddcYq+yv9UcHEa1j1yuenQCglpBp5DV+5sIu0BZfKEzW0aAL76HKlPPcEsxdm/XAWc9B 4hXLKDfpid/OCcSH4seyE3WiMz4W+TjKnt+4nM9opoFKm8sEFAgwJ+ixbgvH2KnfhaOh Xr2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770941718; x=1771546518; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nkpDAlBYfnDGxcVrWynzmo5K/OoXZi98TxFwnjNQDvI=; b=Kiydph8K08S7BDoFHxbJY2Szj29lQirVcDQFtSicWJYRYWyh5UETcYD3Y1K7nbVnC8 ZcHV+z4tKq5ey5RQj2USQRlHGcGgb0/BR7ULfvdFvWMi3AGLyjAESQ3TNRyQHBWd83UA OOV0mMJPFUWsI57zpBlOppAq/L5zCIqVN93ug1AWTuyjguGqXXq/FByR6NxjMOJft21L wIumxBXQZrU1tdhAAHeenwrnUVIYsNZ10j2sOH3hZtRHuFx98zZxcNBqyQeHsRRfhzU5 xZKwFPp7E12w79im5TuY552ac6J9fbZzbDF3w7DWbM/H+h+5hz63QYJY+hVL4BhkHWAi d2Mg== X-Forwarded-Encrypted: i=1; AJvYcCWxnhTJApciugq1pbIKXdk3j6rWu7rEf+T+/Jc6nblMoTPpqnz3kMkEkCTHAeXSNuky8f52qHw1ZgcaYbM=@vger.kernel.org X-Gm-Message-State: AOJu0YyyDrsFniacF+RS+TThFDjOVtgXGLSJZjEk44UsbK7LG0eWas0p EeYKnyMMX8E6tWTGDHhPPNY9JDvWhJu3redk31H2d5STgLbwLCLr3l1Ekr6cmM07294= X-Gm-Gg: AZuq6aIQr64MMl0Z0026WWMVdmecGTr3B0+XGwopL2bZHvdBaw9514sbXzdWwnR6m4j p50y31RBB18x8pTwxeJXeChRVLzRj/I7ifAljqvxfBlP1cFo/231HzhKysivxgqYa+TxP4JDp5M QABoT4Adr9MfpH1mC0vuwjSk3AKUdHOzD6KNDU62iiCGYocVIWJKHePJ+MCXMFswBYILikqXLEN 6YYdtLKW0q59w5DDXfiV91ReUjHLKKxvgvB6x1pqUXC9zVD0ubpMqxCkBngJL2Ekv/KA0SItPsR /bK22w+U69mpYjXIWNfjhwV5FrKcETq8VYBBmKIf0rlVdi2TpUNGXByF2MqYYIoyvvrf2vGSH6p V4LYAN1h+3Q6y3sjo5flEYHnRq5UVwgqw53FjzcjLQU8nf948IuxoS8RKVZYPhT+5u/csEDuVa/ qelI1Wz3Bz1gPHA3XKzjCpqbJw0VErYDZ05wPw7ja5tfs+qm//meVQzLAk+z22e9Jds9yuqrpak lFD//awgQ== X-Received: by 2002:a05:600c:1381:b0:483:ea6:8767 with SMTP id 5b1f17b1804b1-48371098c8dmr12349945e9.36.1770941717627; Thu, 12 Feb 2026 16:15:17 -0800 (PST) Received: from silence.. ([46.10.240.40]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4835d99497asm234440945e9.6.2026.02.12.16.15.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 16:15:17 -0800 (PST) From: Stoyan Bogdanov To: jbrunet@baylibre.com, linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Stoyan Bogdanov Subject: [PATCH v2 1/3] hwmon: (pmbus/tps25990): Rework TPS25990 non standatd direct conversion Date: Fri, 13 Feb 2026 02:14:06 +0200 Message-Id: <20260213001408.2454567-2-sbogdanov@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260213001408.2454567-1-sbogdanov@baylibre.com> References: <20260213001408.2454567-1-sbogdanov@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rework existing implementation for calculation of direct format conversion for TPS25990. With this implamentation is leveraged code reusability for non standard parameters. - Add enum for parameter - Add m, b, R structure to hold value per device - Add data structure to hold for pmbus_driver_info and local_direct_values - Conversion functions are implemented according to formula from TPS25990 datasheet - Remove previously used defines replace with structure Signed-off-by: Stoyan Bogdanov --- drivers/hwmon/pmbus/tps25990.c | 115 +++++++++++++++++++++++++-------- 1 file changed, 88 insertions(+), 27 deletions(-) diff --git a/drivers/hwmon/pmbus/tps25990.c b/drivers/hwmon/pmbus/tps25990.c index c13edd7e1abf..33f6367f797c 100644 --- a/drivers/hwmon/pmbus/tps25990.c +++ b/drivers/hwmon/pmbus/tps25990.c @@ -36,17 +36,58 @@ #define TPS25990_UNLOCKED BIT(7) =20 #define TPS25990_8B_SHIFT 2 -#define TPS25990_VIN_OVF_NUM 525100 -#define TPS25990_VIN_OVF_DIV 10163 -#define TPS25990_VIN_OVF_OFF 155 -#define TPS25990_IIN_OCF_NUM 953800 -#define TPS25990_IIN_OCF_DIV 129278 -#define TPS25990_IIN_OCF_OFF 157 =20 #define PK_MIN_AVG_RST_MASK (PK_MIN_AVG_RST_PEAK | \ PK_MIN_AVG_RST_AVG | \ PK_MIN_AVG_RST_MIN) =20 +enum tps25990_parameters { + TPS25990_VIN_OVF =3D 0, /* VIN over volatage fault */ + TPS25990_IIN_OCF, /* IIN Over currect fault */ + TPS25590_DIRECT_VALUES_MAX, /* Max value ensure there enough space */ +}; + +struct local_direct_value { + int m[TPS25590_DIRECT_VALUES_MAX]; /* mantissa for direct data format */ + int b[TPS25590_DIRECT_VALUES_MAX]; /* offset */ + int R[TPS25590_DIRECT_VALUES_MAX]; /* exponent */ +}; + +struct tps25990_data { + struct pmbus_driver_info *info; + struct local_direct_value *info_local; +}; + +static int tps25990_raw_to_value(struct i2c_client *client, int param, int= raw) +{ + struct tps25990_data *data =3D (struct tps25990_data *)of_device_get_matc= h_data(&client->dev); + struct local_direct_value *info_local =3D data->info_local; + + /* Formula : X =3D (Y / 10^R - b) / m */ + if (info_local->R[param] >=3D 0) + raw /=3D int_pow(10, info_local->R[param]); + else + raw *=3D int_pow(10, -info_local->R[param]); + + return DIV_ROUND_CLOSEST(raw - info_local->b[param], info_local->m[param]= ); +} + +static unsigned int tps25990_value_to_raw(struct i2c_client *client, int p= aram, int val) +{ + struct tps25990_data *data =3D (struct tps25990_data *)of_device_get_matc= h_data(&client->dev); + struct local_direct_value *info_local =3D data->info_local; + + /* Formula : Y =3D ( m * X + b) * 10^R */ + val =3D (long)val * info_local->m[param] + info_local->b[param]; + + if (info_local->R[param] >=3D 0) + val *=3D int_pow(10, info_local->R[param]); + else + val =3D DIV_ROUND_CLOSEST(val, int_pow(10, -info_local->R[param])); + + return val; +} + /* * Arbitrary default Rimon value: 1kOhm * This correspond to an overcurrent limit of 55A, close to the specified = limit @@ -184,9 +225,7 @@ static int tps25990_read_word_data(struct i2c_client *c= lient, ret =3D pmbus_read_word_data(client, page, phase, reg); if (ret < 0) break; - ret =3D DIV_ROUND_CLOSEST(ret * TPS25990_VIN_OVF_NUM, - TPS25990_VIN_OVF_DIV); - ret +=3D TPS25990_VIN_OVF_OFF; + ret =3D tps25990_raw_to_value(client, TPS25990_VIN_OVF, ret); break; =20 case PMBUS_IIN_OC_FAULT_LIMIT: @@ -198,9 +237,7 @@ static int tps25990_read_word_data(struct i2c_client *c= lient, ret =3D pmbus_read_byte_data(client, page, TPS25990_VIREF); if (ret < 0) break; - ret =3D DIV_ROUND_CLOSEST(ret * TPS25990_IIN_OCF_NUM, - TPS25990_IIN_OCF_DIV); - ret +=3D TPS25990_IIN_OCF_OFF; + ret =3D tps25990_raw_to_value(client, TPS25990_IIN_OCF, ret); break; =20 case PMBUS_VIRT_SAMPLES: @@ -246,17 +283,13 @@ static int tps25990_write_word_data(struct i2c_client= *client, break; =20 case PMBUS_VIN_OV_FAULT_LIMIT: - value -=3D TPS25990_VIN_OVF_OFF; - value =3D DIV_ROUND_CLOSEST(((unsigned int)value) * TPS25990_VIN_OVF_DIV, - TPS25990_VIN_OVF_NUM); + value =3D tps25990_value_to_raw(client, TPS25990_VIN_OVF, value); value =3D clamp_val(value, 0, 0xf); ret =3D pmbus_write_word_data(client, page, reg, value); break; =20 case PMBUS_IIN_OC_FAULT_LIMIT: - value -=3D TPS25990_IIN_OCF_OFF; - value =3D DIV_ROUND_CLOSEST(((unsigned int)value) * TPS25990_IIN_OCF_DIV, - TPS25990_IIN_OCF_NUM); + value =3D tps25990_value_to_raw(client, TPS25990_IIN_OCF, value); value =3D clamp_val(value, 0, 0x3f); ret =3D pmbus_write_byte_data(client, page, TPS25990_VIREF, value); break; @@ -337,7 +370,16 @@ static const struct regulator_desc tps25990_reg_desc[]= =3D { }; #endif =20 -static const struct pmbus_driver_info tps25990_base_info =3D { +struct local_direct_value tps25590_local_info =3D { + .m[TPS25990_VIN_OVF] =3D 10163, + .b[TPS25990_VIN_OVF] =3D -30081, + .R[TPS25990_VIN_OVF] =3D -4, + .m[TPS25990_IIN_OCF] =3D 9538, + .b[TPS25990_IIN_OCF] =3D 0, + .R[TPS25990_IIN_OCF] =3D -6, +}; + +static struct pmbus_driver_info tps25990_base_info =3D { .pages =3D 1, .format[PSC_VOLTAGE_IN] =3D direct, .m[PSC_VOLTAGE_IN] =3D 5251, @@ -386,14 +428,19 @@ static const struct pmbus_driver_info tps25990_base_i= nfo =3D { #endif }; =20 +struct tps25990_data data_tps25990 =3D { + .info =3D &tps25990_base_info, + .info_local =3D &tps25590_local_info, +}; + static const struct i2c_device_id tps25990_i2c_id[] =3D { - { "tps25990" }, + { .name =3D "tps25990", .driver_data =3D (kernel_ulong_t)&data_tps25990 }, {} }; MODULE_DEVICE_TABLE(i2c, tps25990_i2c_id); =20 static const struct of_device_id tps25990_of_match[] =3D { - { .compatible =3D "ti,tps25990" }, + { .compatible =3D "ti,tps25990", .data =3D &data_tps25990 }, {} }; MODULE_DEVICE_TABLE(of, tps25990_of_match); @@ -401,23 +448,37 @@ MODULE_DEVICE_TABLE(of, tps25990_of_match); static int tps25990_probe(struct i2c_client *client) { struct device *dev =3D &client->dev; - struct pmbus_driver_info *info; + struct tps25990_data *data; u32 rimon =3D TPS25990_DEFAULT_RIMON; + struct pmbus_driver_info *info_get; + struct local_direct_value *info_local_get; int ret; =20 ret =3D device_property_read_u32(dev, "ti,rimon-micro-ohms", &rimon); if (ret < 0 && ret !=3D -EINVAL) return dev_err_probe(dev, ret, "failed to get rimon\n"); =20 - info =3D devm_kmemdup(dev, &tps25990_base_info, sizeof(*info), GFP_KERNEL= ); - if (!info) + data =3D (struct tps25990_data *)of_device_get_match_data(dev); + if (!data) + return -EOPNOTSUPP; + + info_get =3D data->info; + /* Make copy of pmbus_info and replace it to preserve original values */ + data->info =3D devm_kmemdup(dev, info_get, sizeof(*info_get), GFP_KERNEL); + if (!data->info) + return -ENOMEM; + + info_local_get =3D data->info_local; + /* Make copy of pmbus_info and replace it to preserve original values */ + data->info_local =3D devm_kmemdup(dev, info_local_get, sizeof(*info_local= _get), GFP_KERNEL); + if (!data->info_local) return -ENOMEM; =20 /* Adapt the current and power scale for each instance */ - tps25990_set_m(&info->m[PSC_CURRENT_IN], rimon); - tps25990_set_m(&info->m[PSC_POWER], rimon); + tps25990_set_m(&data->info->m[PSC_CURRENT_IN], rimon); + tps25990_set_m(&data->info->m[PSC_POWER], rimon); =20 - return pmbus_do_probe(client, info); + return pmbus_do_probe(client, data->info); } =20 static struct i2c_driver tps25990_driver =3D { --=20 2.34.1